[GitHub] brooklyn-server pull request #361: Add disable flag to shared sg customizer

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/361


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #361: Add disable flag to shared sg customizer

[duncangrant]

Github user duncangrant commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/361#discussion_r81350227
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
 ---
@@ -106,8 +115,17 @@ public void setCidr(String cidr) {
 this.cidr = cidr;
 }
 
+/**
+ * @param enableSharedSG set to false to disable this customizer
+ */
+public void setEnableSharedSG(boolean enableSharedSG) {
--- End diff --

Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #361: Add disable flag to shared sg customizer

[aledsage]

Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/361#discussion_r81332824
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
 ---
@@ -106,8 +115,17 @@ public void setCidr(String cidr) {
 this.cidr = cidr;
 }
 
+/**
+ * @param enableSharedSG set to false to disable this customizer
+ */
+public void setEnableSharedSG(boolean enableSharedSG) {
--- End diff --

Maybe just call this `setEnabled()`? Possibly mark it as `@Beta`? No strong 
feelings from me though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #361: Add disable flag to shared sg customizer

[duncangrant]

GitHub user duncangrant opened a pull request:

https://github.com/apache/brooklyn-server/pull/361

Add disable flag to shared sg customizer

This flag allows the shared sg to be disabled in yaml

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/duncangrant/brooklyn-server 
add-disable-flag-shared-sg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #361


commit 09bed4940ffad6c9c4bbab3adafa28eabbb78f87
Author: Duncan Grant 
Date:   2016-09-30T12:45:39Z

Add disable flag to shared sg customizer

This flag allows the shared sg to be disabled in yaml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---