[GitHub] brooklyn-server pull request #362: bump httpcomponents versions
Github user ahgittin closed the pull request at: https://github.com/apache/brooklyn-server/pull/362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] brooklyn-server pull request #362: bump httpcomponents versions
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/362#discussion_r94937432
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -51,8 +51,8 @@
mvn:commons-codec/commons-codec/${commons-codec.version}
mvn:org.slf4j/jul-to-slf4j/${slf4j.version}
mvn:org.yaml/snakeyaml/${snakeyaml.version}
-mvn:org.apache.httpcomponents/httpcore-osgi/${httpclient.version}
-mvn:org.apache.httpcomponents/httpclient-osgi/${httpclient.version}
+mvn:org.apache.httpcomponents/httpcore-osgi/${httpclient.httpcore.version}
--- End diff --
Should this not be `${httpcomponents.httpcore.version}` (and the line below
`httpcomponents.httpclient.version`)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #362: bump httpcomponents versions
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/362 bump httpcomponents versions note core and client are no longer kept in sync; latest version of each has been taken this seems to fix strange problems with `HttpRequestSensorYamlTest` failing in maven but working in eclipse, presumably due to use of `TestHttpServer` using these components. it does not however fix the JVM crash in that test under java 7 sadly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ahgittin/brooklyn-server bump-httpcomponents-versions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-server/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit da2453de7a50ba05f7443d32ecbd01e522425fa6 Author: Alex Heneveld Date: 2016-09-30T13:19:10Z bump httpcomponents versions note core and client are no longer kept in sync; latest version of each has been taken --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
