[GitHub] brooklyn-ui issue #88: Allow to resolve different virtual type according to ...
Github user ludop-usharesoft commented on the issue: https://github.com/apache/brooklyn-ui/pull/88 @tbouron ok, here it is. Thanks ! ---
[GitHub] brooklyn-ui issue #88: Allow to resolve different virtual type according to ...
Github user ludop-usharesoft commented on the issue: https://github.com/apache/brooklyn-ui/pull/88 For the getBundleType method, I have currently use the "bundleVersion" parameter to pass the appliance reference. So for now it's working without adding the config parameter to it, but yeah it's look like a hack so it's probably not the cleaner way to do that. However "paletteApi.getBundleType" method is also called from main.controller.js and I don't know exactly in which case. Maybe it can be a problem not to have the entity.config available there if we modify the getBundleType prototype. ---
[GitHub] brooklyn-ui issue #88: Allow to resolve different virtual type according to ...
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/88 I'm not following your suggestion @ahgittin, could you develop on that please? ---
[GitHub] brooklyn-ui issue #88: Allow to resolve different virtual type according to ...
Github user ludop-usharesoft commented on the issue: https://github.com/apache/brooklyn-ui/pull/88 Hi Alex. Yes I have already signed and sent the ICLA to secret...@apache.org (on the 14th of June 2018 with my usharesoft email if you need to search it). Thanks ! ---
[GitHub] brooklyn-ui issue #88: Allow to resolve different virtual type according to ...
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/88 looks good @ludop-usharesoft do we have an ICLA on file for you? good to merge IMO once that's confirmed. as an aside cc @tbouron i wonder if we should store as UI metadata -- probably in the YAML blueprint -- the virtual type, rather than look it up fresh each time. not urgent but something to ponder... ---
