Re: Is it safa to include valgrind.h?
Hi - > On Sep 2, 2019, at 10:59 PM, tan zhongyi wrote: > > Hi, kevin & JB & von, > > We have included one file named as valgrind.h under brpc’s source code. > > https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/LICENSE > https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/valgrind.h > > According to its license statement, valgrind.h is released under BSD style > license, > Other part of valgrind is released under GPL v2. > > But we only include valgrind.h and its license file. > > And I also get its original version as > https://github.com/svn2github/valgrind/blob/master/include/valgrind.h You should include this version of the header file. You need to incorporate the BSD license in the overall LICENSE for Doris with a heading pointing to the header file in the Doris source. > > we will include them in our next apache release > So it looks that it is safe for us to include valgrind.h and its License in > brpc’s source tarball, > right? Is valgrind a dependency in any way? If so then this is a different issue. Regards, Dave > > Please help us to confirm, thanks > > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] NetWilliam closed issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译
NetWilliam closed issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译 URL: https://github.com/apache/incubator-brpc/issues/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] NetWilliam commented on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译
NetWilliam commented on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译 URL: https://github.com/apache/incubator-brpc/issues/901#issuecomment-527336351 找到原因了, 因为我的系统上装了几个版本的protobuf 这个链接链接到了老的版本, 删掉就好了 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] yuhao600 opened a new issue #918: listen port supports customized listener
yuhao600 opened a new issue #918: listen port supports customized listener URL: https://github.com/apache/incubator-brpc/issues/918 The current implementation uses a const listen sockfd. Sometimes the listener needs a customized one. The currently used one could be used as default, so that the users who don't need customized listener don't need to modify code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Is it safa to include valgrind.h?
Hi, kevin & JB & von, We have included one file named as valgrind.h under brpc’s source code. https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/LICENSE https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/valgrind.h According to its license statement, valgrind.h is released under BSD style license, Other part of valgrind is released under GPL v2. But we only include valgrind.h and its license file. And I also get its original version as https://github.com/svn2github/valgrind/blob/master/include/valgrind.h we will include them in our next apache release So it looks that it is safe for us to include valgrind.h and its License in brpc’s source tarball, right? Please help us to confirm, thanks
