[GitHub] [incubator-brpc] leaf-potato commented on issue #1991: support https alpn

2023-01-09 Thread GitBox


leaf-potato commented on issue #1991:
URL: 
https://github.com/apache/incubator-brpc/issues/1991#issuecomment-1375729393

   @wwbmmm 
Client端的实现有几个问题想请教下:目前考虑的是在`ChannelSSLOptions`中新增ALPN的配置,在TLS协商成功后覆盖`ChannelOptions.protocol`字段进行后续的数据发送。
   
   
Q1:`Channel.Init()`方法并不会实际建立连接,这样在初始化阶段并不知道需要使用哪种协议。而在`Channel.CallMethod()`方法调用Socket发送数据前,函数内已经有根据protocol值的特殊逻辑处理。这样的话是否可以在在`Init`就进行TLS握手确定使用的协议?或者还有其他比较好的办法吗?
   
   
Q2:由于protocol是针对下游整体而言的,当下游是集群时,某个下游(ip:port)协商成功了是否就可以认为是整个集群的结果?以及后续连接断开重连(连接池)是否可以直接复用之前的协商结果?
   
   
Q3:除了普通的Channel,考虑到ParallelChannel、SelectiveChannel等其他Channel也有可能需要涉及到ALPN,是否可以将协商功能实现在ChannelBase中?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] leaf-potato commented on issue #1991: support https alpn

2022-12-29 Thread GitBox


leaf-potato commented on issue #1991:
URL: 
https://github.com/apache/incubator-brpc/issues/1991#issuecomment-1367230634

   @wwbmmm 对这个需求比较感兴趣,想尝试去实现,提PR的话社区是否会考虑合入呢


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] leaf-potato commented on issue #1991: support https alpn

2022-12-27 Thread GitBox


leaf-potato commented on issue #1991:
URL: 
https://github.com/apache/incubator-brpc/issues/1991#issuecomment-1365971073

   比较好奇,rpc什么场景下需要协议版本的协商呢?发送或者接受某一方为类似nginx这样的http服务?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org