[GitHub] [incubator-brpc] haolujun closed issue #767: 使用redis客户端时奇怪的200ms问题
haolujun closed issue #767: 使用redis客户端时奇怪的200ms问题 URL: https://github.com/apache/incubator-brpc/issues/767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] haolujun commented on issue #767: 使用redis客户端时奇怪的200ms问题
haolujun commented on issue #767: 使用redis客户端时奇怪的200ms问题 URL: https://github.com/apache/incubator-brpc/issues/767#issuecomment-522968251 > 看一下机器的 tcp 重传监控，是否tcp重传很高 。 200ms看起来是触发了 tcp重传 导致部分请求+200ms 是的，应该是网络流量大，有偶尔的丢包现象，导致触发tcp重传，重传是的ttl最小值一般为200ms。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
jamesge commented on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？ URL: https://github.com/apache/incubator-brpc/issues/896#issuecomment-522974958 https://github.com/apache/incubator-brpc/blob/8c32109de6d697f4c14bf808e19f251fb3a47e9d/src/brpc/details/http_message.cpp#L164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on issue #893: fix bug: bthread_cond_timedwait not return when timeout
jamesge commented on issue #893: fix bug: bthread_cond_timedwait not return when timeout URL: https://github.com/apache/incubator-brpc/pull/893#issuecomment-522977038 看下 #617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Re-bin edited a comment on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
Re-bin edited a comment on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
URL: https://github.com/apache/incubator-brpc/issues/896#issuecomment-522983524
>
https://github.com/apache/incubator-brpc/blob/8c32109de6d697f4c14bf808e19f251fb3a47e9d/src/brpc/details/http_message.cpp#L164
多谢大佬，还向问一下这个实例，里面的controller也能获得uri数据，也是通过上述的办法嘛？对这个地方有一些疑惑，还望不吝赐教。(代码源于Baidu开源的AnyQ)
`void HttpServiceImpl::anyq(google::protobuf::RpcController* cntl_base,
const HttpRequest* request,
HttpResponse*,
google::protobuf::Closure* done) {
brpc::ClosureGuard done_guard(done);
brpc::Controller* cntl = static_cast(cntl_base);
cntl->http_response().set_content_type("application/json;charset=utf8");
Json::Value parameters;
if (this->normalize_input(cntl, parameters) != 0
|| parameters.type() != Json::objectValue) {
FATAL_LOG("normalize input failed!");
return;
}
std::string str_anyq_input;
if (_preproc_plugin->process(cntl, parameters, str_anyq_input) != 0) {
FATAL_LOG("make anyq input failed!");
return;
}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Re-bin edited a comment on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
Re-bin edited a comment on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
URL: https://github.com/apache/incubator-brpc/issues/896#issuecomment-522983524
>
https://github.com/apache/incubator-brpc/blob/8c32109de6d697f4c14bf808e19f251fb3a47e9d/src/brpc/details/http_message.cpp#L164
多谢大佬，还向问一下这个实例，里面的controller也能获得uri数据，也是通过上述的办法嘛？对这个地方有一些疑惑，还望不吝赐教。(代码源于Baidu开源的AnyQ)
`void HttpServiceImpl::anyq(google::protobuf::RpcController* cntl_base,
const HttpRequest* request,
HttpResponse*,
google::protobuf::Closure* done) {
brpc::ClosureGuard done_guard(done);
brpc::Controller* cntl = static_cast(cntl_base);
cntl->http_response().set_content_type("application/json;charset=utf8");
Json::Value parameters;
if (this->normalize_input(cntl, parameters) != 0
|| parameters.type() != Json::objectValue) {
FATAL_LOG("normalize input failed!");
return;
}
std::string str_anyq_input;
if (_preproc_plugin->process(cntl, parameters, str_anyq_input) != 0) {
FATAL_LOG("make anyq input failed!");
return;
}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Re-bin commented on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
Re-bin commented on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
URL: https://github.com/apache/incubator-brpc/issues/896#issuecomment-522983524
>
https://github.com/apache/incubator-brpc/blob/8c32109de6d697f4c14bf808e19f251fb3a47e9d/src/brpc/details/http_message.cpp#L164
多谢大佬，还向问一下这个实例，里面的controller也能获得uri数据，也是通过上述的办法嘛？对这个地方有一些疑惑，还望不吝赐教。(代码源于Baidu开源的AnyQ)
`void HttpServiceImpl::anyq(google::protobuf::RpcController* cntl_base,
const HttpRequest* request,
HttpResponse*,
google::protobuf::Closure* done) {
brpc::ClosureGuard done_guard(done);
brpc::Controller* cntl = static_cast(cntl_base);
cntl->http_response().set_content_type("application/json;charset=utf8");
// preprocess
Json::Value parameters;
if (this->normalize_input(cntl, parameters) != 0
|| parameters.type() != Json::objectValue) {
FATAL_LOG("normalize input failed!");
return;
}
std::string str_anyq_input;
if (_preproc_plugin->process(cntl, parameters, str_anyq_input) != 0) {
FATAL_LOG("make anyq input failed!");
return;
}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Re-bin edited a comment on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
Re-bin edited a comment on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
URL: https://github.com/apache/incubator-brpc/issues/896#issuecomment-522983524
>
https://github.com/apache/incubator-brpc/blob/8c32109de6d697f4c14bf808e19f251fb3a47e9d/src/brpc/details/http_message.cpp#L164
多谢大佬，还向问一下这个实例，里面的controller也能获得uri数据，也是通过上述的办法嘛？对这个地方有一些疑惑，还望不吝赐教。(代码源于Baidu开源的AnyQ)
不知道为什么代码放上来没法全进那个框
`void HttpServiceImpl::anyq(google::protobuf::RpcController* cntl_base,
const HttpRequest* request,
HttpResponse*,
google::protobuf::Closure* done) {
brpc::ClosureGuard done_guard(done);
brpc::Controller* cntl = static_cast(cntl_base);
cntl->http_response().set_content_type("application/json;charset=utf8");
// preprocess
Json::Value parameters;
if (this->normalize_input(cntl, parameters) != 0
|| parameters.type() != Json::objectValue) {
FATAL_LOG("normalize input failed!");
return;
}
std::string str_anyq_input;
if (_preproc_plugin->process(cntl, parameters, str_anyq_input) != 0) {
FATAL_LOG("make anyq input failed!");
return;
}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Re-bin edited a comment on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
Re-bin edited a comment on issue #896: 有个疑惑，想知道brpc中的controller里面的uri数据一般是怎么获得的？
URL: https://github.com/apache/incubator-brpc/issues/896#issuecomment-522983524
>
https://github.com/apache/incubator-brpc/blob/8c32109de6d697f4c14bf808e19f251fb3a47e9d/src/brpc/details/http_message.cpp#L164
多谢大佬，还向问一下这个实例，里面的controller也能获得uri数据，也是通过上述的办法嘛？对这个地方有一些疑惑，还望不吝赐教。(代码源于Baidu开源的AnyQ)
`
void HttpServiceImpl::anyq(google::protobuf::RpcController* cntl_base,
const HttpRequest* request,
HttpResponse*,
google::protobuf::Closure* done) {
brpc::ClosureGuard done_guard(done);
brpc::Controller* cntl = static_cast(cntl_base);
cntl->http_response().set_content_type("application/json;charset=utf8");
// preprocess
Json::Value parameters;
if (this->normalize_input(cntl, parameters) != 0
|| parameters.type() != Json::objectValue) {
FATAL_LOG("normalize input failed!");
return;
}
std::string str_anyq_input;
if (_preproc_plugin->process(cntl, parameters, str_anyq_input) != 0) {
FATAL_LOG("make anyq input failed!");
return;
}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #894: 随着运行时间的增长出现很多未释放的close wait的连接和bthread
zyearn commented on issue #894: 随着运行时间的增长出现很多未释放的close wait的连接和bthread URL: https://github.com/apache/incubator-brpc/issues/894#issuecomment-523282324 worker全部都阻塞住了么（可以通过curl 'ip:port/health'判断，如果没有返回就是阻塞了）？如果阻塞住的话，EventDispatcher就不工作了，fd可能不会被close This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn edited a comment on issue #894: 随着运行时间的增长出现很多未释放的close wait的连接和bthread
zyearn edited a comment on issue #894: 随着运行时间的增长出现很多未释放的close wait的连接和bthread URL: https://github.com/apache/incubator-brpc/issues/894#issuecomment-523282324 worker全部都阻塞住了么（可以通过curl 'ip:port/health'判断，如果没有返回就是阻塞了）？如果阻塞住的话，EventDispatcher就不工作了，fd可能不会被close This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] liupengs commented on issue #866: bthread_cond_timedwait 偶尔出现超时不返回
liupengs commented on issue #866: bthread_cond_timedwait 偶尔出现超时不返回 URL: https://github.com/apache/incubator-brpc/issues/866#issuecomment-522992234 见 #617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] liupengs closed issue #866: bthread_cond_timedwait 偶尔出现超时不返回
liupengs closed issue #866: bthread_cond_timedwait 偶尔出现超时不返回 URL: https://github.com/apache/incubator-brpc/issues/866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] liupengs commented on issue #893: fix bug: bthread_cond_timedwait not return when timeout
liupengs commented on issue #893: fix bug: bthread_cond_timedwait not return when timeout URL: https://github.com/apache/incubator-brpc/pull/893#issuecomment-522990934 这个问题在我们使用场景中出现频率挺高，我们在百度内部和社区提 issues 都是一直无人理。 问题根源就是函数 erase_from_butex 和 wait_for_butex 中操作 container 的顺序不确定， 理论上只需保证操作container 的顺序 或 添加辅助变量记录状态， 就可以解决这个问题。 当前我修复的版本在内部一直运行良好。 但是如 #617 中讨论的由于 butex_requeue 的逻辑掺杂， 导致修复困难， 加上我还没有分析butex_requeue代码， 所以这个 pull request 可以暂时搁置。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
