Re: [VOTE] Buildr 1.4.6 release

2011-06-23 Thread Alex Boisvert
2011/6/22 Marc-André Laverdière marcandre.laverdi...@gmail.com

 That part worked well. Thanks!

 But I got something that didn't :(

 The auto-versioning after a release messed up:
 1.2-RC-5-SNAPSHOT - 1.2-RC-5 - 1.03-SNAPSHOT


Did this use to work in previous versions?

The release documentation (http://buildr.apache.org/releasing.html) is
pretty clear that it will increment the last digit of the 3-digit version
number if THIS_VERSION ends with -SNAPSHOT.   And you have several
alternatives to specify the next version number.

Unless this used to work, I don't see this bug as a blocker for the release.
 We can address it for the next version.

alex


Re: [VOTE] Buildr 1.4.6 release

2011-06-23 Thread Marc-André Laverdière
I agree. This is not a blocker.
Thanks for looking into it.

Marc-André LAVERDIÈRE
Perseverance must finish its work so that you may be mature and complete,
not lacking anything. -James 1:4
http://asimplediscipleslife.blogspot.com/
mlaverd.theunixplace.com





On Thu, Jun 23, 2011 at 10:54 PM, Alex Boisvert alex.boisv...@gmail.com wrote:
 On Thu, Jun 23, 2011 at 10:10 AM, Alex Boisvert 
 alex.boisv...@gmail.comwrote:

 2011/6/22 Marc-André Laverdière marcandre.laverdi...@gmail.com

 That part worked well. Thanks!

 But I got something that didn't :(

 The auto-versioning after a release messed up:
 1.2-RC-5-SNAPSHOT - 1.2-RC-5 - 1.03-SNAPSHOT


 Did this use to work in previous versions?

 The release documentation (http://buildr.apache.org/releasing.html) is
 pretty clear that it will increment the last digit of the 3-digit version
 number if THIS_VERSION ends with -SNAPSHOT.   And you have several
 alternatives to specify the next version number.

 Unless this used to work, I don't see this bug as a blocker for the
 release.  We can address it for the next version.


 I just tested w/ 1.4.4 and 1.4.5 and got the same result.  So I'm going to
 go ahead with the release given that the bug seems to have existed for some
 time and there are straightforward workarounds.

 alex



Re: [VOTE] Buildr 1.4.6 release

2011-06-23 Thread Antoine Toulme
+1. I ran a few integration tests with the release and everything checks
out.

2011/6/23 Marc-André Laverdière marcandre.laverdi...@gmail.com

 I agree. This is not a blocker.
 Thanks for looking into it.

 Marc-André LAVERDIÈRE
 Perseverance must finish its work so that you may be mature and complete,
 not lacking anything. -James 1:4
 http://asimplediscipleslife.blogspot.com/
 mlaverd.theunixplace.com





 On Thu, Jun 23, 2011 at 10:54 PM, Alex Boisvert alex.boisv...@gmail.com
 wrote:
  On Thu, Jun 23, 2011 at 10:10 AM, Alex Boisvert alex.boisv...@gmail.com
 wrote:
 
  2011/6/22 Marc-André Laverdière marcandre.laverdi...@gmail.com
 
  That part worked well. Thanks!
 
  But I got something that didn't :(
 
  The auto-versioning after a release messed up:
  1.2-RC-5-SNAPSHOT - 1.2-RC-5 - 1.03-SNAPSHOT
 
 
  Did this use to work in previous versions?
 
  The release documentation (http://buildr.apache.org/releasing.html) is
  pretty clear that it will increment the last digit of the 3-digit
 version
  number if THIS_VERSION ends with -SNAPSHOT.   And you have several
  alternatives to specify the next version number.
 
  Unless this used to work, I don't see this bug as a blocker for the
  release.  We can address it for the next version.
 
 
  I just tested w/ 1.4.4 and 1.4.5 and got the same result.  So I'm going
 to
  go ahead with the release given that the bug seems to have existed for
 some
  time and there are straightforward workarounds.
 
  alex