Re: Testing a change for pull request submittal?
Hi Christopher,
Thanks for the patch! I've applied it as-is.
I /may/ rework it a little bit later to extend group include/exclude support
to other test frameworks: JUnit, ScalaTest, Specs and others all support
the notion of grouping/labeling tests and I'd like to standardize how this
is specified in the Buildfile and on the command-line, e.g.,
buildr test:@group1,-@group2# include group1 and exclude group2
similar to how we do for individual test inclusion/exclusion today.
alex
On Mon, Jul 18, 2011 at 12:42 PM, Christopher Coco wrote:
> Hi Alex,
>
> I've finally had time to get back to this. I've submitted a JIRA
> (BUILDR-598) along with a code patch attached and updated the pull request
> in GitHub with the changes to support TestNG group inclusion and exclusion
> via the @Test(groups={}) annotation modifier.
>
> Please let me know if there's anything else I can do to get this included
> in Buildr.
>
> Thanks!
> -c
>
> On Wednesday, April 27, 2011 at 8:23 AM, Christopher Coco wrote:
>
> > Hi Alex,
> >
> > No worries. I'll open up a JIRA as you suggested.
> >
> > Thanks!
> > Christopher
> >
> > On Wed, Apr 27, 2011 at 6:36 AM, Alex Boisvert
> > alex.boisv...@gmail.com)> wrote:
> > > Hi Christopher,
> > >
> > > Oh, I haven't seen your pull request... regardless... I forgot to say
> the
> > > best way to notify other devs of a patch is to open a Jira, attach a
> copy of
> > > the patch, make sure you click on the ASL license grant and if your
> work is
> > > also on github (or wherever else) then link to it.
> > >
> > > https://issues.apache.org/jira/browse/BUILDR
> > >
> > > alex
> > >
> > >
> > > On Tue, Apr 26, 2011 at 10:00 PM, Christopher Coco
> > > cac...@gmail.com)> wrote:
> > >
> > > > Hi Alex,
> > > >
> > > > Thanks for the info. I'll look into rspec. I submitted a pull request
> a
> > > > couple of weeks ago (maybe rather hastily) for the TestNG changes I
> made.
> > > > I'll try to write up a test to accompany them.
> > > >
> > > > Thanks again,
> > > > Christopher
> > > >
> > > >
> > > > On Tue, Apr 26, 2011 at 6:06 PM, Alex Boisvert <
> alex.boisv...@gmail.com (mailto:alex.boisv...@gmail.com)
> > > > >wrote:
> > > >
> > > > > Hi Christopher,
> > > > >
> > > > > Pull requests are much appreciated! And your JSP precompiler is a
> very
> > > > > nice
> > > > > first task.
> > > > >
> > > > > For testing, we use rspec. If you're enhancing TestNG support, you
> > > > would
> > > > > typically add to the TestNG specification (
> > > > >
> https://github.com/apache/buildr/blob/trunk/lib/buildr/java/tests.rb).
> > > > >
> > > > > If you get stuck, ask questions here or you can try to catch some
> of us
> > > > on
> > > > > the IRC channel (#buildr on irc.freenode.net (
> http://irc.freenode.net))
> > > > >
> > > > > alex
> > > > >
> > > > > On Tue, Apr 26, 2011 at 2:51 PM, Christopher Coco <
> cac...@gmail.com (mailto:cac...@gmail.com)>
> > > > > wrote:
> > > > >
> > > > > > Hey guys,
> > > > > >
> > > > > > I'm new to Buildr (and ruby in general) and am working on
> migrating our
> > > > > > build from Maven to something that is more expressive in terms of
> > > > project
> > > > > > definition which is what drew us to Buildr. A couple of the
> necessary
> > > > > > pieces
> > > > > > we need before switching are expanded TestNG support (like
> supporting
> > > > > > excluding/including by TestNG groups) and JSP pre-compilation
> (via
> > > > > tomcat6
> > > > > > jasper). Simple things, right?
> > > > > >
> > > > > > Knowing little ruby when I started, I did managed to write a jsp
> > > > > > precompiler
> > > > > > extension (available here: https://gist.github.com/921897). I'm
> sure
> > > > > this
> > > > > > code can be improved.
> > > > > >
> > > > > > As for the TestNG functionality, trying to get exclusion via
> TestNG
> > > > > groups
> > > > > > (or any of the other cmd line options that TestNG allows) using
> the
> > > > > > properties hash didn't work as the param and value are added to
> the
> > > > > TestNG
> > > > > > runner as -D args instead of just as cmd line params. So, I
> forked the
> > > > > > buildr project on github and made a few small tweaks to the
> tests.rb to
> > > > > > pass
> > > > > > along more parameters in the options array to the TestNG class.
> The
> > > > > change
> > > > > > basically shims more cmd line parameters onto the string for
> TestNG
> > > > > runner.
> > > > > >
> > > > > > So my question is now, ok, I should probably test this -- like I
> > > > > mentioned,
> > > > > > I'm extremely green with ruby -- what's the next step (or steps)
> so I
> > > > can
> > > > > > actually give some confidence (other than that we're actually
> running
> > > > the
> > > > > > fork here) that the change works so that my pull request is
> actually
> > > > > looked
> > > > > > at for potential inclusion into the master branch? I'm a java guy
> and
> > > > > > slowly
> > > > > > learning ruby and ruby
Re: Testing a change for pull request submittal?
Hi Alex,
I've finally had time to get back to this. I've submitted a JIRA (BUILDR-598)
along with a code patch attached and updated the pull request in GitHub with
the changes to support TestNG group inclusion and exclusion via the
@Test(groups={}) annotation modifier.
Please let me know if there's anything else I can do to get this included in
Buildr.
Thanks!
-c
On Wednesday, April 27, 2011 at 8:23 AM, Christopher Coco wrote:
> Hi Alex,
>
> No worries. I'll open up a JIRA as you suggested.
>
> Thanks!
> Christopher
>
> On Wed, Apr 27, 2011 at 6:36 AM, Alex Boisvert (mailto:alex.boisv...@gmail.com)> wrote:
> > Hi Christopher,
> >
> > Oh, I haven't seen your pull request... regardless... I forgot to say the
> > best way to notify other devs of a patch is to open a Jira, attach a copy
> > of
> > the patch, make sure you click on the ASL license grant and if your work is
> > also on github (or wherever else) then link to it.
> >
> > https://issues.apache.org/jira/browse/BUILDR
> >
> > alex
> >
> >
> > On Tue, Apr 26, 2011 at 10:00 PM, Christopher Coco > (mailto:cac...@gmail.com)> wrote:
> >
> > > Hi Alex,
> > >
> > > Thanks for the info. I'll look into rspec. I submitted a pull request a
> > > couple of weeks ago (maybe rather hastily) for the TestNG changes I made.
> > > I'll try to write up a test to accompany them.
> > >
> > > Thanks again,
> > > Christopher
> > >
> > >
> > > On Tue, Apr 26, 2011 at 6:06 PM, Alex Boisvert > > (mailto:alex.boisv...@gmail.com)
> > > >wrote:
> > >
> > > > Hi Christopher,
> > > >
> > > > Pull requests are much appreciated! And your JSP precompiler is a very
> > > > nice
> > > > first task.
> > > >
> > > > For testing, we use rspec. If you're enhancing TestNG support, you
> > > would
> > > > typically add to the TestNG specification (
> > > > https://github.com/apache/buildr/blob/trunk/lib/buildr/java/tests.rb).
> > > >
> > > > If you get stuck, ask questions here or you can try to catch some of us
> > > on
> > > > the IRC channel (#buildr on irc.freenode.net (http://irc.freenode.net))
> > > >
> > > > alex
> > > >
> > > > On Tue, Apr 26, 2011 at 2:51 PM, Christopher Coco > > > (mailto:cac...@gmail.com)>
> > > > wrote:
> > > >
> > > > > Hey guys,
> > > > >
> > > > > I'm new to Buildr (and ruby in general) and am working on migrating
> > > > > our
> > > > > build from Maven to something that is more expressive in terms of
> > > project
> > > > > definition which is what drew us to Buildr. A couple of the necessary
> > > > > pieces
> > > > > we need before switching are expanded TestNG support (like supporting
> > > > > excluding/including by TestNG groups) and JSP pre-compilation (via
> > > > tomcat6
> > > > > jasper). Simple things, right?
> > > > >
> > > > > Knowing little ruby when I started, I did managed to write a jsp
> > > > > precompiler
> > > > > extension (available here: https://gist.github.com/921897). I'm sure
> > > > this
> > > > > code can be improved.
> > > > >
> > > > > As for the TestNG functionality, trying to get exclusion via TestNG
> > > > groups
> > > > > (or any of the other cmd line options that TestNG allows) using the
> > > > > properties hash didn't work as the param and value are added to the
> > > > TestNG
> > > > > runner as -D args instead of just as cmd line params. So, I forked the
> > > > > buildr project on github and made a few small tweaks to the tests.rb
> > > > > to
> > > > > pass
> > > > > along more parameters in the options array to the TestNG class. The
> > > > change
> > > > > basically shims more cmd line parameters onto the string for TestNG
> > > > runner.
> > > > >
> > > > > So my question is now, ok, I should probably test this -- like I
> > > > mentioned,
> > > > > I'm extremely green with ruby -- what's the next step (or steps) so I
> > > can
> > > > > actually give some confidence (other than that we're actually running
> > > the
> > > > > fork here) that the change works so that my pull request is actually
> > > > looked
> > > > > at for potential inclusion into the master branch? I'm a java guy and
> > > > > slowly
> > > > > learning ruby and ruby testing is somewhat alien to me right now. But,
> > > I
> > > > > think this functionality is useful (maybe I'm off-base, but we
> > > definitely
> > > > > need it and TestNG definitely supports it), so I'd like to actually
> > > help
> > > > > out
> > > > > here and contribute. I know the question is seemingly general (ruby
> > > > > testing), but I'm trying to be targeted in asking, what needs to
> > > > > happen
> > > > to
> > > > > get the changes incorporated in the next version of Buildr? Am I going
> > > > > about
> > > > > this all wrong and should I submit an issue instead?
> > > > >
> > > > > Thanks,
> > > > > Christopher
> > > > > cac...@gmail.com (mailto:cac...@gmail.com)
> > > > > https://github.com/cacoco
> > > > >
> > > >
> > >
>
