Re: [VOTE] Buildr 1.5.4 release

[Peter Donald]

Looks like a minor bug appeared in our latest release. The fix is as follows.

https://github.com/apache/buildr/commit/ae6f056046126d2ae79b0ef2e4f02176b78923d1

I may try and propose another release before the end of the week to
ensure the bug is not out there too long.


On Thu, Nov 30, 2017 at 9:12 PM, Peter Donald  wrote:
> Vote passed. Releasing now ...
>
> On Thu, Nov 30, 2017 at 5:17 PM, Alex Boisvert  
> wrote:
>> +1 from me too.
>>
>> On Nov 29, 2017 12:04 AM, "Antoine Toulme"  wrote:
>>
>>> Thank you! My +1 as well.
>>>
>>> > On Nov 28, 2017, at 21:29, Peter Donald  wrote:
>>> >
>>> > I had some time to do some testing of the latest version so I pushed out
>>> > the release. Hope that is all good.
>>> >
>>> > Anyhoo - I tested with several different  builds and are +1
>>> >
>>> > On Wed, Nov 29, 2017 at 4:28 PM, Peter Donald 
>>> > wrote:
>>> >
>>> >> We're voting on the source distributions available here:
>>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>>> >>
>>> >> Specifically:
>>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>>> buildr-1.5.4.tgz
>>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>>> buildr-1.5.4.zip
>>> >>
>>> >> The documentation generated for this release is available here:
>>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
>>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
>>> >>
>>> >> The following changes were made since 1.5.3:
>>> >>
>>> >>  * Added:  Findbugs Addon: Upgrade to version 3.0.1 of findbugs.
>>> >>  * Added:  GPG Addon: Add boolean configuration setting `project.gpg`
>>> >> that can be set to false via
>>> >>`project.gpg = false` to avoid signing and uploading
>>> packages.
>>> >> This is useful when some
>>> >>projects are not intended for publishing.
>>> >>  * Fixed:  JaCoCo Addon: Projects that have jacoco disabled will no
>>> >> longer appear in the JaCoCo reports.
>>> >>  * Change: JaCoCo Addon: Update JaCoCo version to 0.7.9.
>>> >>  * Fixed:  BUILDR-733 - Escape classpath entries in the pathing jar
>>> >> manifest. Submitted by Glenn Croes.
>>> >>  * Fixed:  Ensure that the pom is attached to the jar artifact with
>>> empty
>>> >> classifier rather than the last
>>> >>artifact of a type defined. Otherwise a project that defines
>>> >> multiple artifacts of the same type
>>> >>(i.e. `package(:jar)` and `package(:jar, :classifier =>
>>> >> :gwt)`) could have the pom named after
>>> >>the package with the classifier rather than the package
>>> >> without a classifer. (i.e. the pom could
>>> >>be incorrectly defined as `mypackage-1.0.0-gwt.pom` rather
>>> >> than `mypackage-1.0.0.pom`).
>>> >>  * Added:  GWT Addon: Add support for GWT 2.8.2 release and make it the
>>> >> default version unless otherwise specified.
>>> >>  * Added:  GWT Addon: Added support for `:js_exports` boolean to enable
>>> >> "JsInteropExports".
>>> >>  * Added:  IDEA Extension: Added support for `:open_in_browser` boolean
>>> >> passed to `ipr.add_gwt_configuration`
>>> >>  * Added:  BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By
>>> >> Eric Bruneton.
>>> >>  * Added:  Support to compiling Kotlin
>>> >>  * Fixed:  Remove section on development builds in the Contributing
>>> >> section.
>>> >>  * Added:  New way to concatenate file contents when merging several
>>> >> archives together.
>>> >>  * Added:  New way to transform file contents when merging several
>>> >> archives together.
>>> >>  * Fixed:  Removed .class files from being checked in.
>>> >>  * Added:  Support both Jetty 6 and Jetty 9 as addons. Added integration
>>> >> tests to cover their use.
>>> >>
>>> >>
>>> >
>>> >
>>> > --
>>> > Cheers,
>>> >
>>> > Peter Donald
>>>
>
>
>
> --
> Cheers,
>
> Peter Donald



-- 
Cheers,

Peter Donald

Re: [VOTE] Buildr 1.5.4 release

[Peter Donald]

Vote passed. Releasing now ...

On Thu, Nov 30, 2017 at 5:17 PM, Alex Boisvert  wrote:
> +1 from me too.
>
> On Nov 29, 2017 12:04 AM, "Antoine Toulme"  wrote:
>
>> Thank you! My +1 as well.
>>
>> > On Nov 28, 2017, at 21:29, Peter Donald  wrote:
>> >
>> > I had some time to do some testing of the latest version so I pushed out
>> > the release. Hope that is all good.
>> >
>> > Anyhoo - I tested with several different  builds and are +1
>> >
>> > On Wed, Nov 29, 2017 at 4:28 PM, Peter Donald 
>> > wrote:
>> >
>> >> We're voting on the source distributions available here:
>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>> >>
>> >> Specifically:
>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>> buildr-1.5.4.tgz
>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>> buildr-1.5.4.zip
>> >>
>> >> The documentation generated for this release is available here:
>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
>> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
>> >>
>> >> The following changes were made since 1.5.3:
>> >>
>> >>  * Added:  Findbugs Addon: Upgrade to version 3.0.1 of findbugs.
>> >>  * Added:  GPG Addon: Add boolean configuration setting `project.gpg`
>> >> that can be set to false via
>> >>`project.gpg = false` to avoid signing and uploading
>> packages.
>> >> This is useful when some
>> >>projects are not intended for publishing.
>> >>  * Fixed:  JaCoCo Addon: Projects that have jacoco disabled will no
>> >> longer appear in the JaCoCo reports.
>> >>  * Change: JaCoCo Addon: Update JaCoCo version to 0.7.9.
>> >>  * Fixed:  BUILDR-733 - Escape classpath entries in the pathing jar
>> >> manifest. Submitted by Glenn Croes.
>> >>  * Fixed:  Ensure that the pom is attached to the jar artifact with
>> empty
>> >> classifier rather than the last
>> >>artifact of a type defined. Otherwise a project that defines
>> >> multiple artifacts of the same type
>> >>(i.e. `package(:jar)` and `package(:jar, :classifier =>
>> >> :gwt)`) could have the pom named after
>> >>the package with the classifier rather than the package
>> >> without a classifer. (i.e. the pom could
>> >>be incorrectly defined as `mypackage-1.0.0-gwt.pom` rather
>> >> than `mypackage-1.0.0.pom`).
>> >>  * Added:  GWT Addon: Add support for GWT 2.8.2 release and make it the
>> >> default version unless otherwise specified.
>> >>  * Added:  GWT Addon: Added support for `:js_exports` boolean to enable
>> >> "JsInteropExports".
>> >>  * Added:  IDEA Extension: Added support for `:open_in_browser` boolean
>> >> passed to `ipr.add_gwt_configuration`
>> >>  * Added:  BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By
>> >> Eric Bruneton.
>> >>  * Added:  Support to compiling Kotlin
>> >>  * Fixed:  Remove section on development builds in the Contributing
>> >> section.
>> >>  * Added:  New way to concatenate file contents when merging several
>> >> archives together.
>> >>  * Added:  New way to transform file contents when merging several
>> >> archives together.
>> >>  * Fixed:  Removed .class files from being checked in.
>> >>  * Added:  Support both Jetty 6 and Jetty 9 as addons. Added integration
>> >> tests to cover their use.
>> >>
>> >>
>> >
>> >
>> > --
>> > Cheers,
>> >
>> > Peter Donald
>>



-- 
Cheers,

Peter Donald

Re: [VOTE] Buildr 1.5.4 release

[Alex Boisvert]

+1 from me too.

On Nov 29, 2017 12:04 AM, "Antoine Toulme"  wrote:

> Thank you! My +1 as well.
>
> > On Nov 28, 2017, at 21:29, Peter Donald  wrote:
> >
> > I had some time to do some testing of the latest version so I pushed out
> > the release. Hope that is all good.
> >
> > Anyhoo - I tested with several different  builds and are +1
> >
> > On Wed, Nov 29, 2017 at 4:28 PM, Peter Donald 
> > wrote:
> >
> >> We're voting on the source distributions available here:
> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> >>
> >> Specifically:
> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> buildr-1.5.4.tgz
> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> buildr-1.5.4.zip
> >>
> >> The documentation generated for this release is available here:
> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
> >> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
> >>
> >> The following changes were made since 1.5.3:
> >>
> >>  * Added:  Findbugs Addon: Upgrade to version 3.0.1 of findbugs.
> >>  * Added:  GPG Addon: Add boolean configuration setting `project.gpg`
> >> that can be set to false via
> >>`project.gpg = false` to avoid signing and uploading
> packages.
> >> This is useful when some
> >>projects are not intended for publishing.
> >>  * Fixed:  JaCoCo Addon: Projects that have jacoco disabled will no
> >> longer appear in the JaCoCo reports.
> >>  * Change: JaCoCo Addon: Update JaCoCo version to 0.7.9.
> >>  * Fixed:  BUILDR-733 - Escape classpath entries in the pathing jar
> >> manifest. Submitted by Glenn Croes.
> >>  * Fixed:  Ensure that the pom is attached to the jar artifact with
> empty
> >> classifier rather than the last
> >>artifact of a type defined. Otherwise a project that defines
> >> multiple artifacts of the same type
> >>(i.e. `package(:jar)` and `package(:jar, :classifier =>
> >> :gwt)`) could have the pom named after
> >>the package with the classifier rather than the package
> >> without a classifer. (i.e. the pom could
> >>be incorrectly defined as `mypackage-1.0.0-gwt.pom` rather
> >> than `mypackage-1.0.0.pom`).
> >>  * Added:  GWT Addon: Add support for GWT 2.8.2 release and make it the
> >> default version unless otherwise specified.
> >>  * Added:  GWT Addon: Added support for `:js_exports` boolean to enable
> >> "JsInteropExports".
> >>  * Added:  IDEA Extension: Added support for `:open_in_browser` boolean
> >> passed to `ipr.add_gwt_configuration`
> >>  * Added:  BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By
> >> Eric Bruneton.
> >>  * Added:  Support to compiling Kotlin
> >>  * Fixed:  Remove section on development builds in the Contributing
> >> section.
> >>  * Added:  New way to concatenate file contents when merging several
> >> archives together.
> >>  * Added:  New way to transform file contents when merging several
> >> archives together.
> >>  * Fixed:  Removed .class files from being checked in.
> >>  * Added:  Support both Jetty 6 and Jetty 9 as addons. Added integration
> >> tests to cover their use.
> >>
> >>
> >
> >
> > --
> > Cheers,
> >
> > Peter Donald
>

Re: [VOTE] Buildr 1.5.4 release

[Antoine Toulme]

Thank you! My +1 as well.

> On Nov 28, 2017, at 21:29, Peter Donald  wrote:
> 
> I had some time to do some testing of the latest version so I pushed out
> the release. Hope that is all good.
> 
> Anyhoo - I tested with several different  builds and are +1
> 
> On Wed, Nov 29, 2017 at 4:28 PM, Peter Donald 
> wrote:
> 
>> We're voting on the source distributions available here:
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>> 
>> Specifically:
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/buildr-1.5.4.tgz
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/buildr-1.5.4.zip
>> 
>> The documentation generated for this release is available here:
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
>> 
>> The following changes were made since 1.5.3:
>> 
>>  * Added:  Findbugs Addon: Upgrade to version 3.0.1 of findbugs.
>>  * Added:  GPG Addon: Add boolean configuration setting `project.gpg`
>> that can be set to false via
>>`project.gpg = false` to avoid signing and uploading packages.
>> This is useful when some
>>projects are not intended for publishing.
>>  * Fixed:  JaCoCo Addon: Projects that have jacoco disabled will no
>> longer appear in the JaCoCo reports.
>>  * Change: JaCoCo Addon: Update JaCoCo version to 0.7.9.
>>  * Fixed:  BUILDR-733 - Escape classpath entries in the pathing jar
>> manifest. Submitted by Glenn Croes.
>>  * Fixed:  Ensure that the pom is attached to the jar artifact with empty
>> classifier rather than the last
>>artifact of a type defined. Otherwise a project that defines
>> multiple artifacts of the same type
>>(i.e. `package(:jar)` and `package(:jar, :classifier =>
>> :gwt)`) could have the pom named after
>>the package with the classifier rather than the package
>> without a classifer. (i.e. the pom could
>>be incorrectly defined as `mypackage-1.0.0-gwt.pom` rather
>> than `mypackage-1.0.0.pom`).
>>  * Added:  GWT Addon: Add support for GWT 2.8.2 release and make it the
>> default version unless otherwise specified.
>>  * Added:  GWT Addon: Added support for `:js_exports` boolean to enable
>> "JsInteropExports".
>>  * Added:  IDEA Extension: Added support for `:open_in_browser` boolean
>> passed to `ipr.add_gwt_configuration`
>>  * Added:  BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By
>> Eric Bruneton.
>>  * Added:  Support to compiling Kotlin
>>  * Fixed:  Remove section on development builds in the Contributing
>> section.
>>  * Added:  New way to concatenate file contents when merging several
>> archives together.
>>  * Added:  New way to transform file contents when merging several
>> archives together.
>>  * Fixed:  Removed .class files from being checked in.
>>  * Added:  Support both Jetty 6 and Jetty 9 as addons. Added integration
>> tests to cover their use.
>> 
>> 
> 
> 
> -- 
> Cheers,
> 
> Peter Donald

Re: [VOTE] Buildr 1.5.4 release

[Peter Donald]

I had some time to do some testing of the latest version so I pushed out
the release. Hope that is all good.

Anyhoo - I tested with several different  builds and are +1

On Wed, Nov 29, 2017 at 4:28 PM, Peter Donald 
wrote:

> We're voting on the source distributions available here:
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>
> Specifically:
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/buildr-1.5.4.tgz
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/buildr-1.5.4.zip
>
> The documentation generated for this release is available here:
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
>
> The following changes were made since 1.5.3:
>
>   * Added:  Findbugs Addon: Upgrade to version 3.0.1 of findbugs.
>   * Added:  GPG Addon: Add boolean configuration setting `project.gpg`
> that can be set to false via
> `project.gpg = false` to avoid signing and uploading packages.
> This is useful when some
> projects are not intended for publishing.
>   * Fixed:  JaCoCo Addon: Projects that have jacoco disabled will no
> longer appear in the JaCoCo reports.
>   * Change: JaCoCo Addon: Update JaCoCo version to 0.7.9.
>   * Fixed:  BUILDR-733 - Escape classpath entries in the pathing jar
> manifest. Submitted by Glenn Croes.
>   * Fixed:  Ensure that the pom is attached to the jar artifact with empty
> classifier rather than the last
> artifact of a type defined. Otherwise a project that defines
> multiple artifacts of the same type
> (i.e. `package(:jar)` and `package(:jar, :classifier =>
> :gwt)`) could have the pom named after
> the package with the classifier rather than the package
> without a classifer. (i.e. the pom could
> be incorrectly defined as `mypackage-1.0.0-gwt.pom` rather
> than `mypackage-1.0.0.pom`).
>   * Added:  GWT Addon: Add support for GWT 2.8.2 release and make it the
> default version unless otherwise specified.
>   * Added:  GWT Addon: Added support for `:js_exports` boolean to enable
> "JsInteropExports".
>   * Added:  IDEA Extension: Added support for `:open_in_browser` boolean
> passed to `ipr.add_gwt_configuration`
>   * Added:  BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By
> Eric Bruneton.
>   * Added:  Support to compiling Kotlin
>   * Fixed:  Remove section on development builds in the Contributing
> section.
>   * Added:  New way to concatenate file contents when merging several
> archives together.
>   * Added:  New way to transform file contents when merging several
> archives together.
>   * Fixed:  Removed .class files from being checked in.
>   * Added:  Support both Jetty 6 and Jetty 9 as addons. Added integration
> tests to cover their use.
>
>


-- 
Cheers,

Peter Donald

Re: [VOTE] Buildr 1.5.4 release -- CANCELED

[Peter Donald]

Great.

I just pushed a couple of fixes for bugs/unintended features that we have
noticed in the meantime ;)

On Sun, Nov 19, 2017 at 7:19 PM, Antoine Toulme  wrote:

> Allright, sorry for taking my sweet time on this.
>
> I’ll get a new RC rolling over Thanksgiving.
>
> Cheers,
>
> Antoine
>
> > On Sep 27, 2017, at 9:26 PM, Antoine Toulme  wrote:
> >
> > I’ll look and restart a vote then. Thanks!
> >
> >> On Sep 27, 2017, at 9:16 PM, Peter Donald 
> wrote:
> >>
> >> Actually looked like an easy fix so I committed it to master.
> >>
> >> On Thu, Sep 28, 2017 at 1:48 PM, Peter Donald 
> >> wrote:
> >>
> >>> Actually I have just found a bug. I am not sure if this is a
> regression or
> >>> an existing bug. I will have a look at it later tonight, if you could
> hold
> >>> off releasing a little longer I can explore what the issue is.
> >>>
> >>> Largely it is if we define a package and a classifier of same package
> that
> >>> is not :javadoc or :sources, the pom generated seems to be attached to
> the
> >>> last artifact rather than the one with no classifier. Should be easy
> to fix.
> >>>
> >>> FWIW a reproduction would be something like
> >>>
> >>> package(:jar)
> >>> package(:jar, :classifier => :gwt)
> >>>
> >>> will produce a pom named "myartifact-2.0-gwt.pom" rather than
> >>> "myartifact-2.0.pom"
> >>>
> >>>
> >>> On Tue, Sep 26, 2017 at 8:19 AM, Peter Donald 
> >>> wrote:
> >>>
>  +1
> 
> 
>  Ran the MRI variant through all our ci builds
> 
>  On Mon, Sep 25, 2017 at 8:06 AM, Alex Boisvert <
> alex.boisv...@gmail.com>
>  wrote:
> 
> > +1 (not tested)
> >
> > On Sep 24, 2017 3:02 PM, "Antoine Toulme" 
> wrote:
> >
> >> +1
> >>
> >>> On Sep 24, 2017, at 3:03 PM, Antoine Toulme 
> > wrote:
> >>>
> >>> We're voting on the source distributions available here:
> >>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> >>>
> >>> Specifically:
> >>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> >> buildr-1.5.4.tgz
> >>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> >> buildr-1.5.4.zip
> >>>
> >>> The documentation generated for this release is available here:
> >>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
> >>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
> buildr.pdf
> >>>
> >>> The following changes were made since 1.5.3:
> >>>
> >>> * Added: BUILDR-732 - Support bnd version 2.1.0 or more. Submitted
> > By
> >> Eric Bruneton.
> >>> * Added: Support to compiling Kotlin
> >>> * Fixed: Remove section on development builds in the Contributing
> >> section.
> >>> * Added: New way to concatenate file contents when merging several
> >> archives together.
> >>> * Added: New way to transform file contents when merging several
> >> archives together.
> >>> * Fixed: Removed .class files from being checked in.
> >>> * Added: Support both Jetty 6 and Jetty 9 as addons. Added
> > integration
> >> tests to cover their use.
> >>
> >>
> >
> 
> 
> 
>  --
>  Cheers,
> 
>  Peter Donald
> 
> >>>
> >>>
> >>>
> >>> --
> >>> Cheers,
> >>>
> >>> Peter Donald
> >>>
> >>
> >>
> >>
> >> --
> >> Cheers,
> >>
> >> Peter Donald
> >
>
>


-- 
Cheers,

Peter Donald

Re: [VOTE] Buildr 1.5.4 release -- CANCELED

[Antoine Toulme]

I’ll look and restart a vote then. Thanks!

> On Sep 27, 2017, at 9:16 PM, Peter Donald  wrote:
> 
> Actually looked like an easy fix so I committed it to master.
> 
> On Thu, Sep 28, 2017 at 1:48 PM, Peter Donald 
> wrote:
> 
>> Actually I have just found a bug. I am not sure if this is a regression or
>> an existing bug. I will have a look at it later tonight, if you could hold
>> off releasing a little longer I can explore what the issue is.
>> 
>> Largely it is if we define a package and a classifier of same package that
>> is not :javadoc or :sources, the pom generated seems to be attached to the
>> last artifact rather than the one with no classifier. Should be easy to fix.
>> 
>> FWIW a reproduction would be something like
>> 
>> package(:jar)
>> package(:jar, :classifier => :gwt)
>> 
>> will produce a pom named "myartifact-2.0-gwt.pom" rather than
>> "myartifact-2.0.pom"
>> 
>> 
>> On Tue, Sep 26, 2017 at 8:19 AM, Peter Donald 
>> wrote:
>> 
>>> +1
>>> 
>>> 
>>> Ran the MRI variant through all our ci builds
>>> 
>>> On Mon, Sep 25, 2017 at 8:06 AM, Alex Boisvert 
>>> wrote:
>>> 
 +1 (not tested)
 
 On Sep 24, 2017 3:02 PM, "Antoine Toulme"  wrote:
 
> +1
> 
>> On Sep 24, 2017, at 3:03 PM, Antoine Toulme 
 wrote:
>> 
>> We're voting on the source distributions available here:
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>> 
>> Specifically:
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> buildr-1.5.4.tgz
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> buildr-1.5.4.zip
>> 
>> The documentation generated for this release is available here:
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
>> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
>> 
>> The following changes were made since 1.5.3:
>> 
>> * Added: BUILDR-732 - Support bnd version 2.1.0 or more. Submitted
 By
> Eric Bruneton.
>> * Added: Support to compiling Kotlin
>> * Fixed: Remove section on development builds in the Contributing
> section.
>> * Added: New way to concatenate file contents when merging several
> archives together.
>> * Added: New way to transform file contents when merging several
> archives together.
>> * Fixed: Removed .class files from being checked in.
>> * Added: Support both Jetty 6 and Jetty 9 as addons. Added
 integration
> tests to cover their use.
> 
> 
 
>>> 
>>> 
>>> 
>>> --
>>> Cheers,
>>> 
>>> Peter Donald
>>> 
>> 
>> 
>> 
>> --
>> Cheers,
>> 
>> Peter Donald
>> 
> 
> 
> 
> --
> Cheers,
> 
> Peter Donald



signature.asc
Description: Message signed with OpenPGP

Re: [VOTE] Buildr 1.5.4 release

[Peter Donald]

Actually looked like an easy fix so I committed it to master.

On Thu, Sep 28, 2017 at 1:48 PM, Peter Donald 
wrote:

> Actually I have just found a bug. I am not sure if this is a regression or
> an existing bug. I will have a look at it later tonight, if you could hold
> off releasing a little longer I can explore what the issue is.
>
> Largely it is if we define a package and a classifier of same package that
> is not :javadoc or :sources, the pom generated seems to be attached to the
> last artifact rather than the one with no classifier. Should be easy to fix.
>
> FWIW a reproduction would be something like
>
> package(:jar)
> package(:jar, :classifier => :gwt)
>
> will produce a pom named "myartifact-2.0-gwt.pom" rather than
> "myartifact-2.0.pom"
>
>
> On Tue, Sep 26, 2017 at 8:19 AM, Peter Donald 
> wrote:
>
>> +1
>>
>>
>> Ran the MRI variant through all our ci builds
>>
>> On Mon, Sep 25, 2017 at 8:06 AM, Alex Boisvert 
>> wrote:
>>
>>> +1 (not tested)
>>>
>>> On Sep 24, 2017 3:02 PM, "Antoine Toulme"  wrote:
>>>
>>> > +1
>>> >
>>> > > On Sep 24, 2017, at 3:03 PM, Antoine Toulme 
>>> wrote:
>>> > >
>>> > > We're voting on the source distributions available here:
>>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>>> > >
>>> > > Specifically:
>>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>>> > buildr-1.5.4.tgz
>>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>>> > buildr-1.5.4.zip
>>> > >
>>> > > The documentation generated for this release is available here:
>>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
>>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
>>> > >
>>> > > The following changes were made since 1.5.3:
>>> > >
>>> > >  * Added: BUILDR-732 - Support bnd version 2.1.0 or more. Submitted
>>> By
>>> > Eric Bruneton.
>>> > >  * Added: Support to compiling Kotlin
>>> > >  * Fixed: Remove section on development builds in the Contributing
>>> > section.
>>> > >  * Added: New way to concatenate file contents when merging several
>>> > archives together.
>>> > >  * Added: New way to transform file contents when merging several
>>> > archives together.
>>> > >  * Fixed: Removed .class files from being checked in.
>>> > >  * Added: Support both Jetty 6 and Jetty 9 as addons. Added
>>> integration
>>> > tests to cover their use.
>>> >
>>> >
>>>
>>
>>
>>
>> --
>> Cheers,
>>
>> Peter Donald
>>
>
>
>
> --
> Cheers,
>
> Peter Donald
>



-- 
Cheers,

Peter Donald

Re: [VOTE] Buildr 1.5.4 release

[Peter Donald]

Actually I have just found a bug. I am not sure if this is a regression or
an existing bug. I will have a look at it later tonight, if you could hold
off releasing a little longer I can explore what the issue is.

Largely it is if we define a package and a classifier of same package that
is not :javadoc or :sources, the pom generated seems to be attached to the
last artifact rather than the one with no classifier. Should be easy to fix.

FWIW a reproduction would be something like

package(:jar)
package(:jar, :classifier => :gwt)

will produce a pom named "myartifact-2.0-gwt.pom" rather than
"myartifact-2.0.pom"


On Tue, Sep 26, 2017 at 8:19 AM, Peter Donald 
wrote:

> +1
>
>
> Ran the MRI variant through all our ci builds
>
> On Mon, Sep 25, 2017 at 8:06 AM, Alex Boisvert 
> wrote:
>
>> +1 (not tested)
>>
>> On Sep 24, 2017 3:02 PM, "Antoine Toulme"  wrote:
>>
>> > +1
>> >
>> > > On Sep 24, 2017, at 3:03 PM, Antoine Toulme 
>> wrote:
>> > >
>> > > We're voting on the source distributions available here:
>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>> > >
>> > > Specifically:
>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>> > buildr-1.5.4.tgz
>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
>> > buildr-1.5.4.zip
>> > >
>> > > The documentation generated for this release is available here:
>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
>> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
>> > >
>> > > The following changes were made since 1.5.3:
>> > >
>> > >  * Added: BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By
>> > Eric Bruneton.
>> > >  * Added: Support to compiling Kotlin
>> > >  * Fixed: Remove section on development builds in the Contributing
>> > section.
>> > >  * Added: New way to concatenate file contents when merging several
>> > archives together.
>> > >  * Added: New way to transform file contents when merging several
>> > archives together.
>> > >  * Fixed: Removed .class files from being checked in.
>> > >  * Added: Support both Jetty 6 and Jetty 9 as addons. Added
>> integration
>> > tests to cover their use.
>> >
>> >
>>
>
>
>
> --
> Cheers,
>
> Peter Donald
>



-- 
Cheers,

Peter Donald

Re: [VOTE] Buildr 1.5.4 release

[Peter Donald]

+1


Ran the MRI variant through all our ci builds

On Mon, Sep 25, 2017 at 8:06 AM, Alex Boisvert 
wrote:

> +1 (not tested)
>
> On Sep 24, 2017 3:02 PM, "Antoine Toulme"  wrote:
>
> > +1
> >
> > > On Sep 24, 2017, at 3:03 PM, Antoine Toulme 
> wrote:
> > >
> > > We're voting on the source distributions available here:
> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> > >
> > > Specifically:
> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> > buildr-1.5.4.tgz
> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> > buildr-1.5.4.zip
> > >
> > > The documentation generated for this release is available here:
> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
> > > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
> > >
> > > The following changes were made since 1.5.3:
> > >
> > >  * Added: BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By
> > Eric Bruneton.
> > >  * Added: Support to compiling Kotlin
> > >  * Fixed: Remove section on development builds in the Contributing
> > section.
> > >  * Added: New way to concatenate file contents when merging several
> > archives together.
> > >  * Added: New way to transform file contents when merging several
> > archives together.
> > >  * Fixed: Removed .class files from being checked in.
> > >  * Added: Support both Jetty 6 and Jetty 9 as addons. Added integration
> > tests to cover their use.
> >
> >
>



-- 
Cheers,

Peter Donald

Re: [VOTE] Buildr 1.5.4 release

[Alex Boisvert]

+1 (not tested)

On Sep 24, 2017 3:02 PM, "Antoine Toulme"  wrote:

> +1
>
> > On Sep 24, 2017, at 3:03 PM, Antoine Toulme  wrote:
> >
> > We're voting on the source distributions available here:
> > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> >
> > Specifically:
> > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> buildr-1.5.4.tgz
> > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> buildr-1.5.4.zip
> >
> > The documentation generated for this release is available here:
> > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
> > https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
> >
> > The following changes were made since 1.5.3:
> >
> >  * Added: BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By
> Eric Bruneton.
> >  * Added: Support to compiling Kotlin
> >  * Fixed: Remove section on development builds in the Contributing
> section.
> >  * Added: New way to concatenate file contents when merging several
> archives together.
> >  * Added: New way to transform file contents when merging several
> archives together.
> >  * Fixed: Removed .class files from being checked in.
> >  * Added: Support both Jetty 6 and Jetty 9 as addons. Added integration
> tests to cover their use.
>
>

Re: [VOTE] Buildr 1.5.4 release

[Antoine Toulme]

+1

> On Sep 24, 2017, at 3:03 PM, Antoine Toulme  wrote:
> 
> We're voting on the source distributions available here:
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/
> 
> Specifically:
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/buildr-1.5.4.tgz
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/dist/buildr-1.5.4.zip
> 
> The documentation generated for this release is available here:
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/
> https://dist.apache.org/repos/dist/dev/buildr/1.5.4/site/buildr.pdf
> 
> The following changes were made since 1.5.3:
> 
>  * Added: BUILDR-732 - Support bnd version 2.1.0 or more. Submitted By Eric 
> Bruneton.
>  * Added: Support to compiling Kotlin
>  * Fixed: Remove section on development builds in the Contributing section.
>  * Added: New way to concatenate file contents when merging several archives 
> together.
>  * Added: New way to transform file contents when merging several archives 
> together.
>  * Fixed: Removed .class files from being checked in.
>  * Added: Support both Jetty 6 and Jetty 9 as addons. Added integration tests 
> to cover their use.