Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Vladimir Sitnikov]

Stamatis>It is worth mentioning that the build passed with the 3rd attempt.
In the
Stamatis>first attempts the build was stuck while performing style checking.

Do you have threaddumps?
Have you filed JIRA for the locking?

Vladimir

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Danny Chan]

I also agree that some commit messages are not that clear.

But, I what to make cleat that: keeping the commit message understandable is 
the duty of the code reviewer, if the commit message is problematic, how could 
the code be merged.

It is so hard to re-think what these commits really do because long time passes 
and there are 260+ commits, how could a release manager to keep every commit 
message “readable”.

So I would just ignore that ~

Best,
Danny Chan
在 2020年3月4日 +0800 AM7:20，Stamatis Zampetakis ，写道：
> Ubuntu 18.04.4 LTS, jdk 1.8.0_212, Gradle wrapper
>
> * Checked signatures and checksums OK
> * Build and run unit tests (./gradlew clean build) on git repo and staged
> sources OK
> It is worth mentioning that the build passed with the 3rd attempt. In the
> first attempts the build was stuck while performing style checking. I
> assume there is somewhere a race condition coming from the fact that I have
> many cores available on my machine (Intel Core i7-8850H) and the
> multi-threaded Gradle build.
> * Run slow tests on git repo (./gradlew testSlow) OK
> By the way on my machine the slow tests run in 7 minutes which is quite
> impressive and I think comes mostly from Vladimir's effort of enabling
> parallel execution and other improvements.
> * Checked diff between git commit and staged sources OK
> Small differences in the license structure but I brought this before and
> there does not seem to be a problem.
> * Went over the release note OK
> I outline at the end of this email a few minor remarks regarding the
> release notes.
>
> A big thanks to Danny for being the release manager and for also fixing the
> various problems that we encountered in the previous release candidates!
> Another big thanks to all those who tested this, and the previous RCs,
> against downstream projects. Ideally, we should be able to detect
> regressions before the RC phase but in any case it is better late than
> ever.
>
> I cannot give a +1 vote due to CALCITE-3839 and given that in the past we
> shooted down release candidates for less obvious reasons. I think we are
> lowering a bit our standards biased from the fact that we didn't have a
> release for quite some time. Anyways, I don't see CALCITE-3839 as a
> critical bug so I am fine with having another release rather soon.
>
> 0 (binding)
>
> Best,
> Stamatis
>
> * The release date should be updated after the to reflect the actual
> release date.
> * Should we really mention that the release has been tested with Apache
> Druid version 0.14.0-incubating? Did anybody run the tests against Druid? I
> tried to do it a few weeks ago but I had a few problems with setting up the
> VM in calcite-test-dataset.
> * I was under the impression that the Hint API would be experimental for
> some time but it seems in the end it was decided not to do so. I am not
> against it but I am just mentioning it to be sure that we are all in the
> same page.
>
> Below a few comments (nitpicking) for the following commits (entries of the
> release note).
> I am not saying that we should go and change everything now but as Julian
> mentioned in another email we should try to be more pedantic with the
> commit messages since they become our release notes (and should be
> understandable by end-users).
>
> [CALCITE-3437] ElasticSearch adapter. Support MatchQuery in elasticsearch
> (Shlok Srivastava)
> > The use of period could be avoided: Support MatchQuery in ElasticSearch
> adapter
> [CALCITE-3434] ElasticSearch schema with pathPrefix (Jeffery Zhang)
> > The message is not self-contained. Not sure if it is a bug or feature, or
> in general what has changed.
> Add hsqldb data sets (scott, foodmart and chinook) to SQLLine's path
> > Should we capitalize HSQLDB?
> [CALCITE-3606] Derive target table column list by mistake when convert
> TableModify to Sql string (JinXing)
> > The message is not clear.
> [CALCITE-3630] Improve ReduceExpressionsRule
> > The message is too general. What is the improvement?
> [CALCITE-3246] NullPointerException while deserializing udf operator (Wang
> Yanlin).
> > We do not use periods at the first line of the commit message nor at the
> summary of the JIRA.
> [CALCITE-3546] Improve EnumerableDefaults nested loop join Provide a new
> implementation of nested loop join that, unlike the existing one, does not
> require to build the complete result as a list before returning it.
> Instead, it iterates through the outer and inner enumerables and returns
> the results step by step.
> > Very long entry. Seems like a copy-edit problem or bug in the script
> generating the release notes.
> [CALCITE-3285] EnumerableMergeJoin should support non-equi join condions
> (Jin Xing)
> > This change has been reverted (and the JIRA has been reopened) so it
> shouldn't appear in the release notes.
> [CALCITE-3479] Stack overflow error thrown when running join queryi
> (Xiening Dai)
> > Typo queryi -> query and a bit general description. Every join query
> leads to stack overflow?
> 

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Danny Chan]

Thanks Julian and Stamatis, would fix the release note though ~

Best,
Danny Chan
在 2020年3月4日 +0800 AM7:20，Stamatis Zampetakis ，写道：
> Ubuntu 18.04.4 LTS, jdk 1.8.0_212, Gradle wrapper
>
> * Checked signatures and checksums OK
> * Build and run unit tests (./gradlew clean build) on git repo and staged
> sources OK
> It is worth mentioning that the build passed with the 3rd attempt. In the
> first attempts the build was stuck while performing style checking. I
> assume there is somewhere a race condition coming from the fact that I have
> many cores available on my machine (Intel Core i7-8850H) and the
> multi-threaded Gradle build.
> * Run slow tests on git repo (./gradlew testSlow) OK
> By the way on my machine the slow tests run in 7 minutes which is quite
> impressive and I think comes mostly from Vladimir's effort of enabling
> parallel execution and other improvements.
> * Checked diff between git commit and staged sources OK
> Small differences in the license structure but I brought this before and
> there does not seem to be a problem.
> * Went over the release note OK
> I outline at the end of this email a few minor remarks regarding the
> release notes.
>
> A big thanks to Danny for being the release manager and for also fixing the
> various problems that we encountered in the previous release candidates!
> Another big thanks to all those who tested this, and the previous RCs,
> against downstream projects. Ideally, we should be able to detect
> regressions before the RC phase but in any case it is better late than
> ever.
>
> I cannot give a +1 vote due to CALCITE-3839 and given that in the past we
> shooted down release candidates for less obvious reasons. I think we are
> lowering a bit our standards biased from the fact that we didn't have a
> release for quite some time. Anyways, I don't see CALCITE-3839 as a
> critical bug so I am fine with having another release rather soon.
>
> 0 (binding)
>
> Best,
> Stamatis
>
> * The release date should be updated after the to reflect the actual
> release date.
> * Should we really mention that the release has been tested with Apache
> Druid version 0.14.0-incubating? Did anybody run the tests against Druid? I
> tried to do it a few weeks ago but I had a few problems with setting up the
> VM in calcite-test-dataset.
> * I was under the impression that the Hint API would be experimental for
> some time but it seems in the end it was decided not to do so. I am not
> against it but I am just mentioning it to be sure that we are all in the
> same page.
>
> Below a few comments (nitpicking) for the following commits (entries of the
> release note).
> I am not saying that we should go and change everything now but as Julian
> mentioned in another email we should try to be more pedantic with the
> commit messages since they become our release notes (and should be
> understandable by end-users).
>
> [CALCITE-3437] ElasticSearch adapter. Support MatchQuery in elasticsearch
> (Shlok Srivastava)
> > The use of period could be avoided: Support MatchQuery in ElasticSearch
> adapter
> [CALCITE-3434] ElasticSearch schema with pathPrefix (Jeffery Zhang)
> > The message is not self-contained. Not sure if it is a bug or feature, or
> in general what has changed.
> Add hsqldb data sets (scott, foodmart and chinook) to SQLLine's path
> > Should we capitalize HSQLDB?
> [CALCITE-3606] Derive target table column list by mistake when convert
> TableModify to Sql string (JinXing)
> > The message is not clear.
> [CALCITE-3630] Improve ReduceExpressionsRule
> > The message is too general. What is the improvement?
> [CALCITE-3246] NullPointerException while deserializing udf operator (Wang
> Yanlin).
> > We do not use periods at the first line of the commit message nor at the
> summary of the JIRA.
> [CALCITE-3546] Improve EnumerableDefaults nested loop join Provide a new
> implementation of nested loop join that, unlike the existing one, does not
> require to build the complete result as a list before returning it.
> Instead, it iterates through the outer and inner enumerables and returns
> the results step by step.
> > Very long entry. Seems like a copy-edit problem or bug in the script
> generating the release notes.
> [CALCITE-3285] EnumerableMergeJoin should support non-equi join condions
> (Jin Xing)
> > This change has been reverted (and the JIRA has been reopened) so it
> shouldn't appear in the release notes.
> [CALCITE-3479] Stack overflow error thrown when running join queryi
> (Xiening Dai)
> > Typo queryi -> query and a bit general description. Every join query
> leads to stack overflow?
> [CALCITE-3376] VolcanoPlanner CannotPlanException: best rel is null even
> though there is an option with non-infinite cost Problem solved via
> CALCITE-2018, just add a unit test for this specific scenario
> > Very long entry. Seems like a copy-edit problem or bug in the script
> generating the release notes.
> [CALCITE-3383] Plural time units
> > The message is not self-contained. 

Re: [ANNOUNCE] New committer: Feng Zhu

[Xin Wang]

Congrats Feng!

- Xin

Kevin Risden  于2020年3月4日周三 上午2:32写道：

> Congrats Feng!
>
> Sounds like an interesting project.
>
> Kevin Risden
>
>
> On Sun, Mar 1, 2020 at 5:34 AM Feng Zhu  wrote:
>
> > Thanks Julian.
> > Let me make a brief introduction about the project.
> > SuperSQL relies on both Calcite and Avatica (with inner branch). It aims
> to
> > take the role as a unified entrance and middleware to connect various
> data
> > platforms in Tencent, including
> RDBMS、ES、Hive、Flink、Spark、Presto、ClickHouse
> > and some inner-built systems. They may be integrated as datasource or
> > execution engine.
> >
> > As we are still busy on migrating massive workloads and supporting
> in-house
> > business with SuperSQL, current now we do not have enough resources on
> > public release (e.g., presentation, talks or posts). Therefore, it is not
> > suprising that you wasn't aware of it before.
> >
> > Is it better to add the paragraph when we have website or an open-sourced
> > version (maybe several months later)?
> >
> > Tencent's logo can be found in bottom right-hand corner in (
> > https://www.tencent.com/en-us/index.html).
> > I think you can just pick up the english part (i.e. "Tencent").
> >
> > Best regards,
> > Feng
> >
> > Julian Hyde  于2020年3月1日周日 上午7:33写道：
> >
> > > Congratulations, thanks, and welcome!
> > >
> > > Feng, I wasn’t aware of Tencent’s SuperSQL project. It would be a great
> > > addition to the “powered by” page. If you would like to add it, please
> > > create a PR to add a paragraph to that page (no need for a JIRA case),
> > and
> > > provide a link to a logo for Tencent that I can add to the picture.
> > >
> > > Julian
> > >
> > >
> > >
> > > > On Feb 29, 2020, at 3:15 PM, Rui Wang  wrote:
> > > >
> > > > Congratulations Feng! Well deserved!
> > > >
> > > >
> > > >
> > > > -Rui
> > > >
> > > > On Sat, Feb 29, 2020 at 2:10 AM Feng Zhu 
> > wrote:
> > > >
> > > >> Thank you everyone for your warm welcome!
> > > >> Currently I am working at SuperSQL team of Tencent in Shenzhen,
> > > Guangdong,
> > > >> China.
> > > >> The project relies heavily on Calcite to analyze data residing in
> > > thousands
> > > >> of heterogeneous data sources.
> > > >>
> > > >> It is my greate honor to be part of the community. Calcite is an
> > > excellent
> > > >> and promising project!
> > > >> I will do my best to contribute to the project.
> > > >>
> > > >> Best regards,
> > > >> Feng
> > > >>
> > > >> Chunwei Lei  于2020年2月29日周六 下午4:46写道：
> > > >>
> > > >>> Congratulations！
> > > >>>
> > > >>>
> > > >>> Best,
> > > >>> Chunwei
> > > >>>
> > > >>>
> > > >>> On Sat, Feb 29, 2020 at 4:41 PM Danny Chan 
> > > wrote:
> > > >>>
> > >  Congratulations!
> > > 
> > >  Francis Chuang 于2020年2月29日 周六下午4:35写道：
> > > 
> > > > Congrats, well-deserved!
> > > >
> > > > On 29/02/2020 6:26 pm, Stamatis Zampetakis wrote:
> > > >> Apache Calcite's Project Management Committee (PMC) has invited
> > > >> Feng
> > > >> Zhu to become a committer, and we are pleased to announce that
> he
> > > >> has accepted.
> > > >>
> > > >> Feng is an active contributor and has contributed a lot of code
> to
> > > >>> some
> > > >> fairly complex parts of Calcite. He has been very helpful in
> > >  discussions
> > > >> and reviews, especially around code generation, and his work is
> > > >>> always
> > > >> of high quality.
> > > >>
> > > >> Feng, welcome, thank you for your contributions, and we look
> > > >> forward
> > > >> your further interactions with the community! If you wish,
> please
> > > >>> feel
> > > >> free to tell us more about yourself and what you are working on.
> > > >>
> > > >> Stamatis (on behalf of the Apache Calcite PMC)
> > > >>
> > > >
> > > 
> > > >>>
> > > >>
> > >
> > >
> >
>


-- 
Thanks,
Xin

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Stamatis Zampetakis]

Ubuntu 18.04.4 LTS, jdk 1.8.0_212, Gradle wrapper

* Checked signatures and checksums OK
* Build and run unit tests (./gradlew clean build) on git repo and staged
sources OK
It is worth mentioning that the build passed with the 3rd attempt. In the
first attempts the build was stuck while performing style checking. I
assume there is somewhere a race condition coming from the fact that I have
many cores available on my machine (Intel Core i7-8850H) and the
multi-threaded Gradle build.
* Run slow tests on git repo (./gradlew testSlow) OK
By the way on my machine the slow tests run in 7 minutes which is quite
impressive and I think comes mostly from Vladimir's effort of enabling
parallel execution and other improvements.
* Checked diff between git commit and staged sources OK
Small differences in the license structure but I brought this before and
there does not seem to be a problem.
* Went over the release note OK
I outline at the end of this email a few minor remarks regarding the
release notes.

A big thanks to Danny for being the release manager and for also fixing the
various problems that we encountered in the previous release candidates!
Another big thanks to all those who tested this, and the previous RCs,
against downstream projects. Ideally, we should be able to detect
regressions before the RC phase but in any case it is better late than
ever.

I cannot give a +1 vote due to CALCITE-3839 and given that in the past we
shooted down release candidates for less obvious reasons. I think we are
lowering a bit our standards biased from the fact that we didn't have a
release for quite some time. Anyways, I don't see CALCITE-3839 as a
critical bug so I am fine with having another release rather soon.

0 (binding)

Best,
Stamatis

* The release date should be updated after the to reflect the actual
release date.
* Should we really mention that the release has been tested with Apache
Druid version 0.14.0-incubating? Did anybody run the tests against Druid? I
tried to do it a few weeks ago but I had a few problems with setting up the
VM in calcite-test-dataset.
* I was under the impression that the Hint API would be experimental for
some time but it seems in the end it was decided not to do so. I am not
against it but I am just mentioning it to be sure that we are all in the
same page.

Below a few comments (nitpicking) for the following commits (entries of the
release note).
I am not saying that we should go and change everything now but as Julian
mentioned in another email we should try to be more pedantic with the
commit messages since they become our release notes (and should be
understandable by end-users).

[CALCITE-3437] ElasticSearch adapter. Support MatchQuery in elasticsearch
(Shlok Srivastava)
> The use of period could be avoided: Support MatchQuery in ElasticSearch
adapter
[CALCITE-3434] ElasticSearch schema with pathPrefix (Jeffery Zhang)
> The message is not self-contained. Not sure if it is a bug or feature, or
in general what has changed.
Add hsqldb data sets (scott, foodmart and chinook) to SQLLine's path
> Should we capitalize HSQLDB?
[CALCITE-3606] Derive target table column list by mistake when convert
TableModify to Sql string (JinXing)
> The message is not clear.
[CALCITE-3630] Improve ReduceExpressionsRule
> The message is too general. What is the improvement?
[CALCITE-3246] NullPointerException while deserializing udf operator (Wang
Yanlin).
> We do not use periods at the first line of the commit message nor at the
summary of the JIRA.
[CALCITE-3546] Improve EnumerableDefaults nested loop join Provide a new
implementation of nested loop join that, unlike the existing one, does not
require to build the complete result as a list before returning it.
Instead, it iterates through the outer and inner enumerables and returns
the results step by step.
> Very long entry. Seems like a copy-edit problem or bug in the script
generating the release notes.
[CALCITE-3285] EnumerableMergeJoin should support non-equi join condions
(Jin Xing)
> This change has been reverted (and the JIRA has been reopened) so it
shouldn't appear in the release notes.
[CALCITE-3479] Stack overflow error thrown when running join queryi
(Xiening Dai)
> Typo queryi -> query and a bit general description. Every join query
leads to stack overflow?
[CALCITE-3376] VolcanoPlanner CannotPlanException: best rel is null even
though there is an option with non-infinite cost Problem solved via
CALCITE-2018, just add a unit test for this specific scenario
> Very long entry. Seems like a copy-edit problem or bug in the script
generating the release notes.
[CALCITE-3383] Plural time units
> The message is not self-contained. Cannot understand what happend without
looking in the diff or in the JIRA issue.
[CALCITE-3389] Test may fail if HashSet iterates in different order
(contextshuffling)
> Which test?
[CALCITE-3381] When using BigQuery dialect, Rel2SQL converter converts SQL
types to BigQuery types (Rui Wang)
> The message is not 

Re: [ANNOUNCE] New committer: Feng Zhu

[Kevin Risden]

Congrats Feng!

Sounds like an interesting project.

Kevin Risden


On Sun, Mar 1, 2020 at 5:34 AM Feng Zhu  wrote:

> Thanks Julian.
> Let me make a brief introduction about the project.
> SuperSQL relies on both Calcite and Avatica (with inner branch). It aims to
> take the role as a unified entrance and middleware to connect various data
> platforms in Tencent, including RDBMS、ES、Hive、Flink、Spark、Presto、ClickHouse
> and some inner-built systems. They may be integrated as datasource or
> execution engine.
>
> As we are still busy on migrating massive workloads and supporting in-house
> business with SuperSQL, current now we do not have enough resources on
> public release (e.g., presentation, talks or posts). Therefore, it is not
> suprising that you wasn't aware of it before.
>
> Is it better to add the paragraph when we have website or an open-sourced
> version (maybe several months later)?
>
> Tencent's logo can be found in bottom right-hand corner in (
> https://www.tencent.com/en-us/index.html).
> I think you can just pick up the english part (i.e. "Tencent").
>
> Best regards,
> Feng
>
> Julian Hyde  于2020年3月1日周日 上午7:33写道：
>
> > Congratulations, thanks, and welcome!
> >
> > Feng, I wasn’t aware of Tencent’s SuperSQL project. It would be a great
> > addition to the “powered by” page. If you would like to add it, please
> > create a PR to add a paragraph to that page (no need for a JIRA case),
> and
> > provide a link to a logo for Tencent that I can add to the picture.
> >
> > Julian
> >
> >
> >
> > > On Feb 29, 2020, at 3:15 PM, Rui Wang  wrote:
> > >
> > > Congratulations Feng! Well deserved!
> > >
> > >
> > >
> > > -Rui
> > >
> > > On Sat, Feb 29, 2020 at 2:10 AM Feng Zhu 
> wrote:
> > >
> > >> Thank you everyone for your warm welcome!
> > >> Currently I am working at SuperSQL team of Tencent in Shenzhen,
> > Guangdong,
> > >> China.
> > >> The project relies heavily on Calcite to analyze data residing in
> > thousands
> > >> of heterogeneous data sources.
> > >>
> > >> It is my greate honor to be part of the community. Calcite is an
> > excellent
> > >> and promising project!
> > >> I will do my best to contribute to the project.
> > >>
> > >> Best regards,
> > >> Feng
> > >>
> > >> Chunwei Lei  于2020年2月29日周六 下午4:46写道：
> > >>
> > >>> Congratulations！
> > >>>
> > >>>
> > >>> Best,
> > >>> Chunwei
> > >>>
> > >>>
> > >>> On Sat, Feb 29, 2020 at 4:41 PM Danny Chan 
> > wrote:
> > >>>
> >  Congratulations!
> > 
> >  Francis Chuang 于2020年2月29日 周六下午4:35写道：
> > 
> > > Congrats, well-deserved!
> > >
> > > On 29/02/2020 6:26 pm, Stamatis Zampetakis wrote:
> > >> Apache Calcite's Project Management Committee (PMC) has invited
> > >> Feng
> > >> Zhu to become a committer, and we are pleased to announce that he
> > >> has accepted.
> > >>
> > >> Feng is an active contributor and has contributed a lot of code to
> > >>> some
> > >> fairly complex parts of Calcite. He has been very helpful in
> >  discussions
> > >> and reviews, especially around code generation, and his work is
> > >>> always
> > >> of high quality.
> > >>
> > >> Feng, welcome, thank you for your contributions, and we look
> > >> forward
> > >> your further interactions with the community! If you wish, please
> > >>> feel
> > >> free to tell us more about yourself and what you are working on.
> > >>
> > >> Stamatis (on behalf of the Apache Calcite PMC)
> > >>
> > >
> > 
> > >>>
> > >>
> >
> >
>

Re: [Discuss] Adapter's performance is not that fast

[Stamatis Zampetakis]

No need to apologise , I just wanted to make sure that you don't have a
problem in seing the emails on the dev list.



On Mon, Mar 2, 2020, 9:34 AM Xiangwei Wei  wrote:

> Hi.
>
> I'm so sorry about that. I'm new in Apache community and am not familiar
> with dev email.
>
> I wrote this letter from QQ Mail before, but I forgot to subscribe calcite
> dev then. So I subscribed it and resend the email from gmail which was the
> email replied by Haisheng before. I thought the email from QQ was lost
> because of unsubscribing, but somehow it appeared today. I'm so sorry...
>
> And thanks for reminding, I checked the email from Haisheng to ask further
> clarifications, I found the auto reply didn't add dev email..so you
> can't receive my reply. I will resend it then.
>
> PS：I replied this email from QQ just now, and..it disappeared again. I
> don't know whether it will appear later, but I wll never use it again..This
> email is from gmail.
>
> Stamatis Zampetakis  于2020年3月2日周一 下午3:54写道：
>
> > Hi Xiangwei,
> >
> > Haisheng already replied to this thread asking some further
> clarifications
> > [1].
> > Is there a reason that you are resending the email multiple times?
> >
> > Best,
> > Stamatis
> >
> > [1]
> >
> >
> https://lists.apache.org/thread.html/r0163d54fdf001ebc0303e3a796b2c41272c111bdac72e10a8dbb9a7c%40%3Cdev.calcite.apache.org%3E
> >
> > On Sat, Feb 29, 2020 at 11:51 PM 魏祥威 <526213...@qq.com> wrote:
> >
> > > Hi everyone.
> > >
> > >
> > > My name is Xiangwei Wei and I'm new here. I wrote an adapter for Apache
> > > IoTDB recently which isa database for time series data management
> > to
> > > support use of Apache Calcite.
> > >
> > >
> > > However, when I finished it and tried to test its performance, I
> > > foundthe adapter's performance was not that fast. It took much
> time
> > > compared with the raw data query in the database backend. I thought
> maybe
> > > it was the problem of my adapter. So I did the same test on the
> Cassandra
> > > Adapter which is provided by Calcite source code. But it shew similar
> > > result.
> > >
> > >
> > > Executing a simple query using Cassandra Adapter takes about 1600ms -
> > > 1800ms on my PC. However, it costs only 5 ms to do the raw data query
> in
> > > the Cassandra database backend. Is this the general performance of
> > > adapters? Or I made something wrong?
> > >
> > >
> > > I did the test by writing a simple JDBC program to do query using
> > standard
> > > sql. For Cassandra Adapter, I used the data proviced in
> > > "./cassandra/src/test/resources/twissandra.cql" and a simple sql
> > statement
> > > provided in the CassandraAdapterTest which is "select * from
> \"userline\"
> > > where \"username\"='!PUBLIC!'".
> > >
> > >
> > > Best,
> > > Xiangwei Wei
> > >
> > >
> > >
> > > 
> >
>
>
> --
> Best,
> Xiangwei Wei
>

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Ruben Q L]

 +1 (non binding)
Local Calcite build with tests (Windows10 + JDK8): OK
Calcite-based application test suite: OK



Le mar. 3 mars 2020 à 11:11, Enrico Olivelli  a écrit :

> +1 (non binding)
> Run tests locally (on Mac + JDK13)
> Run tests of HerdDB and a bunch of know applications that are using HerdDB
>
> Thank you Danny
>
> Enrico
>
> Il giorno mar 3 mar 2020 alle ore 11:06 Feng Zhu
>  ha scritto:
> >
> > Hi Danny, thanks for your continuous effort!
> >
> > +1 (non-binding)
> >
> > - Build and Test (./gradlew build) - OK
> > - Checked Release Notes - OK
> > - Checked README - OK
> > - Validate gpg signature - OK
> > Environment 1: Windows 7, JDK 1.8.0_121
> > Environment 2: Mac OS X 10.15.1, JDK 1.8.0_231_b11
> >
> > Bests,
> > Feng
> >
> > Danny Chan  于2020年3月2日周一 下午9:28写道：
> >
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.22.0, release
> > > candidate 3.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> > >
> > > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> > >
> > > Tag:
> > > https://github.com/apache/calcite/tree/v1.22.0-rc3
> > >
> > > The artifacts to be voted on are located here:
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> > > (revision 38350)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> > >
> a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> > > *apache-calcite-1.22.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> > >
> https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/danny0405.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > N.B.
> > > To create the jars and test Apache Calcite: "./gradlew build".
> > >
> > > If you do not have a Java environment available, you can run the tests
> > > using docker. To do so, install docker and docker-compose, then run
> > > "docker-compose run test" from the root of the directory.
> > >
> > > Please vote on releasing this package as Apache Calcite 1.22.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.22.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Best,
> > > Danny Chan
> > >
>

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Enrico Olivelli]

+1 (non binding)
Run tests locally (on Mac + JDK13)
Run tests of HerdDB and a bunch of know applications that are using HerdDB

Thank you Danny

Enrico

Il giorno mar 3 mar 2020 alle ore 11:06 Feng Zhu
 ha scritto:
>
> Hi Danny, thanks for your continuous effort!
>
> +1 (non-binding)
>
> - Build and Test (./gradlew build) - OK
> - Checked Release Notes - OK
> - Checked README - OK
> - Validate gpg signature - OK
> Environment 1: Windows 7, JDK 1.8.0_121
> Environment 2: Mac OS X 10.15.1, JDK 1.8.0_231_b11
>
> Bests,
> Feng
>
> Danny Chan  于2020年3月2日周一 下午9:28写道：
>
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.22.0, release
> > candidate 3.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> > https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> >
> > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> >
> > Tag:
> > https://github.com/apache/calcite/tree/v1.22.0-rc3
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> > (revision 38350)
> >
> > The hashes of the artifacts are as follows:
> >
> > a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> > *apache-calcite-1.22.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> > https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/danny0405.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > N.B.
> > To create the jars and test Apache Calcite: "./gradlew build".
> >
> > If you do not have a Java environment available, you can run the tests
> > using docker. To do so, install docker and docker-compose, then run
> > "docker-compose run test" from the root of the directory.
> >
> > Please vote on releasing this package as Apache Calcite 1.22.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.22.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Best,
> > Danny Chan
> >

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Feng Zhu]

Hi Danny, thanks for your continuous effort!

+1 (non-binding)

- Build and Test (./gradlew build) - OK
- Checked Release Notes - OK
- Checked README - OK
- Validate gpg signature - OK
Environment 1: Windows 7, JDK 1.8.0_121
Environment 2: Mac OS X 10.15.1, JDK 1.8.0_231_b11

Bests,
Feng

Danny Chan  于2020年3月2日周一 下午9:28写道：

> Hi all,
>
> I have created a build for Apache Calcite 1.22.0, release
> candidate 3.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
>
> Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
>
> Tag:
> https://github.com/apache/calcite/tree/v1.22.0-rc3
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> (revision 38350)
>
> The hashes of the artifacts are as follows:
>
> a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> *apache-calcite-1.22.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/danny0405.asc
> https://www.apache.org/dist/calcite/KEYS
>
> N.B.
> To create the jars and test Apache Calcite: "./gradlew build".
>
> If you do not have a Java environment available, you can run the tests
> using docker. To do so, install docker and docker-compose, then run
> "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite 1.22.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.22.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Danny Chan
>

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Anton Haidai]

While it is not a part of our daily CI, we are taking measures to detect
Calcite's regressions early, including several preliminary integrations
with Calcite's master between Calcite's releases.
Let me once again highlight that this unfortunate situation with the late
detection of CALCITE-3839
 was caused by an
unlucky timing of our new feature merge and not by a lack of CI.

On Tue, Mar 3, 2020 at 3:49 AM Francis Chuang 
wrote:

> On 3/03/2020 12:31 pm, Julian Hyde wrote:
> > We can discuss the proposal to add other products' test suites to CI.
> > I think it would cause more work for us (triaging false-negative
> > problems). And lots of important downstream projects do not have a
> > public test suite.
>
> Apologies for not being clearer, the comment regarding testing against
> Calcite master in CI daily was directed towards Anton.
>
> It would not be practical for Calcite to run test suites for all of its
> consumers. Consumers should be proactive in testing against our master
> to detect regressions and breaking changes.
>


-- 
Best regards,
Anton.