[CANCEL][VOTE] Release Apache Calcite 1.37.0 (release candidate 1)
Cancel this thread, due to CALCITE-6385[1] issue in the build. Thanks to Stamatis for highlighting this. Will start another vote once the issue will be fixed and merged. [1] https://issues.apache.org/jira/browse/CALCITE-6385 -- Best regards, Sergey
Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)
Yes, agree, CALCITE-6385 is a blocker. I'll cancel the vote. Thanks for finding this, Stamatis, thanks Ruben for clarification, and thanks for all who took the time to vote. On Wed, Apr 24, 2024 at 2:01 PM Ruben Q L wrote: > I think Stamatis is right. We should cancel this vote, fix CALCITE-6385 and > produce a new RC. > > Best, > Ruben > > > On Wed, Apr 24, 2024 at 12:50 PM Sergey Nuyanzin > wrote: > > > Thanks Stamatis for signalling this issue > > > > I think we need to put Blocker priority on this jira issue > > (CALCITE-6385[1]) if we consider it as a no go for the release (please > > correct me if I'm wrong) > > > > [1] https://issues.apache.org/jira/browse/CALCITE-6385 > > > > On Wed, Apr 24, 2024 at 11:59 AM Stamatis Zampetakis > > wrote: > > > > > Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.6.1 > > > > > > * Checked signatures and checksums OK > > > * Checked diff between repo and artifacts OK > > > * Went over release note OK (Left comments in the PR) > > > * Checked README, NOTICE, LICENSE OK > > > * All source files have ASF headers OK (raised [1] for two files > > > where header is needed) > > > * No unexpected binary files OK (find . -type f -exec file {} \; | > > > grep -v text) > > > * Checked LICENSE, NOTICE, signature, and checksum for > > > calcite-core-1.37.0.jar in nexus [2] OK > > > * Built from git tag and run tests (./gradlew build) OK > > > * Built from source artifacts and run tests (gradle build) KO (Logged > > > CALCITE-6385 [3]) > > > > > > -1 (binding) > > > > > > The negative vote is mainly due to CALCITE-6385. Although the test > > > failure is rather innocent, it makes the build fail so users building > > > from source may have a hard time figuring out what happens. > > > > > > Best, > > > Stamatis > > > > > > [1] https://issues.apache.org/jira/browse/CALCITE-6384 > > > [2] > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1225/org/apache/calcite/calcite-core/1.37.0/ > > > [3] https://issues.apache.org/jira/browse/CALCITE-6385 > > > > > > On Wed, Apr 24, 2024 at 11:25 AM Benchao Li > > wrote: > > > > > > > > +1 (binding) > > > > > > > > - Checked signature and checksum (OK) > > > > - Checked LICENSE and Copyright year (OK) > > > > - Checked there are no unexpected binary files (OK) > > > > - Build and test from source (testContributorsFileIsSorted and > > > > testMailmapFile in LintTest failed due to not in git repo) > > > > - Reviewed release note, left some comments which can be resolved > > > > after the release > > > > > > > > Ruben Q L 于2024年4月23日周二 16:57写道: > > > > > > > > > > Thanks Sergey for preparing this release. > > > > > Just a minor clarification: the email subject says "release > candidate > > > 1", > > > > > but we are actually voting rc0. > > > > > > > > > > - Release notes: ok (with some minor comments that I have left in > the > > > PR) > > > > > - Checksum: ok > > > > > - Signature: ok > > > > > - Diff source release and git repository: ok > > > > > - Build + tests: ok > > > > > - Calcite-based application test suite: ok > > > > > > > > > > +1 (binding) > > > > > > > > > > Best, > > > > > Ruben > > > > > > > > > > > > > > > > > > > > On Tue, Apr 23, 2024 at 12:55 AM Francis Chuang < > > > francischu...@apache.org> > > > > > wrote: > > > > > > > > > > > Thanks for being RM for this release, Sergey! > > > > > > > > > > > > My vote is: +1 (binding) > > > > > > > > > > > > - Verified GPG signature - OK > > > > > > - Verified SHA512 - OK > > > > > > - Diffed source release and git repository - OK > > > > > > - Checked release notes on tag > > > > > > ( > > > > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md > > > ) > > > > > > > > > > > > - OK > > > > > > - Checked year and versions in NOTICE, README and HOWTO - OK > > > > > > - Ran tests (gradle check) - OK > > > > > > - Spot checked Nexus artifacts - OK > > > > > > > > > > > > Minor issue with the release notes that should be fixed after the > > > > > > release: Some of the contributors are listed as their GitHub > > > usernames, > > > > > > I think it would be better to put in their real names if they are > > > known. > > > > > > These can usually be retrieved from their GitHub profiles. > > > > > > > > > > > > Environment: > > > > > > Eclipse-temurin:8 docker container in WSL2 (Ubuntu 22.04.4) on > > > Windows > > > > > > 11 23h2 > > > > > > > > > > > > $ docker version > > > > > > Client: > > > > > > Cloud integration: v1.0.35+desktop.13 > > > > > > Version: 26.0.0 > > > > > > API version: 1.45 > > > > > > Go version:go1.21.8 > > > > > > Git commit:2ae903e > > > > > > Built: Wed Mar 20 15:16:45 2024 > > > > > > OS/Arch: linux/amd64 > > > > > > Context: default > > > > > > > > > > > > Server: Docker Desktop > > > > > > Engine: > > > > > >Version: 26.0.0 > > > > > >API version: 1.45 (minimum
Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)
I think Stamatis is right. We should cancel this vote, fix CALCITE-6385 and produce a new RC. Best, Ruben On Wed, Apr 24, 2024 at 12:50 PM Sergey Nuyanzin wrote: > Thanks Stamatis for signalling this issue > > I think we need to put Blocker priority on this jira issue > (CALCITE-6385[1]) if we consider it as a no go for the release (please > correct me if I'm wrong) > > [1] https://issues.apache.org/jira/browse/CALCITE-6385 > > On Wed, Apr 24, 2024 at 11:59 AM Stamatis Zampetakis > wrote: > > > Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.6.1 > > > > * Checked signatures and checksums OK > > * Checked diff between repo and artifacts OK > > * Went over release note OK (Left comments in the PR) > > * Checked README, NOTICE, LICENSE OK > > * All source files have ASF headers OK (raised [1] for two files > > where header is needed) > > * No unexpected binary files OK (find . -type f -exec file {} \; | > > grep -v text) > > * Checked LICENSE, NOTICE, signature, and checksum for > > calcite-core-1.37.0.jar in nexus [2] OK > > * Built from git tag and run tests (./gradlew build) OK > > * Built from source artifacts and run tests (gradle build) KO (Logged > > CALCITE-6385 [3]) > > > > -1 (binding) > > > > The negative vote is mainly due to CALCITE-6385. Although the test > > failure is rather innocent, it makes the build fail so users building > > from source may have a hard time figuring out what happens. > > > > Best, > > Stamatis > > > > [1] https://issues.apache.org/jira/browse/CALCITE-6384 > > [2] > > > https://repository.apache.org/content/repositories/orgapachecalcite-1225/org/apache/calcite/calcite-core/1.37.0/ > > [3] https://issues.apache.org/jira/browse/CALCITE-6385 > > > > On Wed, Apr 24, 2024 at 11:25 AM Benchao Li > wrote: > > > > > > +1 (binding) > > > > > > - Checked signature and checksum (OK) > > > - Checked LICENSE and Copyright year (OK) > > > - Checked there are no unexpected binary files (OK) > > > - Build and test from source (testContributorsFileIsSorted and > > > testMailmapFile in LintTest failed due to not in git repo) > > > - Reviewed release note, left some comments which can be resolved > > > after the release > > > > > > Ruben Q L 于2024年4月23日周二 16:57写道: > > > > > > > > Thanks Sergey for preparing this release. > > > > Just a minor clarification: the email subject says "release candidate > > 1", > > > > but we are actually voting rc0. > > > > > > > > - Release notes: ok (with some minor comments that I have left in the > > PR) > > > > - Checksum: ok > > > > - Signature: ok > > > > - Diff source release and git repository: ok > > > > - Build + tests: ok > > > > - Calcite-based application test suite: ok > > > > > > > > +1 (binding) > > > > > > > > Best, > > > > Ruben > > > > > > > > > > > > > > > > On Tue, Apr 23, 2024 at 12:55 AM Francis Chuang < > > francischu...@apache.org> > > > > wrote: > > > > > > > > > Thanks for being RM for this release, Sergey! > > > > > > > > > > My vote is: +1 (binding) > > > > > > > > > > - Verified GPG signature - OK > > > > > - Verified SHA512 - OK > > > > > - Diffed source release and git repository - OK > > > > > - Checked release notes on tag > > > > > ( > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md > > ) > > > > > > > > > > - OK > > > > > - Checked year and versions in NOTICE, README and HOWTO - OK > > > > > - Ran tests (gradle check) - OK > > > > > - Spot checked Nexus artifacts - OK > > > > > > > > > > Minor issue with the release notes that should be fixed after the > > > > > release: Some of the contributors are listed as their GitHub > > usernames, > > > > > I think it would be better to put in their real names if they are > > known. > > > > > These can usually be retrieved from their GitHub profiles. > > > > > > > > > > Environment: > > > > > Eclipse-temurin:8 docker container in WSL2 (Ubuntu 22.04.4) on > > Windows > > > > > 11 23h2 > > > > > > > > > > $ docker version > > > > > Client: > > > > > Cloud integration: v1.0.35+desktop.13 > > > > > Version: 26.0.0 > > > > > API version: 1.45 > > > > > Go version:go1.21.8 > > > > > Git commit:2ae903e > > > > > Built: Wed Mar 20 15:16:45 2024 > > > > > OS/Arch: linux/amd64 > > > > > Context: default > > > > > > > > > > Server: Docker Desktop > > > > > Engine: > > > > >Version: 26.0.0 > > > > >API version: 1.45 (minimum version 1.24) > > > > >Go version: go1.21.8 > > > > >Git commit: 8b79278 > > > > >Built:Wed Mar 20 15:18:01 2024 > > > > >OS/Arch: linux/amd64 > > > > >Experimental: false > > > > > containerd: > > > > >Version: 1.6.28 > > > > >GitCommit:ae07eda36dd25f8a1b98dfbf587313b99c0190bb > > > > > runc: > > > > >Version: 1.1.12 > > > > >GitCommit:v1.1.12-0-g51d5e94 > > > > > docker-init: > > > > >
Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)
Thanks Stamatis for signalling this issue I think we need to put Blocker priority on this jira issue (CALCITE-6385[1]) if we consider it as a no go for the release (please correct me if I'm wrong) [1] https://issues.apache.org/jira/browse/CALCITE-6385 On Wed, Apr 24, 2024 at 11:59 AM Stamatis Zampetakis wrote: > Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.6.1 > > * Checked signatures and checksums OK > * Checked diff between repo and artifacts OK > * Went over release note OK (Left comments in the PR) > * Checked README, NOTICE, LICENSE OK > * All source files have ASF headers OK (raised [1] for two files > where header is needed) > * No unexpected binary files OK (find . -type f -exec file {} \; | > grep -v text) > * Checked LICENSE, NOTICE, signature, and checksum for > calcite-core-1.37.0.jar in nexus [2] OK > * Built from git tag and run tests (./gradlew build) OK > * Built from source artifacts and run tests (gradle build) KO (Logged > CALCITE-6385 [3]) > > -1 (binding) > > The negative vote is mainly due to CALCITE-6385. Although the test > failure is rather innocent, it makes the build fail so users building > from source may have a hard time figuring out what happens. > > Best, > Stamatis > > [1] https://issues.apache.org/jira/browse/CALCITE-6384 > [2] > https://repository.apache.org/content/repositories/orgapachecalcite-1225/org/apache/calcite/calcite-core/1.37.0/ > [3] https://issues.apache.org/jira/browse/CALCITE-6385 > > On Wed, Apr 24, 2024 at 11:25 AM Benchao Li wrote: > > > > +1 (binding) > > > > - Checked signature and checksum (OK) > > - Checked LICENSE and Copyright year (OK) > > - Checked there are no unexpected binary files (OK) > > - Build and test from source (testContributorsFileIsSorted and > > testMailmapFile in LintTest failed due to not in git repo) > > - Reviewed release note, left some comments which can be resolved > > after the release > > > > Ruben Q L 于2024年4月23日周二 16:57写道: > > > > > > Thanks Sergey for preparing this release. > > > Just a minor clarification: the email subject says "release candidate > 1", > > > but we are actually voting rc0. > > > > > > - Release notes: ok (with some minor comments that I have left in the > PR) > > > - Checksum: ok > > > - Signature: ok > > > - Diff source release and git repository: ok > > > - Build + tests: ok > > > - Calcite-based application test suite: ok > > > > > > +1 (binding) > > > > > > Best, > > > Ruben > > > > > > > > > > > > On Tue, Apr 23, 2024 at 12:55 AM Francis Chuang < > francischu...@apache.org> > > > wrote: > > > > > > > Thanks for being RM for this release, Sergey! > > > > > > > > My vote is: +1 (binding) > > > > > > > > - Verified GPG signature - OK > > > > - Verified SHA512 - OK > > > > - Diffed source release and git repository - OK > > > > - Checked release notes on tag > > > > ( > > > > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md > ) > > > > > > > > - OK > > > > - Checked year and versions in NOTICE, README and HOWTO - OK > > > > - Ran tests (gradle check) - OK > > > > - Spot checked Nexus artifacts - OK > > > > > > > > Minor issue with the release notes that should be fixed after the > > > > release: Some of the contributors are listed as their GitHub > usernames, > > > > I think it would be better to put in their real names if they are > known. > > > > These can usually be retrieved from their GitHub profiles. > > > > > > > > Environment: > > > > Eclipse-temurin:8 docker container in WSL2 (Ubuntu 22.04.4) on > Windows > > > > 11 23h2 > > > > > > > > $ docker version > > > > Client: > > > > Cloud integration: v1.0.35+desktop.13 > > > > Version: 26.0.0 > > > > API version: 1.45 > > > > Go version:go1.21.8 > > > > Git commit:2ae903e > > > > Built: Wed Mar 20 15:16:45 2024 > > > > OS/Arch: linux/amd64 > > > > Context: default > > > > > > > > Server: Docker Desktop > > > > Engine: > > > >Version: 26.0.0 > > > >API version: 1.45 (minimum version 1.24) > > > >Go version: go1.21.8 > > > >Git commit: 8b79278 > > > >Built:Wed Mar 20 15:18:01 2024 > > > >OS/Arch: linux/amd64 > > > >Experimental: false > > > > containerd: > > > >Version: 1.6.28 > > > >GitCommit:ae07eda36dd25f8a1b98dfbf587313b99c0190bb > > > > runc: > > > >Version: 1.1.12 > > > >GitCommit:v1.1.12-0-g51d5e94 > > > > docker-init: > > > >Version: 0.19.0 > > > >GitCommit:de40ad0 > > > > > > > > $ gradle -v > > > > > > > > > > > > Gradle 7.6.1 > > > > > > > > > > > > Build time: 2023-02-24 13:54:42 UTC > > > > Revision: 3905fe8ac072bbd925c70ddbf4463341f4b4 > > > > > > > > Kotlin: 1.7.10 > > > > Groovy: 3.0.13 > >
Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)
Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.6.1 * Checked signatures and checksums OK * Checked diff between repo and artifacts OK * Went over release note OK (Left comments in the PR) * Checked README, NOTICE, LICENSE OK * All source files have ASF headers OK (raised [1] for two files where header is needed) * No unexpected binary files OK (find . -type f -exec file {} \; | grep -v text) * Checked LICENSE, NOTICE, signature, and checksum for calcite-core-1.37.0.jar in nexus [2] OK * Built from git tag and run tests (./gradlew build) OK * Built from source artifacts and run tests (gradle build) KO (Logged CALCITE-6385 [3]) -1 (binding) The negative vote is mainly due to CALCITE-6385. Although the test failure is rather innocent, it makes the build fail so users building from source may have a hard time figuring out what happens. Best, Stamatis [1] https://issues.apache.org/jira/browse/CALCITE-6384 [2] https://repository.apache.org/content/repositories/orgapachecalcite-1225/org/apache/calcite/calcite-core/1.37.0/ [3] https://issues.apache.org/jira/browse/CALCITE-6385 On Wed, Apr 24, 2024 at 11:25 AM Benchao Li wrote: > > +1 (binding) > > - Checked signature and checksum (OK) > - Checked LICENSE and Copyright year (OK) > - Checked there are no unexpected binary files (OK) > - Build and test from source (testContributorsFileIsSorted and > testMailmapFile in LintTest failed due to not in git repo) > - Reviewed release note, left some comments which can be resolved > after the release > > Ruben Q L 于2024年4月23日周二 16:57写道: > > > > Thanks Sergey for preparing this release. > > Just a minor clarification: the email subject says "release candidate 1", > > but we are actually voting rc0. > > > > - Release notes: ok (with some minor comments that I have left in the PR) > > - Checksum: ok > > - Signature: ok > > - Diff source release and git repository: ok > > - Build + tests: ok > > - Calcite-based application test suite: ok > > > > +1 (binding) > > > > Best, > > Ruben > > > > > > > > On Tue, Apr 23, 2024 at 12:55 AM Francis Chuang > > wrote: > > > > > Thanks for being RM for this release, Sergey! > > > > > > My vote is: +1 (binding) > > > > > > - Verified GPG signature - OK > > > - Verified SHA512 - OK > > > - Diffed source release and git repository - OK > > > - Checked release notes on tag > > > ( > > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md) > > > > > > - OK > > > - Checked year and versions in NOTICE, README and HOWTO - OK > > > - Ran tests (gradle check) - OK > > > - Spot checked Nexus artifacts - OK > > > > > > Minor issue with the release notes that should be fixed after the > > > release: Some of the contributors are listed as their GitHub usernames, > > > I think it would be better to put in their real names if they are known. > > > These can usually be retrieved from their GitHub profiles. > > > > > > Environment: > > > Eclipse-temurin:8 docker container in WSL2 (Ubuntu 22.04.4) on Windows > > > 11 23h2 > > > > > > $ docker version > > > Client: > > > Cloud integration: v1.0.35+desktop.13 > > > Version: 26.0.0 > > > API version: 1.45 > > > Go version:go1.21.8 > > > Git commit:2ae903e > > > Built: Wed Mar 20 15:16:45 2024 > > > OS/Arch: linux/amd64 > > > Context: default > > > > > > Server: Docker Desktop > > > Engine: > > >Version: 26.0.0 > > >API version: 1.45 (minimum version 1.24) > > >Go version: go1.21.8 > > >Git commit: 8b79278 > > >Built:Wed Mar 20 15:18:01 2024 > > >OS/Arch: linux/amd64 > > >Experimental: false > > > containerd: > > >Version: 1.6.28 > > >GitCommit:ae07eda36dd25f8a1b98dfbf587313b99c0190bb > > > runc: > > >Version: 1.1.12 > > >GitCommit:v1.1.12-0-g51d5e94 > > > docker-init: > > >Version: 0.19.0 > > >GitCommit:de40ad0 > > > > > > $ gradle -v > > > > > > > > > Gradle 7.6.1 > > > > > > > > > Build time: 2023-02-24 13:54:42 UTC > > > Revision: 3905fe8ac072bbd925c70ddbf4463341f4b4 > > > > > > Kotlin: 1.7.10 > > > Groovy: 3.0.13 > > > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 > > > JVM: 1.8.0_402 (Temurin 25.402-b06) > > > OS: Linux 5.15.146.1-microsoft-standard-WSL2 amd64 > > > > > > $ java -version > > > openjdk version "1.8.0_402" > > > OpenJDK Runtime Environment (Temurin)(build 1.8.0_402-b06) > > > OpenJDK 64-Bit Server VM (Temurin)(build 25.402-b06, mixed mode) > > > > > > Francis > > > > > > On 23/04/2024 9:18 am, Sergey Nuyanzin wrote: > > > > Hi all, > > > > > > > > I have created a build for Apache Calcite 1.37.0, release > > > > candidate 0. > > > > > > > > Thanks to everyone who
[jira] [Created] (CALCITE-6385) LintTest fails when run in source distribution
Stamatis Zampetakis created CALCITE-6385: Summary: LintTest fails when run in source distribution Key: CALCITE-6385 URL: https://issues.apache.org/jira/browse/CALCITE-6385 Project: Calcite Issue Type: Bug Affects Versions: 1.36.0 Reporter: Stamatis Zampetakis Assignee: Stamatis Zampetakis Steps to reproduce: # Download [https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz] # tar -xvf apache-calcite-1.37.0-src.tar.gz # cd apache-calcite-1.37.0-src # /opt/gradle/gradle-7.6.1/bin/gradle cleanTest :core:test --tests LintTest {noformat} FAILURE 0.1sec, org.apache.calcite.test.LintTest > testContributorsFileIsSorted() java.lang.RuntimeException: command [git, ls-files, *.bat, *.cmd, *.csv, *.fmpp, *.ftl, *.iq, *.java, *.json, *.jj, *.kt, *.kts, .mailmap, *.md, *.properties, *.sh, *.sql, *.txt, *.xml, *.yaml, *.yml]: failed with exception at org.apache.calcite.util.TestUnsafe.getGitFiles(TestUnsafe.java:185) at org.apache.calcite.util.TestUnsafe.getTextFiles(TestUnsafe.java:158) at org.apache.calcite.test.LintTest.testContributorsFileIsSorted(LintTest.java:400) Caused by: java.lang.RuntimeException: command [git, ls-files, *.bat, *.cmd, *.csv, *.fmpp, *.ftl, *.iq, *.java, *.json, *.jj, *.kt, *.kts, .mailmap, *.md, *.properties, *.sh, *.sql, *.txt, *.xml, *.yaml, *.yml]: exited with status 128 at org.apache.calcite.util.TestUnsafe.getGitFiles(TestUnsafe.java:180) ... 2 more FAILURE 0.0sec, org.apache.calcite.test.LintTest > testMailmapFile() java.lang.RuntimeException: command [git, ls-files, *.bat, *.cmd, *.csv, *.fmpp, *.ftl, *.iq, *.java, *.json, *.jj, *.kt, *.kts, .mailmap, *.md, *.properties, *.sh, *.sql, *.txt, *.xml, *.yaml, *.yml]: failed with exception at org.apache.calcite.util.TestUnsafe.getGitFiles(TestUnsafe.java:185) at org.apache.calcite.util.TestUnsafe.getTextFiles(TestUnsafe.java:158) at org.apache.calcite.test.LintTest.testMailmapFile(LintTest.java:419) Caused by: java.lang.RuntimeException: command [git, ls-files, *.bat, *.cmd, *.csv, *.fmpp, *.ftl, *.iq, *.java, *.json, *.jj, *.kt, *.kts, .mailmap, *.md, *.properties, *.sh, *.sql, *.txt, *.xml, *.yaml, *.yml]: exited with status 128 at org.apache.calcite.util.TestUnsafe.getGitFiles(TestUnsafe.java:180) ... 2 more FAILURE 0.1sec,6 completed, 2 failed, 2 skipped, org.apache.calcite.test.LintTest {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)
+1 (binding) - Checked signature and checksum (OK) - Checked LICENSE and Copyright year (OK) - Checked there are no unexpected binary files (OK) - Build and test from source (testContributorsFileIsSorted and testMailmapFile in LintTest failed due to not in git repo) - Reviewed release note, left some comments which can be resolved after the release Ruben Q L 于2024年4月23日周二 16:57写道: > > Thanks Sergey for preparing this release. > Just a minor clarification: the email subject says "release candidate 1", > but we are actually voting rc0. > > - Release notes: ok (with some minor comments that I have left in the PR) > - Checksum: ok > - Signature: ok > - Diff source release and git repository: ok > - Build + tests: ok > - Calcite-based application test suite: ok > > +1 (binding) > > Best, > Ruben > > > > On Tue, Apr 23, 2024 at 12:55 AM Francis Chuang > wrote: > > > Thanks for being RM for this release, Sergey! > > > > My vote is: +1 (binding) > > > > - Verified GPG signature - OK > > - Verified SHA512 - OK > > - Diffed source release and git repository - OK > > - Checked release notes on tag > > ( > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md) > > > > - OK > > - Checked year and versions in NOTICE, README and HOWTO - OK > > - Ran tests (gradle check) - OK > > - Spot checked Nexus artifacts - OK > > > > Minor issue with the release notes that should be fixed after the > > release: Some of the contributors are listed as their GitHub usernames, > > I think it would be better to put in their real names if they are known. > > These can usually be retrieved from their GitHub profiles. > > > > Environment: > > Eclipse-temurin:8 docker container in WSL2 (Ubuntu 22.04.4) on Windows > > 11 23h2 > > > > $ docker version > > Client: > > Cloud integration: v1.0.35+desktop.13 > > Version: 26.0.0 > > API version: 1.45 > > Go version:go1.21.8 > > Git commit:2ae903e > > Built: Wed Mar 20 15:16:45 2024 > > OS/Arch: linux/amd64 > > Context: default > > > > Server: Docker Desktop > > Engine: > >Version: 26.0.0 > >API version: 1.45 (minimum version 1.24) > >Go version: go1.21.8 > >Git commit: 8b79278 > >Built:Wed Mar 20 15:18:01 2024 > >OS/Arch: linux/amd64 > >Experimental: false > > containerd: > >Version: 1.6.28 > >GitCommit:ae07eda36dd25f8a1b98dfbf587313b99c0190bb > > runc: > >Version: 1.1.12 > >GitCommit:v1.1.12-0-g51d5e94 > > docker-init: > >Version: 0.19.0 > >GitCommit:de40ad0 > > > > $ gradle -v > > > > > > Gradle 7.6.1 > > > > > > Build time: 2023-02-24 13:54:42 UTC > > Revision: 3905fe8ac072bbd925c70ddbf4463341f4b4 > > > > Kotlin: 1.7.10 > > Groovy: 3.0.13 > > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 > > JVM: 1.8.0_402 (Temurin 25.402-b06) > > OS: Linux 5.15.146.1-microsoft-standard-WSL2 amd64 > > > > $ java -version > > openjdk version "1.8.0_402" > > OpenJDK Runtime Environment (Temurin)(build 1.8.0_402-b06) > > OpenJDK 64-Bit Server VM (Temurin)(build 25.402-b06, mixed mode) > > > > Francis > > > > On 23/04/2024 9:18 am, Sergey Nuyanzin wrote: > > > Hi all, > > > > > > I have created a build for Apache Calcite 1.37.0, release > > > candidate 0. > > > > > > Thanks to everyone who has contributed to this release. > > > > > > You can read the release notes here: > > > > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md > > > > > > The commit to be voted upon: > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=53fd905eb4c730b4bedd49fa6569d5b0de47f021 > > > > > > Its hash is 53fd905eb4c730b4bedd49fa6569d5b0de47f021 > > > > > > Tag: > > > https://github.com/apache/calcite/tree/calcite-1.37.0-rc0 > > > > > > The artifacts to be voted on are located here: > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.37.0-rc0 > > > (revision 68720) > > > > > > The hashes of the artifacts are as follows: > > > > > b044fb94fd60710142edfe348ff20bbdc7e43f3d70a68b6520b65dc8fb2fe53f0ecf6b5d03b199b3212e9064a7dd04fb3995a9cd09cb8864a7bfdb5617feefbb > > > *apache-calcite-1.37.0-src.tar.gz > > > > > > A staged Maven repository is available for review at: > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1225/org/apache/calcite/ > > > > > > Release artifacts are signed with the following key: > > > https://people.apache.org/keys/committer/snuyanzin.asc > > > https://www.apache.org/dist/calcite/KEYS > > > > > > To create the jars and test Apache Calcite: "gradle build" > > > (requires an appropriate Gradle/JDK installation) > > > > > > Please vote on releasing this package as Apache
[jira] [Created] (CALCITE-6384) Missing ASF header from buildcache.yml, gradle-wrapper-validation.yml
Stamatis Zampetakis created CALCITE-6384: Summary: Missing ASF header from buildcache.yml, gradle-wrapper-validation.yml Key: CALCITE-6384 URL: https://issues.apache.org/jira/browse/CALCITE-6384 Project: Calcite Issue Type: Task Affects Versions: 1.36.0 Reporter: Stamatis Zampetakis Assignee: Stamatis Zampetakis The header is required as per [ASF policy|https://www.apache.org/legal/src-headers.html]. * [https://github.com/apache/calcite/blob/153494207c24318d4c1d2c908df4a15c4aa4/.github/workflows/buildcache.yml] * [https://github.com/apache/calcite/blob/153494207c24318d4c1d2c908df4a15c4aa4/.github/workflows/gradle-wrapper-validation.yml] -- This message was sent by Atlassian Jira (v8.20.10#820010)