[GitHub] vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds
vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468458376 Where do you get MultiJoins in the first place? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds
vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468036956 >"generate at most N permutation" part. Are you referring to some piece of code that I can leverage to test this? No. I question the business purpose of the feature you add. Why do you need "first ordering it finds"? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds
vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468033965 @siddharthteotia , this PR adds extremely specific feature, and I don't see how the behavior is tested. Do you have a test that validates "only one"? I think we could go with: "generate at most N permutations" or "spend no more than X milliseconds" rule parameters. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
