Re: Master is open
Yes, master branch is ready to accept new commits. On 2020/05/27 19:26:01, Julian Hyde wrote: > Thanks for committing those PRs. I think we should re-open master now. > > On Sun, May 24, 2020 at 4:34 PM Haisheng Yuan wrote: > > > > I have gone over those deferred PRs that were good to go and committed them. > > Nothing blocker from my side. > > > > Haisheng > > > > On 2020/05/24 20:03:00, Haisheng Yuan wrote: > > > OK, let's keep master closed for now. I can confirm that those PRs tagged > > > with LGTM are ready to merge. I can go ahead and merge them, but for > > > others we need other reviewers to help confirm. > > > > > > On 2020/05/24 19:53:09, Julian Hyde wrote: > > > > Yes, review and (if they are ready) commit them before opening master. > > > > > > > > On Sun, May 24, 2020 at 11:30 AM Haisheng Yuan wrote: > > > > > > > > > > I went over the JIRAs, I marked those fix-for-1.23.0 (but didn't get > > > > > chance to get into 1.23.0) to 1.24.0. > > > > > By handling those deferred PRs, do you mean we first review and > > > > > commit these PRs? > > > > > > > > > > Thanks, > > > > > Haisheng > > > > > > > > > > On 2020/05/24 18:22:59, Julian Hyde wrote: > > > > > > What about the plan to keep it closed until we handled those > > > > > > deferred PRs? > > > > > > > > > > > > Julian > > > > > > > > > > > > > On May 24, 2020, at 08:19, Haisheng Yuan wrote: > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > Calcite master branch is open for commit now. > > > > > > > > > > > > > > Cheers, > > > > > > > Haisheng > > > > > > > > > > > > > >
Re: Master is open
Thanks for committing those PRs. I think we should re-open master now. On Sun, May 24, 2020 at 4:34 PM Haisheng Yuan wrote: > > I have gone over those deferred PRs that were good to go and committed them. > Nothing blocker from my side. > > Haisheng > > On 2020/05/24 20:03:00, Haisheng Yuan wrote: > > OK, let's keep master closed for now. I can confirm that those PRs tagged > > with LGTM are ready to merge. I can go ahead and merge them, but for others > > we need other reviewers to help confirm. > > > > On 2020/05/24 19:53:09, Julian Hyde wrote: > > > Yes, review and (if they are ready) commit them before opening master. > > > > > > On Sun, May 24, 2020 at 11:30 AM Haisheng Yuan wrote: > > > > > > > > I went over the JIRAs, I marked those fix-for-1.23.0 (but didn't get > > > > chance to get into 1.23.0) to 1.24.0. > > > > By handling those deferred PRs, do you mean we first review and commit > > > > these PRs? > > > > > > > > Thanks, > > > > Haisheng > > > > > > > > On 2020/05/24 18:22:59, Julian Hyde wrote: > > > > > What about the plan to keep it closed until we handled those deferred > > > > > PRs? > > > > > > > > > > Julian > > > > > > > > > > > On May 24, 2020, at 08:19, Haisheng Yuan wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > Calcite master branch is open for commit now. > > > > > > > > > > > > Cheers, > > > > > > Haisheng > > > > > > > > > >
Re: Master is open
I have gone over those deferred PRs that were good to go and committed them. Nothing blocker from my side. Haisheng On 2020/05/24 20:03:00, Haisheng Yuan wrote: > OK, let's keep master closed for now. I can confirm that those PRs tagged > with LGTM are ready to merge. I can go ahead and merge them, but for others > we need other reviewers to help confirm. > > On 2020/05/24 19:53:09, Julian Hyde wrote: > > Yes, review and (if they are ready) commit them before opening master. > > > > On Sun, May 24, 2020 at 11:30 AM Haisheng Yuan wrote: > > > > > > I went over the JIRAs, I marked those fix-for-1.23.0 (but didn't get > > > chance to get into 1.23.0) to 1.24.0. > > > By handling those deferred PRs, do you mean we first review and commit > > > these PRs? > > > > > > Thanks, > > > Haisheng > > > > > > On 2020/05/24 18:22:59, Julian Hyde wrote: > > > > What about the plan to keep it closed until we handled those deferred > > > > PRs? > > > > > > > > Julian > > > > > > > > > On May 24, 2020, at 08:19, Haisheng Yuan wrote: > > > > > > > > > > Hi all, > > > > > > > > > > Calcite master branch is open for commit now. > > > > > > > > > > Cheers, > > > > > Haisheng > > > > > > >
Re: Master is open
OK, let's keep master closed for now. I can confirm that those PRs tagged with LGTM are ready to merge. I can go ahead and merge them, but for others we need other reviewers to help confirm. On 2020/05/24 19:53:09, Julian Hyde wrote: > Yes, review and (if they are ready) commit them before opening master. > > On Sun, May 24, 2020 at 11:30 AM Haisheng Yuan wrote: > > > > I went over the JIRAs, I marked those fix-for-1.23.0 (but didn't get chance > > to get into 1.23.0) to 1.24.0. > > By handling those deferred PRs, do you mean we first review and commit > > these PRs? > > > > Thanks, > > Haisheng > > > > On 2020/05/24 18:22:59, Julian Hyde wrote: > > > What about the plan to keep it closed until we handled those deferred PRs? > > > > > > Julian > > > > > > > On May 24, 2020, at 08:19, Haisheng Yuan wrote: > > > > > > > > Hi all, > > > > > > > > Calcite master branch is open for commit now. > > > > > > > > Cheers, > > > > Haisheng > > > >
Re: Master is open
I went over the JIRAs, I marked those fix-for-1.23.0 (but didn't get chance to get into 1.23.0) to 1.24.0. By handling those deferred PRs, do you mean we first review and commit these PRs? Thanks, Haisheng On 2020/05/24 18:22:59, Julian Hyde wrote: > What about the plan to keep it closed until we handled those deferred PRs? > > Julian > > > On May 24, 2020, at 08:19, Haisheng Yuan wrote: > > > > Hi all, > > > > Calcite master branch is open for commit now. > > > > Cheers, > > Haisheng >
Re: Master is open
What about the plan to keep it closed until we handled those deferred PRs? Julian > On May 24, 2020, at 08:19, Haisheng Yuan wrote: > > Hi all, > > Calcite master branch is open for commit now. > > Cheers, > Haisheng
