Re: [DISCUSS] Towards Calcite 1.21.0
Hello, According to the discussion in JIRA the following issues seem to be very close to been resolved: https://issues.apache.org/jira/browse/CALCITE-1581 https://issues.apache.org/jira/browse/CALCITE-2302 https://issues.apache.org/jira/browse/CALCITE-3122 I will wait for those to be merged and then I will start the release process. I would like to kindly ask the reviewers involved to check that there is nothing more left to do. I will start moving the remaining issues to 1.22.0. Let me know if there is anything else that we should include in this release. Best, Stamatis On Mon, Aug 19, 2019, 11:04 PM Julian Hyde wrote: > +1 > > I’ve poked Khai Tran re. 3122 (Pig). > > > On Aug 16, 2019, at 11:20 PM, Stamatis Zampetakis > wrote: > > > > Hi all, > > > > The release is advancing quite well, yet we have 22 issues marked for > > 1.21.0 [1]. > > > > From those, the following 5 seem to be the most important: > > > > https://issues.apache.org/jira/browse/CALCITE-1581 > > https://issues.apache.org/jira/browse/CALCITE-2302 > > https://issues.apache.org/jira/browse/CALCITE-3122 > > https://issues.apache.org/jira/browse/CALCITE-3224 > > https://issues.apache.org/jira/browse/CALCITE-3228 > > > > I will try to have an RC for the 26th of August so let's try to get them > in. > > > > [1] > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > > > On Thu, Aug 1, 2019 at 8:51 AM Danny Chan wrote: > > > >> Let’s get the CALCITE-2302[1]: the full implicit type cast support into > >> 1.21 ! > >> > >> [1] https://github.com/apache/calcite/pull/706 > >> > >> Best, > >> Danny Chan > >> 在 2019年7月21日 +0800 PM3:28，Stamatis Zampetakis ，写道： > >>> Hi all, > >>> > >>> Approximately one month has passed from the previous release (Calcite > >>> 1.20.0) and I was thinking that it would be nice to have the next > release > >>> out by the end of August. To do this I think we should try to have an > RC > >>> around the 20 of August. > >>> > >>> The progress towards the next release can be seen in [1]. As you can > >>> observe we do not have many issues marked for fixing for 1.21.0 but we > do > >>> have many pull requests. > >>> > >>> I would like to invite committers to go over the existing PRs and for > >> those > >>> that we plan to review and finalize in the next month or so set the fix > >>> version to 1.21.0 adding an appropriate comment. > >>> > >>> In term of priorities, I think we should emphasize on finalizing and > >>> merging PRs that are blocking other open source projects and commercial > >>> products from upgrading to the latest release. If it is not already > done > >>> please assign this issues the highest priority (blocker) and set the > fix > >>> version to 1.21.0. > >>> > >>> Apart from very important issues it makes sense to treat PRs in FIFO > >> order. > >>> Contributors who submit a PR early will certainly get discouraged to > >>> contribute again if we never merge these PRs in time. > >>> > >>> Don't hesitate to reply to this thread if the plan above is not > >> convenient > >>> for you! > >>> > >>> Best, > >>> Stamatis > >>> > >>> [1] > >>> > >> > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > >> > >
[jira] [Created] (CALCITE-3290) evaluate in AbstractNode
xzh_dz created CALCITE-3290: --- Summary: evaluate in AbstractNode Key: CALCITE-3290 URL: https://issues.apache.org/jira/browse/CALCITE-3290 Project: Calcite Issue Type: Improvement Reporter: xzh_dz -- This message was sent by Atlassian Jira (v8.3.2#803003)
Re: [DISCUSS] Towards Calcite 1.21.0
Sounds good. * I am reviewing 3122 and will commit shortly. * I see Danny has asked me to final review 2302. I'll do that tomorrow. * Who owns 1581? Julian On Sun, Aug 25, 2019 at 1:28 PM Stamatis Zampetakis wrote: > > Hello, > > According to the discussion in JIRA the following issues seem to be very > close to been resolved: > https://issues.apache.org/jira/browse/CALCITE-1581 > https://issues.apache.org/jira/browse/CALCITE-2302 > https://issues.apache.org/jira/browse/CALCITE-3122 > > I will wait for those to be merged and then I will start the release > process. I would like to kindly ask the reviewers involved to check that > there is nothing more left to do. > > I will start moving the remaining issues to 1.22.0. Let me know if there is > anything else that we should include in this release. > > Best, > Stamatis > > On Mon, Aug 19, 2019, 11:04 PM Julian Hyde wrote: > > > +1 > > > > I’ve poked Khai Tran re. 3122 (Pig). > > > > > On Aug 16, 2019, at 11:20 PM, Stamatis Zampetakis > > wrote: > > > > > > Hi all, > > > > > > The release is advancing quite well, yet we have 22 issues marked for > > > 1.21.0 [1]. > > > > > > From those, the following 5 seem to be the most important: > > > > > > https://issues.apache.org/jira/browse/CALCITE-1581 > > > https://issues.apache.org/jira/browse/CALCITE-2302 > > > https://issues.apache.org/jira/browse/CALCITE-3122 > > > https://issues.apache.org/jira/browse/CALCITE-3224 > > > https://issues.apache.org/jira/browse/CALCITE-3228 > > > > > > I will try to have an RC for the 26th of August so let's try to get them > > in. > > > > > > [1] > > > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > > > > > On Thu, Aug 1, 2019 at 8:51 AM Danny Chan wrote: > > > > > >> Let’s get the CALCITE-2302[1]: the full implicit type cast support into > > >> 1.21 ! > > >> > > >> [1] https://github.com/apache/calcite/pull/706 > > >> > > >> Best, > > >> Danny Chan > > >> 在 2019年7月21日 +0800 PM3:28，Stamatis Zampetakis ，写道： > > >>> Hi all, > > >>> > > >>> Approximately one month has passed from the previous release (Calcite > > >>> 1.20.0) and I was thinking that it would be nice to have the next > > release > > >>> out by the end of August. To do this I think we should try to have an > > RC > > >>> around the 20 of August. > > >>> > > >>> The progress towards the next release can be seen in [1]. As you can > > >>> observe we do not have many issues marked for fixing for 1.21.0 but we > > do > > >>> have many pull requests. > > >>> > > >>> I would like to invite committers to go over the existing PRs and for > > >> those > > >>> that we plan to review and finalize in the next month or so set the fix > > >>> version to 1.21.0 adding an appropriate comment. > > >>> > > >>> In term of priorities, I think we should emphasize on finalizing and > > >>> merging PRs that are blocking other open source projects and commercial > > >>> products from upgrading to the latest release. If it is not already > > done > > >>> please assign this issues the highest priority (blocker) and set the > > fix > > >>> version to 1.21.0. > > >>> > > >>> Apart from very important issues it makes sense to treat PRs in FIFO > > >> order. > > >>> Contributors who submit a PR early will certainly get discouraged to > > >>> contribute again if we never merge these PRs in time. > > >>> > > >>> Don't hesitate to reply to this thread if the plan above is not > > >> convenient > > >>> for you! > > >>> > > >>> Best, > > >>> Stamatis > > >>> > > >>> [1] > > >>> > > >> > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > >> > > > >
[jira] [Created] (CALCITE-3291) SqlFunctionsTest failed
Hong Shen created CALCITE-3291:
--
Summary: SqlFunctionsTest failed
Key: CALCITE-3291
URL: https://issues.apache.org/jira/browse/CALCITE-3291
Project: Calcite
Issue Type: Test
Components: core
Reporter: Hong Shen
When I run mvn test, I find some testcase failed.
{code}
[ERROR] Tests run: 39, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.017
s <<< FAILURE! - in org.apache.calcite.test.SqlFunctionsTest
[ERROR] testMd5(org.apache.calcite.test.SqlFunctionsTest) Time elapsed: 0.009
s <<< ERROR!
java.lang.IllegalArgumentException: Argument for @Nonnull parameter 'string' of
org/apache/calcite/runtime/SqlFunctions.md5 must not be null
at org.apache.calcite.test.SqlFunctionsTest.testMd5(SqlFunctionsTest.java:882)
[ERROR] testSha1(org.apache.calcite.test.SqlFunctionsTest) Time elapsed: 0.007
s <<< ERROR!
java.lang.IllegalArgumentException: Argument for @Nonnull parameter 'string' of
org/apache/calcite/runtime/SqlFunctions.sha1 must not be null
at org.apache.calcite.test.SqlFunctionsTest.testSha1(SqlFunctionsTest.java:896)
{/code}
The code is
{code}
@Test public void testMd5() {
assertThat("d41d8cd98f00b204e9800998ecf8427e", is(md5("")));
assertThat("d41d8cd98f00b204e9800998ecf8427e", is(md5(ByteString.of("",
16;
assertThat("902fbdd2b1df0c4f70b4a5d23525e932", is(md5("ABC")));
assertThat("902fbdd2b1df0c4f70b4a5d23525e932",
is(md5(new ByteString("ABC".getBytes(UTF_8);
try {
String o = md5((String) null);
fail("Expected NPE, got " + o);
} catch (NullPointerException e) {
// ok
}
}
{/code}
It should catch java.lang.IllegalArgumentException, but not
NullPointerException. I will add a patch to fix it.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
Re: [DISCUSS] Towards Calcite 1.21.0
I see that Chunwei has reviewed 1581 and he gave a +1 so I suppose it is ready to go. On Mon, Aug 26, 2019, 7:27 AM Julian Hyde wrote: > Sounds good. > * I am reviewing 3122 and will commit shortly. > * I see Danny has asked me to final review 2302. I'll do that tomorrow. > * Who owns 1581? > > Julian > > On Sun, Aug 25, 2019 at 1:28 PM Stamatis Zampetakis > wrote: > > > > Hello, > > > > According to the discussion in JIRA the following issues seem to be very > > close to been resolved: > > https://issues.apache.org/jira/browse/CALCITE-1581 > > https://issues.apache.org/jira/browse/CALCITE-2302 > > https://issues.apache.org/jira/browse/CALCITE-3122 > > > > I will wait for those to be merged and then I will start the release > > process. I would like to kindly ask the reviewers involved to check that > > there is nothing more left to do. > > > > I will start moving the remaining issues to 1.22.0. Let me know if there > is > > anything else that we should include in this release. > > > > Best, > > Stamatis > > > > On Mon, Aug 19, 2019, 11:04 PM Julian Hyde wrote: > > > > > +1 > > > > > > I’ve poked Khai Tran re. 3122 (Pig). > > > > > > > On Aug 16, 2019, at 11:20 PM, Stamatis Zampetakis > > > > wrote: > > > > > > > > Hi all, > > > > > > > > The release is advancing quite well, yet we have 22 issues marked for > > > > 1.21.0 [1]. > > > > > > > > From those, the following 5 seem to be the most important: > > > > > > > > https://issues.apache.org/jira/browse/CALCITE-1581 > > > > https://issues.apache.org/jira/browse/CALCITE-2302 > > > > https://issues.apache.org/jira/browse/CALCITE-3122 > > > > https://issues.apache.org/jira/browse/CALCITE-3224 > > > > https://issues.apache.org/jira/browse/CALCITE-3228 > > > > > > > > I will try to have an RC for the 26th of August so let's try to get > them > > > in. > > > > > > > > [1] > > > > > > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > > > > > > > On Thu, Aug 1, 2019 at 8:51 AM Danny Chan > wrote: > > > > > > > >> Let’s get the CALCITE-2302[1]: the full implicit type cast support > into > > > >> 1.21 ! > > > >> > > > >> [1] https://github.com/apache/calcite/pull/706 > > > >> > > > >> Best, > > > >> Danny Chan > > > >> 在 2019年7月21日 +0800 PM3:28，Stamatis Zampetakis >，写道： > > > >>> Hi all, > > > >>> > > > >>> Approximately one month has passed from the previous release > (Calcite > > > >>> 1.20.0) and I was thinking that it would be nice to have the next > > > release > > > >>> out by the end of August. To do this I think we should try to have > an > > > RC > > > >>> around the 20 of August. > > > >>> > > > >>> The progress towards the next release can be seen in [1]. As you > can > > > >>> observe we do not have many issues marked for fixing for 1.21.0 > but we > > > do > > > >>> have many pull requests. > > > >>> > > > >>> I would like to invite committers to go over the existing PRs and > for > > > >> those > > > >>> that we plan to review and finalize in the next month or so set > the fix > > > >>> version to 1.21.0 adding an appropriate comment. > > > >>> > > > >>> In term of priorities, I think we should emphasize on finalizing > and > > > >>> merging PRs that are blocking other open source projects and > commercial > > > >>> products from upgrading to the latest release. If it is not already > > > done > > > >>> please assign this issues the highest priority (blocker) and set > the > > > fix > > > >>> version to 1.21.0. > > > >>> > > > >>> Apart from very important issues it makes sense to treat PRs in > FIFO > > > >> order. > > > >>> Contributors who submit a PR early will certainly get discouraged > to > > > >>> contribute again if we never merge these PRs in time. > > > >>> > > > >>> Don't hesitate to reply to this thread if the plan above is not > > > >> convenient > > > >>> for you! > > > >>> > > > >>> Best, > > > >>> Stamatis > > > >>> > > > >>> [1] > > > >>> > > > >> > > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > > >> > > > > > > >
[jira] [Created] (CALCITE-3292) SqlToRelConverter#substituteSubQuery fails with NullPointerException when converting SqlUpdate.
jin xing created CALCITE-3292: - Summary: SqlToRelConverter#substituteSubQuery fails with NullPointerException when converting SqlUpdate. Key: CALCITE-3292 URL: https://issues.apache.org/jira/browse/CALCITE-3292 Project: Calcite Issue Type: Bug Components: core Reporter: jin xing Assignee: jin xing -- This message was sent by Atlassian Jira (v8.3.2#803003)
