Re: [camel] branch master updated: Upgrade Commons DBCP2 to version 2.4.0

2018-06-17 Thread Andrea Cosentino
If I remember correctly this should be break the camel-example-sql-blueprint, I 
have to verify.

--
Andrea Cosentino 
--
Apache Camel PMC Chair
Apache Karaf Committer
Apache Servicemix PMC Member
Email: ancosen1...@yahoo.com
Twitter: @oscerd2
Github: oscerd






On Sunday, June 17, 2018, 7:02:55 PM GMT+2, pascalschumac...@apache.org 
 wrote: 





This is an automated email from the ASF dual-hosted git repository.

pascalschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
    new 55bd2cc  Upgrade Commons DBCP2 to version 2.4.0
55bd2cc is described below

commit 55bd2ccc8457430836d9aa1192d6d635965933e1
Author: Pascal Schumacher 
AuthorDate: Sun Jun 17 14:33:07 2018 +0200

    Upgrade Commons DBCP2 to version 2.4.0
---
parent/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/parent/pom.xml b/parent/pom.xml
index ec0e53d..4537d98 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -145,7 +145,7 @@
    1.4
    1.0.15
    1.4
-    2.2.0
+    2.4.0
    1.8.1
    2.1
    1.3

-- 
To stop receiving notification emails like this one, please contact
pascalschumac...@apache.org.


[GitHub] camel pull request #2373: Updates to latest zipkin, eliminating SpanCollecto...

2018-06-17 Thread oscerd
Github user oscerd closed the pull request at:

https://github.com/apache/camel/pull/2373


---


[GitHub] camel pull request #2381: CAMEL-11893: Restored SolrAddBeanTest in camel-sol...

2018-06-17 Thread aldettinger
GitHub user aldettinger opened a pull request:

https://github.com/apache/camel/pull/2381

CAMEL-11893: Restored SolrAddBeanTest in camel-solr

Fixed most ERROR level logs in `target/camel-solr-test.log`.
Aligned jetty version with the one used by `solr-test-framework`.

This PR fixes a single test, more to come.

See [CAMEL-11893](https://issues.apache.org/jira/browse/CAMEL-11893) for 
more.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aldettinger/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2381


commit 5efbad27c75bb31fcfa9b2991389b9e198acc93e
Author: aldettinger 
Date:   2018-06-17T17:05:15Z

CAMEL-11893: Restored SolrAddBeanTest in camel-solr




---


Re: JUnit5, was: testcontainers

2018-06-17 Thread Pascal Schumacher

Thanks for the information!

Part of camel already uses this version 
(https://github.com/apache/camel/commit/1ddd931d5cf2faea41e2d7454a9f04ed3985) 
and Zoran is looking into updating the remaining parts in 
https://issues.apache.org/jira/browse/CAMEL-12586


Cheers,
Pascal

Am 17.06.2018 um 00:29 schrieb David Karlsen:

It is released now!

Den ons. 23. mai 2018 kl. 10:32 skrev Zoran Regvart :


Hi David,
yes we can wait for that and the Surefire/Failsafe release that
includes it. I think we can also add
org.junit.platform:junit-platform-surefire-provider:1.2.0 dependency
to the existing Surefire/Failsafe plugin configurations.

As far as I understand that issue is tracking the incorporation of the
existing codebase from JUnit5 into Surefire.

zoran

On Wed, May 23, 2018 at 10:15 AM, David Karlsen 
wrote:

Would you have to await for
https://issues.apache.org/jira/browse/SUREFIRE-1330 to be merged to get
surefire support?

Den ons. 23. mai 2018 kl. 10:08 skrev Zoran Regvart :


Hi,
on the testcontainers thread I mentioned that we can switch to JUnit5.
I've attended a talk by Sam Brannen at the local JUG. I think it was a
variant of the talk[1] he gave at SpringOne 2017.

The key takeaway for me was that JUnit5 is forward and backward
compatible, so you can run the same tests written with JUnit4
annotations on JUnit5, but you can also run JUnit5 tests on JUnit4, if
for some reason that would make sense in a particular case.

What I understood is that we could upgrade to JUnit5 by simply
upgrading the surefire/failsafe Maven plugins and adding the
junit-vintage-engine dependency but only to a module that has mixed
JUnit4 and JUnit5 tests[2]. The only issue is limited @Rule support.

Now on to the benefits, I think it makes much sense to move over to
JUnit5 for the conditional test execution[3], better categorization of
tests via tags[4] and the much better extension model[5].

I propose that we schedule this for the one release after the pending
one (so in 2.23), and that we add camel-test-jupiter component that
would help developers write nicer tests for their integrations with
support for dependency injection for example[6].

zoran

[1] https://www.youtube.com/watch?v=h0Idcz71Aog
[2]
https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4
[3]


https://junit.org/junit5/docs/current/user-guide/#writing-tests-conditional-execution

[4]


https://junit.org/junit5/docs/current/user-guide/#writing-tests-tagging-and-filtering

[5] https://junit.org/junit5/docs/current/user-guide/#extensions
[6]


https://junit.org/junit5/docs/current/user-guide/#writing-tests-dependency-injection

--
Zoran Regvart



--
--
David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen



--
Zoran Regvart







[GitHub] camel pull request #2380: CAMEL-9751: Allow to configure swagger security re...

2018-06-17 Thread davsclaus
GitHub user davsclaus opened a pull request:

https://github.com/apache/camel/pull/2380

CAMEL-9751: Allow to configure swagger security requirements in generated 
swagger api docs in rest-dsl.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/camel swagger-security

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2380


commit 490b50366bd81345767d04e95d7b01e83b637387
Author: Claus Ibsen 
Date:   2018-06-16T10:31:32Z

CAMEL-9751: Allow to configure swagger security requirements in generated 
swagger api docs in rest-dsl.

commit 14b0aa59147326576c222b3c73bee43ba0f2ed74
Author: Claus Ibsen 
Date:   2018-06-16T12:42:24Z

CAMEL-9751: Allow to configure swagger security requirements in generated 
swagger api docs in rest-dsl.

commit 1e711d20a9bff5aedf624e303ff948e421d7e9dc
Author: Claus Ibsen 
Date:   2018-06-17T08:33:16Z

CAMEL-9751: Allow to configure swagger security requirements in generated 
swagger api docs in rest-dsl.

commit 57142664acc06cffce684c9962b88c3cb919b652
Author: Claus Ibsen 
Date:   2018-06-17T08:52:05Z

CAMEL-9751: Allow to configure swagger security requirements in generated 
swagger api docs in rest-dsl.




---