[GitHub] [camel-quarkus] oscerd merged pull request #197: Add the camel-paho extension to support the MQTT
oscerd merged pull request #197: Add the camel-paho extension to support the MQTT URL: https://github.com/apache/camel-quarkus/pull/197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd closed issue #171: Create a Camel MQTT extension
oscerd closed issue #171: Create a Camel MQTT extension URL: https://github.com/apache/camel-quarkus/issues/171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #197: Add the camel-paho extension to support the MQTT
asf-ci commented on issue #197: Add the camel-paho extension to support the MQTT URL: https://github.com/apache/camel-quarkus/pull/197#issuecomment-530222199 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/150/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] zhfeng opened a new pull request #197: Add the camel-paho extension to support the MQTT
zhfeng opened a new pull request #197: Add the camel-paho extension to support the MQTT URL: https://github.com/apache/camel-quarkus/pull/197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #196: chore(deps): update quarkus to v0.21.2
oscerd merged pull request #196: chore(deps): update quarkus to v0.21.2 URL: https://github.com/apache/camel-quarkus/pull/196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #196: chore(deps): update quarkus to v0.21.2
asf-ci commented on issue #196: chore(deps): update quarkus to v0.21.2 URL: https://github.com/apache/camel-quarkus/pull/196#issuecomment-530029018 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/149/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #932: Provide better instructions on the kit create command for missing nam…
astefanutti merged pull request #932: Provide better instructions on the kit create command for missing nam… URL: https://github.com/apache/camel-k/pull/932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: deprecated components by which version of camel
Hi Ah yeah that is a nice touch. Camel 3 is a fresh start and all deprecated components is removed. We have a in pom.xml (eg see zipkin). We could have a you can add to the pom.xml, and then the build system can pickup this, and automatic mark this in the docs. But its more "build magic". On Tue, Sep 10, 2019 at 7:47 AM Onder SEZGIN wrote: > > Hi, > > as in the documentation we mention that components are available by > starting of which camel version. > > would it be good to add by which version the component got deprecated? > for the time being, i don't have a sample implementation to show such > scenario but i believe it would be a good feature for docs? > > or is there any already that i am not aware of? > > thanks > Onder -- Claus Ibsen - http://davsclaus.com @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
deprecated components by which version of camel
Hi, as in the documentation we mention that components are available by starting of which camel version. would it be good to add by which version the component got deprecated? for the time being, i don't have a sample implementation to show such scenario but i believe it would be a good feature for docs? or is there any already that i am not aware of? thanks Onder
[GitHub] [camel-k] astefanutti merged pull request #928: fix: Correct indentation for integration source content
astefanutti merged pull request #928: fix: Correct indentation for integration source content URL: https://github.com/apache/camel-k/pull/928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on a change in pull request #932: Provide better instructions on the kit create command for missing nam…
astefanutti commented on a change in pull request #932: Provide better
instructions on the kit create command for missing nam…
URL: https://github.com/apache/camel-k/pull/932#discussion_r322735058
##
File path: pkg/cmd/kit_create.go
##
@@ -76,7 +75,7 @@ type kitCreateCommand struct {
func (command *kitCreateCommand) validateArgs(_ *cobra.Command, args []string)
error {
if len(args) != 1 {
- return errors.New("accepts 1 arg, received " +
strconv.Itoa(len(args)))
+ return errors.New("Create expects a single name argument.")
Review comment:
Error message should not start with capital letter.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #732: Update Camel K tagline in Kamel CLI
astefanutti closed issue #732: Update Camel K tagline in Kamel CLI URL: https://github.com/apache/camel-k/issues/732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #931: Fix #732: Adjusted CLI tagline to be in sync with updated (serverless superpowers) language.
astefanutti commented on issue #931: Fix #732: Adjusted CLI tagline to be in sync with updated (serverless superpowers) language. URL: https://github.com/apache/camel-k/pull/931#issuecomment-529922151 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #931: Fix #732: Adjusted CLI tagline to be in sync with updated (serverless superpowers) language.
astefanutti merged pull request #931: Fix #732: Adjusted CLI tagline to be in sync with updated (serverless superpowers) language. URL: https://github.com/apache/camel-k/pull/931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] dobozysaurus opened a new pull request #932: Provide better instructions on the kit create command for missing nam…
dobozysaurus opened a new pull request #932: Provide better instructions on the kit create command for missing nam… URL: https://github.com/apache/camel-k/pull/932 …e param. #586 refers to the kamel context create command, which looks to have been replaced by the kit command. This fix updates the language in the usage field to make the name arg requirement more clear. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] dobozysaurus opened a new pull request #931: Fix 732
dobozysaurus opened a new pull request #931: Fix 732 URL: https://github.com/apache/camel-k/pull/931 Adjusted CLI tagline to be in sync with updated (serverless superpowers) language. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #930: Fix for #732.
astefanutti commented on issue #930: Fix for #732. URL: https://github.com/apache/camel-k/pull/930#issuecomment-529910322 @dobozysaurus you can just force push your branch and keep this PR open if you want. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] dobozysaurus closed pull request #930: Fix for #732.
dobozysaurus closed pull request #930: Fix for #732. URL: https://github.com/apache/camel-k/pull/930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #930: Fix for #732.
astefanutti commented on issue #930: Fix for #732. URL: https://github.com/apache/camel-k/pull/930#issuecomment-529902233 Thanks. Could you please amend the commit message to something explicit about the fix rather than referencing the GitHub issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] dobozysaurus opened a new pull request #930: Fix for #732.
dobozysaurus opened a new pull request #930: Fix for #732. URL: https://github.com/apache/camel-k/pull/930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lubuxnl commented on issue #923: Camel-K build fails with error: open /workspace/builder-656588331/package/context/Dockerfile: no such file or directory
lubuxnl commented on issue #923: Camel-K build fails with error: open /workspace/builder-656588331/package/context/Dockerfile: no such file or directory URL: https://github.com/apache/camel-k/issues/923#issuecomment-529890242 I just recreated my [Vagrant/Virtualbox/Minikube](https://github.com/lubuxnl/ubuntu-minikube/tree/knative) VM from scratch and installed Istio, Knative and Camel-K. I then tried to run the printer, splitter and feed routes from the [examples/knative](https://github.com/apache/camel-k/tree/master/examples/knative) folder of this repo. This time the printer and feed routes built and ran fine, but the splitter route encountered the same error as reported in this issue during the build (see [logfile](https://github.com/apache/camel-k/files/3595383/camel-k-kit-splitter-builder.log)). Previously also this route ran fine, so apparently the problem is not with the route itself, but some specific condition. Is it possible to get logging at debug level for the build process, that might help explain the condition that caused the build to fail? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
lburgazzoli commented on a change in pull request #189: Make xml and jaxb
disabled by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r322660654
##
File path:
extensions/xml-common/runtime/src/main/java/org/apache/camel/quarkus/component/xml/runtime/graal/Target_org_apache_camel_quarkus_core_runtime_support_FastModel.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.xml.runtime.graal;
+
+import java.io.InputStream;
+
+import com.oracle.svm.core.annotate.Substitute;
+import com.oracle.svm.core.annotate.TargetClass;
+import org.apache.camel.CamelContext;
+import org.apache.camel.impl.DefaultModel;
+import org.apache.camel.model.ModelHelper;
+import org.apache.camel.model.RoutesDefinition;
+
+@TargetClass(className =
"org.apache.camel.quarkus.core.runtime.support.FastModel")
+@Substitute
+public class Target_org_apache_camel_quarkus_core_runtime_support_FastModel
extends DefaultModel {
+
+public
Target_org_apache_camel_quarkus_core_runtime_support_FastModel(CamelContext
camelContext) {
+super(camelContext);
+}
+
+@Substitute
+public void addRouteDefinitions(InputStream is) throws Exception {
+RoutesDefinition def =
ModelHelper.loadRoutesDefinition(getCamelContext(), is);
Review comment:
FWIW, what I recall is that a class level `@Substitute` means that the whole
class need to be replaced that's why I see this as replacement for `FastModel`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
lburgazzoli commented on a change in pull request #189: Make xml and jaxb
disabled by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r322645850
##
File path:
extensions/xml-common/runtime/src/main/java/org/apache/camel/quarkus/component/xml/runtime/graal/Target_org_apache_camel_quarkus_core_runtime_support_FastModel.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.xml.runtime.graal;
+
+import java.io.InputStream;
+
+import com.oracle.svm.core.annotate.Substitute;
+import com.oracle.svm.core.annotate.TargetClass;
+import org.apache.camel.CamelContext;
+import org.apache.camel.impl.DefaultModel;
+import org.apache.camel.model.ModelHelper;
+import org.apache.camel.model.RoutesDefinition;
+
+@TargetClass(className =
"org.apache.camel.quarkus.core.runtime.support.FastModel")
+@Substitute
+public class Target_org_apache_camel_quarkus_core_runtime_support_FastModel
extends DefaultModel {
+
+public
Target_org_apache_camel_quarkus_core_runtime_support_FastModel(CamelContext
camelContext) {
+super(camelContext);
+}
+
+@Substitute
+public void addRouteDefinitions(InputStream is) throws Exception {
+RoutesDefinition def =
ModelHelper.loadRoutesDefinition(getCamelContext(), is);
Review comment:
But that means that the JVM mode and the native mode are behaving
differently right ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
gnodet commented on a change in pull request #189: Make xml and jaxb disabled
by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r322642682
##
File path:
extensions/xml-common/deployment/src/main/java/org/apache/camel/quarkus/component/xml/deployment/ModelFactoryProcessor.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.xml.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import org.apache.camel.quarkus.component.xml.runtime.SupportRecorder;
+import org.apache.camel.quarkus.core.deployment.CamelRegistryBuildItem;
+import org.apache.camel.spi.ModelJAXBContextFactory;
+
+public class ModelFactoryProcessor {
+
+@Record(ExecutionTime.STATIC_INIT)
+@BuildStep
+CamelRegistryBuildItem jaxbContextFactory(SupportRecorder recorder) {
+return new CamelRegistryBuildItem(
+"log",
Review comment:
Good catch !
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
gnodet commented on a change in pull request #189: Make xml and jaxb disabled
by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r322642596
##
File path:
extensions/xml-common/runtime/src/main/java/org/apache/camel/quarkus/component/xml/runtime/graal/Target_org_apache_camel_quarkus_core_runtime_support_FastModel.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.xml.runtime.graal;
+
+import java.io.InputStream;
+
+import com.oracle.svm.core.annotate.Substitute;
+import com.oracle.svm.core.annotate.TargetClass;
+import org.apache.camel.CamelContext;
+import org.apache.camel.impl.DefaultModel;
+import org.apache.camel.model.ModelHelper;
+import org.apache.camel.model.RoutesDefinition;
+
+@TargetClass(className =
"org.apache.camel.quarkus.core.runtime.support.FastModel")
+@Substitute
+public class Target_org_apache_camel_quarkus_core_runtime_support_FastModel
extends DefaultModel {
+
+public
Target_org_apache_camel_quarkus_core_runtime_support_FastModel(CamelContext
camelContext) {
+super(camelContext);
+}
+
+@Substitute
+public void addRouteDefinitions(InputStream is) throws Exception {
+RoutesDefinition def =
ModelHelper.loadRoutesDefinition(getCamelContext(), is);
Review comment:
We're not replacing `FastModel` with `DefaultModel`. This is just a class
containing a substitution for the `addRouteDefinitions` method. The one in
`FastModel` now simply throws an `UnsupportedOperationException`.
The goal is to have the default `FastModel` not being tied to xml/jaxb (thus
unable to load xml routes) and have this feature automatically added when
adding the dependency to the `xml-common` extension.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] lburgazzoli commented on issue #929: routes.yaml example fails with NoSuchLanguageException
lburgazzoli commented on issue #929: routes.yaml example fails with NoSuchLanguageException URL: https://github.com/apache/camel-k/issues/929#issuecomment-529846826 it maybe because of some relocation of classes in camel 3 rc1, we probably need to add camel-bean as common dependency This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] jamesnetherton opened a new issue #929: routes.yaml example fails with NoSuchLanguageException
jamesnetherton opened a new issue #929: routes.yaml example fails with NoSuchLanguageException URL: https://github.com/apache/camel-k/issues/929 The body uppercase transformation in the [routes.yaml](https://github.com/apache/camel-k/blob/master/examples/routes.yaml#L10) example results in: ``` 2019-09-10 08:50:02.245 WARN [Camel (camel-k) thread #2 - timer://tick] TimerConsumer - Error processing exchange. Exchange[ID-routes-6559d6b457-vlsxl-1568105397257-0-3]. Caused by: [org.apache.camel.NoSuchLanguageException - No language could be found for: bean] org.apache.camel.NoSuchLanguageException: No language could be found for: bean at org.apache.camel.impl.engine.DefaultLanguageResolver.noSpecificLanguageFound(DefaultLanguageResolver.java:91) ~[org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.impl.engine.DefaultLanguageResolver.resolveLanguage(DefaultLanguageResolver.java:67) ~[org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.impl.engine.AbstractCamelContext.resolveLanguage(AbstractCamelContext.java:1619) ~[org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.support.builder.ExpressionBuilder$68.evaluate(ExpressionBuilder.java:1527) ~[org.apache.camel.camel-support-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.support.ExpressionAdapter.evaluate(ExpressionAdapter.java:34) ~[org.apache.camel.camel-support-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.language.simple.SimpleExpressionBuilder$29.evaluate(SimpleExpressionBuilder.java:668) ~[org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.support.ExpressionAdapter.evaluate(ExpressionAdapter.java:34) ~[org.apache.camel.camel-support-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.builder.SimpleBuilder.evaluate(SimpleBuilder.java:99) ~[org.apache.camel.camel-core-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.processor.SetBodyProcessor.process(SetBodyProcessor.java:43) ~[org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.processor.errorhandler.RedeliveryErrorHandler$RedeliveryState.run(RedeliveryErrorHandler.java:480) ~[org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.impl.engine.DefaultReactiveExecutor$Worker.schedule(DefaultReactiveExecutor.java:185) [org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.impl.engine.DefaultReactiveExecutor.scheduleMain(DefaultReactiveExecutor.java:59) [org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.processor.Pipeline.process(Pipeline.java:87) [org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:222) [org.apache.camel.camel-base-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.component.timer.TimerConsumer.sendTimerExchange(TimerConsumer.java:193) [org.apache.camel.camel-timer-3.0.0-M4.jar:3.0.0-M4] at org.apache.camel.component.timer.TimerConsumer$1.run(TimerConsumer.java:75) [org.apache.camel.camel-timer-3.0.0-M4.jar:3.0.0-M4] at java.util.TimerThread.mainLoop(Timer.java:555) [?:1.8.0_191] at java.util.TimerThread.run(Timer.java:505) [?:1.8.0_191] ``` If you manually add a dependency for `camel-bean` it works fine. Not sure if that's the intended way to make the example work, but it'd be nice if it worked OOTB. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #189: Make xml and jaxb disabled by default and opt-in when depending on camel
asf-ci commented on issue #189: Make xml and jaxb disabled by default and opt-in when depending on camel URL: https://github.com/apache/camel-quarkus/pull/189#issuecomment-529839385 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/148/Build result: FAILURE[...truncated 945.75 KB...]at java.lang.reflect.Method.invoke (Method.java:498)at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)at hudson.remoting.UserRequest.perform (UserRequest.java:212)at hudson.remoting.UserRequest.perform (UserRequest.java:54)at hudson.remoting.Request$2.run (Request.java:369)at hudson.remoting.InterceptingExecutorService$1.call (InterceptingExecutorService.java:72)at java.util.concurrent.FutureTask.run (FutureTask.java:266)at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1149)at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624)at java.lang.Thread.run (Thread.java:748)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of afba269cb1721fa1420fd3baab49dc5fd3119deb to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/148/ and message: 'FAILURE 37 tests run, 1 skipped, 0 failed.'Using context: default This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
lburgazzoli commented on a change in pull request #189: Make xml and jaxb
disabled by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r322619614
##
File path:
extensions/xml-common/runtime/src/main/java/org/apache/camel/quarkus/component/xml/runtime/graal/Target_org_apache_camel_quarkus_core_runtime_support_FastModel.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.xml.runtime.graal;
+
+import java.io.InputStream;
+
+import com.oracle.svm.core.annotate.Substitute;
+import com.oracle.svm.core.annotate.TargetClass;
+import org.apache.camel.CamelContext;
+import org.apache.camel.impl.DefaultModel;
+import org.apache.camel.model.ModelHelper;
+import org.apache.camel.model.RoutesDefinition;
+
+@TargetClass(className =
"org.apache.camel.quarkus.core.runtime.support.FastModel")
+@Substitute
+public class Target_org_apache_camel_quarkus_core_runtime_support_FastModel
extends DefaultModel {
+
+public
Target_org_apache_camel_quarkus_core_runtime_support_FastModel(CamelContext
camelContext) {
+super(camelContext);
+}
+
+@Substitute
+public void addRouteDefinitions(InputStream is) throws Exception {
+RoutesDefinition def =
ModelHelper.loadRoutesDefinition(getCamelContext(), is);
Review comment:
For my understanding:
- are we are replacing `FastModel` with `DefaultModel` ?
- why this method is implemented in the substitution and not in `FastModel` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
lburgazzoli commented on a change in pull request #189: Make xml and jaxb
disabled by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r322619614
##
File path:
extensions/xml-common/runtime/src/main/java/org/apache/camel/quarkus/component/xml/runtime/graal/Target_org_apache_camel_quarkus_core_runtime_support_FastModel.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.xml.runtime.graal;
+
+import java.io.InputStream;
+
+import com.oracle.svm.core.annotate.Substitute;
+import com.oracle.svm.core.annotate.TargetClass;
+import org.apache.camel.CamelContext;
+import org.apache.camel.impl.DefaultModel;
+import org.apache.camel.model.ModelHelper;
+import org.apache.camel.model.RoutesDefinition;
+
+@TargetClass(className =
"org.apache.camel.quarkus.core.runtime.support.FastModel")
+@Substitute
+public class Target_org_apache_camel_quarkus_core_runtime_support_FastModel
extends DefaultModel {
+
+public
Target_org_apache_camel_quarkus_core_runtime_support_FastModel(CamelContext
camelContext) {
+super(camelContext);
+}
+
+@Substitute
+public void addRouteDefinitions(InputStream is) throws Exception {
+RoutesDefinition def =
ModelHelper.loadRoutesDefinition(getCamelContext(), is);
Review comment:
For my understanding:
- are we are replacing `FastMode` with `DefaultModel` ?
- why this method is implemented in the substitution and not in `FastMode` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
lburgazzoli commented on a change in pull request #189: Make xml and jaxb
disabled by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r322617740
##
File path:
extensions/xml-common/deployment/src/main/java/org/apache/camel/quarkus/component/xml/deployment/ModelFactoryProcessor.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.xml.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import org.apache.camel.quarkus.component.xml.runtime.SupportRecorder;
+import org.apache.camel.quarkus.core.deployment.CamelRegistryBuildItem;
+import org.apache.camel.spi.ModelJAXBContextFactory;
+
+public class ModelFactoryProcessor {
+
+@Record(ExecutionTime.STATIC_INIT)
+@BuildStep
+CamelRegistryBuildItem jaxbContextFactory(SupportRecorder recorder) {
+return new CamelRegistryBuildItem(
+"log",
Review comment:
looks like this is not the right name :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #164: Support for camel-mail
lburgazzoli commented on a change in pull request #164: Support for camel-mail
URL: https://github.com/apache/camel-quarkus/pull/164#discussion_r322615843
##
File path:
extensions/mail/deployment/src/main/java/org/apache/camel/quarkus/component/mail/deployment/MailProcessor.java
##
@@ -0,0 +1,166 @@
+package org.apache.camel.quarkus.component.mail.deployment;
+
+import java.io.BufferedReader;
+import java.io.IOError;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.UncheckedIOException;
+import java.net.URL;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Enumeration;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Set;
+import java.util.Spliterator;
+import java.util.Spliterators;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+import java.util.stream.StreamSupport;
+
+import javax.inject.Inject;
+import javax.mail.Provider;
+import javax.mail.Session;
+
+import io.quarkus.arc.ResourceProvider;
+import io.quarkus.deployment.ApplicationArchive;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.ApplicationArchivesBuildItem;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.substrate.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.substrate.ServiceProviderBuildItem;
+import io.quarkus.deployment.builditem.substrate.SubstrateResourceBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.apache.camel.quarkus.core.runtime.CamelConfig.Runtime;
+
+class MailProcessor {
+
+private static final String FEATURE = "camel-mail";
+
+@Inject
+BuildProducer reflectiveClass;
+
+@Inject
+BuildProducer resource;
+
+@Inject
+BuildProducer services;
+
+@Inject
+ApplicationArchivesBuildItem applicationArchivesBuildItem;
+
+@BuildStep
+FeatureBuildItem feature() {
+return new FeatureBuildItem(FEATURE);
+}
+
+@BuildStep
+void process() throws IOException {
+List providers =
resources("META-INF/services/javax.mail.Provider")
+.flatMap(this::lines)
+.filter(s -> !s.startsWith("#"))
+.collect(Collectors.toList());
+
+List imp1 = providers.stream()
+.map(this::loadClass)
+.map(this::instantiate)
Review comment:
As we are only registering the providers for reflection, do we really need
to instantiate the provider ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #164: Support for camel-mail
oscerd merged pull request #164: Support for camel-mail URL: https://github.com/apache/camel-quarkus/pull/164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #164: Support for camel-mail
asf-ci commented on issue #164: Support for camel-mail URL: https://github.com/apache/camel-quarkus/pull/164#issuecomment-529826440 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/147/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton opened a new issue #195: Auto configuration of metrics management strategies
jamesnetherton opened a new issue #195: Auto configuration of metrics management strategies URL: https://github.com/apache/camel-quarkus/issues/195 E.g auto configure some or all of [these](https://github.com/apache/camel-quarkus/blob/master/integration-tests/microprofile-metrics/src/main/java/org/apache/camel/quarkus/component/microprofile/metrics/it/MicroProfileMetricsRouteBuilder.java#L31-L34) so that metrics on routes & exchanges are provided OOTB. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Camel 2.24.2
+1 (binding) --- Luca Burgazzoli On Tue, Sep 10, 2019 at 9:21 AM Francois Papon wrote: > +1 (non-binding) > > Thanks! > > regards, > > François > fpa...@apache.org > > Le 09/09/2019 à 09:22, Gregor Zurowski a écrit : > > Hi Everyone: > > > > This is a vote to release Apache Camel 2.24.2, the second patch > > release for the camel-2.24.x branch with 20 fixes and improvements. > > > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345672=12311211 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachecamel-1150/ > > > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1150/org/apache/camel/apache-camel/2.24.2/ > > > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.24.2 > > > > Please test this release candidate and cast your vote. > > [ ] +1 Release the binary as Apache Camel 2.24.2 > > [ ] -1 Veto the release (provide specific comments) > > > > The vote is open for at least 72 hours. > > > > Thanks, > > Gregor >
Re: [VOTE] Release Apache Camel 2.24.2
+1 (non-binding) Thanks! regards, François fpa...@apache.org Le 09/09/2019 à 09:22, Gregor Zurowski a écrit : > Hi Everyone: > > This is a vote to release Apache Camel 2.24.2, the second patch > release for the camel-2.24.x branch with 20 fixes and improvements. > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345672=12311211 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1150/ > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1150/org/apache/camel/apache-camel/2.24.2/ > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.24.2 > > Please test this release candidate and cast your vote. > [ ] +1 Release the binary as Apache Camel 2.24.2 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Gregor
Re: [VOTE] Release Apache Camel 2.24.2
+1 (non-binding) On Tue, 10 Sep 2019 at 02:30, Onder SEZGIN wrote: > +1 > > On Mon, 9 Sep 2019, 13:22 Andrea Cosentino, wrote: > > > +1 (binding) > > > > Il giorno lun 9 set 2019 alle ore 14:06 Alex Dettinger < > > aldettin...@gmail.com> ha scritto: > > > > > +1 (binding) > > > > > > Well done Gregor, > > > Alex > > > > > > On Mon, Sep 9, 2019 at 1:40 PM Zoran Regvart > wrote: > > > > > > > +1 (binding) > > > > > > > > Thanks for cutting the release Gregor! > > > > > > > > On Mon, Sep 9, 2019 at 9:23 AM Gregor Zurowski < > > gre...@list.zurowski.org > > > > > > > > wrote: > > > > > > > > > > Hi Everyone: > > > > > > > > > > This is a vote to release Apache Camel 2.24.2, the second patch > > > > > release for the camel-2.24.x branch with 20 fixes and improvements. > > > > > > > > > > Release notes: > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345672=12311211 > > > > > > > > > > Staging repository: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecamel-1150/ > > > > > > > > > > Tarballs: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecamel-1150/org/apache/camel/apache-camel/2.24.2/ > > > > > > > > > > Tag: > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.24.2 > > > > > > > > > > Please test this release candidate and cast your vote. > > > > > [ ] +1 Release the binary as Apache Camel 2.24.2 > > > > > [ ] -1 Veto the release (provide specific comments) > > > > > > > > > > The vote is open for at least 72 hours. > > > > > > > > > > Thanks, > > > > > Gregor > > > > > > > > > > > > > > > > -- > > > > Zoran Regvart > > > > > > > > > >
[GitHub] [camel-quarkus] lburgazzoli merged pull request #194: chore(it): add noDeps to quarkus-maven-plugin to make hot-reload working in multi-module projects
lburgazzoli merged pull request #194: chore(it): add noDeps to quarkus-maven-plugin to make hot-reload working in multi-module projects URL: https://github.com/apache/camel-quarkus/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
