Daemonized maven distro available
Hey guys, In my fight to speed up the camel build, I've been working these past days on maven improvements. After having worked on the build (need to push some fixes btw), then maven (speed improvements incorporated in maven 3.6.2), i've decided to spend some time enhancing maven further. What I came up with is something which looks like gradle but works with maven. The maven client spawns a daemon if needed instead of running the build locally. The benefits is that the second time the build is launched, the JVM does have everything ready and that speeds things a lot. Note that the build is run concurrently, so this still causes some problems with the Camel build which still rely on the pom ordering instead of explicit dependencies. The outcome is available at [1]. It's really easy to build and the only thing is that you should use the mvnd executable instead of the maven. Please have a look and do not hesitate to raise issues if you encounter any problem or think about any way to enhance it. If you think the project is interesting enough, i'll fix them. [1] https://github.com/gnodet/mvnd -- Guillaume Nodet
Re: I want to help!
Thanks! I'll start from that. Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Friday, September 27, 2019 12:40 AM, Zoran Regvart wrote: > Hi Briana, > thank you for offering help, the dev@camel.apache.org is the mailing > list where we discuss the development of Apache Camel, here we can > help you with any issues, getting started in contributing or discuss > any direction you would like to take but you're unsure how or if it's > the right thing to do for the project. So please make sure that if you > haven't already done so, subscribe by sending an email to > dev-subscr...@camel.apache.org -- I had to approve this e-mail from > the moderation queue so I'm guessing you might not be subscribed. > > For the website we have a number of issues already open that have the > `help-wanted` label on them, there's a list on the issue tracker: > > https://issues.apache.org/jira/issues/?jql=project %3D CAMEL AND status %3D > Open AND component %3D website AND labels %3D help-wanted > > We also have some documentation on how to get started in contributing to > Camel: > > https://camel.apache.org/manual/latest/contributing.html > > And how the website is structured and built: > > https://github.com/apache/camel-website/blob/master/README.md > > Perhaps start there and see what would be nice contribution for you. > Please feel free to ask any questions here we're very happy to help... > > zoran > > On Thu, Sep 26, 2019 at 10:34 PM Briana brian...@protonmail.com.invalid wrote: > > > Hello, > > I'm a beginner and first time contributor to open source projects. > > I found on ASF that the Apache Camel project is asking for help and I want > > to make myself useful to you. > > I found this: > > https://helpwanted.apache.org/task.html?cf54768988007a3804af7316cfc2449fbb5db8e9 > > Can you guide me from where I could start? > > Thanks! > > Sent with ProtonMail Secure Email. > > -- > > Zoran Regvart
[GitHub] [camel-quarkus] asf-ci commented on issue #201: Fix #184 Leverage platform http service
asf-ci commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-536042702 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/174/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #965: Build completes OK but integration shows ERROR
nicolaferraro commented on issue #965: Build completes OK but integration shows ERROR URL: https://github.com/apache/camel-k/issues/965#issuecomment-536015439 > Minikube 1.4 IIRC with K8s 1.16. > […](#) > Sent from my iPhone > On 27 Sep 2019, at 18:29, Nicola Ferraro ***@***.***> wrote: @steveww I see you're using Camel K 1.0.0-M1, so it's probably something that broke in recent versions of Kube. What kubernetes version are you using? Minikube? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. Yes, same as mine... I get the same error This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #201: Fix #184 Leverage platform http service
asf-ci commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-536013392 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/173/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] steveww commented on issue #965: Build completes OK but integration shows ERROR
steveww commented on issue #965: Build completes OK but integration shows ERROR URL: https://github.com/apache/camel-k/issues/965#issuecomment-536012294 Minikube 1.4 IIRC with K8s 1.16. Sent from my iPhone > On 27 Sep 2019, at 18:29, Nicola Ferraro wrote: > > @steveww I see you're using Camel K 1.0.0-M1, so it's probably something that broke in recent versions of Kube. > > What kubernetes version are you using? Minikube? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #965: Build completes OK but integration shows ERROR
nicolaferraro commented on issue #965: Build completes OK but integration shows ERROR URL: https://github.com/apache/camel-k/issues/965#issuecomment-536009620 @steveww I see you're using Camel K 1.0.0-M1, so it's probably something that broke in recent versions of Kube. What kubernetes version are you using? Minikube? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] oscerd commented on issue #145: add (initial) support for quarkus
oscerd commented on issue #145: add (initial) support for quarkus URL: https://github.com/apache/camel-k-runtime/pull/145#issuecomment-536002952 Yes, no problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #145: add (initial) support for quarkus
lburgazzoli commented on issue #145: add (initial) support for quarkus URL: https://github.com/apache/camel-k-runtime/pull/145#issuecomment-536000768 @oscerd as we'll need to test native images too, would it be possible to switch to ASF's Jenkins ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] steveww commented on issue #965: Build completes OK but integration shows ERROR
steveww commented on issue #965: Build completes OK but integration shows ERROR URL: https://github.com/apache/camel-k/issues/965#issuecomment-53589 May be I should try with an older version of K8s? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #145: add (initial) support for quarkus
lburgazzoli commented on issue #145: add (initial) support for quarkus URL: https://github.com/apache/camel-k-runtime/pull/145#issuecomment-535998922 Failing because: Failure to find com.fasterxml.jackson:jackson-bom:pom:2.9.10 in https://maven-central.storage-download.googleapis.com/repos/central/data/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #209: Upgrade to Quarkus 0.23.0
lburgazzoli commented on issue #209: Upgrade to Quarkus 0.23.0 URL: https://github.com/apache/camel-quarkus/issues/209#issuecomment-535998415 Blocking issue: https://github.com/quarkusio/quarkus/issues/4248 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] jamesnetherton commented on issue #965: Build completes OK but integration shows ERROR
jamesnetherton commented on issue #965: Build completes OK but integration
shows ERROR
URL: https://github.com/apache/camel-k/issues/965#issuecomment-535987834
Looks like https://github.com/apache/camel-k/issues/960.
The same error is present in the build log:
```
{"level":"info","ts":1569596803.3845682,"logger":"camel-k.builder","msg":"step
done in 0.009136
seconds","step":"github.com/apache/camel-k/pkg/builder/IncrementalPackager","phase":30,"kit":"kit-bm725sq7e5omlm5uhsmg"}
{"level":"info","ts":1569596803.3845954,"logger":"camel-k.builder","msg":"executing
step","step":"github.com/apache/camel-k/pkg/builder/kaniko/Publisher","phase":40,"kit":"kit-bm725sq7e5omlm5uhsmg"}
{"level":"info","ts":1569596803.384622,"logger":"camel-k.builder","msg":"step
failed with error: open
/workspace/builder-333639899/package/context/Dockerfile: no such file or
directory","step":"github.com/apache/camel-k/pkg/builder/kaniko/Publisher","phase":40,"kit":"kit-bm725sq7e5omlm5uhsmg"}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] steveww opened a new issue #965: Build completes OK but integration shows ERROR
steveww opened a new issue #965: Build completes OK but integration shows ERROR URL: https://github.com/apache/camel-k/issues/965 [build.log](https://github.com/apache/camel-k/files/3663356/build.log) $ kamel get Shows error and the pod is not running, but no errors in the log??? [foo.txt](https://github.com/apache/camel-k/files/3663369/foo.txt) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga edited a comment on issue #201: Fix #184 Leverage platform http service
ppalaga edited a comment on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-535971108 d9796e2c19e5a223e49570e5067b3cd71b741483 should fix the test failures. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga edited a comment on issue #201: Fix #184 Leverage platform http service
ppalaga edited a comment on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-535971108 3dcfa9a should fix the test failures. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #201: Fix #184 Leverage platform http service
ppalaga commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-535971108 3dcfa9a should fix the test failure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #201: Fix #184 Leverage platform http service
ppalaga commented on a change in pull request #201: Fix #184 Leverage platform
http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r329108060
##
File path:
extensions/platform-http/component/src/main/java/org/apache/camel/component/platform/http/PlatformHttpEndpoint.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.platform.http;
+
+import java.util.Collections;
+import java.util.Set;
+import java.util.TreeSet;
+
+import org.apache.camel.AsyncEndpoint;
+import org.apache.camel.Component;
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.Producer;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.spi.HeaderFilterStrategyAware;
+import org.apache.camel.spi.UriEndpoint;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.support.DefaultEndpoint;
+
+@UriEndpoint(/* firstVersion = "3.?.0", */ scheme = "platform-http", title =
"Platform HTTP", syntax = "platform-http:[methods:]path", label = "http")
+public class PlatformHttpEndpoint extends DefaultEndpoint implements
AsyncEndpoint, HeaderFilterStrategyAware {
+
+private final String path;
+private final Set methods;
+
+@UriParam(label = "consumer", description = "A comma separated list of
HTTP methods to serve. This list will be merged with the methods specified in
the URI path. E.g. platform-http:GET,POST:/path?httpMethodRestrict=PUT,DELETE
will effectivelly result in GET,POST,PUT,DELETE. If no methods are specified,
all methods will be served.")
+private String httpMethodRestrict;
Review comment:
I am not sure I follow. Could you please explain it in more detail? We do
change substantial parts of the URI (no protocol, no host, no port) so there
apparently is something new and we are not going to be 100% compatible with the
older generation of the HTTP components.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli opened a new pull request #145: add (initial) support for quarkus #57
lburgazzoli opened a new pull request #145: add (initial) support for quarkus #57 URL: https://github.com/apache/camel-k-runtime/pull/145 This PR add initial bits to support quarkus in camel-k-runtime, it is far to be completed but as it is getting bigger and bigger I'd like to get it reviewed and merged before it ends up begin a complete rewrite of the project :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #941: kamel get still has a column for 'Context'
astefanutti closed issue #941: kamel get still has a column for 'Context' URL: https://github.com/apache/camel-k/issues/941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #964: fix: Rename kamel get 'context' column to 'kit'
astefanutti merged pull request #964: fix: Rename kamel get 'context' column to 'kit' URL: https://github.com/apache/camel-k/pull/964 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] jamesnetherton opened a new pull request #964: fix: Rename kamel get 'context' column to 'kit'
jamesnetherton opened a new pull request #964: fix: Rename kamel get 'context' column to 'kit' URL: https://github.com/apache/camel-k/pull/964 **Release Note** ```release-note Updated 'CONTEXT' column header in 'kamel get' output to 'KIT' ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #201: Fix #184 Leverage platform http service
asf-ci commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-535901585 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/172/Failed Tests: 4camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-platform-http: 4org.apache.camel.quarkus.component.http.server.it.PlatformHttpTest.multipartorg.apache.camel.quarkus.component.http.server.it.PlatformHttpTest.basicorg.apache.camel.quarkus.component.http.server.it.PlatformHttpIT.multipartorg.apache.camel.quarkus.component.http.server.it.PlatformHttpIT.basic This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro merged pull request #963: chore(release): automatic generation of release notes
nicolaferraro merged pull request #963: chore(release): automatic generation of release notes URL: https://github.com/apache/camel-k/pull/963 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r329012715
##
File path:
extensions/platform-http/component/src/main/java/org/apache/camel/component/platform/http/PlatformHttpEndpoint.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.platform.http;
+
+import java.util.Collections;
+import java.util.Set;
+import java.util.TreeSet;
+
+import org.apache.camel.AsyncEndpoint;
+import org.apache.camel.Component;
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.Producer;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.spi.HeaderFilterStrategyAware;
+import org.apache.camel.spi.UriEndpoint;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.support.DefaultEndpoint;
+
+@UriEndpoint(/* firstVersion = "3.?.0", */ scheme = "platform-http", title =
"Platform HTTP", syntax = "platform-http:[methods:]path", label = "http")
+public class PlatformHttpEndpoint extends DefaultEndpoint implements
AsyncEndpoint, HeaderFilterStrategyAware {
+
+private final String path;
+private final Set methods;
+
+@UriParam(label = "consumer", description = "A comma separated list of
HTTP methods to serve. This list will be merged with the methods specified in
the URI path. E.g. platform-http:GET,POST:/path?httpMethodRestrict=PUT,DELETE
will effectivelly result in GET,POST,PUT,DELETE. If no methods are specified,
all methods will be served.")
+private String httpMethodRestrict;
Review comment:
Sorry but there's no old vs new.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new pull request #963: chore(release): automatic generation of release notes
nicolaferraro opened a new pull request #963: chore(release): automatic generation of release notes URL: https://github.com/apache/camel-k/pull/963 This adds a "release note" section on the template of each PR that allows the author of the PR to provide a message that will be added in the release notes section of each Camel K release. Extraction of notes is based on a fork of the [k8s.io/release](https://github.com/kubernetes/release) project available at https://github.com/nicolaferraro/release. Details on how to install it are provided when running `make release-notes`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #201: Fix #184 Leverage platform http service
ppalaga commented on issue #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201#issuecomment-535884193 7ccc04d removes the synchromization in the QuarkusPlatformHttpConsumer lifecycle methods. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #201: Fix #184 Leverage platform http service
ppalaga commented on a change in pull request #201: Fix #184 Leverage platform
http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r329008926
##
File path:
extensions/platform-http/component/src/main/java/org/apache/camel/component/platform/http/PlatformHttpEndpoint.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.platform.http;
+
+import java.util.Collections;
+import java.util.Set;
+import java.util.TreeSet;
+
+import org.apache.camel.AsyncEndpoint;
+import org.apache.camel.Component;
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.Producer;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.spi.HeaderFilterStrategyAware;
+import org.apache.camel.spi.UriEndpoint;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.support.DefaultEndpoint;
+
+@UriEndpoint(/* firstVersion = "3.?.0", */ scheme = "platform-http", title =
"Platform HTTP", syntax = "platform-http:[methods:]path", label = "http")
+public class PlatformHttpEndpoint extends DefaultEndpoint implements
AsyncEndpoint, HeaderFilterStrategyAware {
+
+private final String path;
+private final Set methods;
+
+@UriParam(label = "consumer", description = "A comma separated list of
HTTP methods to serve. This list will be merged with the methods specified in
the URI path. E.g. platform-http:GET,POST:/path?httpMethodRestrict=PUT,DELETE
will effectivelly result in GET,POST,PUT,DELETE. If no methods are specified,
all methods will be served.")
+private String httpMethodRestrict;
Review comment:
The component is incubating here and the API/SPI will eventually move to
Camel when it is mature enough. So IMO this is a way how to address it in
Camel.
I agree that consistency with the old stuff is nice when migrating and to
keep the old knowledge usable but the developer experience is the king for
green field projects where the old stuff does not matter that much.
It is amazing to see how excited people get when they see Panache. Applying
your argument there, Panache should not be introduced because it is reaching
the same goal as the well established Hibernate? I do not think that would be
the right approach.
I see `platform-http` as the new generation of the HTTP components where we
SHOULD be compatible with the old generation as far as possible but at the same
time it should not block us from improving things.
Having to type 18 chars less to define a route is IMO an improvement that
justifies having two ways of configuring the same thing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #201: Fix #184 Leverage platform http service
ppalaga commented on a change in pull request #201: Fix #184 Leverage platform
http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328998471
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpEngine.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.component.platform.http.PlatformHttpConstants;
+import org.apache.camel.component.platform.http.PlatformHttpEndpoint;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.jboss.logging.Logger;
+
+import io.vertx.ext.web.Router;
+
+@ApplicationScoped
+@Named(PlatformHttpConstants.PLATFORM_HTTP_ENGINE_NAME)
+public class QuarkusPlatformHttpEngine implements PlatformHttpEngine {
Review comment:
Same as above - this is possible since Quarkus 0.23. I vote for improving
this later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #201: Fix #184 Leverage platform http service
ppalaga commented on a change in pull request #201: Fix #184 Leverage platform
http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328998134
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/PlatformHttpRecorder.java
##
@@ -0,0 +1,24 @@
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpConstants;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.quarkus.core.runtime.CamelRuntime;
+import org.apache.camel.spi.Registry;
+
+import io.quarkus.arc.runtime.BeanContainer;
+import io.quarkus.runtime.RuntimeValue;
+import io.quarkus.runtime.annotations.Recorder;
+
+@Recorder
+public class PlatformHttpRecorder {
+
+public void registerBeans(RuntimeValue runtime,
BeanContainer beanContainer) {
+final Registry registry = runtime.getValue().getRegistry();
+final QuarkusPlatformHttpEngine engine =
beanContainer.instance(QuarkusPlatformHttpEngine.class);
Review comment:
Indeed, but only since Quarkus 0.23. I'd prefer improving this later when we
are on 0.23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #201: Fix #184 Leverage platform http service
ppalaga commented on a change in pull request #201: Fix #184 Leverage platform
http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328992945
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpConsumer.java
##
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import io.vertx.core.MultiMap;
+import io.vertx.core.buffer.Buffer;
+import io.vertx.core.http.HttpMethod;
+import io.vertx.core.http.HttpServerRequest;
+import io.vertx.core.http.HttpServerResponse;
+import io.vertx.ext.web.Route;
+import io.vertx.ext.web.Router;
+import io.vertx.ext.web.RoutingContext;
+
+import org.apache.camel.Consumer;
+import org.apache.camel.Endpoint;
+import org.apache.camel.Exchange;
+import org.apache.camel.Message;
+import org.apache.camel.NoTypeConversionAvailableException;
+import org.apache.camel.Processor;
+import org.apache.camel.TypeConversionException;
+import org.apache.camel.TypeConverter;
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpEndpoint;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.support.DefaultConsumer;
+import org.apache.camel.support.DefaultMessage;
+import org.apache.camel.support.ExchangeHelper;
+import org.apache.camel.support.MessageHelper;
+import org.apache.camel.support.ObjectHelper;
+
+/**
+ * A Quarkus specific {@link Consumer} for the {@link PlatformHttpComponent}.
+ */
+public class QuarkusPlatformHttpConsumer extends DefaultConsumer {
+private final Router router;
+private final Object routeLock = new Object();
+private Route route;
+
+public QuarkusPlatformHttpConsumer(Endpoint endpoint, Processor processor,
Router router) {
+super(endpoint, processor);
+this.router = router;
+}
+
+@Override
+public PlatformHttpEndpoint getEndpoint() {
+return (PlatformHttpEndpoint) super.getEndpoint();
+}
+
+@Override
+protected void doStart() throws Exception {
+super.doStart();
+
+synchronized (routeLock) {
+route = router.route(getEndpoint().getPath());
+final Setmethods = getEndpoint().getEffectiveMethods();
+if (!methods.equals(Method.getAll())) {
+methods.stream().forEach(m ->
route.method(HttpMethod.valueOf(m.name(;
+}
+
+route.handler(ctx -> {
+try {
+Exchange e = toExchange(ctx,
getEndpoint().createExchange(),
+getEndpoint().getHeaderFilterStrategy());
+getProcessor().process(e);
+writeResponse(ctx, e,
getEndpoint().getHeaderFilterStrategy());
+} catch (Exception e1) {
+throw new RuntimeException(e1);
+}
+});
+}
+}
+
+@Override
+protected void doStop() throws Exception {
+synchronized (routeLock) {
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #201: Fix #184 Leverage platform http service
ppalaga commented on a change in pull request #201: Fix #184 Leverage platform
http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328992879
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpConsumer.java
##
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import io.vertx.core.MultiMap;
+import io.vertx.core.buffer.Buffer;
+import io.vertx.core.http.HttpMethod;
+import io.vertx.core.http.HttpServerRequest;
+import io.vertx.core.http.HttpServerResponse;
+import io.vertx.ext.web.Route;
+import io.vertx.ext.web.Router;
+import io.vertx.ext.web.RoutingContext;
+
+import org.apache.camel.Consumer;
+import org.apache.camel.Endpoint;
+import org.apache.camel.Exchange;
+import org.apache.camel.Message;
+import org.apache.camel.NoTypeConversionAvailableException;
+import org.apache.camel.Processor;
+import org.apache.camel.TypeConversionException;
+import org.apache.camel.TypeConverter;
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpEndpoint;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.support.DefaultConsumer;
+import org.apache.camel.support.DefaultMessage;
+import org.apache.camel.support.ExchangeHelper;
+import org.apache.camel.support.MessageHelper;
+import org.apache.camel.support.ObjectHelper;
+
+/**
+ * A Quarkus specific {@link Consumer} for the {@link PlatformHttpComponent}.
+ */
+public class QuarkusPlatformHttpConsumer extends DefaultConsumer {
+private final Router router;
+private final Object routeLock = new Object();
+private Route route;
+
+public QuarkusPlatformHttpConsumer(Endpoint endpoint, Processor processor,
Router router) {
+super(endpoint, processor);
+this.router = router;
+}
+
+@Override
+public PlatformHttpEndpoint getEndpoint() {
+return (PlatformHttpEndpoint) super.getEndpoint();
+}
+
+@Override
+protected void doStart() throws Exception {
+super.doStart();
+
+synchronized (routeLock) {
Review comment:
Thanks, now I see there is a similar lock in ServiceSupport.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328991190
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/PlatformHttpRecorder.java
##
@@ -0,0 +1,24 @@
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpConstants;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.quarkus.core.runtime.CamelRuntime;
+import org.apache.camel.spi.Registry;
+
+import io.quarkus.arc.runtime.BeanContainer;
+import io.quarkus.runtime.RuntimeValue;
+import io.quarkus.runtime.annotations.Recorder;
+
+@Recorder
+public class PlatformHttpRecorder {
+
+public void registerBeans(RuntimeValue runtime,
BeanContainer beanContainer) {
+final Registry registry = runtime.getValue().getRegistry();
+final QuarkusPlatformHttpEngine engine =
beanContainer.instance(QuarkusPlatformHttpEngine.class);
Review comment:
There's a router build item
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328991190
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/PlatformHttpRecorder.java
##
@@ -0,0 +1,24 @@
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpConstants;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.quarkus.core.runtime.CamelRuntime;
+import org.apache.camel.spi.Registry;
+
+import io.quarkus.arc.runtime.BeanContainer;
+import io.quarkus.runtime.RuntimeValue;
+import io.quarkus.runtime.annotations.Recorder;
+
+@Recorder
+public class PlatformHttpRecorder {
+
+public void registerBeans(RuntimeValue runtime,
BeanContainer beanContainer) {
+final Registry registry = runtime.getValue().getRegistry();
+final QuarkusPlatformHttpEngine engine =
beanContainer.instance(QuarkusPlatformHttpEngine.class);
Review comment:
There a router build item
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #201: Fix #184 Leverage platform http service
ppalaga commented on a change in pull request #201: Fix #184 Leverage platform
http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328989625
##
File path:
extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/PlatformHttpRecorder.java
##
@@ -0,0 +1,24 @@
+package org.apache.camel.quarkus.component.platform.http.runtime;
+
+import org.apache.camel.component.platform.http.PlatformHttpComponent;
+import org.apache.camel.component.platform.http.PlatformHttpConstants;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.quarkus.core.runtime.CamelRuntime;
+import org.apache.camel.spi.Registry;
+
+import io.quarkus.arc.runtime.BeanContainer;
+import io.quarkus.runtime.RuntimeValue;
+import io.quarkus.runtime.annotations.Recorder;
+
+@Recorder
+public class PlatformHttpRecorder {
+
+public void registerBeans(RuntimeValue runtime,
BeanContainer beanContainer) {
+final Registry registry = runtime.getValue().getRegistry();
+final QuarkusPlatformHttpEngine engine =
beanContainer.instance(QuarkusPlatformHttpEngine.class);
Review comment:
`QuarkusPlatformHttpEngine` needs to `@Inject` the `Router`. How could that
work without the bean container?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #201: Fix #184 Leverage platform http service
lburgazzoli commented on a change in pull request #201: Fix #184 Leverage
platform http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328989670
##
File path:
extensions/platform-http/component/src/main/java/org/apache/camel/component/platform/http/PlatformHttpEndpoint.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.platform.http;
+
+import java.util.Collections;
+import java.util.Set;
+import java.util.TreeSet;
+
+import org.apache.camel.AsyncEndpoint;
+import org.apache.camel.Component;
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.Producer;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.spi.HeaderFilterStrategyAware;
+import org.apache.camel.spi.UriEndpoint;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.support.DefaultEndpoint;
+
+@UriEndpoint(/* firstVersion = "3.?.0", */ scheme = "platform-http", title =
"Platform HTTP", syntax = "platform-http:[methods:]path", label = "http")
+public class PlatformHttpEndpoint extends DefaultEndpoint implements
AsyncEndpoint, HeaderFilterStrategyAware {
+
+private final String path;
+private final Set methods;
+
+@UriParam(label = "consumer", description = "A comma separated list of
HTTP methods to serve. This list will be merged with the methods specified in
the URI path. E.g. platform-http:GET,POST:/path?httpMethodRestrict=PUT,DELETE
will effectivelly result in GET,POST,PUT,DELETE. If no methods are specified,
all methods will be served.")
+private String httpMethodRestrict;
Review comment:
it is super confusing as we have two competing way to set the same thing.
We do already have lot of discrepancies in components, please try to stick
with what we have and if you think there is something better, please address it
camel itself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #201: Fix #184 Leverage platform http service
ppalaga commented on a change in pull request #201: Fix #184 Leverage platform
http service
URL: https://github.com/apache/camel-quarkus/pull/201#discussion_r328988066
##
File path:
extensions/platform-http/component/src/main/java/org/apache/camel/component/platform/http/PlatformHttpEndpoint.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.platform.http;
+
+import java.util.Collections;
+import java.util.Set;
+import java.util.TreeSet;
+
+import org.apache.camel.AsyncEndpoint;
+import org.apache.camel.Component;
+import org.apache.camel.Consumer;
+import org.apache.camel.Processor;
+import org.apache.camel.Producer;
+import org.apache.camel.component.platform.http.spi.Method;
+import org.apache.camel.component.platform.http.spi.PlatformHttpEngine;
+import org.apache.camel.spi.HeaderFilterStrategy;
+import org.apache.camel.spi.HeaderFilterStrategyAware;
+import org.apache.camel.spi.UriEndpoint;
+import org.apache.camel.spi.UriParam;
+import org.apache.camel.support.DefaultEndpoint;
+
+@UriEndpoint(/* firstVersion = "3.?.0", */ scheme = "platform-http", title =
"Platform HTTP", syntax = "platform-http:[methods:]path", label = "http")
+public class PlatformHttpEndpoint extends DefaultEndpoint implements
AsyncEndpoint, HeaderFilterStrategyAware {
+
+private final String path;
+private final Set methods;
+
+@UriParam(label = "consumer", description = "A comma separated list of
HTTP methods to serve. This list will be merged with the methods specified in
the URI path. E.g. platform-http:GET,POST:/path?httpMethodRestrict=PUT,DELETE
will effectivelly result in GET,POST,PUT,DELETE. If no methods are specified,
all methods will be served.")
+private String httpMethodRestrict;
Review comment:
`platform-http:GET:/platform-http/hello` is shorter, faster to type and
faster to read than `platform-http:/platform-http/hello?httpMethodRestrict=GET`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #961: Upgrade to Knative 0.9
nicolaferraro commented on issue #961: Upgrade to Knative 0.9 URL: https://github.com/apache/camel-k/pull/961#issuecomment-535851962 > May need to update the OLM manifest for 1.0.0-M2 as well. Right. Done! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] dmvolod closed issue #85: Able to run maven build with debug and/or extended info
dmvolod closed issue #85: Able to run maven build with debug and/or extended info URL: https://github.com/apache/camel-k/issues/85 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] dmvolod closed issue #839: Orphan generated XML DSL from OpenAPI JSON after deleting integration
dmvolod closed issue #839: Orphan generated XML DSL from OpenAPI JSON after deleting integration URL: https://github.com/apache/camel-k/issues/839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] dmvolod closed issue #598: Review reset and delete with --all option for merging similar functions to one place
dmvolod closed issue #598: Review reset and delete with --all option for merging similar functions to one place URL: https://github.com/apache/camel-k/issues/598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] dmvolod closed pull request #883: Orphan generated XML DSL from OpenAPI JSON after deleting integration
dmvolod closed pull request #883: Orphan generated XML DSL from OpenAPI JSON after deleting integration URL: https://github.com/apache/camel-k/pull/883 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #142: Include camel-k-runtime version in camel-catalog
lburgazzoli commented on issue #142: Include camel-k-runtime version in camel-catalog URL: https://github.com/apache/camel-k-runtime/pull/142#issuecomment-535833055 no worries, I was faster than you :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] oscerd commented on issue #142: Include camel-k-runtime version in camel-catalog
oscerd commented on issue #142: Include camel-k-runtime version in camel-catalog URL: https://github.com/apache/camel-k-runtime/pull/142#issuecomment-535816668 Sorry, I merged but I was looking at a different tab.. If needed I can revert This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] oscerd merged pull request #142: Include camel-k-runtime version in camel-catalog
oscerd merged pull request #142: Include camel-k-runtime version in camel-catalog URL: https://github.com/apache/camel-k-runtime/pull/142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on a change in pull request #142: Include camel-k-runtime version in camel-catalog
lburgazzoli commented on a change in pull request #142: Include camel-k-runtime version in camel-catalog URL: https://github.com/apache/camel-k-runtime/pull/142#discussion_r328932663 ## File path: tooling/camel-k-maven-plugin/src/it/generate-catalog/verify.groovy ## @@ -0,0 +1,25 @@ +/* + * Copyright (C) 2016 Red Hat, Inc. Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli merged pull request #143: groovy: improve rest dsl
lburgazzoli merged pull request #143: groovy: improve rest dsl URL: https://github.com/apache/camel-k-runtime/pull/143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli merged pull request #144: Update deps
lburgazzoli merged pull request #144: Update deps URL: https://github.com/apache/camel-k-runtime/pull/144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #144: Update deps
lburgazzoli commented on issue #144: Update deps URL: https://github.com/apache/camel-k-runtime/pull/144#issuecomment-535800261 > There is a new release of groovy 2.5.8, you may consider to upgrade that too. https://github.com/apache/camel-k-runtime/blob/master/pom.xml#L48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
