Re: camel-vertx-kafka and TLS 1.2 vs 1.3

2020-12-08 Thread Omar Al-Safi
So I have overridden the default values
,
so it shouldn't matter the JDK version that is used for complication.

Regards,

On Tue, Dec 8, 2020 at 11:01 AM Omar Al-Safi  wrote:

> Yeah we can, I will override this shortly in the pom file.
>
> On Tue, Dec 8, 2020 at 7:14 AM Claus Ibsen  wrote:
>
>> Hi
>>
>> This new component seems to generate different configuration class
>> whether compiled with JDK8 ot JDK11.
>>
>> This commit is a regen from JDK11
>>
>> https://github.com/apache/camel/commit/4dd5a2cc782ad11633e161549534e98976a94367
>>
>> So it looks like the TLS1.2 and 1.3 discovery depends on the JDK
>> version used for compilation. Maybe we should lock this down to
>> TLSv1.2,TLSv1.3 so when we do a release, then Gregor compiles with
>> JDK8 then the default will be correct for running on either JDK8 or
>> JDK11.
>>
>>
>>
>> --
>> Claus Ibsen
>> -
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2
>>
>


Re: camel-vertx-kafka and TLS 1.2 vs 1.3

2020-12-08 Thread Omar Al-Safi
Yeah we can, I will override this shortly in the pom file.

On Tue, Dec 8, 2020 at 7:14 AM Claus Ibsen  wrote:

> Hi
>
> This new component seems to generate different configuration class
> whether compiled with JDK8 ot JDK11.
>
> This commit is a regen from JDK11
>
> https://github.com/apache/camel/commit/4dd5a2cc782ad11633e161549534e98976a94367
>
> So it looks like the TLS1.2 and 1.3 discovery depends on the JDK
> version used for compilation. Maybe we should lock this down to
> TLSv1.2,TLSv1.3 so when we do a release, then Gregor compiles with
> JDK8 then the default will be correct for running on either JDK8 or
> JDK11.
>
>
>
> --
> Claus Ibsen
> -
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>


camel-vertx-kafka and TLS 1.2 vs 1.3

2020-12-07 Thread Claus Ibsen
Hi

This new component seems to generate different configuration class
whether compiled with JDK8 ot JDK11.

This commit is a regen from JDK11
https://github.com/apache/camel/commit/4dd5a2cc782ad11633e161549534e98976a94367

So it looks like the TLS1.2 and 1.3 discovery depends on the JDK
version used for compilation. Maybe we should lock this down to
TLSv1.2,TLSv1.3 so when we do a release, then Gregor compiles with
JDK8 then the default will be correct for running on either JDK8 or
JDK11.



-- 
Claus Ibsen
-
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2