Re: yaml-dsl on main failing
Thanks Claus, I was looking at the PR that introduced this change and I noticed that it did not have any tests because the changes were spread in areas not covered by our github actions check. Maybe one activity for the future is to increase the test coverage for changes on the dsl/* components so that we can catch issues like these earlier. I created https://issues.apache.org/jira/browse/CAMEL-18744 so we won't forget to do this when we have some time. Kind regards On Wed, Nov 23, 2022 at 6:53 AM Claus Ibsen wrote: > Hi > > I had to revert the jandex upgrade, as we need to find a fix so the > yaml-dsl is not affected. > > On Tue, Nov 22, 2022 at 2:53 PM Claus Ibsen wrote: > > > Hi > > > > Okay so reverting these works > > > > commit 0f5125829c6f350b3ded7f8d389f938c6e538e2c (HEAD -> main) > > Author: Claus Ibsen > > Date: Tue Nov 22 13:38:16 2022 +0100 > > > > Revert "CAMEL-18707: Upgrade to Jandex 3.0.3 (#8735)" > > > > This reverts commit 469faf73eca13d7f006fa1f8e54fbd4326cc0df5. > > > > commit c30e0a99ef0ef3d33024726e550ae2530f891b97 > > Author: Claus Ibsen > > Date: Tue Nov 22 13:36:10 2022 +0100 > > > > Revert "Regen for commit 9f3d15cade87a4e785c138f0b22b3d910b5ccbc6 > > (#8754)" > > > > This reverts commit 9f8a3cbd7a45c201bd3bd7a871168b55e1ef96a8. > > > > > > > > On Tue, Nov 22, 2022 at 1:46 PM Claus Ibsen > wrote: > > > >> Hi > >> > >> I am tracking what happened as the yaml-dsl unexpected is failing, as it > >> seems its generated a little bit different now (inline = true is > removed) > >> > >> I suspect its maybe related to the jandex upgrade > >> > >> > https://ci-builds.apache.org/job/Camel/job/Apache%20Camel/job/main/lastCompletedBuild/changes#469faf73eca13d7f006fa1f8e54fbd4326cc0df5 > >> > >> I am rebuilding after a few git reverts to find out. > >> > >> > >> > >> -- > >> Claus Ibsen > >> - > >> @davsclaus > >> Camel in Action 2: https://www.manning.com/ibsen2 > >> > > > > > > -- > > Claus Ibsen > > - > > @davsclaus > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > -- > Claus Ibsen > - > @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 > -- Otavio R. Piske http://orpiske.net
Re: yaml-dsl on main failing
Hi I had to revert the jandex upgrade, as we need to find a fix so the yaml-dsl is not affected. On Tue, Nov 22, 2022 at 2:53 PM Claus Ibsen wrote: > Hi > > Okay so reverting these works > > commit 0f5125829c6f350b3ded7f8d389f938c6e538e2c (HEAD -> main) > Author: Claus Ibsen > Date: Tue Nov 22 13:38:16 2022 +0100 > > Revert "CAMEL-18707: Upgrade to Jandex 3.0.3 (#8735)" > > This reverts commit 469faf73eca13d7f006fa1f8e54fbd4326cc0df5. > > commit c30e0a99ef0ef3d33024726e550ae2530f891b97 > Author: Claus Ibsen > Date: Tue Nov 22 13:36:10 2022 +0100 > > Revert "Regen for commit 9f3d15cade87a4e785c138f0b22b3d910b5ccbc6 > (#8754)" > > This reverts commit 9f8a3cbd7a45c201bd3bd7a871168b55e1ef96a8. > > > > On Tue, Nov 22, 2022 at 1:46 PM Claus Ibsen wrote: > >> Hi >> >> I am tracking what happened as the yaml-dsl unexpected is failing, as it >> seems its generated a little bit different now (inline = true is removed) >> >> I suspect its maybe related to the jandex upgrade >> >> https://ci-builds.apache.org/job/Camel/job/Apache%20Camel/job/main/lastCompletedBuild/changes#469faf73eca13d7f006fa1f8e54fbd4326cc0df5 >> >> I am rebuilding after a few git reverts to find out. >> >> >> >> -- >> Claus Ibsen >> - >> @davsclaus >> Camel in Action 2: https://www.manning.com/ibsen2 >> > > > -- > Claus Ibsen > - > @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 > -- Claus Ibsen - @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
Re: yaml-dsl on main failing
Hi Okay so reverting these works commit 0f5125829c6f350b3ded7f8d389f938c6e538e2c (HEAD -> main) Author: Claus Ibsen Date: Tue Nov 22 13:38:16 2022 +0100 Revert "CAMEL-18707: Upgrade to Jandex 3.0.3 (#8735)" This reverts commit 469faf73eca13d7f006fa1f8e54fbd4326cc0df5. commit c30e0a99ef0ef3d33024726e550ae2530f891b97 Author: Claus Ibsen Date: Tue Nov 22 13:36:10 2022 +0100 Revert "Regen for commit 9f3d15cade87a4e785c138f0b22b3d910b5ccbc6 (#8754)" This reverts commit 9f8a3cbd7a45c201bd3bd7a871168b55e1ef96a8. On Tue, Nov 22, 2022 at 1:46 PM Claus Ibsen wrote: > Hi > > I am tracking what happened as the yaml-dsl unexpected is failing, as it > seems its generated a little bit different now (inline = true is removed) > > I suspect its maybe related to the jandex upgrade > > https://ci-builds.apache.org/job/Camel/job/Apache%20Camel/job/main/lastCompletedBuild/changes#469faf73eca13d7f006fa1f8e54fbd4326cc0df5 > > I am rebuilding after a few git reverts to find out. > > > > -- > Claus Ibsen > - > @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 > -- Claus Ibsen - @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
yaml-dsl on main failing
Hi I am tracking what happened as the yaml-dsl unexpected is failing, as it seems its generated a little bit different now (inline = true is removed) I suspect its maybe related to the jandex upgrade https://ci-builds.apache.org/job/Camel/job/Apache%20Camel/job/main/lastCompletedBuild/changes#469faf73eca13d7f006fa1f8e54fbd4326cc0df5 I am rebuilding after a few git reverts to find out. -- Claus Ibsen - @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
