[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r327479299
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Hi @astefanutti ,
Since we are not able to get any alternative solution for this, so can we go
ahead to merge this patch?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
astefanutti commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r327479834
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Sorry for the delay, I'm looking at it right now and I'll get back to you on
this today.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
astefanutti commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r327513592
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
It seems possible to check whether an option has been explicitly provided
with `flag.Flag.Changed`, e.g.:
```
func (o *installCmdOptions) install(cmd *cobra.Command, _ []string) error {
flag := cmd.Flags().Lookup("kaniko-cache")
if flag.Changed {
// ...
```
Ideally, we would need spf13/pflag#214, e.g. for knative/client#346, but
that's another issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r327515627
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Thanks @astefanutti , I will look into this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Re: [VOTE] Release Apache Camel Quarkus 0.2.0
+1. For the Tag it could be better to use hash number, as the git tags could be changed without notice. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Mon, Sep 23, 2019 at 3:12 PM Andrea Cosentino wrote: > > Hello all: > > This is a vote to release Apache Camel Quarkus 0.2.0 > > This release contains new extensions and it has been updated to Camel > 3.0.0-RC1 and Quarkus 0.22.0. > > Staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1153/ > > Tag: > https://gitbox.apache.org/repos/asf?p=camel-quarkus.git;a=tag;h=refs/tags/0.2.0 > > Source release package: > https://repository.apache.org/content/repositories/orgapachecamel-1153/org/apache/camel/quarkus/camel-quarkus-parent/0.2.0/camel-quarkus-parent-0.2.0-source-release.zip > > Please test this release candidate and cast your vote. > > [ ] +1 Release the binary as Apache Camel Quarkus 0.2.0 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Andrea > > > -- > Andrea Cosentino > -- > Apache Camel PMC Chair > Apache Karaf Committer > Apache Servicemix PMC Member > Email: ancosen1...@yahoo.com > Twitter: @oscerd2 > Github: oscerd
[GitHub] [camel-k] nicolaferraro commented on issue #888: Camel K should use duck types to recognize Knative sinks
nicolaferraro commented on issue #888: Camel K should use duck types to recognize Knative sinks URL: https://github.com/apache/camel-k/issues/888#issuecomment-534550335 This is an issue with knative 0.8+ releases where e.g. channels have been moved from eventing.knative.dev to messaging.knative.dev This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new issue #952: Upgrade to Knative 0.9
nicolaferraro opened a new issue #952: Upgrade to Knative 0.9 URL: https://github.com/apache/camel-k/issues/952 Leaving compatibility with 0.8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #953: fix(build): Go 1.13 compatibility
astefanutti opened a new pull request #953: fix(build): Go 1.13 compatibility URL: https://github.com/apache/camel-k/pull/953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lburgazzoli merged pull request #953: fix(build): Go 1.13 compatibility
lburgazzoli merged pull request #953: fix(build): Go 1.13 compatibility URL: https://github.com/apache/camel-k/pull/953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #954: Jolokia and Prometheus traits fixes
astefanutti opened a new pull request #954: Jolokia and Prometheus traits fixes URL: https://github.com/apache/camel-k/pull/954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
