[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim property fo...
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/200#discussion_r85957010
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/graphgenerator/GraphGenerator.java
---
@@ -998,4 +1000,24 @@ private void
prepareIsUseInvertedIndex(List dims,
graphConfig.setIsUseInvertedIndex(
isUseInvertedIndexList.toArray(new
Boolean[isUseInvertedIndexList.size()]));
}
+
+ /**
+ * Preparing the boolean [] to map whether the dimension use trim or not.
+ *
+ * @param dims
+ * @param graphConfig
+ */
+ private void prepareIsUseTrim(List dims,
+GraphConfigurationInfo graphConfig) {
+List isUseTrimList = new ArrayList();
+for (CarbonDimension dimension : dims) {
+ if (dimension.isUseTrim()) {
--- End diff --
Can we add this trim option as property of the column, i mean inside a
column property rather than setting directly as CarbonDimension property,
Already in CarbonColumn there is a property map which holds column related
properties, i think we can use that, please check the feasibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim property fo...
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r85957803 --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java --- @@ -472,6 +475,7 @@ public boolean processRow(StepMetaInterface smi, StepDataInterface sdi) throws K break; } } +<<< HEAD --- End diff -- is this file is having any conflict? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim property fo...
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/200#discussion_r85957411
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenMeta.java
---
@@ -1694,5 +1699,19 @@ public void setTableOption(String tableOption) {
public TableOptionWrapper getTableOptionWrapper() {
return tableOptionWrapper;
}
+
+ public String getIsUseTrim() {
+return isUseTrim;
+ }
+
+ public void setIsUseTrim(Boolean[] isUseTrim) {
+for (Boolean flag: isUseTrim) {
+ if (flag) {
+this.isUseTrim += "T";
--- End diff --
Use TRUE/FALSE for better readability
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
