[GitHub] incubator-carbondata pull request #204: [CARBONDATA-280]Fix the bug that whe...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/204


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #204: [CARBONDATA-280]Fix the bug that whe...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/204#discussion_r83027008
  
--- Diff: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/deleteTable/TestDeleteTableNewDDL.scala
 ---
@@ -97,7 +97,7 @@ class TestDeleteTableNewDDL extends QueryTest with 
BeforeAndAfterAll {
   "CREATE table CaseInsensitiveTable (ID int, date String, country 
String, name " +
   "String," +
   "phonetype String, serialname String, salary int) stored by 
'org.apache.carbondata.format'" +
-  "TBLPROPERTIES('DICTIONARY_INCLUDE'='ID', 
'DICTIONARY_INCLUDE'='salary')"
+  "TBLPROPERTIES('DICTIONARY_INCLUDE'='ID,salary')"
--- End diff --

add space after `,`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #204: [CARBONDATA-280]Fix the bug that whe...

[Zhangshunyu]

GitHub user Zhangshunyu reopened a pull request:

https://github.com/apache/incubator-carbondata/pull/204

[CARBONDATA-280]Fix the bug that when table properties is repeated it only 
set the last one

## Why raise this pr?
When table properties is repeated it only set the last one, for example,
```
CREATE TABLE IF NOT EXISTS carbontable
(ID Int, date Timestamp, country String,
name String, phonetype String, serialname String, salary Int)
STORED BY 'carbondata'
TBLPROPERTIES('DICTIONARY_EXCLUDE'='country','DICTIONARY_INCLUDE'='ID',
'DICTIONARY_EXCLUDE'='phonetype', 'DICTIONARY_INCLUDE'='salary')
```
As we use map to store the properties, only salary is set to 
DICTIONARY_INCLUDE and only phonetype is set to DICTIONARY_EXCLUDE.

## How to solve?
**We should do restrict syntax check that 
'DICTIONARY_EXCLUDE'='country,phonetype' , 'DICTIONARY_INCLUDE'='ID,salary**' 
and if table properties is repeated, throw an  MalformedCarbonCommandException 
to tell the user that Table properties is repeated, so that the user would not 
perform error operation.

## How to test?
Pass the exist test cases and the new test case for this bug.
## Test Result
CI has passed:
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/354/testReport/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Zhangshunyu/incubator-carbondata tbprop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #204


commit 3e0030e04bff9d11f87471684b4b7b7a8d8b6209
Author: Zhangshunyu 
Date:   2016-09-28T04:50:01Z

Fix the bug that when table properties is repeated it only set the last one

commit 1828b2b78b3de9f7fa127cfcc17bf24d6c138640
Author: Zhangshunyu 
Date:   2016-09-28T05:11:12Z

Fix the test case

commit 876828400f02bb68190222e38898ccec29bb2f04
Author: Zhangshunyu 
Date:   2016-09-28T08:34:36Z

Simply

commit a7a03508b494701ec641b66449a2f0df81e2fde0
Author: Zhangshunyu 
Date:   2016-09-28T08:38:57Z

Simply




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #204: [CARBONDATA-280]Fix the bug that whe...

[Zhangshunyu]

Github user Zhangshunyu closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/204


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #204: [CARBONDATA-280]Fix the bug that whe...

[Zhangshunyu]

GitHub user Zhangshunyu opened a pull request:

https://github.com/apache/incubator-carbondata/pull/204

[CARBONDATA-280]Fix the bug that when table properties is repeated it only 
set the last one

## Why raise this pr?
When table properties is repeated it only set the last one, for example,
```
CREATE TABLE IF NOT EXISTS carbontable
(ID Int, date Timestamp, country String,
name String, phonetype String, serialname String, salary Int)
STORED BY 'carbondata'
TBLPROPERTIES(**'DICTIONARY_EXCLUDE'='country','DICTIONARY_INCLUDE'='ID',
'DICTIONARY_EXCLUDE'='phonetype', 'DICTIONARY_INCLUDE'='salary'**)
```
only salary is set to DICTIONARY_INCLUDE and only phonetype is set to 
DICTIONARY_EXCLUDE.

## How to solve?
We should do restrict syntax check and if table properties is repeated, 
throw an  MalformedCarbonCommandException to tell the user that Table 
properties is repeated, so that the user would not perform error operation.

## How to test?
Pass the exist test cases and the new test case for this bug.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Zhangshunyu/incubator-carbondata tbprop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #204


commit 3e0030e04bff9d11f87471684b4b7b7a8d8b6209
Author: Zhangshunyu 
Date:   2016-09-28T04:50:01Z

Fix the bug that when table properties is repeated it only set the last one




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---