[GitHub] incubator-carbondata pull request #81: [CARBONDATA-132] Parse some Spark exc...

[Zhangshunyu]

Github user Zhangshunyu commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/81#discussion_r75984291
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
 ---
@@ -775,6 +777,13 @@ object CarbonDataRDDFactory extends Logging {
   loadStatus = CarbonCommonConstants.STORE_LOADSTATUS_FAILURE
   logInfo("DataLoad failure")
   logger.error(ex)
--- End diff --

OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #81: [CARBONDATA-132] Parse some Spark exc...

[Zhangshunyu]

Github user Zhangshunyu commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/81#discussion_r75984276
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
 ---
@@ -775,6 +777,13 @@ object CarbonDataRDDFactory extends Logging {
   loadStatus = CarbonCommonConstants.STORE_LOADSTATUS_FAILURE
   logInfo("DataLoad failure")
   logger.error(ex)
+  ex match {
+case sparkException: SparkException =>
+  if 
(sparkException.getCause.isInstanceOf[DataLoadingException]) {
+executorMessage = sparkException.getCause.getMessage
+  }
+case _ =>
--- End diff --

Here we only get DataLoadingException from executor and show it directly to 
user so that he can know his incorrect operation, but the other exception we 
still use "DataLoad Failure", because we do not show internal error to user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #81: [CARBONDATA-132] Parse some Spark exc...

[manishgupta88]

Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/81#discussion_r75869589
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
 ---
@@ -775,6 +777,13 @@ object CarbonDataRDDFactory extends Logging {
   loadStatus = CarbonCommonConstants.STORE_LOADSTATUS_FAILURE
   logInfo("DataLoad failure")
   logger.error(ex)
--- End diff --

@Zhangshunyu Move logInfo and logger.error below the case match 
blockalso in logInfo log the executorMessage. you can move the variable 
message also above with default value as "DataLoad failure: " so that the same 
can be used for logInfo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #81: [CARBONDATA-132] Parse some Spark exc...

[manishgupta88]

Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/81#discussion_r75869120
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
 ---
@@ -775,6 +777,13 @@ object CarbonDataRDDFactory extends Logging {
   loadStatus = CarbonCommonConstants.STORE_LOADSTATUS_FAILURE
   logInfo("DataLoad failure")
   logger.error(ex)
+  ex match {
+case sparkException: SparkException =>
+  if 
(sparkException.getCause.isInstanceOf[DataLoadingException]) {
+executorMessage = sparkException.getCause.getMessage
+  }
+case _ =>
--- End diff --

@Zhangshunyu ...for underscore case also get the message and assign it to 
variable executorMessage because lets say the control comes to case _ then 
variable executorMessage will have empty value and message will remain as 
"DataLoad failure: " which will be incorrect


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---