[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

[QiangCai]

Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/97#discussion_r76513592
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
@@ -689,6 +689,10 @@ object GlobalDictionaryUtil extends Logging {
   generatePredefinedColDictionary(colDictFilePath, table,
 dimensions, carbonLoadModel, sqlContext, hdfsLocation, 
dictfolderPath)
 }
+if (headers.length > df.columns.length) {
+  logError("Either delimiter or fileheader provided is not 
correct")
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

[Vimal-Das]

Github user Vimal-Das commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/97#discussion_r76512936
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
@@ -689,6 +689,10 @@ object GlobalDictionaryUtil extends Logging {
   generatePredefinedColDictionary(colDictFilePath, table,
 dimensions, carbonLoadModel, sqlContext, hdfsLocation, 
dictfolderPath)
 }
+if (headers.length > df.columns.length) {
+  logError("Either delimiter or fileheader provided is not 
correct")
--- End diff --

The log can be more informative like
" The number of columns in the file header do not match the number of 
columns in the data file; Either delimiter or fileheader provided is not 
correct"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

[QiangCai]

Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/97#discussion_r76384836
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
@@ -689,6 +689,10 @@ object GlobalDictionaryUtil extends Logging {
   generatePredefinedColDictionary(colDictFilePath, table,
 dimensions, carbonLoadModel, sqlContext, hdfsLocation, 
dictfolderPath)
 }
+if (headers.length > df.columns.length) {
+  logError("Maybe either delimiter or fileheader is wrong")
+  throw new DataLoadingException("Maybe either delimiter or 
fileheader is wrong")
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

[manishgupta88]

Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/97#discussion_r76381309
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
@@ -689,6 +689,10 @@ object GlobalDictionaryUtil extends Logging {
   generatePredefinedColDictionary(colDictFilePath, table,
 dimensions, carbonLoadModel, sqlContext, hdfsLocation, 
dictfolderPath)
 }
+if (headers.length > df.columns.length) {
+  logError("Maybe either delimiter or fileheader is wrong")
+  throw new DataLoadingException("Maybe either delimiter or 
fileheader is wrong")
--- End diff --

@QiangCai ...Please modify this message as below:
"Either delimiter or fileheader provided is not correct"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

[QiangCai]

Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/97#discussion_r76374282
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
@@ -705,7 +709,7 @@ object GlobalDictionaryUtil extends Logging {
   // check result status
   checkStatus(carbonLoadModel, sqlContext, model, statusList)
 } else {
-  logInfo("have no column need to generate global dictionary in 
Fact file")
+  logInfo("have no column need to generate global dictionary in 
source data files")
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

[manishgupta88]

Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/97#discussion_r76373466
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
@@ -705,7 +709,7 @@ object GlobalDictionaryUtil extends Logging {
   // check result status
   checkStatus(carbonLoadModel, sqlContext, model, statusList)
 } else {
-  logInfo("have no column need to generate global dictionary in 
Fact file")
+  logInfo("have no column need to generate global dictionary in 
source data files")
--- End diff --

@QiangCai ...Please modify the logger message as below:
"No column found for generating global dictionary in source data files"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

[QiangCai]

GitHub user QiangCai opened a pull request:

https://github.com/apache/incubator-carbondata/pull/97

[CARBONDATA-180]give proper error message when dataloading with wrong 
delimiter or fileheader

**1 CarbonData JIRA link**
[CARBONDATA-180](https://issues.apache.org/jira/browse/CARBONDATA-180)

**2 Cause Analysis**
When dataloading with wrong delimiter or fileheader,  We get less columns  
from input file than columns in fileheader property.

**3 Solution**
We can check the columns in fileheader property and the columns in input 
files. If these two columns list are different, we can stop dataloading flow 
and give a proper error message.  

**4 Impact**
DataLoading

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QiangCai/incubator-carbondata 
fixWrongdelimiter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #97


commit a285462795066d74ac2580714a5009b37ff5b754
Author: QiangCai 
Date:   2016-08-26T02:57:53Z

give a proper error message for wrong delimiter or fileheader




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---