Re: Request for review - 2 jiras for 3.0/3.11

[Dinesh Joshi]

I can help review these Jiras. However, they are touching the gossip subsystem 
and would recommend someone more familiar with that part of the code to do a 
2nd pass before we commit it.

Thanks,

Dinesh

> On Jul 8, 2019, at 10:53 AM, Michael Shuler  wrote:
> 
> Resending as a new req-for-review thread for visibility, since they look 
> important to my untrained eye:
> 
> https://issues.apache.org/jira/browse/CASSANDRA-15097
> https://issues.apache.org/jira/browse/CASSANDRA-15098
> 
> Michael
> 
>  Forwarded Message 
> Subject: Re: Time for a new 3.0/3.11 release?
> Date: Wed, 3 Jul 2019 10:38:38 -0700
> From: Jay Zhuang 
> Reply-To: dev@cassandra.apache.org
> To: dev@cassandra.apache.org
> 
> I'd like to raise some attention for the following 2 tickets, they're
> patch-ready and deployed on all our production clusters:
> * CASSANDRA-15098: "Endpoints no longer owning tokens are not removed for
> vnode"
>  For vNode cluster, the replaced node may not be removed from gossiper
> (and system.peers, every time a node restart, they will be re-populated
> into gossiper from system.peers). The patch is pretty small and
> straightforward.
> * CASSANDRA-15097: "Avoid updating unchanged gossip state"
>  I think this is a bug because it's not only causing large pending gossip
> tasks, it's also causing long token-metadata update lock for large vNode
> cluster.
> 
> Here is another improvement we made for vNode to avoid gossip block during
> removeNode: CASSANDRA-15141. But I think it can wait until 4.x. It mostly
> causes problem for 1000+ vNode clusters.
> 
> Thanks,
> Jay
> 
> On Tue, Jul 2, 2019 at 10:28 PM Mick Semb Wever  wrote:
> 
>> 
>> 
>> > Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
>> > 3.11.5 release?
>> 
>> 
>> I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see
>> no reason why Michael would wait for this when he generously finds time to
>> cut a release.
>> 
>> Maybe the author and reviewer decides to push it to both 3.11.x and 4.0,
>> but that's irrelevant to this thread.
>> 
>> regards,
>> Mick
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
>> For additional commands, e-mail: dev-h...@cassandra.apache.org
>> 
>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Request for review - 2 jiras for 3.0/3.11

[Michael Shuler]

Resending as a new req-for-review thread for visibility, since they look 
important to my untrained eye:


https://issues.apache.org/jira/browse/CASSANDRA-15097
https://issues.apache.org/jira/browse/CASSANDRA-15098

Michael

 Forwarded Message 
Subject: Re: Time for a new 3.0/3.11 release?
Date: Wed, 3 Jul 2019 10:38:38 -0700
From: Jay Zhuang 
Reply-To: dev@cassandra.apache.org
To: dev@cassandra.apache.org

I'd like to raise some attention for the following 2 tickets, they're
patch-ready and deployed on all our production clusters:
* CASSANDRA-15098: "Endpoints no longer owning tokens are not removed for
vnode"
  For vNode cluster, the replaced node may not be removed from gossiper
(and system.peers, every time a node restart, they will be re-populated
into gossiper from system.peers). The patch is pretty small and
straightforward.
* CASSANDRA-15097: "Avoid updating unchanged gossip state"
  I think this is a bug because it's not only causing large pending gossip
tasks, it's also causing long token-metadata update lock for large vNode
cluster.

Here is another improvement we made for vNode to avoid gossip block during
removeNode: CASSANDRA-15141. But I think it can wait until 4.x. It mostly
causes problem for 1000+ vNode clusters.

Thanks,
Jay

On Tue, Jul 2, 2019 at 10:28 PM Mick Semb Wever  wrote:




> Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
> 3.11.5 release?


I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see
no reason why Michael would wait for this when he generously finds time to
cut a release.

Maybe the author and reviewer decides to push it to both 3.11.x and 4.0,
but that's irrelevant to this thread.

regards,
Mick

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: Time for a new 3.0/3.11 release?

[Michael Shuler]

On 7/3/19 1:44 PM, aj...@apache.org wrote:

In fact there is a branch for it noted in the ticket, from which a
patch could be cut instantly, but there doesn't seem to be any point
to doing that until the feature freeze is over. Is there any sense of
timing on that? I've seen a few discussions about release process for
4.x on this list, but I haven't been able to get a sense of how long
it might be.


I see a couple different links to a couple different branches and a 
github compare with conflicts in comments in CASSANDRA-15005. I see no 
PR link, and the project doesn't use PRs in practice. There is no patch 
attached to the jira. I also see a link to an open related jira and 
discussion around that. I don't know the details of the actual 
feature/improvement, but the discussion appears (to me) to still be a 
discussion. It does not look (to me) like a finalized patch with 
completed CI links, etc. ready for someone to review. Regardless, it 
does not appear (to me) to be appropriate for 3.11.x.


The cassandra-3.11 branch is in maintenance mode, which means no new 
features. Improvements require discussion and consensus for inclusion in 
maintenance branches, in order to keep breaking changes to a minimum. 
New features should target the trunk branch (4.0), unless there is a 
previously obtained consensus to include a particular 
improvement/feature in an earlier branch. Indeed, the trunk branch has 
been frozen for new feature inclusion for quite some time, and there 
have been some limited discussions on how long this might be. "When it's 
done" is basically the current answer, while the existing in-flight, 
approved feature jiras are still in progress or under review.


With trunk frozen, this feature may need to simply wait. This is an 
example of a possible problem with a long-frozen trunk branch - new 
things may need to sit in limbo for a while, until cassandra-4.0 is 
branched and there is an opportunity to commit new features to trunk again.


I hope that helps! Some of the above is definitely my understanding and 
some subjective observation of that specific jira.


(An update on the current state of in-progress/review statuses for 4.0 
jiras from the folks working on them would be awesome! hint hint.)


Kind regards,
Michael



On Wed, Jul 3, 2019, 1:28 AM Mick Semb Wever mailto:m...@apache.org>> wrote:


Is there any chance to get CASSANDRA-15005 (ready, with PR) into a 
3.11.5 release?



I doubt it Soroka. It's not a bug and there's no patch for it, so I'd
see no reason why Michael would wait for this when he generously
finds time to cut a release.

Maybe the author and reviewer decides to push it to both 3.11.x and
4.0, but that's irrelevant to this thread.

regards, Mick

-


To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 


For additional commands, e-mail: dev-h...@cassandra.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org