Re: [DISCUSS] Change the useage of nodetool tablehistograms

2023-03-21 Thread guo Maxwell
Thanks everyone , So It seems that it is better to add new parameter
options to meet our needs, while keeping the original parameter functions
unaffected to achieve backward compatibility.
So the new options are :
1. nodetool tablehistograms ks.tb1 or ks tb1  ... //this is *one of the old
way *of using tablehistogram. will print out the histograms of tabke ks.tb1
, we keep the old format to print out the table histograms,besides if more
than two arguments is provied, suchu as nodetool tablehistograms
system.local system_schema.columns system_schema.tables then all
tables's  histograms
will be printed out (I think this is a bug that not as excepted in the
document's decription, we should remind the user that this is an incorrenct
usage)

2. nodetool tablehistograms -tbs ks.tb1 ks.tb2  //print out list of
tables' histograms with format keyspace.table
3.nodetool tablehistograms -ks ks1 ks2 ks3 ... //print out list of
keyspaces histograms
4.nodetool tablehistograms -i -ks ks1 ks2  //print out list of table
histograms except for the keyspaces list behind the option -i
5.nodetool tablehistograns -i -tbs ks.tb1 ks.tb2 // print out list tables'
histograms except for table in ks.tb1 ks.tb2
6.nodetool tablehistograns -i -tbs ks.tb1 ks.tb2 -ks ks1 // print out list
tables' histograms except for table in ks.tb1 ks.tb2 and all tables in ks1
6.none option specified ,then all tables histograms will be print out.// this
is *another one of the old way* of using tablehistogram.

So we add some more options like "-i", "-ks", "-tbs" , we can combine these
options  and we can also use any of them individually, besides, we can also
use the tool through old way if a table with format ks.tb is provied.


Jeremiah D Jordan  于2023年3月16日周四 23:14写道:

> -1 on any change which breaks the previously documented usage.
> +1 any additions to what the tool can do without breaking previously
> documented behavior.
>
> On Mar 16, 2023, at 7:42 AM, Josh McKenzie  wrote:
>
> We could also consider augmenting the tool with new named arguments with
> the functionality you described and leave the positional usage intact.
>
> On Thu, Mar 16, 2023, at 6:43 AM, Bowen Song via dev wrote:
>
> The documented command options are:
>
> nodetool tablehistograms [  | ]
>
>
>
> That means one parameter will be treated as dot separated keyspace and
> table. Alternatively, two parameters will be treated as the keyspace and
> table respectively.
>
> To remain compatible with the documented behaviour, my suggestion is to
> change the command options to:
>
> nodetool tablehistograms [  [ [...]] |
>  [ [...]]]
>
> Feel free to add the "all except ..." feature to the above.
>
> This doesn't break backward compatibility in documented ways. It only
> changes the undocumented behaviour. If someone is using the undocumented
> behaviour, they must know things may break when the software is upgraded.
> We can just add a line to the NEWS.txt and let them update their scripts.
>
>
> On 16/03/2023 08:53, guo Maxwell wrote:
>
> Hello everyone :
> The nodetool tablehistograms have one argument which you can fill with
> only one table name with the format "keyspace_name.table_name
> /keyspace_name table_name", so that you can get the table histograms of the
> specied table.
>
> And  if none arguments is set, all the tables' histograms will be print
> out.And if more than 2 arguments (nomatter the format is right or wrong) are
> set , all the tables' histograms will also be print out too(Which is a bug
> In my mind).
>
> So the usage of nodetool tablehistograms has some usage restrictions, That
> is either output one , or all informations.
>
> As CASSANDRA-18296  
> described
> , I will change the usage of nodetool tablehistograms, which support the
> feature below:
> 1. nodetool tablehistograms ks.tb1 ks.tb2  //print out list of tables'
> histograms with format keyspace.table
> 2.nodetool tablehistograms ks1 ks2 ks3 ... //print out list of keyspaces
> histograms
> 3.nodetool tablehistograms -i ks1 ks2  //print out list of table
> histograms except for the keyspaces list behind the option -i
> 4.nodetool tablehistograns -i ks ks.tb // print out list tables'
> histograms except for table in keyspace ks and ks.tb table.
> 5.none option specified ,then all tables histograms will be print out.
>
> The usage will breaks compatibility with how it was done previously, and
> as this is a user facing tool.
>
> So, What do you think?
>
> Thanks~~~
>
>
>

-- 
you are the apple of my eye !


Re: Please grant Wiki access for CEP

2023-03-21 Thread C. Scott Andreas

Done, thanks Doug!On Mar 21, 2023, at 2:22 PM, Doug Rohrer  
wrote:Hi folks:I’d like to post a CEP, but given it’s the first time I’m trying to 
contribute to the wiki, I don’t have access.If someone with access could please grant 
user drohrer access to post, I’d greatly appreciate it.Thanks,Doug Rohrer

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-03-21 Thread Maxim Muzafarov
Hello everyone,

This a friendly reminder that some help is still needed with the review :-)
I have resolved all the conflicts that have arisen in the last month or two.

If you'd like to invest some time in code clarity, please take a look:
https://github.com/apache/cassandra/pull/2046/files

On Wed, 8 Feb 2023 at 19:48, Maxim Muzafarov  wrote:
>
> Hello everyone,
>
>
> We are trying to clean up the source code around the direct use of
> system properties and make this use more manageable and transparent.
> To achieve this, I have prepared a patch that moves all system
> property names to the CassandraRelevantProperties, which in turn makes
> some of the properties visible to a user through the
> SystemPropertiesTable virtual table.
>
> The patch has passed a few rounds of review, but we still need another
> pair of eyes to make sure we are not missing anything valuable.
> Please, take a look at the patch.
>
> You can find all the changes here:
> https://issues.apache.org/jira/browse/CASSANDRA-17797
>
>
> I'd also like to share the names of the properties that will appear in
> the SystemPropertiesTable, the appearance of which is related to the
> public API changes we agreed to discuss on the dev list.
>
>
> The public API changes
>
> Newly production system properties added:
>
> io.netty.eventLoopThreads
> io.netty.transport.estimateSizeOnSubmit
> java.security.auth.login.config
> javax.rmi.ssl.client.enabledCipherSuites
> javax.rmi.ssl.client.enabledProtocols
> ssl.enable
> log4j2.disable.jmx
> log4j2.shutdownHookEnabled
> logback.configurationFile
>
> Newly added and used for tests only:
>
> invalid-legacy-sstable-root
> legacy-sstable-root
> org.apache.cassandra.tools.UtilALLOW_TOOL_REINIT_FOR_TEST
> org.caffinitas.ohc.segmentCount
> suitename
> sun.stderr.encoding
> sun.stdout.encoding
> test.bbfailhelper.enabled
> write_survey


Please grant Wiki access for CEP

2023-03-21 Thread Doug Rohrer
Hi folks:

I’d like to post a CEP, but given it’s the first time I’m trying to contribute 
to the wiki, I don’t have access.

If someone with access could please grant user drohrer access to post, I’d 
greatly appreciate it.

Thanks,

Doug Rohrer

CASSANDRA-18343

2023-03-21 Thread Ekaterina Dimitrova
Hi everyone,

Heads up, I will be adding new -add-exports to jvm17-clients.options in
CASSANDRA-18343. It is needed in order to be able to run bin/nodetool sjk
hh with JDK 17. More details on the ticket if someone is interested

Best regards,
Ekaterina


Re: [DISCUSS] Lift MessagingService.minimum_version to 40 in trunk

2023-03-21 Thread Ariel Weisberg
Hi,

I am pretty strongly in favor just to keep the amount of code kept around for 
serialization/deserialization and caching serialized sizes for different 
versions under control.

5.0 will have changes necessitating using another version so it will be adding 
to the clutter.

Ariel

On Mon, Mar 13, 2023, at 9:05 AM, Mick Semb Wever wrote:
> If we do not recommend and do not test direct upgrades from 3.x to
> 5.x, we have the opportunity to clean up a fair chunk of code by
> making `MessagingService.minimum_version=40`
>
> As Cassandra versions 4.x and  5.0 are all on
> `MessagingService.current_version=40` this would mean lifting
> MessagingService.minimum_version would make it equal to the
> current_version.
>
> Today already we don't allow mixed-version streaming.  The only
> argument I can see for keeping minimum_version=30 is for supporting
> non-streaming messages between 3.x and 5.0 nodes, which I can't find a
> basis for.
>
> An _example_ of the code that can be cleaned up is in the patch
> attached to the ticket:
> CASSANDRA-18314 – Lift MessagingService.minimum_version to 40
>
> What do you think?


[RELEASE] Apache Cassandra 4.1.1 released

2023-03-21 Thread Miklosovic, Stefan
The Cassandra team is pleased to announce the release of Apache Cassandra 
version 4.1.1.

Apache Cassandra is a fully distributed database. It is the right choice when 
you need scalability and high availability without compromising performance.

 http://cassandra.apache.org/

Downloads of source and binary distributions are listed in our download section:

 http://cassandra.apache.org/download/

This version is a bug fix release[1] on the 4.1 series. As always, please pay 
attention to the release notes[2] and Let us know[3] if you were to encounter 
any problem.

[WARNING] Debian and RedHat package repositories have moved! Debian 
/etc/apt/sources.list.d/cassandra.sources.list and RedHat 
/etc/yum.repos.d/cassandra.repo files must be updated to the new repository 
URLs. For Debian it is now https://debian.cassandra.apache.org . For RedHat it 
is now https://redhat.cassandra.apache.org/41x/ .

Enjoy!

[1]: CHANGES.txt 
https://gitbox.apache.org/repos/asf?p=cassandra.git;a=blob_plain;f=CHANGES.txt;hb=refs/tags/cassandra-4.1.1
[2]: NEWS.txt 
https://gitbox.apache.org/repos/asf?p=cassandra.git;a=blob_plain;f=NEWS.txt;hb=refs/tags/cassandra-4.1.1
[3]: https://issues.apache.org/jira/browse/CASSANDRA

Re: CASSANDRA-18247 committed

2023-03-21 Thread Aleksey Yeshchenko
Hurray!

Great work, thanks for making it happen.

—
AY

> On 20 Mar 2023, at 17:19, Ekaterina Dimitrova  wrote:
> 
> Hi everyone,
> 
> Happy Monday!
> 
> CASSANDRA-18247 was just committed. It adds testing CircleCI configuration 
> for JDK11+JDK17. Full description and how to use it can be found in 
> .circleci/readme.md.
> 
> Please let me know if you have any questions
> 
> Best regards,
> Ekaterina



Re: [EXTERNAL] Re: Cassandra CI Status 2023-01-07

2023-03-21 Thread guo Maxwell
Hi all :
Here comes Cassandra CI status for  2023-3-13 - 2023-23-179 :

*** CASSANDRA-18338 
 -  dtest.bootstrap_test.TestBootstrap.test_cleanup trunk
***  CASSANDRA-18338 
 - test:
org.apache.cassandra.distributed.test.ByteBuddyExamplesTest.countTest ,
this failed twice with jdk 8 and jdk 11, on trunk and  4.1
others are some timeout exception.


Mick Semb Wever  于2023年2月28日周二 05:37写道:

> New failures from Build Lead week 8
>
> *** CASSANDRA-18290 – SecondaryIndexTest.testUpdatesToMemtableData
> 4.1, row did not delete
>
> *** CASSANDRA-18289 –
>
> sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
> trunk, error not found in logs
>
> *** CASSANDRA-18287 –
> InsertUpdateIfConditionTest.testMultiExistConditionOnSameRowClustering
> trunk,
>
> *** CASSANDRA-18288 – TopPartitionsTest.basicRegularTombstonesTest
> trunk, missing tombstones
>
> ***CASSANDRA-18286 – TTLTest.testCapWarnExpirationOverflowPolicy
> negative deletion and expiry value
> 3.0, MarshalException: A local expiration time should not be negative
>
>
>
> On Tue, 21 Feb 2023 at 03:41, guo Maxwell  wrote:
> >
> > Hi all :
> > Here comes Cassandra CI status for  2023-2-13 - 2023-2-17 :
> >
> > *** CASSANDRA-18274 - Test
> Failures:org.apache.cassandra.utils.binlog.BinLogTest.testTruncationReleasesLogSpace-compression
> -linked in 4.1
> > Other tests below are time out exceptions, and we can ignore them as
> it's considered test-infrastructure failures. Which we are working on
> separately (CASSANDRA-18137), and I have already modify this notification
> in Build Lead page.
> > *** CASSANDRA-18273: Timeout occurred. Please note the time in the
> report does not reflect the time until the timeout. - linked in trunk, 4.0
> > *** CASSANDRA-11493:dtest failure in
> consistency_test.TestAccuracy.test_simple_strategy_users - it is timeout
> exception for CASSANDRA-11493 so I do not reopen it .
> >
> >
> >
> > German Eichberger via dev  于2023年2月14日周二
> 00:29写道:
> >>
> >> First, one of my learnings was that a ticket assigned to an issue in
> one branch of butler doesn't carry to another. So always search.
> >>
> >> New failures from build lead week 7:
> >>
> >> I created a Jira filter for finding the tickets I created:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20AND%20issuetype%20%3D%20Bug%20AND%20component%20in%20(%22Test%2Fdtest%2Fjava%22%2C%20%22Test%2Fdtest%2Fpython%22%2C%20%22Test%2Ffuzz%22%2C%20%22Test%2Funit%22)%20AND%20created%20%3E%3D%20-7d%20AND%20reporter%20in%20(xgerman42)
> >>
> >> *** CASSANDRA-18257 - Test Failures: 
> >> org.apache.cassandra.net.ProxyHandlerConnectionsTest.testExpireSome
> - linked in 4.0, 4.1, trunk
> >> *** CASSANDRA-18253 - Test Failures: dtest
> repair_tests.repair_test.TestRepair.test_simple_sequential_repair - linked
> in 4.0, trunk
> >> *** CASSANDRA-18246 - Test Failures:
> org.apache.cassandra.cql3.validation.operations.TTLTest.testCapNoWarnExpirationOverflowPolicy
> - linked in 3.11
> >> *** CASSANDRA-18245 - Test Failures:
> org.apache.cassandra.db.compaction.CompactionsTest.testDontPurgeAccidentally
> - linked in 3.11
> >> -
> >>
> >> 
> >> From: Dan Jatnieks 
> >> Sent: Friday, February 10, 2023 2:42 PM
> >> To: dev@cassandra.apache.org ; Claude
> Warren, Jr 
> >> Subject: [EXTERNAL] Re: Cassandra CI Status 2023-01-07
> >>
> >> You don't often get email from d...@datastax.com. Learn why this is
> important
> >> New Failures from Build Lead Week 6:
> >>
> >> *** CASSANDRA-18021 - Flaky
> org.apache.cassandra.distributed.test.ReprepareTestOldBehaviour#testReprepareMixedVersionWithoutReset
> >> - This existing ticket has been linked in butler to new failures on 3.11
> >>
> >> *** CASSANDRA-17608 - Fix testMetricsWithRebuildAndStreamingToTwoNodes
> >> - Re-opened as intermittent failure occurred in build 1445 on trunk
> >>
> >> Several new failures had only a single occurrence; no new tickets were
> opened during this time.
> >>
> >>
> >>
> >> On Fri, Feb 10, 2023 at 12:44 AM Claude Warren, Jr via dev <
> dev@cassandra.apache.org> wrote:
> >>
> >> New Failures from Build Lead Week 5
> >>
> >> *** CASSANDRA-18198 - "AttributeError: module 'py' has no attribute
> 'io'" reported in multiple tests
> >> - reported in 4.1, 3.11, and 3.0
> >> - identified as a possible class loader issue associated with
> CASSANDRA-18150
> >>
> >> *** CASSANDRA-18191 - Native Transport SSL tests failing
> >> - TestNativeTransportSSL.test_connect_to_ssl and
> TestNativeTransportSSL.test_connect_to_ssl (novnode)
> >> - TestNativeTransportSSL.test_connect_to_ssl_optional and
> TestNativeTransportSSL.test_connect_to_ssl_optional (nvnode)
> >>
> >>
> >> On Mon, Jan 23, 2023 at 10:10 PM Caleb Rackliffe <
> calebrackli...@gmail.com> wrote:
> >>
> >> New failures from Build Lead Week 4:
> >>
> >> *** CASSANDRA-18188 - Test failure in
> 

Re: [VOTE] Release Apache Cassandra 4.1.1

2023-03-21 Thread Miklosovic, Stefan
The vote has passed.


From: Tommy Stendahl via dev 
Sent: Monday, March 20, 2023 9:17
To: dev@cassandra.apache.org
Subject: Re: [VOTE] Release Apache Cassandra 4.1.1

NetApp Security WARNING: This is an external email. Do not click links or open 
attachments unless you recognize the sender and know the content is safe.



+1 (nb)

-Original Message-
From: Brandon Williams 
mailto:brandon%20williams%20%3cdri...@gmail.com%3e>>
Reply-To: dev@cassandra.apache.org
To: dev@cassandra.apache.org
Subject: Re: [VOTE] Release Apache Cassandra 4.1.1
Date: Fri, 17 Mar 2023 13:38:15 -0500


+1


Kind Regards,

Brandon


On Thu, Mar 16, 2023 at 3:11 AM Miklosovic, Stefan

<



stefan.mikloso...@netapp.com

> wrote:


Proposing the test build of Cassandra 4.1.1 for release.


sha1: 8d91b469afd3fcafef7ef85c10c8acc11703ba2d

Git:



https://gitbox.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/4.1.1-tentative


Maven Artifacts:



https://repository.apache.org/content/repositories/orgapachecassandra-1284/org/apache/cassandra/cassandra-all/4.1.1/



The Source and Build Artifacts, and the Debian and RPM packages and 
repositories, are available here:



https://dist.apache.org/repos/dist/dev/cassandra/4.1.1/



The vote will be open for 72 hours (longer if needed). Everyone who has tested 
the build is invited to vote. Votes by PMC members are considered binding. A 
vote passes if there are at least three binding +1s and no -1's.


[1]: CHANGES.txt:



https://gitbox.apache.org/repos/asf?p=cassandra.git;a=blob_plain;f=CHANGES.txt;hb=refs/tags/4.1.1-tentative


[2]: NEWS.txt:



https://gitbox.apache.org/repos/asf?p=cassandra.git;a=blob_plain;f=NEWS.txt;hb=refs/tags/4.1.1-tentative