Re: [DISCUSSION] Dependency management in our first alpha release

2023-08-23 Thread Abe Ratnofsky
> I also want to hear if Abe still has concerns about not following deprecation 
> process here.

I support removing the library on an expedited schedule, rather than waiting 
for a full major of deprecation. We still have a large surface for metrics 
integrations, and users who depended on metrics-reporter-config will have a 
path forward if they need similar functionality.

> On Aug 23, 2023, at 07:28, Ekaterina Dimitrova  wrote:
> 
> I also want to hear if Abe still has concerns about not following deprecation 
> process here. 


Re: [DISCUSSION] Dependency management in our first alpha release

2023-08-23 Thread Maxim Muzafarov
Hello everyone,


CASSANDRA-14667 when the 3.11.5 driver version with shaded metrics
dependencies is released, it will be fairly easy to handle the
cassandra-related part and get rid of the old metrics version in
Cassandra itself (the number of changes to the Cassandra part is also
minimal ~10 lines of changes overall). Although I can't do anything to
speed up the driver release process (can I?) I have tested everything
locally and all the dtests that failed when I upgraded the metrics
version started passing locally afterwards. The changes for the driver
are fairly straightforward and simple [1], the main question is how
much effort is needed to prepare and deploy a new driver version which
I'm not aware of. According to the latest discussion in the
corresponding jira ticket we are in a good shape now, but if we still
have a lack of volunteers for this just give me the permissions and a
link to the release documentation and I'll prepare everything we need
to move it forward :-)

Do we need a separate issue for 'org.caffinitas.ohc:ohc-core-j8' or we
should handle everything under [2]?


[1] https://github.com/datastax/java-driver/pull/1685/files
[2] https://issues.apache.org/jira/browse/CASSANDRA-18777

On Wed, 23 Aug 2023 at 16:51, C. Scott Andreas  wrote:
>
> Given how early we are in the cycle with even the branch only recently cut 
> (and how much is not yet present in the alpha), housecleaning seems like a 
> positive impulse.
>
> On Aug 23, 2023, at 7:28 AM, Ekaterina Dimitrova  
> wrote:
>
>
> Hi everyone,
>
> I wanted to clarify something. I understood dependency updates/cleaning can 
> also be done in an alpha release if they lead to minimal user-facing changes, 
> if any at all. I agree with that in our first 5.0 alpha release because we 
> are not yet feature-complete. It is a good time for people to do a bit of 
> housekeeping and tighten some loose ends.
> Do you think this is a valid statement? Thoughts?
> I wanted to clear this topic as we have a few in-flight tickets/discussions:
>
> - CASSANDRA-14667 - upgrade dropwizard metrics, for which to be accommodated, 
> Bret is creating a new 3.11.4 drivers version. So we should update the 
> driver. I am unsure how much effort and change it will be on our side to 
> update the drivers though. Maxim, did you try it? Any thoughts?
>
>
> - CASSANDRA-18789 - commons-lang3, a pretty non-controversial bump with two 
> versions. The one we are on is tested to Java 11, and the newest one tests up 
> to JDK17 and beyond. This is enough reason for me honestly to update it.
>
>
>
> - In [1], Maxim mentioned that we can clean org.caffinitas.ohc:ohc-core-j8.
>
>
> - In [2], Stefan and Mick made a point that we could even remove in 5.0 
> metrics-reporter-config(CASSANDRA-18743) and commons-codec(CASSANDRA-18772)
>  I think this should be a good idea - let's make some noise in the user group 
> to ensure people are aware and no one raises any significant concerns and 
> then clean those two. I also want to hear if Abe still has concerns about not 
> following deprecation process here.
>
> And if we decide, we can find a few more loose ends to deal with. I am sure.
>
> Looking forward to your feedback and thoughts.
>
> Best regards,
> Ekaterina
>
>
>
> [1] https://lists.apache.org/thread/9m1vz5qyows97wlppkwk1fd8386rj9q1
> [2] https://lists.apache.org/thread/9m1vz5qyows97wlppkwk1fd8386rj9q1
>
>


Re: [DISCUSSION] Dependency management in our first alpha release

2023-08-23 Thread C. Scott Andreas

Given how early we are in the cycle with even the branch only recently cut (and how 
much is not yet present in the alpha), housecleaning seems like a positive impulse.On 
Aug 23, 2023, at 7:28 AM, Ekaterina Dimitrova  wrote:Hi 
everyone,I wanted to clarify something. I understood dependency updates/cleaning can 
also be done in an alpha release if they lead to minimal user-facing changes, if any 
at all. I agree with that in our first 5.0 alpha release because we are not yet 
feature-complete. It is a good time for people to do a bit of housekeeping and 
tighten some loose ends. Do you think this is a valid statement? Thoughts?I wanted to 
clear this topic as we have a few in-flight tickets/discussions:- CASSANDRA-14667 - 
upgrade dropwizard metrics, for which to be accommodated, Bret is creating a new 
3.11.4 drivers version. So we should update the driver. I am unsure how much effort 
and change it will be on our side to update the drivers though. Maxim, did you try 
it? Any thoughts?- CASSANDRA-18789 - commons-lang3, a pretty non-controversial bump 
with two versions. The one we are on is tested to Java 11, and the newest one tests 
up to JDK17 and beyond. This is enough reason for me honestly to update it.- In [1], 
Maxim mentioned that we can clean org.caffinitas.ohc:ohc-core-j8.- In [2], Stefan and 
Mick made a point that we could even remove in 5.0 
metrics-reporter-config(CASSANDRA-18743) and commons-codec(CASSANDRA-18772) I think 
this should be a good idea - let's make some noise in the user group to ensure people 
are aware and no one raises any significant concerns and then clean those two. I also 
want to hear if Abe still has concerns about not following deprecation process here. 
And if we decide, we can find a few more loose ends to deal with. I am sure.Looking 
forward to your feedback and thoughts.Best regards,Ekaterina[1] 
https://lists.apache.org/thread/9m1vz5qyows97wlppkwk1fd8386rj9q1[2] 
https://lists.apache.org/thread/9m1vz5qyows97wlppkwk1fd8386rj9q1

[DISCUSSION] Dependency management in our first alpha release

2023-08-23 Thread Ekaterina Dimitrova
Hi everyone,

I wanted to clarify something. I understood dependency updates/cleaning can
also be done in an alpha release if they lead to minimal user-facing
changes, if any at all. I agree with that in our first 5.0 alpha release
because we are not yet feature-complete. It is a good time for people to do
a bit of housekeeping and tighten some loose ends.
Do you think this is a valid statement? Thoughts?
I wanted to clear this topic as we have a few in-flight tickets/discussions:

   1. - CASSANDRA-14667
    - upgrade
   dropwizard metrics, for which to be accommodated, Bret is creating a new
   3.11.4 drivers version. So we should update the driver. I am unsure how
   much effort and change it will be on our side to update the drivers though.
   Maxim, did you try it? Any thoughts?
   2.
  1.
 1. - CASSANDRA-18789
  -
 commons-lang3, a pretty non-controversial bump with two
versions. The one
 we are on is tested to Java 11, and the newest one tests up
to JDK17 and
 beyond. This is enough reason for me honestly to update it.
 2.
1.
3.
  2. - In [1], Maxim mentioned that we can clean
  org.caffinitas.ohc:ohc-core-j8.


- In [2], Stefan and Mick made a point that we could even remove in 5.0
metrics-reporter-config(CASSANDRA-18743) and commons-codec(CASSANDRA-18772)
 I think this should be a good idea - let's make some noise in the user
group to ensure people are aware and no one raises any significant concerns
and then clean those two. I also want to hear if Abe still has concerns
about not following deprecation process here.

And if we decide, we can find a few more loose ends to deal with. I am sure.

Looking forward to your feedback and thoughts.

Best regards,
Ekaterina

   1.


[1] https://lists.apache.org/thread/9m1vz5qyows97wlppkwk1fd8386rj9q1
[2] https://lists.apache.org/thread/9m1vz5qyows97wlppkwk1fd8386rj9q1