[jira] [Commented] (CLEREZZA-1028) Unlock the lock along all execution paths of it.
[ https://issues.apache.org/jira/browse/CLEREZZA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706881#comment-16706881 ] Furkan KAMACI commented on CLEREZZA-1028: - Yes, we may leave it as it is: https://stackoverflow.com/questions/10868423/lock-lock-before-try > Unlock the lock along all execution paths of it. > - > > Key: CLEREZZA-1028 > URL: https://issues.apache.org/jira/browse/CLEREZZA-1028 > Project: Clerezza > Issue Type: Bug > Components: platform >Reporter: Furkan KAMACI >Priority: Major > Fix For: 8 > > > We should unlock the locks at all cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLEREZZA-1028) Unlock the lock along all execution paths of it.
[ https://issues.apache.org/jira/browse/CLEREZZA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706687#comment-16706687 ] Hasan commented on CLEREZZA-1028: - [~kamaci], I think there is no need to place the lock acquirement within the try-catch block ([https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/Lock.html).] But I might be wrong. Could you probably share your concern why this is needed? > Unlock the lock along all execution paths of it. > - > > Key: CLEREZZA-1028 > URL: https://issues.apache.org/jira/browse/CLEREZZA-1028 > Project: Clerezza > Issue Type: Bug > Components: platform >Reporter: Furkan KAMACI >Priority: Major > Fix For: 8 > > > We should unlock the locks at all cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLEREZZA-1028) Unlock the lock along all execution paths of it.
[ https://issues.apache.org/jira/browse/CLEREZZA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692781#comment-16692781 ] Furkan KAMACI commented on CLEREZZA-1028: - I've created a PR for this: https://github.com/apache/clerezza/pull/7 > Unlock the lock along all execution paths of it. > - > > Key: CLEREZZA-1028 > URL: https://issues.apache.org/jira/browse/CLEREZZA-1028 > Project: Clerezza > Issue Type: Bug > Components: platform >Reporter: Furkan KAMACI >Priority: Major > > We should unlock the locks at all cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
