[GitHub] climate pull request #434: CLIMATE-905 - Box whisker plot to evaluate simula...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/climate/pull/434


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request #434: CLIMATE-905 - Box whisker plot to evaluate simula...

[huikyole]

Github user huikyole commented on a diff in the pull request:

https://github.com/apache/climate/pull/434#discussion_r111779716
  
--- Diff: ocw/dataset_processor.py ---
@@ -391,8 +391,11 @@ def subset(target_dataset, subregion, 
subregion_name=None, extract=True, user_ma
 '''
 
 if not subregion.start:
-subregion.start = target_dataset.times[0]
-subregion.end = target_dataset.times[-1]
+time_start = target_dataset.times[0]
--- End diff --

Thanks, @agoodm . I defined time_start and time_end not to change the 
subregion object in case the object is used again for subsetting another OCW 
dataset. I will update the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request #434: CLIMATE-905 - Box whisker plot to evaluate simula...

[agoodm]

Github user agoodm commented on a diff in the pull request:

https://github.com/apache/climate/pull/434#discussion_r111778443
  
--- Diff: ocw/dataset_processor.py ---
@@ -391,8 +391,11 @@ def subset(target_dataset, subregion, 
subregion_name=None, extract=True, user_ma
 '''
 
 if not subregion.start:
-subregion.start = target_dataset.times[0]
-subregion.end = target_dataset.times[-1]
+time_start = target_dataset.times[0]
--- End diff --

The helper function `_are_bounds_contained_by_dataset)_` will now always 
throw an exception if the `start` and `end` attributes of the subregion 
instance are not defined. Was there any particular reason you made this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] climate pull request #434: CLIMATE-905 - Box whisker plot to evaluate simula...

[huikyole]

GitHub user huikyole opened a pull request:

https://github.com/apache/climate/pull/434

CLIMATE-905 - Box whisker plot to evaluate simulated trends

- example/temperature/trends_over_CONUS.py has been updated
- data_source.local.load_multiple_files has been updated to load the CMIP5 
files without file concatenation.
- dataset_processor has been updated.
- plotter has a new module (draw_plot_to_compare_trends) to generate a plot 
to compare observed trends with simulated ones.
- test_local.py has been updated to reflect the changes in
- utils.calculate_temporal_trend_of_time_series has been debugged.
- utils.calculate_ensemble_temporal_trends has been updated.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huikyole/climate CLIMATE-905

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/climate/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #434


commit 6f6cde83ed23e5d121244896c97638070e280a74
Author: huikyole 
Date:   2017-04-17T06:01:39Z

CLIMATE-905 - Box whisker plot to evaluate simulated trends

- example/temperature/trends_over_CONUS.py has been updated
- data_source.local.load_multiple_files has been updated to load the CMIP5 
files without file concatenation.
- dataset_processor has been updated.
- plotter has a new module (draw_plot_to_compare_trends) to generate a plot 
to compare observed trends with simulated ones.
- test_local.py has been updated to reflect the changes in
- utils.calculate_temporal_trend_of_time_series has been debugged.
- utils.calculate_ensemble_temporal_trends has been updated.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---