[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219645#comment-14219645 ] ASF GitHub Bot commented on CLIMATE-542: Github user MJJoyce commented on the pull request: https://github.com/apache/climate/pull/125#issuecomment-63847909 There were some problems with this that were corrected in #127. See the discussion on the [relevant ticket](https://issues.apache.org/jira/browse/CLIMATE-542). Please close this PR. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200429#comment-14200429 ] ASF GitHub Bot commented on CLIMATE-542: Github user MJJoyce commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-62009511 :+1: other than the above comment. TY sir for all work. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200819#comment-14200819 ] ASF GitHub Bot commented on CLIMATE-542: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-62042462 Merged build started. Test Failed. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200817#comment-14200817 ] ASF GitHub Bot commented on CLIMATE-542: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-62042452 Merged build triggered. Test Failed. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200821#comment-14200821 ] ASF GitHub Bot commented on CLIMATE-542: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-62042700 Merged build finished. Test Passed. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200883#comment-14200883 ] ASF GitHub Bot commented on CLIMATE-542: Github user MJJoyce commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-62048543 :+1: Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200907#comment-14200907 ] ASF GitHub Bot commented on CLIMATE-542: Github user asfgit closed the pull request at: https://github.com/apache/climate/pull/127 Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[
https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198725#comment-14198725
]
Ross Laidlaw commented on CLIMATE-542:
--
Here's the original code from
https://github.com/apache/climate/blob/master/rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py#L393:
{code}
def calcTemporalCorrelation(evaluationData, referenceData):
'''
Purpose ::
Calculate the temporal correlation.
Assumption(s) ::
The first dimension of two datasets is the time axis.
Input ::
evaluationData - model data array of any shape
referenceData- observation data array of any shape
Output::
temporalCorelation - A 2-D array of temporal correlation coefficients
at each subregion
sigLev - A 2-D array of confidence levels related to temporalCorelation
REF: 277-281 in Stat methods in atmos sci by Wilks, 1995, Academic Press,
467pp.
sigLev: the correlation between model and observation is significant at
sigLev * 100 %
'''
evaluationDataMask = process.create_mask_using_threshold(evaluationData,
threshold = 0.75)
referenceDataMask = process.create_mask_using_threshold(referenceData,
threshold = 0.75)
nregion = evaluationData.shape[0]
temporalCorrelation = ma.zeros([nregion])-100.
sigLev = ma.zeros([nregion])-100.
for iregion in np.arange(nregion):
temporalCorrelation[iregion], sigLev[iregion] =
stats.pearsonr(evaluationData[iregion,:], referenceData[iregion,:])
sigLev[iregion] = 1 - sigLev[iregion]
temporalCorrelation=ma.masked_equal(temporalCorrelation.data, -100.)
sigLev=ma.masked_equal(sigLev.data, -100.)
return temporalCorrelation, sigLev
{code}
I think we can remove the following lines, as {{evaluationDataMask}} and
{{referenceDataMask}} aren't used in the method after they've been initialized:
{code}
evaluationDataMask = process.create_mask_using_threshold(evaluationData,
threshold = 0.75)
referenceDataMask = process.create_mask_using_threshold(referenceData,
threshold = 0.75)
{code}
Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
---
Key: CLIMATE-542
URL: https://issues.apache.org/jira/browse/CLIMATE-542
Project: Apache Open Climate Workbench
Issue Type: Sub-task
Components: metrics
Affects Versions: 0.4
Reporter: Ross Laidlaw
Assignee: Ross Laidlaw
Fix For: 0.5
Port the 'calcTemporalCorrelation' method from
rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198734#comment-14198734 ] Kim Whitehall commented on CLIMATE-542: --- Agreed Ross. That's in keeping with the discussions from the meeting. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Ross Laidlaw Fix For: 0.5 Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199541#comment-14199541 ] ASF GitHub Bot commented on CLIMATE-542: GitHub user rlaidlaw opened a pull request: https://github.com/apache/climate/pull/127 CLIMATE-542 - Add TemporalCorrelation metric and unit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/rlaidlaw/climate CLIMATE-542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/127.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #127 commit 16578ed8a42d6f5156c6803122c9434e9eb44632 Author: rlaidlaw rlaidlaw.o...@gmail.com Date: 2014-11-06T01:16:40Z CLIMATE-542: Add TemporalCorrelation metric and unit tests Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199581#comment-14199581 ] ASF GitHub Bot commented on CLIMATE-542: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-61914552 Merged build triggered. Test Failed. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199587#comment-14199587 ] ASF GitHub Bot commented on CLIMATE-542: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-61914630 Merged build finished. Test Passed. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199604#comment-14199604 ] ASF GitHub Bot commented on CLIMATE-542: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-61915224 Merged build triggered. Test Failed. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLIMATE-542) Port 'calcTemporalCorrelation' method over to ocw/metrics.py module
[ https://issues.apache.org/jira/browse/CLIMATE-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199606#comment-14199606 ] ASF GitHub Bot commented on CLIMATE-542: Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/127#issuecomment-61915294 Merged build finished. Test Passed. Port 'calcTemporalCorrelation' method over to ocw/metrics.py module --- Key: CLIMATE-542 URL: https://issues.apache.org/jira/browse/CLIMATE-542 Project: Apache Open Climate Workbench Issue Type: Sub-task Components: metrics Affects Versions: 0.4 Reporter: Ross Laidlaw Assignee: Huikyo Lee Fix For: 0.5 Attachments: metrics.py Port the 'calcTemporalCorrelation' method from rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py to ocw/metrics.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
