Re: [QUESTION] How come we don't include Users@ in vote threads?
On Sun, Nov 16, 2014 at 11:44 PM, Pierre-Luc Dion pdion...@apache.org wrote: I agree that more tests are welcome, we have to try then :) Afaik non-pmc's aren't binding and any votes would merely be an indication, or do i misunderstand? All votes are important [1] and count as indicator, who ever vote mean something, It also show that the community members did some tests or review of some kind. And whoever doing a -1 with valid justification will be listen. It would be much more interesting to see an RC with 15 non binding votes than the 3 minimum binding. [1] http://www.apache.org/foundation/voting.html Just my 2 cents: Some Apache communities include users@ to get user feedback, and other's do not. IMO, what would be better is for us to engage the user community to help test the release prior to adding the voting overhead. The act of voting should (hopefully) not be that big of a deal. I'd much rather find ways to recruit users to become testers earlier on in the cycle. If you look at our last several releases, QA / quality has been lacking during the release process. It's often been active users that start testing only when they see the vote thread. The question I'd pose is: how do we figure out how to pull these individuals into the cycle earlier. -chip
[ACS44] release 4.4.2 imminent
People, I want to make a new 4.4 release after not delivering the quality I would like for 4.4.0 and 4.4.1. I want to call on all to test the head of the 44 branch before I do. Both two prior releases have known issues within one week after release. In my opinion it would be great if we can prevent the next release from having such issues, so once again please test to your best at 4.4 and report to me (in this thread for instance). I addition to that I would like to have a test and evaluation session here @apachecon about the 4.4.2 to asses it's quality. Any of you around Budapest are welcome to join in. Wednesday is the plan. kind regards, -- Daan
Re: did anyone try 4.4.2?
That one is fixed (i hope) On Mon, Nov 17, 2014 at 3:52 AM, Pierre-Luc Dion pdion...@apache.org wrote: I'm trying to build 4.4.2 from 4.4 branch. I'm having the db deployment error that schema-441to442.sql does not exist. Could it be the cause of the problem you are seeing too ? On Fri, Nov 14, 2014 at 8:57 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: I run into a strange exception during the spring load phase. Did anybody run 442 yet? -- Daan -- Daan
Re: [ACS44] release 4.4.2 imminent
Cheers, will do. Till when do we have to do this? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Daan Hoogland daan.hoogl...@gmail.com To: dev dev@cloudstack.apache.org, us...@cloudstack.apache.org Sent: Monday, 17 November, 2014 08:56:22 Subject: [ACS44] release 4.4.2 imminent People, I want to make a new 4.4 release after not delivering the quality I would like for 4.4.0 and 4.4.1. I want to call on all to test the head of the 44 branch before I do. Both two prior releases have known issues within one week after release. In my opinion it would be great if we can prevent the next release from having such issues, so once again please test to your best at 4.4 and report to me (in this thread for instance). I addition to that I would like to have a test and evaluation session here @apachecon about the 4.4.2 to asses it's quality. Any of you around Budapest are welcome to join in. Wednesday is the plan. kind regards, -- Daan
Re: [ACS44] release 4.4.2 imminent
Hi Dan, would you mind provide 4.4.2 RPMs somewhere so we can test the upgrade from 4.4.1 ? best On 17 November 2014 09:56, Daan Hoogland daan.hoogl...@gmail.com wrote: People, I want to make a new 4.4 release after not delivering the quality I would like for 4.4.0 and 4.4.1. I want to call on all to test the head of the 44 branch before I do. Both two prior releases have known issues within one week after release. In my opinion it would be great if we can prevent the next release from having such issues, so once again please test to your best at 4.4 and report to me (in this thread for instance). I addition to that I would like to have a test and evaluation session here @apachecon about the 4.4.2 to asses it's quality. Any of you around Budapest are welcome to join in. Wednesday is the plan. kind regards, -- Daan -- Andrija Panić -- http://admintweets.com --
Re: [ACS44] release 4.4.2 imminent
On Mon, Nov 17, 2014 at 9:56 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: People, I want to make a new 4.4 release after not delivering the quality I would like for 4.4.0 and 4.4.1. I want to call on all to test the head of the 44 branch before I do. Both two prior releases have known issues within one week after release. In my opinion it would be great if we can prevent the next release from having such issues, so once again please test to your best at 4.4 and report to me (in this thread for instance). I addition to that I would like to have a test and evaluation session here @apachecon about the 4.4.2 to asses it's quality. Any of you around Budapest are welcome to join in. Wednesday is the plan. Any idea when on Wednesday it might be? Won't arrive before 14ish. -- Erik
Re: Review Request 28032: CLOUDSTACK-7913 - Added reconnect functionality to Host class in base.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28032/#review61706 --- Ship it! 19781e094b987cf65d05d890cd3cd86fc22cb873 4.5 and master - SrikanteswaraRao Talluri On Nov. 14, 2014, 3:14 p.m., Chandan Purushothama wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28032/ --- (Updated Nov. 14, 2014, 3:14 p.m.) Review request for cloudstack, sangeetha hariharan and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7913 https://issues.apache.org/jira/browse/CLOUDSTACK-7913 Repository: cloudstack-git Description --- Reconnect method in Host Class can be used to reconnect a host in CloudStack Setup. Diffs - tools/marvin/marvin/lib/base.py 580d0ab Diff: https://reviews.apache.org/r/28032/diff/ Testing --- Test enable Maintenance Mode on Hosts which have VPC elements ... === TestName: test_01_enable_maintenance_with_vpc_nw | Status : SUCCESS === ok Test cancel Maintenance Mode on the above Hosts + Migrate VMs Back ... === TestName: test_02_cancel_maintenance | Status : SUCCESS === ok Test reconnect Host which has VPC elements ... === TestName: test_03_reconnect_host | Status : SUCCESS === ok -- Ran 3 tests in 463.515s Thanks, Chandan Purushothama
[GitHub] cloudstack pull request: CLOUDSTACK-7620: Added SNMP MIB file for ...
Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/31#issuecomment-63280334 Merging the commit to master as it had passed CI build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Review Request 28039: CLOUDSTACK-7912: Remove hardcoded netscaler info and read it from config file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28039/#review61707
---
Ship it!
5f99917991a59f8ecd6d8b0e17b497fe210e636e 4.5 and master
- SrikanteswaraRao Talluri
On Nov. 14, 2014, 2:34 p.m., Gaurav Aradhye wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28039/
---
(Updated Nov. 14, 2014, 2:34 p.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-7912
https://issues.apache.org/jira/browse/CLOUDSTACK-7912
Repository: cloudstack-git
Description
---
In many test cases, netscaler info is hard coded into test cases. Also they
are read from different sources, such as hardcoded config in test case and
test_data.py file.
Ideally this information should be present in config file so that the marvin
code doesn't have to be changed while running test cases. We just should have
to make changes in config file.
Additional changes:
1. Pep8 fixes
2. Import fixes
Important note:
Following strucutre should be present in config file. If not present, the
test cases will be skipped.
netscalerDevice: {
ipaddress: x.x.x.x,
username: ,
password: ,
networkdevicetype: ,
publicinterface: 1/1,
privateinterface: 1/1,
numretries: 2,
lbdevicededicated: False, #(Or True)
lbdevicecapacity: 2,
port: 22
}
Values should be set according to netscaler device available.
Diffs
-
test/integration/component/test_lb_secondary_ip.py daffe34
test/integration/component/test_netscaler_lb.py 4c99aa3
test/integration/component/test_netscaler_lb_algo.py 6eda9a3
test/integration/component/test_netscaler_lb_sticky.py c333f60
test/integration/component/test_persistent_networks.py 4cd0aa8
tools/marvin/marvin/lib/common.py 9e3d40c
Diff: https://reviews.apache.org/r/28039/diff/
Testing
---
Yes.
Ran few test cases and result is as following:
Test Create a SourceBased stick policy for a Lb rule with ... === TestName:
test_01_source_based_roundrobin | Status : SUCCESS ===
ok
Test Create a SourceBased stick policy for a Lb rule ... === TestName:
test_02_source_based_source_algo | Status : SUCCESS ===
ok
Test Create a SourceBased stick policy for a Lb rule with leastconn algo
... === TestName: test_03_source_based_leastconn | Status : SUCCESS ===
ok
Test Create a LBCookie stick policy for a Lb rule with roundrobin algo ...
=== TestName: test_04_lbcookie_based_roundrobin | Status : SUCCESS ===
ok
Test Create a LBCookie stick policy for a Lb rule with Source algorithm
... === TestName: test_05_lbcookie_source_algo | Status : SUCCESS ===
ok
Test Create a LBCookie stick policy for a Lb rule with leastconn algo ...
=== TestName: test_06_lbcookie_leastconn | Status : SUCCESS ===
ok
Test Create a AppCookie stick policy for a Lb rule with roundrobin algo ...
=== TestName: test_07_appcookie_based_roundrobin | Status : SUCCESS ===
ok
Test Create a AppCookie stick policy for a Lb rule with Source ... ===
TestName: test_08_appcookie_source_algo | Status : SUCCESS ===
ok
Test Create a AppCookie stick policy for a Lb rule with leastconn ... ===
TestName: test_09_appcookie_leastconn | Status : SUCCESS ===
ok
--
Ran 9 tests in 540.990s
OK
Test edit LB rule from least conn to round robin algo ... === TestName:
test_lb_least_conn_to_round_robin | Status : SUCCESS ===
ok
=== TestName: test_lb_least_conn_to_round_robin | Status : EXCEPTION ===
ERROR
Test edit LB rule from round robin to source algo ... === TestName:
test_lb_leastconn_to_source | Status : SUCCESS ===
ok
Test edit LB rule from round robin to least connection algo ... === TestName:
test_lb_round_robin_to_least_conn | Status : SUCCESS ===
ok
Test edit LB rule from round robin to source algo ... === TestName:
test_lb_round_robin_to_source | Status : SUCCESS ===
ok
Test edit LB rule from source to least conn algo ... === TestName:
test_lb_source_to_least_conn | Status : SUCCESS ===
ok
Test edit LB rule from source to round robin algo ... === TestName:
test_lb_source_to_round_robin | Status : SUCCESS ===
ok
Test Create LB rule with least connection algorithm ... === TestName:
test_lb_with_least_conn | Status : SUCCESS ===
ok
Test Create LB rule with round robin algorithm ... === TestName:
test_lb_with_round_robin | Status : SUCCESS ===
ok
Test Add multiple Vms to an existing LB rule. ... === TestName:
test_add_multiple_vms_lb | Status : SUCCESS ===
ok
Test create LB rule with same public port after deleting rule ... ===
TestName:
[GitHub] cloudstack pull request: CLOUDSTACK-7703, CLOUDSTACK-7752: Fixed d...
Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/30#issuecomment-63281107 merging this patch to Master as it had passed CI as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Jenkins build is back to normal : build-4.5 #139
See http://jenkins.buildacloud.org/job/build-4.5/139/changes
Re: [ACS44] release 4.4.2 imminent
So we will have to wait for you with starting;) On Mon, Nov 17, 2014 at 10:38 AM, Erik Weber terbol...@gmail.com wrote: On Mon, Nov 17, 2014 at 9:56 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: People, I want to make a new 4.4 release after not delivering the quality I would like for 4.4.0 and 4.4.1. I want to call on all to test the head of the 44 branch before I do. Both two prior releases have known issues within one week after release. In my opinion it would be great if we can prevent the next release from having such issues, so once again please test to your best at 4.4 and report to me (in this thread for instance). I addition to that I would like to have a test and evaluation session here @apachecon about the 4.4.2 to asses it's quality. Any of you around Budapest are welcome to join in. Wednesday is the plan. Any idea when on Wednesday it might be? Won't arrive before 14ish. -- Erik -- Daan
Re: [ACS44] release 4.4.2 imminent
I think, till we o longer find bugs that bug us. Not sure, but as far as I know there is no bug in it now. I just don't want to go into a 72 hour vote period now untill I get some support for the release. On Mon, Nov 17, 2014 at 10:01 AM, Nux! n...@li.nux.ro wrote: Cheers, will do. Till when do we have to do this? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Daan Hoogland daan.hoogl...@gmail.com To: dev dev@cloudstack.apache.org, us...@cloudstack.apache.org Sent: Monday, 17 November, 2014 08:56:22 Subject: [ACS44] release 4.4.2 imminent People, I want to make a new 4.4 release after not delivering the quality I would like for 4.4.0 and 4.4.1. I want to call on all to test the head of the 44 branch before I do. Both two prior releases have known issues within one week after release. In my opinion it would be great if we can prevent the next release from having such issues, so once again please test to your best at 4.4 and report to me (in this thread for instance). I addition to that I would like to have a test and evaluation session here @apachecon about the 4.4.2 to asses it's quality. Any of you around Budapest are welcome to join in. Wednesday is the plan. kind regards, -- Daan -- Daan
[GitHub] cloudstack pull request: CLOUDSTACK-7620: Added SNMP MIB file for ...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7620: Added SNMP MIB file for ...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/31#issuecomment-63287776 closing pull request as this got merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7703, CLOUDSTACK-7752: Fixed d...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7703, CLOUDSTACK-7752: Fixed d...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/30#issuecomment-63287919 closing this PR as patch got committed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7758: Fixed although api calls...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7541: Added restriction to not...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Jenkins build is back to stable : simulator-singlerun #640
See http://jenkins.buildacloud.org/job/simulator-singlerun/640/changes
Re: Show volumes - showing another VM's volume
Created improvement ticket - to consider implementing Volume purging, just like with VMs...so they are not deleted immediatey - so there is time to recover the volume... https://issues.apache.org/jira/browse/CLOUDSTACK-7926 On 12 November 2014 14:48, Logan Barfield lbarfi...@tqhosting.com wrote: I've noticed this happen several times as well. Usually when it does I'll notice the same volume come up no matter what instance I'm looking at, and like you mentioned the only fix is a full page refresh. Thank You, Logan Barfield Tranquil Hosting On Wed, Nov 12, 2014 at 4:53 AM, Andrija Panic andrija.pa...@gmail.com wrote: Hi guys, I have just run into (GUI) bug in CS 4.4.1: Clicked on freshly deployed instance, clicked on Show Volumes, detached volume and deleted it - later I realized that the volume belonged some other VM. Confirmed again, by clicking on this same new VM, clicking on show volumes, and when I click on the volume that's still attached - it says this volume belogns to another already running VM. So basicaly, I lost my volume/data because of this bug... When I reloaded GUI by refreshing the URL in browser address bar, only after that, correct volumes were show. I don't know how to reproduce this problem, but I lost my data... -- Andrija Panić -- http://admintweets.com -- -- Andrija Panić -- http://admintweets.com --
Re: [TEST] DevCloud4 - rework / Cleanup
Hi Ian, I'm trying to run the binary-advanced, in the Public IPs of the zone the gateway is 192.168.23.5, should my box have the IP 192.168.23.5 instead of the current 192.168.23.1 ? thanks, On Sun, Nov 16, 2014 at 2:57 PM, Ian Duffy i...@ianduffy.ie wrote: Hi Pierre, So advanced and basic are running from code on the host machine. Only a NFS, MySQL and hypervisor box is supplied. Testing is for binary-installation-advanced and binary-installation-basic. On 16 November 2014 19:44, Pierre-Luc Dion pd...@cloudops.com wrote: Hi Ian, I'm trying it as it seams quite strait forward. although, the instruction to install cloudstack [1]: I should run that in the management VM right, not locally ? does IPs are hardcoded somewhere? Thanks, that's awesome to have a local cloudstack running without effort. I'm testing this on OSX and so far the installation process is easy and well documented (still few things missing :-P )! [1] https://github.com/imduffy15/devcloud4/tree/master/advanced#start-cloudstack *Pierre-Luc DION* Architecte de Solution Cloud | Cloud Solutions Architect t 855.652.5683 *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Sun, Nov 16, 2014 at 11:18 AM, Ian Duffy i...@ianduffy.ie wrote: TL;DR: Devcloud 4 cleaned up a bit, chef attributes no longer hidden, further user customisation allowed, Testers wanted. ** advanced zone on 4.4.* isn't supported due to a change on some API param for setting tags on interfaces ** Hi All, https://github.com/imduffy15/devcloud4/tree/dev/binary-installation-basic I've pushed some clean up work for binary-installation versions DevCloud4. I've moved a few things about so chef attributes are no longer completely black boxed and are more exposed to the user so they are aware they can change system vm locations, rpm locations, etc. Along with this I've moved to using berkshelf for pulling in the chef cookbooks. Sadly this adds a dependency on ChefDK but it works better for cookbook updates. I've also upped the amount of RAM given to XenServer and the System VMs. (6gb for XenServer and 256 for ssvm cpvm rvm)... I would suggest running on a system with 16gb of ram. I may lower this down in the future but I felt their was some performance issues in allocating only 100mb of ram to the system vms. URLs to resources should now be more stable. I'm no longer hosting a marvin binary, its pulled in from pypi. All default URLs for RPMs and SystemVM images are pointing to shapeblues repo :). The chef cookbook powering it all is a modification from the one created by the folks over at CloudOps. If anybody is interested in testing I'd love to hear some feedback: ** Note should work on osx, linux and windows (in theory, windows remains untested)** ** you need chefdk installed on your machine along with vagrant-berkshelf ** ** you need virtualbox interfaces vboxnet0 vboxnet1 vboxnet2 with ips 192.168.22.1, 192.168.23.1 and 192.168.24.1 respectively along with disabling the DHCP Server ** git clone https://github.com/imduffy15/devcloud4.git git checkout -b dev origin/dev cd binary-installation-basic or binary-installation-advanced vagrant up Thanks, Ian
Re: [ACS44] release 4.4.2 imminent
Trying devcloud4 with 4.4 branch and I'm having this issue: [WARNING] java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:297) at java.lang.Thread.run(Thread.java:745) Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade the database at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:336) at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:431) at com.cloud.upgrade.DatabaseCreator.main(DatabaseCreator.java:217) ... 6 more Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to find db/schema-441to442.sql at com.cloud.upgrade.dao.Upgrade441to442.getPrepareScripts(Upgrade441to442.java:50) at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:303) ... 8 more I don't see the schema-441to442.sql files in the db folder too. does 442 is on a different branch? On Mon, Nov 17, 2014 at 5:20 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: So we will have to wait for you with starting;) On Mon, Nov 17, 2014 at 10:38 AM, Erik Weber terbol...@gmail.com wrote: On Mon, Nov 17, 2014 at 9:56 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: People, I want to make a new 4.4 release after not delivering the quality I would like for 4.4.0 and 4.4.1. I want to call on all to test the head of the 44 branch before I do. Both two prior releases have known issues within one week after release. In my opinion it would be great if we can prevent the next release from having such issues, so once again please test to your best at 4.4 and report to me (in this thread for instance). I addition to that I would like to have a test and evaluation session here @apachecon about the 4.4.2 to asses it's quality. Any of you around Budapest are welcome to join in. Wednesday is the plan. Any idea when on Wednesday it might be? Won't arrive before 14ish. -- Erik -- Daan
Jenkins build became unstable: simulator-singlerun #641
See http://jenkins.buildacloud.org/job/simulator-singlerun/641/changes
Re: [ACS44] release 4.4.2 imminent
On Mon, Nov 17, 2014 at 2:12 PM, Pierre-Luc Dion pdion...@apache.org wrote: Trying devcloud4 with 4.4 branch and I'm having this issue: I don't see the schema-441to442.sql files in the db folder too. does 442 is on a different branch? no, I added the file locallly and forgot to commit. it is pushed now, sorry -- Daan
New Defects reported by Coverity Scan for cloudstack
Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 11 new defect(s) introduced to cloudstack found with Coverity Scan. 18 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 11 of 11 defect(s) ** CID 1254843: Copy-paste error (COPY_PASTE_ERROR) /server/src/com/cloud/capacity/CapacityManagerImpl.java: 712 in com.cloud.capacity.CapacityManagerImpl.updateCapacityForHost(com.cloud.host.Host)() ** CID 1254842: Bx: Questionable Boxing of primitive value (FB.BX_UNBOXING_IMMEDIATELY_REBOXED) /server/src/com/cloud/network/NetworkServiceImpl.java: 1409 in com.cloud.network.NetworkServiceImpl.commitNetwork(java.lang.Long, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, com.cloud.user.Account, java.lang.Long, java.lang.Long, java.lang.Long, boolean, java.lang.Boolean, java.lang.Long, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Boolean, java.lang.Long, java.lang.String, com.cloud.offerings.NetworkOfferingVO, com.cloud.network.PhysicalNetwork, org.apache.cloudstack.acl.ControlledEntity$ACLType, com.cloud.user.Account, java.lang.String, boolean)() ** CID 1254841: DLS: Dead local store (FB.DLS_DEAD_LOCAL_STORE) /server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java: 2577 in com.cloud.network.router.VirtualNetworkApplianceManagerImpl.postStateTransitionEvent(com.cloud.utils.fsm.StateMachine2$Transition, com.cloud.vm.VirtualMachine, boolean, java.lang.Object)() ** CID 1254840: Dm: Dubious method used (FB.DM_DEFAULT_ENCODING) /plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java: 1054 in com.cloud.hypervisor.xenserver.resource.Xenserver625StorageProcessor.createTemplateFromSnapshot2(org.apache.cloudstack.storage.command.CopyCommand)() ** CID 1254839: Dm: Dubious method used (FB.DM_DEFAULT_ENCODING) /utils/src/org/apache/cloudstack/utils/graphite/GraphiteClient.java: 86 in org.apache.cloudstack.graphite.GraphiteClient.sendMetrics(java.util.Map, long)() ** CID 1254838: REC: RuntimeException capture (FB.REC_CATCH_EXCEPTION) /plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java: 1102 in com.cloud.hypervisor.xenserver.resource.Xenserver625StorageProcessor.createTemplateFromSnapshot2(org.apache.cloudstack.storage.command.CopyCommand)() ** CID 1254837: REC: RuntimeException capture (FB.REC_CATCH_EXCEPTION) /server/src/com/cloud/server/StatsCollector.java: 515 in com.cloud.server.StatsCollector$VmStatsCollector.runInContext()() ** CID 1254835: Dereference after null check (FORWARD_NULL) /server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java: 63 in com.cloud.alert.ConsoleProxyAlertAdapter.onProxyAlert(java.lang.Object, com.cloud.consoleproxy.ConsoleProxyAlertEventArgs)() /server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java: 69 in com.cloud.alert.ConsoleProxyAlertAdapter.onProxyAlert(java.lang.Object, com.cloud.consoleproxy.ConsoleProxyAlertEventArgs)() /server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java: 80 in com.cloud.alert.ConsoleProxyAlertAdapter.onProxyAlert(java.lang.Object, com.cloud.consoleproxy.ConsoleProxyAlertEventArgs)() /server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java: 91 in com.cloud.alert.ConsoleProxyAlertAdapter.onProxyAlert(java.lang.Object, com.cloud.consoleproxy.ConsoleProxyAlertEventArgs)() /server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java: 110 in com.cloud.alert.ConsoleProxyAlertAdapter.onProxyAlert(java.lang.Object, com.cloud.consoleproxy.ConsoleProxyAlertEventArgs)() /server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java: 121 in com.cloud.alert.ConsoleProxyAlertAdapter.onProxyAlert(java.lang.Object, com.cloud.consoleproxy.ConsoleProxyAlertEventArgs)() /server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java: 135 in com.cloud.alert.ConsoleProxyAlertAdapter.onProxyAlert(java.lang.Object, com.cloud.consoleproxy.ConsoleProxyAlertEventArgs)() ** CID 1254834: Dereference after null check (FORWARD_NULL) /server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java: 62 in com.cloud.alert.SecondaryStorageVmAlertAdapter.onSSVMAlert(java.lang.Object, com.cloud.storage.secondary.SecStorageVmAlertEventArgs)() /server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java: 68 in com.cloud.alert.SecondaryStorageVmAlertAdapter.onSSVMAlert(java.lang.Object, com.cloud.storage.secondary.SecStorageVmAlertEventArgs)() /server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java: 78 in com.cloud.alert.SecondaryStorageVmAlertAdapter.onSSVMAlert(java.lang.Object, com.cloud.storage.secondary.SecStorageVmAlertEventArgs)() /server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java: 92 in
Re: [TEST] DevCloud4 - rework / Cleanup
Hi Pierre, No that is correct. We cannot control the .1 interface which is on the host machine. We can however control .5 and get it to do forwarding On 17 Nov 2014 12:28, Pierre-Luc Dion pdion...@apache.org wrote: Hi Ian, I'm trying to run the binary-advanced, in the Public IPs of the zone the gateway is 192.168.23.5, should my box have the IP 192.168.23.5 instead of the current 192.168.23.1 ? thanks, On Sun, Nov 16, 2014 at 2:57 PM, Ian Duffy i...@ianduffy.ie wrote: Hi Pierre, So advanced and basic are running from code on the host machine. Only a NFS, MySQL and hypervisor box is supplied. Testing is for binary-installation-advanced and binary-installation-basic. On 16 November 2014 19:44, Pierre-Luc Dion pd...@cloudops.com wrote: Hi Ian, I'm trying it as it seams quite strait forward. although, the instruction to install cloudstack [1]: I should run that in the management VM right, not locally ? does IPs are hardcoded somewhere? Thanks, that's awesome to have a local cloudstack running without effort. I'm testing this on OSX and so far the installation process is easy and well documented (still few things missing :-P )! [1] https://github.com/imduffy15/devcloud4/tree/master/advanced#start-cloudstack *Pierre-Luc DION* Architecte de Solution Cloud | Cloud Solutions Architect t 855.652.5683 *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Sun, Nov 16, 2014 at 11:18 AM, Ian Duffy i...@ianduffy.ie wrote: TL;DR: Devcloud 4 cleaned up a bit, chef attributes no longer hidden, further user customisation allowed, Testers wanted. ** advanced zone on 4.4.* isn't supported due to a change on some API param for setting tags on interfaces ** Hi All, https://github.com/imduffy15/devcloud4/tree/dev/binary-installation-basic I've pushed some clean up work for binary-installation versions DevCloud4. I've moved a few things about so chef attributes are no longer completely black boxed and are more exposed to the user so they are aware they can change system vm locations, rpm locations, etc. Along with this I've moved to using berkshelf for pulling in the chef cookbooks. Sadly this adds a dependency on ChefDK but it works better for cookbook updates. I've also upped the amount of RAM given to XenServer and the System VMs. (6gb for XenServer and 256 for ssvm cpvm rvm)... I would suggest running on a system with 16gb of ram. I may lower this down in the future but I felt their was some performance issues in allocating only 100mb of ram to the system vms. URLs to resources should now be more stable. I'm no longer hosting a marvin binary, its pulled in from pypi. All default URLs for RPMs and SystemVM images are pointing to shapeblues repo :). The chef cookbook powering it all is a modification from the one created by the folks over at CloudOps. If anybody is interested in testing I'd love to hear some feedback: ** Note should work on osx, linux and windows (in theory, windows remains untested)** ** you need chefdk installed on your machine along with vagrant-berkshelf ** ** you need virtualbox interfaces vboxnet0 vboxnet1 vboxnet2 with ips 192.168.22.1, 192.168.23.1 and 192.168.24.1 respectively along with disabling the DHCP Server ** git clone https://github.com/imduffy15/devcloud4.git git checkout -b dev origin/dev cd binary-installation-basic or binary-installation-advanced vagrant up Thanks, Ian
Jenkins build is still unstable: simulator-singlerun #642
See http://jenkins.buildacloud.org/job/simulator-singlerun/changes
Jenkins build is back to stable : simulator-singlerun #643
See http://jenkins.buildacloud.org/job/simulator-singlerun/643/changes
Jenkins build became unstable: simulator-singlerun #644
See http://jenkins.buildacloud.org/job/simulator-singlerun/644/
Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/ --- (Updated Nov. 17, 2014, 6:26 p.m.) Review request for cloudstack. Changes --- - as suggested by Rajani Karuturi, created a new function in network.js to list LB algorithms for a network. - fixed internationalization for 'label.source' - updated to use last commit on master (efe47b07044a863e5a34f48ef6e2468265925604) Repository: cloudstack-git Description --- JIRA: CLOUDSTACK 7915 Removed hard-coded values for Load Balancer algorithms in UI. Instead, now UI sets values loaded dynamically through load balancer provider capabilities. Also updated internationalization messages. Diffs (updated) - client/WEB-INF/classes/resources/messages.properties 86eb5c2 client/WEB-INF/classes/resources/messages_ar.properties 4f65118 client/WEB-INF/classes/resources/messages_es.properties f2d754e client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 ui/dictionary.jsp 671f48f ui/scripts/network.js c27b999 ui/scripts/vpc.js af19d87 Diff: https://reviews.apache.org/r/28043/diff/ Testing (updated) --- Tests performed: - create new isolated network with DefaultIsolatedNetworkOffering, acquire new IP, list load balancer algorithms (UI) - create new shared network with DefaultSharedNetworkWithSourceNat, acquire new IP, list load balancer algorithms (UI) It should work correctly as long as network offering is configured with LB provider/capabilities. Otherwise, list of algorithms is empty in UI. Thanks, Daniel Vega Simoes
Multiple local storage pools?
Hi guys, Do you know how it would be possible to add multiple local primary storage pools? I know that if local storage is enabled /var/lib/libvirt/images (in KVM's case) is added automatically. But assuming I want to add an SSD or SATA array to this host and want to differentiate it within cloudstack, how should I go about it? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro
Re: Multiple local storage pools?
Lucian, don't relly have the answer - but did you maybe consider ZFS on Linux, mounted on /var/lib/libvirt/images/ - there you can add SSD for writings and perhaps read cache (SLOG for writes and L2ARC for readings) ? On 17 November 2014 19:37, Nux! n...@li.nux.ro wrote: Hi guys, Do you know how it would be possible to add multiple local primary storage pools? I know that if local storage is enabled /var/lib/libvirt/images (in KVM's case) is added automatically. But assuming I want to add an SSD or SATA array to this host and want to differentiate it within cloudstack, how should I go about it? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro -- Andrija Panić -- http://admintweets.com --
Re: [ACS44] release 4.4.2 imminent
Upgrade fine for me - no issues at all... - from the RPMs snapshots On 17 November 2014 14:36, Daan Hoogland daan.hoogl...@gmail.com wrote: On Mon, Nov 17, 2014 at 2:12 PM, Pierre-Luc Dion pdion...@apache.org wrote: Trying devcloud4 with 4.4 branch and I'm having this issue: I don't see the schema-441to442.sql files in the db folder too. does 442 is on a different branch? no, I added the file locallly and forgot to commit. it is pushed now, sorry -- Daan -- Andrija Panić -- http://admintweets.com --
Re: Wasting Time !
Gents - my point of view on the cloudstack and the work arround it is the folowing: - Pretty lacking documentation - Working on new fancy features - instead of making current features work at all... - Few examples: -- new vxlan isolation method was introduced some release ago - default MTU of 1450 is used - which makes need that every VM has lowered MTU inside, in order to fucntion AT ALL ! -- KVM full snapshots don't work -- GUI needs serious polishing, and I mean serious ! from sorting objects by name or similar, to some bugs fix etc. -- Network throtling on only Public/Internet NIC of VPC/VR -- Usage server was HEAVILY broken, last time I got feedback from our developer who is working on billing (at least ACS 4.3.0) -- etc,etc,etc.. I listed here just some of the issues I have reported, which have not been adresses AT ALL - when I say addressed, that means I did not get even replies. (Again, it is not me here not geting replies, but potentially large number of CS users that would benefit from the issues fixed.) But we have time obviously to spend replying on Mohammeds provocation (I say provocations since he is not replying to the thread) - instead of polishing the product and making basic things work. Again my 2 cents - just wanted to share my opinion on (un)completeness of the product. It's great for private use - but going public and trying to do business with cloudstack is at the moment very painful - works, but is very painfull and lacks some basic features. My opinion is that we need products polished, instead of slamming on the new fancy features, that nobody will use at the moment. Again, any cloud product is VERY complex - a great mixture of different technologies - so I understand it is not meant to be easy to operate and develop. Sorry for long post... I do my best to report bugs/imporvements and to make critics, but other than that - not being adeveloper, can't really help that much... - On 17 November 2014 16:18, Noel King noelk...@gmail.com wrote: Hi I also disagree completely with this thread having also checked out and installed Cloudstack competitors I found cloudstack probably the easiest and stablest to get running. I come from a programming not infrastructure backdrop and as pointed out previously implementing a private cloud is not easy, but we managed to setup up for first Cloudstack cluster with 3 servers in under one day's effort, the documentation provided was sufficient and was adequate for us to complete the task. I agree you with others you going to need to be more informative here on your problems as I have always found the community responsive and excellent to deal with. Kind regards Noel On 17 November 2014 15:05, Tim Mackey tmac...@gmail.com wrote: From my perspective there are two issues being raised in this thread. 1. The original poster didn't actually ask a question, and despite requests for more information, nothing which would allow us to help was forthcoming. We can't fix that which we don't know to be broken, and as we're all learning and building our respective experience can't hope to mirror that of anyone else. 2. CloudStack is like every piece of software I've ever worked with; it has a learning curve. Cloud in general forces you to rethink your paradigms, and for me building my first CloudStack cloud took six weeks of unlearning what I thought best practice. Not everything I had to unlearn was CloudStack; some was just bad thinking called best practice. There's lots of information out there, but a learning curve definitely exists, and even today years after that first experience I continue to learn new things about CloudStack. To Mohammad, I offer this suggestion. You've engaged with this community, but specifics are lacking. It isn't reasonable for the community to offer assistance without knowing what is troubling you. Expectations are an important part of that, and we don't know what yours were, only that you're unhappy. Sandeep has raised specific issues, and I hope they were captured in Jira ( https://issues.apache.org/jira/browse/CLOUDSTACK). If they weren't then there is a very real possibility they won't be addressed until someone either reports it, or decides to directly fix it. I know I'm guilty of not putting Jira reports in, and I suspect I'm not alone. We all have the power to complain, but we also have the power to help fix an issue by taking a few extra minutes to just report the issue, and reporting on a mailing list doesn't count. Sorry for getting on my soap box, but I figured this thread had a good chance of showing up in some index in the future and that I had an opportunity to give a bit of guidance. Hopefully I've not overstepped. -tim On Mon, Nov 17, 2014 at 9:27 AM, sandeep khandekar cloudstack.sand...@gmail.com wrote: I agree with him, it wastes time, but at the same time you are
Why a particular commit is found in 4.4 branch but not master and 4.5
Hi, I am looking at an issue fixed a while back - https://issues.apache.org/jira/browse/CLOUDSTACK-5505 I am hitting the same issue with the 4.5 branch code, and after searching around found that the fix was only found in branch 4.4, not master, not 4.5 What does this mean? The commit is only to be in 4.4, or its squashed before inclusion in later branches, including master? Thanks, KC
Build failed in Jenkins: build-4.5 #140
See http://jenkins.buildacloud.org/job/build-4.5/140/changes Changes: [jessicawang] CLOUDSTACK-7927: UI Infrastructure Primary Storage detailView add View Volumes link that will list all volumes under this primary storage when being clicked. -- [...truncated 5997 lines...] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-storage-image-sample --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-storage-image-sample --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-storage-image-default --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-plugin-storage-image-default --- [INFO] Compiling 3 source files to http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/storage/image/default/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-storage-image-sample --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/storage/image/sample/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-plugin-storage-image-sample --- [INFO] Compiling 3 source files to http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/storage/image/sample/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-midonet --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/midonet/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-plugin-network-midonet --- [INFO] Compiling 1 source file to http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/midonet/target/test-classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-storage-image-sample --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/storage/image/sample/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-plugin-storage-image-sample --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-plugin-storage-image-sample --- [INFO] Tests are skipped. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Storage Volume SolidFire Provider 4.5.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-storage-image-default --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/storage/image/default/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-plugin-storage-image-default --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-plugin-storage-image-default --- [INFO] Tests are skipped. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Storage Volume CloudByte Provider 4.5.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-storage-volume-solidfire --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/storage/volume/solidfire/target (includes = [**/*], excludes = []) [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-storage-volume-cloudbyte --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/storage/volume/cloudbyte/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/storage/volume/solidfire (includes = [target, dist], excludes = []) [INFO] [INFO] ---
Re: Why a particular commit is found in 4.4 branch but not master and 4.5
I figured this out - the CLOUDSTACK-5505 header is dropped when the fixes are merged into master and 4.5. Then I don’t see why I am hitting the issue - created a VPC, when applying static NAT it failed to apply, and it is found the VpcVR does not have eth1. The log complains about “ethnull”, which I suppose is an issue that has been fixed long back … KC On Nov 17, 2014, at 12:12 PM, Kuang-Ching Wang kuangching.w...@gmail.com wrote: Hi, I am looking at an issue fixed a while back - https://issues.apache.org/jira/browse/CLOUDSTACK-5505 I am hitting the same issue with the 4.5 branch code, and after searching around found that the fix was only found in branch 4.4, not master, not 4.5 What does this mean? The commit is only to be in 4.4, or its squashed before inclusion in later branches, including master? Thanks, KC
Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/#review61817 --- I am getting conflicts in the properties file applying to the latest master (my HEAD is @ eba7cc78da751cc25994a5a736a87ce2e83c394e). There were a lot of changes lately to the localization strings, which is probably why it is conflicting; could you try updating the patch? Applying: CLOUDSTACK-7915: Remove hard-coded values for Load Balancer algorithms in UI error: patch failed: client/WEB-INF/classes/resources/messages_fr_FR.properties:1160 error: client/WEB-INF/classes/resources/messages_fr_FR.properties: patch does not apply error: patch failed: client/WEB-INF/classes/resources/messages_ja_JP.properties:740 error: client/WEB-INF/classes/resources/messages_ja_JP.properties: patch does not apply error: patch failed: client/WEB-INF/classes/resources/messages_zh_CN.properties:740 error: client/WEB-INF/classes/resources/messages_zh_CN.properties: patch does not apply Patch failed at 0001 CLOUDSTACK-7915: Remove hard-coded values for Load Balancer algorithms in UI - Brian Federle On Nov. 17, 2014, 6:26 p.m., Daniel Vega Simoes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/ --- (Updated Nov. 17, 2014, 6:26 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- JIRA: CLOUDSTACK 7915 Removed hard-coded values for Load Balancer algorithms in UI. Instead, now UI sets values loaded dynamically through load balancer provider capabilities. Also updated internationalization messages. Diffs - client/WEB-INF/classes/resources/messages.properties 86eb5c2 client/WEB-INF/classes/resources/messages_ar.properties 4f65118 client/WEB-INF/classes/resources/messages_es.properties f2d754e client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 ui/dictionary.jsp 671f48f ui/scripts/network.js c27b999 ui/scripts/vpc.js af19d87 Diff: https://reviews.apache.org/r/28043/diff/ Testing --- Tests performed: - create new isolated network with DefaultIsolatedNetworkOffering, acquire new IP, list load balancer algorithms (UI) - create new shared network with DefaultSharedNetworkWithSourceNat, acquire new IP, list load balancer algorithms (UI) It should work correctly as long as network offering is configured with LB provider/capabilities. Otherwise, list of algorithms is empty in UI. Thanks, Daniel Vega Simoes
Jenkins build is still unstable: simulator-singlerun #645
See http://jenkins.buildacloud.org/job/simulator-singlerun/changes
Re: Review Request 27305: CLOUDSTACK-7810 : Fixed the script test_vpc_vm_life_cycle.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27305/#review61829 --- Ship it! Ship It! - sangeetha hariharan On Nov. 15, 2014, 11:04 p.m., Chandan Purushothama wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27305/ --- (Updated Nov. 15, 2014, 11:04 p.m.) Review request for cloudstack and sangeetha hariharan. Bugs: CLOUDSTACK-7810 https://issues.apache.org/jira/browse/CLOUDSTACK-7810 Repository: cloudstack-git Description --- Test Cases are trying to validate SSH access and failing. These Test Cases are not meant to be run on SImulator due to their validation requirements. Hence they cannot be run with Simulator Diffs - test/integration/component/test_vpc_vm_life_cycle.py 84e27df Diff: https://reviews.apache.org/r/27305/diff/ Testing --- Changed the tags on Tests. Testing not done Thanks, Chandan Purushothama
Re: Review Request 27305: CLOUDSTACK-7810 : Fixed the script test_vpc_vm_life_cycle.py
On Nov. 17, 2014, 10:45 p.m., sangeetha hariharan wrote: Ship It! Commit e712ac78d0814b973886ccdbd2c1edd88a0bfbb9 in cloudstack's branch refs/heads/master from Chandan Purushothama [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e712ac7 ] CLOUDSTACK-7810 : Fixed the script 'test_vpc_vm_life_cycle.py' - Chandan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27305/#review61829 --- On Nov. 15, 2014, 11:04 p.m., Chandan Purushothama wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27305/ --- (Updated Nov. 15, 2014, 11:04 p.m.) Review request for cloudstack and sangeetha hariharan. Bugs: CLOUDSTACK-7810 https://issues.apache.org/jira/browse/CLOUDSTACK-7810 Repository: cloudstack-git Description --- Test Cases are trying to validate SSH access and failing. These Test Cases are not meant to be run on SImulator due to their validation requirements. Hence they cannot be run with Simulator Diffs - test/integration/component/test_vpc_vm_life_cycle.py 84e27df Diff: https://reviews.apache.org/r/27305/diff/ Testing --- Changed the tags on Tests. Testing not done Thanks, Chandan Purushothama
Re: Multiple local storage pools?
Andrija, but I want a more straight forward way to use the SSDs. ZFS I'm sure it's awesome, but it would just complicate my setup. Thanks though. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Andrija Panic andrija.pa...@gmail.com To: dev@cloudstack.apache.org Sent: Monday, 17 November, 2014 19:07:15 Subject: Re: Multiple local storage pools? Lucian, don't relly have the answer - but did you maybe consider ZFS on Linux, mounted on /var/lib/libvirt/images/ - there you can add SSD for writings and perhaps read cache (SLOG for writes and L2ARC for readings) ? On 17 November 2014 19:37, Nux! n...@li.nux.ro wrote: Hi guys, Do you know how it would be possible to add multiple local primary storage pools? I know that if local storage is enabled /var/lib/libvirt/images (in KVM's case) is added automatically. But assuming I want to add an SSD or SATA array to this host and want to differentiate it within cloudstack, how should I go about it? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro -- Andrija Panić -- http://admintweets.com --
Jenkins build is still unstable: simulator-singlerun #646
See http://jenkins.buildacloud.org/job/simulator-singlerun/changes
Build failed in Jenkins: build-master-simulator #1150
See http://jenkins.buildacloud.org/job/build-master-simulator/1150/ -- [...truncated 1135 lines...] [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-framework-events --- [INFO] Surefire report directory: http://jenkins.buildacloud.org/job/build-master-simulator/ws/framework/events/target/surefire-reports --- T E S T S --- Results : Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] Building Apache CloudStack Cloud Engine Schema Component 4.6.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-engine-schema --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-simulator/ws/engine/schema/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-simulator/ws/engine/schema (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-engine-schema --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-engine-schema --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-engine-schema --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-engine-schema --- [INFO] Compiling 661 source files to http://jenkins.buildacloud.org/job/build-master-simulator/ws/engine/schema/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-engine-schema --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-simulator/ws/engine/schema/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-engine-schema --- [INFO] Compiling 2 source files to http://jenkins.buildacloud.org/job/build-master-simulator/ws/engine/schema/target/test-classes [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-engine-schema --- [INFO] Surefire report directory: http://jenkins.buildacloud.org/job/build-master-simulator/ws/engine/schema/target/surefire-reports --- T E S T S --- Running com.cloud.upgrade.dao.DatabaseAccessObjectTest Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.982 sec Running com.cloud.upgrade.dao.DbUpgradeUtilsTest Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.405 sec Results : Tests run: 33, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] Building Apache CloudStack Framework - Jobs 4.6.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-framework-jobs --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-simulator/ws/framework/jobs/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-simulator/ws/framework/jobs (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-framework-jobs --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-framework-jobs --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-framework-jobs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 1 resource [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-framework-jobs --- [INFO] Compiling 33 source files to http://jenkins.buildacloud.org/job/build-master-simulator/ws/framework/jobs/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-framework-jobs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 4 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-framework-jobs
Jenkins build is still unstable: simulator-singlerun #647
See http://jenkins.buildacloud.org/job/simulator-singlerun/changes
[GitHub] cloudstack pull request: CLOUDSTACK-7932: Fixed wrong semantics fo...
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/39 CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in HypervInvestigator Fixed wrong semantics for isVmAlive() method in HypervInvestigator Findbugs will report error on this as it is expecting true/false for Boolean value. But we have diffrent meaning for null so it is false positive case from findbug You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-7932 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit fe07c08c0093bbe89732bf6509f12ec8a8a0a8f2 Author: Anshul Gangwar anshul.gang...@citrix.com Date: 2014-11-17T07:30:42Z CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in HypervInvestigator Findbugs will report error on this as it is expecting true/false for Boolean value. But we have diffrent meaning for null so it is false positive case from findbug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7929: Unhandled exception when...
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/40 CLOUDSTACK-7929: Unhandled exception when setting negative value for throttling rate while creating network offering To fix issue while creating network offering if one specifies negative value for network rate then we will convert that value to 0 i.e. unlimited You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-7929 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit 2386a33e0df00920332892c00e0802be72cf63db Author: Anshul Gangwar anshul.gang...@citrix.com Date: 2014-11-14T05:26:05Z CLOUDSTACK-7929: While creating network offering if one specifies negative value for network rate then we will convert that value to 0 i.e. unlimited --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7930, CLOUDSTACK-7931: Do not ...
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/41 CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for global settings which are of type integer and float Do not allow to set invalid values for global settings which are of type integer and float You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-7930 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit b7de1ecbe470365c30bc6afcea5f5c560bc9c8c2 Author: Anshul Gangwar anshul.gang...@citrix.com Date: 2014-11-17T09:57:22Z CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for global settings which are of type integer and float --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Multiple local storage pools?
Ok, waiting for someone to answer this :) Sent from Google Nexus 4 On Nov 18, 2014 12:35 AM, Nux! n...@li.nux.ro wrote: Andrija, but I want a more straight forward way to use the SSDs. ZFS I'm sure it's awesome, but it would just complicate my setup. Thanks though. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Andrija Panic andrija.pa...@gmail.com To: dev@cloudstack.apache.org Sent: Monday, 17 November, 2014 19:07:15 Subject: Re: Multiple local storage pools? Lucian, don't relly have the answer - but did you maybe consider ZFS on Linux, mounted on /var/lib/libvirt/images/ - there you can add SSD for writings and perhaps read cache (SLOG for writes and L2ARC for readings) ? On 17 November 2014 19:37, Nux! n...@li.nux.ro wrote: Hi guys, Do you know how it would be possible to add multiple local primary storage pools? I know that if local storage is enabled /var/lib/libvirt/images (in KVM's case) is added automatically. But assuming I want to add an SSD or SATA array to this host and want to differentiate it within cloudstack, how should I go about it? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro -- Andrija Panić -- http://admintweets.com --
[GitHub] cloudstack pull request: Merge 4.5 to master
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/42 Merge 4.5 to master You can merge this pull request into a Git repository by running: $ git pull https://github.com/karuturi/cloudstack merge-45-to-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit 2d3b3376e37faeec3ed62a58750819dc7630260c Author: Sheng Yang sheng.y...@citrix.com Date: 2014-11-14T19:43:03Z Revert CLOUDSTACK-7821: Fix OSX cannot connect to VPN due to wrongly declaim ENCAPSULATION_MODE_UDP_TRANSPORT_RFC This reverts commit e1c788ca3c69a8c8c2041c7b106f76fa49332888. It breaks Windows 7 client. commit 425a6b01d60b88016c23a1126960375b00d97069 Author: Anthony Xu anthony...@citrix.com Date: 2014-11-14T19:24:42Z CLOUDSTACK-7918: guest os name changes from 'SUSE Linux Enterprise Server 12 (experimental)' to 'SUSE Linux Enterprise Server 12 (64-bit)' in latest XS 5.6 , changed the guest OS mapping to fix it. commit 303fc90057db2707ae8f6b709fb5e3e86fc9db40 Author: Milamber milam...@apache.org Date: 2014-11-15T08:37:49Z Update L10N resource files on master branch (with 4.5 translation strings) commit 25e5d00f6016b31fc178da97c7125c2f37a8c40d Author: Milamber milam...@apache.org Date: 2014-11-15T08:38:34Z Add 4.5.x messages.properties to Transifex config tool commit 19781e094b987cf65d05d890cd3cd86fc22cb873 Author: Chandan Purushothama chandan.purushoth...@citrix.com Date: 2014-11-14T06:56:01Z CLOUDSTACK-7913 : Added reconnect functionality to Host class in base.py Signed-off-by: SrikanteswaraRao Talluri tall...@apache.org commit 5f99917991a59f8ecd6d8b0e17b497fe210e636e Author: Gaurav Aradhye gaurav.arad...@clogeny.com Date: 2014-11-14T14:23:25Z CLOUDSTACK-7912: Remove hardcoded netscaler info and read it from config file Signed-off-by: SrikanteswaraRao Talluri tall...@apache.org commit 635abaf2e9ca4f0399085f441ea6d5eeaab9f3ab Author: Jessica Wang jessicaw...@apache.org Date: 2014-11-17T21:05:08Z CLOUDSTACK-7927: UI Infrastructure Primary Storage detailView add View Volumes link that will list all volumes under this primary storage when being clicked. commit aa5cb0838a340b9521f98a6dfc18bf076ab6f454 Author: Rajani Karuturi rajanikarut...@gmail.com Date: 2014-11-18T06:12:07Z Merge branch '4.5' Conflicts: client/WEB-INF/classes/resources/messages_zh_CN.properties --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Review Request 28160: CloudStack-6282: Added event test cases in Ipaddresses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28160/ --- Review request for cloudstack and Santhosh Edukulla. Bugs: cloudstack-6282 https://issues.apache.org/jira/browse/cloudstack-6282 Repository: cloudstack-git Description --- CloudStack-6282: Added event test cases in Ipaddresses Diffs - test/integration/component/test_escalations_ipaddresses.py 41e5b2f Diff: https://reviews.apache.org/r/28160/diff/ Testing --- Testing is done . Attached is the result log File Attachments results.txt https://reviews.apache.org/media/uploaded/files/2014/11/18/c518dfef-9937-4bfe-8e1b-db0d4f4d7387__results.txt Thanks, Monis Majeed
Review Request 28161: CLOUDSTACK-7933: test_escalations_instances.py - Fixed test_13_vm_nics for Vmware
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28161/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7933 https://issues.apache.org/jira/browse/CLOUDSTACK-7933 Repository: cloudstack-git Description --- Skipping remove nic operation for VMware when vmware tools are not installed on VM. Diffs - test/integration/component/test_escalations_instances.py fd25bb9 Diff: https://reviews.apache.org/r/28161/diff/ Testing --- Yes. log: @Desc: Test to verify Nics for a VM ... === TestName: test_13_vm_nics | Status : SUCCESS === ok -- Ran 1 test in 255.060s OK Thanks, Gaurav Aradhye
[GitHub] cloudstack pull request: CLOUDSTACK-7932: Fixed wrong semantics fo...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/39#issuecomment-63428603 From the method definition (isVmAlive), looks like what it is doing is right. ideally, we should change the return type from Boolean to boolean in the interface. Maybe in the caller(HighAvailabilityManagerImpl), you could check for both null and false for now. Also, can you add some unittests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7929: Unhandled exception when...
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/40#discussion_r20487864
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -3723,6 +3723,10 @@ public NetworkOffering
createNetworkOffering(CreateNetworkOfferingCmd cmd) {
throw new InvalidParameterValueException(Invalid value for
Availability. Supported types: + Availability.Required + , +
Availability.Optional);
}
+if (networkRate != null networkRate 0) {
--- End diff --
is networkRate == null a valid value?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-7932: Fixed wrong semantics fo...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/39#issuecomment-63429460 Actually null has different meaning than false. False means that vm is not alive while null means it cannot be determined whether it is alive or not. This is existing functionality for all hypervisor investigators so it doesn't make sense to write unit tests for this. This got changed to this behavior while fixing findbug bugs. Better would be to use enum to represent various better states. But that will require many changes and can be taken for next release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7929: Unhandled exception when...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/40#discussion_r20488120
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -3723,6 +3723,10 @@ public NetworkOffering
createNetworkOffering(CreateNetworkOfferingCmd cmd) {
throw new InvalidParameterValueException(Invalid value for
Availability. Supported types: + Availability.Required + , +
Availability.Optional);
}
+if (networkRate != null networkRate 0) {
--- End diff --
yes. it means that networkRate parameter is not passed and networkRate for
this offering will be taken from other global settings
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-7930, CLOUDSTACK-7931: Do not ...
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20488370
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String name,
String value, String scop
type = c.getType();
}
+String errMsg = null;
+try {
+if (type.equals(Integer.class)) {
+errMsg = There was error in trying to parse value: +
value + . Please enter a valid integer value for parameter + name;
+Integer.parseInt(value);
+} else if (type.equals(Float.class)) {
+errMsg = There was error in trying to parse value: +
value + . Please enter a valid float value for parameter + name;
+Float.parseFloat(value);
--- End diff --
should we allow values like 3,400.5 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-7930, CLOUDSTACK-7931: Do not ...
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20488404
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String name,
String value, String scop
type = c.getType();
}
+String errMsg = null;
+try {
+if (type.equals(Integer.class)) {
+errMsg = There was error in trying to parse value: +
value + . Please enter a valid integer value for parameter + name;
+Integer.parseInt(value);
+} else if (type.equals(Float.class)) {
+errMsg = There was error in trying to parse value: +
value + . Please enter a valid float value for parameter + name;
+Float.parseFloat(value);
+}
+} catch (Exception e) {
--- End diff --
Can you catch specific expected exceptions NPE and NFE?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-7930, CLOUDSTACK-7931: Do not ...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/41#issuecomment-63430386 Can you add unittests for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7932: Fixed wrong semantics fo...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/39#issuecomment-63430873 In the second return statement, should it return false since the agent is alive and returned some status? I didnt understand the argument for not adding unittests. I see that as an only way to avoid the same changes in future as findbugs would report it again and someone would attempt to fix it again. adding some documentation might help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Multiple local storage pools?
Not directly, but one way you could make this happen would be to create a 'sharedmountpoint' primary storage, and use tags to ensure that it doesn't try to use that storage on any host other than the desired one. Sharedmountpoint is basically telling CS that you have done the work of mounting a clustered filesystem in a specific place. For example, set the host with tag 'host1', the storage with tag 'host1ssd', and create a service offering with both storage tag and host tag to select that combination. Kind of a hack, but it should work. On Mon, Nov 17, 2014 at 11:03 PM, Andrija Panic andrija.pa...@gmail.com wrote: Ok, waiting for someone to answer this :) Sent from Google Nexus 4 On Nov 18, 2014 12:35 AM, Nux! n...@li.nux.ro wrote: Andrija, but I want a more straight forward way to use the SSDs. ZFS I'm sure it's awesome, but it would just complicate my setup. Thanks though. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Andrija Panic andrija.pa...@gmail.com To: dev@cloudstack.apache.org Sent: Monday, 17 November, 2014 19:07:15 Subject: Re: Multiple local storage pools? Lucian, don't relly have the answer - but did you maybe consider ZFS on Linux, mounted on /var/lib/libvirt/images/ - there you can add SSD for writings and perhaps read cache (SLOG for writes and L2ARC for readings) ? On 17 November 2014 19:37, Nux! n...@li.nux.ro wrote: Hi guys, Do you know how it would be possible to add multiple local primary storage pools? I know that if local storage is enabled /var/lib/libvirt/images (in KVM's case) is added automatically. But assuming I want to add an SSD or SATA array to this host and want to differentiate it within cloudstack, how should I go about it? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro -- Andrija Panić -- http://admintweets.com --
[GitHub] cloudstack pull request: CLOUDSTACK-7932: Fixed wrong semantics fo...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/39#issuecomment-63432886 No. Because agent is reporting status of host. We cannot determine the status of VMs from that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7930, CLOUDSTACK-7931: Do not ...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20489652
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String name,
String value, String scop
type = c.getType();
}
+String errMsg = null;
+try {
+if (type.equals(Integer.class)) {
+errMsg = There was error in trying to parse value: +
value + . Please enter a valid integer value for parameter + name;
+Integer.parseInt(value);
+} else if (type.equals(Float.class)) {
+errMsg = There was error in trying to parse value: +
value + . Please enter a valid float value for parameter + name;
+Float.parseFloat(value);
--- End diff --
No. Because they will fail later in parsing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-7930, CLOUDSTACK-7931: Do not ...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20489860
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String name,
String value, String scop
type = c.getType();
}
+String errMsg = null;
+try {
+if (type.equals(Integer.class)) {
+errMsg = There was error in trying to parse value: +
value + . Please enter a valid integer value for parameter + name;
+Integer.parseInt(value);
+} else if (type.equals(Float.class)) {
+errMsg = There was error in trying to parse value: +
value + . Please enter a valid float value for parameter + name;
+Float.parseFloat(value);
+}
+} catch (Exception e) {
--- End diff --
What value will be added by catching specific exceptions?
In the end user only wants to know whether the value is valid or not.
he/she is not concerned with what type of exception he is getting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
