[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

2015-08-11 Thread borisroman
GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/680

Interface changes related to CLOUDSTACK-8580

See issue CLOUDSTACK-8580 and individual commits.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8580

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #680


commit 53e6551dee27ed41ec729746e305f1c3f43ce7ee
Author: Boris Schrijver bo...@pcextreme.nl
Date:   2015-08-11T21:45:16Z

Added responses to ListCapabilities to reflect CLOUDSTACK-8580 changes.

This to add these options to the gui. See issue CLOUDSTACK-8580.

commit 8d8b6f85a85021841c06aae1cb2e1a71a3d08fc7
Author: Boris Schrijver bo...@pcextreme.nl
Date:   2015-08-11T22:28:36Z

Made interface changes related to CLOUDSTACK-8580


https://github.com/kevindierkx/cloudstack/commit/3be14e978aa0c9b286d9f57bf1fc60ebe50990c7




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/674#issuecomment-130100258
  
I'd eventually like to. I'm in the process of setting up our test
infrastructure so these kinds of tests can run automatically. Right now
it's a combination of manually kicking off tests and manually running some
tests via the GUI.

On Tuesday, August 11, 2015, Daan Hoogland notificati...@github.com wrote:

 Code lgtm. can you publish the tests?

 —
 Reply to this email directly or view it on GitHub
 https://github.com/apache/cloudstack/pull/674#issuecomment-130091528.



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/671


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

2015-08-11 Thread pavanb018
Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/671#issuecomment-129720549
  
LGTM 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[Blocker/Critical] VR related Issues

2015-08-11 Thread Kishan Kavala
Below VR related issues currently open. Most of these issues did not exist in 
4.5.x and are related to VR refactor (persistent VR).

Blocker
https://issues.apache.org/jira/browse/CLOUDSTACK-8690 - Remote Access VPN not 
working

Critical
https://issues.apache.org/jira/browse/CLOUDSTACK-8688 - Default policy for 
INPUT and FORWARD chain is ACCEPT in VR filter table (Wilder is working on 
this) 
https://issues.apache.org/jira/browse/CLOUDSTACK-8681 - CS does not honor the 
default deny egress policy in isolated network
https://issues.apache.org/jira/browse/CLOUDSTACK-8710 - site2site vpn iptables 
rules are not configured on VR
https://issues.apache.org/jira/browse/CLOUDSTACK-8685 - Default route is not 
configured on VPC VR
https://issues.apache.org/jira/browse/CLOUDSTACK-8694  - Monitor service cron 
job not visible





[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/658


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: VR remote access vpn not working in master

2015-08-11 Thread Jayapal Reddy Uradi
Marked this bug as blocker because the remote access VPN functionality itself 
broken.

Thanks,
Jayapal

On 31-Jul-2015, at 11:42 AM, Jayapal Reddy 
jayapalreddy.ur...@citrix.commailto:jayapalreddy.ur...@citrix.com wrote:

Hi All,

In latest master remote access vpn is not working because the configuration is 
not applied on the VR.
On the VR logs below error msg is seen.
'Error I do not know what to do with file of type remoteaccessvpn'

I have file ticket 
CLOUDSTACK-8690https://issues.apache.org/jira/browse/CLOUDSTACK-8690. The 
remote access vpn feature is broken so I think it is blocker.


Thanks,
Jayapal




[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call listUsa...

2015-08-11 Thread pritisarap12
GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/675

CLOUDSTACK-8723: Verify API call listUsageRecords returns usage of new 
volume created after restore VM

After restoring a running VM current ROOT disk gets destroyed and new ROOT 
disk gets created.
This testcase is to check if volume usage of this newly created volume is 
listed in listUsageRecords API.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-8723-Verify-API-call-listUsageRecords-returns-usage-of-new-volume-created-after-restore-VM

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #675


commit c7e30029c17cc9c0d1f72803da481cc896ecc5e7
Author: Priti Sarap priti.sa...@clogeny.com
Date:   2015-08-11T08:45:13Z

CLOUDSTACK-8723: Verify API call listUsageRecords returns usage of new 
volume created after restore VM




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: Revisit Process for creating Blocker bugs

2015-08-11 Thread Raja Pullela
Thanks for the summary Somesh and thanks for Mike for the clarification.  
(3) sounds good - it's always good to let everyone know that you've/reporter 
created a blocker bug!   Hope we will have enough people to chime in to voice 
their yea's or nay's?

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Tuesday, August 11, 2015 6:02 AM
To: dev@cloudstack.apache.org
Subject: Re: Revisit Process for creating Blocker bugs

3. In case the reporter feels the defect qualifies as a Blocker, they should 
raise it as Blocker and create a discussion/voting thread on the ML for the 
same.

This is what I always do these days and I think it makes a lot of sense: Go 
ahead and mark the bug as a Blocker, but then send out an obvious e-mail (i.e. 
well-named Subject) to the list to begin discussion around it.

On Mon, Aug 10, 2015 at 10:24 AM, Somesh Naidu somesh.na...@citrix.com
wrote:

  I did not see (or understand) a major change proposed or needed in 
  this
 thread.

 The primary topic of discussion is categorization of a defect as 
 Blocker, that is, how to qualify a defect as Blocker. The discussion 
 scope widened and included process to raise an issue as Blocker.

 The issue/discussion seems to have risen due to some folks (Raja and 
 team) raising a blocker without discussion on ML. As a counter 
 measure, these defects were downgraded to Critical (by Daan).

 In terms of qualification for a blocker, the two school of thoughts 
 were, Raja/Ram - consideration should be drawn from the 
 technical/functional impact irrespective of how many users are affected.
 Daan - consideration should be drawn from how many users are affected 
 (achieved by voting).

 In terms of the process, two approaches proposed were, Raja/Ram - the 
 reporter should first set the priority level to Blocker
 and in parallel raise it for discussion on the ML.
 Daan - the reporter should raise such defect as Critical and then 
 work on promoting it to Blocker via lazy consensus.

 I am not entirely sure which approach suggests a change.

 @Daan/Raja - My sincere apologies in case my summary has inaccuracies; 
 please feel free to correct.

 My proposal was (matches with mostly what Sebastian said), 1. Create a 
 wiki page with more detailed guidelines and processes for Release 
 Blockers.
 2. The reporter should raise a defect by qualifying against the above 
 guidelines.
 3. In case the reporter feels the defect qualifies as a Blocker, they 
 should raise it as Blocker and create a discussion/voting thread on 
 the ML for the same.
 4. RM should ensure an explicit decision is made on the severity and 
 upgrade/downgrade accordingly. Note, RM having the responsibility and 
 authority to drive closure does not equate to veto power.

 Regards,
 Somesh


 -Original Message-
 From: Sebastien Goasguen [mailto:run...@gmail.com]
 Sent: Monday, August 10, 2015 4:23 AM
 To: dev@cloudstack.apache.org
 Subject: Re: Revisit Process for creating Blocker bugs


  On Aug 6, 2015, at 7:35 AM, Raja Pullela raja.pull...@citrix.com
 wrote:
 
  Looks like there are few of us who differ with the current
 process/restriction.
  Just to close this thread - there are already guidelines that exist
 currently and we should continue to adopt or follow those.Let the
 Release Manager or other people closely involved with a particular 
 release decide on whether a particular bug is correctly categorized or 
 not.  They should have the veto power to downgrade or upgrade, as necessary.
 

 I would not call it veto power.

 Folks will file tickets and put a priority level, a RM will see 
 blockers and when those are not resolved, the RM should go on the list 
 and get a feel from the community about those blockers (whether they are or 
 not).

 I did not see (or understand) a major change proposed or needed in 
 this thread.


  Assess Priority -
 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=30746
 287
  When creating a new Jira ticket, please take a minute to correctly
 assess the priority of the issue. By default, Jira assigns a new issue 
 a Priority level of Major. In many cases, this is wrong. Please be 
 sure to set the Priority correctly:
  Blocker: Blocks development and/or testing work, production cannot run.
 Security issues.
  Critical: Crashes, loss of data, severe memory leak.
  Major: Major loss of function, broken feature, returns incorrect
 information, etc.
  Minor: Minor loss of function, problem with an easy workaround. 
  Wishlist
 items.
  Trivial: Typos that don't affect comprehension of the UI, misaligned
 text, etc.
 
  -Original Message-
  From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
  Sent: Wednesday, August 5, 2015 2:19 PM
  To: dev dev@cloudstack.apache.org
  Subject: Re: Revisit Process for creating Blocker bugs
 
  Koushik, that would be true if we had our upgrade process in order.
 
  On Wed, Aug 5, 2015 at 7:14 AM, Koushik Das koushik@citrix.com
 

Re: Ec2stack not working with current aws cli

2015-08-11 Thread sebgoa

On Aug 10, 2015, at 11:25 PM, Carlos Reátegui car...@reategui.com wrote:

 
 
 Can you make a PR that updates the README with this config option…
 
 Done. 
 

thanks merged

 
 
 thanks
 
 On Aug 6, 2015, at 3:07 AM, Carlos Reategui create...@gmail.com wrote:
 
 BTW I figured out how to force the cli to send v2.  It would still be nice
 to update Ec2Stack though:
 
 aws configure set profile.your profile name.ec2.signature_version v2
 
 
 Or for your default profile:
 
 
 aws configure set default.ec2.signature_version v2
 
 
 The above will update your ~/.aws/config file.
 
 
 
 
 On Wed, Aug 5, 2015 at 5:49 PM, Carlos Reategui create...@gmail.com wrote:
 
 Hi,
 I am having trouble with the current aws cli.  Ec2stack is expecting AWS
 signature version 2 but the current aws cli uses v4.
 
 Do I file a JIRA in under cloudstack?  I did not see an ec2stack component.
 
 Here is a wireshark capture:
 
 POST / HTTP/1.1
 Host: localhost:5000
 Accept-Encoding: identity
 Content-Length: 40
 Content-Type: application/x-www-form-urlencoded
 X-Amz-Date: 20150806T002150Z
 Authorization: AWS4-HMAC-SHA256
 Credential=x/20150806//ec2/aws4_request,
 SignedHeaders=host;user-agent;x-amz-date, Signature=xx
 User-Agent: aws-cli/1.7.42 Python/2.7.6 Darwin/14.4.0
 
 Action=DescribeImagesVersion=2015-04-15
 
 HTTP/1.0 400 BAD REQUEST
 Content-Type: application/xml
 Content-Length: 314
 Server: Werkzeug/0.10.4 Python/2.7.3
 Date: Thu, 06 Aug 2015 00:21:50 GMT
 
 ?xml version=1.0 encoding=UTF-8?
 Response
 
 
 Errors
 Error
 CodeMissingParameter/Code
 MessageThe request must contain the parameter
 SignatureVersion/Message
 /Error
 /Errors
 
 
 
  RequestId21ba5526-3bd1-11e5-abbc-d4ae52927e09/RequestId
 
 /Response
 
 
 



[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/658#issuecomment-129801929
  
@manuiiit Nice. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Improve debug message when the scheduler ...

2015-08-11 Thread milamberspace
GitHub user milamberspace opened a pull request:

https://github.com/apache/cloudstack/pull/676

Improve debug message when the scheduler prepare to snapshot (volume …

…'id' and add volume name)

Signed-off-by: Milamber milam...@apache.org

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milamberspace/cloudstack AddVolumeName

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #676


commit 302408f15ce75396acef2acb0feae33f6b81d8b3
Author: Milamber milam...@apache.org
Date:   2015-06-22T21:44:03Z

Improve debug message when the scheduler prepare to snapshot (volume 'id' 
and add volume name)

Signed-off-by: Milamber milam...@apache.org




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36735392
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call listUsa...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/675#discussion_r36731289
  
--- Diff: test/integration/testpaths/testpath_usage.py ---
@@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self):
 # aggregation period and current period will give the network usage
 return
 
+@attr(tags=[advanced, basic], required_hardware=false)
+def test_08_checkNewVolumein_listUsageRecords(self):
+ Test case to check if new volume crated after
+restore VM is listed in listUsageRecords
+# 1. Launch a VM
+# 2. Restore the VM
+# 3. Check if the new volume created is listed in listUsageRecords 
API
+
+
+# Step 1
+vm_cluster = VirtualMachine.create(
+self.userapiclient,
+self.testdata[small],
+templateid=self.template.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+)
+
+volumes_root_list = list_volumes(
+self.apiclient,
+virtualmachineid=vm_cluster.id,
+type='ROOT',
+listall=True
+)
--- End diff --

use validate list  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-11 Thread jburwell
Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/650#discussion_r36737719
  
--- Diff: 
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
 ---
@@ -322,21 +306,11 @@ public String authenticate(final String command, 
final MapString, Object[] par
 if (_apiServer.verifyUser(userAccount.getId())) {
 LoginCmdResponse loginResponse = 
(LoginCmdResponse) _apiServer.loginUser(session, userAccount.getUsername(), 
userAccount.getUsername() + userAccount.getSource().toString(),
 userAccount.getDomainId(), null, 
remoteAddress, params);
-resp.addCookie(new Cookie(userid, 
URLEncoder.encode(loginResponse.getUserId(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie(domainid, 
URLEncoder.encode(loginResponse.getDomainId(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie(role, 
URLEncoder.encode(loginResponse.getType(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie(username, 
URLEncoder.encode(loginResponse.getUsername(), HttpUtils.UTF_8)));
-resp.addCookie(new Cookie(account, 
URLEncoder.encode(loginResponse.getAccount(), HttpUtils.UTF_8)));
-String timezone = loginResponse.getTimeZone();
-if (timezone != null) {
-resp.addCookie(new Cookie(timezone, 
URLEncoder.encode(timezone, HttpUtils.UTF_8)));
-}
-resp.addCookie(new Cookie(userfullname, 
URLEncoder.encode(loginResponse.getFirstName() +   + 
loginResponse.getLastName(), HttpUtils.UTF_8).replace(+, %20)));
-resp.addHeader(SET-COOKIE, 
String.format(%s=%s;HttpOnly, ApiConstants.SESSIONKEY, 
loginResponse.getSessionKey()));
+SAMLUtils.setupSamlUserCookies(loginResponse, 
resp);
 
resp.sendRedirect(SAML2AuthManager.SAMLCloudStackRedirectionUrl.value());
 return 
ApiResponseSerializer.toSerializedString(loginResponse, responseType);
 }
-} catch (final CloudAuthenticationException ignored) {
+} catch (final Exception ignored) {
--- End diff --

Java7 supports multi-catch[1] to avoid boilerplate error handling logic.  
However, some code duplication would be preferable to an overly broad catch 
that swallows errors.  

Personally, I think all ignored exceptions should be logged to WARN.  Many 
times, a pattern of ignored exceptions is a symptom of pending and current 
systemic issue.  Having the information in the log as warning helps operators 
detect these types of errors and often avoid larger issues.

[1]: 
https://docs.oracle.com/javase/7/docs/technotes/guides/language/catch-multiple.html
 
https://docs.oracle.com/javase/7/docs/technotes/guides/language/catch-multiple.html
 On Aug 11, 2015, at 1:26 AM, Rohit Yadav notificati...@github.com wrote:
 
 In 
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
 https://github.com/apache/cloudstack/pull/650#discussion_r36712694:
 
   
resp.sendRedirect(SAML2AuthManager.SAMLCloudStackRedirectionUrl.value());
   return 
ApiResponseSerializer.toSerializedString(loginResponse, responseType);
   }
  -} catch (final CloudAuthenticationException 
ignored) {
  +} catch (final Exception ignored) {
 @jburwell https://github.com/jburwell @DaanHoogland 
https://github.com/DaanHoogland catching pokemons allows to reduce redundant 
error handling code, in case of any auth or IO exception (as the plugin is 
conversing with the IDP server) an API authentication error is thrown at the 
bottom; not sure what could be the best way of handling this without 
duplicating code
 
 —
 Reply to this email directly or view it on GitHub 
https://github.com/apache/cloudstack/pull/650/files#r36712694.
 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Improve cloud-install-sys-tmplt to work i...

2015-08-11 Thread remibergsma
GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/678

Improve cloud-install-sys-tmplt to work in dev environment again

The script that you run to initially setup secondary storage, had some 
errors. As it now depends on /etc/cloudstack/management/db.properties, it did 
not work any more on my development environment.

I defined some defaults that work in development environments (those are 
sane defaults anyway), then check if the 
/etc/cloudstack/management/db.properties file exists. If so, it reads from 
there and gets the vars just like before. If not, it keeps the defaults unless 
of course someone overrides them on the command line.

While working on the script, I also fixed the indentation and found a query 
that was not yet using the -P mysql port variable.

I tested it both on my development environment as well as in an environment 
installed from RPM (where you'd have /etc/cloudstack/management/db.properties 
and that both worked.

PS @snuf please check if it also works again for you.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
sec-stor-script-mysql-default-port

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #678


commit 8a1e79f518eadd772913d01c66a98414867fc8a6
Author: Remi Bergsma git...@remi.nl
Date:   2015-08-11T11:37:24Z

make sane defaults for MySQL settings

In dev environments, there is no /etc/cloudstack/management/db.properties 
file
That forces you to specify all parameters on the command line. This commit
sets some defaults, like port 3306, user root and localhost.

When available, it will still get settings from the config file and it will
also allow you to override it on the command line. So it is fully backwards
compatible.

commit ee9b644e28f8c1bab6afb94311054f2cd2f2e3d9
Author: Remi Bergsma git...@remi.nl
Date:   2015-08-11T12:43:17Z

this query had no -P port specified so did not work

commit 2f858a7d088f4a41c35bf1c0577f922a51fc3ca2
Author: Remi Bergsma git...@remi.nl
Date:   2015-08-11T12:55:16Z

clean-ups in the file

- replace tabs with 4 spaces
- removed trailing spaces
- fixed indenting
- made if; then look the same




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-129836794
  
can we get test result ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call listUsa...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/675#discussion_r36732367
  
--- Diff: test/integration/testpaths/testpath_usage.py ---
@@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self):
 # aggregation period and current period will give the network usage
 return
 
+@attr(tags=[advanced, basic], required_hardware=false)
+def test_08_checkNewVolumein_listUsageRecords(self):
+ Test case to check if new volume crated after
+restore VM is listed in listUsageRecords
+# 1. Launch a VM
+# 2. Restore the VM
+# 3. Check if the new volume created is listed in listUsageRecords 
API
+
+
+# Step 1
+vm_cluster = VirtualMachine.create(
+self.userapiclient,
+self.testdata[small],
+templateid=self.template.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+)
+
+volumes_root_list = list_volumes(
+self.apiclient,
+virtualmachineid=vm_cluster.id,
+type='ROOT',
+listall=True
+)
+
+root_volume = volumes_root_list[0]
+
+# Step 2
+vm_cluster.restore(self.apiclient)
+
+qresultset = self.dbclient.execute(
+select id from volumes where name='%s' and state='Ready'; %
+root_volume.name)
+
+self.assertNotEqual(
+len(qresultset),
+0,
+Check DB Query result set
+)
+
+volumeCheck = Volume Id:  + str(qresultset[0][0]) +  usage time
+
+response = self.listUsageRecords(usagetype=6)
+self.assertEqual(response[0], PASS, response[1])
+UsageRecords = [record for record in response[1]
+if volumeCheck in record.description]
+# Step 3
+self.assertNotEqual(
--- End diff --

even  if  UsageRecords is empty test case will pass , is that we are 
expecting ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/673#issuecomment-129868539
  
Thanks @anshul1886 will test it soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/667#discussion_r36733719
  
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+Test restore running VM on VMWare with one cluster having 2 Primary Storage
+
+
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+   list_virtual_machines
+   )
+
+from marvin.codes import CLUSTERTAG1, ROOT
+import time
+
+
+class TestRestoreVM(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestRestoreVM, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+try:
+cls.skiptest = False
+if cls.hypervisor.lower() not in [vmware]:
+cls.skiptest = True
+return
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_cwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=CLUSTERTAG1
+)
+cls._cleanup.append(cls.service_offering_cwps)
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(This test is to be checked on VMWare only \
+Hence, skip for %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+return
+
+@attr(tags=[advanced, basic], required_hardware=true)
+def test_01_recover_VM(self):
+ Test Restore VM on VMWare
+1. Deploy a VM without datadisk
+2. Restore the VM
+3. Verify that VM comes up in 

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-129837984
  
can we get test results ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call listUsa...

2015-08-11 Thread pritisarap12
Github user pritisarap12 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/675#discussion_r36734678
  
--- Diff: test/integration/testpaths/testpath_usage.py ---
@@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self):
 # aggregation period and current period will give the network usage
 return
 
+@attr(tags=[advanced, basic], required_hardware=false)
+def test_08_checkNewVolumein_listUsageRecords(self):
+ Test case to check if new volume crated after
+restore VM is listed in listUsageRecords
+# 1. Launch a VM
+# 2. Restore the VM
+# 3. Check if the new volume created is listed in listUsageRecords 
API
+
+
+# Step 1
+vm_cluster = VirtualMachine.create(
+self.userapiclient,
+self.testdata[small],
+templateid=self.template.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+)
+
+volumes_root_list = list_volumes(
+self.apiclient,
+virtualmachineid=vm_cluster.id,
+type='ROOT',
+listall=True
+)
+
+root_volume = volumes_root_list[0]
+
+# Step 2
+vm_cluster.restore(self.apiclient)
+
+qresultset = self.dbclient.execute(
+select id from volumes where name='%s' and state='Ready'; %
+root_volume.name)
+
+self.assertNotEqual(
+len(qresultset),
+0,
+Check DB Query result set
+)
+
+volumeCheck = Volume Id:  + str(qresultset[0][0]) +  usage time
+
+response = self.listUsageRecords(usagetype=6)
+self.assertEqual(response[0], PASS, response[1])
+UsageRecords = [record for record in response[1]
+if volumeCheck in record.description]
+# Step 3
+self.assertNotEqual(
--- End diff --

No, In step 3 we are verifying that UsageRecords should not be None.
or I have updated test case to fail it if UsageRecords  is empty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36734361
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-129846827
  
can you update test results ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36734207
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# License); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ Test case for Multiple Volume Snapshot in ZWPS
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata[ostype])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list)  2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata[account],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata[service_offering],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata[disk_offering],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception(Warning: Exception during cleanup : %s % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest(Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
+
+def 

[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...

2015-08-11 Thread milamberspace
GitHub user milamberspace opened a pull request:

https://github.com/apache/cloudstack/pull/677

[ACS4.5] Improve debug message when the scheduler prepare to snapshot 
(volume …

…'id' and add volume name)

Signed-off-by: Milamber milam...@apache.org

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milamberspace/cloudstack AddVolumeName45

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #677


commit ebac91de53e14d60474745c5853a22eec84409b2
Author: Milamber milam...@apache.org
Date:   2015-06-22T21:44:03Z

Improve debug message when the scheduler prepare to snapshot (volume 'id' 
and add volume name)

Signed-off-by: Milamber milam...@apache.org




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: VR remote access vpn not working in master

2015-08-11 Thread Jayapal Reddy Uradi
There is no work around. Currently there are no code changes in VR to config 
the remote access vpn.

Thanks,
Jayapal

On 11-Aug-2015, at 8:23 PM, Somesh Naidu somesh.na...@citrix.com
 wrote:

 Is this open for voting? Is there a workaround/quickfix for this?
 
 Regards,
 Somesh
 
 -Original Message-
 From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] 
 Sent: Tuesday, August 11, 2015 4:53 AM
 To: dev@cloudstack.apache.org
 Subject: Re: VR remote access vpn not working in master
 
 Marked this bug as blocker because the remote access VPN functionality itself 
 broken.
 
 Thanks,
 Jayapal
 
 On 31-Jul-2015, at 11:42 AM, Jayapal Reddy 
 jayapalreddy.ur...@citrix.commailto:jayapalreddy.ur...@citrix.com wrote:
 
 Hi All,
 
 In latest master remote access vpn is not working because the configuration 
 is not applied on the VR.
 On the VR logs below error msg is seen.
 'Error I do not know what to do with file of type remoteaccessvpn'
 
 I have file ticket 
 CLOUDSTACK-8690https://issues.apache.org/jira/browse/CLOUDSTACK-8690. The 
 remote access vpn feature is broken so I think it is blocker.
 
 
 Thanks,
 Jayapal
 
 



[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/677#issuecomment-129868111
  
Code LGTM, we should also bring this to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Improve cloud-install-sys-tmplt to work i...

2015-08-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/678#issuecomment-129910400
  
lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: VR remote access vpn not working in master

2015-08-11 Thread Somesh Naidu
Is this open for voting? Is there a workaround/quickfix for this?

Regards,
Somesh

-Original Message-
From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] 
Sent: Tuesday, August 11, 2015 4:53 AM
To: dev@cloudstack.apache.org
Subject: Re: VR remote access vpn not working in master

Marked this bug as blocker because the remote access VPN functionality itself 
broken.

Thanks,
Jayapal

On 31-Jul-2015, at 11:42 AM, Jayapal Reddy 
jayapalreddy.ur...@citrix.commailto:jayapalreddy.ur...@citrix.com wrote:

Hi All,

In latest master remote access vpn is not working because the configuration is 
not applied on the VR.
On the VR logs below error msg is seen.
'Error I do not know what to do with file of type remoteaccessvpn'

I have file ticket 
CLOUDSTACK-8690https://issues.apache.org/jira/browse/CLOUDSTACK-8690. The 
remote access vpn feature is broken so I think it is blocker.


Thanks,
Jayapal




[GitHub] cloudstack pull request: Improve debug message when the scheduler ...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/676#issuecomment-129886755
  
Build failure not related to this change (cloudstack-pull-rats #256)

Code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/677#issuecomment-129886138
  
@milamberspace Ah, only now noticed you sent two pull requests ;-)

FYI: For 4.5, you can send a PR to master which we'll cherry-pick to 4.5. 
From 4.6 and on we'll be forward merging, so you'd send it to the release 
branch (which will be merged to master).

Long story short: I think you can close this one and let's merge the other 
one to master once it has 2xLGTM. We'll then bring it to 4.5 as well.

I'll move my LGTM to the other one ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/673#issuecomment-129925883
  
@anshul1886 Tested your code, works just fine! LGTM.

The only thing I noticed: excisting key/values are removed, then added 
again. So the net result is OK. It just inserts them again (the auto-increment 
goes up) but that wasn't introduced by your code as far as I can see.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/674#issuecomment-129902187
  
I see now unit tests for getUsedBytes() and creatAsync(), the methods you 
changed only a generic package org.apache.cloudstack.storage.test. Can you 
expand on how this code is tested, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Improve cloud-install-sys-tmplt to work i...

2015-08-11 Thread snuf
Github user snuf commented on the pull request:

https://github.com/apache/cloudstack/pull/678#issuecomment-129909452
  
lgtm, tested and uploads without the file there now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [Proposal] Minimise VR downtime during network update.

2015-08-11 Thread Bharat Kumar
Hi Daan,

I am not aware of  the work done for rVPC networks.  I am still in the POC 
stage, will update the FS or scope it down depending on 
the changes related to rvpc, If there are too many changes may be i will 
restrict this to non vpc networks.

I will create a apache ticket fro this work. 

Thanks,
Bharat.

On 11-Aug-2015, at 9:16 pm, Daan Hoogland daan.hoogl...@gmail.com wrote:

 Can you make a ticket on apache instead of referring an internal ticket?
 
 Can you describe how this work relates to the rvpc refactor work done for
 4.6?
 
 
 
 On Tue, Aug 11, 2015 at 5:41 PM, Bharat Kumar bharat.ku...@citrix.com
 wrote:
 
 Hi,
 
 Currently we use redundant virtual router enabled networks to prevent
 network outage even if one of the virtual router fails. This is achieved by
 using redundant virtual routers along with VRRP protocol. This has
 increased the network robustness. However  updating a network with new
 network offering involves some downtime due to Vr restarts. In case of
 redundant VR based networks we can sequence the network update operations
 to update the backup first and then update the master while master's
 operations are being handled by backup, this way i think we can minimise
 the downtime.
 
 link to FS.
 
 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61310469
 
 Please review the FS and give suggestion or comments.
 
 Thanks,
 Bharat.
 
 
 
 
 -- 
 Daan



exception messages added

2015-08-11 Thread Daan Hoogland
H,

CLOUDSTACK-8656 is not completely done with this pull request but I want to
rest this work for a while. I got comments (thanks) and made some changes
to adhere to peoples wishes.

Can I get LGTM now?

-- 
Daan


Re: [Proposal] Minimise VR downtime during network update.

2015-08-11 Thread Daan Hoogland
Can you make a ticket on apache instead of referring an internal ticket?

Can you describe how this work relates to the rvpc refactor work done for
4.6?



On Tue, Aug 11, 2015 at 5:41 PM, Bharat Kumar bharat.ku...@citrix.com
wrote:

 Hi,

 Currently we use redundant virtual router enabled networks to prevent
 network outage even if one of the virtual router fails. This is achieved by
 using redundant virtual routers along with VRRP protocol. This has
 increased the network robustness. However  updating a network with new
 network offering involves some downtime due to Vr restarts. In case of
 redundant VR based networks we can sequence the network update operations
 to update the backup first and then update the master while master's
 operations are being handled by backup, this way i think we can minimise
 the downtime.

 link to FS.

 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61310469

 Please review the FS and give suggestion or comments.

 Thanks,
 Bharat.




-- 
Daan


[GitHub] cloudstack pull request: Improve cloud-install-sys-tmplt to work i...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/678


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [Proposal] Minimise VR downtime during network update.

2015-08-11 Thread Daan Hoogland
Thanks Bharat,

One of the main implications of the rvpc refactor is that vpc routers and
normal VRs are greatly unified. If you are working with master you will
notice this.

happy sailing,


On Tue, Aug 11, 2015 at 5:57 PM, Bharat Kumar bharat.ku...@citrix.com
wrote:

 Hi Daan,

 I am not aware of  the work done for rVPC networks.  I am still in the POC
 stage, will update the FS or scope it down depending on
 the changes related to rvpc, If there are too many changes may be i will
 restrict this to non vpc networks.

 I will create a apache ticket fro this work.

 Thanks,
 Bharat.

 On 11-Aug-2015, at 9:16 pm, Daan Hoogland daan.hoogl...@gmail.com wrote:

  Can you make a ticket on apache instead of referring an internal ticket?
 
  Can you describe how this work relates to the rvpc refactor work done for
  4.6?
 
 
 
  On Tue, Aug 11, 2015 at 5:41 PM, Bharat Kumar bharat.ku...@citrix.com
  wrote:
 
  Hi,
 
  Currently we use redundant virtual router enabled networks to prevent
  network outage even if one of the virtual router fails. This is
 achieved by
  using redundant virtual routers along with VRRP protocol. This has
  increased the network robustness. However  updating a network with new
  network offering involves some downtime due to Vr restarts. In case of
  redundant VR based networks we can sequence the network update
 operations
  to update the backup first and then update the master while master's
  operations are being handled by backup, this way i think we can minimise
  the downtime.
 
  link to FS.
 
 
 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61310469
 
  Please review the FS and give suggestion or comments.
 
  Thanks,
  Bharat.
 
 
 
 
  --
  Daan




-- 
Daan


How about using drone.io for cloudstack bugs and test

2015-08-11 Thread Keerthiraja SJ
Hi

How about *Continuous Integration* for Github and Bitbucket that monitors
your code for bugs.

Kindly go through

I believe this is free for the Public Projects.

*https://drone.io/ https://drone.io/*

Thanks,
Keerthi


[Proposal] Minimise VR downtime during network update.

2015-08-11 Thread Bharat Kumar
Hi,

Currently we use redundant virtual router enabled networks to prevent network 
outage even if one of the virtual router fails. This is achieved by using 
redundant virtual routers along with VRRP protocol. This has increased the 
network robustness. However  updating a network with new network offering 
involves some downtime due to Vr restarts. In case of redundant VR based 
networks we can sequence the network update operations to update the backup 
first and then update the master while master's operations are being handled by 
backup, this way i think we can minimise the downtime.

link to FS.

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61310469

Please review the FS and give suggestion or comments.

Thanks,
Bharat.



Re: [Blocker/Critical] VR related Issues

2015-08-11 Thread Remi Bergsma
Hi Kishan,

Thanks for your mail, we clearly need to spend some time in debugging and 
fixing these issues. Let me look into the blocking Remote Access VPN issue 
(CLOUDSTACK-8690) and see if I can reproduce / fix it.

Regards,
Remi


 On 11 Aug 2015, at 11:33, Kishan Kavala kishan.kav...@citrix.com wrote:
 
 Below VR related issues currently open. Most of these issues did not exist in 
 4.5.x and are related to VR refactor (persistent VR).
 
 Blocker
 https://issues.apache.org/jira/browse/CLOUDSTACK-8690 - Remote Access VPN not 
 working
 
 Critical
 https://issues.apache.org/jira/browse/CLOUDSTACK-8688 - Default policy for 
 INPUT and FORWARD chain is ACCEPT in VR filter table (Wilder is working on 
 this) 
 https://issues.apache.org/jira/browse/CLOUDSTACK-8681 - CS does not honor the 
 default deny egress policy in isolated network
 https://issues.apache.org/jira/browse/CLOUDSTACK-8710 - site2site vpn 
 iptables rules are not configured on VR
 https://issues.apache.org/jira/browse/CLOUDSTACK-8685 - Default route is not 
 configured on VPC VR
 https://issues.apache.org/jira/browse/CLOUDSTACK-8694  - Monitor service cron 
 job not visible
 
 
 



[GitHub] cloudstack pull request: [WIP] Cloudstack 8656: do away with more ...

2015-08-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/654#discussion_r36763863
  
--- Diff: 
services/console-proxy/server/src/com/cloud/consoleproxy/vnc/packet/server/RawRect.java
 ---
@@ -50,26 +52,27 @@ public void paint(BufferedImage image, Graphics2D 
graphics) {
 
 switch (dataBuf.getDataType()) {
 
-case DataBuffer.TYPE_INT: {
-// We chose RGB888 model, so Raster will use DataBufferInt 
type
-DataBufferInt dataBuffer = (DataBufferInt)dataBuf;
+case DataBuffer.TYPE_INT: {
+// We chose RGB888 model, so Raster will use DataBufferInt type
+DataBufferInt dataBuffer = (DataBufferInt)dataBuf;
 
-int imageWidth = image.getWidth();
-int imageHeight = image.getHeight();
+int imageWidth = image.getWidth();
+int imageHeight = image.getHeight();
 
-// Paint rectangle directly on buffer, line by line
-int[] imageBuffer = dataBuffer.getData();
-for (int srcLine = 0, dstLine = y; srcLine  height  
dstLine  imageHeight; srcLine++, dstLine++) {
-try {
-System.arraycopy(buf, srcLine * width, 
imageBuffer, x + dstLine * imageWidth, width);
-} catch (IndexOutOfBoundsException e) {
-}
+// Paint rectangle directly on buffer, line by line
+int[] imageBuffer = dataBuffer.getData();
+for (int srcLine = 0, dstLine = y; srcLine  height  dstLine 
 imageHeight; srcLine++, dstLine++) {
+try {
+System.arraycopy(buf, srcLine * width, imageBuffer, x 
+ dstLine * imageWidth, width);
+} catch (IndexOutOfBoundsException e) {
+s_logger.info([ignored] buffer overflow!?!, e);
 }
-break;
 }
+break;
--- End diff --

So it seemed to me @mike-tutkowski . Is this a worry concerning this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/674#issuecomment-129974204
  
I have internal functional tests that make use of a SolidFire system.

On Tuesday, August 11, 2015, Daan Hoogland notificati...@github.com wrote:

 I see now unit tests for getUsedBytes() and creatAsync(), the methods you
 changed only a generic package org.apache.cloudstack.storage.test. Can you
 expand on how this code is tested, please?

 —
 Reply to this email directly or view it on GitHub
 https://github.com/apache/cloudstack/pull/674#issuecomment-129902187.



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

2015-08-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/654#issuecomment-129990097
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-11 Thread borisroman
GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/679

Added Virtualmachine count and ID's to listSecurityGroups response

See issue CLOUDSTACK-8133 for more information.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8133

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #679


commit f4449b62d93e56d9f62fac06922b12381a51b8e4
Author: Boris Schrijver bo...@pcextreme.nl
Date:   2015-08-11T17:01:38Z

CLOUDSTACK-8133 Added Virtualmachine count and ID's to listSecurityGroups 
response.

See issue CLOUDSTACK-8133 for more information.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

2015-08-11 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/654#discussion_r36774764
  
--- Diff: 
services/console-proxy/server/src/com/cloud/consoleproxy/vnc/packet/server/RawRect.java
 ---
@@ -50,26 +52,27 @@ public void paint(BufferedImage image, Graphics2D 
graphics) {
 
 switch (dataBuf.getDataType()) {
 
-case DataBuffer.TYPE_INT: {
-// We chose RGB888 model, so Raster will use DataBufferInt 
type
-DataBufferInt dataBuffer = (DataBufferInt)dataBuf;
+case DataBuffer.TYPE_INT: {
+// We chose RGB888 model, so Raster will use DataBufferInt type
+DataBufferInt dataBuffer = (DataBufferInt)dataBuf;
 
-int imageWidth = image.getWidth();
-int imageHeight = image.getHeight();
+int imageWidth = image.getWidth();
+int imageHeight = image.getHeight();
 
-// Paint rectangle directly on buffer, line by line
-int[] imageBuffer = dataBuffer.getData();
-for (int srcLine = 0, dstLine = y; srcLine  height  
dstLine  imageHeight; srcLine++, dstLine++) {
-try {
-System.arraycopy(buf, srcLine * width, 
imageBuffer, x + dstLine * imageWidth, width);
-} catch (IndexOutOfBoundsException e) {
-}
+// Paint rectangle directly on buffer, line by line
+int[] imageBuffer = dataBuffer.getData();
+for (int srcLine = 0, dstLine = y; srcLine  height  dstLine 
 imageHeight; srcLine++, dstLine++) {
+try {
+System.arraycopy(buf, srcLine * width, imageBuffer, x 
+ dstLine * imageWidth, width);
+} catch (IndexOutOfBoundsException e) {
+s_logger.info([ignored] buffer overflow!?!, e);
 }
-break;
 }
+break;
--- End diff --

I guess it's OK. It looks like it would fix a bug (the for loop would only 
execute at most once before).

If you're OK with it, I'm OK with it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request:

2015-08-11 Thread borisroman
Github user borisroman commented on the pull request:


https://github.com/apache/cloudstack/commit/f4449b62d93e56d9f62fac06922b12381a51b8e4#commitcomment-12645845
  
The re-positioning of the imports is an automated feature of Eclipse.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Remi Bergsma joins the PMC

2015-08-11 Thread Remi Bergsma
Thanks everyone! Great working with you :-)

 On 11 Aug 2015, at 07:44, Wilder Rodrigues wrodrig...@schubergphilis.com 
 wrote:
 
 Congratulations, dude!
 
 Cheers,
 Wilder
 
 Sent from my iPhone
 
 On 10 Aug 2015, at 19:09, Daan Hoogland daan.hoogl...@gmail.com wrote:
 
 LS,
 
 Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
 that he accepted. Please join me in congratulating Remi.
 
 ​regards,​
 -- 
 Daan


[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/674#issuecomment-130091528
  
Code lgtm. can you publish the tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Coverity regressions per 10 aug 2015

2015-08-11 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/681

Coverity regressions per 10 aug 2015

Not all are in here, the db upgrade code seems to stay the main pitfall.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack coverity-regressions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #681


commit a3ae8e064556cbb1786092da2f2921f30c694aaa
Author: Daan Hoogland d...@onecht.net
Date:   2015-08-11T23:04:06Z

coverity 1315774: improvement of code to negate false positive

commit 1ab3b9659475e8c9f02954d9f47ac1c5a8636e25
Author: Daan Hoogland d...@onecht.net
Date:   2015-08-11T23:10:31Z

coverity 1315775: proper getting of networkLabel




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[Low Priority] Resource method names

2015-08-11 Thread Mike Tutkowski
I like these names. :)

public long findCorrectResourceLimitForAccount(Account account,
ResourceType type);

public long findCorrectResourceLimitForAccount(long accountId, Long limit,
ResourceType type);

public long findCorrectResourceLimitForDomain(Domain domain, ResourceType
type);
What if I was looking for an incorrect resource limit, though? I don't see
such methods. ;)

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


[GitHub] cloudstack pull request: Coverity regressions per 10 aug 2015

2015-08-11 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/681#issuecomment-130167859
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [Proposal] Replacing Openswan ipsec with Strongswan ipsec

2015-08-11 Thread Rohit Yadav
Jayapal - great and looking forward to it.

As a test case, I would hope that with strongswan it would be possible to use 
both Mac and Windows VPN clients which was an issue with openswan - 
https://issues.apache.org/jira/browse/CLOUDSTACK-7087

On 12-Aug-2015, at 10:29 am, Jayapal Reddy Uradi 
jayapalreddy.ur...@citrix.commailto:jayapalreddy.ur...@citrix.com wrote:

Here is the FS[1] and ticket[2] details.

[1]https://cwiki.apache.org/confluence/display/CLOUDSTACK/Replacing+openswan+ipsec+with+strongswan+ipsec
[2]https://issues.apache.org/jira/browse/CLOUDSTACK-8682


Thanks,
Jayapal

On 27-Jul-2015, at 12:12 PM, Suresh Sadhu 
suresh.sa...@citrix.commailto:suresh.sa...@citrix.com wrote:

+1

Kindly share any practical limitation or any know issues exists in strong 
swan[if anybody using this protocol  in real time ,please share  your 
experience ]...  that will really helpful us(both dev and qa) to design ,code 
and test this feature in a better way.


Regards
Sadhu



-Original Message-
From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
Sent: 24 July 2015 17:40
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: [Proposal] Replacing Openswan ipsec with Strongswan ipsec

Hi All,

Openswan is not being actively maintained by community.
Any security updates to the packages then it is difficult to upgrade.
latest version of OS X clients are not working on openswan.

To address the above concerns I am proposing to move from openswan ipsec to 
strongswan ipsec.

I will be sharing the FS for this feature soon.

Thanks,
Jayapal




Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com
Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design  Buildhttp://shapeblue.com/iaas-cloud-design-and-build//
CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
CloudStack Software 
Engineeringhttp://shapeblue.com/cloudstack-software-engineering/
CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/
CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.


[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-11 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/679#discussion_r36827811
  
--- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 
---
@@ -125,6 +130,14 @@ public SecurityGroupResponse 
newSecurityGroupResponse(SecurityGroupJoinVO vsg, A
 }
 }
 
+ListSecurityGroupVMMapVO securityGroupVmMap = 
_securityGroupVMMapDao.listBySecurityGroup(vsg.getId());
+s_logger.debug(newSecurityGroupResponse() - virtualmachine 
count:  + securityGroupVmMap.size());
+sgResponse.setVirtualMachineCount(securityGroupVmMap.size());
+
+for(SecurityGroupVMMapVO securityGroupVMMapVO : 
securityGroupVmMap) {
+
sgResponse.addVirtualMachineId(_userVmDao.findById(securityGroupVMMapVO.getInstanceId()).getUuid());
--- End diff --

Add a check that findById is not returning null. There is a possibility 
that VM may get deleted after the call to listBySecurityGroup() but before that 
map entry is processed in the for-loop. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-11 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/679#issuecomment-130175830
  
Please add tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [Proposal] Replacing Openswan ipsec with Strongswan ipsec

2015-08-11 Thread Jayapal Reddy Uradi
Here is the FS[1] and ticket[2] details.

[1]https://cwiki.apache.org/confluence/display/CLOUDSTACK/Replacing+openswan+ipsec+with+strongswan+ipsec
[2]https://issues.apache.org/jira/browse/CLOUDSTACK-8682


Thanks,
Jayapal

On 27-Jul-2015, at 12:12 PM, Suresh Sadhu suresh.sa...@citrix.com wrote:

 +1 
 
 Kindly share any practical limitation or any know issues exists in strong 
 swan[if anybody using this protocol  in real time ,please share  your 
 experience ]...  that will really helpful us(both dev and qa) to design ,code 
 and test this feature in a better way.
 
 
 Regards
 Sadhu
 
 
 
 -Original Message-
 From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] 
 Sent: 24 July 2015 17:40
 To: dev@cloudstack.apache.org
 Subject: [Proposal] Replacing Openswan ipsec with Strongswan ipsec
 
 Hi All,
 
 Openswan is not being actively maintained by community.
 Any security updates to the packages then it is difficult to upgrade.
 latest version of OS X clients are not working on openswan.
 
 To address the above concerns I am proposing to move from openswan ipsec to 
 strongswan ipsec.
 
 I will be sharing the FS for this feature soon.
 
 Thanks,
 Jayapal
 
 



Re: [Blocker/Critical] VR related Issues

2015-08-11 Thread Bharat Kumar
Hi,

looks like  there is  one more issue. Conntrackd fails to start in case of rvr 
enabled isolated networks.
created a bug to track this. 
https://issues.apache.org/jira/browse/CLOUDSTACK-8725

Thanks,
Bharat.

On 11-Aug-2015, at 3:03 pm, Kishan Kavala 
kishan.kav...@citrix.commailto:kishan.kav...@citrix.com wrote:

Below VR related issues currently open. Most of these issues did not exist in 
4.5.x and are related to VR refactor (persistent VR).

Blocker
https://issues.apache.org/jira/browse/CLOUDSTACK-8690 - Remote Access VPN not 
working

Critical
https://issues.apache.org/jira/browse/CLOUDSTACK-8688 - Default policy for 
INPUT and FORWARD chain is ACCEPT in VR filter table (Wilder is working on this)
https://issues.apache.org/jira/browse/CLOUDSTACK-8681 - CS does not honor the 
default deny egress policy in isolated network
https://issues.apache.org/jira/browse/CLOUDSTACK-8710 - site2site vpn iptables 
rules are not configured on VR
https://issues.apache.org/jira/browse/CLOUDSTACK-8685 - Default route is not 
configured on VPC VR
https://issues.apache.org/jira/browse/CLOUDSTACK-8694  - Monitor service cron 
job not visible