[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/680#discussion_r36865162
--- Diff: ui/scripts/instances.js ---
@@ -618,11 +618,11 @@
createForm: {
title: 'label.action.destroy.instance',
desc: 'label.action.destroy.instance',
-isWarning: true,
+isWarning: true,
preFilter: function(args) {
-if (isAdmin() || isDomainAdmin()) {
-
args.$form.find('.form-item[rel=expunge]').css('display', 'inline-block');
-} else {
+// Hide the expunge checkbox when the
authenticated user
+// can't expunge VMs. Related to
CLOUDSTACK-8580.
--- End diff --
I think the var name is explanatory. the comment could go with allocation
and not use of the thingy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/680#discussion_r36865186
--- Diff: ui/scripts/instances.js ---
@@ -2425,11 +2425,15 @@
var allowedActions = [];
if (jsonObj.state == 'Destroyed') {
-if (isAdmin() || isDomainAdmin()) {
+// Display expunge and recover action when authenticated user
+// is allowed to expunge or recover VMs. Related to
CLOUDSTACK-8580.
--- End diff --
see comment at line 624
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/680#discussion_r36865220
--- Diff: ui/scripts/instances.js ---
@@ -2498,8 +2502,11 @@
} else if (jsonObj.state == 'Error') {
allowedActions.push(destroy);
} else if (jsonObj.state == 'Expunging') {
-if (isAdmin() || isDomainAdmin())
+// Display expunge action when authenticated user
+// is allowed to expunge VMs. Related to CLOUDSTACK-8580.
+if (g_allowUserExpungeRecoverVm) {
--- End diff --
see commetn at line 624
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-130321431 please comment on testing the stuff, for instance ref unit - or integration tests that cover the code in the PR description/comment or, alternatively add unit tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Release EC2stack 1.0.0
On Aug 12, 2015, at 12:31 PM, sebgoa run...@gmail.com wrote: Hi folks, I am working towards making a release of EC2stack. Since it was given to our project we have not made an official release. I just added a few documentation files, added license headers, notice files, copied over the release script from cloud monkey. Plus a few other odds and ins. I don't plan to do any changes to the actual code for now, but I would like to make a 1.0.0 release and then start patching. How do people feel about this ? Has anyone used it lately with 4.5.x releases ? finally, any help to get the Travis runs working again would be good, matter of changing the links I think. FWIW, I fixed the Travis build , we are green :) https://github.com/apache/cloudstack-ec2stack feedback welcome, otherwise I will just cut a release and send a vote thread. cheers, -Sebastien
Build failed in Jenkins: build-master-slowbuild #2043
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2043/changes Changes: [mike.tutkowski] getUsedBytes should query the SolidFire cluster to acquire the size of the given volume if there is no volume_details info for that volume (and then create a volume_details row for this volume so we don't have to make that cluster call for this purpose again) -- [...truncated 27471 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-quickcloud [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-quickcloud [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-quickcloud --- [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-quickcloud --- [WARNING] No files to instrument. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-quickcloud --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/quickcloud/src/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-quickcloud [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-quickcloud --- [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [1.732s] [INFO] Apache CloudStack . SUCCESS [2.348s] [INFO] Apache CloudStack Maven Conventions Parent SUCCESS [0.773s] [INFO] Apache CloudStack Framework - Managed Context . SUCCESS [21.035s] [INFO] Apache CloudStack Utils ... SUCCESS [1:14.789s] [INFO] Apache CloudStack Framework ... SUCCESS [0.106s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.512s] [INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.677s] [INFO] Apache CloudStack API . SUCCESS [1:50.606s] [INFO] Apache CloudStack Framework - REST SUCCESS [17.287s] [INFO] Apache CloudStack Framework - IPC . SUCCESS [31.079s] [INFO] Apache CloudStack Cloud Engine SUCCESS [0.101s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [27.039s] [INFO] Apache CloudStack Framework - Security SUCCESS [24.513s] [INFO] Apache CloudStack Core SUCCESS [1:15.525s] [INFO] Apache CloudStack Agents .. SUCCESS [35.338s] [INFO] Apache CloudStack Framework - Clustering .. SUCCESS [33.101s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.208s] [INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:06.026s] [INFO] Apache CloudStack Framework - Jobs SUCCESS [40.081s] [INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [24.659s] [INFO] Apache CloudStack Server .. SUCCESS [4:01.670s] [INFO] Apache CloudStack Usage Server SUCCESS [44.044s] [INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [1:28.074s] [INFO] Apache CloudStack Cloud Services .. SUCCESS [0.073s] [INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.445s] [INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.574s] [INFO] Apache CloudStack Engine Storage Component SUCCESS [46.043s] [INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.031s] [INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.080s] [INFO] Apache CloudStack Engine Storage Data Motion Component SUCCESS [22.068s] [INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.916s] [INFO] Apache CloudStack Engine Storage Snapshot Component SUCCESS [34.702s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [12.886s] [INFO] Apache CloudStack Cloud Engine Service SUCCESS [5.891s] [INFO] Apache CloudStack Plugin POM .. SUCCESS [0.789s] [INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [25.669s] [INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [23.135s] [INFO]
Re: Release EC2stack 1.0.0
Hey Sebastien, Thank you for doing this. If there's any small jobs I can help out let me know, I'm allowed to work on this type of stuff again once Friday the 14th passes. On Wednesday, August 12, 2015, sebgoa run...@gmail.com wrote: On Aug 12, 2015, at 12:31 PM, sebgoa run...@gmail.com javascript:; wrote: Hi folks, I am working towards making a release of EC2stack. Since it was given to our project we have not made an official release. I just added a few documentation files, added license headers, notice files, copied over the release script from cloud monkey. Plus a few other odds and ins. I don't plan to do any changes to the actual code for now, but I would like to make a 1.0.0 release and then start patching. How do people feel about this ? Has anyone used it lately with 4.5.x releases ? finally, any help to get the Travis runs working again would be good, matter of changing the links I think. FWIW, I fixed the Travis build , we are green :) https://github.com/apache/cloudstack-ec2stack feedback welcome, otherwise I will just cut a release and send a vote thread. cheers, -Sebastien
Build failed in Jenkins: build-master-slowbuild #2044
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2044/ -- [...truncated 27471 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-quickcloud [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-quickcloud [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-quickcloud --- [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-quickcloud --- [WARNING] No files to instrument. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-quickcloud --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/quickcloud/src/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-quickcloud [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-quickcloud --- [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [1.845s] [INFO] Apache CloudStack . SUCCESS [2.308s] [INFO] Apache CloudStack Maven Conventions Parent SUCCESS [0.794s] [INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.469s] [INFO] Apache CloudStack Utils ... SUCCESS [1:13.743s] [INFO] Apache CloudStack Framework ... SUCCESS [0.112s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.308s] [INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.641s] [INFO] Apache CloudStack API . SUCCESS [1:49.042s] [INFO] Apache CloudStack Framework - REST SUCCESS [15.450s] [INFO] Apache CloudStack Framework - IPC . SUCCESS [31.410s] [INFO] Apache CloudStack Cloud Engine SUCCESS [0.087s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [27.714s] [INFO] Apache CloudStack Framework - Security SUCCESS [25.813s] [INFO] Apache CloudStack Core SUCCESS [1:17.330s] [INFO] Apache CloudStack Agents .. SUCCESS [34.681s] [INFO] Apache CloudStack Framework - Clustering .. SUCCESS [32.605s] [INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [15.064s] [INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.195s] [INFO] Apache CloudStack Framework - Jobs SUCCESS [41.103s] [INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [24.687s] [INFO] Apache CloudStack Server .. SUCCESS [3:58.726s] [INFO] Apache CloudStack Usage Server SUCCESS [43.778s] [INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [1:25.771s] [INFO] Apache CloudStack Cloud Services .. SUCCESS [0.092s] [INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.463s] [INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [56.919s] [INFO] Apache CloudStack Engine Storage Component SUCCESS [47.903s] [INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.232s] [INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.520s] [INFO] Apache CloudStack Engine Storage Data Motion Component SUCCESS [31.002s] [INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.572s] [INFO] Apache CloudStack Engine Storage Snapshot Component SUCCESS [33.764s] [INFO] Apache CloudStack Cloud Engine API SUCCESS [12.374s] [INFO] Apache CloudStack Cloud Engine Service SUCCESS [6.874s] [INFO] Apache CloudStack Plugin POM .. SUCCESS [0.794s] [INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [25.771s] [INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [23.902s] [INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider SUCCESS [35.919s] [INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.335s] [INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [22.800s] [INFO] Apache CloudStack Plugin - ACL Static Role Based ..
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130526955 It doesn't like this line: long lVolumeId = Long.valueOf(volume.getFolder()); The folder column is a string, but it's storing a long for me (the ID of a SolidFire volume). Is there another way I should convert the value so the slow build will be OK with this? Thanks! On Wed, Aug 12, 2015 at 9:58 PM, Rajani Karuturi notificati...@github.com wrote: @mike-tutkowski https://github.com/mike-tutkowski master slow build failed as this commit introduced a new findbugs issues. Can you please take a look? http://jenkins.buildacloud.org/job/build-master-slowbuild/2045/findbugsResult/new/ â Reply to this email directly or view it on GitHub https://github.com/apache/cloudstack/pull/674#issuecomment-130523246. -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*â¢* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130535316 OK, but - ultimately - I do want to convert it to a primitive long. On Wed, Aug 12, 2015 at 10:50 PM, Rajani Karuturi notificati...@github.com wrote: valueOf returns a new Long() where as parseLong returns primitive long. valueOf causes unboxing as what is required is a primitive long. Using parseLong will satisfy findbugs I think. â Reply to this email directly or view it on GitHub https://github.com/apache/cloudstack/pull/674#issuecomment-130535022. -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*â¢* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
I'm not sure what the protocol is on this, so I just went ahead and checked in the code to fix the FindBugs issue and noted the PR (674) it is related to. Here is the commit: 8fcc76e On Wed, Aug 12, 2015 at 10:55 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Oh, I read what you wrote wrong. OK - thanks. On Wed, Aug 12, 2015 at 10:54 PM, mike-tutkowski g...@git.apache.org wrote: Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130535316 OK, but - ultimately - I do want to convert it to a primitive long. On Wed, Aug 12, 2015 at 10:50 PM, Rajani Karuturi notificati...@github.com wrote: valueOf returns a new Long() where as parseLong returns primitive long. valueOf causes unboxing as what is required is a primitive long. Using parseLong will satisfy findbugs I think. — Reply to this email directly or view it on GitHub https://github.com/apache/cloudstack/pull/674#issuecomment-130535022. -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™*
[GitHub] cloudstack pull request: verify that when createTemplate is ued to...
Github user manasaveloori commented on the pull request: https://github.com/apache/cloudstack/pull/688#issuecomment-130540793 Test when createTemplate is used to create templates having the same name all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status : SUCCESS === ok -- Ran 1 test in 442.896s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/683#discussion_r36940905 --- Diff: test/integration/component/test_simultaneous_volume_attach.py --- @@ -0,0 +1,256 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +#Import Local Modules +from marvin.cloudstackAPI import * +from marvin.cloudstackTestCase import cloudstackTestCase, unittest +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (ServiceOffering, + VirtualMachine, + Account, + Volume, + DiskOffering, + ) +from marvin.lib.common import (get_domain, +get_zone, +get_template, +find_storage_pool_type) +from marvin.codes import ( +PASS, +FAILED, +JOB_FAILED, +JOB_CANCELLED, +JOB_SUCCEEDED +) +from nose.plugins.attrib import attr +import time + + +class TestMultipleVolumeAttach(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +testClient = super(TestMultipleVolumeAttach, cls).getClsTestClient() +cls.apiclient = testClient.getApiClient() +cls.services = testClient.getParsedTestDataConfig() +cls._cleanup = [] +# Get Zone, Domain and templates +cls.domain = get_domain(cls.apiclient) +cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests()) +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = testClient.getHypervisorInfo() +cls.invalidStoragePoolType = False +#for LXC if the storage pool of type 'rbd' ex: ceph is not available, skip the test +if cls.hypervisor.lower() == 'lxc': +if not find_storage_pool_type(cls.apiclient, storagetype='rbd'): +# RBD storage type is required for data volumes for LXC +cls.invalidStoragePoolType = True +return +cls.disk_offering = DiskOffering.create( +cls.apiclient, +cls.services[disk_offering] +) + +template = get_template( +cls.apiclient, +cls.zone.id, +cls.services[ostype] +) +if template == FAILED: +assert False, get_template() failed to return template with description %s % cls.services[ostype] + +cls.services[domainid] = cls.domain.id +cls.services[zoneid] = cls.zone.id +cls.services[template] = template.id +cls.services[diskofferingid] = cls.disk_offering.id + +# Create VMs, VMs etc +cls.account = Account.create( +cls.apiclient, +cls.services[account], +domainid=cls.domain.id +) +cls.service_offering = ServiceOffering.create( +cls.apiclient, + cls.services[service_offering] +) +cls.virtual_machine = VirtualMachine.create( +cls.apiclient, +cls.services, +accountid=cls.account.name, +domainid=cls.account.domainid, + serviceofferingid=cls.service_offering.id, +mode=cls.services[mode] +) + +if
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130523246 @mike-tutkowski master slow build failed as this commit introduced a new findbugs issues. Can you please take a look? http://jenkins.buildacloud.org/job/build-master-slowbuild/2045/findbugsResult/new/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-130539282 @kishankavala The current implementation of the createSSHKeyPair checks for the keypair-name in the table ssh_keypairs and if that name exists it will return A keypair with the name exists. But at the time of inserting the keypairs it will not insert the same key once again because of the UNIQUE constraint that is added in the above commit. So In a way the duplication problem is automatically checked. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: verify that when createTemplate is ued to...
GitHub user manasaveloori opened a pull request: https://github.com/apache/cloudstack/pull/688 verify that when createTemplate is ued to create templates with same ⦠â¦name, all of them fet unique_name under vm_template table so that templates with same name does not get deleted during template sync You can merge this pull request into a Git repository by running: $ git pull https://github.com/manasaveloori/cloudstack Test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/688.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #688 commit ab8b2af13cfb93458e77102b4177ffa3e86df146 Author: manasaVeloori manasa1...@gmail.com Date: 2015-08-13T05:26:18Z verify that when createTemplate is ued to create templates with same name, all of them fet unique_name under vm_template table so that templates with same name does not get deleted during template sync --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130535022 valueOf returns a new Long() where as parseLong returns primitive long. valueOf causes unboxing as what is required is a primitive long. Using parseLong will satisfy findbugs I think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user kansal commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36940851 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed` ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_speed`.`name` = 'CpuSpeed'))) left join `cloud`.`user_vm_details` `custom_ram_size` ON (((`custom_ram_size`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory'))); +delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id s2.id and s1.public_key = s2.public_key; --- End diff -- @sedukull there are no constraints which refer to ssh_keypairs as the foreign key. Yes there are foreign key constraints on the columns of ssh_keypairs, but deleteing them won't create any problem as they are not referenced further. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130536383 I think I confused you :). Since what is required is primitive long, findbugs wants you to use parseLong instead of valueOf(which returns Long object) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130536522 No, what you said made perfect sense. :) I just read it incorrectly at first. On Wed, Aug 12, 2015 at 11:02 PM, Rajani Karuturi notificati...@github.com wrote: I think I confused you :). Since what is required is primitive long, findbugs wants you to use parseLong instead of valueOf(which returns Long object) â Reply to this email directly or view it on GitHub https://github.com/apache/cloudstack/pull/674#issuecomment-130536383. -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*â¢* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130536491 BTW, I just noticed, this PR is missing jira issue. It would be good to have one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130536585 No, what you said made perfect sense. :) I just read it incorrectly at first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Low Priority] Resource method names
:) ~Rajani On Wed, Aug 12, 2015 at 5:11 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I like these names. :) public long findCorrectResourceLimitForAccount(Account account, ResourceType type); public long findCorrectResourceLimitForAccount(long accountId, Long limit, ResourceType type); public long findCorrectResourceLimitForDomain(Domain domain, ResourceType type); What if I was looking for an incorrect resource limit, though? I don't see such methods. ;) -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™*
[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-130219642 open for review, tests added; cc @abhinandanprateek @remibergsma @wilderrodrigues @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Coverity regressions per 10 aug 2015
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/681#issuecomment-130186820 Thanks for fixing these @DaanHoogland. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130186688 code lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/677#issuecomment-130187847 Ok thanks for your comment. I close this PR. I will cherry-pick the PR #676 on the 4.5 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...
Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/677 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36832023
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
copy
todir=${basedir}/target/generated-webapp/WEB-INF/classes/scripts
fileset dir=${basedir}/../scripts/
/copy
+copy
todir=${basedir}/target/generated-webapp/WEB-INF/classes/systemvm/js
--- End diff --
Do we have any unit-tests added for this change? As well, if we possible,
can we have a document for the console proxy workflow available on wiki ? This
may help people to know the exact workflow or class interactions with business
flow.
As well, a small change to this request message Made the adding new
keyboard language support easier could be beneficial i believe, helps people
to know the complete context for this change.
Note :this is not specific to this line, but a generic note.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36833745
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
copy
todir=${basedir}/target/generated-webapp/WEB-INF/classes/scripts
fileset dir=${basedir}/../scripts/
/copy
+copy
todir=${basedir}/target/generated-webapp/WEB-INF/classes/systemvm/js
--- End diff --
FS
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy
has details regarding console proxy workflow which is present in description.
In developer setup these files are always present so adding unit test for
certain (which will always pass) thing doesn't make sense to me. In my opinion
unit test are meant to test corner cases or some uncertainty.
I will try to improve description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
RE: [Low Priority] Resource method names
Please send out a PR with the fix. -Original Message- From: Rajani Karuturi [mailto:raj...@apache.org] Sent: Wednesday, 12 August 2015 12:02 To: dev@cloudstack.apache.org Subject: Re: [Low Priority] Resource method names :) ~Rajani On Wed, Aug 12, 2015 at 5:11 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I like these names. :) public long findCorrectResourceLimitForAccount(Account account, ResourceType type); public long findCorrectResourceLimitForAccount(long accountId, Long limit, ResourceType type); public long findCorrectResourceLimitForDomain(Domain domain, ResourceType type); What if I was looking for an incorrect resource limit, though? I don't see such methods. ;) -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™*
[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-130232580 @wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes related to #593. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Some KVM fixes
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/682 Some KVM fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack kvm-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/682.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #682 commit 14797e9da30a50f1ceeb67d72096843e22d5748a Author: John Burwell john.burw...@shapeblue.com Date: 2015-07-21T19:36:01Z CLOUDSTACK-8566: Strips the username and password credentials from host details ... map returned by the following API calls by filtering these fields from the details attribute in the HostResponse class: * listHosts * addHost * cancelHostMaintenance * listHosts * prepareHostForMaintenance * reconnectHost * updateHost This fix addresses CVE 2015-3251. Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/683#discussion_r36845173 --- Diff: test/integration/component/test_simultaneous_volume_attach.py --- @@ -0,0 +1,264 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +#Import Local Modules +from marvin.cloudstackAPI import * +from marvin.cloudstackTestCase import cloudstackTestCase, unittest +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (ServiceOffering, + VirtualMachine, + Account, + Volume, + DiskOffering, + ) +from marvin.lib.common import (get_domain, +get_zone, +get_template, +find_storage_pool_type) +from marvin.codes import ( +PASS, +FAILED, +JOB_FAILED, +JOB_CANCELLED, +JOB_SUCCEEDED +) +from nose.plugins.attrib import attr +import time + + +class TestMultipleVolumeAttach(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +testClient = super(TestMultipleVolumeAttach, cls).getClsTestClient() +cls.apiclient = testClient.getApiClient() +cls.services = testClient.getParsedTestDataConfig() +cls._cleanup = [] +# Get Zone, Domain and templates +cls.domain = get_domain(cls.apiclient) +cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests()) +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = testClient.getHypervisorInfo() +cls.invalidStoragePoolType = False +#for LXC if the storage pool of type 'rbd' ex: ceph is not available, skip the test +if cls.hypervisor.lower() == 'lxc': +if not find_storage_pool_type(cls.apiclient, storagetype='rbd'): +# RBD storage type is required for data volumes for LXC +cls.invalidStoragePoolType = True +return +cls.disk_offering = DiskOffering.create( +cls.apiclient, +cls.services[disk_offering] +) + +template = get_template( +cls.apiclient, +cls.zone.id, +cls.services[ostype] +) +if template == FAILED: +assert False, get_template() failed to return template with description %s % cls.services[ostype] + +cls.services[domainid] = cls.domain.id +cls.services[zoneid] = cls.zone.id +cls.services[template] = template.id +cls.services[diskofferingid] = cls.disk_offering.id + +# Create VMs, VMs etc +cls.account = Account.create( +cls.apiclient, +cls.services[account], +domainid=cls.domain.id +) +cls.service_offering = ServiceOffering.create( +cls.apiclient, + cls.services[service_offering] +) +cls.virtual_machine = VirtualMachine.create( +cls.apiclient, +cls.services, +accountid=cls.account.name, +domainid=cls.account.domainid, + serviceofferingid=cls.service_offering.id, +mode=cls.services[mode] +) + +if
[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...
GitHub user pavanb018 opened a pull request: https://github.com/apache/cloudstack/pull/683 CLOUDSTACK-8726 : Automation for Quickly attaching multiple data disks to a new VM Attach multiple Volumes simultaneously to a Running VM ... === TestName: test_attach_multiple_volumes | Status : SUCCESS === ok -- Ran 1 test in 196.931s OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/pavanb018/cloudstack multivol Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/683.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #683 commit 6e96c658a81cf86cbd01ca08368b2a29ffc51000 Author: pavan018 pavanbandarupa...@gmail.com Date: 2015-08-12T09:52:19Z Automation for multiple disk attachments to instance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/683#discussion_r36845123 --- Diff: test/integration/component/test_simultaneous_volume_attach.py --- @@ -0,0 +1,264 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +#Import Local Modules +from marvin.cloudstackAPI import * +from marvin.cloudstackTestCase import cloudstackTestCase, unittest +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (ServiceOffering, + VirtualMachine, + Account, + Volume, + DiskOffering, + ) +from marvin.lib.common import (get_domain, +get_zone, +get_template, +find_storage_pool_type) +from marvin.codes import ( +PASS, +FAILED, +JOB_FAILED, +JOB_CANCELLED, +JOB_SUCCEEDED +) +from nose.plugins.attrib import attr +import time + + +class TestMultipleVolumeAttach(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +testClient = super(TestMultipleVolumeAttach, cls).getClsTestClient() +cls.apiclient = testClient.getApiClient() +cls.services = testClient.getParsedTestDataConfig() +cls._cleanup = [] +# Get Zone, Domain and templates +cls.domain = get_domain(cls.apiclient) +cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests()) +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = testClient.getHypervisorInfo() +cls.invalidStoragePoolType = False +#for LXC if the storage pool of type 'rbd' ex: ceph is not available, skip the test +if cls.hypervisor.lower() == 'lxc': +if not find_storage_pool_type(cls.apiclient, storagetype='rbd'): +# RBD storage type is required for data volumes for LXC +cls.invalidStoragePoolType = True +return +cls.disk_offering = DiskOffering.create( +cls.apiclient, +cls.services[disk_offering] +) + +template = get_template( +cls.apiclient, +cls.zone.id, +cls.services[ostype] +) +if template == FAILED: +assert False, get_template() failed to return template with description %s % cls.services[ostype] + +cls.services[domainid] = cls.domain.id +cls.services[zoneid] = cls.zone.id +cls.services[template] = template.id +cls.services[diskofferingid] = cls.disk_offering.id + +# Create VMs, VMs etc +cls.account = Account.create( +cls.apiclient, +cls.services[account], +domainid=cls.domain.id +) +cls.service_offering = ServiceOffering.create( +cls.apiclient, + cls.services[service_offering] +) +cls.virtual_machine = VirtualMachine.create( +cls.apiclient, +cls.services, +accountid=cls.account.name, +domainid=cls.account.domainid, + serviceofferingid=cls.service_offering.id, +mode=cls.services[mode] +) + +if
[GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36839282
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
copy
todir=${basedir}/target/generated-webapp/WEB-INF/classes/scripts
fileset dir=${basedir}/../scripts/
/copy
+copy
todir=${basedir}/target/generated-webapp/WEB-INF/classes/systemvm/js
--- End diff --
Thanks for the FS link, it was helpful. Regarding the unit test, i would
disagree to say that they are meant to test corner cases. Not sure, what it
doesnt make sense to you. In general, unit test purpose is not what you meant,
in this commit, if we see we modified near to 28 code files, added new classes
and code, it makes sense to have unit tests for the added code. It will help
to test the code units and individual functional blocks during build, these
areas not always are touched by functional tests. It adds to the coverage, make
sure code modified down the lane adheres to the contract through failures in
tests etc. Its appreciated, if we can have few unit tests added to this, right
now they are zero tests for this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Some KVM fixes
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130231279 @wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes related to https://github.com/apache/cloudstack/pull/593. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-8427] Add missing localizatio...
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/686 [CLOUDSTACK-8427] Add missing localization for some labels in Web UI - on new functionnality: upload volume/template from Local - on the zone configuration wizard for the Next button - update French messages properties from transifex - Improve some French translations (Téléverser for Upload) You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace/cloudstack MissingSomesL10N Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/686.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #686 commit 4be622e4ffa71c03f75c4f5671c9600deed9ac4b Author: Milamber milam...@apache.org Date: 2015-08-12T16:30:15Z Add missing localization for some labels in Web UI - on new functionnality: upload volume/template from Local - on the zone configuration wizard for the Next button - update French messages properties from transifex - Improve some French translations (Téléverser for Upload) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36857039 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed` ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_speed`.`name` = 'CpuSpeed'))) left join `cloud`.`user_vm_details` `custom_ram_size` ON (((`custom_ram_size`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory'))); +delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id s2.id and s1.public_key = s2.public_key; --- End diff -- It seems ssh_keypairs table, has foreign key constraints with cascading delete logic, as per table definition. Will these delete statements effect the rows in other tables say account and domain? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/684 CLOUDSTACK-8728: Testcase to Verify if VRs IP Testcase to check if VR's IP changes if it is destroyed and re-created in basic zone. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-8728-Testcase-to-Verify-if-VRs-IP-changes-if-it-is-destroyed-and-re-created-in-Basic-Zone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/684.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #684 commit ea0d5ca141c3b73f212be37953b96b823b179600 Author: Priti Sarap priti.sa...@clogeny.com Date: 2015-08-12T11:58:04Z CLOUDSTACK:8728-Testcase to Verify if VRs IP changes if it is destroyed and re created in Basic Zone --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/685 CLOUDSTACK-8727: API call listVirtualMachines returns same keypair Currently the user can register same key with different names. Upon listing the VM's the name which got registered first is being returned and not the actual one. Anyhow this behavior is rare and not good. I have added a UNIQUE constraint on the ssh_keypairs table and also made sure that the previous registered keys(with duplicates) get deleted. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kansal/cloudstack CLOUDSTACK-8727 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/685.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #685 commit ee45f299f4df9b51ba3c530a9770392780a33dd5 Author: Kshitij Kansal kshitij.kan...@citrix.com Date: 2015-08-12T12:07:48Z CLOUDSTACK-8727: API call listVirtualMachines returns same keypair --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36855234 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed` ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_speed`.`name` = 'CpuSpeed'))) left join `cloud`.`user_vm_details` `custom_ram_size` ON (((`custom_ram_size`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory'))); +delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id s2.id and s1.public_key = s2.public_key; --- End diff -- I believe, its an api change required rather adding the constraint at the db level, otherwise it will mask the actual issue in the code where these duplicates are getting added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36856027 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed` ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_speed`.`name` = 'CpuSpeed'))) left join `cloud`.`user_vm_details` `custom_ram_size` ON (((`custom_ram_size`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory'))); +delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id s2.id and s1.public_key = s2.public_key; +ALTER TABLE ssh_keypairs ADD UNIQUE (fingerprint); --- End diff -- @sedukull It was said they should be announced on the ML and that they occur on .0 releases only unless it is a bugfix. please take it on list, though. It will never hurt. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...
Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/684#issuecomment-130273467 Testcase result: Check if Virtual Router has same IP after network restart or not. ... === TestName: test_01_vr_has_same_ip | Status : SUCCESS === ok -- Ran 1 test in 245.730s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-130282420 @kansal Can you add a similar check for duplicates keys in the createSSHKeyPair API validation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36855422 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed` ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_speed`.`name` = 'CpuSpeed'))) left join `cloud`.`user_vm_details` `custom_ram_size` ON (((`custom_ram_size`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory'))); +delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id s2.id and s1.public_key = s2.public_key; +ALTER TABLE ssh_keypairs ADD UNIQUE (fingerprint); --- End diff -- Here, we added unique constraint on fingerprint column, but in previous one you deleted the rows where public_key column values are same. The bug mentions that previous ones added with same names are deleted, here it seems id is an auto increment column and is deleting rows which are added later, not the previous ones. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36855515 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed` ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_speed`.`name` = 'CpuSpeed'))) left join `cloud`.`user_vm_details` `custom_ram_size` ON (((`custom_ram_size`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory'))); +delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id s2.id and s1.public_key = s2.public_key; +ALTER TABLE ssh_keypairs ADD UNIQUE (fingerprint); --- End diff -- Can we indent these two lines better, currently it shows as part of view creation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36855563 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed` ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_speed`.`name` = 'CpuSpeed'))) left join `cloud`.`user_vm_details` `custom_ram_size` ON (((`custom_ram_size`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory'))); +delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id s2.id and s1.public_key = s2.public_key; +ALTER TABLE ssh_keypairs ADD UNIQUE (fingerprint); --- End diff -- As well, there was a discussion on the mailing list that all DB changes be discussed on the ML. Can we discuss this issue on ML first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Release EC2stack 1.0.0
On 12-Aug-2015, at 4:01 pm, sebgoa run...@gmail.commailto:run...@gmail.com wrote: How do people feel about this ? Has anyone used it lately with 4.5.x releases ? I had test ec2stack with 4.5.1 release and help set it up for a pre-production environment as well. Last time I checked I was able to work awscli with it, not to mention how painless it was compared to awsapi (which btw did not work with 4.5.x, for me). Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130313964 @koushik-das Added tests. Please have a look! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user kansal commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36858306 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed` ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_speed`.`name` = 'CpuSpeed'))) left join `cloud`.`user_vm_details` `custom_ram_size` ON (((`custom_ram_size`.`vm_id` = `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory'))); +delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id s2.id and s1.public_key = s2.public_key; +ALTER TABLE ssh_keypairs ADD UNIQUE (fingerprint); --- End diff -- @sedukullI have deleted the lines with the same public_key because we want that previous different name-same key registrations are handled. (I mean the ones people will already have in their DB). For putting the unique constraint, I added it on the fingerprint because the public_key is a VARCHAR(5120) and our DB doesn't allow unique key on such large values. It won't be a problem because finger print is generated from the public_key only. Coming to deleting the rows, I am deleting the ones with newer(large) id's. If required, older ones can be deleted and newest can be kept.(no big deal). @DaanHoogland Being new to the community, I was not aware of the fact that we have take these to Mailing lists. If you want I can do that also. @sedukull as far as the api changes are concerned, I don't think that is necessary. Its not generating the duplicates in the main table. What happens is that in the logic, there is join between ssh_keypairs and user_vm_details to create user_vm_view on the basis of public_key. Since public_key is not a foreign key, such kind of issues are arising. For cascading delete logic I will get back to you in detail. But it worked fine for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/687 [CS45] Add missing localization for some labels in Web UI - on the zone configuration wizard for the Next button - on templates, Shared, extratable and Dynamically Scalable - Improve some French translations (Téléverser for Upload) - update French messages properties from transifex (4.5 branch) You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace/cloudstack CS45_MissingSomesL10N Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/687.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #687 commit a8fa39bdf0278d3a791142fef34260c7cb14b03f Author: Milamber milam...@apache.org Date: 2015-08-12T19:43:38Z [CS45] Add missing localization for some labels in Web UI - on the zone configuration wizard for the Next button - on templates, Shared, extratable and Dynamically Scalable - Improve some French translations (Téléverser for Upload) - update French messages properties from transifex (4.5 branch) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
