[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132140803 @karuturi You should send a public key which has it's special characters ( SPACE / - % ) replaced with uri compatible escape characters. - encoding http://www.w3schools.com/tags/ref_urlencode.asp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132145283 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Disablestorage pep8
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/703#issuecomment-132145192 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: tool to aid db comaprision for upgrade te...
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/188#issuecomment-132160851 Yes this was committed. On 14-Aug-2015, at 2:48 pm, Rohit Yadav notificati...@github.com wrote: Was this merge on master? â Reply to this email directly or view it on GitHub https://github.com/apache/cloudstack/pull/188#issuecomment-131039138. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...
Hello, @remi: Thanks would great if this PR can be included in master before the release process of 4.6. Thanks. @all (translators): New strings needs to be translated on Transifex[1]. I will make an update of the l10n properties files just before the start of 4.6 release process. Milamber PS: cc user list for touch the translators. [1] https://www.transifex.com/ke4qqq/CloudStack_UI/ On 18/08/2015 11:22, milamberspace wrote: GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/712 CLOUDSTACK-8744 Add missing localization (l10n) for several parts in … …the UI - l10n for the SSH Key Pairs behavior - l10n for Autoscaling / LB sections - l10n for Reset password - l10n on some strings for the installation Wizard - l10n on some strings in VPN/VPC section - l10n on Service offerings sections - improve some FR translations You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace/cloudstack CLOUDSTACK-8744-AnotherMissingL10N-4-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/712.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #712 commit 267994fa0b3f9a5a773e691be0fc43d1c4f05d16 Author: Milamber milam...@apache.org Date: 2015-08-18T10:16:14Z CLOUDSTACK-8744 Add missing localization (l10n) for several parts in the UI - l10n for the SSH Key Pairs behavior - l10n for Autoscaling / LB sections - l10n for Reset password - l10n on some strings for the installation Wizard - l10n on some strings in VPN/VPC section - l10n on Service offerings sections - improve some FR translations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Typo correction
GitHub user radu-stefanache opened a pull request: https://github.com/apache/cloudstack/pull/711 Typo correction Cannnot != Cannot You can merge this pull request into a Git repository by running: $ git pull https://github.com/radu-stefanache/cloudstack radu-stefanache-patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/711.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #711 commit 931e20c7f6f79130c4746e8cc07af7beb7e854a7 Author: Radu Stefanache radu.stefana...@gmail.com Date: 2015-08-18T09:57:41Z Typo correction Cannnot != Cannot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed typo
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/708#issuecomment-132152921 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed typo
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/708 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Typo correction
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/711#issuecomment-132153264 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-noredist #4533
See http://jenkins.buildacloud.org/job/build-master-noredist/4533/changes Changes: [radu.stefanache] Typo correction -- [...truncated 8205 lines...] 2015-08-18 10:11:11 DEBUG Script:433 - Looking for scripts/vm/systemvm/id_rsa.cloud in http://jenkins.buildacloud.org/job/build-master-noredist/ws/utils/scripts/vm/systemvm/id_rsa.cloud 2015-08-18 10:11:11 DEBUG Script:433 - Looking for scripts/vm/systemvm/id_rsa.cloud in http://jenkins.buildacloud.org/job/build-master-noredist/ws/scripts/vm/systemvm/id_rsa.cloud 2015-08-18 10:11:11 DEBUG Ovm3HypervisorSupport:165 - found SshKey http://jenkins.buildacloud.org/job/build-master-noredist/ws/scripts/vm/systemvm/id_rsa.cloud 2015-08-18 10:11:11 DEBUG Ovm3HypervisorResource:389 - override connection: null 2015-08-18 10:11:11 DEBUG Ovm3HypervisorResource:345 - configure ovm-1 with params: {agentusername=oracle, public.network.device=xenbr0, xenserver.heartbeat.interval=60, private.network.device=xenbr0, agentpassword=unknown, Hypervisor.Version=4.1.3OVM, secondary.storage.vm=false, Host.OS=Oracle VM Server, ovm3pool=true, ipaddress=192.168.1.64, password=unknown, username=root, pool=a9c1219d-817d-4242-b23e-2607801c79d5, ismaster=false, storage.network.device=xenbr0, ovm3.heartbeat.timeout=120, Host.OS.Version=5.7, xenserver.nics.max=7, agentVersion=3.2.1-183, router.aggregation.command.each.timeout=3, pod=1, istest=true, max.template.iso.size=50, host=ovm-1, com.cloud.network.Networks.RouterPrivateIpStrategy=DcGlobal, agentport=8899, Host.OS.Kernel.Version=2.6.39-300.22.2.el5uek, migratewait=3600, storage.network.device1=xenbr0, ovm3.heartbeat.interval=1, ip=192.168.1.64, ovm3cluster=false, guid=19e5f1e7-22f4-3b6d-8d41-c82f89c65295, ovm3vip=192.168.1.230, hasmaster=true, cluster=1, guest.network.device=xenbr0, zone=1, xenserver.heartbeat.timeout=120} 2015-08-18 10:11:11 DEBUG ConnectionTest:67 - methodresponse call: check_dom0_ip - [192.168.1.230] 2015-08-18 10:11:11 DEBUG Ovm3HypervisorSupport:587 - ovm-1 is a master, already has vip 192.168.1.230 2015-08-18 10:11:11 DEBUG ConnectionTest:67 - methodresponse call: discover_network - [] 2015-08-18 10:11:11 DEBUG Ovm3HypervisorNetwork:75 - already have control0 2015-08-18 10:11:11 DEBUG ConnectionTest:67 - methodresponse call: ovs_ip_config - [control0, static, 169.254.0.1, 255.255.0.0] 2015-08-18 10:11:11 DEBUG ConnectionTest:67 - methodresponse call: ovs_control_interface - [control0, 169.254.0.0/16] 2015-08-18 10:11:12 DEBUG ConnectionTest:67 - methodresponse call: discover_hardware - [] 2015-08-18 10:11:12 DEBUG ConnectionTest:67 - methodresponse call: discover_server - [] 2015-08-18 10:11:12 DEBUG ConnectionTest:67 - methodresponse call: update_server_roles - [xen,utility] 2015-08-18 10:11:12 DEBUG Ovm3StoragePool:164 - Host ovm-1 owned by us 2015-08-18 10:11:12 DEBUG Ovm3HypervisorResource:208 - executeRequest called: class com.cloud.agent.api.GetHostStatsCommand 2015-08-18 10:11:12 DEBUG ConnectionTest:72 - getresult call: ovs_dom0_stats - [xenbr0] 2015-08-18 10:11:12 DEBUG Ovm3HypervisorSupport:709 - Unable to get host stats for: ovm-1 com.cloud.hypervisor.ovm3.objects.Ovm3ResourceException: Client call ovs_dom0_stats to null with [xenbr0] went wrong: Exception: null at com.cloud.hypervisor.ovm3.objects.OvmObject.callWrapper(OvmObject.java:107) at com.cloud.hypervisor.ovm3.objects.CloudstackPlugin.ovsDom0Stats(CloudstackPlugin.java:135) at com.cloud.hypervisor.ovm3.resources.helpers.Ovm3HypervisorSupport.execute(Ovm3HypervisorSupport.java:697) at com.cloud.hypervisor.ovm3.resources.Ovm3HypervisorResource.executeRequest(Ovm3HypervisorResource.java:253) at com.cloud.hypervisor.ovm3.resources.helpers.Ovm3HypervisorSupportTest.GetHostStatsCommandFailTest(Ovm3HypervisorSupportTest.java:218) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at
[GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/712 CLOUDSTACK-8744 Add missing localization (l10n) for several parts in ⦠â¦the UI - l10n for the SSH Key Pairs behavior - l10n for Autoscaling / LB sections - l10n for Reset password - l10n on some strings for the installation Wizard - l10n on some strings in VPN/VPC section - l10n on Service offerings sections - improve some FR translations You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace/cloudstack CLOUDSTACK-8744-AnotherMissingL10N-4-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/712.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #712 commit 267994fa0b3f9a5a773e691be0fc43d1c4f05d16 Author: Milamber milam...@apache.org Date: 2015-08-18T10:16:14Z CLOUDSTACK-8744 Add missing localization (l10n) for several parts in the UI - l10n for the SSH Key Pairs behavior - l10n for Autoscaling / LB sections - l10n for Reset password - l10n on some strings for the installation Wizard - l10n on some strings in VPN/VPC section - l10n on Service offerings sections - improve some FR translations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132102845 LGTM. I made the commit two years ago. However, something changed in the following commit, so the encoding on UI is not needed any more. commit 6aafb9c50da3cf4db37c0323d8bdc859776a8fa0 Author: Likitha Shetty likitha.she...@citrix.com Date: Thu Nov 21 13:33:57 2013 +0530 CLOUDSTACK-5227. Cannot pass Japanese characters as parameter values to an API. During API check for control characters use pattern matching to avoid identifying all non-printable characters as control characters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-slowbuild #2087
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2087/ -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-plugin-network-srx --- [INFO] Fork Value is true [INFO] Done FindBugs Analysis [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx --- [INFO] BugInstance size is 0 [INFO] Error size is 0 [INFO] No errors/warnings found [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [ERROR] Aug 18, 2015 8:10:27 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler saveCoverageData INFO: Cobertura: Saved information on 21 classes. [INFO] Instrumentation was successful. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-srx --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/juniper-srx/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-srx --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-srx --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/JuniperSRXFirewallElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 1146ms [ERROR] Aug 18, 2015 8:10:32 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 1214ms [ERROR] Aug 18, 2015 8:10:33 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Nuage VSP 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vsp --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-vsp --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-vsp --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vsp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-vsp --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 43 source files to http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target/classes [INFO] - [ERROR] COMPILATION ERROR :
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/710#issuecomment-132120109 apart from the formatting changes, are there any other changes? Can you please make separate commits for formatting and the actual changes with clear commit messages describing the change? Can you also add information on how to run these tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Default to notify only script to handle n...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/696#issuecomment-132146849 LGTM The resizing in general should be done using libvirt-java and not by executing 'virsh' at all. It could be that the Java bindings for libvirt are lacking some support for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-132154456 LGTM to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: simulator-4.5-singlerun #260
See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/260/ -- Started by upstream project build-4.5-simulator build number 315 originally caused by: Started by upstream project build-4.5 build number 511 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors
[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/709 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Fwd: Re: new timestamp format for API in ACS 4.5.1
Copy thread from @users, as I am not sure where is the right place to find right people for helping. Forwarded Message Subject:Re: new timestamp format for API in ACS 4.5.1 Date: Tue, 18 Aug 2015 18:04:56 +0800 From: tony_caot...@163.com Reply-To: us...@cloudstack.apache.org To: us...@cloudstack.apache.org In ParamProcessWorker::setFieldValue() I found this lins: case DATE: // This piece of code is for maintaining backward compatibility // and support both the date formats(Bug 9724) Is it related to my problem? Where can I found the descriptions about BUG9724 ? --- Cao Tong On 08/18/2015 05:54 PM, tony_caot...@163.com wrote: Hello, When I use timestamp format startdate=2015-07-31, it works find. When I use it like this startdate=2015-07-31 13:00:00. It return a error IOError: ('http error', 401, 'Unauthorized', httplib.HTTPMessage instance at 0x16dca70) Could anyone tell me why ? I have read the code DefaultLoginAPIAuthenticatorCmd::authenticate() , but I am still not understand what was happening, it seems authenticate failed, but why?? --- Cao Tong On 07/31/2015 07:07 PM, tony_caot...@163.com wrote: Hi, was this format is enabled in ACS 4.5.1 like /-MM-dd HH:mm:ss /I found it in 4.5.0 API doc, but it seems not enabled. http://cloudstack.apache.org/api/apidocs-4.5/user/listEvents.html api.listEvents(startdate=2015-07-31 13:00:00) Traceback (most recent call last): File stdin, line 1, in module File call.py, line 48, in handlerFunction return self._make_request(name, kwargs) File call.py, line 60, in _make_request data = self._http_get(self.value) File call.py, line 53, in _http_get response = urllib.urlopen(url) File /usr/lib64/python2.7/urllib.py, line 87, in urlopen return opener.open(url) File /usr/lib64/python2.7/urllib.py, line 208, in open return getattr(self, name)(url) File /usr/lib64/python2.7/urllib.py, line 359, in open_http return self.http_error(url, fp, errcode, errmsg, headers) File /usr/lib64/python2.7/urllib.py, line 372, in http_error result = method(url, fp, errcode, errmsg, headers) File /usr/lib64/python2.7/urllib.py, line 683, in http_error_401 errcode, errmsg, headers) File /usr/lib64/python2.7/urllib.py, line 381, in http_error_default raise IOError, ('http error', errcode, errmsg, headers) IOError: ('http error', 401, 'Unauthorized', httplib.HTTPMessage instance at 0x16dca70) my ACS version: [root@cs ~]# rpm -qa |grep cloud cloudstack-management-4.5.1-shapeblue0.el6.x86_64 cloudstack-awsapi-4.5.1-shapeblue0.el6.x86_64 cloudstack-agent-4.5.1-shapeblue0.el6.x86_64 cloudstack-common-4.5.1-shapeblue0.el6.x86_64
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user sailajamada commented on the pull request: https://github.com/apache/cloudstack/pull/710#issuecomment-132122426 Hi Rajani, There are two commits First Commit: 1) Initial Test automation had only 37 test cases and no support for LXC. This includes total of 71 cases for both templates and volumes. New commit has the changes to handle LXC and better way to SKIP the testcases based on the environment. Second Commit: 2) To remove white spaces --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-132091017 The PR #709 don't fix the issue for me. I can't add a SSH key pair without revert the #615. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Usage Records are still generating even VM removed.
update the usage_event table with VM.DESTROY event for this vm. I would say create a vm, destroy it and observer the entries in usage_event table. create a similar entry for the manually destroyed vm. ~Rajani On Tue, Aug 18, 2015 at 12:12 AM, raja sekhar rajsekhar@gmail.com wrote: Hi All, The usage records are still generating even if the vm is removed from cloudstack. The actual scenario is: The xenserver host went to alert state and the vms in it are not accessible. we have removed the vms from backend by updating vm_instance,volume table. can any one help me what is the exact table to update? i am using cloudstack 4.2 waiting for your valuable suggestions. regards, rajasekhar.
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/705#issuecomment-132115146 Hi @karuturi The pull analysis failure is unrelated. -- Checkstyle errors in code I didn't touch The errors in the master build are being caused by a change of method names as stated in the mail I send yesterday. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201508.mbox/%3C1558679771.80.1439832860031.JavaMail.open-xchange%40109.72.87.221%3E --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132121319 @borisroman excluding the cloudmonkey bit, if I make direct api call, should I send the encoded value or the original value. Did that change from previous version? I think it would be better to also update api documentation to reflect whether it accepts encoded/decoded value. right now it just says Public key material of the keypair https://cloudstack.apache.org/api/apidocs-4.5/user/registerSSHKeyPair.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/710#issuecomment-132124601 Hi @sailajamada, In both the commits, I am seeing only formatting changes in both the commits. I am sure that I am missing the real changes in the pep8 formats. Can you please check again and also change the commit messages accordingly? I would like to run these tests. Can you also add steps on how to run them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/705#issuecomment-132121809 ok. will check PR #707. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...
Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/692#discussion_r37269538 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py --- @@ -96,7 +96,7 @@ def _redundant_on(self): d = s.replace(.templ, ) CsHelper.copy_if_needed(%s/%s % (self.CS_TEMPLATES_DIR, s), %s/%s % (self.CS_ROUTER_DIR, d)) CsHelper.copy_if_needed(%s/%s % (self.CS_TEMPLATES_DIR, keepalived.conf.templ), self.KEEPALIVED_CONF) -CsHelper.copy_if_needed(%s/%s % (self.CS_TEMPLATES_DIR, conntrackd.conf.templ), self.CONNTRACKD_CONF) +CsHelper.copy(%s/%s % (self.CS_TEMPLATES_DIR, conntrackd.conf.templ), self.CONNTRACKD_CONF) --- End diff -- Hi Daan, The intent of copy_if_needed is to prevent overwriting the config file if it is preset already. In case of conntrackd, the config file is already present and so it dose not copy the default cloudstack conntrackd template and as a result conntrackd fails to start. For this(copy_if_needed) to work we should make sure that this file is not present when this code runs for the first time. There may be similar errors related to rvr. I was trying to see if i can address them as a part of larger fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
GitHub user sailajamada opened a pull request: https://github.com/apache/cloudstack/pull/710 Browser Based Volume and Template Upload Test Automation Modifications CLOUDSTACK-8735 Test Browser_template_Life_cycle ... === TestName: test_01_Browser_template_Life_cycle_tpath | Status : SUCCESS === ok Test Browser_template_upload_multiple_zones ... SKIP: Only one zone available hence skipping Test Browser_template_upload_ResetVM_With_Deleted_Template ... === TestName: test_03_Browser_template_ResetVM_With_Deleted_Template | Status : SUCCESS === ok Test Browser_Upload_Template with all API parameters ... === TestName: test_04_Browser_Upload_Template_with_all_API_parameters | Status : SUCCESS === ok Test Browser Upload Template Resource limits ... === TestName: test_05_Browser_Upload_template_resource_limits | Status : SUCCESS === ok Test Browser_Upload_Template Secondary Storage Resource limits ... === TestName: test_06_Browser_Upload_template_secondary_storage_resource_limits | Status : SUCCESS === ok Test Browser_Upload_Template Resource limits after template deletion ... === TestName: test_07_Browser_Upload_template_resource_limits_after_deletion | Status : SUCCESS === ok Test Browser_Upload_Template Secondary Storage Resource limits after template deletion ... === TestName: test_08_Browser_Upload_Template_secondary_storage_resource_limits_after_deletion | Status : SUCCESS === ok Test SSVM_Life_Cycle_With_Browser_template_TPath ... === TestName: test_09_SSVM_Life_Cycle_With_Browser_Template_TPath | Status : SUCCESS === ok -- Ran 9 tests in 14156.758s OK (SKIP=1) Test Browser_volume_Life_cycle - This includes upload volume,attach to a VM, write data ,Stop ,Start, Reboot,Reset of a VM, detach,attach back to the VM, delete volumes ... === TestName: test_01_Browser_volume_Life_cycle_tpath | Status : SUCCESS === ok Test SSVM_Life_Cycle_With_Browser_Volume_TPath - This includes SSVM life cycle followed by Browser volume upload operations ... === TestName: test_02_SSVM_Life_Cycle_With_Browser_Volume_TPath | Status : SUCCESS === ok Test Browser_Upload_Volume_Global_Config limits ... === TestName: test_03_Browser_Upload_Volume_Global_Config_TPath | Status : SUCCESS === ok Test Browser_Upload_Volume_Negative_Scenarios ... === TestName: test_04_Browser_Upload_Volume_Negative_Scenarios_TPath | Status : FAILED === FAIL Test Browser_Upload_Volume_MultiSSVM_Scenarios ... SKIP: secstorage.session.max global config is not set to 1 which means Multiple SSVM's are not present Test Browser_Upload_Volume_with_extended_file_extenstions ... === TestName: test_06_Browser_Upload_Volume_with_extended_file_extenstions | Status : FAILED === FAIL Test Browser_Upload_Volume_Storage_Cleanup_Config_Validation ... === TestName: test_07_Browser_Upload_Volume_Storage_Cleanup_Config_Validation | Status : FAILED === FAIL Test Browser_Upload_Volume_Negative_Scenarios ... === TestName: test_08_Browser_Upload_Volume_TamperedPostURL | Status : SUCCESS === ok Test Browser_Upload_Volume_PostURL_with_Deleted_Uploadvolume_Details ... === TestName: test_09_Browser_Upload_Volume_PostURL_with_Deleted_Uploadvolume_Details | Status : SUCCESS === ok Test Browser_Upload_Volume_API_with_imagepoolid ... === TestName: test_10_Browser_Upload_Volume_API_with_imagepoolid | Status : SUCCESS === ok Test Browser_Upload_Volume_migrate_upload_volume ... === TestName: test_11_migrate_upload_volume | Status : SUCCESS === ok Test Browser_Upload_Volumewith all API parameters ... === TestName: test_12_Browser_Upload_Volume_with_all_API_parameters | Status : SUCCESS === ok Test Browser_Upload_Volume Volume Resource limits ... === TestName: test_13_Browser_Upload_Volume_volume_resource_limits | Status : SUCCESS === ok Test Browser_Upload_Volume Secondary Storage Resource limits ... === TestName: test_14_Browser_Upload_Volume_secondary_storage_resource_limits | Status : SUCCESS === ok Test Browser_Upload_Volume Primary Storage Resource limits ... === TestName: test_15_Browser_Upload_Volume_primary_storage_resource_limits | Status : SUCCESS === ok Test Browser_Upload_Volume resource_limits_after_deletion ... === TestName: test_16_Browser_Upload_volume_resource_limits_after_deletion | Status : SUCCESS === ok Test Browser_Upload_Volume secondary_storage_resource_limits_after_deletion ... === TestName: test_17_Browser_Upload_Volume_secondary_storage_resource_limits_after_deletion | Status : SUCCESS === ok Test Browser_Upload_Volume_with_invalid_signature ... === TestName: test_18_Browser_Upload_Volume_with_invalid_signature | Status : SUCCESS === ok Ran 18 tests in 18497.812s FAILED (SKIP=1,
[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132121577 @milamberspace, I couldnt find registerSSHKeyPair from UI. I could only see reset ssh key on a stopped vm. Where is this option in UI? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-132097141 Sorry, I clean up my browser cache, now works with the #709 fix. Thanks @borisroman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132097225 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132123648 @karuturi go to the Accounts page, and select SSH Key pairs in the dropdown. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132106862 @karuturi Cloudmonkey passes an single encoded public key, as it's supposed to! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-132174594 @devdeep look great. one question but LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user sailajamada commented on the pull request: https://github.com/apache/cloudstack/pull/710#issuecomment-132195800 Hi Rajani, To run the test: 1. Use the test data file included in the commit or add below section to your test data file browser_upload_volume:{ VHD: { diskname: XenUploadVol, url: http://10.147.28.7/templates/rajani-thin-volume.vhd;, checksum: 09b08b6abb1b903fca7711d3ac8d6598, }, OVA: { diskname: VMwareUploadVol, url: http://10.147.28.7/templates/Autoscale_Template/CentOS5.5(64bit)-vmware-autoscale.ova, checksum: da997b697feaa2f1f6e0d4785b0cece2, }, QCOW2: { diskname: KVMUploadVol, url: http://10.147.28.7/templates/rajani-thin-volume.qcow2;, checksum: 02de0576dd3a61ab59c03fd795fc86ac, }, TAR: { diskname: LXCUploadVol, url: http://10.147.28.7/templates/lxc/rhel63_x64.tar.gz;, checksum: aa29a468bd77aba6c723af4db61c734a, }, 'browser_resized_disk_offering': { displaytext: Resizeddisk, name: Resizeddisk, disksize: 3, } }, browser_upload_volume_extended:{ VHD: { diskname: XenUploadVol, url: http://10.147.28.7/templates/builtin/centos56-x86_64.vhd.bz2;, checksum: 09b08b6abb1b903fca7711d3ac8d6598, }, QCOW2: { diskname: KVMUploadVol, url: http://10.147.28.7/templates/builtin/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2;, checksum: 02de0576dd3a61ab59c03fd795fc86ac, }, }, browser_upload_template: { VHD: { templatename: XenUploadtemplate, displaytext: XenUploadtemplate, url: http://10.147.28.7/templates/builtin/centos56-x86_64.vhd.bz2;, hypervisor:XenServer, checksum: 09b08b6abb1b903fca7711d3ac8d6598, ostypeid:142 }, OVA: { templatename: VMwareUploadtemplate, displaytext: VMwareUploadtemplate, url: http://nfs1.lab.vmops.com/templates/vmware/CentOS5.3-x86_64.ova;, checksum: 02de0576dd3a61ab59c03fd795fc86ac, hypervisor:VMware, ostypeid:142 }, QCOW2: { templatename: KVMUploadtemplate, displaytext: KVMUploadtemplate, url: http://10.147.28.7/templates/builtin/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2;, checksum: d06b5f6a-d44e-11e4-9d99-4af3a393b3ac, hypervisor:KVM, ostypeid:142 }, TAR: { templatename: LXCUploadtemplate, displaytext: LXCUploadtemplate, url: http://10.147.28.7/templates/lxc/rhel63_x64.tar.gz;, checksum: aa29a468bd77aba6c723af4db61c734a, hypervisor:LXC, ostypeid:142, }, }, 2. Command to run the test nosetests -v --with-marvin --marvin-config=configuration file.cfg --log-folder-path=logfolder name --tests=Path to test_browse_volumes.py Ex: nosetests -v --with-marvin --marvin-config=btemplate.cfg --log-folder-path=/sailajalogs/ --tests=/ACSPRSAILAJA/cloudstack/test/integration/component/test_browse_volumes.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132197866 Hi all, Sorry the delay. Well, @anshul1886 IMHO the test cases add value to the code, they are making sure that those paths are properly coded (that may be too simple; however in such a huge, complex and complicated code such as the ACS they are needed). We try to use TDD to develop anything we are doing here. Therefore, when we were making those changes we did the following: ⢠Created an abstract method: com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.getPatchFilePath() ⢠Then we just generated that method in CitrixResourceBase subclasses ⢠Extracted the body of the method âgetPatchFilesâ from CitrixResourceBase subclasses ⢠At that moment we already had the methods we needed, so we could start creating the tests to check if each instance was returning the expected path. Every single test was failing at this moment as we expected. ⢠Then we started coding the methods in each class that was needed. After that we ran the tests to check if everything was ok. I believe those tests add value and that they are not a burden as pointed out by @DaanHoogland , if some future commit comes to touch that code and change the paths by mistake our test cases will get that. Additionally, I also believe that tests cases should be as simple as that, if the test method is too complicated there is something wrong either with the code or with the coder. But at the end if you guys think that they are not necessary, I can remove them. No hard feelings ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-slowbuild #2088
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2088/changes Changes: [radu.stefanache] Typo correction [Boris Schrijver] Removed double encoding of Public Key from JS. -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-plugin-network-srx --- [INFO] Fork Value is true [INFO] Done FindBugs Analysis [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx --- [INFO] BugInstance size is 0 [INFO] Error size is 0 [INFO] No errors/warnings found [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [ERROR] Aug 18, 2015 11:19:02 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler saveCoverageData INFO: Cobertura: Saved information on 21 classes. [INFO] Instrumentation was successful. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-srx --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/juniper-srx/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-srx --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-srx --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/JuniperSRXFirewallElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 1155ms [ERROR] Aug 18, 2015 11:19:03 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 1239ms [ERROR] Aug 18, 2015 11:19:04 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Nuage VSP 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vsp --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-vsp --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-vsp --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vsp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-vsp --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 43 source files to
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-132175228 I seeing below errors after applying this patch. Please do a noredist build as mentioned at https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack#HowtobuildCloudStack-BuildingCloudStack ``` [ERROR] /root/source/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[270,50] error: cannot find symbol [ERROR] symbol: method getDns1() location: variable publicNicProfile of type NicProfile /root/source/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[271,50] error: cannot find symbol [ERROR] symbol: method getDns2() location: variable publicNicProfile of type NicProfile /root/source/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[272,40] error: cannot find symbol [ERROR] symbol: method getGateway() location: variable publicNicProfile of type NicProfile /root/source/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[273,57] error: cannot find symbol ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-132187698 @karuturi I see, fixed them in a new commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132189625 @anshul1886 I agree with your point about the purpose of unit tests. In this case the purpose is to make sure developers don't change the paths, isn't it? So that when changes to the resource hierarchy occur paths for specific versions don't change. It makes sense to me. What changes do you envision that would justify changing the paths and would make those tests a burden? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132182774 @anshul1886 if the purpose is to ensure that the path returned doesn't change, this seems perfectly aceptable to me. If people want to change the path in the future they must be aware and change the unit tests as well. That said they seem a litle trivial but I'm alright with that. It is mainly the integrity class hierarchy of the resources that is being tested this way. (comment moved to this PR where it makes less non-sense) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132186831 @DaanHoogland That doesn't seems to be the case here. I believe if somebody has to change unit test with every change then that unit test is burden and should not be kept in codebase. I still didn't get the real purpose here as your statement starts with if. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: This branch implements the CSV and native...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-132173995 @anshul1886 if the purpose is to ensure that the path returned doesn't change, this seems perfectly aceptable to me. If people want to change the path in the future they must be aware and change the unit tests as well. That said they seem a litle trivial but I'm alright with that. It is mainly the integrity class hierarchy of the resources that is being tested this way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-noredist #4534
See http://jenkins.buildacloud.org/job/build-master-noredist/4534/ -- [...truncated 8580 lines...] at net.sourceforge.pmd.RuleSetReferenceId.getInputStream(RuleSetReferenceId.java:315) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetReferenceNode(RuleSetFactory.java:303) at net.sourceforge.pmd.RuleSetFactory.parseRuleNode(RuleSetFactory.java:262) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:219) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) net.sourceforge.pmd.RuleSetNotFoundException: Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar at net.sourceforge.pmd.RuleSetReferenceId.getInputStream(RuleSetReferenceId.java:315) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetReferenceNode(RuleSetFactory.java:303) at net.sourceforge.pmd.RuleSetFactory.parseRuleNode(RuleSetFactory.java:262) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:219) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) java.lang.RuntimeException: Couldn't find the class Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar at net.sourceforge.pmd.RuleSetFactory.classNotFoundProblem(RuleSetFactory.java:247) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:237) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) java.lang.RuntimeException: Couldn't find the class Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar [WARNING] Failure executing PMD: null at net.sourceforge.pmd.RuleSetFactory.classNotFoundProblem(RuleSetFactory.java:247) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:237) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/713 CLOUDSTACK-8745 : verify usage after root disk migration put storage in maintenance mode and start ha vm and check usage ... === TestName: test_ha_with_storage_maintenance | Status : SUCCESS === ok -- Ran 1 test in 842.294s OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/nitt10prashant/cloudstack pool_maint Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/713.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #713 commit d276a3579f7f055b5431575a5bb498d96dfc9f45 Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-08-18T11:23:54Z CLOUDSTACK-8745 : verify usage after root disk migration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [PROPOSAL] Closing PRs older than 1 month and without activity
-0 I think there is no harm in keeping the PRs open which are not merged yet, as a reference which can be picked up by someone over time and merged/closed later. For example, here is an interesting PR that is more than a month old but if you close it we risk forgetting about it: https://github.com/apache/cloudstack/pull/372 The age of the PR is perhaps another point of discussion, perhaps it may be okay to close a PR that is more than a year, or at least 6+ years old, but not month+ old. On 17-Aug-2015, at 7:55 pm, Remi Bergsma rberg...@schubergphilis.commailto:rberg...@schubergphilis.com wrote: Hi all, There are several PRs that are quite old. They haven't been updated by their author for over a month and there was no response to comments made. As a RM, I want to maintain an as-short-as-possible list of PRs that is actively worked on. It is perfectly fine if a PR is open for a longer time, as long as it is actively maintained (or has a comment that explains why there is a delay). Long lists of open PRs don't give the impression we actively work on them and might keep people from contributing. Proposal: Let's close PRs where the author did not respond for over a month. How? For now, I'll manually select the PRs that I propose to close. Next, I make a PR with an empty commit that closes the PRs by triggering asfbot (as we cannot otherwise close PRs due to it being read-only for committers). By using a PR, it should be visible which PRs will get closed (after 2x LGTM and no -1). I’ll send an example PR with link to this thread after I've sent this e-mail. Work lost? The work done in a PR is not lost by closing the PR! If someone wants to take over, this is how you can merge the work in a new branch (keeping author and commit hashes the same) and add more commits on top of it. You can then send it as a new PR. Example: prId=12345 git fetch origin pull/${prId}/head:pr/${prId} git merge --no-ff --log -m Merging PR ${prId} and continuing the work pr/${prId} git commit --amend -s --allow-empty-message -m '' Please let me know what you think: +1 or -1? If -1, what should we do instead? Regards, Remi Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Build failed in Jenkins: build-master-slowbuild #2090
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2090/changes Changes: [sowmya.krishnan] CLOUDSTACK-8738: Added the two methods for enable and cancel maintenance mode on StoragePool [sowmya.krishnan] Fixed pep8 issues [rene.moser] CLOUDSTACK-8740: add custom.css to make custom UI styles easier [radu.stefanache] Typo correction -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-plugin-network-srx --- [INFO] Fork Value is true [INFO] Done FindBugs Analysis [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx --- [INFO] BugInstance size is 0 [INFO] Error size is 0 [INFO] No errors/warnings found [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [ERROR] Aug 18, 2015 5:29:33 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler saveCoverageData INFO: Cobertura: Saved information on 21 classes. [INFO] Instrumentation was successful. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-srx --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/juniper-srx/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-srx --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-srx --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/JuniperSRXFirewallElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 1131ms [ERROR] Aug 18, 2015 5:29:34 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 1222ms [ERROR] Aug 18, 2015 5:29:35 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Nuage VSP 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vsp --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-vsp --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-vsp --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vsp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-vsp --- [INFO] Changes
Build failed in Jenkins: build-master-slowbuild #2091
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2091/ -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-plugin-network-srx --- [INFO] Fork Value is true [INFO] Done FindBugs Analysis [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx --- [INFO] BugInstance size is 0 [INFO] Error size is 0 [INFO] No errors/warnings found [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [ERROR] Aug 18, 2015 8:10:59 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler saveCoverageData INFO: Cobertura: Saved information on 21 classes. [INFO] Instrumentation was successful. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-srx --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/juniper-srx/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-srx --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-srx --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/JuniperSRXFirewallElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 1134ms [ERROR] Aug 18, 2015 8:11:04 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 1206ms [ERROR] Aug 18, 2015 8:11:05 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Nuage VSP 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vsp --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-vsp --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-vsp --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vsp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-vsp --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 43 source files to http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target/classes [INFO] - [ERROR] COMPILATION ERROR :
Build failed in Jenkins: build-master-slowbuild #2093
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2093/ -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-plugin-network-srx --- [INFO] Fork Value is true [INFO] Done FindBugs Analysis [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx --- [INFO] BugInstance size is 0 [INFO] Error size is 0 [INFO] No errors/warnings found [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [ERROR] Aug 19, 2015 2:10:58 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler saveCoverageData INFO: Cobertura: Saved information on 21 classes. [INFO] Instrumentation was successful. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-srx --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/juniper-srx/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-srx --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-srx --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/JuniperSRXFirewallElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 1145ms [ERROR] Aug 19, 2015 2:11:03 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 1209ms [ERROR] Aug 19, 2015 2:11:04 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Nuage VSP 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vsp --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-vsp --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-vsp --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vsp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-vsp --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 43 source files to http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target/classes [INFO] - [ERROR] COMPILATION ERROR :
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379405 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379426 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379847 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + --- End diff -- hmm... I thought something like this should work: StoragePool.enableMaintenance(self.api_client, id=storageself.storageid[0][0]) since it is a classmethod I am just trying to confirm you're using the latest base.py since couple of these enhancements went in recently into base.py... If it still doesn't fit in, it's ok. You can continue the way you've done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132438972 @rafaelweingartner @DaanHoogland If the purpose is to make sure that path is not modified by other developer then adding note/comment on top of that line makes more sense. Even adding note is kind of implicit as paths are kind of constants which any developer would think before changing. Tests are not meant for that purpose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Quota master
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-132442691 @DaanHoogland @kishankavala @jburwell The documentation to run and check the plugin are in this pull request: https://github.com/apache/cloudstack-docs-admin/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-install pull request: Update xenserver.rst
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-install/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
new timestamp format for API in ACS 4.5.1
Hi All: Does any one have any idea ? Thanks. --- Cao Tong On 08/18/2015 06:04 PM, tony_caot...@163.com wrote: In ParamProcessWorker::setFieldValue() I found this lins: case DATE: // This piece of code is for maintaining backward compatibility // and support both the date formats(Bug 9724) Is it related to my problem? Where can I found the descriptions about BUG9724 ? --- Cao Tong On 08/18/2015 05:54 PM, tony_caot...@163.com wrote: Hello, When I use timestamp format startdate=2015-07-31, it works find. When I use it like this startdate=2015-07-31 13:00:00. It return a error IOError: ('http error', 401, 'Unauthorized', httplib.HTTPMessage instance at 0x16dca70) Could anyone tell me why ? I have read the code DefaultLoginAPIAuthenticatorCmd::authenticate() , but I am still not understand what was happening, it seems authenticate failed, but why?? --- Cao Tong On 07/31/2015 07:07 PM, tony_caot...@163.com wrote: Hi, was this format is enabled in ACS 4.5.1 like /-MM-dd HH:mm:ss /I found it in 4.5.0 API doc, but it seems not enabled. http://cloudstack.apache.org/api/apidocs-4.5/user/listEvents.html api.listEvents(startdate=2015-07-31 13:00:00) Traceback (most recent call last): File stdin, line 1, in module File call.py, line 48, in handlerFunction return self._make_request(name, kwargs) File call.py, line 60, in _make_request data = self._http_get(self.value) File call.py, line 53, in _http_get response = urllib.urlopen(url) File /usr/lib64/python2.7/urllib.py, line 87, in urlopen return opener.open(url) File /usr/lib64/python2.7/urllib.py, line 208, in open return getattr(self, name)(url) File /usr/lib64/python2.7/urllib.py, line 359, in open_http return self.http_error(url, fp, errcode, errmsg, headers) File /usr/lib64/python2.7/urllib.py, line 372, in http_error result = method(url, fp, errcode, errmsg, headers) File /usr/lib64/python2.7/urllib.py, line 683, in http_error_401 errcode, errmsg, headers) File /usr/lib64/python2.7/urllib.py, line 381, in http_error_default raise IOError, ('http error', errcode, errmsg, headers) IOError: ('http error', 401, 'Unauthorized', httplib.HTTPMessage instance at 0x16dca70) my ACS version: [root@cs ~]# rpm -qa |grep cloud cloudstack-management-4.5.1-shapeblue0.el6.x86_64 cloudstack-awsapi-4.5.1-shapeblue0.el6.x86_64 cloudstack-agent-4.5.1-shapeblue0.el6.x86_64 cloudstack-common-4.5.1-shapeblue0.el6.x86_64
[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/30 CLOUDSTACK-8592: Quota plugin usage documentation This document provides information on configuring and running the quota service. It also provides information on various APIs to check and maintain quotas for accounts. You can merge this pull request into a Git repository by running: $ git pull https://github.com/abhinandanprateek/cloudstack-docs-admin master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-admin/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit 84504b4ae60f40a414f219c1ba7a646cc4e416ac Author: Abhinandan Prateek abhinandan.prat...@shapeblue.com Date: 2015-08-19T04:23:13Z CLOUDSTACK-8592: Quota plugin usage documentation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379373 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + --- End diff -- those methods can be used only with storage pool class object. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-132444220 build is successful now. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379748 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user devdeep commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-132439804 @remibergsma I'll close this pull request and generate a new one where the unit tests are squashed in one commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user devdeep closed the pull request at: https://github.com/apache/cloudstack/pull/635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379183 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379122 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + --- End diff -- There are enableMaintenance and cancelMaintenance methods available now directly from StoragePool in base.py. It's better to use that instead of repeating? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379467 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37379515 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
GitHub user devdeep opened a pull request: https://github.com/apache/cloudstack/pull/715 CLOUDSTACK-8687: Prepare template only on a given storage pool Update prepare template api to seed/prepare a template only on a given primary storage. Currently, the prepare template api will seed/prepare a given template on all the primary storage pools in a zone. If however, a user wishes to prepare a template only a particular storage pool, it isn't possible. Updated the api to take storage pool id as an optional parameter. If the pool id is provided then the template is prepared only on the given primary storage pool. Also added unit tests to validate the functionality You can merge this pull request into a Git repository by running: $ git pull https://github.com/devdeep/cloudstack-1 CLOUDSTACK-8687 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/715.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #715 commit adf6b588ddb2d61bc4aa8ed4c02edaf292fa825e Author: Devdeep Singh devd...@gmail.com Date: 2015-07-28T06:35:35Z CLOUDSTACK-8687: Update prepare template api to seed/prepare a template only on a given primary storage. Currently, the prepare template api will seed/prepare a given template on all the primary storage pools in a zone. If however, a user wishes to prepare a template only a particular storage pool, it isn't possible. Updated the api to take storage pool id as an optional parameter. If the pool id is provided then the template is prepared only on the given primary storage pool commit fedef2e6caefd41ad10ac3d691a28271e101f171 Author: Devdeep Singh devd...@gmail.com Date: 2015-08-04T11:47:10Z CLOUDSTACK-8687: Unit tests for validating the prepare template functionality. These tests validate that the templates get scheduled for seeding. Additionally, if a template is already seeded, we do not try and seed it again. Tests also validate that templates are seeded to storage pools which are available. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-132335229 @pedro-martins s_logger is a standard name for the variables and in each class it gets the class.class as its log category. I fail to see how you change improves on this. Also '4,076 additions and 3,379 deletions' means more code and not a reduction in code. Finally I see a lot of reordering of variables in classes that I'd rather see in separate commits so the essentials of your change are easier reviewed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-noredist #4532
See http://jenkins.buildacloud.org/job/build-master-noredist/4532/changes Changes: [Boris Schrijver] Removed double encoding of Public Key from JS. -- [...truncated 7827 lines...] at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetReferenceNode(RuleSetFactory.java:303) at net.sourceforge.pmd.RuleSetFactory.parseRuleNode(RuleSetFactory.java:262) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:219) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) java.lang.RuntimeException: Couldn't find the class Stream closed at net.sourceforge.pmd.RuleSetFactory.classNotFoundProblem(RuleSetFactory.java:247) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:239) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetReferenceNode(RuleSetFactory.java:303) at net.sourceforge.pmd.RuleSetFactory.parseRuleNode(RuleSetFactory.java:262) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:219) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) 2015-08-18 09:55:21 DEBUG Ovm3HypervisorResource:389 - override connection: null 2015-08-18 09:55:21 DEBUG Ovm3HypervisorResource:345 - configure ovm-1 with params: {agentusername=oracle, public.network.device=xenbr0, xenserver.heartbeat.interval=60, private.network.device=xenbr0, agentpassword=unknown, Hypervisor.Version=4.1.3OVM, secondary.storage.vm=false, Host.OS=Oracle VM Server, ovm3pool=true, ipaddress=192.168.1.64, password=unknown, username=root, pool=a9c1219d-817d-4242-b23e-2607801c79d5, ismaster=false, storage.network.device=xenbr0, ovm3.heartbeat.timeout=120, Host.OS.Version=5.7, xenserver.nics.max=7, agentVersion=3.2.1-183, router.aggregation.command.each.timeout=3, pod=1, istest=true, max.template.iso.size=50, host=ovm-1, com.cloud.network.Networks.RouterPrivateIpStrategy=DcGlobal, agentport=8899, Host.OS.Kernel.Version=2.6.39-300.22.2.el5uek, migratewait=3600, storage.network.device1=xenbr0, ovm3.heartbeat.interval=1, ip=192.168.1.64, ovm3cluster=false, guid=19e5f1e7-22f4-3b6d-8d41-c82f89c65295, ovm3vip=192.168.1.230, hasmaster=true, cluster=1, guest.network.device=xenbr0, zone=1, xenserver.heartbeat.timeout=120} 2015-08-18 09:55:21 DEBUG ConnectionTest:67 - methodresponse call: check_dom0_ip - [192.168.1.230] 2015-08-18 09:55:21 DEBUG Ovm3HypervisorSupport:587 - ovm-1 is a master, already has vip 192.168.1.230 2015-08-18 09:55:21 DEBUG ConnectionTest:72 - getresult call: discover_network - [] 2015-08-18 09:55:21 DEBUG DefaultListableBeanFactory:506 - Eagerly caching bean 'networkDao' to allow for resolving potential circular references 2015-08-18 09:55:21 DEBUG DefaultListableBeanFactory:460 - Finished creating instance of bean 'networkDao' 2015-08-18 09:55:21 DEBUG DefaultListableBeanFactory:215 - Creating shared instance of singleton bean 'physicalNetworkDao' 2015-08-18 09:55:21 DEBUG DefaultListableBeanFactory:432 - Creating instance of bean 'physicalNetworkDao' 2015-08-18 09:55:21 DEBUG DefaultListableBeanFactory:243 - Returning cached instance of singleton bean 'globoDnsElementTest.TestConfiguration' 2015-08-18 09:55:21 DEBUG DefaultListableBeanFactory:506 - Eagerly caching bean
[GitHub] cloudstack-docs-rn pull request: Fix CLOUDSTACK-8540: Update templ...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack-docs-rn/pull/24#issuecomment-132164867 Thanks for the PR @rhosdev. Its merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-rn pull request: Fix CLOUDSTACK-8540: Update templ...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-rn/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-slowbuild #2092
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2092/ -- [...truncated 25929 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-plugin-network-srx --- [INFO] Fork Value is true [INFO] Done FindBugs Analysis [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx --- [INFO] BugInstance size is 0 [INFO] Error size is 0 [INFO] No errors/warnings found [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [ERROR] Aug 18, 2015 11:10:57 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler saveCoverageData INFO: Cobertura: Saved information on 21 classes. [INFO] Instrumentation was successful. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-srx --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/juniper-srx/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-srx --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-srx --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/JuniperSRXFirewallElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 1590ms [ERROR] Aug 18, 2015 11:10:57 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 1190ms [ERROR] Aug 18, 2015 11:10:59 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Nuage VSP 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vsp --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-vsp --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-vsp --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vsp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-vsp --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 43 source files to http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target/classes [INFO] - [ERROR] COMPILATION ERROR
Build failed in Jenkins: build-master-slowbuild #2094
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2094/ -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-plugin-network-srx --- [INFO] Fork Value is true [INFO] Done FindBugs Analysis [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx --- [INFO] BugInstance size is 0 [INFO] Error size is 0 [INFO] No errors/warnings found [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [ERROR] Aug 19, 2015 5:10:08 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler saveCoverageData INFO: Cobertura: Saved information on 21 classes. [INFO] Instrumentation was successful. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-srx --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/juniper-srx/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-srx --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-srx --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/JuniperSRXFirewallElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 1154ms [ERROR] Aug 19, 2015 5:10:13 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 1215ms [ERROR] Aug 19, 2015 5:10:14 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Nuage VSP 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vsp --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-vsp --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-vsp --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vsp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-vsp --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 43 source files to http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target/classes [INFO] - [ERROR] COMPILATION ERROR :
[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/691#discussion_r37381189 --- Diff: test/integration/component/test_persistent_networks.py --- @@ -1459,6 +1459,135 @@ def test_delete_account(self): return +def test_volume_delete_event_errorState(self): + +@summary: Test volume delete event generation in error state condition +@Steps: + +Step1: Create a network using network created in Step1 +Step2: Verifying that network creation is successful +Step3: Login to Virtual router and add iptable rule to block insertion of vm rules +Step6: deploy a vm using network created in step2 +Step7: check the Vm status for failure +Step8: destroy and expunge the vm +Step9: list the generated events for volume delete event. + + +# Listing all the networks available + +account = Account.create( +self.api_client, +self.services[account], +domainid=self.domain.id) + +network = Network.create( +self.apiclient, +self.services[isolated_network], +networkofferingid=self.isolated_persistent_network_offering.id, +accountid=self.account.name, +domainid=self.domain.id, +zoneid=self.zone.id) + +response = verifyNetworkState( +self.apiclient, +network.id, +implemented) +exceptionOccured = response[0] +isNetworkInDesiredState = response[1] +exceptionMessage = response[2] + +if (exceptionOccured or (not isNetworkInDesiredState)): +self.fail(exceptionMessage) +self.assertIsNotNone( +network.vlan, +vlan must not be null for persistent network) +try: +if self.zone.networktype == Basic: +list_router_response = list_routers( +self.apiclient, +listall=true +) +else: +list_router_response = list_routers( +self.apiclient, +account=self.account.name, +domainid=self.account.domainid +) +self.assertEqual( +isinstance(list_router_response, list), +True, +Check list response returns a valid list +) +router = list_router_response[0] + +self.debug(Router ID: %s, state: %s % (router.id, router.state)) + +self.assertEqual( +router.state, +'Running', +Check list router response for router state +) +self.hypervisor = self.testClient.getHypervisorInfo() +if self.hypervisor.lower() in ('vmware', 'hyperv'): +result = get_process_status( +self.apiclient.connection.mgtSvr, +22, +self.apiclient.connection.user, +self.apiclient.connection.passwd, +router.linklocalip, +iptables -I INPUT 1 -j DROP, +hypervisor=self.hypervisor +) +else: +try: +hosts = list_hosts( +self.apiclient, +zoneid=router.zoneid, +type='Routing', +state='Up', +id=router.hostid +) + +self.assertEqual( +isinstance(hosts, list), +True, +Check list host returns a valid list +) + +host = hosts[0] +result = get_process_status( +host.ipaddress, +22, root, xenroot, router.linklocalip, +iptables -I INPUT 1 -j DROP +) + --- End diff -- I believe this is a double hop to router from the host instead of management server. Do you think you can use get_host_credentials for getting host password instead of hard coding? Otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37380762 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37380740 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack pull request: Refactored Nic.java for readability.
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user ksowmya commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r37381494 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackAPI import (enableStorageMaintenance, + cancelStorageMaintenance + ) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.lib.base import (Account, + VirtualMachine, + ServiceOffering, + Cluster, + StoragePool, + Volume) +from marvin.lib.common import (get_zone, + get_domain, + get_template, + list_hosts + ) +from marvin.codes import PASS + + +def maintenance(self, storageid): +enables maintenance mode of a Storage pool + +cmd = enableStorageMaintenance.enableStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.enableStorageMaintenance(cmd) + + +def cancelmaintenance(self, storageid): +cancel maintenance mode of a Storage pool + +cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd() +cmd.id = storageid +return self.api_client.cancelStorageMaintenance(cmd) + + +class testHaPoolMaintenance(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +try: +cls._cleanup = [] +cls.testClient = super( +testHaPoolMaintenance, +cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Domain, Zone, Template +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services[ostype] +) +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services['mode'] = cls.zone.networktype +cls.hypervisor = cls.testClient.getHypervisorInfo() +cls.services[virtual_machine][zoneid] = cls.zone.id +cls.services[virtual_machine][template] = cls.template.id +cls.clusterWithSufficientPool = None +clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id) + +if not validateList(clusters)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +for cluster in clusters: +cls.pool = StoragePool.list(cls.api_client, +clusterid=cluster.id, +keyword=NetworkFilesystem +) + +if not validateList(cls.pool)[0]: + +cls.debug( +check list cluster response for zone id %s % +cls.zone.id) + +if len(cls.pool) = 2: +cls.clusterWithSufficientPool = cluster +break +if not cls.clusterWithSufficientPool: +return + +cls.services[service_offerings][ +tiny][offerha] = True + +
[GitHub] cloudstack-docs-rn pull request: Modified Advanced Baremetal suppo...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-rn/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-132237794 @devdeep Could you please make your commit message (first line) more descriptive? Right now I cannot tell the difference between them, unless I click on them and read it all. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-noredist #4537
See http://jenkins.buildacloud.org/job/build-master-noredist/4537/ -- [...truncated 7272 lines...] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) 2015-08-18 15:10:58 DEBUG ProfileValueUtils:68 - Retrieved @ProfileValueSourceConfiguration [null] for test class [com.globo.globodns.cloudstack.resource.GloboDnsResourceTest] 2015-08-18 15:10:58 DEBUG ProfileValueUtils:80 - Retrieved ProfileValueSource type [class org.springframework.test.annotation.SystemProfileValueSource] for class [com.globo.globodns.cloudstack.resource.GloboDnsResourceTest] net.sourceforge.pmd.RuleSetNotFoundException: Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar at net.sourceforge.pmd.RuleSetReferenceId.getInputStream(RuleSetReferenceId.java:315) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetReferenceNode(RuleSetFactory.java:303) at net.sourceforge.pmd.RuleSetFactory.parseRuleNode(RuleSetFactory.java:262) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:219) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) java.lang.RuntimeException: Couldn't find the class Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar at net.sourceforge.pmd.RuleSetFactory.classNotFoundProblem(RuleSetFactory.java:247) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:237) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) java.lang.RuntimeException: Couldn't find the class Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar at net.sourceforge.pmd.RuleSetFactory.classNotFoundProblem(RuleSetFactory.java:247) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:237) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at
Re: [PROPOSAL] Closing PRs older than 1 month and without activity
Hi all, This PR includes the ones we can close now: https://github.com/apache/cloudstack/pull/706 Any LGTM’s so we can merge it? Thanks, Remi On 17 Aug 2015, at 18:56, Rajani Karuturi raj...@apache.orgmailto:raj...@apache.org wrote: +1 for auto closing. I also agree with Boris that we need to distinguish discarded vs. Merged prs. On Mon, Aug 17, 2015 at 21:51 PM, Mike Tutkowski mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com wrote: +1 Sounds reasonable On Mon, Aug 17, 2015 at 8:25 AM, Remi Bergsma rberg...@schubergphilis.commailto:rberg...@schubergphilis.com javascript:; wrote: Hi all, There are several PRs that are quite old. They haven't been updated by their author for over a month and there was no response to comments made. As a RM, I want to maintain an as-short-as-possible list of PRs that is actively worked on. It is perfectly fine if a PR is open for a longer time, as long as it is actively maintained (or has a comment that explains why there is a delay). Long lists of open PRs don't give the impression we actively work on them and might keep people from contributing. Proposal: Let's close PRs where the author did not respond for over a month. How? For now, I'll manually select the PRs that I propose to close. Next, I make a PR with an empty commit that closes the PRs by triggering asfbot (as we cannot otherwise close PRs due to it being read-only for committers). By using a PR, it should be visible which PRs will get closed (after 2x LGTM and no -1). I’ll send an example PR with link to this thread after I've sent this e-mail. Work lost? The work done in a PR is not lost by closing the PR! If someone wants to take over, this is how you can merge the work in a new branch (keeping author and commit hashes the same) and add more commits on top of it. You can then send it as a new PR. Example: prId=12345 git fetch origin pull/${prId}/head:pr/${prId} git merge --no-ff --log -m Merging PR ${prId} and continuing the work pr/${prId} git commit --amend -s --allow-empty-message -m '' Please let me know what you think: +1 or -1? If -1, what should we do instead? Regards, Remi -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com javascript:; o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™* -- - Sent from Windows Phone ~Rajani
[GitHub] cloudstack pull request: Typo correction
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/711 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Typo correction
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/711#issuecomment-132228606 LGTM, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Disablestorage pep8
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/703 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-noredist #4536
See http://jenkins.buildacloud.org/job/build-master-noredist/4536/changes Changes: [sowmya.krishnan] CLOUDSTACK-8738: Added the two methods for enable and cancel maintenance mode on StoragePool [sowmya.krishnan] Fixed pep8 issues -- [...truncated 7464 lines...] 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:215 - Creating shared instance of singleton bean 'org.springframework.context.annotation.internalRequiredAnnotationProcessor' at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:432 - Creating instance of bean 'org.springframework.context.annotation.internalRequiredAnnotationProcessor' at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129)2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:506 - Eagerly caching bean 'org.springframework.context.annotation.internalRequiredAnnotationProcessor' to allow for resolving potential circular references 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:460 - Finished creating instance of bean 'org.springframework.context.annotation.internalRequiredAnnotationProcessor' at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:215 - Creating shared instance of singleton bean 'org.springframework.context.annotation.internalCommonAnnotationProcessor' at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113)2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:432 - Creating instance of bean 'org.springframework.context.annotation.internalCommonAnnotationProcessor' 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:506 - Eagerly caching bean 'org.springframework.context.annotation.internalCommonAnnotationProcessor' to allow for resolving potential circular references at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63)2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:460 - Finished creating instance of bean 'org.springframework.context.annotation.internalCommonAnnotationProcessor' 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:215 - Creating shared instance of singleton bean 'org.springframework.context.annotation.ConfigurationClassPostProcessor.importAwareProcessor' at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:432 - Creating instance of bean 'org.springframework.context.annotation.ConfigurationClassPostProcessor.importAwareProcessor' at java.util.concurrent.FutureTask.run(FutureTask.java:262)2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:506 - Eagerly caching bean 'org.springframework.context.annotation.ConfigurationClassPostProcessor.importAwareProcessor' to allow for resolving potential circular references 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:460 - Finished creating instance of bean 'org.springframework.context.annotation.ConfigurationClassPostProcessor.importAwareProcessor' at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)2015-08-18 14:45:42 DEBUG GenericApplicationContext:809 - Unable to locate MessageSource with name 'messageSource': using default [org.springframework.context.support.DelegatingMessageSource@322f8695] 2015-08-18 14:45:42 DEBUG GenericApplicationContext:833 - Unable to locate ApplicationEventMulticaster with name 'applicationEventMulticaster': using default [org.springframework.context.event.SimpleApplicationEventMulticaster@4e2cb9f0] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 2015-08-18 14:45:42 INFO DefaultListableBeanFactory:603 - Pre-instantiating singletons in org.springframework.beans.factory.support.DefaultListableBeanFactory@775cb8bd: defining beans [org.springframework.context.annotation.internalConfigurationAnnotationProcessor,org.springframework.context.annotation.internalAutowiredAnnotationProcessor,org.springframework.context.annotation.internalRequiredAnnotationProcessor,org.springframework.context.annotation.internalCommonAnnotationProcessor,org.springframework.context.annotation.ConfigurationClassPostProcessor.importAwareProcessor]; root of factory hierarchy at java.lang.Thread.run(Thread.java:745)2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:243 - Returning cached instance of singleton bean 'org.springframework.context.annotation.internalConfigurationAnnotationProcessor' 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:243 - Returning cached instance of singleton bean 'org.springframework.context.annotation.internalAutowiredAnnotationProcessor' 2015-08-18 14:45:42 DEBUG DefaultListableBeanFactory:243 - Returning cached instance of singleton bean 'org.springframework.context.annotation.internalRequiredAnnotationProcessor'
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-132237051 Travis error is due to timeout. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
GitHub user pedro-martins opened a pull request: https://github.com/apache/cloudstack/pull/714 Changed variable s_logger to non-static and fixed its name in âcom.cloud.utils.component.ComponentLifecycleBaseâ and its subclasses Hi guys, We have noticed that every single class that is a subclass of âComponentLifecycleBaseâ instantiate their on âloggerâ manually and uses a nonstandard name. We fixed that by changing the variable in âComponentLifecycleBaseâ to protected and non-static and instantiated it using the method âgetClassâ from Object class. Therefore, we can reduce the code in a few hundred lines and use a more intuitive name for the logger variable. During that process we found a static method that used the âs_loggerâ variable in classes: com.cloud.network.element.VirtualRouterElement org.apache.cloudstack.network.element.InternalLoadBalancerElement To fix that we had to create a new class âcom.cloud.network.element.HAProxyLBRuleâ, instantiate it with @Componente and inject into the aforementioned classes. The class that we create is âcom.cloud.network.element.HAProxyLBRuleâ and has the following methods: com.cloud.network.element.HAProxyLBRule.containsOnlyNumbers(String, String) com.cloud.network.element.HAProxyLBRule.validateHAProxyLBRule(LoadBalancingRule) Sadly we could not write test cases to it; hence we did not fully understand those methods. However, if anyone out there understands it, we would appreciate some code to be added to it. As minor this change may seem; we believe that it enhances a little bit the ACS code by using standard name to logger variable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rafaelweingartner/cloudstack master-lrg-cs-hackday-003 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #714 commit 631dccada87c131f9b2106d9942d07cb6a61db79 Author: pedro-martins php...@gmail.com Date: 2015-08-18T14:54:20Z Changed the variable in âComponentLifecycleBaseâ to protected and non-static and instantiated it using the method âgetClassâ from Object class. Therefore, we can reduce the code in a few hundred lines and use a more intuitive name for the logger variable. During that process we found a static method that used the âs_loggerâ variable in classes: com.cloud.network.element.VirtualRouterElement org.apache.cloudstack.network.element.InternalLoadBalancerElement To fix that we had to create a new class âcom.cloud.network.element.HAProxyLBRuleâ, instantiate it with @Componente and inject into the aforementioned classes. The class that we create is âcom.cloud.network.element.HAProxyLBRuleâ and has the following methods: com.cloud.network.element.HAProxyLBRule.containsOnlyNumbers(String, String) com.cloud.network.element.HAProxyLBRule.validateHAProxyLBRule(LoadBalancingRule) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8740: add custom.css to make c...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/704#issuecomment-132234421 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-noredist #4535
See http://jenkins.buildacloud.org/job/build-master-noredist/4535/changes Changes: [radu.stefanache] Typo correction -- [...truncated 7918 lines...] at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) net.sourceforge.pmd.RuleSetNotFoundException: Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar at net.sourceforge.pmd.RuleSetReferenceId.getInputStream(RuleSetReferenceId.java:315) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetReferenceNode(RuleSetFactory.java:303) at net.sourceforge.pmd.RuleSetFactory.parseRuleNode(RuleSetFactory.java:262) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:219) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) java.lang.RuntimeException: Couldn't find the class Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar at net.sourceforge.pmd.RuleSetFactory.classNotFoundProblem(RuleSetFactory.java:247) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:237) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:25) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) net.sourceforge.pmd.RuleSetNotFoundException: Can't find resource 'rulesets/java/basic.xml' for rule 'null'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Here's the current classpath: /home/jenkins/acs/tools/hudson.tasks.Maven_MavenInstallation/maven-3.1.1/boot/plexus-classworlds-2.5.1.jar at net.sourceforge.pmd.RuleSetReferenceId.getInputStream(RuleSetReferenceId.java:315) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetReferenceNode(RuleSetFactory.java:303) at net.sourceforge.pmd.RuleSetFactory.parseRuleNode(RuleSetFactory.java:262) at net.sourceforge.pmd.RuleSetFactory.parseRuleSetNode(RuleSetFactory.java:219) at net.sourceforge.pmd.RuleSetFactory.createRuleSet(RuleSetFactory.java:164) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:129) at net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114) at net.sourceforge.pmd.processor.PmdRunnable$PmdThread.getRuleSets(PmdRunnable.java:113) at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:63) at
Build failed in Jenkins: build-master-slowbuild #2089
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2089/ -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-plugin-network-srx --- [INFO] Fork Value is true [INFO] Done FindBugs Analysis [INFO] [INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-srx --- [INFO] BugInstance size is 0 [INFO] Error size is 0 [INFO] No errors/warnings found [INFO] [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [ERROR] Aug 18, 2015 2:10:12 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler saveCoverageData INFO: Cobertura: Saved information on 21 classes. [INFO] Instrumentation was successful. [INFO] NOT adding cobertura ser file to attached artifacts list. [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-srx --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/juniper-srx/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-srx --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-srx --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-srx --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/JuniperSRXFirewallElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 1146ms [ERROR] Aug 18, 2015 2:10:17 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 1222ms [ERROR] Aug 18, 2015 2:10:19 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 21 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Nuage VSP 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-vsp --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-vsp --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-vsp --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vsp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-vsp --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 43 source files to http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/nuage-vsp/target/classes [INFO] - [ERROR] COMPILATION ERROR :
[GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/712#issuecomment-132229241 Thanks @milamberspace it should be possible to merge it before 4.6 RC. Let's find some reviewers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Disablestorage pep8
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/703#issuecomment-132234105 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/712#issuecomment-132252988 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8740: add custom.css to make c...
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/704#issuecomment-132252887 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-noredist #4538
See http://jenkins.buildacloud.org/job/build-master-noredist/4538/changes Changes: [rene.moser] CLOUDSTACK-8740: add custom.css to make custom UI styles easier -- [...truncated 8409 lines...] 2015-08-18 16:12:21 DEBUG Ovm3HypervisorResource:389 - override connection: null [INFO] [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ cloud-engine-storage --- 2015-08-18 16:12:21 DEBUG Ovm3HypervisorResource:345 - configure ovm-1 with params: {agentusername=oracle, public.network.device=xenbr0, xenserver.heartbeat.interval=60, private.network.device=xenbr0, agentpassword=unknown, Hypervisor.Version=4.1.3OVM, secondary.storage.vm=false, Host.OS=Oracle VM Server, ovm3pool=true, ipaddress=192.168.1.64, password=unknown, username=root, pool=a9c1219d-817d-4242-b23e-2607801c79d5, ismaster=false, storage.network.device=xenbr0, ovm3.heartbeat.timeout=120, Host.OS.Version=5.7, xenserver.nics.max=7, agentVersion=3.2.1-183, router.aggregation.command.each.timeout=3, pod=1, istest=true, max.template.iso.size=50, host=ovm-1, com.cloud.network.Networks.RouterPrivateIpStrategy=DcGlobal, agentport=8899, Host.OS.Kernel.Version=2.6.39-300.22.2.el5uek, migratewait=3600, storage.network.device1=xenbr0, ovm3.heartbeat.interval=1, ip=192.168.1.64, ovm3cluster=false, guid=19e5f1e7-22f4-3b6d-8d41-c82f89c65295, ovm3vip=192.168.1.230, hasmaster=true, cluster=1, guest.network.device=xenbr0, zone=1, xenserver.heartbeat.timeout=120} 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: check_dom0_ip - [192.168.1.230] 2015-08-18 16:12:21 DEBUG Ovm3HypervisorSupport:587 - ovm-1 is a master, already has vip 192.168.1.230 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: discover_network - [] 2015-08-18 16:12:21 DEBUG Ovm3HypervisorNetwork:75 - already have control0 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: ovs_ip_config - [control0, static, 169.254.0.1, 255.255.0.0] 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: ovs_control_interface - [control0, 169.254.0.0/16] 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: discover_hardware - [] 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: discover_server - [] 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: update_server_roles - [xen,utility] 2015-08-18 16:12:21 DEBUG Ovm3StoragePool:164 - Host ovm-1 owned by us 2015-08-18 16:12:21 DEBUG Ovm3HypervisorResource:208 - executeRequest called: class com.cloud.agent.api.PingTestCommand 2015-08-18 16:12:21 DEBUG Ovm3HypervisorResource:389 - override connection: null 2015-08-18 16:12:21 DEBUG Ovm3HypervisorResource:345 - configure ovm-1 with params: {agentusername=oracle, public.network.device=xenbr0, xenserver.heartbeat.interval=60, private.network.device=xenbr0, agentpassword=unknown, Hypervisor.Version=4.1.3OVM, secondary.storage.vm=false, Host.OS=Oracle VM Server, ovm3pool=true, ipaddress=192.168.1.64, password=unknown, username=root, pool=a9c1219d-817d-4242-b23e-2607801c79d5, ismaster=false, storage.network.device=xenbr0, ovm3.heartbeat.timeout=120, Host.OS.Version=5.7, xenserver.nics.max=7, agentVersion=3.2.1-183, router.aggregation.command.each.timeout=3, pod=1, istest=true, max.template.iso.size=50, host=ovm-1, com.cloud.network.Networks.RouterPrivateIpStrategy=DcGlobal, agentport=8899, Host.OS.Kernel.Version=2.6.39-300.22.2.el5uek, migratewait=3600, storage.network.device1=xenbr0, ovm3.heartbeat.interval=1, ip=192.168.1.64, ovm3cluster=false, guid=19e5f1e7-22f4-3b6d-8d41-c82f89c65295, ovm3vip=192.168.1.230, hasmaster=true, cluster=1, guest.network.device=xenbr0, zone=1, xenserver.heartbeat.timeout=120} 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: check_dom0_ip - [192.168.1.230] 2015-08-18 16:12:21 DEBUG Ovm3HypervisorSupport:587 - ovm-1 is a master, already has vip 192.168.1.230 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: discover_network - [] 2015-08-18 16:12:21 DEBUG Ovm3HypervisorNetwork:75 - already have control0 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: ovs_ip_config - [control0, static, 169.254.0.1, 255.255.0.0] 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: ovs_control_interface - [control0, 169.254.0.0/16] 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: discover_hardware - [] 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: discover_server - [] 2015-08-18 16:12:21 DEBUG ConnectionTest:67 - methodresponse call: update_server_roles - [xen,utility] 2015-08-18 16:12:21 DEBUG Ovm3StoragePool:164 - Host ovm-1 owned by us 2015-08-18 16:12:21 DEBUG Ovm3HypervisorResource:208 - executeRequest called: class com.cloud.agent.api.CheckNetworkCommand 2015-08-18 16:12:21 DEBUG Ovm3HypervisorNetwork:119 - Checking if network name setup is done on ovm-1 2015-08-18 16:12:21 DEBUG Ovm3HypervisorNetwork:99 - Looking
Review PRs: please help!
Hi all, Could you please have a look at the PRs we have waiting [1] and review them? Test it, look at the code or otherwise review them. Add comments, or add a LGTM when you think it’s OK. Even if you review just one PR per day it already helps :-) I’ll keep an eye on them as well and will merge when the requirements are met. Thanks, Remi [1] https://github.com/apache/cloudstack/pulls
[GitHub] cloudstack pull request: CLOUDSTACK-8740: add custom.css to make c...
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/704#issuecomment-132253205 so there is nothing in this custom.css file ? LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/699#issuecomment-132253698 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-132253810 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---