[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

2015-09-11 Thread bvbharatk
GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/800

CLOUDSTACK-8798 Fixed the vrrp virtual ip config in case of rvr enabl…

Fixed the vrrp virtual ip config in case of rvr enabled isolated networks.
changed the CsRedundant.py to bring down the public interface when rvr 
changes state to
backup. Also fixed vrrp authentication for isolated networks.

This fix dose not effect the vpc networks. it is only meant for rvr 
isolated networks.

manullay deployed a vm in rvr enabled isolated network and ran the tests 
below.

nosetests --with-marvin --marvin-config=/marvin-config 
test/integration/component/test_redundant_router_services.py

Test redundant router internals ... === TestName: test_enableVPNOverRvR | 
Status : SUCCESS ===
ok
--
Ran 1 test in 633.336s
OK
nosetests --with-marvin --marvin-config=/marvin-config 
test/integration/component/test_redundant_router_cleanups.py

Test network garbage collection with RVR ... === TestName: test_network_gc 
| Status : SUCCESS ===
ok
Test restarting RvR network without cleanup ... === TestName: 
test_restart_ntwk_no_cleanup | Status : SUCCESS ===
ok
Test restart RvR network with cleanup ... === TestName: 
test_restart_ntwk_with_cleanup | Status : SUCCESS ===
ok
--
Ran 3 tests in 2120.263s
OK

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-8798

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #800


commit 6f68ecc3bfec6b5d614a49029b03599064e59e15
Author: Bharat Kumar 
Date:   2015-08-14T08:42:28Z

CLOUDSTACK-8798 Fixed the vrrp virtual ip config in case of rvr enabled 
isolated networks.
changed the CsRedundant.py to bring down the public interface when rvr 
changes state to
backup. Also fixed vrrp authentication for isolated networks.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Repo still pointing 4.5.1

2015-09-11 Thread Keerthiraja SJ
Hi All,

I tried to validate the 4.5.2 after pointing the repo below and did the yum
install cloud-management still I could see yum pushes on the 4.5.1 not the
4.5.2.

cat /etc/yum.repos.d/cloudstack.repo
[cloudstack]
name=cloudstack
baseurl=http://cloudstack.apt-get.eu/rhel/4.5/
enabled=1
gpgcheck=0


Dependencies Resolved

===
 Package
Arch
Version
Repository Size
===
Installing:
 cloudstack-management
x86_64
4.5.1-shapeblue0.el6
cloudstack 88 M
Installing for dependencies:
 ConsoleKit
x86_64
0.4.1-3.el6
base   82 k
 ConsoleKit-libs
x86_64
0.4.1-3.el6
base   17 k
 GConf2
x86_64
2.28.0-6.el6
base  964 k
 MySQL-python
x86_64
1.2.3-0.3.c1.1.el6
base   86 k
 ORBit2
x86_64
2.14.17-5.el6
base  168 k
 OpenIPMI
x86_64
2.0.16-14.el6
base  156 k
 OpenIPMI-libs
x86_64
2.0.16-14.el6
base  473 k
 alsa-lib
x86_64
1.0.22-3.el6
base  370 k
 apache-tomcat-apis
noarch
0.1-1.el6
base  164 k
 at
x86_64
3.1.10-48.el6
base   61 k
 atk
x86_64
1.30.0-1.el6
base  195 k
 avahi-libs
x86_64
0.6.25-15.el6
base   55 k
 axis
noarch
1.2.1-7.5.el6_5
base  1.5 M
 bc
x86_64
1.06.95-1.el6
base  110 k
 bcel
x86_64
5.2-7.2.el6
base  1.4 M
 cairo
x86_64
1.8.8-6.el6_6
base  309 k
 classpathx-jaf
x86_64
1.0-15.4.el6
base  100 k
 classpathx-mail
noarch
1.1.1-9.4.el6
base  479 k
 cloudstack-awsapi
x86_64
4.5.1-shapeblue0.el6
cloudstack 85 M
 cloudstack-common
x86_64
4.5.1-shapeblue0.el6
cloudstack109 M
 cups-libs
x86_64
1:1.4.2-72.el6
base  321 k
 cvs
x86_64
1.11.23-16.el6
base  712 k
 db4-cxx
x86_64
4.7.25-19.el6_6
base  588 k
 db4-devel
x86_64
4.7.25-19.el6_6
base  6.6 M
 dbus
x86_64
1:1.2.24-8.el6_6
base  207 k
 ecj
x86_64
1:3.4.2-6.el6
base  2.8 M
 ed
x86_64
1.1-3.3.el6
base   72 k
 eggdbus
x86_64
0.6-3.el6
base   91 k
 flac
x86_64
1.2.1-7.el6_6
base  242 k
 fontconfig
x86_64
2.8.0-5.el6
base  186 k
 freetype
x86_64
2.3.11-15.el6_6.1
base  361 k
 gdbm-devel
x86_64
1.8.0-38.el6
base   25 k
 gdk-pixbuf2
x86_64
2.24.1-6.el6_7
updates   501 k
 genisoimage
x86_64
1.1.9-12.el6
base  348 k
 geronimo-specs
noarch
1.0-3.5.M2.el6
base  111 k
 geronimo-specs-compat
noarch
1.0-3.5.M2.el6
base  7.1 k
 gettext
x86_64
0.17-18.el6
base  1.8 M
 giflib
x86_64
4.1.6-3.1.el6
base   37 k
 glibc
i686
2.12-1.166.el6_7.1
updates   4.3 M
 glibc-devel
x86_64
2.12-1.166.el6_7.1
updates   985 k
 glibc-headers
x86_64
2.12-1.166.el6_7.1
updates   614 k
 gnutls
x86_64
2.8.5-18.el6
base  347 k
 gtk2
x86_64
2.24.23-6.el6
base  3.2 M
 hicolor-icon-theme
noarch
0.11-1.1.el6
base   40 k
 ipmitool
x86_64
1.8.11-28.el6
base  464 k
 jakarta-commons-collections
noarch
3.2.1-3.4.el6
base  523 k
 jakarta-commons-daemon
x86_64
1:1.0.1-8.9.el6
base   45 k
 jakarta-commons-dbcp
noarch
1.2.1-13.8.el6
base  116 k
 jakarta-commons-discovery
noarch
1:0.4-5.4.el6
base   73 k
 jakarta-commons-httpclient
x86_64

Re: Repo still pointing 4.5.1

2015-09-11 Thread Keerthiraja SJ
Really need someone to do createrepo because the repodata seems to be very
old.

repodata/ 2015-05-07
16:04

Kindly do the need full as soon as possible.

Thanks,
Keerthi

On Fri, Sep 11, 2015 at 11:43 AM, Keerthiraja SJ 
wrote:

> Hi All,
>
> I tried to validate the 4.5.2 after pointing the repo below and did the
> yum install cloud-management still I could see yum pushes on the 4.5.1 not
> the 4.5.2.
>
> cat /etc/yum.repos.d/cloudstack.repo
> [cloudstack]
> name=cloudstack
> baseurl=http://cloudstack.apt-get.eu/rhel/4.5/
> enabled=1
> gpgcheck=0
>
>
> Dependencies Resolved
>
>
> ===
>  Package
> Arch
> Version
> Repository Size
>
> ===
> Installing:
>  cloudstack-management
> x86_64
> 4.5.1-shapeblue0.el6
> cloudstack 88 M
> Installing for dependencies:
>  ConsoleKit
> x86_64
> 0.4.1-3.el6
> base   82 k
>  ConsoleKit-libs
> x86_64
> 0.4.1-3.el6
> base   17 k
>  GConf2
> x86_64
> 2.28.0-6.el6
> base  964 k
>  MySQL-python
> x86_64
> 1.2.3-0.3.c1.1.el6
> base   86 k
>  ORBit2
> x86_64
> 2.14.17-5.el6
> base  168 k
>  OpenIPMI
> x86_64
> 2.0.16-14.el6
> base  156 k
>  OpenIPMI-libs
> x86_64
> 2.0.16-14.el6
> base  473 k
>  alsa-lib
> x86_64
> 1.0.22-3.el6
> base  370 k
>  apache-tomcat-apis
> noarch
> 0.1-1.el6
> base  164 k
>  at
> x86_64
> 3.1.10-48.el6
> base   61 k
>  atk
> x86_64
> 1.30.0-1.el6
> base  195 k
>  avahi-libs
> x86_64
> 0.6.25-15.el6
> base   55 k
>  axis
> noarch
> 1.2.1-7.5.el6_5
> base  1.5 M
>  bc
> x86_64
> 1.06.95-1.el6
> base  110 k
>  bcel
> x86_64
> 5.2-7.2.el6
> base  1.4 M
>  cairo
> x86_64
> 1.8.8-6.el6_6
> base  309 k
>  classpathx-jaf
> x86_64
> 1.0-15.4.el6
> base  100 k
>  classpathx-mail
> noarch
> 1.1.1-9.4.el6
> base  479 k
>  cloudstack-awsapi
> x86_64
> 4.5.1-shapeblue0.el6
> cloudstack 85 M
>  cloudstack-common
> x86_64
> 4.5.1-shapeblue0.el6
> cloudstack109 M
>  cups-libs
> x86_64
> 1:1.4.2-72.el6
> base  321 k
>  cvs
> x86_64
> 1.11.23-16.el6
> base  712 k
>  db4-cxx
> x86_64
> 4.7.25-19.el6_6
> base  588 k
>  db4-devel
> x86_64
> 4.7.25-19.el6_6
> base  6.6 M
>  dbus
> x86_64
> 1:1.2.24-8.el6_6
> base  207 k
>  ecj
> x86_64
> 1:3.4.2-6.el6
> base  2.8 M
>  ed
> x86_64
> 1.1-3.3.el6
> base   72 k
>  eggdbus
> x86_64
> 0.6-3.el6
> base   91 k
>  flac
> x86_64
> 1.2.1-7.el6_6
> base  242 k
>  fontconfig
> x86_64
> 2.8.0-5.el6
> base  186 k
>  freetype
> x86_64
> 2.3.11-15.el6_6.1
> base  361 k
>  gdbm-devel
> x86_64
> 1.8.0-38.el6
> base   25 k
>  gdk-pixbuf2
> x86_64
> 2.24.1-6.el6_7
> updates   501 k
>  genisoimage
> x86_64
> 1.1.9-12.el6
> base  348 k
>  geronimo-specs
> noarch
> 1.0-3.5.M2.el6
> base  111 k
>  geronimo-specs-compat
> noarch
> 1.0-3.5.M2.el6
> base  7.1 k
>  gettext
> x86_64
> 0.17-18.el6
> base  1.8 M
>  giflib
> x86_64
> 4.1.6-3.1.el6
> base   37 k
>  glibc
> i686
> 2.12-1.166.el6_7.1
> updates   4.3 M
>  glibc-devel
> x86_64
> 2.12-1.166.el6_7.1
> updates   985 k
>  glibc-headers
> x86_64
> 2.12-1.166.el6_7.1
> updates   614 k
>  gnutls
> x86_64
> 2.8.5-18.el6
> base  

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-11 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/728#issuecomment-139586066
  
I reverted the directed commit and merged this pr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2282

2015-09-11 Thread jenkins
See 

Changes:

[shweta.agarwal] CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for 
CentOS 5.9

[bharat.kumar] CLOUDSTACK-8798 Fixed the vrrp virtual ip config in case of rvr 
enabled isolated networks.

[Rajani Karuturi] Revert "CLOUDSTACK-8756:Incorrect guest os mapping in CCP 
4.2.1-6 for CentOS 5.9"

--
[...truncated 28183 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[3.725s]
[INFO] Apache CloudStack . SUCCESS [2.626s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.801s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.601s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.041s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.106s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [55.651s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.126s]
[INFO] Apache CloudStack API . SUCCESS [1:59.423s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.997s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [31.236s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.121s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.525s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.145s]
[INFO] Apache CloudStack Core  SUCCESS [1:19.988s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.375s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.638s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.034s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:12.594s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.374s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [31.723s]
[INFO] Apache CloudStack Server .. SUCCESS [4:28.050s]
[INFO] Apache CloudStack Usage Server  SUCCESS [50.673s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:33.210s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.082s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.439s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [56.177s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [1:02.145s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [34.484s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [27.833s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [23.259s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.121s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [34.464s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.147s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.816s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.767s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.864s]
[INFO] Apache CloudStack Plugin - Storage 

[GitHub] cloudstack pull request: Fixed secstorage.proxy is not setting pro...

2015-09-11 Thread anshul1886
GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/802

Fixed secstorage.proxy is not setting proxy configuration on SSVM in some 
cases



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8828

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/802.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #802


commit 2c81ebe72f0215d5cc27a10970ef0a3b259e0017
Author: Anshul Gangwar 
Date:   2015-09-11T08:07:08Z

Fixed secstorage.proxy is not setting proxy configuration on SSVM in some 
cases




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-11 Thread anshul1886
GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/804

CLOUDSTACK-8834: Fixed unable to download Template , when in multi zones

We were listing image stores by zone id which was resulting in listing of 
only one image store
If in that image store its download state is not DOWNLOADED then download 
template is failing

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8834

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #804


commit 8511d62b5aee6976f2eecd32506402de47858215
Author: Anshul Gangwar 
Date:   2015-06-11T06:02:08Z

CLOUDSTACK-8834: Fixed unable to download Template , when in multi zones
We were listing image stores by zone id which was resulting in listing of 
only one image store
If in that image store its download state is not DOWNLOADED then download 
template is failing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-11 Thread nlivens
GitHub user nlivens opened a pull request:

https://github.com/apache/cloudstack/pull/801

CLOUDSTACK-8832 : Update Nuage VSP plugin to work with Nuage VSP rele…

…ase 3.2

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nlivens/cloudstack updated-nuage-vsp-plugin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/801.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #801


commit 6602ccb6b13f2b77d70cd5a4448fc56eccd7bce1
Author: Nick Livens 
Date:   2015-09-11T07:57:13Z

CLOUDSTACK-8832 : Update Nuage VSP plugin to work with Nuage VSP release 3.2




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

2015-09-11 Thread Wido den Hollander


On 10-09-15 23:15, Andrija Panic wrote:
> Wido,
> 
> could you folow maybe what my colegue Dmytro just sent ?
> 

Yes, seems logical.

> Its not only matter of question fixing rados-java (16 snaps limit)  - it
> seems that for any RBD exception, ACS will freak out...
> 

No, a RbdException will be caught, but the Rados Bindings shouldn't
throw NegativeArraySizeException in any case.

That's the main problem.

Wido

> THx
> 
> On 10 September 2015 at 17:06, Dmytro Shevchenko <
> dmytro.shevche...@safeswisscloud.com> wrote:
> 
>> Hello everyone, some clarification about this. Configuration:
>> CS: 4.5.1
>> Primary storage: Ceph
>>
>> Actually we have 2 separate bugs:
>>
>> 1. When you remove some volume with more then 16 snapshots (doesn't matter
>> destroyed or active - they always present on Ceph), on next storage garbage
>> collector cycle it invoke 'deletePhysicalDisk' from
>> LibvirtStorageAdaptor.java. On line 854 we calling list snapshots from
>> external rados-java library and getting exception.
>>
>> https://github.com/apache/cloudstack/blob/4.5.1/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java#L854
>> This exception do not catching in current function, but Agent DO NOT CRASH
>> at this moment and continue working fine. Agent form proper answer to
>> server and send it, text in answer - java stack trace. Log from Agent side:
>>
>> 2015-09-10 02:32:35,312 DEBUG [kvm.storage.LibvirtStorageAdaptor]
>> (agentRequest-Handler-4:null) Trying to fetch storage pool
>> 33ebaf83-5d09-3038-b63b-742e759a
>> 992e from libvirt
>> 2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
>> (agentRequest-Handler-4:null) Attempting to remove volume
>> 4c6a2092-056c-4446-a2ca-d6bba9f7f
>> 7f8 from pool 33ebaf83-5d09-3038-b63b-742e759a992e
>> 2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
>> (agentRequest-Handler-4:null) Unprotecting and Removing RBD snapshots of
>> image cloudstack-storage
>> /4c6a2092-056c-4446-a2ca-d6bba9f7f7f8 prior to removing the image
>> 2015-09-10 02:32:35,436 DEBUG [kvm.storage.LibvirtStorageAdaptor]
>> (agentRequest-Handler-4:null) Succesfully connected to Ceph cluster at
>> 10.10.1.26:6789
>> 2015-09-10 02:32:35,454 DEBUG [kvm.storage.LibvirtStorageAdaptor]
>> (agentRequest-Handler-4:null) Fetching list of snapshots of RBD image
>> cloudstack-storage/4c6a2092
>> -056c-4446-a2ca-d6bba9f7f7f8
>> 2015-09-10 02:32:35,457 WARN  [cloud.agent.Agent]
>> (agentRequest-Handler-4:null) Caught:
>> java.lang.NegativeArraySizeException
>> at com.ceph.rbd.RbdImage.snapList(Unknown Source)
>> at
>> com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor.deletePhysicalDisk(LibvirtStorageAdaptor.java:854)
>> at
>> com.cloud.hypervisor.kvm.storage.LibvirtStoragePool.deletePhysicalDisk(LibvirtStoragePool.java:175)
>> at
>> com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.deleteVolume(KVMStorageProcessor.java:1206)
>> 2015-09-10 02:32:35,458 DEBUG [cloud.agent.Agent]
>> (agentRequest-Handler-4:null) Seq 1-1743737480722513946:  { Ans: , MgmtId:
>> 90520739779588, via: 1, Ver: v1,
>>  Flags: 10,
>> [{"com.cloud.agent.api.Answer":{"result":false,"details":"java.lang.NegativeArraySizeException\n\tat
>> com.ceph.rbd.RbdImage.snapList(Unknown Sourc
>> e)\n\tat
>> com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor.deletePhysicalDisk(LibvirtStorageAdaptor.java:854)\n\tat
>> com.cloud.hypervisor.kvm.storage.Lib
>> virtStoragePool.deletePhysicalDisk(LibvirtStoragePool.java:175)\n\tat
>> com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.deleteVolume(KVMStorageProcessor.j
>> ava:1206)\n\tat
>> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:124)\n\tat
>> com.cloud.storage.re.
>>
>> so this volume and it snapshots never will be removed.
>>
>>
>> 2. Second bug. Experimentally it has been found that after 50 minutes we
>> had exception on Agent, for some unknown reason Management server decided
>> about it lost connection to this agent, start HA process and start Agent
>> process again.
>> Log on Agent side:
>> 2015-09-10 02:57:12,664 DEBUG [kvm.resource.LibvirtComputingResource]
>> (agentRequest-Handler-2:null) Executing: /bin/bash -c free|grep Mem:|awk
>> '{print $2}'
>> 2015-09-10 02:57:12,667 DEBUG [kvm.resource.LibvirtComputingResource]
>> (agentRequest-Handler-2:null) Execution is successful.
>> 2015-09-10 02:57:40,502 DEBUG [kvm.resource.LibvirtComputingResource]
>> (UgentTask-5:null) Executing:
>> /usr/share/cloudstack-common/scripts/vm/network/security_
>> group.py get_rule_logs_for_vms
>> 2015-09-10 02:57:40,572 DEBUG [kvm.resource.LibvirtComputingResource]
>> (UgentTask-5:null) Execution is successful.
>> 2015-09-10 02:57:54,135 INFO  [cloud.agent.AgentShell] (main:null) Agent
>> started
>> 2015-09-10 02:57:54,136 INFO  [cloud.agent.AgentShell] (main:null)
>> Implementation Version is 4.5.1
>> 2015-09-10 02:57:54,138 INFO  

[GitHub] cloudstack pull request: CLOUDSTACK-5863: Add unit tests for volum...

2015-09-11 Thread borisroman
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/796#issuecomment-139489439
  
LGTM -> Test run fine and increase coverage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Repo still pointing 4.5.1

2015-09-11 Thread Wido den Hollander

On 11-09-15 08:20, Keerthiraja SJ wrote:
> Really need someone to do createrepo because the repodata seems to be very
> old.
> 
> repodata/ 2015-05-07
> 16:04
> 
> Kindly do the need full as soon as possible.
> 

That should be fixed now!

Wido

> Thanks,
> Keerthi
> 
> On Fri, Sep 11, 2015 at 11:43 AM, Keerthiraja SJ 
> wrote:
> 
>> Hi All,
>>
>> I tried to validate the 4.5.2 after pointing the repo below and did the
>> yum install cloud-management still I could see yum pushes on the 4.5.1 not
>> the 4.5.2.
>>
>> cat /etc/yum.repos.d/cloudstack.repo
>> [cloudstack]
>> name=cloudstack
>> baseurl=http://cloudstack.apt-get.eu/rhel/4.5/
>> enabled=1
>> gpgcheck=0
>>
>>
>> Dependencies Resolved
>>
>>
>> ===
>>  Package
>> Arch
>> Version
>> Repository Size
>>
>> ===
>> Installing:
>>  cloudstack-management
>> x86_64
>> 4.5.1-shapeblue0.el6
>> cloudstack 88 M
>> Installing for dependencies:
>>  ConsoleKit
>> x86_64
>> 0.4.1-3.el6
>> base   82 k
>>  ConsoleKit-libs
>> x86_64
>> 0.4.1-3.el6
>> base   17 k
>>  GConf2
>> x86_64
>> 2.28.0-6.el6
>> base  964 k
>>  MySQL-python
>> x86_64
>> 1.2.3-0.3.c1.1.el6
>> base   86 k
>>  ORBit2
>> x86_64
>> 2.14.17-5.el6
>> base  168 k
>>  OpenIPMI
>> x86_64
>> 2.0.16-14.el6
>> base  156 k
>>  OpenIPMI-libs
>> x86_64
>> 2.0.16-14.el6
>> base  473 k
>>  alsa-lib
>> x86_64
>> 1.0.22-3.el6
>> base  370 k
>>  apache-tomcat-apis
>> noarch
>> 0.1-1.el6
>> base  164 k
>>  at
>> x86_64
>> 3.1.10-48.el6
>> base   61 k
>>  atk
>> x86_64
>> 1.30.0-1.el6
>> base  195 k
>>  avahi-libs
>> x86_64
>> 0.6.25-15.el6
>> base   55 k
>>  axis
>> noarch
>> 1.2.1-7.5.el6_5
>> base  1.5 M
>>  bc
>> x86_64
>> 1.06.95-1.el6
>> base  110 k
>>  bcel
>> x86_64
>> 5.2-7.2.el6
>> base  1.4 M
>>  cairo
>> x86_64
>> 1.8.8-6.el6_6
>> base  309 k
>>  classpathx-jaf
>> x86_64
>> 1.0-15.4.el6
>> base  100 k
>>  classpathx-mail
>> noarch
>> 1.1.1-9.4.el6
>> base  479 k
>>  cloudstack-awsapi
>> x86_64
>> 4.5.1-shapeblue0.el6
>> cloudstack 85 M
>>  cloudstack-common
>> x86_64
>> 4.5.1-shapeblue0.el6
>> cloudstack109 M
>>  cups-libs
>> x86_64
>> 1:1.4.2-72.el6
>> base  321 k
>>  cvs
>> x86_64
>> 1.11.23-16.el6
>> base  712 k
>>  db4-cxx
>> x86_64
>> 4.7.25-19.el6_6
>> base  588 k
>>  db4-devel
>> x86_64
>> 4.7.25-19.el6_6
>> base  6.6 M
>>  dbus
>> x86_64
>> 1:1.2.24-8.el6_6
>> base  207 k
>>  ecj
>> x86_64
>> 1:3.4.2-6.el6
>> base  2.8 M
>>  ed
>> x86_64
>> 1.1-3.3.el6
>> base   72 k
>>  eggdbus
>> x86_64
>> 0.6-3.el6
>> base   91 k
>>  flac
>> x86_64
>> 1.2.1-7.el6_6
>> base  242 k
>>  fontconfig
>> x86_64
>> 2.8.0-5.el6
>> base  186 k
>>  freetype
>> x86_64
>> 2.3.11-15.el6_6.1
>> base  361 k
>>  gdbm-devel
>> x86_64
>> 1.8.0-38.el6
>> base   25 k
>>  gdk-pixbuf2
>> x86_64
>> 2.24.1-6.el6_7
>> updates   501 k
>>  genisoimage
>> x86_64
>> 1.1.9-12.el6
>> base  348 k
>>  geronimo-specs
>> noarch
>> 1.0-3.5.M2.el6
>> base  111 k
>>  geronimo-specs-compat
>> noarch
>> 1.0-3.5.M2.el6
>> base  7.1 k
>>  gettext
>> x86_64
>> 0.17-18.el6
>> base  1.8 M
>>  giflib
>> x86_64
>> 4.1.6-3.1.el6
>> base   37 k
>>  glibc
>> i686
>> 2.12-1.166.el6_7.1
>> 

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

2015-09-11 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/795#issuecomment-139493789
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Cloudstack 4.5.2 startup ERROR

2015-09-11 Thread Keerthiraja SJ
Hi All,

After successfully installation I could while starting the
cloudstack-management ther seems to some error while connecting to my
database.

I am right now into production setup.

ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to upgrade the
database
com.cloud.utils.exception.CloudRuntimeException: Unable to execute upgrade
script: /usr/share/cloudstack-management/setup/db/schema-40to410.sql

ERROR [c.c.u.d.ScriptRunner] (main:null) Error executing: alter table
vm_template add size bigint unsigned
ERROR [c.c.u.d.ScriptRunner] (main:null)
com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate column
name 'size'
ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to execute upgrade
script: /usr/share/cloudstack-management/setup/db/schema-40to410.sql


The Version of the MYSQL

MariaDB-server-10.1.7-1.el6.x86_64
MariaDB-common-10.1.7-1.el6.x86_64
MariaDB-client-10.1.7-1.el6.x86_64

If this is not the right version MARIADB then what version should I have to
install.

Thanks,
Keerthi


[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

2015-09-11 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request:

https://github.com/apache/cloudstack/pull/805

CLOUDSTACK-8822 - Replacing Runnable by Callable

That's the first part of the refactor, which will touch the 
ManagedContextRunnable and all its subclasses. However, in order to reduce 
impact, the first part comprises the Agent and Nio related classes 
(NioConnection, NioServer and NioClient).
 
* All the sub-classes were also updated according to the changes in the 
super-classes
* Improved exception handling
* There were also code formatting changes

Changes were structural and the NioTest covered them without need to modify 
the unit test.

This PR is quite extensive. Please, wait for the Test Report in order to 
proceed with further review.

ping @remibergsma @miguelaferreira @bhaisaab @karuturi @wido @DaanHoogland 
@borisroman @K0zka 

Cheers,
Wilder

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekholabs/cloudstack 
improvement/callable_CLOUDSTACK-8822

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #805


commit 79a3f8c5774c50dc128968c29da5096dc3dde39e
Author: wilderrodrigues 
Date:   2015-09-08T10:12:55Z

CLOUDSTACK-8822 - Replacing Runnable by Callable in the Taks and 
NioConnection classes

   - All the sub-classes were also updated according to the changes in the 
super-classes
   - There were also code formatting changes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

2015-09-11 Thread wido
Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/784#discussion_r39248790
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,25 @@ def get_control_if(self):
 return ip
 return None
 
+def check_if_link_exists(self,dev):
+cmd="ip link show dev %s"%dev
+result=CsHelper.execute(cmd)
+if(len(result)!=0):
+   return True
+else:
+   return False
+
+def check_if_link_up(self,dev):
+cmd="ip link show dev %s | tr '\n' ' ' | cut -d ' ' -f 9"%dev
--- End diff --

We should keep as much logic in Python as possible. The performance 
difference is small, but with tr and grep you spawn subprocessess again.

But as @remibergsma says. Try to open that file in /sys and parse the 
contents. You can use the simple Python file functions.

No need to execute IP. The less subprocesses we execute, the better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

2015-09-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/800#issuecomment-139486801
  
Hey @bvbharatk 

Thanks, dude! I really loved the test report! :)

LGTM :+1: 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2283

2015-09-11 Thread jenkins
See 

--
[...truncated 28183 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.721s]
[INFO] Apache CloudStack . SUCCESS [2.174s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.789s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.556s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.022s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.121s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.578s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [28.098s]
[INFO] Apache CloudStack API . SUCCESS [1:49.435s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.221s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.424s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.090s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.490s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.991s]
[INFO] Apache CloudStack Core  SUCCESS [1:16.040s]
[INFO] Apache CloudStack Agents .. SUCCESS [34.401s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.070s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.442s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:11.533s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [47.136s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [29.887s]
[INFO] Apache CloudStack Server .. SUCCESS [4:23.693s]
[INFO] Apache CloudStack Usage Server  SUCCESS [51.960s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:33.115s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.065s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.407s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [57.552s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [58.567s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [33.970s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [27.733s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [31.910s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.652s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [36.032s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.735s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.877s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.787s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [1:33.653s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[3:13.812s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[1:26.897s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [21.811s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [41.478s]
[INFO] Apache CloudStack Plugin - 

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-11 Thread ashwinswaroop
GitHub user ashwinswaroop opened a pull request:

https://github.com/apache/cloudstack/pull/810

This is the fix for the JIRA issue CLOUDSTACK-8817.

This is my first contribution to Apache CloudStack. The return values for 
endpoint and startpoint have now been changed to Integer instead of String. 
Please let me know if this is the only change that is required or if there are 
additional files which will be impacted by this change which require 
modification also.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ashwinswaroop/cloudstack feature_x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #810


commit 4d626c11bc4f029788ddc0e12340d8e880521f8b
Author: Ashwin Swaroop 
Date:   2015-09-11T22:27:31Z

This is the fix for the JIRA issue CLOUDSTACK-8817. The return values for 
endpoint and startpoint are now Integer instead of String.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-systemvm-master #621

2015-09-11 Thread jenkins
See 

Changes:

[shweta.agarwal] CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for 
CentOS 5.9

[nitinkumar.maharana] CLOUDSTACK-8821: Provide appropriate message in the UI 
when configuring the Firewall rules.

[Boris Schrijver] Removal of test/debug code.

[w.zhou] CLOUDSTACK-5863: Add unit tests for create/delete/revert volume 
snapshot

[w.zhou] CLOUDSTACK-5863: Add unit tests for take volume snapshot

[w.zhou] Fix coverity scan 1323172

[Boris Schrijver] Added Unit Test for LocalTemplateDownloader.

[bharat.kumar] CLOUDSTACK-8798 Fixed the vrrp virtual ip config in case of rvr 
enabled isolated networks.

[wrodrigues] CLOUDSTACK-8822 - Replacing Runnable by Callable in the Taks and 
NioConnection classes

[Rajani Karuturi] unittests to verify empty password is not allowed during 
account create

[sanjeev] CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for CentOS 
5.9

[wido] CLOUDSTACK-8799 fixed the defalut routes

[wido] Added QCOW2 virtual size checking for S3.

[wido] CLOUDSTACK-8799 fixed for vpc networks.

[Rajani Karuturi] Revert "CLOUDSTACK-8756:Incorrect guest os mapping in CCP 
4.2.1-6 for CentOS 5.9"

--
[...truncated 1094 lines...]
+ '[' -t 2 ']'
+ echo '[2015-09-11 21:57:33] INFO: destroying existing veewee image, if any'
[2015-09-11 21:57:33] INFO: destroying existing veewee image, if any
+ set +e
+ bundle exec veewee vbox destroy systemvmtemplate-master-4.6.0
Error:: You tried to destroy a non-existing box 'systemvmtemplate-master-4.6.0'
+ set -e
+ add_on_exit veewee_destroy
+ local n=3
+ on_exit_items[${n}]=veewee_destroy
+ '[' 3 -eq 0 ']'
+ veewee_build
+ log INFO 'building new image with veewee'
+ local level=INFO
+ shift
+ [[ 1 != \1 ]]
+ local code=
++ date '+%F %T'
+ local 'line=[2015-09-11 21:57:35] INFO: building new image with veewee'
+ '[' -t 2 ']'
+ echo '[2015-09-11 21:57:35] INFO: building new image with veewee'
[2015-09-11 21:57:35] INFO: building new image with veewee
+ bundle exec veewee vbox build systemvmtemplate-master-4.6.0 --nogui --auto
Downloading vbox guest additions iso v 4.3.14 - 
http://download.virtualbox.org/virtualbox/4.3.14/VBoxGuestAdditions_4.3.14.iso
Checking if isofile VBoxGuestAdditions_4.3.14.iso already exists.
Full path: 


   
Fetching file:   0% |  | ETA:  --:--:--
Fetching file:   1% || 656.7KB   3.8MB/s ETA:   0:00:16
Fetching file:   2% ||   1.3MB   3.6MB/s ETA:   0:00:16
Fetching file:   3% ||   1.9MB   3.3MB/s ETA:   0:00:18
Fetching file:   4% ||   2.5MB   3.2MB/s ETA:   0:00:18
Fetching file:   5% |o   |   3.1MB   3.3MB/s ETA:   0:00:18
Fetching file:   6% |o   |   3.8MB   3.3MB/s ETA:   0:00:17
Fetching file:   7% |o   |   4.4MB   3.4MB/s ETA:   0:00:17
Fetching file:   8% |o   |   5.0MB   3.4MB/s ETA:   0:00:16
Fetching file:   9% |oo  |   5.7MB   3.5MB/s ETA:   0:00:16
Fetching file:  10% |oo  |   6.3MB   3.6MB/s ETA:   0:00:15
Fetching file:  11% |oo  |   6.9MB   3.6MB/s ETA:   0:00:15
Fetching file:  12% |oo  |   7.5MB   3.7MB/s ETA:   0:00:14
Fetching file:  13% |ooo |   8.2MB   3.7MB/s ETA:   0:00:14
Fetching file:  14% |ooo |   8.8MB   3.8MB/s ETA:   0:00:14
Fetching file:  15% |ooo |   9.4MB   3.9MB/s ETA:   0:00:13
Fetching file:  16% |ooo |  10.1MB   3.9MB/s ETA:   0:00:13
Fetching file:  17% ||  10.7MB   4.0MB/s ETA:   0:00:13
Fetching file:  18% ||  11.3MB   3.9MB/s ETA:   0:00:13
Fetching file:  19% ||  11.9MB   3.9MB/s ETA:   0:00:13
Fetching file:  20% ||  12.6MB   3.8MB/s ETA:   0:00:13
Fetching file:  21% |o   |  13.2MB   3.8MB/s ETA:   0:00:13
Fetching file:  22% |o   |  13.8MB   3.8MB/s ETA:   0:00:13
Fetching file:  23% |o   |  14.5MB   3.7MB/s ETA:   0:00:12
Fetching file:  24% |o   |  15.1MB   3.8MB/s ETA:   0:00:12
Fetching file:  25% |oo  |  15.7MB   3.8MB/s ETA:   0:00:12
Fetching file:  26% |oo  |  16.4MB   3.8MB/s ETA:   0:00:12
Fetching file:  27% |oo  |  17.0MB   3.8MB/s ETA:   0:00:12
Fetching file:  28% |oo  |  17.6MB   3.8MB/s ETA:   0:00:11
Fetching file:  29% |oo  |  18.2MB   3.8MB/s ETA:   0:00:11
Fetching file:  30% |ooo |  

Build failed in Jenkins: build-master-slowbuild #2284

2015-09-11 Thread jenkins
See 

--
[...truncated 28183 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.813s]
[INFO] Apache CloudStack . SUCCESS [2.181s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.811s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.587s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.347s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.103s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.897s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.284s]
[INFO] Apache CloudStack API . SUCCESS [1:51.082s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.355s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.912s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.093s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.446s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.400s]
[INFO] Apache CloudStack Core  SUCCESS [1:16.378s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.456s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.470s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.111s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:11.929s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [46.030s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [30.997s]
[INFO] Apache CloudStack Server .. SUCCESS [4:29.954s]
[INFO] Apache CloudStack Usage Server  SUCCESS [48.021s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:34.018s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.094s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.468s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [1:04.647s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [55.187s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [32.167s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [27.222s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.864s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.528s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [36.234s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [14.177s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.799s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.728s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [2:22.607s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[2:47.741s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[1:01.155s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [21.418s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [43.003s]
[INFO] Apache CloudStack Plugin 

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-11 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request:

https://github.com/apache/cloudstack/pull/806

CLOUDSTACK-8820: Showing error when try to add vCenter 6

CLOUDSTACK-8820: Showing error when try to add advance zone using VMware 
ESXi 6.0 host

Summary: In vCenter 6.0, response headers need to be fetched after service 
login for server cookie unlike previous versions of vCenter.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sureshanaparti/cloudstack CLOUDSTACK-8820

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/806.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #806


commit 4a6e2cdeeecae6953245ce3213513f4d5dd82e7f
Author: Suresh Kumar Anaparti 
Date:   2015-09-11T10:09:09Z

CLOUDSTACK-8820: Showing error when try to add advance zone using VMWare 
ESXi 6.0 host
Summary: In vCenter 6.0, response headers need to be fetched after service 
login for server cookie unlike previous versions of vCenter.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

2015-09-11 Thread kishankavala
Github user kishankavala commented on the pull request:

https://github.com/apache/cloudstack/pull/784#issuecomment-139513737
  
After applying patch, was able to create VPC successfully.
LGTM.
Sub-process optimization is good to have. This PR will unblock the VPC 
creation.

2015-09-11 15:59:15,169 DEBUG [c.c.a.t.Request] 
(AgentManager-Handler-8:null) Seq 297-1810728525179650071: Processing:  { Ans: 
, MgmtId: 233845178473044, via: 297, Ver: v1, Flags: 110, 
[{"com.cloud.agent.api.StartAnswer":{"vm":{"id":34,"name":"r-34-VM","type":"DomainRouter","cpus":1,"minSpeed":500,"maxSpeed":500,"minRam":268435456,"maxRam":268435456,"arch":"x86_64","os":"Debian
 GNU/Linux 5.0 (64-bit)","platformEmulator":"Debian GNU/Linux 5","bootArgs":" 
vpccidr=10.5.1.0/24 domain=cs2cloud.internal dns1=4.2.2.2 template=domP 
name=r-34-VM eth0ip=169.254.1.43 eth0mask=255.255.0.0 type=vpcrouter 
disable_rp_filter=true 
baremetalnotificationsecuritykey=s67s-w0ooifUaTiCWhF24OUfj8JSRhTKTs6N-2rlWY2tkkPo-F0nZOv1lKTIyXXs0ir4vv0hatiUHFaddZxiDw
 
baremetalnotificationapikey=c9SUcsu8zctnSQmy43yhQB0HJM2HTDsRjEXd85s9IJOobOBRLaGZBa22vDH4IozJpIW8PHXVAFWu_W9qtdvYIA
 host=10.147.28.47 
port=8080","enableHA":true,"limitCpuUse":false,"enableDynamicallyScaleVm":false,"vncPassword":"UOXbgiNACZU3NN8Rv6uvNg",
 
"vncAddr":"10.147.28.43","params":{},"uuid":"4da3b373-17bc-4b4a-8b34-f32459faf341","disks":[{"data":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"uuid":"5e291e11-8043-4b67-9b41-aa55e71e8236","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"954526cd-d0f1-4a9e-b80a-902baad3faa2","id":3,"poolType":"Filesystem","host":"10.147.28.43","path":"/var/lib/libvirt/images","port":0,"url":"Filesystem://10.147.28.43/var/lib/libvirt/images/?ROLE=Primary=954526cd-d0f1-4a9e-b80a-902baad3faa2"}},"name":"ROOT-34","size":3145728000,"path":"5e291e11-8043-4b67-9b41-aa55e71e8236","volumeId":34,"vmName":"r-34-VM","accountId":2,"format":"QCOW2","provisioningType":"THIN","id":34,"deviceId":0,"hypervisorType":"KVM"}},"diskSeq":0,"path":"5e291e11-8043-4b67-9b41-aa55e71e8236","type":"ROOT","_details":{"managed":"false","storagePort":"0","storageHost":"10.147.28.43","volumeSize":"3145728000"}}],"nics":[{"deviceId":0,"networkRateMbps":-1,"defaultNic"
 
:false,"pxeDisable":true,"nicUuid":"588f728c-9de8-4b04-8fd4-7b03226c9ef2","uuid":"4c825977-669f-4777-9a44-a312952321c8","ip":"169.254.1.43","netmask":"255.255.0.0","gateway":"169.254.0.1","mac":"0e:00:a9:fe:01:2b","broadcastType":"LinkLocal","type":"Control","isSecurityGroupEnabled":false}]},"result":true,"wait":0}},{"com.cloud.agent.api.check.CheckSshAnswer":{"result":true,"wait":0}},{"com.cloud.agent.api.GetDomRVersionAnswer":{"templateVersion":"Cloudstack
 Release 4.6.0 Sun Jul 26 22:08:05 UTC 
2015","scriptsVersion":"d6222468f4f35d173be74954631b18d2\n","result":true,"details":"Cloudstack
 Release 4.6.0 Sun Jul 26 22:08:05 UTC 
2015\n","wait":0}},{"com.cloud.agent.api.PlugNicAnswer":{"result":true,"details":"success","wait":0}},{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null
 - success: null","null - success: [INFO] update_config.py :: Processing 
incoming file => ip_associations.json\n[INFO] Processing JSON file 
ip_associations.json\n"],"r
 
esult":true,"wait":0}},{"com.cloud.agent.api.Answer":{"result":true,"details":"Nothing
 to 
do","wait":0}},{"com.cloud.agent.api.NetworkUsageAnswer":{"routerName":"r-34-VM","bytesSent":0,"bytesReceived":0,"result":true,"wait":0}}]
 }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/805#issuecomment-139520736
  
@wilderrodrigues LGTM (minor issue - s/taks/task)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: unittests to verify empty password is not...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/807#issuecomment-139521022
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/800#discussion_r39263080
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDatabag.py ---
@@ -130,7 +136,10 @@ def get_router_password(self):
 This is slightly difficult to happen, but if it does, destroy the 
router with the password generated with the
 code below and restart the VPC with out the clean up option.
 '''
-passwd = "%s-%s" % (self.get_vpccidr, self.get_router_id())
+if(self.get_type()=='router'):
--- End diff --

- run pep8, fix errors
- consider using -- if self.get_type() == "router"   or   if 
self.get_type() is "router"
- stick to uniform usage to quotes, double quotes for strings here so 
"router" instead of 'router'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/795#issuecomment-139524204
  
@borisroman looks good, can you increase code coverage by adding tests for 
the utils and core changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Removal of test/debug code.

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/794#issuecomment-139524401
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.5.2 Fails to Start.

2015-09-11 Thread Keerthiraja SJ
I really face this issue when I install on MariaDB. If I do the same on
MySQL this pass it.

On Fri, Sep 11, 2015 at 7:09 PM, Keerthiraja SJ  wrote:

> Hi All,
>
> Today I tried to install the CS 4.5.2 on fresh box where I could able to
> successfully deploy
> the cloudstack-setup-databases.
>
> After I tried number of times the fresh installation I could see the same
> issue been reproducing it.
>
> While stating the cloudstack servers I could see below error constantly.
>
>
>
>
> *ERROR*ERROR [c.c.u.d.ScriptRunner] (main:null) Error executing: UPDATE
> `cloud`.`configuration` SET value = CONCAT("*.",(SELECT `temptable`.`value`
> FROM (SELECT * FROM `cloud`.`configuration` WHERE
> `name`="consoleproxy.url.domain") AS `temptable` WHERE
> `temptable`.`name`="consoleproxy.url.domain")) WHERE
> `name`="consoleproxy.url.domain"
> ERROR [c.c.u.d.ScriptRunner] (main:null)
> com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications
> link failure
>
> The last packet successfully received from the server was 25 milliseconds
> ago.  The last packet sent successfully to the server was 25 milliseconds
> ago.
> ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to execute upgrade
> script: /usr/share/cloudstack-management/setup/db/schema-421to430.sql
> com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications
> link failure
>
>
> Caused by: java.net.SocketException: Broken pipe
> ... 61 more
> ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to upgrade the
> database
> com.cloud.utils.exception.CloudRuntimeException: Unable to execute upgrade
> script: /usr/share/cloudstack-management/setup/db/schema-421to430.sql
> at
> com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:311)
>
> ERROR [c.c.u.d.DbUtil] (main:null) RELEASE_LOCK() throws exception
> com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications
> link failure
>
>
> I did this test number of times by allocating fresh box.
>
> Thanks,
> Keerthi
>


CS 4.5.2 Fails to Start.

2015-09-11 Thread Keerthiraja SJ
Hi All,

Today I tried to install the CS 4.5.2 on fresh box where I could able to
successfully deploy
the cloudstack-setup-databases.

After I tried number of times the fresh installation I could see the same
issue been reproducing it.

While stating the cloudstack servers I could see below error constantly.




*ERROR*ERROR [c.c.u.d.ScriptRunner] (main:null) Error executing: UPDATE
`cloud`.`configuration` SET value = CONCAT("*.",(SELECT `temptable`.`value`
FROM (SELECT * FROM `cloud`.`configuration` WHERE
`name`="consoleproxy.url.domain") AS `temptable` WHERE
`temptable`.`name`="consoleproxy.url.domain")) WHERE
`name`="consoleproxy.url.domain"
ERROR [c.c.u.d.ScriptRunner] (main:null)
com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications
link failure

The last packet successfully received from the server was 25 milliseconds
ago.  The last packet sent successfully to the server was 25 milliseconds
ago.
ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to execute upgrade
script: /usr/share/cloudstack-management/setup/db/schema-421to430.sql
com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications
link failure


Caused by: java.net.SocketException: Broken pipe
... 61 more
ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to upgrade the
database
com.cloud.utils.exception.CloudRuntimeException: Unable to execute upgrade
script: /usr/share/cloudstack-management/setup/db/schema-421to430.sql
at
com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:311)

ERROR [c.c.u.d.DbUtil] (main:null) RELEASE_LOCK() throws exception
com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications
link failure


I did this test number of times by allocating fresh box.

Thanks,
Keerthi


[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/800#issuecomment-139551429
  
cool


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2286

2015-09-11 Thread jenkins
See 

--
[...truncated 28183 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.709s]
[INFO] Apache CloudStack . SUCCESS [2.194s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.765s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.898s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:31.195s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.108s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.687s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.272s]
[INFO] Apache CloudStack API . SUCCESS [1:58.563s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.541s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.794s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.101s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.969s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.437s]
[INFO] Apache CloudStack Core  SUCCESS [1:17.526s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.328s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [35.879s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.099s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:10.307s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [48.477s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [31.144s]
[INFO] Apache CloudStack Server .. SUCCESS [4:30.202s]
[INFO] Apache CloudStack Usage Server  SUCCESS [48.794s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:24.548s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.072s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.431s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [58.644s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [55.963s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [31.646s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [28.341s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.621s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [24.697s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [38.413s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.397s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [6.034s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.744s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [1:59.514s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[3:23.744s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[59.547s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [20.649s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [38.990s]
[INFO] Apache CloudStack Plugin - 

[GitHub] cloudstack pull request: CLOUDSTACK-5863: Add unit tests for volum...

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/796


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/806#issuecomment-139521285
  
Great PR @sureshanaparti I was going to work on supporting this as ESXi6 
works well on top of KVM; I can test this for you next week; LGTM on code 
change (not tested though)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/775#issuecomment-139524565
  
@nitin-maharana you changed a single line in a 102 line method. Though the 
code LGTM, I do not feel confident. Can you write unit tests or specify how 
this can be reproduced and/or proven?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/793#issuecomment-139524505
  
@anshul1886 LGTM, can you add some unit test for the new methods?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/728#issuecomment-139530956
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

2015-09-11 Thread Wido den Hollander


On 11-09-15 10:19, Wido den Hollander wrote:
> 
> 
> On 10-09-15 23:15, Andrija Panic wrote:
>> Wido,
>>
>> could you folow maybe what my colegue Dmytro just sent ?
>>
> 
> Yes, seems logical.
> 
>> Its not only matter of question fixing rados-java (16 snaps limit)  - it
>> seems that for any RBD exception, ACS will freak out...
>>
> 
> No, a RbdException will be caught, but the Rados Bindings shouldn't
> throw NegativeArraySizeException in any case.
> 
> That's the main problem.
> 

Seems to be fixed with this commit:
https://github.com/ceph/rados-java/commit/5584f3961c95d998d2a9eff947a5b7b4d4ba0b64

Just tested it with 256 snapshots:

---
 T E S T S
---
Running com.ceph.rbd.TestRbd
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 521.014 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

The bindings should now be capable of listing more then 16 snapshots.

You can build the bindings manually and replace rados.jar on your
running systems.

For 4.6 I'll try to get the updated rados-java included.

Wido

> Wido
> 
>> THx
>>
>> On 10 September 2015 at 17:06, Dmytro Shevchenko <
>> dmytro.shevche...@safeswisscloud.com> wrote:
>>
>>> Hello everyone, some clarification about this. Configuration:
>>> CS: 4.5.1
>>> Primary storage: Ceph
>>>
>>> Actually we have 2 separate bugs:
>>>
>>> 1. When you remove some volume with more then 16 snapshots (doesn't matter
>>> destroyed or active - they always present on Ceph), on next storage garbage
>>> collector cycle it invoke 'deletePhysicalDisk' from
>>> LibvirtStorageAdaptor.java. On line 854 we calling list snapshots from
>>> external rados-java library and getting exception.
>>>
>>> https://github.com/apache/cloudstack/blob/4.5.1/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java#L854
>>> This exception do not catching in current function, but Agent DO NOT CRASH
>>> at this moment and continue working fine. Agent form proper answer to
>>> server and send it, text in answer - java stack trace. Log from Agent side:
>>>
>>> 2015-09-10 02:32:35,312 DEBUG [kvm.storage.LibvirtStorageAdaptor]
>>> (agentRequest-Handler-4:null) Trying to fetch storage pool
>>> 33ebaf83-5d09-3038-b63b-742e759a
>>> 992e from libvirt
>>> 2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
>>> (agentRequest-Handler-4:null) Attempting to remove volume
>>> 4c6a2092-056c-4446-a2ca-d6bba9f7f
>>> 7f8 from pool 33ebaf83-5d09-3038-b63b-742e759a992e
>>> 2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
>>> (agentRequest-Handler-4:null) Unprotecting and Removing RBD snapshots of
>>> image cloudstack-storage
>>> /4c6a2092-056c-4446-a2ca-d6bba9f7f7f8 prior to removing the image
>>> 2015-09-10 02:32:35,436 DEBUG [kvm.storage.LibvirtStorageAdaptor]
>>> (agentRequest-Handler-4:null) Succesfully connected to Ceph cluster at
>>> 10.10.1.26:6789
>>> 2015-09-10 02:32:35,454 DEBUG [kvm.storage.LibvirtStorageAdaptor]
>>> (agentRequest-Handler-4:null) Fetching list of snapshots of RBD image
>>> cloudstack-storage/4c6a2092
>>> -056c-4446-a2ca-d6bba9f7f7f8
>>> 2015-09-10 02:32:35,457 WARN  [cloud.agent.Agent]
>>> (agentRequest-Handler-4:null) Caught:
>>> java.lang.NegativeArraySizeException
>>> at com.ceph.rbd.RbdImage.snapList(Unknown Source)
>>> at
>>> com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor.deletePhysicalDisk(LibvirtStorageAdaptor.java:854)
>>> at
>>> com.cloud.hypervisor.kvm.storage.LibvirtStoragePool.deletePhysicalDisk(LibvirtStoragePool.java:175)
>>> at
>>> com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.deleteVolume(KVMStorageProcessor.java:1206)
>>> 2015-09-10 02:32:35,458 DEBUG [cloud.agent.Agent]
>>> (agentRequest-Handler-4:null) Seq 1-1743737480722513946:  { Ans: , MgmtId:
>>> 90520739779588, via: 1, Ver: v1,
>>>  Flags: 10,
>>> [{"com.cloud.agent.api.Answer":{"result":false,"details":"java.lang.NegativeArraySizeException\n\tat
>>> com.ceph.rbd.RbdImage.snapList(Unknown Sourc
>>> e)\n\tat
>>> com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor.deletePhysicalDisk(LibvirtStorageAdaptor.java:854)\n\tat
>>> com.cloud.hypervisor.kvm.storage.Lib
>>> virtStoragePool.deletePhysicalDisk(LibvirtStoragePool.java:175)\n\tat
>>> com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.deleteVolume(KVMStorageProcessor.j
>>> ava:1206)\n\tat
>>> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:124)\n\tat
>>> com.cloud.storage.re.
>>>
>>> so this volume and it snapshots never will be removed.
>>>
>>>
>>> 2. Second bug. Experimentally it has been found that after 50 minutes we
>>> had exception on Agent, for some unknown reason Management server decided
>>> about it lost connection to this agent, start HA process and start Agent
>>> process again.
>>> Log on Agent side:
>>> 2015-09-10 02:57:12,664 DEBUG 

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-11 Thread nlivens
Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-139530205
  
@bhaisaab, I'll increase the unit test code coverage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/806#discussion_r39265018
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -152,13 +152,26 @@ public void connect(String url, String userName, 
String password) throws Excepti
 @SuppressWarnings("unchecked")
 Map headers = (Map)((BindingProvider)vimPort).getResponseContext().get(MessageContext.HTTP_RESPONSE_HEADERS);
 List cookies = headers.get("Set-cookie");
+
+vimPort.login(serviceContent.getSessionManager(), userName, 
password, null);
+
+if (cookies == null) {
+@SuppressWarnings("unchecked")
--- End diff --

why suppress? please add a comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

2015-09-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/800#issuecomment-139532157
  
@bhaisaab , should we wait for a new commit from @bvbharatk on this PR 
before merging it?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: unittests to verify empty password is not...

2015-09-11 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/807

unittests to verify empty password is not allowed during account/user create



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack createuser-unittests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #807


commit 9b80fb8656a9fe902720c27b363dc3e059b8cfec
Author: Rajani Karuturi 
Date:   2014-04-01T06:02:33Z

unittests to verify empty password is not allowed during login




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

2015-09-11 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/805#issuecomment-139520511
  
Nice work @wilderrodrigues. Pinging @snuf to have a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/803#issuecomment-139521700
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-139521497
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/808#issuecomment-139521444
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/792#issuecomment-139524545
  
code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change while configur...

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/791


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/805#issuecomment-139530031
  
pending pull-analysis results; LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: unittests to verify empty password is not...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/807#issuecomment-139530930
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/806#discussion_r39265110
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -577,41 +590,48 @@ public ManagedObjectReference 
getDecendentMoRef(ManagedObjectReference root, Str
 return null;
 }
 
-// Create PropertySpecs
-PropertySpec pSpec = new PropertySpec();
-pSpec.setType(type);
-pSpec.setAll(false);
-pSpec.getPathSet().add("name");
-
-ObjectSpec oSpec = new ObjectSpec();
-oSpec.setObj(root);
-oSpec.setSkip(false);
-oSpec.getSelectSet().addAll(constructCompleteTraversalSpec());
-
-PropertyFilterSpec spec = new PropertyFilterSpec();
-spec.getPropSet().add(pSpec);
-spec.getObjectSet().add(oSpec);
-List specArr = new 
ArrayList();
-specArr.add(spec);
-
-List ocary = 
vimPort.retrieveProperties(getPropCol(), specArr);
-
-if (ocary == null || ocary.size() == 0) {
-return null;
-}
+try {
+// Create PropertySpecs
+PropertySpec pSpec = new PropertySpec();
+pSpec.setType(type);
+pSpec.setAll(false);
+pSpec.getPathSet().add("name");
+
+ObjectSpec oSpec = new ObjectSpec();
+oSpec.setObj(root);
+oSpec.setSkip(false);
+oSpec.getSelectSet().addAll(constructCompleteTraversalSpec());
+
+PropertyFilterSpec spec = new PropertyFilterSpec();
+spec.getPropSet().add(pSpec);
+spec.getObjectSet().add(oSpec);
+List specArr = new 
ArrayList();
+specArr.add(spec);
+
+ManagedObjectReference propCollector = getPropCol();
+List ocary = 
vimPort.retrieveProperties(propCollector, specArr);
+
+if (ocary == null || ocary.size() == 0) {
+return null;
+}
 
-// filter through retrieved objects to get the first match.
-for (ObjectContent oc : ocary) {
-ManagedObjectReference mor = oc.getObj();
-List propary = oc.getPropSet();
-if (type == null || type.equals(mor.getType())) {
-if (propary.size() > 0) {
-String propval = (String)propary.get(0).getVal();
-if (propval != null && name.equalsIgnoreCase(propval))
-return mor;
+// filter through retrieved objects to get the first match.
+for (ObjectContent oc : ocary) {
+ManagedObjectReference mor = oc.getObj();
+List propary = oc.getPropSet();
+if (type == null || type.equals(mor.getType())) {
+if (propary.size() > 0) {
+String propval = (String)propary.get(0).getVal();
+if (propval != null && 
name.equalsIgnoreCase(propval))
+return mor;
+}
 }
 }
+} catch (Exception e) {
--- End diff --

please catch specific exceptions, not just anything


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/806#discussion_r39265179
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -577,41 +590,48 @@ public ManagedObjectReference 
getDecendentMoRef(ManagedObjectReference root, Str
 return null;
 }
 
-// Create PropertySpecs
-PropertySpec pSpec = new PropertySpec();
-pSpec.setType(type);
-pSpec.setAll(false);
-pSpec.getPathSet().add("name");
-
-ObjectSpec oSpec = new ObjectSpec();
-oSpec.setObj(root);
-oSpec.setSkip(false);
-oSpec.getSelectSet().addAll(constructCompleteTraversalSpec());
-
-PropertyFilterSpec spec = new PropertyFilterSpec();
-spec.getPropSet().add(pSpec);
-spec.getObjectSet().add(oSpec);
-List specArr = new 
ArrayList();
-specArr.add(spec);
-
-List ocary = 
vimPort.retrieveProperties(getPropCol(), specArr);
-
-if (ocary == null || ocary.size() == 0) {
-return null;
-}
+try {
+// Create PropertySpecs
+PropertySpec pSpec = new PropertySpec();
+pSpec.setType(type);
+pSpec.setAll(false);
+pSpec.getPathSet().add("name");
+
+ObjectSpec oSpec = new ObjectSpec();
+oSpec.setObj(root);
+oSpec.setSkip(false);
+oSpec.getSelectSet().addAll(constructCompleteTraversalSpec());
+
+PropertyFilterSpec spec = new PropertyFilterSpec();
+spec.getPropSet().add(pSpec);
+spec.getObjectSet().add(oSpec);
+List specArr = new 
ArrayList();
+specArr.add(spec);
+
+ManagedObjectReference propCollector = getPropCol();
+List ocary = 
vimPort.retrieveProperties(propCollector, specArr);
+
+if (ocary == null || ocary.size() == 0) {
+return null;
+}
 
-// filter through retrieved objects to get the first match.
-for (ObjectContent oc : ocary) {
-ManagedObjectReference mor = oc.getObj();
-List propary = oc.getPropSet();
-if (type == null || type.equals(mor.getType())) {
-if (propary.size() > 0) {
-String propval = (String)propary.get(0).getVal();
-if (propval != null && name.equalsIgnoreCase(propval))
-return mor;
+// filter through retrieved objects to get the first match.
+for (ObjectContent oc : ocary) {
+ManagedObjectReference mor = oc.getObj();
+List propary = oc.getPropSet();
+if (type == null || type.equals(mor.getType())) {
+if (propary.size() > 0) {
+String propval = (String)propary.get(0).getVal();
+if (propval != null && 
name.equalsIgnoreCase(propval))
+return mor;
+}
 }
 }
+} catch (Exception e) {
+s_logger.debug("Failed to get mor for name: " + name + " and 
type: " + type, e);
--- End diff --

(mor == more || mor is MoRef)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

2015-09-11 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/808

CLOUDSTACK-8835: Added alerts incase of template download failure

Authored-By: @sanjaytripathi 
Reviewed-By: Devdeep

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-8835

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #808


commit 9a35f87d370fb781763d1d243d2f225e3fb60c4a
Author: Sanjay Tripathi 
Date:   2015-02-26T10:04:29Z

CLOUDSTACK-8835: Added alerts incase of template download failure

Reviewed-By: Devdeep




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/805#discussion_r39262559
  
--- Diff: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1315,6 +1321,10 @@ protected void doTask(final Task task) throws 
Exception {
 } catch (final UnsupportedVersionException e) {
 s_logger.warn(e.getMessage());
 // upgradeAgent(task.getLink(), data, 
e.getReason());
+} catch (final ClassNotFoundException e) {
+final String message = String.format("Exception 
occured when executing taks! Error '%s'", e.getMessage());
--- End diff --

s/taks/task/ (minor issue)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/795#issuecomment-139523955
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixed secstorage.proxy is not setting pro...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/802#issuecomment-139521867
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-139522260
  
Can you increase its unit test code coverage?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/800#issuecomment-139523586
  
Minor issues, otherwise code changes look alright


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/806#issuecomment-139532380
  
change makes sense but I have some comments on the coding style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-11 Thread ashwinswaroop
Github user ashwinswaroop commented on the pull request:

https://github.com/apache/cloudstack/pull/810#issuecomment-139697149
  
Sorry for not changing the setter. I'm using eclipse now and I can see that 
there is a FirewallResponse.java file in both cloud and cloudstack-api. Should 
I make the changes in both places or only in cloudstack-api like last time? 
Also I have noticed various callers to setStartPort and getStartPort in the 
project. Will they need to be changed also, or should I leave everything else 
as it is?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2285

2015-09-11 Thread jenkins
See 

--
[...truncated 28183 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.772s]
[INFO] Apache CloudStack . SUCCESS [2.203s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.808s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [20.095s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.914s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.109s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.961s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.791s]
[INFO] Apache CloudStack API . SUCCESS [1:49.949s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.269s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.426s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.093s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.629s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.509s]
[INFO] Apache CloudStack Core  SUCCESS [1:17.114s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.898s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [35.553s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [15.421s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:13.702s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [46.186s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [30.129s]
[INFO] Apache CloudStack Server .. SUCCESS [4:25.261s]
[INFO] Apache CloudStack Usage Server  SUCCESS [52.866s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:32.268s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.102s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.416s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [1:02.002s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [54.767s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [33.249s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.827s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.861s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [22.976s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.885s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [13.284s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.888s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.743s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [1:28.276s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[3:18.971s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[1:36.562s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [21.005s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [46.089s]
[INFO] Apache CloudStack Plugin 

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-11 Thread ashwinswaroop
Github user ashwinswaroop commented on the pull request:

https://github.com/apache/cloudstack/pull/810#issuecomment-139703362
  
Okay that makes sense. I went through the entire project and found only one 
caller of setStartPort and setEndPort which was from the relevant 
class(Firewall Response). There were others, but they were referring to a 
different class. The relevant caller took an argument of the form x.toString 
previously, but now since I changed the setter definition and the variable 
types to Integer, I removed the .toString part since it was already an Integer 
being converted to a String. There was no getter definition at all in 
FirewallResponse.java. Should I go ahead and commit? Also, in what way should I 
adjust the comments on my commit like you mentioned? 
Thanks for the help!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-11 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/810#issuecomment-139698329
  
@ashwinswaroop, no problem. 
About the class duplicity, it just seems that there are two classes, but in 
reality there is only one. The question is that the project cloudstack-api is 
located inside the Cloudstack (it is a module). You should open the class that 
appear to be in cloudstack-api, this way the Eclipse IDE will properly compile 
and show the errors that the class might have.

Sure you will have to change every single point that uses those getters and 
setters, if you want to proceed with that proposal.

I just asked about the IDE, because when I saw that you just changed the 
parameters type, but not the setters and getters, it seemed like someone using 
VI to edit source files.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

2015-09-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/805#issuecomment-139532454
  
Thanks, guys!

@bhaisaab: I will change that and push in the second part of the refactor.

Thanks again for a quick review! I will paste the tests results (still 
running because I'm testing a lot) before merging.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/728


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixed secstorage.proxy is not setting pro...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/802#issuecomment-139536217
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Removal of test/debug code.

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/794


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

2015-09-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/800#issuecomment-139539283
  
I will merge this, since it got 2 LGTM, and will change the if as suggested 
by Rohit in my next PR that will touch the python files. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

2015-09-11 Thread sanju1010
GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/809

Changes made to DeployDataCenter to support Baremetal Basic Zone Creation

1. Made changes to deployDataCenter.py to support zone creation with 
Baremetal as the Hyeprvisor
2. Added test file to BVT with basic vm deployment test 
3. Added template entry in test_data.py file
4. Added sample configuration file BareMetal.cfg to create Basic Zone with 
Baremetal as the Hypervisor

I have also tested this and works fine. However, I don't have test results 
to post here.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack BMetal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #809


commit 71141ab87da4bbf3406e766fb412b524310db70e
Author: sanjeev 
Date:   2015-09-11T13:00:34Z

Changes made to DeployDataCenter to support Baremetal Basic Zone Creation. 
Also added a sample test file to deploy vm




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-139533946
  
the ticket (CLOUDSTACK-8834) mentions a screenshot, which is not there. the 
explanation give reproduction hints but is not completely clear because of 
this. The change seems trivial but is [part of a big method that warrants 
refactoring and (unit/integration)testing.
Be assured that I won't :-1: on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

2015-09-11 Thread Dmytro Shevchenko
Thanks a lot Wido! Any chance to find out why management server decided 
that it lost connection to agent after that exceptions? It's not so 
critical as this bug with 16 snapshots, but during last week we catch 
situation when Agent failed unprotect snapshot, rise exception and this 
is was a reason of disconnection a bit later after that. (It is not 
clear why CS decided remove that volume, it was template with one 'gold' 
snapshot with several active clones)


On 09/11/2015 03:20 PM, Wido den Hollander wrote:


On 11-09-15 10:19, Wido den Hollander wrote:


On 10-09-15 23:15, Andrija Panic wrote:

Wido,

could you folow maybe what my colegue Dmytro just sent ?


Yes, seems logical.


Its not only matter of question fixing rados-java (16 snaps limit)  - it
seems that for any RBD exception, ACS will freak out...


No, a RbdException will be caught, but the Rados Bindings shouldn't
throw NegativeArraySizeException in any case.

That's the main problem.


Seems to be fixed with this commit:
https://github.com/ceph/rados-java/commit/5584f3961c95d998d2a9eff947a5b7b4d4ba0b64

Just tested it with 256 snapshots:

---
  T E S T S
---
Running com.ceph.rbd.TestRbd
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 521.014 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

The bindings should now be capable of listing more then 16 snapshots.

You can build the bindings manually and replace rados.jar on your
running systems.

For 4.6 I'll try to get the updated rados-java included.

Wido


Wido


THx

On 10 September 2015 at 17:06, Dmytro Shevchenko <
dmytro.shevche...@safeswisscloud.com> wrote:


Hello everyone, some clarification about this. Configuration:
CS: 4.5.1
Primary storage: Ceph

Actually we have 2 separate bugs:

1. When you remove some volume with more then 16 snapshots (doesn't matter
destroyed or active - they always present on Ceph), on next storage garbage
collector cycle it invoke 'deletePhysicalDisk' from
LibvirtStorageAdaptor.java. On line 854 we calling list snapshots from
external rados-java library and getting exception.

https://github.com/apache/cloudstack/blob/4.5.1/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java#L854
This exception do not catching in current function, but Agent DO NOT CRASH
at this moment and continue working fine. Agent form proper answer to
server and send it, text in answer - java stack trace. Log from Agent side:

2015-09-10 02:32:35,312 DEBUG [kvm.storage.LibvirtStorageAdaptor]
(agentRequest-Handler-4:null) Trying to fetch storage pool
33ebaf83-5d09-3038-b63b-742e759a
992e from libvirt
2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
(agentRequest-Handler-4:null) Attempting to remove volume
4c6a2092-056c-4446-a2ca-d6bba9f7f
7f8 from pool 33ebaf83-5d09-3038-b63b-742e759a992e
2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
(agentRequest-Handler-4:null) Unprotecting and Removing RBD snapshots of
image cloudstack-storage
/4c6a2092-056c-4446-a2ca-d6bba9f7f7f8 prior to removing the image
2015-09-10 02:32:35,436 DEBUG [kvm.storage.LibvirtStorageAdaptor]
(agentRequest-Handler-4:null) Succesfully connected to Ceph cluster at
10.10.1.26:6789
2015-09-10 02:32:35,454 DEBUG [kvm.storage.LibvirtStorageAdaptor]
(agentRequest-Handler-4:null) Fetching list of snapshots of RBD image
cloudstack-storage/4c6a2092
-056c-4446-a2ca-d6bba9f7f7f8
2015-09-10 02:32:35,457 WARN  [cloud.agent.Agent]
(agentRequest-Handler-4:null) Caught:
java.lang.NegativeArraySizeException
 at com.ceph.rbd.RbdImage.snapList(Unknown Source)
 at
com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor.deletePhysicalDisk(LibvirtStorageAdaptor.java:854)
 at
com.cloud.hypervisor.kvm.storage.LibvirtStoragePool.deletePhysicalDisk(LibvirtStoragePool.java:175)
 at
com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.deleteVolume(KVMStorageProcessor.java:1206)
2015-09-10 02:32:35,458 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-4:null) Seq 1-1743737480722513946:  { Ans: , MgmtId:
90520739779588, via: 1, Ver: v1,
  Flags: 10,
[{"com.cloud.agent.api.Answer":{"result":false,"details":"java.lang.NegativeArraySizeException\n\tat
com.ceph.rbd.RbdImage.snapList(Unknown Sourc
e)\n\tat
com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor.deletePhysicalDisk(LibvirtStorageAdaptor.java:854)\n\tat
com.cloud.hypervisor.kvm.storage.Lib
virtStoragePool.deletePhysicalDisk(LibvirtStoragePool.java:175)\n\tat
com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.deleteVolume(KVMStorageProcessor.j
ava:1206)\n\tat
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:124)\n\tat
com.cloud.storage.re.

so this volume and it snapshots never will be removed.


2. Second bug. Experimentally it has been found that after 50 minutes we
had exception on 

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

2015-09-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/805#issuecomment-139537936
  
@remibergsma @bhaisaab @DaanHoogland 

Tests Results:

Environment

KVM + CentOS 7.1
Management Server + CentOS 7.1
Latest SytemVM
Agent + Common built from source


Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok

--
Ran 7 tests in 666.061s

OK
/tmp//MarvinLogs/test_routers_MT0LID/results.txt (END)



Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: 
test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status 
: SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : 
SUCCESS ===
ok
test_09_create_redundant_vpc_offering 
(integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: 
test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok

--
Ran 8 tests in 1648.764s

OK
/tmp//MarvinLogs/test_vpc_offerings_JEYBTX/results.txt (END)



Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok

--
Ran 10 tests in 1838.049s

OK (SKIP=1)
/tmp//MarvinLogs/test_vm_life_cycle_3JACRM/results.txt (END)



Test VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : 
SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok

--
Ran 2 tests in 912.914s

OK
/tmp//MarvinLogs/test_vpc_vpn_ZJA1WV/results.txt (END)


VPN remote access user limit tests ... === TestName: test_01_VPN_user_limit 
| Status : SUCCESS ===
ok
Test create VPN when L2TP port in use ... === TestName: 
test_02_use_vpn_port | Status : SUCCESS ===
ok
Test create NAT rule when VPN when L2TP enabled ... === TestName: 
test_03_enable_vpn_use_port | Status : SUCCESS ===
ok
Test add new users to existing VPN ... === TestName: test_04_add_new_users 
| Status : SUCCESS ===
ok
Test add duplicate user to existing VPN ... === TestName: 
test_05_add_duplicate_user | Status : SUCCESS ===
ok
Test as global admin, add a new VPN user to an existing VPN entry ... === 
TestName: test_06_add_VPN_user_global_admin | Status : SUCCESS ===
ok
Test as domain admin, add a new VPN user to an existing VPN entry ... === 
TestName: test_07_add_VPN_user_domain_admin | Status : SUCCESS ===
ok


[GitHub] cloudstack pull request: unittests to verify empty password is not...

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/807


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...

2015-09-11 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/799#issuecomment-139538952
  
LGTM. With @bhaisaab though. Please fix Centos 7 as well.

Btw, we should really use systemd :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/809#issuecomment-139542841
  
@sanju1010 I had a look and didn't see you add your test to the travis 
yaml, is it included in the travis run? (if yes no need for any test report)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/800


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

2015-09-11 Thread Wido den Hollander


On 11-09-15 14:43, Dmytro Shevchenko wrote:
> Thanks a lot Wido! Any chance to find out why management server decided
> that it lost connection to agent after that exceptions? It's not so
> critical as this bug with 16 snapshots, but during last week we catch
> situation when Agent failed unprotect snapshot, rise exception and this
> is was a reason of disconnection a bit later after that. (It is not
> clear why CS decided remove that volume, it was template with one 'gold'
> snapshot with several active clones)
> 

No, I didn't look at CS at all. I just spend the day improving the RADOS
bindings.

Wido

> On 09/11/2015 03:20 PM, Wido den Hollander wrote:
>>
>> On 11-09-15 10:19, Wido den Hollander wrote:
>>>
>>> On 10-09-15 23:15, Andrija Panic wrote:
 Wido,

 could you folow maybe what my colegue Dmytro just sent ?

>>> Yes, seems logical.
>>>
 Its not only matter of question fixing rados-java (16 snaps limit) 
 - it
 seems that for any RBD exception, ACS will freak out...

>>> No, a RbdException will be caught, but the Rados Bindings shouldn't
>>> throw NegativeArraySizeException in any case.
>>>
>>> That's the main problem.
>>>
>> Seems to be fixed with this commit:
>> https://github.com/ceph/rados-java/commit/5584f3961c95d998d2a9eff947a5b7b4d4ba0b64
>>
>>
>> Just tested it with 256 snapshots:
>>
>> ---
>>   T E S T S
>> ---
>> Running com.ceph.rbd.TestRbd
>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>> 521.014 sec
>>
>> Results :
>>
>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>>
>> The bindings should now be capable of listing more then 16 snapshots.
>>
>> You can build the bindings manually and replace rados.jar on your
>> running systems.
>>
>> For 4.6 I'll try to get the updated rados-java included.
>>
>> Wido
>>
>>> Wido
>>>
 THx

 On 10 September 2015 at 17:06, Dmytro Shevchenko <
 dmytro.shevche...@safeswisscloud.com> wrote:

> Hello everyone, some clarification about this. Configuration:
> CS: 4.5.1
> Primary storage: Ceph
>
> Actually we have 2 separate bugs:
>
> 1. When you remove some volume with more then 16 snapshots (doesn't
> matter
> destroyed or active - they always present on Ceph), on next storage
> garbage
> collector cycle it invoke 'deletePhysicalDisk' from
> LibvirtStorageAdaptor.java. On line 854 we calling list snapshots from
> external rados-java library and getting exception.
>
> https://github.com/apache/cloudstack/blob/4.5.1/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java#L854
>
> This exception do not catching in current function, but Agent DO
> NOT CRASH
> at this moment and continue working fine. Agent form proper answer to
> server and send it, text in answer - java stack trace. Log from
> Agent side:
>
> 2015-09-10 02:32:35,312 DEBUG [kvm.storage.LibvirtStorageAdaptor]
> (agentRequest-Handler-4:null) Trying to fetch storage pool
> 33ebaf83-5d09-3038-b63b-742e759a
> 992e from libvirt
> 2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
> (agentRequest-Handler-4:null) Attempting to remove volume
> 4c6a2092-056c-4446-a2ca-d6bba9f7f
> 7f8 from pool 33ebaf83-5d09-3038-b63b-742e759a992e
> 2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
> (agentRequest-Handler-4:null) Unprotecting and Removing RBD
> snapshots of
> image cloudstack-storage
> /4c6a2092-056c-4446-a2ca-d6bba9f7f7f8 prior to removing the image
> 2015-09-10 02:32:35,436 DEBUG [kvm.storage.LibvirtStorageAdaptor]
> (agentRequest-Handler-4:null) Succesfully connected to Ceph cluster at
> 10.10.1.26:6789
> 2015-09-10 02:32:35,454 DEBUG [kvm.storage.LibvirtStorageAdaptor]
> (agentRequest-Handler-4:null) Fetching list of snapshots of RBD image
> cloudstack-storage/4c6a2092
> -056c-4446-a2ca-d6bba9f7f7f8
> 2015-09-10 02:32:35,457 WARN  [cloud.agent.Agent]
> (agentRequest-Handler-4:null) Caught:
> java.lang.NegativeArraySizeException
>  at com.ceph.rbd.RbdImage.snapList(Unknown Source)
>  at
> com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor.deletePhysicalDisk(LibvirtStorageAdaptor.java:854)
>
>  at
> com.cloud.hypervisor.kvm.storage.LibvirtStoragePool.deletePhysicalDisk(LibvirtStoragePool.java:175)
>
>  at
> com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.deleteVolume(KVMStorageProcessor.java:1206)
>
> 2015-09-10 02:32:35,458 DEBUG [cloud.agent.Agent]
> (agentRequest-Handler-4:null) Seq 1-1743737480722513946:  { Ans: ,
> MgmtId:
> 90520739779588, via: 1, Ver: v1,
>   Flags: 10,
> [{"com.cloud.agent.api.Answer":{"result":false,"details":"java.lang.NegativeArraySizeException\n\tat

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/808#issuecomment-139532776
  
Makes sense and LGTM. I see some code duplication in 
ImageStoreUploadMonitorImpl, though. A good moment to get rid of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/803#discussion_r39266451
  
--- Diff: 
engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java
 ---
@@ -350,4 +351,20 @@ public void expireDnldUrlsForZone(Long dcId){
 return listIncludingRemovedBy(sc);
 }
 
+@Override
+public boolean updateVolumeId(long srcVolId, long destVolId) {
+TransactionLegacy txn = TransactionLegacy.currentTxn();
+try {
+VolumeDataStoreVO volumeDataStoreVO = findByVolume(srcVolId);
+if(volumeDataStoreVO != null) {
+txn.start();
+volumeDataStoreVO.setVolumeId(destVolId);
+update(volumeDataStoreVO.getId(), volumeDataStoreVO);
+txn.commit();
+}
+} catch (Exception e) {
--- End diff --

please catch more specific/explicit exceptions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Removal of test/debug code.

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/794#issuecomment-139537389
  
Looks like what I meant @borisroman , LgreatTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

2015-09-11 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/808#issuecomment-139538657
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/805


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


No more direct commits to master please!

2015-09-11 Thread Remi Bergsma
Hi all,

What happened to master? I see a lot of direct commits. I thought we agreed to 
make a PR, then _merge_ it to master with the script in ./tools/git/git-pr.

We’re getting ready for a 4.6 RC and this makes stuff extra hard to track. Most 
direct commits seem to come from PRs, but I don’t think all of them did.

Talking about this (there are more):
https://github.com/apache/cloudstack/commit/b66dcda49f370e6fc91ebff889a694f17826ca44
https://github.com/apache/cloudstack/commit/1c6378ec0056e8c75990a4a0c15e99b2df162a75
https://github.com/apache/cloudstack/commit/1a02773b556a0efa277cf18cd099fc62a4e27706
https://github.com/apache/cloudstack/commit/ba59a4b6f31e48e4b6e43e16068e4cacdc45
https://github.com/apache/cloudstack/commit/f661ac0a2a783447b6eaab590d58091ec542aec2

Please don’t make me revert the direct commits.

If you need help with getting PRs merged, ping me or Rajani as we’re happy to 
help.

Thanks,
Remi



[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

2015-09-11 Thread bvbharatk
Github user bvbharatk commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/784#discussion_r39275218
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,25 @@ def get_control_if(self):
 return ip
 return None
 
+def check_if_link_exists(self,dev):
+cmd="ip link show dev %s"%dev
+result=CsHelper.execute(cmd)
+if(len(result)!=0):
+   return True
+else:
+   return False
+
+def check_if_link_up(self,dev):
+cmd="ip link show dev %s | tr '\n' ' ' | cut -d ' ' -f 9"%dev
--- End diff --

Hi, 
we have used the subprocess command to find the state of the device in two 
more places. I have created a improvement ticket(CLOUDSTACK-8837) to track 
this. I will work on this later, until then 
i guess the current changes will do.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2281

2015-09-11 Thread jenkins
See 

Changes:

[nitinkumar.maharana] CLOUDSTACK-8821: Provide appropriate message in the UI 
when configuring the Firewall rules.

[Boris Schrijver] Removal of test/debug code.

[w.zhou] CLOUDSTACK-5863: Add unit tests for create/delete/revert volume 
snapshot

[w.zhou] CLOUDSTACK-5863: Add unit tests for take volume snapshot

[w.zhou] Fix coverity scan 1323172

[Boris Schrijver] Added Unit Test for LocalTemplateDownloader.

[wrodrigues] CLOUDSTACK-8822 - Replacing Runnable by Callable in the Taks and 
NioConnection classes

[Rajani Karuturi] unittests to verify empty password is not allowed during 
account create

[sanjeev] CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for CentOS 
5.9

[wido] CLOUDSTACK-8799 fixed the defalut routes

[wido] Added QCOW2 virtual size checking for S3.

[wido] CLOUDSTACK-8799 fixed for vpc networks.

--
[...truncated 28183 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.702s]
[INFO] Apache CloudStack . SUCCESS [2.287s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.800s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.966s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:33.543s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.109s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.092s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.667s]
[INFO] Apache CloudStack API . SUCCESS [1:50.821s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.142s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.486s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.096s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.152s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [26.143s]
[INFO] Apache CloudStack Core  SUCCESS [1:20.047s]
[INFO] Apache CloudStack Agents .. SUCCESS [37.220s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [38.069s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [15.031s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:10.028s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.538s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.355s]
[INFO] Apache CloudStack Server .. SUCCESS [4:23.432s]
[INFO] Apache CloudStack Usage Server  SUCCESS [50.526s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:36.936s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.071s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.444s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [1:00.276s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [52.619s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [34.772s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [29.157s]
[INFO] Apache CloudStack Engine Storage Data Motion 

Re: No more direct commits to master please!

2015-09-11 Thread Wido den Hollander


On 11-09-15 16:26, Remi Bergsma wrote:
> Hi all,
> 
> What happened to master? I see a lot of direct commits. I thought we agreed 
> to make a PR, then _merge_ it to master with the script in ./tools/git/git-pr.
> 

Errr, I used that script?

This is what my Bash history shows me:

wido@wido-desktop:~/repos/cloudstack$ history |grep git-pr
 1752  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/757
 2013  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/783
 2025  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/794
 2027  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/807
 2029  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/795
 2030  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/784
 2043  history |grep git-pr
wido@wido-desktop:~/repos/cloudstack$

They all had 2 LGTM, so I merged them.

Any idea what went wrong here?

> We’re getting ready for a 4.6 RC and this makes stuff extra hard to track. 
> Most direct commits seem to come from PRs, but I don’t think all of them did.
> 
> Talking about this (there are more):
> https://github.com/apache/cloudstack/commit/b66dcda49f370e6fc91ebff889a694f17826ca44
> https://github.com/apache/cloudstack/commit/1c6378ec0056e8c75990a4a0c15e99b2df162a75
> https://github.com/apache/cloudstack/commit/1a02773b556a0efa277cf18cd099fc62a4e27706
> https://github.com/apache/cloudstack/commit/ba59a4b6f31e48e4b6e43e16068e4cacdc45
> https://github.com/apache/cloudstack/commit/f661ac0a2a783447b6eaab590d58091ec542aec2
> 
> Please don’t make me revert the direct commits.
> 
> If you need help with getting PRs merged, ping me or Rajani as we’re happy to 
> help.
> 
> Thanks,
> Remi
> 


Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

2015-09-11 Thread Andrija Panic
THx a lot Wido !!! - we will patch this - For my understanding - is this
"temorary"solution - since it raises limit to 256 snaps ? Or am I wrong ? I
mean, since we dont stil have proper snapshots removal etc, so after i.e.
3-6months we will again have 256 snapshots of a single volume on CEPH ?

BTW we also have other exception, that causes same consequences - agent
disocnnecting and VMs going down...
As Dmytro explained, unprotecting snapshot causes same consequence...

>From my understanding, any RBD exception, might cause Agent to disconnect
(or actually mgmt server to disconnect agent)...

Any clue on this, recommendation?

Thx a lot for fixing rados-java stuff !

Andrija

On 11 September 2015 at 15:28, Wido den Hollander  wrote:

>
>
> On 11-09-15 14:43, Dmytro Shevchenko wrote:
> > Thanks a lot Wido! Any chance to find out why management server decided
> > that it lost connection to agent after that exceptions? It's not so
> > critical as this bug with 16 snapshots, but during last week we catch
> > situation when Agent failed unprotect snapshot, rise exception and this
> > is was a reason of disconnection a bit later after that. (It is not
> > clear why CS decided remove that volume, it was template with one 'gold'
> > snapshot with several active clones)
> >
>
> No, I didn't look at CS at all. I just spend the day improving the RADOS
> bindings.
>
> Wido
>
> > On 09/11/2015 03:20 PM, Wido den Hollander wrote:
> >>
> >> On 11-09-15 10:19, Wido den Hollander wrote:
> >>>
> >>> On 10-09-15 23:15, Andrija Panic wrote:
>  Wido,
> 
>  could you folow maybe what my colegue Dmytro just sent ?
> 
> >>> Yes, seems logical.
> >>>
>  Its not only matter of question fixing rados-java (16 snaps limit)
>  - it
>  seems that for any RBD exception, ACS will freak out...
> 
> >>> No, a RbdException will be caught, but the Rados Bindings shouldn't
> >>> throw NegativeArraySizeException in any case.
> >>>
> >>> That's the main problem.
> >>>
> >> Seems to be fixed with this commit:
> >>
> https://github.com/ceph/rados-java/commit/5584f3961c95d998d2a9eff947a5b7b4d4ba0b64
> >>
> >>
> >> Just tested it with 256 snapshots:
> >>
> >> ---
> >>   T E S T S
> >> ---
> >> Running com.ceph.rbd.TestRbd
> >> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> >> 521.014 sec
> >>
> >> Results :
> >>
> >> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> >>
> >> The bindings should now be capable of listing more then 16 snapshots.
> >>
> >> You can build the bindings manually and replace rados.jar on your
> >> running systems.
> >>
> >> For 4.6 I'll try to get the updated rados-java included.
> >>
> >> Wido
> >>
> >>> Wido
> >>>
>  THx
> 
>  On 10 September 2015 at 17:06, Dmytro Shevchenko <
>  dmytro.shevche...@safeswisscloud.com> wrote:
> 
> > Hello everyone, some clarification about this. Configuration:
> > CS: 4.5.1
> > Primary storage: Ceph
> >
> > Actually we have 2 separate bugs:
> >
> > 1. When you remove some volume with more then 16 snapshots (doesn't
> > matter
> > destroyed or active - they always present on Ceph), on next storage
> > garbage
> > collector cycle it invoke 'deletePhysicalDisk' from
> > LibvirtStorageAdaptor.java. On line 854 we calling list snapshots
> from
> > external rados-java library and getting exception.
> >
> >
> https://github.com/apache/cloudstack/blob/4.5.1/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java#L854
> >
> > This exception do not catching in current function, but Agent DO
> > NOT CRASH
> > at this moment and continue working fine. Agent form proper answer to
> > server and send it, text in answer - java stack trace. Log from
> > Agent side:
> >
> > 2015-09-10 02:32:35,312 DEBUG [kvm.storage.LibvirtStorageAdaptor]
> > (agentRequest-Handler-4:null) Trying to fetch storage pool
> > 33ebaf83-5d09-3038-b63b-742e759a
> > 992e from libvirt
> > 2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
> > (agentRequest-Handler-4:null) Attempting to remove volume
> > 4c6a2092-056c-4446-a2ca-d6bba9f7f
> > 7f8 from pool 33ebaf83-5d09-3038-b63b-742e759a992e
> > 2015-09-10 02:32:35,431 INFO  [kvm.storage.LibvirtStorageAdaptor]
> > (agentRequest-Handler-4:null) Unprotecting and Removing RBD
> > snapshots of
> > image cloudstack-storage
> > /4c6a2092-056c-4446-a2ca-d6bba9f7f7f8 prior to removing the image
> > 2015-09-10 02:32:35,436 DEBUG [kvm.storage.LibvirtStorageAdaptor]
> > (agentRequest-Handler-4:null) Succesfully connected to Ceph cluster
> at
> > 10.10.1.26:6789
> > 2015-09-10 02:32:35,454 DEBUG [kvm.storage.LibvirtStorageAdaptor]
> > (agentRequest-Handler-4:null) Fetching list of snapshots of RBD image
> 

Re: No more direct commits to master please!

2015-09-11 Thread Miguel Ferreira
Hi Wido,

In order to figure out what went wrong, could you please point me to the merge 
commit (the one saying “Merge pull request …”) for commit 
b66dcda49f370e6fc91ebff889a694f17826ca44 ?


Cheers,
\ Miguel Ferreira
   mferre...@schubergphilis.com




On 11 Sep 2015, at 16:39, Wido den Hollander 
> wrote:



On 11-09-15 16:26, Remi Bergsma wrote:
Hi all,

What happened to master? I see a lot of direct commits. I thought we agreed to 
make a PR, then _merge_ it to master with the script in ./tools/git/git-pr.


Errr, I used that script?

This is what my Bash history shows me:

wido@wido-desktop:~/repos/cloudstack$ history |grep git-pr
1752  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/757
2013  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/783
2025  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/794
2027  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/807
2029  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/795
2030  ./tools/git/git-pr https://github.com/apache/cloudstack/pull/784
2043  history |grep git-pr
wido@wido-desktop:~/repos/cloudstack$

They all had 2 LGTM, so I merged them.

Any idea what went wrong here?

We’re getting ready for a 4.6 RC and this makes stuff extra hard to track. Most 
direct commits seem to come from PRs, but I don’t think all of them did.

Talking about this (there are more):
https://github.com/apache/cloudstack/commit/b66dcda49f370e6fc91ebff889a694f17826ca44
https://github.com/apache/cloudstack/commit/1c6378ec0056e8c75990a4a0c15e99b2df162a75
https://github.com/apache/cloudstack/commit/1a02773b556a0efa277cf18cd099fc62a4e27706
https://github.com/apache/cloudstack/commit/ba59a4b6f31e48e4b6e43e16068e4cacdc45
https://github.com/apache/cloudstack/commit/f661ac0a2a783447b6eaab590d58091ec542aec2

Please don’t make me revert the direct commits.

If you need help with getting PRs merged, ping me or Rajani as we’re happy to 
help.

Thanks,
Remi




[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-11 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/728#issuecomment-139582425
  
Hi @sanju1010 please use git-pr script to merge pull requests. Its in the 
source code at tools/git/git-pr
Here is a doc on how to use it 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655
If you face any issues, please ping me or @remibergsma.  Do not do direct 
commits like above to master. only merge commits should be in master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---