[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1024#issuecomment-153286419
  
Thanks @bhaisaab nice fix, have seen it before. Will run some tests soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/950#issuecomment-153286535
  
@miguelaferreira @remibergsma Would this be of any help? 
https://mariadb.com/kb/en/mariadb/about-mariadb-connector-j/

It has a GNU license. Are there any compatability issues?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153286583
  
@wilderrodrigues Thanks for the fix, tests are running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Git with Eclipse

[Daan Hoogland]

never mind: https://github.com/apache/cloudstack-docs-admin/pull/31/files

looked in the wrong repo

On Tue, Nov 3, 2015 at 10:34 AM, Daan Hoogland 
wrote:

> Ron, can you link us to your PR? there is 118 open at the moment and I
> don't see your name with the last bunch.
>
> On Mon, Nov 2, 2015 at 10:59 PM, Ron Wheeler <
> rwhee...@artifact-software.com> wrote:
>
>> Due to Sebastien and Daan's help, I have been able to create a pull
>> request for a small change to the docs.
>> https://wiki.eclipse.org/EGit/User_Guide#Working_with_remote_Repositories
>> was also a great help.
>> It took me a few attempts to get a push to my github repo working but it
>> finally worked.
>>
>> Eclipse/STS is pretty good for editing docs since it has an ReST editor
>> that provides an outline for documents.
>> I would like to have a Maven plug-in for Sphinx but I am not sure about
>> everyone else so it might be tricky to integrate it into my workflow
>> without affecting the master on git.
>>
>> If anyone has a chance to look at the pull request and let me know if I
>> got it right, that would be reassuring.
>>
>> Ron
>>
>>
>>
>>
>>
>> On 30/10/2015 5:58 AM, Sebastien Goasguen wrote:
>>
>>> Ron,
>>>
>>> I don’t know how to use Github with eclipse, I use the command line for
>>> everything.
>>>
>>> But the documentation should be good:
>>>
>>> https://github.com/apache/cloudstack-docs-admin#contributing-to-the-documentation
>>>
>>> Basically you need an account on GitHub.
>>> You fork https://github.com/apache/cloudstack-docs-admin (or the other
>>> docs repo).
>>> You will then have a fork at https://github.com/
>>> /cloudstack-docs-admin
>>>
>>> Clone your own fork:
>>>
>>> $ git clone https://github.com//cloudstack-docs-admin
>>>
>>> Make your commits via eclipse and push to your own fork.
>>>
>>> Then on the GitHub UI, create a pull request to the upstream repo:
>>> https://github.com/apache/cloudstack-docs-admin
>>>
>>> -sebastien
>>>
>>> On Oct 29, 2015, at 9:58 PM, Ron Wheeler 
 wrote:

 Trying to help out with the docs without doing too much damage.
 I am new to git.

 I am using Eclipse with the egit/mylyn plug-in and I have managed to
 get the source for the docs-admin downloaded.

 The "Configure Fetch" has a Source Ref of "refs/heads/*" and a
 Desctination Ref  of "refs/remotes/origin/*"
 I think that I have the right sources. They seem to match the published
 docs.

 I have made my changes and think that I need to create a pull request
 to get one of the Cloudstack gods to decide if my attempts are worthy.

 I have created the pull request in Eclipse but when I try to submit it
 I get an error box titled "Submit failed" popping up with the rather
 cryptic "Unexpected error: Invalid request. "base", "head" weren't
 supplied".
 I think that I have to configure the "Remotes/origin/
 https://gethub.com/apache/cloudstack-doc-admin.git; entry  using
 "Configure Push" menu.

 It has a section called "Ref mappings" that I gather is how git figures
 out how I want my changes mapped back into the remote repos.

 Am I looking in the right places?
 If so, what are the right "Source Ref" and "Destination Ref" entries to
 get a pull request that will please the gods (both local and remote).

 It looks like editing and creating pull requests gets easy once this is
 working.

 Still have to work on getting the document production working so I can
 actually see the fruits of my labour.

 Thanks

 Ron


 *
 *

 --
 Ron Wheeler
 President
 Artifact Software Inc
 email: rwhee...@artifact-software.com
 skype: ronaldmwheeler
 phone: 866-970-2435, ext 102


>>>
>>
>> --
>> Ron Wheeler
>> President
>> Artifact Software Inc
>> email: rwhee...@artifact-software.com
>> skype: ronaldmwheeler
>> phone: 866-970-2435, ext 102
>>
>>
>
>
> --
> Daan
>



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1009#issuecomment-153286973
  
Hi @rags22489664 Thanks for the fix! Can you please get rid of that second 
commit? It cannot be merged like this. Thanks!

If you add a unit test, @dahn can review again. After that we need to see 
when we can merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

[Sanjeev N]

In case of VMWare and Hyper-v , linc local is on eth1. So the command in
all the failed tests to verify link local IP should be modified.
"cat /var/cache/cloud/cmdline | xargs | sed \"s/ /\\n/g\" | grep eth0ip= |
sed \"s/\=/ /g\" | awk '{print $2}'",.
It is using eth0ip. However, it should be eth1ip.

On Tue, Nov 3, 2015 at 12:25 PM, Wilder Rodrigues <
wrodrig...@schubergphilis.com> wrote:

> Thanks , Raja!
>
> Will fix it today!
>
> Cheers,
> Wilder
>
> Sent from my iPhone
>
> On 02 Nov 2015, at 14:11, Raja Pullela > wrote:
>
> Hi wilder, missed your earlier email.. sorry,  here are the details.  Let
> me know if you need any further details.  I believe for Hyperv/Vmware the
> ips come from the pod cidr and the validation should be skipped.
>
> Raja
> Error Message
>
> The cached Link Local should be the same as the current Link Local IP, but
> they are different! Current ==> 10.71.153.33; Cached ==> 169.254.1.130
> Logs available at 
>
> Stacktrace
>
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/root/cloudstack/test/integration/smoke/test_ssvm.py", line 518,
> in test_03_ssvm_internals
> "The cached Link Local should be the same as the current Link Local
> IP, but they are different! Current ==> %s; Cached ==> %s " %
> (linklocal_ip, res)
>   File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 924, in
> assertMultiLineEqual
> self.fail(self._formatMessage(msg, standardMsg))
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> 'The cached Link Local should be the same as the current Link Local IP,
> but they are different! Current ==> 10.71.153.33; Cached ==> 169.254.1.130
> \n
>
> 
>
> From: Wilder Rodrigues >
> Date: November 2, 2015 at 4:04:31 PM GMT+5:30
> To: Rajani Karuturi >, Remi
> Bergsma >,
> Raja Pullela >,
> dev@cloudstack.apache.org <
> dev@cloudstack.apache.org>
> Subject: Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8
> tests in test_ssvm.py
>
> Hi Raja,
>
> We don't have vmware/hyperv test environment. Could you please print the
> whole error message? I'm missing the bit that says:
>
> Current ==> %s; Cached ==> %s
>
> Without the full message I cannot look further into it.
>
> Cheers,
> Wilder
>
>
>
> > On 30 Oct 2015, at 17:03, Raja Pullela > wrote:
> >
> > Hi Wilder
> >
> > The changes from this commit are failing the HyperV and VMware BVTs.
> >
> > Can you please let me know if these tests were passing in your
> environment- VMware, Hyperv?
> >
> > Raja
> >
> > Error - "the cached link local should be same current local ip, but they
> are different!"
> >
>
>

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/950#issuecomment-153289366
  
I've searched the legal section of Apache's JIRA and found several posts 
about including GPL licensed products in builds and test runs. One in 
particular (https://issues.apache.org/jira/browse/LEGAL-19) mentions "runtime 
dependency". My commit "ccb2cd9568fd7d2febfe6de08e43c43e460c0bee" makes the 
mysql connector an explicit runtime dependency, by requiring that the class is 
loaded.

I would argue that mysql connector is already a runtime dependency because 
without it the application won't run. My commit makes that explicit. Which 
could be a problem in legal-land.

I've tried an failed miserably to understand how is the mysql connector 
loaded in tomcat when installing from RPM. Does anyone know how this is done?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153301644
  
@wilderrodrigues apart from the issue mentioned in CLOUDSTACK-9018, I found 
the below issue.
The egress rule added in a default egress ALLOW network doesnt block the 
traffic.

On default egress DENY network, I added a rule to allow 22. iptables rules 
look fine and I am able to ssh from a vm created in this network
```
Chain FW_EGRESS_RULES (1 references)
 pkts bytes target prot opt in out source   
destination
0 0 ACCEPT tcp  --  *  *   0.0.0.0/0
0.0.0.0/0tcp dpt:22
4   288 DROP   all  --  *  *   0.0.0.0/0
0.0.0.0/0
```

```
[root@egress-deny-vm ~]# ssh 10.147.28.48
root@10.147.28.48's password:
Last login: Tue Nov  3 08:49:09 2015 from 10.147.30.176
```
once I delete the rule, I am not able to ssh from the vm anymore and 
iptables rule is deleted. Which is expected. 

But, incase of default egress ALLLOW network, any egress rule added should 
be to block the traffic. ie) rules should be added with target DROP
when I add egress rule to block 22, iptables rule created is to accept 22 
and the port is not blocked
```
Chain FW_EGRESS_RULES (1 references)
 pkts bytes target prot opt in out source   
destination
0 0 ACCEPT tcp  --  *  *   0.0.0.0/0
0.0.0.0/0tcp dpt:22
184 ACCEPT all  --  *  *   0.0.0.0/0
0.0.0.0/0
```
and ssh is not blocked from a vm created in this network(even after 
creating the egress rule to block it).
```
root@10.147.28.48's password:
Last login: Tue Nov  3 08:55:04 2015 from 10.147.30.173
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153287597
  
@jburwell That's fine, although this branch can be rebased easily. I would 
do that before running tests anyway. But I'll focus on 4.6 first, so it makes 
sense to hold it now. Shouldn't take long.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

[DaanHoogland]

Github user DaanHoogland commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153299225
  
Ron, your PR looks fine. It is kind of convention to have a ticket 
describing what needs to be done and then prepend the ticket id to the PR 
description. On the other hand we are moving to github with tickets as well 
(slowly) and in that case it doesn't make sense to have a jira ticket as well.

this LGTM
@runseb Do we apply the 2 lgtm on docs as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

[rags22489664]

Github user rags22489664 commented on the pull request:

https://github.com/apache/cloudstack/pull/1009#issuecomment-153289004
  
oh..let me remove the second commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-153301418
  
this has two lgtm but no report of tests executed. As this is only test 
code I'll recreate an environment and give it a spin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: New PMC member: Erik Weber

[Erik Weber]

Thanks again all :-)

Erik

On Sat, Oct 31, 2015 at 7:06 PM, Jan-Arve Nygård 
wrote:

> Congratulations Erik, well deserved :)
>
> Den fredag 30. oktober 2015 skrev Milamber  følgende:
>
> >
> > Congrats Erik! Good works!
> >
> > On 30/10/2015 14:01, Giles Sirett wrote:
> >
> >> All
> >> The PMC is delighted to announce that we have asked Erik weber to join
> >> the PMC and he has accepted
> >>
> >> Please join me in congratulating Erik
> >>
> >> Kind Regards
> >> Giles
> >>
> >> D: +44 20 3603 0541 | M: +44 796 111
> >> 2055
> >> giles.sir...@shapeblue.com
> >> Find out more about ShapeBlue and our range of CloudStack related
> services
> >>
> >> IaaS Cloud Design & Build<
> >> http://shapeblue.com/iaas-cloud-design-and-build//>
> >> CSForge – rapid IaaS deployment framework >
> >> CloudStack Consulting
> >> CloudStack Software Engineering<
> >> http://shapeblue.com/cloudstack-software-engineering/>
> >> CloudStack Infrastructure Support<
> >> http://shapeblue.com/cloudstack-infrastructure-support/>
> >> CloudStack Bootcamp Training Courses<
> >> http://shapeblue.com/cloudstack-training/>
> >>
> >> This email and any attachments to it may be confidential and are
> intended
> >> solely for the use of the individual to whom it is addressed. Any views
> or
> >> opinions expressed are solely those of the author and do not necessarily
> >> represent those of Shape Blue Ltd or related companies. If you are not
> the
> >> intended recipient of this email, you must neither take any action based
> >> upon its contents, nor copy or show it to anyone. Please contact the
> sender
> >> if you believe you have received this email in error. Shape Blue Ltd is
> a
> >> company incorporated in England & Wales. ShapeBlue Services India LLP
> is a
> >> company incorporated in India and is operated under license from Shape
> Blue
> >> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
> Brasil
> >> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd
> is
> >> a company registered by The Republic of South Africa and is traded under
> >> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
> >>
> >
> >
> >
>

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/950#issuecomment-153287336
  
That seems to be LGPL and as such not allowed by apache policy: 
http://www.apache.org/legal/resolved.html

The issue to me is more on where do the restrictions apply. We cannot 
distribute this dependency but we can use it in development and test. 
Therefore, why not include in the development profile?

I don't know enough about where and how these restrictions apply to make a 
call. The people that might know are not contributing to the discussion, so I'm 
loosing hope.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153285784
  
Ping @remibergsma @borisroman  

Partial results (tests still running)

```
Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status
 : SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: 
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
```

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1024

[4.6/master] CLOUDSTACK-9019: Add storage network offering in ssvm only if 
storage…

… network is defined

During creation of SSVM, checks and adds 
NetworkOffering.SystemStorageNetwork to
offerings only if storage network exists for the target datacenter.

(Manually tested)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-9019-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1024.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1024


commit 8922707076632d478d7ed088a08bf24261e07c82
Author: Rohit Yadav 
Date:   2015-11-03T08:17:23Z

CLOUDSTACK-9019: Add storage network offering in ssvm only if storage 
network is defined

During creation of SSVM, checks and adds 
NetworkOffering.SystemStorageNetwork to
offerings only if storage network exists for the target datacenter

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-153287076
  
LGTM  Based on code understanding

One line change  if attribute is there then proceed to cleanup  if 
hasattr(self, "data_volume_created"): 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

[Sanjeev N]

I am taking back my previous comment. I created VMWare environment and vpc
creation was successful. Please ignore it.


On Tue, Nov 3, 2015 at 12:15 PM, Remi Bergsma 
wrote:

> Hi Sanjeev,
>
> That same tests passes fine here (see all the reviews I posted). Can you
> provide more details, so we can find the difference?
>
> What hypervisor, management server, other environmental properties. Please
> also share the full logs (you may also send them to me private, if you
> don’t want to publish them). Then we can investigate.
>
> Regards,
> Remi
>
>
>
>
>
> On 02/11/15 13:29, "Sanjeev N"  wrote:
>
> >The reason for these two failures is VPC creation itself is failing.
> Reason
> >being "SSH access to VR on 3922 port using its management ip address" is
> >failing. Hence failure in VR start. This looks like product bug to me.
> >
> >-Sanjeev
> >
> >On Fri, Oct 30, 2015 at 10:36 PM, Raja Pullela 
> >wrote:
> >
> >> Super, thanks Remi!
> >>
> >> > On Oct 30, 2015, at 10:35 PM, Remi Bergsma <
> rberg...@schubergphilis.com>
> >> wrote:
> >> >
> >> > Hi Raja,
> >> >
> >> > Talked to Michael and he will improve the test soon.
> >> >
> >> > Regards,
> >> > Remi
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >> On 30/10/15 17:44, "Raja Pullela"  wrote:
> >> >>
> >> >> Hi Michael
> >> >>
> >> >> Can you please add a wait for the template  to download before the VM
> >> creation?
> >> >>
> >> >> Raja
> >> >> Begin forwarded message:
> >> >> From: Raja Pullela > raja.pull...@citrix.com>>
> >> >> Date: October 29, 2015 at 11:49:59 AM GMT+5:30
> >> >> To: "CloudStack Dev (dev@cloudstack.apache.org >> dev@cloudstack.apache.org>)" > dev@cloudstack.apache.org>>
> >> >> Subject: Few BVTs failing
> >> >> Reply-To: >
> >> >>
> >> >> Hi,
> >> >>
> >> >> In the latest BVTs, following tests are failing consistently -
> >> >>
> >> >> * 2015-10-29 00:27:43,987 - CRITICAL - FAILED:
> >> test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '
> >> File "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
> >> testMethod()\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, in
> >> test_vpc_remote_access_vpn\nself.fail(e)\n', '  File
> >> "/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise
> >> self.failureException(msg)\n', 'AssertionError: Execute cmd:
> >> deployvirtualmachine failed, due to: errorCode: 530, errorText:Template
> 202
> >> has not been completely downloaded to zone 1\n']
> >> >>
> >> >> * 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION:
> >> test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File
> >> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
> >> testMethod()\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, in
> >> test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to
> >> deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before
> >> assignment\n"]
> >> >>
> >> >> * 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION:
> >> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most
> >> recent call last):\n', '  File "/usr/lib/python2.7/unittest/case.py",
> line
> >> 329, in run\ntestMethod()\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line
> 576, in
> >> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm =
> >> self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line
> 382, in
> >> deployvm_in_network\nraise Exception("Deployment failed of VM: %s" %
> >> e)\n', "Exception: Deployment failed of VM: Job failed: {jobprocstatus
> : 0,
> >> created : u'2015-10-29T02:02:09+', jobresult : {errorcode : 533,
> >> errortext : u'Unable to create a deployment for VM[User|i-36-69-VM]'},
> cmd
> >> : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin',
> userid
> >> : u'afe432e8-7dd7-11e5-9ca5-b230fb1ebb83', jobstatus : 2, jobid :
> >> u'de5a239a-c70c-4039-9e8e-2ea9b80ed28b', jobresultcode : 530,
> jobinstanceid
> >> : u'47770620-0c37-4e7c-91e0-666bf7fe5eaa', jobresulttype : u'object',
> >> jobinstancetype : u'VirtualMachine', accountid :
> >> u'afe422b2-7dd7-11e5-9ca5-b230fb1ebb83'}\n"]
> >> >>
> >> >> * 2015-10-29 02:00:33,135 - CRITICAL - EXCEPTION:
> >> test02_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most
> recent
> >> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line
> 329, in
> >> run\ntestMethod()\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line
> 686, in
> >> test02_internallb_haproxy_stats_on_all_interfaces\nsettings =
> >> self.get_lb_stats_settings()\n', '  File
> >> 

Re: Git with Eclipse

[Daan Hoogland]

Ron, can you link us to your PR? there is 118 open at the moment and I
don't see your name with the last bunch.

On Mon, Nov 2, 2015 at 10:59 PM, Ron Wheeler  wrote:

> Due to Sebastien and Daan's help, I have been able to create a pull
> request for a small change to the docs.
> https://wiki.eclipse.org/EGit/User_Guide#Working_with_remote_Repositories
> was also a great help.
> It took me a few attempts to get a push to my github repo working but it
> finally worked.
>
> Eclipse/STS is pretty good for editing docs since it has an ReST editor
> that provides an outline for documents.
> I would like to have a Maven plug-in for Sphinx but I am not sure about
> everyone else so it might be tricky to integrate it into my workflow
> without affecting the master on git.
>
> If anyone has a chance to look at the pull request and let me know if I
> got it right, that would be reassuring.
>
> Ron
>
>
>
>
>
> On 30/10/2015 5:58 AM, Sebastien Goasguen wrote:
>
>> Ron,
>>
>> I don’t know how to use Github with eclipse, I use the command line for
>> everything.
>>
>> But the documentation should be good:
>>
>> https://github.com/apache/cloudstack-docs-admin#contributing-to-the-documentation
>>
>> Basically you need an account on GitHub.
>> You fork https://github.com/apache/cloudstack-docs-admin (or the other
>> docs repo).
>> You will then have a fork at https://github.com/
>> /cloudstack-docs-admin
>>
>> Clone your own fork:
>>
>> $ git clone https://github.com//cloudstack-docs-admin
>>
>> Make your commits via eclipse and push to your own fork.
>>
>> Then on the GitHub UI, create a pull request to the upstream repo:
>> https://github.com/apache/cloudstack-docs-admin
>>
>> -sebastien
>>
>> On Oct 29, 2015, at 9:58 PM, Ron Wheeler 
>>> wrote:
>>>
>>> Trying to help out with the docs without doing too much damage.
>>> I am new to git.
>>>
>>> I am using Eclipse with the egit/mylyn plug-in and I have managed to get
>>> the source for the docs-admin downloaded.
>>>
>>> The "Configure Fetch" has a Source Ref of "refs/heads/*" and a
>>> Desctination Ref  of "refs/remotes/origin/*"
>>> I think that I have the right sources. They seem to match the published
>>> docs.
>>>
>>> I have made my changes and think that I need to create a pull request to
>>> get one of the Cloudstack gods to decide if my attempts are worthy.
>>>
>>> I have created the pull request in Eclipse but when I try to submit it I
>>> get an error box titled "Submit failed" popping up with the rather cryptic
>>> "Unexpected error: Invalid request. "base", "head" weren't supplied".
>>> I think that I have to configure the "Remotes/origin/
>>> https://gethub.com/apache/cloudstack-doc-admin.git; entry  using
>>> "Configure Push" menu.
>>>
>>> It has a section called "Ref mappings" that I gather is how git figures
>>> out how I want my changes mapped back into the remote repos.
>>>
>>> Am I looking in the right places?
>>> If so, what are the right "Source Ref" and "Destination Ref" entries to
>>> get a pull request that will please the gods (both local and remote).
>>>
>>> It looks like editing and creating pull requests gets easy once this is
>>> working.
>>>
>>> Still have to work on getting the document production working so I can
>>> actually see the fruits of my labour.
>>>
>>> Thanks
>>>
>>> Ron
>>>
>>>
>>> *
>>> *
>>>
>>> --
>>> Ron Wheeler
>>> President
>>> Artifact Software Inc
>>> email: rwhee...@artifact-software.com
>>> skype: ronaldmwheeler
>>> phone: 866-970-2435, ext 102
>>>
>>>
>>
>
> --
> Ron Wheeler
> President
> Artifact Software Inc
> email: rwhee...@artifact-software.com
> skype: ronaldmwheeler
> phone: 866-970-2435, ext 102
>
>


-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-153285936
  
LGTM based on code review.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9019: Add storage networ...

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1025

[4.5] CLOUDSTACK-9019: Add storage network offering in ssvm only if 
storage…

… network is defined

During creation of SSVM, checks and adds 
NetworkOffering.SystemStorageNetwork to
offerings only if storage network exists for the target datacenter

(Manually tested)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-9019-4.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1025.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1025


commit 619f0eb276499a7b8f31d31f6479d27f215c7b3f
Author: Rohit Yadav 
Date:   2015-11-03T08:17:23Z

CLOUDSTACK-9019: Add storage network offering in ssvm only if storage 
network is defined

During creation of SSVM, checks and adds 
NetworkOffering.SystemStorageNetwork to
offerings only if storage network exists for the target datacenter

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

[Wilder Rodrigues]

Thanks for the details, Sanjeev.

Fixing the test now. PR to follow.

Cheers,
Wilder

> On 03 Nov 2015, at 10:26, Sanjeev N  wrote:
> 
> In case of VMWare and Hyper-v , linc local is on eth1. So the command in
> all the failed tests to verify link local IP should be modified.
> "cat /var/cache/cloud/cmdline | xargs | sed \"s/ /\\n/g\" | grep eth0ip= |
> sed \"s/\=/ /g\" | awk '{print $2}'",.
> It is using eth0ip. However, it should be eth1ip.
> 
> On Tue, Nov 3, 2015 at 12:25 PM, Wilder Rodrigues <
> wrodrig...@schubergphilis.com> wrote:
> 
>> Thanks , Raja!
>> 
>> Will fix it today!
>> 
>> Cheers,
>> Wilder
>> 
>> Sent from my iPhone
>> 
>> On 02 Nov 2015, at 14:11, Raja Pullela  raja.pull...@citrix.com>> wrote:
>> 
>> Hi wilder, missed your earlier email.. sorry,  here are the details.  Let
>> me know if you need any further details.  I believe for Hyperv/Vmware the
>> ips come from the pod cidr and the validation should be skipped.
>> 
>> Raja
>> Error Message
>> 
>> The cached Link Local should be the same as the current Link Local IP, but
>> they are different! Current ==> 10.71.153.33; Cached ==> 169.254.1.130
>> Logs available at 
>> 
>> Stacktrace
>> 
>>  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
>>testMethod()
>>  File "/root/cloudstack/test/integration/smoke/test_ssvm.py", line 518,
>> in test_03_ssvm_internals
>>"The cached Link Local should be the same as the current Link Local
>> IP, but they are different! Current ==> %s; Cached ==> %s " %
>> (linklocal_ip, res)
>>  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
>>assertion_func(first, second, msg=msg)
>>  File "/usr/lib/python2.7/unittest/case.py", line 924, in
>> assertMultiLineEqual
>>self.fail(self._formatMessage(msg, standardMsg))
>>  File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
>>raise self.failureException(msg)
>> 'The cached Link Local should be the same as the current Link Local IP,
>> but they are different! Current ==> 10.71.153.33; Cached ==> 169.254.1.130
>> \n
>> 
>> 
>> 
>> From: Wilder Rodrigues  wrodrig...@schubergphilis.com>>
>> Date: November 2, 2015 at 4:04:31 PM GMT+5:30
>> To: Rajani Karuturi >, Remi
>> Bergsma >,
>> Raja Pullela >,
>> dev@cloudstack.apache.org <
>> dev@cloudstack.apache.org>
>> Subject: Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8
>> tests in test_ssvm.py
>> 
>> Hi Raja,
>> 
>> We don't have vmware/hyperv test environment. Could you please print the
>> whole error message? I'm missing the bit that says:
>> 
>> Current ==> %s; Cached ==> %s
>> 
>> Without the full message I cannot look further into it.
>> 
>> Cheers,
>> Wilder
>> 
>> 
>> 
>>> On 30 Oct 2015, at 17:03, Raja Pullela  raja.pull...@citrix.com>> wrote:
>>> 
>>> Hi Wilder
>>> 
>>> The changes from this commit are failing the HyperV and VMware BVTs.
>>> 
>>> Can you please let me know if these tests were passing in your
>> environment- VMware, Hyperv?
>>> 
>>> Raja
>>> 
>>> Error - "the cached link local should be same current local ip, but they
>> are different!"
>>> 
>> 
>> 

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-153302753
  
Test Result:

Storage and Snapshot Limit ...
--
Ran 1 test in 970.317s

OK




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153309944
  
Usage of @LogLevel(Log4jLevel.Off) seems inappropriate to avoid logging 
sensitive information, why not still check the sensitive param/annotation to 
log or not log data?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153337620
  
@DaanHoogland @bhaisaab I also couldn't find any annotation on API fields 
for this. So ended up using the LogLevel which is also used in the agent 
commands.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

[michaelandersen]

Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1028#issuecomment-153338369
  
Tested change on a KVM hypervisor:

Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok

--
Ran 2 tests in 1084.378s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/866#issuecomment-153339945
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 29 tests in 12815.696s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py 

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1024#issuecomment-153351476
  
Thanks @remibergsma 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153351842
  
@remibergsma agree regarding the rebase effort.  However, I am not going to 
spend time testing now knowing that it will need to be retested when master is 
unfrozen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

[Ron Wheeler]

I can make a JIRA if that will help keep things straight.

Ron

On 03/11/2015 4:41 AM, DaanHoogland wrote:

Github user DaanHoogland commented on the pull request:

 
https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153299225
   
 Ron, your PR looks fine. It is kind of convention to have a ticket describing what needs to be done and then prepend the ticket id to the PR description. On the other hand we are moving to github with tickets as well (slowly) and in that case it doesn't make sense to have a jira ticket as well.
 
 this LGTM

 @runseb Do we apply the 2 lgtm on docs as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---




--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153305656
  
Thanks for the details, @karuturi ! I will fix that.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153309653
  
More test results. It did not break existing functionality, but still I 
will fix the one @karuturi found.

Cheers,
Wilder

```
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: 
test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status 
: SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : 
SUCCESS ===
ok
test_09_create_redundant_vpc_offering 
(integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: 
test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok

--
Ran 13 tests in 3403.790s

OK
/tmp//MarvinLogs/test_vpc_offerings_6W7KGH/results.txt (END)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

[pdion891]

Github user pdion891 commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153337733
  
LGTM, formating is fine in the current sphinx theme. 

Having the link to the feature spec mention at line 305 would have been a 
nice to have. 

Thanks for the PR!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

[michaelandersen]

Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1028#issuecomment-153338103
  
@sanjeevneelarapu please review once build checks are completed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

[Remi Bergsma]

Hi Raja,

Please see this PR: https://github.com/apache/cloudstack/pull/1028

Regards,
Remi




On 30/10/15 17:44, "Raja Pullela"  wrote:

>Hi Michael
>
>Can you please add a wait for the template  to download before the VM creation?
>
>Raja
>Begin forwarded message:
>From: Raja Pullela >
>Date: October 29, 2015 at 11:49:59 AM GMT+5:30
>To: "CloudStack Dev 
>(dev@cloudstack.apache.org)" 
>>
>Subject: Few BVTs failing
>Reply-To: >
>
>Hi,
>
>In the latest BVTs, following tests are failing consistently -
>
>* 2015-10-29 00:27:43,987 - CRITICAL - FAILED: 
>test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '  File 
>"/usr/lib/python2.7/unittest/case.py", line 329, in run\ntestMethod()\n', 
>'  File "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, 
>in test_vpc_remote_access_vpn\nself.fail(e)\n', '  File 
>"/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise 
>self.failureException(msg)\n', 'AssertionError: Execute cmd: 
>deployvirtualmachine failed, due to: errorCode: 530, errorText:Template 202 
>has not been completely downloaded to zone 1\n']
>
>* 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION: 
>test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File 
>"/usr/lib/python2.7/unittest/case.py", line 329, in run\ntestMethod()\n', 
>'  File "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, 
>in test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to 
>deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before 
>assignment\n"]
>
>* 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION: 
>test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most recent 
>call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>run\ntestMethod()\n', '  File 
>"/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 576, in 
>test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm = 
>self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File 
>"/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 382, in 
>deployvm_in_network\nraise Exception("Deployment failed of VM: %s" % 
>e)\n', "Exception: Deployment failed of VM: Job failed: {jobprocstatus : 0, 
>created : u'2015-10-29T02:02:09+', jobresult : {errorcode : 533, errortext 
>: u'Unable to create a deployment for VM[User|i-36-69-VM]'}, cmd : 
>u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : 
>u'afe432e8-7dd7-11e5-9ca5-b230fb1ebb83', jobstatus : 2, jobid : 
>u'de5a239a-c70c-4039-9e8e-2ea9b80ed28b', jobresultcode : 530, jobinstanceid : 
>u'47770620-0c37-4e7c-91e0-666bf7fe5eaa', jobresulttype : u'object', 
>jobinstancetype : u'VirtualMachine', accountid : 
>u'afe422b2-7dd7-11e5-9ca5-b230fb1ebb83'}\n"]
>
>* 2015-10-29 02:00:33,135 - CRITICAL - EXCEPTION: 
>test02_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most recent 
>call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>run\ntestMethod()\n', '  File 
>"/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 686, in 
>test02_internallb_haproxy_stats_on_all_interfaces\nsettings = 
>self.get_lb_stats_settings()\n', '  File 
>"/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 646, in 
>get_lb_stats_settings\nself.fail("Failed to retrieve stats settings " % 
>e)\n', 'TypeError: not all arguments converted during string formatting\n']
>
>Looks like these were added by Michael.
>
>Michael,
>Can you optimize the tests with the following
>
>1)  Before the VM Deployment or right after Template Register, can you put 
>a loop to check if the Template is in a ready state before continuing with the 
>test ? The reason is Template download is not getting completed and as a 
>result the test cases are failing.
>
>2)  Any reason for not using test_data.py to have all the 
>configuration/settings you have defined the test file ?
>
>Please let me know if you have any questions,
>Raja
>

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-admin/pull/31


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1028#discussion_r43742770
  
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -570,127 +584,139 @@ def test_vpc_site2site_vpn(self):
 finally:
 self.assertIsNotNone(ntwk2, "Network failed to create")
 
-self.logger.debug("Network %s created in VPC %s" %(ntwk2.id, 
vpc2.id))
+self.logger.debug("Network %s created in VPC %s" % (ntwk2.id, 
vpc2.id))
 
 # Deploy a vm in network 2
 try:
 vm1 = VirtualMachine.create(self.apiclient, 
services=self.services["virtual_machine"],
-templateid=self.template.id,
-zoneid=self.zone.id,
-accountid=self.account.name,
-domainid= self.account.domainid,
-serviceofferingid=self.service_offering.id,
-networkids=ntwk1.id,
-hypervisor=self.services["virtual_machine"]["hypervisor"]
-)
+templateid=self.template.id,
+zoneid=self.zone.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+
serviceofferingid=self.service_offering.id,
+networkids=ntwk1.id,
+hypervisor=self.services[
+
"virtual_machine"]["hypervisor"]
+)
 except Exception as e:
 self.fail(e)
 finally:
 self.assert_(vm1 is not None, "VM failed to deploy")
 self.assert_(vm1.state == 'Running', "VM is not running")
 
-self.logger.debug("VM %s deployed in VPC %s" %(vm1.id, vpc1.id))
+self.logger.debug("VM %s deployed in VPC %s" % (vm1.id, vpc1.id))
 
 # Deploy a vm in network 2
 try:
 vm2 = VirtualMachine.create(self.apiclient, 
services=self.services["virtual_machine"],
-templateid=self.template.id,
-zoneid=self.zone.id,
-accountid=self.account.name,
-domainid= self.account.domainid,
-serviceofferingid=self.service_offering.id,
-networkids=ntwk2.id,
-hypervisor=self.services["virtual_machine"]["hypervisor"]
-)
+templateid=self.template.id,
+zoneid=self.zone.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+
serviceofferingid=self.service_offering.id,
+networkids=ntwk2.id,
+hypervisor=self.services[
+
"virtual_machine"]["hypervisor"]
+)
 except Exception as e:
 self.fail(e)
 finally:
 self.assert_(vm2 is not None, "VM failed to deploy")
 self.assert_(vm2.state == 'Running', "VM is not running")
 
-self.debug("VM %s deployed in VPC %s" %(vm2.id, vpc2.id))
+self.debug("VM %s deployed in VPC %s" % (vm2.id, vpc2.id))
 
 # 4) Enable Site-to-Site VPN for VPC
 vpn1_response = Vpn.createVpnGateway(self.apiclient, vpc1.id)
-self.assert_(vpn1_response is not None, "Failed to enable VPN 
Gateway 1")
+self.assert_(
+vpn1_response is not None, "Failed to enable VPN Gateway 1")
 self.logger.debug("VPN gateway for VPC %s enabled" % vpc1.id)
 
 vpn2_response = Vpn.createVpnGateway(self.apiclient, vpc2.id)
-self.assert_(vpn2_response is not None, "Failed to enable VPN 
Gateway 2")
+self.assert_(
+vpn2_response is not None, "Failed to enable VPN Gateway 2")
 self.logger.debug("VPN gateway for VPC %s enabled" % vpc2.id)
 
 # 5) Add VPN Customer gateway info
 src_nat_list = PublicIPAddress.list(
-self.apiclient,
-account=self.account.name,
-domainid=self.account.domainid,
-listall=True,
-issourcenat=True,
-vpcid=vpc1.id
-

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1024#issuecomment-153341635
  
Result before this PR:

```
root@s-58-VM:~# ifconfig 
eth0  Link encap:Ethernet  HWaddr 0e:00:a9:fe:03:b0  
  inet addr:169.254.3.176  Bcast:169.254.255.255  Mask:255.255.0.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:1362 errors:0 dropped:0 overruns:0 frame:0
  TX packets:74 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:68093 (66.4 KiB)  TX bytes:11731 (11.4 KiB)

eth1  Link encap:Ethernet  HWaddr 06:8f:3c:00:00:0e  
  inet addr:192.168.22.143  Bcast:192.168.22.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:63121 errors:0 dropped:1 overruns:0 frame:0
  TX packets:31637 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:84701257 (80.7 MiB)  TX bytes:125724065 (119.8 MiB)

eth2  Link encap:Ethernet  HWaddr 06:3c:56:00:00:16  
  inet addr:192.168.23.2  Bcast:192.168.23.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:1009 errors:0 dropped:0 overruns:0 frame:0
  TX packets:36 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:47700 (46.5 KiB)  TX bytes:3072 (3.0 KiB)

eth3  Link encap:Ethernet  HWaddr 06:9b:9e:00:00:14  
  inet addr:192.168.22.149  Bcast:192.168.22.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:3599 errors:0 dropped:1 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:193180 (188.6 KiB)  TX bytes:0 (0.0 B)

loLink encap:Local Loopback  
  inet addr:127.0.0.1  Mask:255.0.0.0
  UP LOOPBACK RUNNING  MTU:16436  Metric:1
  RX packets:0 errors:0 dropped:0 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0 
  RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
```

```
root@s-58-VM:~# route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric RefUse 
Iface
0.0.0.0 192.168.22.10.0.0.0 UG0  00 eth1
8.8.4.4 192.168.22.1255.255.255.255 UGH   0  00 eth1
169.254.0.0 0.0.0.0 255.255.0.0 U 0  00 eth0
192.168.22.00.0.0.0 255.255.255.0   U 0  00 eth1
192.168.22.00.0.0.0 255.255.255.0   U 0  00 eth3
192.168.23.00.0.0.0 255.255.255.0   U 0  00 eth2
```

After this PR:

```
root@s-1-VM:~# ifconfig 
eth0  Link encap:Ethernet  HWaddr 0e:00:a9:fe:03:44  
  inet addr:169.254.3.68  Bcast:169.254.255.255  Mask:255.255.0.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:30 errors:0 dropped:0 overruns:0 frame:0
  TX packets:12 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:1748 (1.7 KiB)  TX bytes:687 (687.0 B)

eth1  Link encap:Ethernet  HWaddr 06:00:c6:00:00:01  
  inet addr:192.168.22.130  Bcast:192.168.22.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:39717 errors:0 dropped:0 overruns:0 frame:0
  TX packets:17889 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:43372312 (41.3 MiB)  TX bytes:63330617 (60.3 MiB)

eth2  Link encap:Ethernet  HWaddr 06:82:d6:00:00:16  
  inet addr:192.168.23.2  Bcast:192.168.23.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:32 errors:0 dropped:0 overruns:0 frame:0
  TX packets:34 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:3128 (3.0 KiB)  TX bytes:2844 (2.7 KiB)

loLink encap:Local Loopback  
  inet addr:127.0.0.1  Mask:255.0.0.0
  UP LOOPBACK RUNNING  MTU:16436  Metric:1
  RX packets:0 errors:0 dropped:0 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0 
  RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
```

```
root@s-1-VM:~# route -n
Kernel IP routing table
Destination Gateway 

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9019: Add storage networ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1025#issuecomment-153341540
  
Result before this PR:

```
root@s-58-VM:~# ifconfig 
eth0  Link encap:Ethernet  HWaddr 0e:00:a9:fe:03:b0  
  inet addr:169.254.3.176  Bcast:169.254.255.255  Mask:255.255.0.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:1362 errors:0 dropped:0 overruns:0 frame:0
  TX packets:74 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:68093 (66.4 KiB)  TX bytes:11731 (11.4 KiB)

eth1  Link encap:Ethernet  HWaddr 06:8f:3c:00:00:0e  
  inet addr:192.168.22.143  Bcast:192.168.22.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:63121 errors:0 dropped:1 overruns:0 frame:0
  TX packets:31637 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:84701257 (80.7 MiB)  TX bytes:125724065 (119.8 MiB)

eth2  Link encap:Ethernet  HWaddr 06:3c:56:00:00:16  
  inet addr:192.168.23.2  Bcast:192.168.23.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:1009 errors:0 dropped:0 overruns:0 frame:0
  TX packets:36 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:47700 (46.5 KiB)  TX bytes:3072 (3.0 KiB)

eth3  Link encap:Ethernet  HWaddr 06:9b:9e:00:00:14  
  inet addr:192.168.22.149  Bcast:192.168.22.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:3599 errors:0 dropped:1 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:193180 (188.6 KiB)  TX bytes:0 (0.0 B)

loLink encap:Local Loopback  
  inet addr:127.0.0.1  Mask:255.0.0.0
  UP LOOPBACK RUNNING  MTU:16436  Metric:1
  RX packets:0 errors:0 dropped:0 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0 
  RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
```

```
root@s-58-VM:~# route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric RefUse 
Iface
0.0.0.0 192.168.22.10.0.0.0 UG0  00 eth1
8.8.4.4 192.168.22.1255.255.255.255 UGH   0  00 eth1
169.254.0.0 0.0.0.0 255.255.0.0 U 0  00 eth0
192.168.22.00.0.0.0 255.255.255.0   U 0  00 eth1
192.168.22.00.0.0.0 255.255.255.0   U 0  00 eth3
192.168.23.00.0.0.0 255.255.255.0   U 0  00 eth2
```

After this PR:

```
root@s-1-VM:~# ifconfig 
eth0  Link encap:Ethernet  HWaddr 0e:00:a9:fe:03:44  
  inet addr:169.254.3.68  Bcast:169.254.255.255  Mask:255.255.0.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:30 errors:0 dropped:0 overruns:0 frame:0
  TX packets:12 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:1748 (1.7 KiB)  TX bytes:687 (687.0 B)

eth1  Link encap:Ethernet  HWaddr 06:00:c6:00:00:01  
  inet addr:192.168.22.130  Bcast:192.168.22.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:39717 errors:0 dropped:0 overruns:0 frame:0
  TX packets:17889 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:43372312 (41.3 MiB)  TX bytes:63330617 (60.3 MiB)

eth2  Link encap:Ethernet  HWaddr 06:82:d6:00:00:16  
  inet addr:192.168.23.2  Bcast:192.168.23.255  Mask:255.255.255.0
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:32 errors:0 dropped:0 overruns:0 frame:0
  TX packets:34 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:3128 (3.0 KiB)  TX bytes:2844 (2.7 KiB)

loLink encap:Local Loopback  
  inet addr:127.0.0.1  Mask:255.0.0.0
  UP LOOPBACK RUNNING  MTU:16436  Metric:1
  RX packets:0 errors:0 dropped:0 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0 
  RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
```

```
root@s-1-VM:~# route -n
Kernel IP routing table
Destination Gateway 

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1012#issuecomment-153342236
  
This is already merged, I was running some tests. Documenting the results 
here just in case we have to look back at it:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
[root@cs1 MarvinLogs]# less test_network_NUVQG1/results.txt 
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 29 tests in 12492.734s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \

Re: [GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

[Ron Wheeler]

Thanks
I have downloaded and installed Sphinx so I will be able to generate the 
docs before the next PR.


Ron

On 03/11/2015 5:49 AM, terbolous wrote:

Github user terbolous commented on the pull request:

 
https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934
   
 LGTM, verified in the github preview that the output renders correctly.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---



--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

[Raja Pullela]

Cool, thanks Remi!  a job is scheduled to run tomorrow morning and looking 
forward to see 100% passrates! 

Best
Raja 

> On Nov 3, 2015, at 6:05 PM, Remi Bergsma  wrote:
> 
> Hi Raja,
> 
> Please see this PR: https://github.com/apache/cloudstack/pull/1028
> 
> Regards,
> Remi
> 
> 
> 
> 
>> On 30/10/15 17:44, "Raja Pullela"  wrote:
>> 
>> Hi Michael
>> 
>> Can you please add a wait for the template  to download before the VM 
>> creation?
>> 
>> Raja
>> Begin forwarded message:
>> From: Raja Pullela >
>> Date: October 29, 2015 at 11:49:59 AM GMT+5:30
>> To: "CloudStack Dev 
>> (dev@cloudstack.apache.org)" 
>> >
>> Subject: Few BVTs failing
>> Reply-To: >
>> 
>> Hi,
>> 
>> In the latest BVTs, following tests are failing consistently -
>> 
>> * 2015-10-29 00:27:43,987 - CRITICAL - FAILED: 
>> test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
>> testMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, in 
>> test_vpc_remote_access_vpn\nself.fail(e)\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise 
>> self.failureException(msg)\n', 'AssertionError: Execute cmd: 
>> deployvirtualmachine failed, due to: errorCode: 530, errorText:Template 202 
>> has not been completely downloaded to zone 1\n']
>> 
>> * 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION: 
>> test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
>> testMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, in 
>> test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to 
>> deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before 
>> assignment\n"]
>> 
>> * 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION: 
>> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most recent 
>> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>> run\ntestMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 576, in 
>> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm = 
>> self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 382, in 
>> deployvm_in_network\nraise Exception("Deployment failed of VM: %s" % 
>> e)\n', "Exception: Deployment failed of VM: Job failed: {jobprocstatus : 0, 
>> created : u'2015-10-29T02:02:09+', jobresult : {errorcode : 533, 
>> errortext : u'Unable to create a deployment for VM[User|i-36-69-VM]'}, cmd : 
>> u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : 
>> u'afe432e8-7dd7-11e5-9ca5-b230fb1ebb83', jobstatus : 2, jobid : 
>> u'de5a239a-c70c-4039-9e8e-2ea9b80ed28b', jobresultcode : 530, jobinstanceid 
>> : u'47770620-0c37-4e7c-91e0-666bf7fe5eaa', jobresulttype : u'object', 
>> jobinstancetype : u'VirtualMachine', accountid : 
>> u'afe422b2-7dd7-11e5-9ca5-b230fb1ebb83'}\n"]
>> 
>> * 2015-10-29 02:00:33,135 - CRITICAL - EXCEPTION: 
>> test02_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most recent 
>> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>> run\ntestMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 686, in 
>> test02_internallb_haproxy_stats_on_all_interfaces\nsettings = 
>> self.get_lb_stats_settings()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 646, in 
>> get_lb_stats_settings\nself.fail("Failed to retrieve stats settings " % 
>> e)\n', 'TypeError: not all arguments converted during string formatting\n']
>> 
>> Looks like these were added by Michael.
>> 
>> Michael,
>> Can you optimize the tests with the following
>> 
>> 1)  Before the VM Deployment or right after Template Register, can you 
>> put a loop to check if the Template is in a ready state before continuing 
>> with the test ? The reason is Template download is not getting completed and 
>> as a result the test cases are failing.
>> 
>> 2)  Any reason for not using test_data.py to have all the 
>> configuration/settings you have defined the test file ?
>> 
>> Please let me know if you have any questions,
>> Raja
>> 

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-153336055
  
@wido any chance libvirt can be upgraded?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

[michaelandersen]

GitHub user michaelandersen opened a pull request:

https://github.com/apache/cloudstack/pull/1028

smoke/test_vpc_vpn: Add template wait & refactor

- Added a wait for template download as the test was failing in some 
environments
- Removed debug timer in setup and teardown
- Increased time.sleep before ssh connection from 10 to 20 seconds


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandersen/cloudstack fix/vpc_vpn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1028.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1028


commit d6ee8caf3e15727ce30405c02452dca90f8f8a99
Author: Michael Andersen 
Date:   2015-11-03T12:25:35Z

smoke/test_vpc_vpn: Add template wait & refactor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153338874
  
The field level annotation was discussed as a prefered solution but in the 
end a regexp on field names was used. I am fine with re-using the LogLevel 
annotation. It does what is needed and the name suggests this use.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

[michaelandersen]

Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1028#issuecomment-153338894
  
executed tests with: 
nosetests --with-marvin --marvin-config=./mct-zone1-kvm1.cfg -a 
tags=advanced  test_vpc_vpn.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153327157
  
@bhaisaab What are your reasons for saying that @LogLevel(Log4jLevel.Off) 
is inappropriate?

By sensitive param/annotation are you referring to the existing @APICommand 
annotation params requestHasSensitiveInfo/responseHasSensitiveInfo? The problem 
with this approach is that it doesn't tell about the specific field which is 
sensitive and so the entire response needs to be searched for sensitive data by 
means of regex which is very bad in terms of performance.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: qemu-guest-agent support...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1027

CLOUDSTACK-8715: qemu-guest-agent support on KVM

@wido can you check if these codes are useful for you? 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack guest-agent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1027.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1027


commit 9317ef728f66ca7ff26166592ca2083432fdc805
Author: Wido den Hollander 
Date:   2015-10-27T10:03:49Z

CLOUDSTACK-8715: Add VirtIO channel to all Instances for the Qemu Guest 
Agent

This commit adds a additional VirtIO channel with the name 
'org.qemu.guest_agent.0'
to all Instances.

With the Qemu Guest Agent the Hypervisor gains more control over the 
Instance if
these tools are present inside the Instance, for example:

* Power control
* Flushing filesystems

In the future this should allow safer snapshots on KVM since we can 
instruct the
Instance to flush the filesystems prior to snapshotting the disk.

More information: http://wiki.qemu.org/Features/QAPI/GuestAgent

Keep in mind that on Ubuntu AppArmor still needs to be disabled since the 
default
AppArmor profile doesn't allow libvirt to write into /var/lib/libvirt/qemu

commit dbf8d0271eee8fd6a79f0159e377c636a0960011
Author: Wido den Hollander 
Date:   2015-10-30T11:33:27Z

Install the Qemu Guest Agent inside the SSVM

commit f6e4955e128d4079692900630f8cbc1096840696
Author: Wei Zhou 
Date:   2015-11-01T20:56:09Z

[Guest Agent] add guest_agent column in vm_template table

commit 13c7b8d472f1ae3992398a17317df48f3900317c
Author: Wei Zhou 
Date:   2015-11-02T07:52:18Z

[Guest Agent] add guest agent support in kvm hypervisor plugin

commit 8df88e484ef0140a7ead5fdd6c49aebcae45
Author: Wei Zhou 
Date:   2015-11-02T09:15:41Z

[Guest Agent] add rebootVM and stopVM via guest agent

commit 83abf9f0d9a125449a48a6211f6a6e9898088026
Author: Wei Zhou 
Date:   2015-11-03T09:44:32Z

[Guest Agent] send boot args to systemvms by send_to_vm_agent.py

commit 010e5a7699bbc871473363530bb890bddbf1ed99
Author: Wei Zhou 
Date:   2015-11-03T11:46:00Z

[Guest Agent] fix UI bugs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9021 - Add right interface whe...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1026


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-153301936
  
2 lgtm but no test report, will execute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1024#issuecomment-153311038
  
Seems like a good fix to me. Can't test it manually at this moment though


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-153312402
  
@DaanHoogland @ustcweizhou Overall it seems good! It's just hard to test 
this since it can break migration of VMs and you also have to deal with all the 
versions of libvirt.

But overall I think it's OK. If you can take a look at my comments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/977#discussion_r43734401
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreVMSnapshotCommandWrapper.java
 ---
@@ -0,0 +1,103 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import java.util.List;
+import java.util.Map;
+
+import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.apache.log4j.Logger;
+import org.libvirt.Connect;
+import org.libvirt.Domain;
+import org.libvirt.LibvirtException;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.RestoreVMSnapshotAnswer;
+import com.cloud.agent.api.RestoreVMSnapshotCommand;
+import com.cloud.agent.api.VMSnapshotTO;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.vm.VirtualMachine;
+
+@ResourceWrapper(handles =  RestoreVMSnapshotCommand.class)
+public final class LibvirtRestoreVMSnapshotCommandWrapper extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtRestoreVMSnapshotCommandWrapper.class);
+
+@Override
+public Answer execute(final RestoreVMSnapshotCommand cmd, final 
LibvirtComputingResource libvirtComputingResource) {
+String vmName = cmd.getVmName();
+List listVolumeTo = cmd.getVolumeTOs();
+VirtualMachine.PowerState vmState = 
VirtualMachine.PowerState.PowerOn;
+
+Domain dm = null;
+try {
+final LibvirtUtilitiesHelper libvirtUtilitiesHelper = 
libvirtComputingResource.getLibvirtUtilitiesHelper();
+Connect conn = libvirtUtilitiesHelper.getConnection();
+dm = libvirtComputingResource.getDomain(conn, vmName);
+
+if (dm == null) {
+return new RestoreVMSnapshotAnswer(cmd, false,
+"Restore VM Snapshot Failed due to can not find 
vm: " + vmName);
+}
+String xmlDesc = dm.getXMLDesc(0);
+
+List snapshots = cmd.getSnapshots();
+Map snapshotAndParents = 
cmd.getSnapshotAndParents();
+for (VMSnapshotTO snapshot: snapshots) {
+VMSnapshotTO parent = 
snapshotAndParents.get(snapshot.getId());
+String parentName = (parent == null)? "": ("  
" + parent.getSnapshotName() + "\n");
+String vmSnapshotXML = "\n"
--- End diff --

Can we maybe offload this to a helper which generates the XML? We have this 
for multiple things. That allows us to Unit Test the XML generation. That is 
very hard to do when it's inline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9021 - Add right interface whe...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1026#issuecomment-153329985
  
change makes sense, I have no hyperv or vmware to test on.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-noredist #4710

[jenkins]

See 

Changes:

[wrodrigues] CLOUDSTACK-9021 - Add right interface when test is executed 
against HyperV/VMware

--
[...truncated 849 lines...]
2015-11-03 12:09:47,045 DEBUG [utils.script.Script] (main:) Classpath resource: 
null
2015-11-03 12:09:47,046 DEBUG [utils.script.Script] (main:) Executing: 
/bin/bash -c echo 'hello world!' 
2015-11-03 12:09:47,049 DEBUG [utils.script.Script] (main:) Execution is 
successful.
2015-11-03 12:09:47,049 WARN  [utils.script.Script] (main:) Exception: 
/bin/bash -c echo 'hello world!' 
java.lang.IllegalArgumentException
at com.cloud.utils.ScriptTest$1.interpret(ScriptTest.java:107)
at com.cloud.utils.script.Script.execute(Script.java:223)
at 
com.cloud.utils.ScriptTest.executeWithOutputInterpreter(ScriptTest.java:103)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
2015-11-03 12:09:47,052 DEBUG [utils.script.Script] (main:) Executing: 
/bin/bash -c /not/existing/scripts/1446552587052 
2015-11-03 12:09:47,054 DEBUG [utils.script.Script] (main:) Exit value is 127
2015-11-03 12:09:47,055 DEBUG [utils.script.Script] (main:) /bin/bash: 
/not/existing/scripts/1446552587052: No such file or directory
2015-11-03 12:09:47,056 DEBUG [utils.script.Script] (main:) Executing: 
/bin/bash -c echo 'hello world!' 
2015-11-03 12:09:47,058 DEBUG [utils.script.Script] (main:) Execution is 
successful.
2015-11-03 12:09:47,059 DEBUG [utils.script.Script] (main:) Executing: 
/bin/bash -c echo 'hello world!' 
2015-11-03 12:09:47,062 DEBUG [utils.script.Script] (main:) Execution is 
successful.
Tests run: 10, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.045 sec - in 
com.cloud.utils.ScriptTest
Running com.cloud.utils.TestProfiler
Configure log4j with default properties
2015-11-03 12:09:47,088 INFO  [cloud.utils.TestProfiler] (main:) testProfiler() 
started
2015-11-03 12:09:48,089 INFO  [cloud.utils.TestProfiler] (main:) Duration in 
Millis: 1000
2015-11-03 12:09:48,089 INFO  [cloud.utils.TestProfiler] (main:) testProfiler() 
stopped
Configure log4j with default properties
Configure log4j with default properties
2015-11-03 12:09:49,111 INFO  [cloud.utils.TestProfiler] (main:) Duration in 
Nano: 1000130221
Configure log4j with default properties
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.046 sec - in 
com.cloud.utils.TestProfiler
Running com.cloud.utils.net.NetUtilsTest
2015-11-03 12:09:49,145 INFO  [utils.net.NetUtils] (main:) Invalid value of 
cidr 10.3.6.5/50
2015-11-03 12:09:49,152 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2015-11-03 12:09:49,153 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2015-11-03 12:09:49,155 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2015-11-03 12:09:49,156 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2015-11-03 12:09:49,157 INFO  

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-153302400
  
Test Result:

Test events table ... === TestName: test_01_verify_events_table | Status : 
SUCCESS ===
ok

--
Ran 1 test in 86.360s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/977#discussion_r43734254
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java
 ---
@@ -0,0 +1,108 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
+import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.apache.log4j.Logger;
+import org.libvirt.Connect;
+import org.libvirt.Domain;
+import org.libvirt.DomainSnapshot;
+import org.libvirt.LibvirtException;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.DeleteVMSnapshotAnswer;
+import com.cloud.agent.api.DeleteVMSnapshotCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.hypervisor.kvm.storage.KVMPhysicalDisk;
+import com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.storage.Volume;
+import com.cloud.utils.script.Script;
+
+@ResourceWrapper(handles =  DeleteVMSnapshotCommand.class)
+public final class LibvirtDeleteVMSnapshotCommandWrapper extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtDeleteVMSnapshotCommandWrapper.class);
+
+@Override
+public Answer execute(final DeleteVMSnapshotCommand cmd, final 
LibvirtComputingResource libvirtComputingResource) {
+String vmName = cmd.getVmName();
+
+final KVMStoragePoolManager storagePoolMgr = 
libvirtComputingResource.getStoragePoolMgr();
+Domain dm = null;
+try {
+final LibvirtUtilitiesHelper libvirtUtilitiesHelper = 
libvirtComputingResource.getLibvirtUtilitiesHelper();
+Connect conn = libvirtUtilitiesHelper.getConnection();
+dm = libvirtComputingResource.getDomain(conn, vmName);
+
+DomainSnapshot snapshot = null;
+try {
+snapshot = 
dm.snapshotLookupByName(cmd.getTarget().getSnapshotName());
+} catch (LibvirtException e) {
+s_logger.warn("Cannot find vmSnapshot with name: " + 
cmd.getTarget().getSnapshotName());
+return new DeleteVMSnapshotAnswer(cmd, cmd.getVolumeTOs());
+}
+
+snapshot.delete(0); // only remove this snapshot, not children
+
+return new DeleteVMSnapshotAnswer(cmd, cmd.getVolumeTOs());
+} catch (LibvirtException e) {
+String msg = " Delete VM snapshot failed due to " + 
e.toString();
+
+if (dm == null) {
+s_logger.debug("Can not find vm: " + vmName + ", delete 
the snapshot using qemu-img");
--- End diff --

Is this an action to be taken by the admin? The log line seems to suggest it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

[terbolous]

Github user terbolous commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934
  
LGTM, verified in the github preview that the output renders correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153330895
  
@bhaisaab @koushik-das Isn't there an annotation on field level for APIs as 
well? A change was accepted for that. I am looking for it and will update this 
comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9021 - Add right interface whe...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1026#issuecomment-153331810
  
2 LGTMs merging. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/977#discussion_r43734224
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java
 ---
@@ -0,0 +1,108 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
+import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.apache.log4j.Logger;
+import org.libvirt.Connect;
+import org.libvirt.Domain;
+import org.libvirt.DomainSnapshot;
+import org.libvirt.LibvirtException;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.DeleteVMSnapshotAnswer;
+import com.cloud.agent.api.DeleteVMSnapshotCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.hypervisor.kvm.storage.KVMPhysicalDisk;
+import com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.storage.Volume;
+import com.cloud.utils.script.Script;
+
+@ResourceWrapper(handles =  DeleteVMSnapshotCommand.class)
+public final class LibvirtDeleteVMSnapshotCommandWrapper extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtDeleteVMSnapshotCommandWrapper.class);
+
+@Override
+public Answer execute(final DeleteVMSnapshotCommand cmd, final 
LibvirtComputingResource libvirtComputingResource) {
+String vmName = cmd.getVmName();
+
+final KVMStoragePoolManager storagePoolMgr = 
libvirtComputingResource.getStoragePoolMgr();
+Domain dm = null;
+try {
+final LibvirtUtilitiesHelper libvirtUtilitiesHelper = 
libvirtComputingResource.getLibvirtUtilitiesHelper();
+Connect conn = libvirtUtilitiesHelper.getConnection();
+dm = libvirtComputingResource.getDomain(conn, vmName);
+
+DomainSnapshot snapshot = null;
+try {
+snapshot = 
dm.snapshotLookupByName(cmd.getTarget().getSnapshotName());
+} catch (LibvirtException e) {
+s_logger.warn("Cannot find vmSnapshot with name: " + 
cmd.getTarget().getSnapshotName());
+return new DeleteVMSnapshotAnswer(cmd, cmd.getVolumeTOs());
+}
+
+snapshot.delete(0); // only remove this snapshot, not children
+
+return new DeleteVMSnapshotAnswer(cmd, cmd.getVolumeTOs());
+} catch (LibvirtException e) {
+String msg = " Delete VM snapshot failed due to " + 
e.toString();
--- End diff --

Can't you move this down to where you actually throw the Answer back?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

[Wilder Rodrigues]

PR has been created. Could you please have a look?

https://github.com/apache/cloudstack/pull/1026

Cheers,
Wilder


On 03 Nov 2015, at 10:59, Wilder Rodrigues 
> wrote:

Thanks for the details, Sanjeev.

Fixing the test now. PR to follow.

Cheers,
Wilder

On 03 Nov 2015, at 10:26, Sanjeev N 
> wrote:

In case of VMWare and Hyper-v , linc local is on eth1. So the command in
all the failed tests to verify link local IP should be modified.
"cat /var/cache/cloud/cmdline | xargs | sed \"s/ /\\n/g\" | grep eth0ip= |
sed \"s/\=/ /g\" | awk '{print $2}'",.
It is using eth0ip. However, it should be eth1ip.

On Tue, Nov 3, 2015 at 12:25 PM, Wilder Rodrigues <
wrodrig...@schubergphilis.com> wrote:

Thanks , Raja!

Will fix it today!

Cheers,
Wilder

Sent from my iPhone

On 02 Nov 2015, at 14:11, Raja Pullela 
mailto:raja.pull...@citrix.com>>> wrote:

Hi wilder, missed your earlier email.. sorry,  here are the details.  Let
me know if you need any further details.  I believe for Hyperv/Vmware the
ips come from the pod cidr and the validation should be skipped.

Raja
Error Message

The cached Link Local should be the same as the current Link Local IP, but
they are different! Current ==> 10.71.153.33; Cached ==> 169.254.1.130
Logs available at 

Stacktrace

File "/usr/lib/python2.7/unittest/case.py", line 329, in run
  testMethod()
File "/root/cloudstack/test/integration/smoke/test_ssvm.py", line 518,
in test_03_ssvm_internals
  "The cached Link Local should be the same as the current Link Local
IP, but they are different! Current ==> %s; Cached ==> %s " %
(linklocal_ip, res)
File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
  assertion_func(first, second, msg=msg)
File "/usr/lib/python2.7/unittest/case.py", line 924, in
assertMultiLineEqual
  self.fail(self._formatMessage(msg, standardMsg))
File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
  raise self.failureException(msg)
'The cached Link Local should be the same as the current Link Local IP,
but they are different! Current ==> 10.71.153.33; Cached ==> 169.254.1.130
\n



From: Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>>>
Date: November 2, 2015 at 4:04:31 PM GMT+5:30
To: Rajani Karuturi 
>, Remi
Bergsma 
>,
Raja Pullela 
>,
dev@cloudstack.apache.org
 <
dev@cloudstack.apache.org>
Subject: Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8
tests in test_ssvm.py

Hi Raja,

We don't have vmware/hyperv test environment. Could you please print the
whole error message? I'm missing the bit that says:

Current ==> %s; Cached ==> %s

Without the full message I cannot look further into it.

Cheers,
Wilder



On 30 Oct 2015, at 17:03, Raja Pullela 
mailto:raja.pull...@citrix.com>>> wrote:

Hi Wilder

The changes from this commit are failing the HyperV and VMware BVTs.

Can you please let me know if these tests were passing in your
environment- VMware, Hyperv?

Raja

Error - "the cached link local should be same current local ip, but they
are different!"

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/950#issuecomment-153396280
  
@miguelaferreira Shame, though I understand ;). Just for reference; here it 
loads the mysql-connector-jar [0]. It is loaded before the main app because 
it's in the common.loader definition. The jar itself is installed because we 
require mysql-connector-java here [1]. And if you look at the RPM here [3] you 
can see it is actually installed there.

Don't know if you we're actually searching for that...

[0] 
https://github.com/apache/cloudstack/blob/master/packaging/centos7/tomcat7/catalina.properties#L47
[1] 
https://github.com/apache/cloudstack/blob/master/packaging/centos7/cloud.spec#L74
[2] 
http://mirror.centos.org/centos/7.1.1503/os/x86_64/Packages/mysql-connector-java-5.1.25-3.el7.noarch.rpm

Ping @remibergsma 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/950#issuecomment-153390623
  
@remibergsma @borisroman I'm closing this PR since I've been able to figure 
out how the mysql driver is being loaded in the RPM install. It happens that 
it's not enough to add the jar to tomcat's common class loader, nor the webapp 
class loader. For it to work the jar must be in the class path of tomcat 
itself. That is, the `CLASSPATH` variable in the environment that starts 
tomcat. In tomcat terminology that is the `System` loader 
(https://tomcat.apache.org/tomcat-7.0-doc/class-loader-howto.html)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

[miguelaferreira]

Github user miguelaferreira closed the pull request at:

https://github.com/apache/cloudstack/pull/950


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[NuxRo]

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-153439504
  
That would help,  I'm all for 100+ :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[resmo]

Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-153425811
  
agreed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-153430373
  
@NuxRo I can check this tomorrow, I think search box simply queries 
listVirtualMachines API which does not support filtering by passing an IP 
argument.

On a related note, I'm working on some UI changes to make it slightly 
better on how we find information in the UI such as sorting of table (columns), 
some new views and navigation methods to find resources that are having issues 
(like finding hosts which are down in a cluster, or finding storage pools that 
are full visually) which might be useful. So, you can do something like list 
all VMs and then sort by IP and then find it, or simply search using browser's 
text search option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[NuxRo]

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-153431622
  
@bhaisaab Thanks for that. The UI is indeed in need of attention.

The problem with listing the VMs is that the UI will only show a few, then 
as you scroll down it displays more and more. Terribly annoying!
If I would merely go on the Instances page I can use the ctrl+f in Firefox, 
but this will only work on the 20 or so VMs displayed.

For this reason I have a cloudmonkey script running from cronjob doing a 
list of all VMs together with all their information (NICs included) and 
spitting this in an HTML file, but it's a hack... :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-153437575
  
@NuxRo I did some pagesize and latency comparisons for one of the 
views/APIs (see: 
https://github.com/apache/cloudstack/pull/751#issuecomment-135661968); I think 
it's a general issue with expecting to have all the resources in the list but 
it's not possible to get all the resources as it could the UI for long or if 
the network timeouts (or errors out) you'll see nothing. The default pagesize 
in the UI is set to 20 the last time I checked, we can easily increase this to 
50 or 100 without much change in latency and UX.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/950#issuecomment-153468603
  
@borisroman That's what I thought, but no, the `common.loader` property (in 
[0] is not what does the trick). I've tried that too and that did not work, not 
because the jar isn't "loaded" by the JVM but because the driver class itself 
is not loaded into the memory area that holds classes.

Tomcat has 4 layers of class loaders: Bootstrap, System, Common and each 
webapp.

In the `catalina.properties` file there is a property called 
`common.loader` that defines which jars are available to tomcat's Common class 
loader. The fact that a jar is available to the class loader does not mean all 
classes it defines will be loaded. It only means that when a class is 
requested, the class loader will be able to search that jar. And, by the way, 
if a class is defined in multiple jars, only the first one that is found will 
be loaded.

**So, why is it that having the jar with the right driver class available, 
the DriverManager still doesn't find a suitable driver?**

It turns out that the DriverManager is not actively searching for all 
available drivers (as specified in the Java Docs [1]). It so happens that for 
the driver class to be available for the DriverManager, that class has to be 
explicitly loaded, either by an `import com.mysql.jdbc.Driver;` statement, or a 
`Class.forName("com.mysql.jdbc.Driver")` statement.
I've made a very simple webapp that asks the DriverManager for a JDBC MySQL 
connector, and even though the correct driver is sitting in a jar that is in 
the class path, the DriverManager still throws a "no suitable driver found" 
exception. To make that work, all we need is to add a line of code saying 
`Class.forName("com.mysql.jdbc.Driver");` right before asking for the 
connection. Adding that line proves the jar with the driver is correctly 
defined in the class path, and when requested the correct driver class is 
loaded by the JVM. 

What happens in CloudStack is that the mysql connector jar is not only 
searchable by the Common class loader (via `common.loader` in [0]), but it is 
also searchable by tomca's System class loader set in [2]. And that's the class 
loader that is actually loading the driver class. I'm not sure why, but my best 
guess is that when tomcat is booting, one of it's components (maybe tomcat-jdbc 
[3]) sweeps the available jars for any class implementing `java.sql.Driver` and 
actually finds the one we need.

So, if you want to drop a CloudStack WAR in a tomcat instance, make sure 
that the MySQL connector jar is the class path of the process that starts JVM.

Finally, just for documentation sake, @ke4qqq, if you even read this, 
please grep the codebase for `Class.forName("com.mysql.jdbc.Driver")`. You will 
find two files that contain that line, and those make the "runtime dependency" 
on a class licensed under GPL very explicit. I wonder how does that play out 
with Apache's policy?

[0] 
https://github.com/apache/cloudstack/blob/master/packaging/centos7/tomcat7/catalina.properties#L47
[1] http://docs.oracle.com/javase/7/docs/api/java/sql/DriverManager.html
[2] 
https://github.com/apache/cloudstack/blob/master/packaging/centos7/cloud-management.sysconfig#L48
[3] https://tomcat.apache.org/tomcat-7.0-doc/jdbc-pool.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Documentation errors Administrators Guide

[Ron Wheeler]

When I run Sphinx with
c:\python27\scripts\sphinx-build -a -E -v -w .\cloudstack\sphinx.log 
c:\users\ron\git\cloudstack-docs-admin\source .\cloudstack 
>./cloudstack/console.log

I get 55 Errors and Warnings.
Some of these seem to be real errors and some seem to be orphaned fragments.

Can/should these be cleaned up?
Are there document fragments that should be deleted or moved to a part 
of the project where they are not in the build?



c:\users\ron\git\cloudstack-docs-admin\source\networking\remote_access_vpn.rst:88: 
ERROR: Undefined substitution referenced: "vpn-icon.png".
c:\users\ron\git\cloudstack-docs-admin\source\networking\remote_access_vpn.rst:142: 
ERROR: Undefined substitution referenced: "vpn-icon.png".
c:/users/ron/git/cloudstack-docs-admin/source/networking/virtual_private_cloud_config.rst:572: 
WARNING: duplicate label source-nat-priv-gw, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\virtual_private_cloud_config.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/remote_access_vpn.rst:20: 
WARNING: duplicate label remote-access-vpn, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\remote_access_vpn.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/virtual_private_cloud_config.rst:1014: 
WARNING: duplicate label create-ext-lb-rule, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\virtual_private_cloud_config.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/external_firewalls_and_load_balancers.rst:253: 
WARNING: duplicate label adding-lb-rule, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\external_firewalls_and_load_balancers.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/virtual_private_cloud_config.rst:593: 
WARNING: duplicate label acl-priv-gw, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\virtual_private_cloud_config.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/virtual_private_cloud_config.rst:289: 
WARNING: duplicate label conf-net-acl, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\virtual_private_cloud_config.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/external_firewalls_and_load_balancers.rst:360: 
WARNING: duplicate label health-check, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\external_firewalls_and_load_balancers.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/global_server_load_balancing.rst:311: 
WARNING: duplicate label enabling-gslb-in-ns, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\global_server_load_balancing.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/virtual_private_cloud_config.rst:1159: 
WARNING: duplicate label creating-net-offering-internal-lb, other 
instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\virtual_private_cloud_config.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/virtual_private_cloud_config.rst:1218: 
WARNING: duplicate label create-int-lb-rule, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\virtual_private_cloud_config.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/external_firewalls_and_load_balancers.rst:400: 
WARNING: duplicate label conf-autoscale, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\external_firewalls_and_load_balancers.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/virtual_private_cloud_config.rst:487: 
WARNING: duplicate label adding-priv-gw-vpc, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\virtual_private_cloud_config.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/site_to_site_vpn.rst:4: 
WARNING: duplicate label setting-s2s-vpn-conn, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\site_to_site_vpn.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/global_server_load_balancing.rst:421: 
WARNING: duplicate label assigning-lb-rule-gslb, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\global_server_load_balancing.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/ip_forwarding_and_firewalling.rst:94: 
WARNING: duplicate label egress-fw-rules, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\ip_forwarding_and_firewalling.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/external_firewalls_and_load_balancers.rst:626: 
WARNING: duplicate label update-autoscale, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\external_firewalls_and_load_balancers.rst
c:/users/ron/git/cloudstack-docs-admin/source/networking/global_server_load_balancing.rst:377: 
WARNING: duplicate label adding-gslb-rule, other instance in 
c:\users\ron\git\cloudstack-docs-admin\source\networking\global_server_load_balancing.rst

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153468143
  
I agree with @remibergsma .
If the plugin is provided by the vendor, I would say they are responsible 
for the code maintenance and update.What we need to check are the changes in 
other projects (api,engine/schema,server,etc).
This PR LGTM +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

[NuxRo]

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1029#issuecomment-153467987
  
Excellent! I thought this feature was already implemented via 
expunge.delay, good to know it doesn't work as I thought it was.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153473377
  
@ustcweizhou @remibergsma this is a massive technical debt that we are 
carrying with other plugins, and I think we need to stop to expanding that 
debt.  In some cases, we (i.e. ASF) have been granted licenses for virtual 
appliances to test plugin operation (a completely valid way to verify 
operation).  For others, we are shipping code that has not been verified for a 
number of releases.  In the past, plugins have been contributed and tested for 
a release, but those contributors have not remained active to maintain the 
plugin.  Since the community lacks the equipment or test rigs, no one else can 
pick up maintenance -- leaving us with bit rotting code.  In summary, as a 
community, we should not be accepting the responsibility to support and 
maintain code whose operation we cannot verify -- plugin or core.  The question 
of what to do with existing plugins that don't meet this criteria is a 
discussion for another thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Documentation image sources are missing

[Ron Wheeler]

I can find the .png files but I can not find the sources for the images.
I have never heard of anyone editing png files directly.

Are the sources in another project?

Ron

--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: 4.6 status update

[Remi Bergsma]

FYI: once PR 1023 is merged (fixes final blocker) I'll create a 4.6 RC for us 
all to test. 

Had planned to do it tonight but there's one test failing and I want to be 100% 
sure it all works and all tests pass. To be resolved tomorrow. Almost there!

Regards, Remi 

Sent from my iPhone

> On 30 Oct 2015, at 18:01, Remi Bergsma  wrote:
> 
> Hi all,
>  
> The blocker mentioned below has been fixed. Its PR (1008) is almost ready to 
> be merged. In the mean while, Mike reported an issue, that is now our single 
> blocker. Waiting for more info on it.
> 
> Lots of PRs were merged, thanks to all that tested, reviewed or otherwise 
> helped out.
> 
> Could you all please pick a PR from the list below and review it?
> 
> We’re aiming for a RC early next week.
> 
> Thanks and have a great weekend!
> 
> Regards,
> Remi
> 
> 
> PRs for 4.6
> ===
> If you have PRs that should go into 4.6, please ping me or Rajani about it 
> and make sure the PR gets reviewed and tested. Looks like we're getting close 
> to RC so act now.
> 
> These are some PRs that fix bugs we want to consider. Please help testing and 
> reviewing:
> 
> CLOUDSTACK-8964: Ovm3HypervisorGuru wrong answer and snapshot to volume 
> implementation. #975
> https://github.com/apache/cloudstack/pull/975
> 
> CLOUDSTACk-9002: VM deployment is successful even when dhcp entry com… #995
> https://github.com/apache/cloudstack/pull/995
> 
> CLOUDSTACK-8940: Wrong value is inserted into nics table netmask fiel… #916
> https://github.com/apache/cloudstack/pull/916
> 
> Update L10N Web UI resource files before 4.6 RC1 (v2) #1001
> https://github.com/apache/cloudstack/pull/1001
> 
> 
> UI
> ===
> There is a bunch of rather small UI improvements we should consider. Please 
> help testing and reviewing:
> 
> CLOUDSTACK-8961: Changes related to the UI of VPN Users management. #941
> https://github.com/apache/cloudstack/pull/941
> 
> CLOUDSTACK-8976 - Sorting of security groups #937
> https://github.com/apache/cloudstack/pull/937
> 
> CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always 
> displayed rather than the IP corresponding to the NIC where LB is being 
> created #903
> https://github.com/apache/cloudstack/pull/903
> 
> CLOUDSTACK-8919: Slow UI response while loading the list of networks in 
> network tab. #897
> https://github.com/apache/cloudstack/pull/897
> 
> 
> 
> 
> 
> From: Remi Bergsma
> Date: Thursday 29 October 2015 09:28
> To: "dev@cloudstack.apache.org"
> Subject: 4.6 status update
> 
> Hi,
> 
> We’re down to a single blocker:
> 
> 1) CentOS 7 - systemd-tmpfiles - Operation not permitted
> This is about the CentOS 7 packaging of the Management Server.
> https://issues.apache.org/jira/browse/CLOUDSTACK-8812
> 
> 
> PRs for 4.6
> ===
> If you have PRs that should go into 4.6, please ping me or Rajani about it 
> and make sure the PR gets reviewed and tested. Looks like we're getting close 
> to RC so act now.
> 
> These are some PRs that fix bugs we want to consider. Please help testing and 
> reviewing:
> 
> CLOUDSTACK-8793 Enable s2s VPN connection for projects #879
> https://github.com/apache/cloudstack/pull/879
> 
> CLOUDSTACK-8964: Ovm3HypervisorGuru wrong answer and snapshot to volume 
> implementation. #975
> https://github.com/apache/cloudstack/pull/975
> 
> Rename xapi plugins for s3 and swift to make them work after renaming the 
> calls #982
> https://github.com/apache/cloudstack/pull/982
> 
> CLOUDSTACk-9002: VM deployment is successful even when dhcp entry com… #995
> https://github.com/apache/cloudstack/pull/995
> 
> CLOUDSTACK-8962: Dedicated cluster is used for virtual routers that belong to 
> non-dedicated account #945
> https://github.com/apache/cloudstack/pull/945
> 
> CLOUDSTACK-8940: Wrong value is inserted into nics table netmask fiel… #916
> https://github.com/apache/cloudstack/pull/916
> 
> Pass LbProtocol down to the HAProxyConfigurator #848
> https://github.com/apache/cloudstack/pull/848
> 
> Update L10N Web UI resource files before 4.6 RC1 (v2) #1001
> https://github.com/apache/cloudstack/pull/1001
> 
> 
> UI
> ===
> There is a bunch of rather small UI improvements we should consider. Please 
> help testing and reviewing:
> 
> 
> CLOUDSTACK-8929: The list of VMs that can be assigned to a load balancer rule 
> is not updated after a VM is assigned to it. #949
> https://github.com/apache/cloudstack/pull/949
> 
> CLOUDSTACK-8961: Changes related to the UI of VPN Users management. #941
> https://github.com/apache/cloudstack/pull/941
> 
> CLOUDSTACK-8976 - Sorting of security groups #937
> https://github.com/apache/cloudstack/pull/937
> 
> CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always 
> displayed rather than the IP corresponding to the NIC where LB is being 
> created #903
> https://github.com/apache/cloudstack/pull/903
> 
> CLOUDSTACK-8919: Slow UI response while loading the list of networks in 
> network 

Build failed in Jenkins: build-4.5 #535

[jenkins]

See 

Changes:

[Rohit Yadav] CLOUDSTACK-9019: Add storage network offering in ssvm only if 
storage network is defined

--
[...truncated 2618 lines...]
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Hypervisor UCS
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Hypervisor Hyper-V
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Network Elastic Load Balancer
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Network Internal Load Balancer
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Palo Alto
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Network Netscaler
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Network Nicira NVP
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - BigSwitch Virtual Network Segment
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Network Brocade VCS
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Stratosphere SSP
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - Network Opendaylight
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 
[INFO] Skipping Apache CloudStack Plugin - User Authenticator LDAP
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] 

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9019: Add storage networ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1025#issuecomment-153575105
  
Merging since #1024 is merged now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8958: add dedicated ips to dom...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1007#discussion_r43845446
  
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java 
---
@@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final 
DedicatePublicIpRangeCmd cmd) throws Res
 vlanOwner = 
_accountMgr.getAccount(project.getProjectAccountId());
 }
 
+Domain domain = null;
 if (accountName != null && domainId != null) {
 vlanOwner = _accountDao.findActiveAccount(accountName, 
domainId);
-}
-if (vlanOwner == null) {
-throw new InvalidParameterValueException("Unable to find 
account by name " + accountName);
-} else if (vlanOwner.getId() == Account.ACCOUNT_ID_SYSTEM) {
-throw new InvalidParameterValueException("Please specify a 
valid account. Cannot dedicate IP range to system account");
+if (vlanOwner == null) {
--- End diff --

vlanOwner check is now done only when account is specified. What about the 
project case which also can set the vlanOwner? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153596954
  
Hi @karuturi,

Sorry, perhaps too earlier here, but I don't follow completely. :)

How did you setup your environment in order to test the case you explained 
above? You mentioned that the rules were not there, and you had to set them up 
manually. However, in the next comment, you said that is might have been caused 
by restarting the network.

Did you run the tests in an isolated environment with a new built 
systemvm.iso?

I just want to understand how you got that scenario - no rules. Based on 
the new code and test, the only issue we got was the UDP/53 on the RVR.

If it was all caused by the network restart, then it's clear. And by the 
way, that is another issue and I will have a look at.

Thanks again for the tests.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1029#discussion_r43848708
  
--- Diff: server/src/com/cloud/configuration/Config.java ---
@@ -672,6 +672,7 @@
 "86400",
 "The interval (in seconds) to wait before running the storage 
cleanup thread.",
 null),
+StorageCleanupDelay("Advanced", StorageManager.class, Integer.class, 
"storage.cleanup.delay", "86400", "Determines how long (in seconds) to wait 
before actually expunging destroyed volumes. The default value = the default 
value of storage.cleanup.interval.", null),
--- End diff --

To make the configuration more readable, I will move all the 
storage-cleanup related configurations to Configurable interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/883#discussion_r43846616
  
--- Diff: scripts/vm/hypervisor/xenserver/logrotate ---
@@ -0,0 +1,29 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Version @VERSION@
+#
+# script to perform logrotation on xenserver 6.0.2 and later
+
+/usr/sbin/logrotate  /etc/logrotate.d/cloudlog
--- End diff --

@sspans  I think the files mentioned in the patch file are the only ones 
getting deployed to the xenserver. Of these I cloud find cloudlog is the only 
logrotate configuration file. 
Please let me know if I missed anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-153603199
  
@bhaisaab I think from the UI same value is passed for both name and 
display name. But if you use the API you can pass different values. The 'name' 
is set as hostname of the VM. But 'display name' is just a friendly name 
associated to the VM for easy reference.

I don't think it is a good idea to remove display name from the VM summary 
page. Or the fields to be displayed in the page should be made configurable. 
The user may choose what all fields to display in the summary page. The same 
can hold for the IP address as well.

Also about displaying the IP address I think @resmo raised some valid 
points. In advanced zone VMs in different isolated networks can have same 
private IP address. So not sure how it helps user/admin. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153613824
  
Thanks a lot, @karuturi !

I reproduce it and once fix write a new test to cover the fix.

Cheers,
WIlder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: simulator-4.5-singlerun #277

[jenkins]

See 

--
Started by upstream project "build-4.5-simulator" build number 331
originally caused by:
 Started by upstream project "build-4.5" build number 536
 originally caused by:
  Started by user Rajani Karuturi
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1258)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1759)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: error:  while accessing 
https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs

fatal: HTTP request failed

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to simulator(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy46.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
... 11 more
ERROR: Error fetching remote repo 'origin'
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
' for the 
testing framework 'JUnit'.  Did you enter a pattern relative to the correct 
directory?  Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the 
resolved pattern 'xunit.xml'. Configuration error?.
[xUnit] [INFO] - Failing BUILD.
[xUnit] 

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

[michaelandersen]

Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1028#issuecomment-153604321
  
changed the required_hardware tag to true and rebased to master and 
retested:
nosetests --with-marvin --marvin-config=../../../mct-zone1-kvm1.cfg -a 
tags=advanced,required_hardware=true  test_vpc_vpn.py

Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok

--
Ran 2 tests in 1056.887s

OK

nosetests --with-marvin --marvin-config=../../../mct-zone1-kvm1.cfg -a 
tags=advanced,required_hardware=false  test_vpc_vpn.py

--
Ran 0 tests in 0.000s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153605360
  
I upgraded an existing xenserver setup with the changes in this PR. (clear 
the tags on xenserver and restarted the networks to recreated VRs with new 
systemvm.iso) I also manually checked it has the latest configure.py file
(added details about setup on my first comment 
https://github.com/apache/cloudstack/pull/1023#issuecomment-153274765 )

In the default egress allow network, it has an existing egress rule to 
block port 22 and restarting it created a new router without egress chain.
when I deleted the rule and restarted network, it created new router with 
egress chain properly configured. 

to clear the confusion, I was able to reproduce it with the following steps
1. create a new network with default egress allow (network name: 
egress2_allow)
2. launch a vm in the network.
3. check that VR came up and running
4. ssh to VR and check the iptables. 
5. verified that iptables FW_EGRESS_RULES is present. 
6. test outgoing traffic from user vm created in this network. (ssh and 
ping were working fine)
7. create a egress rule to block port 22
8. verified that iptables drop rule is added in egress chain on VR
9. verified that ssh from user vm doesnt work
10. restart network and wait till a new VR  is created and running
11. observe that FW_EGRESS_RULES is missing in the iptables on the new VR
12. also, ping google.com and ssh doesnt work from user vm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1024#issuecomment-153374008
  
code looks good to me too. what happened to the policy of not accepting 
anything without test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153376651
  
The last test failed because the connection timed out without printing 
"Giving up.", as I expected in the test. You can see the output below:

```
{Cmd: wget -t 1 -T 1 www.google.com via Host: 192.168.23.6} {returns: 
[u'--2015-11-03 14:44:03--  http://www.google.com/', u'Resolving 
www.google.com... failed: Connection timed out.', u"wget: unable to resolve 
host address 'www.google.com'"]}
{Cmd: wget -t 1 -T 1 www.google.com via Host: 192.168.23.6} {returns: 
[u'--2015-11-03 14:44:03--  http://www.google.com/', u'Resolving 
www.google.com... failed: Connection timed out.', u"wget: unable to resolve 
host address 'www.google.com'"]}
{Cmd: wget -t 1 -T 1 www.google.com via Host: 192.168.23.6} {returns: 
[u'--2015-11-03 14:44:03--  http://www.google.com/', u'Resolving 
www.google.com... failed: Connection timed out.', u"wget: unable to resolve 
host address 'www.google.com'"]}
{Cmd: wget -t 1 -T 1 www.google.com via Host: 192.168.23.6} {returns: 
[u'--2015-11-03 14:44:03--  http://www.google.com/', u'Resolving 
www.google.com... failed: Connection timed out.', u"wget: unable to resolve 
host address 'www.google.com'"]}
```

I will push another time and will rely on a better test string. But no 
worries, the fix is fine!

* Test results:

```
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : FAILED ===
FAIL

==
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/component/test_routers_network_ops.py",
 line 473, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
"Attempt to retrieve google.com index page should NOT be successful"
AssertionError: Attempt to retrieve google.com index page should NOT be 
successful
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[KrisSterckx]

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153367941
  
@jburwell  @remibergsma  Pls note all again that the changes to core are 
very minimal and are limited to convenience extensions only. I would expect 
running the CI should be good in verifying that the plugin changes don't break 
anything in core.

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153369716
  
@KrisSterckx this plugin is part of the code that is the responsibility of 
the community.  Therefore, we need to verify its operation in addition to the 
core changes.  My understanding is that a virtual device is available for 
testing the plugin.  Is that correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-153371179
  
My bad, there is no libvirt-java upgrade possible at this point. I was 
mistaking libvirt 1.1.0 for a possibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153371614
  
@wilderrodrigues my bubble is very busy but ping if you are ready and need 
testing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1024#issuecomment-153371665
  
 :+1: (code review only) good improvement.
A test case would have been nice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153373615
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 31 tests in 15382.029s

OK
```


And:
 

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1029

CLOUDSTACK-9022: keep Destroyed volumes for sometime

for now, the Destroyed volumes will be expunged in Storage cleanup thread, 
no matter when they are destroyed.
In Expunging vm thread, we expunge the Destroyed vms which have been 
destroyed at least 'expunge.delay' seconds. We add the similar configuration 
for volumes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack storage-cleanup-delay

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1029.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1029


commit e411f00fdb49615e45f3e0f3fe709d97734d3db2
Author: Wei Zhou 
Date:   2015-11-03T16:04:55Z

CLOUDSTACK-9022: keep Destroyed volumes for sometime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153404172
  
The virtio console is a bridge between hypervisor and vm instance. I am not 
sure if customers feel good/friendly with this.

I donot know if libvirt-java 0.5.1 supports qemu guest agent. If yes, we 
can send commands/data directly from java. It is another way for implementation.
python script and java have their own benifits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

[ronatartifact]

Github user ronatartifact commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153356376
  
I considered using a link but was unsure about the policy of references 
to outside documents.

It creates a link that can be easily broken by the developers if they 
change the structure or location of the design docs without thinking 
that the official Docs have links.

That is why I used the title of the page and the reference by name to 
the 4.4 design docs.

If the information is relatively stable and worth knowing, perhaps a 
summary of the Administration implications could be included in a 
section in the Admin docs to eliminate the need for a link to an 
external source.

I am a bit too new and do not use the GPU (as near as I can tell at this 
point) to know where it should be included in the Admin docs and how 
much an Admin (as opposed to a developer) needs to know to add a GPU.

Ron


On 03/11/2015 7:28 AM, Pierrre-Luc Dion wrote:
>
> LGTM, formating is fine in the current sphinx theme.
>
> Having the link to the feature spec mention at line 305 would have 
> been a nice to have.
>
> Thanks for the PR!
>
> —
> Reply to this email directly or view it on GitHub 
> 
.
>


-- 
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Git with Eclipse

[Ron Wheeler]

Thanks for the feedback.
It is just a small change to see if I can get the process to work.
It is an attempt to clarify a section that I found a bit hard to 
understand so I hope that it does make that section easier to read for 
the next person.


There is a lot more information in the 4.4 Design Docs which includes 
changes made in the 4.5 release which is a bit confusing.
I am not sure how important this stuff is and wonder if some of the 
material about GPUs needs to be included in the Admin documentation as a 
statement of how they work in the current version rather than asking 
people to search through all of the design notes to find out how GPUs 
are handled .


Ron

On 03/11/2015 4:36 AM, Daan Hoogland wrote:

never mind: https://github.com/apache/cloudstack-docs-admin/pull/31/files

looked in the wrong repo

On Tue, Nov 3, 2015 at 10:34 AM, Daan Hoogland 
wrote:


Ron, can you link us to your PR? there is 118 open at the moment and I
don't see your name with the last bunch.

On Mon, Nov 2, 2015 at 10:59 PM, Ron Wheeler <
rwhee...@artifact-software.com> wrote:


Due to Sebastien and Daan's help, I have been able to create a pull
request for a small change to the docs.
https://wiki.eclipse.org/EGit/User_Guide#Working_with_remote_Repositories
was also a great help.
It took me a few attempts to get a push to my github repo working but it
finally worked.

Eclipse/STS is pretty good for editing docs since it has an ReST editor
that provides an outline for documents.
I would like to have a Maven plug-in for Sphinx but I am not sure about
everyone else so it might be tricky to integrate it into my workflow
without affecting the master on git.

If anyone has a chance to look at the pull request and let me know if I
got it right, that would be reassuring.

Ron





On 30/10/2015 5:58 AM, Sebastien Goasguen wrote:


Ron,

I don’t know how to use Github with eclipse, I use the command line for
everything.

But the documentation should be good:

https://github.com/apache/cloudstack-docs-admin#contributing-to-the-documentation

Basically you need an account on GitHub.
You fork https://github.com/apache/cloudstack-docs-admin (or the other
docs repo).
You will then have a fork at https://github.com/
/cloudstack-docs-admin

Clone your own fork:

$ git clone https://github.com//cloudstack-docs-admin

Make your commits via eclipse and push to your own fork.

Then on the GitHub UI, create a pull request to the upstream repo:
https://github.com/apache/cloudstack-docs-admin

-sebastien

On Oct 29, 2015, at 9:58 PM, Ron Wheeler 

wrote:

Trying to help out with the docs without doing too much damage.
I am new to git.

I am using Eclipse with the egit/mylyn plug-in and I have managed to
get the source for the docs-admin downloaded.

The "Configure Fetch" has a Source Ref of "refs/heads/*" and a
Desctination Ref  of "refs/remotes/origin/*"
I think that I have the right sources. They seem to match the published
docs.

I have made my changes and think that I need to create a pull request
to get one of the Cloudstack gods to decide if my attempts are worthy.

I have created the pull request in Eclipse but when I try to submit it
I get an error box titled "Submit failed" popping up with the rather
cryptic "Unexpected error: Invalid request. "base", "head" weren't
supplied".
I think that I have to configure the "Remotes/origin/
https://gethub.com/apache/cloudstack-doc-admin.git; entry  using
"Configure Push" menu.

It has a section called "Ref mappings" that I gather is how git figures
out how I want my changes mapped back into the remote repos.

Am I looking in the right places?
If so, what are the right "Source Ref" and "Destination Ref" entries to
get a pull request that will please the gods (both local and remote).

It looks like editing and creating pull requests gets easy once this is
working.

Still have to work on getting the document production working so I can
actually see the fruits of my labour.

Thanks

Ron


*
*

--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102




--
Daan







--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102