date:20151129

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1085#issuecomment-160442363
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 17069.659s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1085#issuecomment-160442447
  
Functionality also works:

```
(local) ï¿½ > list vlanipranges keyword=50
count = 1
vlaniprange:
id = abdc0be9-6869-438b-9b10-16061bd0bdcb
account = system
domain = ROOT
domainid = 6984f247-9676-11e5-b0bf-5254001daa61
endip = 192.168.23.50
forvirtualnetwork = True
gateway = 192.168.23.1
netmask = 255.255.255.0
networkid = 754d5656-5d0f-4c24-92cd-088ffefd7234
physicalnetworkid = 84ad2f6a-1bb6-4bc7-9631-05eb16b66c4d
startip = 192.168.23.2
vlan = vlan://50
zoneid = 5204d4ca-7452-4899-88ca-9bf700bbdcc1
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread DaanHoogland

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1134#issuecomment-160444699
  
@pdube, no, there is a page on cleaning up the API but as the semantic 
version scheme commands we should only do that cleaning up per version 5.0. see 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/API+changes
My preference is keeping related calls in one service and not have a Query 
service, or use it as a backend for the API command


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread pdube

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1134#issuecomment-160447903
  
@DaanHoogland I was talking about the implementation of APIs. Example, 
let's say you create a new module, call it Exampe. So we can list, create and 
delete Example. What are the classes that we expect someone to create? 
ExampleService, ExampleDoa, ExampleVO, etc.? That is what I was refering to. 
That way, if we decide that the best way to write modules is to have a service 
that is self contained, then we can phase out the use of the QueryService


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1116#issuecomment-160442050
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 15802.447s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1085


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

What SDN are you using?

2015-11-29 Thread Nux!

Hello,

So besides the folks using Nicira, can anyone recommend any other SDN thing or 
should I stay with v(x)lans?
I'm kind of removed from this side of things since my deployments tend to be 
with Security Grups in a single or few VLANs, any suggestions welcome, 
preferably free/foss.

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1087#issuecomment-160431621
  
LGTM, tested on CentOS7:

Logrotate is there:

```
[root@cs1 x86_64]# cat /etc/logrotate.d/cloudstack-catalina 
/var/log/cloudstack/management/catalina.out {
copytruncate
daily
rotate 14
compress
missingok
create 0644 cloud cloud
}
```

And this folder is missing (expected):
```
ls -la /var/log/cloudstack-management/
ls: cannot access /var/log/cloudstack-management/: No such file or directory
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1087#issuecomment-160431637
  
@PaulAngus please respond to the comment by @jburwell. After that we can 
merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1132#issuecomment-160443626
  
@bhaisaab Let's find someone else who can review this..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread pdube

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1134#issuecomment-160441642
  
@DaanHoogland I did not find a guide to do it. I looked at the patterns I 
found in other modules, and imitated those. I found it confusing because there 
were a few different ways to do it. I really don't mind moving it back into the 
service. As a side question, why not move it into the AffinityGroupDao? (if 
not, what is the Dao for?) Is there a definitive guide for writing APIs? If 
there is not a definitive guide, then maybe we should write one to help with 
the evolution of the APIs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1116


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update L10N resource files with 4.6 strin...

2015-11-29 Thread milamberspace

GitHub user milamberspace opened a pull request:

https://github.com/apache/cloudstack/pull/1138

Update L10N resource files with 4.6 strings from Transifex (20151129)

Small update of L10N files before the 4.6.1 release candidate

cc @remibergsma 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milamberspace/cloudstack 
L10N-update-4.6-20151129

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1138


commit 6d4722953f859c537aadd2a0b4b5f3553f33dc69
Author: Milamber <milam...@apache.org>
Date:   2015-11-29T19:01:56Z

Update L10N resource files with 4.6 strings from Transifex (20151129)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: What SDN are you using?

2015-11-29 Thread Simon Weller

Nux,

The two most deployed SDN solutions are Vmware NSX-MH (Nicara) and Nuage VSP 
(Alcatel-Lucent).  Neither are cheap!
We've been evaluating whether we're going to run a POC on Nuage, as it does 
have some very cool features including service chaining.
Most of the other SDN plugins within CS are either very alpha, or haven't 
received any updates in quite a while. 
I polled the dev list list a few months back and it didn't appear anyone on the 
lists were running (or willing to talk about) Big Switch, Midonet or 
Stratosphere. I know someone built the start of a plugin for Open Daylight, but 
it hasn't seen any development since then. We even reached out to Midonet, 
offering to pay for support and they told us to install Openstack ;-)

We have the native KVM VXLAN implementation running in our lab and it seems to 
work very well. We went 100% 10/40GB using open platform switches and Cumulus 
linux.

Our main interest in SDN is to provide more advanced traffic steering and 
security features later.

- Si






From: Nux! 
Sent: Sunday, November 29, 2015 12:56 PM
To: Cloudstack Users List
Cc: dev
Subject: What SDN are you using?

Hello,

So besides the folks using Nicira, can anyone recommend any other SDN thing or 
should I stay with v(x)lans?
I'm kind of removed from this side of things since my deployments tend to be 
with Security Grups in a single or few VLANs, any suggestions welcome, 
preferably free/foss.

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

Re: DevCloud deployment

2015-11-29 Thread Илья Толстихин

Hi all,

I found exception message in xcp-xapi.log

[20151124T09:22:36.680Z|debug|devcloud|460 INET 127.0.0.1:80|host.call_plugin
R:0bff3a505aba|dispatcher] Server_helpers.exec exception_handler: Got
exception XENAPI_PLUGIN_FAILURE: [ non-zero exit; ; Traceback (most recent
call last):
  File "/usr/lib/xcp/plugins/vmops", line 39, in 
import cloudstack_pluginlib as lib
  File "/etc/xapi.d/plugins/cloudstack_pluginlib.py", line 24, in 
import simplejson as json
ImportError: No module named simplejson
 ]


I added sys.path.append("/etc/xapi.d/plugins/") into
/usr/lib/xcp/plugins/vmops and installed simplejson.
Exception disappeared, but there was an error of another kind.

This is fragment of xcp-xapi.log

Do you have idea, what could be wrong?

2015-11-18 9:39 GMT+06:00 Abhinandan Prateek <
abhinandan.prat...@shapeblue.com>:

>
> The wiki below is much more elaborate on cloudstack setup using virtual
> box, and good for anyone wishing to be a cloudstack developer.
> http://www.shapeblue.com/virtualbox-test-env/
>
>
>
> On 17/11/15, 2:17 PM, "Илья Толстихин"  wrote:
>
> >I copied vhd-util from /usr/bin/ on devcloud to
> >scripts/vm/hypervisor/xenserver of cloudstack.
> >Nothing changed.
> >
> >Also I tried to setup with manuals
> >
> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md
> >
> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/advanced/README.md
> >
> >That gives the same error.
> >Do you have any other ideas, what could be the reason?
> >
> >2015-11-16 17:14 GMT+06:00 Илья Толстихин :
> >
> >> Thanks.
> >>
> >> 2015-11-16 10:28 GMT+06:00 Rajani Karuturi :
> >>
> >>> I find it easier to use devcloud4[1]. It the easiest way for xen6.2
> >>> devcloud setup.
> >>> The documentation is also good. Just install the required tools/IP
> configs
> >>> mentioned in README [2]. Then, go to the advanced and follow the
> readme[3]
> >>> there for a advanced zone setup.
> >>>
> >>> [1] https://github.com/apache/cloudstack/tree/master/tools/devcloud4
> >>> [2]
> >>>
> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md
> >>> [3]
> >>>
> >>>
> https://github.com/apache/cloudstack/blob/master/tools/devcloud4/advanced/README.md
> >>>
> >>> ~Rajani
> >>>
> >>> On Fri, Nov 13, 2015 at 12:52 PM, Daan Hoogland <
> daan.hoogl...@gmail.com>
> >>> wrote:
> >>>
> >>> > From your log it seems the host can be reached but doesn't respond s
> >>> > expected. First guess :wrong version of vhd-utils?
> >>> >
> >>> > Sorry for the late reaction. Stuck in traffic
> >>> >
> >>> > Biligual auto correct use.  Read at your own risico
> >>> > Op 12-nov.-2015 10:28 schreef "Илья Толстихин" :
> >>> >
> >>> > > This is fragment of vmops.log file of MS.
> >>> > >
> >>> > > 2015-11-12 0:49 GMT+06:00 Daan Hoogland :
> >>> > >
> >>> > >> Ilya, Can you share the log of your management server? There must
> be
> >>> > some
> >>> > >> more info in there. And maybe you can check SRLog on the host To
> see
> >>> if
> >>> > >> anything happened there at all.
> >>> > >>
> >>> > >> On Wed, Nov 11, 2015 at 6:43 PM, Илья Толстихин <
> inosi...@gmail.com>
> >>> > >> wrote:
> >>> > >>
> >>> > >> > Yes, this is Xen.
> >>> > >> >
> >>> > >> > 2015-11-11 22:00 GMT+06:00 Daan Hoogland <
> daan.hoogl...@gmail.com
> >>> >:
> >>> > >> >
> >>> > >> > > this is a xen host, right?
> >>> > >> > >
> >>> > >> > > On Wed, Nov 11, 2015 at 3:43 PM, Илья Толстихин <
> >>> inosi...@gmail.com
> >>> > >
> >>> > >> > > wrote:
> >>> > >> > >
> >>> > >> > > > On host ssh is up with 22 port only.
> >>> > >> > > >
> >>> > >> > > > 2015-11-11 20:03 GMT+06:00 Илья Толстихин <
> inosi...@gmail.com
> >>> >:
> >>> > >> > > >
> >>> > >> > > > > Cloudstack 4.6.0
> >>> > >> > > > > Yes, I can ssh to host
> >>> > >> > > > >
> >>> > >> > > > > 2015-11-11 19:41 GMT+06:00 Daan Hoogland <
> >>> > daan.hoogl...@gmail.com
> >>> > >> >:
> >>> > >> > > > >
> >>> > >> > > > >> what version of ACS?
> >>> > >> > > > >> It sounds like a network issue between ms and host? can
> you
> >>> ssh
> >>> > >> from
> >>> > >> > > ms
> >>> > >> > > > to
> >>> > >> > > > >> host on the right port? (i think it was 3922, might be
> 3022)
> >>> > >> > > > >>
> >>> > >> > > > >> On Wed, Nov 11, 2015 at 1:42 PM, Илья Толстихин <
> >>> > >> inosi...@gmail.com
> >>> > >> > >
> >>> > >> > > > >> wrote:
> >>> > >> > > > >>
> >>> > >> > > > >> > Hi all,
> >>> > >> > > > >> > Could you please help with the DevCloud deployment.
> >>> > >> > > > >> >
> >>> > >> > > > >> > I imported devcloud into virtualbox, in settings
> *enabled
> >>> > PAE*
> >>> > >> and
> >>> > >> > > > >> > created *host-only
> >>> > >> > > > >> > network 192.168.56.1/24 *
> >>> > >> > > > >> > Devcloud is pinged now.
> >>> > >> > > > >> >
> >>> > >> > > > >> > I built and run cloudstack on my local machine with
> >>> commands
> >>> > >> > > > >> > *mvn

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread DaanHoogland

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1134#issuecomment-160417989
  
Did a quick review and it looks great. One general remark; Let's keep 
interface as orthogonal as possible, i.e. use 'list' as the prefix for search 
functions and have a service implement it's own list method. @pdube you 
probably found some guide somewhere that made you do this differently. can you 
tell me where? The reason I want this is to be able to contain resource editing 
in a single widget using as little services as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6 to master

2015-11-29 Thread DaanHoogland

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1136#issuecomment-160418520
  
@bhaisaab you should not have merged #1119 as it is also in 4.6. This merge 
commit was wrong because of this isse and should have been fixed before 
merging. Now the same thing is doen in two different commits. the idea is that 
you always merge forward so you can always track the branches a change is in. 
Squashing??? we don't go back to the mess we were in are we?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6 to master

2015-11-29 Thread DaanHoogland

Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/1136


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1121#issuecomment-160390678
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 17559.991s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread remibergsma

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1134#discussion_r46088753
  
--- Diff: test/integration/component/test_affinity_groups_projects.py ---
@@ -0,0 +1,1083 @@
+#!/usr/bin/env python
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+# 
+#http://www.apache.org/licenses/LICENSE-2.0
+# 
+#  Unless required by applicable law or agreed to in writing,
+#  software distributed under the License is distributed on an
+#  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+#  KIND, either express or implied.  See the License for the
+#  specific language governing permissions and limitations
+#  under the License.
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.cloudstackAPI import deleteAffinityGroup
+from marvin.lib.utils import (cleanup_resources,
+random_gen)
+from marvin.lib.base import (Account,
+Project,
+ServiceOffering,
+VirtualMachine,
+AffinityGroup,
+Domain)
+from marvin.lib.common import (get_zone,
+ get_domain,
+ get_template,
+ list_hosts,
+ list_virtual_machines,
+ wait_for_cleanup)
+from nose.plugins.attrib import attr
+
+class Services:
+"""Test Account Services
+"""
+
+def __init__(self):
+   self.services = {
+  "domain": {
+ "name": "NonRootDomain"
+  },
+  "domain_admin_account": {
+ "email": "newt...@test.com",
+ "firstname": "Test",
+ "lastname": "User",
+ "username": "doadmintest",
+ "password": "password"
+  },
+  "account": {
+ "email": "newt...@test.com",
+ "firstname": "Test",
+ "lastname": "User",
+ "username": "acc",
+ "password": "password"
+  },
+  "account_not_in_project": {
+ "email": "newt...@test.com",
+ "firstname": "Test",
+ "lastname": "User",
+ "username": "account_not_in_project",
+ "password": "password"
+  },
+  "project": {
+ "name": "Project",
+ "displaytext": "Project"
+  },
+  "project2": {
+ "name": "Project2",
+ "displaytext": "Project2"
+  },
+  "service_offering": {
+ "name": "Tiny Instance",
+ "displaytext": "Tiny Instance",
+ "cpunumber": 1,
+ "cpuspeed": 100,
+ "memory": 64
+  },
+  "ostype": 'CentOS 5.3 (64-bit)',
+  "host_anti_affinity": {
+"name": "",
+"type": "host anti-affinity"
+ },
+  "virtual_machine" : {
+ "hypervisor" : "KVM"
--- End diff --

@pdube Even better, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6 to master

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1136#issuecomment-160390613
  
@bhaisaab The problem with your approach, to be honest, is that the commit 
ID changed. As this was a bit of a special case it may not be a problem. 
General speaking, the forward merging approach is the better one as it allows 
for tracking back the commit ids to all branches a commit is in.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1121#issuecomment-160390932
  
Pinging @DaanHoogland @borisroman to do second review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Forgotten license added

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1137


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1105


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

2015-11-29 Thread wido

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1121#discussion_r46089169
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -419,7 +419,7 @@ public String toString() {
 
 public static class DiskDef {
 public enum DeviceType {
-FLOPPY("floppy"), DISK("disk"), CDROM("cdrom");
+FLOPPY("floppy"), DISK("disk"), CDROM("cdrom"), LUN("lun");
--- End diff --

So why is the LUN type added here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9081 Migration of vm across cl...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1118#issuecomment-160390779
  
LGTM based on these tests (although I didn't test the actual change).

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 17430.478s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \

[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6 to master

2015-11-29 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1136#issuecomment-160391011
  
@remibergsma I used the git pr tool so not sure how the commit ID changed, 
I merged the other PR because 4.6 merge on master chose the other change while 
merge conflict resolution which did not solve the regression fixed in 4.6.

Fwd-merging is fine, but the way we're merging Github PRs it's difficult to 
track changes even using --no-merges with git log. IMO the git log history is 
practically unreadable or followable, along with the fact that we don't squash 
merge changes for each github PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1094#issuecomment-160391354
  
@miguelaferreira @wilderrodrigues Can one of you review this? Once done, I 
can run the integration tests again.Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

2015-11-29 Thread remibergsma

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1007#discussion_r46089078
  
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java 
---
@@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final 
DedicatePublicIpRangeCmd cmd) throws Res
 vlanOwner = 
_accountMgr.getAccount(project.getProjectAccountId());
 }
 
+Domain domain = null;
 if (accountName != null && domainId != null) {
 vlanOwner = _accountDao.findActiveAccount(accountName, 
domainId);
-}
-if (vlanOwner == null) {
-throw new InvalidParameterValueException("Unable to find 
account by name " + accountName);
-} else if (vlanOwner.getId() == Account.ACCOUNT_ID_SYSTEM) {
-throw new InvalidParameterValueException("Please specify a 
valid account. Cannot dedicate IP range to system account");
+if (vlanOwner == null) {
--- End diff --

Looks like the project case is handled by 
89ce8bd9e289327f411790eb05a9fb49ef1f9a2f. Since all tests pass, I will merge 
this now. Future adjustments can be made in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1007


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

2015-11-29 Thread bhaisaab

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1121#discussion_r46089189
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -761,6 +766,10 @@ public String toString() {
 }
 diskBuilder.append("/>\n");
 
+if (_serial != null && !_serial.isEmpty() && _deviceType != 
DeviceType.LUN) {
--- End diff --

@wido see, we use the device type here to avoid adding the disk/volume 
serial if the device type is LUN


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

2015-11-29 Thread bhaisaab

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1121#discussion_r46089183
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -419,7 +419,7 @@ public String toString() {
 
 public static class DiskDef {
 public enum DeviceType {
-FLOPPY("floppy"), DISK("disk"), CDROM("cdrom");
+FLOPPY("floppy"), DISK("disk"), CDROM("cdrom"), LUN("lun");
--- End diff --

SCSI block devices, LUN are not supported; the type was added to avoid 
possible bug in case we decide to support this storage/device type in future. 
See https://libvirt.org/formatdomain.html#elementsDisks for details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-jdk18 #413

2015-11-29 Thread jenkins

See 

Changes:

[w.zhou] CLOUDSTACK-8958: add dedicated ips to domain (account for now)

[w.zhou] CLOUDSTACK-8958: throw an exception if project account cannot be found

[Rajani Karuturi] CLOUDSTACK-9081 Migration of vm across clusters fails in 
clustered MS

[rafaelweingartner] Removal of DefaultUserAuthenticator empty class

[Daan Hoogland] rats

--
[...truncated 398 lines...]
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.049 sec - in 
com.cloud.utils.UuidUtilsTest
Running com.cloud.utils.crypto.RSAHelperTest
2015-11-29 09:09:45,735 INFO  [utils.crypt.RSAHelper] (main:) [ignored]error 
during public key encryption: Unsupported format
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.262 sec - in 
com.cloud.utils.crypto.RSAHelperTest
Running com.cloud.utils.crypto.EncryptionSecretKeyCheckerTest
2015-11-29 09:09:45,848 DEBUG [utils.crypt.EncryptionSecretKeyChecker] (main:) 
Encryption Type: null
2015-11-29 09:09:45,849 DEBUG [utils.crypt.EncryptionSecretKeyChecker] (main:) 
Encryption Type: file
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec - in 
com.cloud.utils.crypto.EncryptionSecretKeyCheckerTest
Running com.cloud.utils.PropertiesUtilsTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 sec - in 
com.cloud.utils.PropertiesUtilsTest
Running com.cloud.utils.exception.ExceptionUtilTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
com.cloud.utils.exception.ExceptionUtilTest
Running com.cloud.utils.storage.QCOW2UtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec - in 
com.cloud.utils.storage.QCOW2UtilsTest
Running com.cloud.utils.encoding.UrlEncoderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
com.cloud.utils.encoding.UrlEncoderTest
Running com.cloud.utils.UriUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.084 sec - in 
com.cloud.utils.UriUtilsTest
Running com.cloud.utils.HttpUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.093 sec - in 
com.cloud.utils.HttpUtilsTest
Running com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
2015-11-29 09:09:46,203 INFO  [backoff.impl.ConstantTimeBackoff] (Thread-1:) 
Thread Thread-1 interrupted while waiting for retry
2015-11-29 09:09:46,307 DEBUG [backoff.impl.ConstantTimeBackoffTest] (main:) 
thread started
2015-11-29 09:09:46,307 DEBUG [backoff.impl.ConstantTimeBackoffTest] 
(Thread-2:) before
2015-11-29 09:09:46,408 DEBUG [backoff.impl.ConstantTimeBackoffTest] (main:) 
testing wakeup
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.322 sec - in 
com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
Running com.cloud.utils.ProcessUtilTest
2015-11-29 09:09:46,412 INFO  [backoff.impl.ConstantTimeBackoff] (Thread-2:) 
Thread Thread-2 interrupted while waiting for retry
2015-11-29 09:09:46,412 DEBUG [backoff.impl.ConstantTimeBackoffTest] 
(Thread-2:) after
2015-11-29 09:09:46,415 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
2015-11-29 09:09:46,425 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
2015-11-29 09:09:46,426 DEBUG [cloud.utils.ProcessUtil] (main:) Executing: bash 
-c ps -p 123456 
2015-11-29 09:09:46,522 DEBUG [cloud.utils.ProcessUtil] (main:) Exit value is 1
2015-11-29 09:09:46,522 DEBUG [cloud.utils.ProcessUtil] (main:)   PID TTY   
   TIME CMD
2015-11-29 09:09:46,523 DEBUG [cloud.utils.ProcessUtil] (main:) Executing: bash 
-c echo $PPID 
2015-11-29 09:09:46,526 DEBUG [cloud.utils.ProcessUtil] (main:) Execution is 
successful.
2015-11-29 09:09:46,532 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.125 sec - in 
com.cloud.utils.ProcessUtilTest
Running com.cloud.utils.PasswordGeneratorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
com.cloud.utils.PasswordGeneratorTest
Running com.cloud.utils.rest.HttpUriRequestBuilderTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.07 sec - in 
com.cloud.utils.rest.HttpUriRequestBuilderTest
Running com.cloud.utils.rest.HttpStatusCodeHelperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
com.cloud.utils.rest.HttpStatusCodeHelperTest
Running com.cloud.utils.rest.RESTServiceConnectorTest
2015-11-29 09:09:46,855 DEBUG [utils.rest.RESTServiceConnector] (main:) 
Executing retrieve object on /somepath
2015-11-29 09:09:46,855 DEBUG [utils.rest.BasicRestClient] (main:) Executig GET 
request on https://localhost:443/somepath
2015-11-29 09:09:46,865 DEBUG [utils.rest.RESTServiceConnector] (main:) 
Executed request: GET /somepath HTTP/1.1 status was HTTP/1.1 200 OK
2015-11-29 09:09:46,866 DEBUG

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1135#issuecomment-160393076
  
FYI: @pdube I set all timers to 5 sec but that didn't result in a faster 
integration test run for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1132#issuecomment-160392997
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 16746.083s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \

[GitHub] cloudstack pull request: Forgotten license added

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1137#issuecomment-160390871
  
LGTM, just looked at the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9081 Migration of vm across cl...

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1118


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6 to master

2015-11-29 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1136#issuecomment-160391149
  
@bhaisaab The commit ID didn't change from the PR and your merge, that was 
fine. It was just different in 4.6 branch because the change was done combined 
with something else there. Never mind, it's fine this way and the end result is 
also great: 4.6 had an improved UI and 4.7 has that + metrics. Thanks!

I think we should discuss the squashing on the list. I'm fine, as long as 
we decide something and then live it. Let's not do it here ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

2015-11-29 Thread wido

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1121#discussion_r46089207
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -761,6 +766,10 @@ public String toString() {
 }
 diskBuilder.append("/>\n");
 
+if (_serial != null && !_serial.isEmpty() && _deviceType != 
DeviceType.LUN) {
--- End diff --

I see, but it is suddenly a new type of disk I haven't seen before in KVM. 
Hence my question.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread DaanHoogland

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1134#discussion_r46092314
  
--- Diff: api/src/org/apache/cloudstack/affinity/AffinityGroupService.java 
---
@@ -18,47 +18,36 @@
 
 import java.util.List;
 
+import 
org.apache.cloudstack.api.command.user.affinitygroup.CreateAffinityGroupCmd;
+
 import com.cloud.uservm.UserVm;
-import com.cloud.utils.Pair;
 
 public interface AffinityGroupService {
 
 /**
  * Creates an affinity/anti-affinity group for the given 
account/domain.
  *
- * @param account
+ * @param accountName
+ * @param projectId
  * @param domainId
- * @param name
- * @param type
+ * @param affinityGroupName
+ * @param affinityGroupType
  * @param description
  * @return AffinityGroup
  */
+AffinityGroup createAffinityGroup(String accountName, Long projectId, 
Long domainId, String affinityGroupName, String affinityGroupType, String 
description);
 
-AffinityGroup createAffinityGroup(String account, Long domainId, 
String affinityGroupName, String affinityGroupType, String description);
+AffinityGroup createAffinityGroup(CreateAffinityGroupCmd 
createAffinityGroupCmd);
 
 /**
  * Creates an affinity/anti-affinity group.
  *
  * @param affinityGroupId
- * @param account
- * @param domainId
- * @param affinityGroupName
- */
-boolean deleteAffinityGroup(Long affinityGroupId, String account, Long 
domainId, String affinityGroupName);
-
-/** Lists Affinity Groups in your account
- * @param account
+ * @param accountName
  * @param domainId
- * @param affinityGroupId
  * @param affinityGroupName
- * @param affinityGroupType
- * @param vmId
- * @param startIndex
- * @param pageSize
- * @return
  */
-Pair listAffinityGroups(Long 
affinityGroupId, String affinityGroupName, String affinityGroupType, Long vmId, 
Long startIndex,
--- End diff --

@pdube does it not make sense to list affinity groups?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread DaanHoogland

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1134#discussion_r46092351
  
--- Diff: api/src/org/apache/cloudstack/query/QueryService.java ---
@@ -131,9 +132,7 @@
 
 ListResponse listIsos(ListIsosCmd cmd);
 
-ListResponse listAffinityGroups(Long 
affinityGroupId, String affinityGroupName,
-String affinityGroupType, Long vmId, String accountName, Long 
domainId, boolean isRecursive,
-boolean listAll, Long startIndex, Long pageSize, String 
keyword);
+ListResponse 
searchForAffinityGroups(ListAffinityGroupsCmd cmd);
--- End diff --

I makes more sense to put this in the AffinityGroupService. (a list 
function)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread DaanHoogland

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1134#discussion_r46092380
  
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2406,98 +2406,10 @@ public void buildACLSearchCriteria(SearchCriteria sc
 }
 }
 
-//@Override
--- End diff --

:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...

2015-11-29 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1132#issuecomment-160514080
  
Thanks @remibergsma
Ping @sateesh-chodapuneedi  can you review this, and later if you want sent 
additional PRs with further changes etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

2015-11-29 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1121#issuecomment-160514198
  
Verifying this is simple, just check the  in the VM's virt xml 
(virsh edit domain, note the serial in the xml for the disk/volume) and ssh 
into the VM and check the hdd/vda serial (on debian based systemvm it was 
available at /sys/devices/pci:00::00:07.0/virtio4/block/vda/serial)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: What SDN are you using?

2015-11-29 Thread GoGoZoom PDX

Hm - Not a single mention of OpenvSwitch? I wonder why?...

Eric Pretorious
Portland, OR
On Nov 29, 2015 11:20 AM, "Simon Weller"  wrote:

> Nux,
>
> The two most deployed SDN solutions are Vmware NSX-MH (Nicara) and Nuage
> VSP (Alcatel-Lucent).  Neither are cheap!
> We've been evaluating whether we're going to run a POC on Nuage, as it
> does have some very cool features including service chaining.
> Most of the other SDN plugins within CS are either very alpha, or haven't
> received any updates in quite a while.
> I polled the dev list list a few months back and it didn't appear anyone
> on the lists were running (or willing to talk about) Big Switch, Midonet or
> Stratosphere. I know someone built the start of a plugin for Open Daylight,
> but it hasn't seen any development since then. We even reached out to
> Midonet, offering to pay for support and they told us to install Openstack
> ;-)
>
> We have the native KVM VXLAN implementation running in our lab and it
> seems to work very well. We went 100% 10/40GB using open platform switches
> and Cumulus linux.
>
> Our main interest in SDN is to provide more advanced traffic steering and
> security features later.
>
> - Si
>
>
>
>
>
> 
> From: Nux! 
> Sent: Sunday, November 29, 2015 12:56 PM
> To: Cloudstack Users List
> Cc: dev
> Subject: What SDN are you using?
>
> Hello,
>
> So besides the folks using Nicira, can anyone recommend any other SDN
> thing or should I stay with v(x)lans?
> I'm kind of removed from this side of things since my deployments tend to
> be with Security Grups in a single or few VLANs, any suggestions welcome,
> preferably free/foss.
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

2015-11-29 Thread maneesha-p

Github user maneesha-p commented on the pull request:

https://github.com/apache/cloudstack/pull/834#issuecomment-160512875
  
@remibergsma 2 LGTM s . Can this be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-11-29 Thread sanju1010

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1122#discussion_r46107622
  
--- Diff: test/integration/component/test_tags.py ---
@@ -2401,3 +2403,143 @@ def 
test_23_list_untagged_host_for_vm_migration(self):
 if not id in host_ids_for_migration:
 self.fail("Not all hosts are available for vm migration")
 return
+
+@attr(tags=["advanced"], required_hardware="false")
+def test_24_public_IP_tag(self):
+""" Testcreation, adding and removing tag on public IP address
+"""
+# Validate the following
+# 1. Create a domain and admin account under the new domain
+# 2. Create  a tag on acquired public IP address using createTags 
API
+# 3. Delete above created tag using deleteTags API
+# 4. Perform steps 3&4 using domain-admin
--- End diff --

Yes.
On Nov 29, 2015 11:31 PM, "Remi Bergsma"  wrote:

> In test/integration/component/test_tags.py
> :
>
> > @@ -2401,3 +2403,143 @@ def 
test_23_list_untagged_host_for_vm_migration(self):
> >  if not id in host_ids_for_migration:
> >  self.fail("Not all hosts are available for vm 
migration")
> >  return
> > +
> > +@attr(tags=["advanced"], required_hardware="false")
> > +def test_24_public_IP_tag(self):
> > +""" Testcreation, adding and removing tag on public IP address
> > +"""
> > +# Validate the following
> > +# 1. Create a domain and admin account under the new domain
> > +# 2. Create  a tag on acquired public IP address using 
createTags API
> > +# 3. Delete above created tag using deleteTags API
> > +# 4. Perform steps 3&4 using domain-admin
>
> Do you mean steps 2 & 3 here?
>
> â
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1117#issuecomment-160513890
  
Merging on 4.5, since the fix has been tested and merged on 4.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-29 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1115#issuecomment-160513845
  
@remibergsma cool, @abhinandanprateek can you close this; as the other PR 
has been merged on 4.6 and will be fwd-merged on master to get the fix on 
master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: simulator-4.5-singlerun #280

2015-11-29 Thread jenkins

See 

--
Started by upstream project "build-4.5-simulator" build number 334
originally caused by:
 Started by upstream project "build-4.5" build number 542
 originally caused by:
  Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:763)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1012)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1043)
at hudson.scm.SCM.checkout(SCM.java:485)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1738)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: error:  while accessing 
https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs

fatal: HTTP request failed

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1640)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1388)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:62)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:313)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to simulator(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:220)
at hudson.remoting.Channel.call(Channel.java:781)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor594.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy55.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:761)
... 11 more
ERROR: null
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
' for the 
testing framework 'JUnit'.  Did you enter a pattern relative to the correct 
directory?  Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the 
resolved pattern 'xunit.xml'. Configuration error?.
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] - There are errors when

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...

2015-11-29 Thread sateesh-chodapuneedi

Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/1132#issuecomment-160517214
  
@bhaisaab why are we merging the feature branch into a 4.6.* 
maintenance/minor release branch. Shouldn't it be merged into a major release 
branch/master?

BTW, this week I am working towards a PR against ACS master, for this 
feature branch along with tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

2015-11-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46113758
  
--- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ---
@@ -671,8 +672,19 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 vpcId, offering.getRedundantRouter());
 vo.setDisplayNetwork(isDisplayNetworkEnabled == 
null ? true : isDisplayNetworkEnabled);
 
vo.setStrechedL2Network(offering.getSupportsStrechedL2());
-networks.add(_networksDao.persist(vo, 
vo.getGuestType() == Network.GuestType.Isolated,
-
finalizeServicesAndProvidersForNetwork(offering, plan.getPhysicalNetworkId(;
+NetworkVO networkPersisted = 
_networksDao.persist(vo, vo.getGuestType() == Network.GuestType.Isolated,
+
finalizeServicesAndProvidersForNetwork(offering, plan.getPhysicalNetworkId()));
+networks.add(networkPersisted);
+
+if (predefined instanceof NetworkVO){
+try{
+NetworkGuruAdditionalFunctions functions = 
(NetworkGuruAdditionalFunctions) guru;
--- End diff --

This would best be protected with a `instanceof` check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46113707
  
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate) {
 if 
(com.cloud.dc.Vlan.UNTAGGED.equalsIgnoreCase(candidate)) {
 return Native.toUri(candidate);
 }
+if (UuidUtils.validateUUID(candidate)){
+//Supporting lswitch uuid as vlan id: set 
broadcast_uri = null and add row on nicira_nvp_router_map with 
logicalrouter_uuid = candidate
+return null;
--- End diff --

I've read the comment in the line above a few times, and still cannot 
understand the purpose of returning null on an invalid UUID (i.e. you 
previously caught a number format exception).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46113829
  
--- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ---
@@ -671,8 +672,19 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 vpcId, offering.getRedundantRouter());
 vo.setDisplayNetwork(isDisplayNetworkEnabled == 
null ? true : isDisplayNetworkEnabled);
 
vo.setStrechedL2Network(offering.getSupportsStrechedL2());
-networks.add(_networksDao.persist(vo, 
vo.getGuestType() == Network.GuestType.Isolated,
-
finalizeServicesAndProvidersForNetwork(offering, plan.getPhysicalNetworkId(;
+NetworkVO networkPersisted = 
_networksDao.persist(vo, vo.getGuestType() == Network.GuestType.Isolated,
+
finalizeServicesAndProvidersForNetwork(offering, plan.getPhysicalNetworkId()));
+networks.add(networkPersisted);
+
+if (predefined instanceof NetworkVO){
+try{
+NetworkGuruAdditionalFunctions functions = 
(NetworkGuruAdditionalFunctions) guru;
+
functions.finalizeNetworkDesign(networkPersisted.getId(), 
((NetworkVO)predefined).getVlanIdAsUUID());
+}
+catch (Exception e){
+//Couldn't cast to 
NetworkGuruAdditionalFunctions, continue
--- End diff --

The code should not catch exception because it is simply too broad.
Caught exceptions cannot be silently ignored (i.e. having an empty `catch` 
block).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114822
  
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -18,3 +18,5 @@
 --;
 -- Schema upgrade from 4.6.0 to 4.7.0;
 --;
+
+ALTER TABLE `cloud`.`nicira_nvp_router_map` DROP INDEX 
`logicalrouter_uuid` ;
--- End diff --

What's the purpose behind dropping the index?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-4787 - vmware diskcontro...

2015-11-29 Thread sateesh-chodapuneedi

Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/1131#issuecomment-160517089
  
@bhaisaab why are we merging the feature breanch into a 4.5.* 
maintenance/minor release branch. Shouldn't it be merged into a major release 
branch/master?

BTW, this week I am working towards a PR against ACS master, for this 
feature branch along with tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

2015-11-29 Thread harikrishna-patnala

Github user harikrishna-patnala commented on the pull request:

https://github.com/apache/cloudstack/pull/1139#issuecomment-160531359
  
Looks good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

2015-11-29 Thread DaanHoogland

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/834#issuecomment-160537225
  
@maneesha-p Probably not cleanly anymore. I'll give it a shot. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114230
  
--- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ---
@@ -671,8 +672,19 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 vpcId, offering.getRedundantRouter());
 vo.setDisplayNetwork(isDisplayNetworkEnabled == 
null ? true : isDisplayNetworkEnabled);
 
vo.setStrechedL2Network(offering.getSupportsStrechedL2());
-networks.add(_networksDao.persist(vo, 
vo.getGuestType() == Network.GuestType.Isolated,
-
finalizeServicesAndProvidersForNetwork(offering, plan.getPhysicalNetworkId(;
+NetworkVO networkPersisted = 
_networksDao.persist(vo, vo.getGuestType() == Network.GuestType.Isolated,
--- End diff --

This block adds more code to an already oversized method. This would best 
be extracted as a new method or even a new object. This way it would be easier 
to read and unit-test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114716
  
--- Diff: 
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java
 ---
@@ -0,0 +1,110 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.network.resource.wrapper;
+
+import static com.cloud.network.resource.NiciraNvpResource.NAME_MAX_LEN;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.ConfigureSharedNetworkUuidAnswer;
+import com.cloud.agent.api.ConfigureSharedNetworkUuidCommand;
+import com.cloud.network.nicira.LogicalRouterPort;
+import com.cloud.network.nicira.LogicalSwitchPort;
+import com.cloud.network.nicira.NiciraNvpApi;
+import com.cloud.network.nicira.NiciraNvpApiException;
+import com.cloud.network.nicira.NiciraNvpTag;
+import com.cloud.network.nicira.PatchAttachment;
+import com.cloud.network.resource.NiciraNvpResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+
+@ResourceWrapper(handles =  ConfigureSharedNetworkUuidCommand.class)
+public final class NiciraNvpConfigureSharedNetworkUuidCommandWrapper 
extends CommandWrapper{
+
+private static final Logger s_logger = 
Logger.getLogger(NiciraNvpConfigureSharedNetworkUuidCommandWrapper.class);
+
+@Override
+public Answer execute(ConfigureSharedNetworkUuidCommand command, 
NiciraNvpResource niciraNvpResource) {
+final String logicalRouterUuid = command.getLogicalRouterUuid();
+final String logicalSwitchUuid = command.getLogicalSwitchUuid();
+final String portIpAddress = command.getPortIpAddress();
+final List tags = new ArrayList();
+tags.add(new NiciraNvpTag("cs_account", command.getOwnerName()));
+final long networkId = command.getNetworkId();
+
+final NiciraNvpApi niciraNvpApi = 
niciraNvpResource.getNiciraNvpApi();
+
+s_logger.debug("Attaching Logical Switch " + logicalSwitchUuid + " 
on Logical Router " + logicalRouterUuid + " for Shared Network" + networkId);
+
+//Stored for rollback
+LogicalRouterPort lrpi = null;
+LogicalSwitchPort lsp = null;
+try {
+// Create the inside port for the router
+lrpi = new LogicalRouterPort();
+lrpi.setAdminStatusEnabled(true);
+lrpi.setDisplayName(niciraNvpResource.truncate(networkId + 
"-shared-att-port", NAME_MAX_LEN));
+lrpi.setTags(tags);
+final List ipAddresses = new ArrayList();
+ipAddresses.add(portIpAddress);
+lrpi.setIpAddresses(ipAddresses);
+lrpi = niciraNvpApi.createLogicalRouterPort(logicalRouterUuid, 
lrpi);
+
+try {
+// Create the inside port on the lswitch
+lsp = new 
LogicalSwitchPort(niciraNvpResource.truncate(networkId + "-shared-att-port", 
NAME_MAX_LEN), tags, true);
+lsp = 
niciraNvpApi.createLogicalSwitchPort(logicalSwitchUuid, lsp);
+
+// Attach the inside router port to the lswitch port with 
a PatchAttachment
+
niciraNvpApi.updateLogicalRouterPortAttachment(logicalRouterUuid, 
lrpi.getUuid(), new PatchAttachment(lsp.getUuid()));
+
+// Attach the inside lswitch port to the router with a 
PatchAttachment
+
niciraNvpApi.updateLogicalSwitchPortAttachment(logicalSwitchUuid, 
lsp.getUuid(), new PatchAttachment(lrpi.getUuid()));
+}
+catch (final NiciraNvpApiException e){
+try {
+

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114722
  
--- Diff: 
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper.java
 ---
@@ -0,0 +1,93 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.network.resource.wrapper;
+
+import static com.cloud.network.resource.NiciraNvpResource.NAME_MAX_LEN;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.ConfigureSharedNetworkVlanIdAnswer;
+import com.cloud.agent.api.ConfigureSharedNetworkVlanIdCommand;
+import com.cloud.network.nicira.L2GatewayAttachment;
+import com.cloud.network.nicira.LogicalSwitchPort;
+import com.cloud.network.nicira.NiciraNvpApi;
+import com.cloud.network.nicira.NiciraNvpApiException;
+import com.cloud.network.nicira.NiciraNvpTag;
+import com.cloud.network.resource.NiciraNvpResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+
+@ResourceWrapper(handles =  ConfigureSharedNetworkVlanIdCommand.class)
+public class NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper extends 
CommandWrapper{
+
+private static final Logger s_logger = 
Logger.getLogger(NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper.class);
+
+@Override
+public Answer execute(ConfigureSharedNetworkVlanIdCommand command, 
NiciraNvpResource niciraNvpResource) {
+final String logicalSwitchUuid = command.getLogicalSwitchUuid();
+final String l2GatewayServiceUuid = 
command.getL2GatewayServiceUuid();
+long vlanId = command.getVlanId();
+final List tags = new ArrayList();
+tags.add(new NiciraNvpTag("cs_account", command.getOwnerName()));
+final long networkId = command.getNetworkId();
+
+s_logger.debug("Connecting Logical Switch " + logicalSwitchUuid + 
" to L2 Gateway Service " + l2GatewayServiceUuid + ", vlan id " + vlanId + " 
network " + networkId);
+final NiciraNvpApi niciraNvpApi = 
niciraNvpResource.getNiciraNvpApi();
+
+LogicalSwitchPort lsp = null;
+try {
+// Create the outside port for the router
+lsp = new LogicalSwitchPort();
+lsp.setAdminStatusEnabled(true);
+lsp.setDisplayName(niciraNvpResource.truncate(networkId + 
"-l2Gateway-port", NAME_MAX_LEN));
+lsp.setTags(tags);
+lsp = niciraNvpApi.createLogicalSwitchPort(logicalSwitchUuid, 
lsp);
+
+try {
+// Attach the outside port to the gateway service on the 
correct VLAN
+final L2GatewayAttachment attachment = new 
L2GatewayAttachment(l2GatewayServiceUuid);
+if (command.getVlanId() != 0) {
+attachment.setVlanId(command.getVlanId());
+}
+
niciraNvpApi.updateLogicalSwitchPortAttachment(logicalSwitchUuid, 
lsp.getUuid(), attachment);
+}
+catch (NiciraNvpApiException e){
+try {
+
niciraNvpApi.deleteLogicalSwitchPort(logicalSwitchUuid, lsp.getUuid());
+} catch (NiciraNvpApiException e1) {
--- End diff --

Caught exceptions should at least be logged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114748
  
--- Diff: 
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper.java
 ---
@@ -0,0 +1,93 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.network.resource.wrapper;
+
+import static com.cloud.network.resource.NiciraNvpResource.NAME_MAX_LEN;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.ConfigureSharedNetworkVlanIdAnswer;
+import com.cloud.agent.api.ConfigureSharedNetworkVlanIdCommand;
+import com.cloud.network.nicira.L2GatewayAttachment;
+import com.cloud.network.nicira.LogicalSwitchPort;
+import com.cloud.network.nicira.NiciraNvpApi;
+import com.cloud.network.nicira.NiciraNvpApiException;
+import com.cloud.network.nicira.NiciraNvpTag;
+import com.cloud.network.resource.NiciraNvpResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+
+@ResourceWrapper(handles =  ConfigureSharedNetworkVlanIdCommand.class)
+public class NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper extends 
CommandWrapper{
+
+private static final Logger s_logger = 
Logger.getLogger(NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper.class);
+
+@Override
+public Answer execute(ConfigureSharedNetworkVlanIdCommand command, 
NiciraNvpResource niciraNvpResource) {
+final String logicalSwitchUuid = command.getLogicalSwitchUuid();
+final String l2GatewayServiceUuid = 
command.getL2GatewayServiceUuid();
+long vlanId = command.getVlanId();
+final List tags = new ArrayList();
+tags.add(new NiciraNvpTag("cs_account", command.getOwnerName()));
+final long networkId = command.getNetworkId();
+
+s_logger.debug("Connecting Logical Switch " + logicalSwitchUuid + 
" to L2 Gateway Service " + l2GatewayServiceUuid + ", vlan id " + vlanId + " 
network " + networkId);
+final NiciraNvpApi niciraNvpApi = 
niciraNvpResource.getNiciraNvpApi();
+
+LogicalSwitchPort lsp = null;
+try {
+// Create the outside port for the router
+lsp = new LogicalSwitchPort();
+lsp.setAdminStatusEnabled(true);
+lsp.setDisplayName(niciraNvpResource.truncate(networkId + 
"-l2Gateway-port", NAME_MAX_LEN));
+lsp.setTags(tags);
+lsp = niciraNvpApi.createLogicalSwitchPort(logicalSwitchUuid, 
lsp);
+
+try {
+// Attach the outside port to the gateway service on the 
correct VLAN
+final L2GatewayAttachment attachment = new 
L2GatewayAttachment(l2GatewayServiceUuid);
+if (command.getVlanId() != 0) {
+attachment.setVlanId(command.getVlanId());
+}
+
niciraNvpApi.updateLogicalSwitchPortAttachment(logicalSwitchUuid, 
lsp.getUuid(), attachment);
+}
+catch (NiciraNvpApiException e){
+try {
+
niciraNvpApi.deleteLogicalSwitchPort(logicalSwitchUuid, lsp.getUuid());
+} catch (NiciraNvpApiException e1) {
+}
+throw e;
+}
+}
+catch (NiciraNvpApiException e){
+try {
+throw e;
--- End diff --

You except an exception when throwing an exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46115019
  
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -18,3 +18,5 @@
 --;
 -- Schema upgrade from 4.6.0 to 4.7.0;
 --;
+
+ALTER TABLE `cloud`.`nicira_nvp_router_map` DROP INDEX 
`logicalrouter_uuid` ;
--- End diff --

This is about not being unique anymore, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

2015-11-29 Thread karuturi

GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/1139

CLOUDSTACK-9092: L10n fix in "Add LDAP Account page"

fixed two strings on the "Add LDAP Account page"

After the change: (with a test string in messages_ja_JP.properties file)
![screen shot 2015-11-30 at 11 07 42 
am](https://cloud.githubusercontent.com/assets/186833/11464468/213f0f4e-9755-11e5-85b3-1cc6a89895c1.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-9092

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1139


commit d6af6adbad707ab378098decca47d8f5e4012872
Author: Rajani Karuturi 
Date:   2015-11-30T05:51:17Z

CLOUDSTACK-9092: L10n fix in "Add LDAP Account page"

fixed two strings on the "Add LDAP Account page"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

2015-11-29 Thread harikrishna-patnala

GitHub user harikrishna-patnala opened a pull request:

https://github.com/apache/cloudstack/pull/1140

CLOUDSTACK-9094: Multiple threads are being used to collect the statsâ¦

CLOUDSTACK-9094: Multiple threads are being used to collect the stats from 
the same VR

Same thread is being intialised by two managers, 
VirtualNetworkApplianceManager and VpcVirtualNetworkApplianceManager

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/harikrishna-patnala/cloudstack CLOUDSTACK-9094

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1140


commit c9cc2ccd6dd69bc267ded6e654ec7167a330b6df
Author: Harikrishna Patnala 
Date:   2015-11-30T06:44:15Z

CLOUDSTACK-9094: Multiple threads are being used to collect the stats from 
the same VR

Same thread is being intialised by two managers, 
VirtualNetworkApplianceManager and VpcVirtualNetworkApplianceManager




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114035
  
--- Diff: 
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru;
+
+import java.util.Map;
+
+public interface NetworkGuruAdditionalFunctions {
--- End diff --

Several problems with this interface. An interface called functions seems 
like it is meant o `patch up` another interface that is lacking functionality. 
Secondly, it looks very much NSX specific while the name and package seem quite 
generic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114312
  
--- Diff: 
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java
 ---
@@ -239,8 +244,51 @@ public boolean implement(Network network, 
NetworkOffering offering, DeployDestin
  * multiple operations that should be done only once.
  */
 
-// Implement SourceNat immediately as we have al the info already
-if 
(networkModel.isProviderSupportServiceInNetwork(network.getId(), 
Service.SourceNat, Provider.NiciraNvp)) {
+if (network.getGuestType().equals(GuestType.Shared)){
--- End diff --

This block (and the next) add to an already large method. It would be best 
to refactor it to new methods (or a new object altogether).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114646
  
--- Diff: 
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/guru/NiciraNvpGuestNetworkGuru.java
 ---
@@ -102,11 +112,11 @@ public NiciraNvpGuestNetworkGuru() {
 @Override
 protected boolean canHandle(final NetworkOffering offering, final 
NetworkType networkType, final PhysicalNetwork physicalNetwork) {
 // This guru handles only Guest Isolated network that supports 
Source nat service
-if (networkType == NetworkType.Advanced && 
isMyTrafficType(offering.getTrafficType()) && offering.getGuestType() == 
Network.GuestType.Isolated
+if (networkType == NetworkType.Advanced && 
isMyTrafficType(offering.getTrafficType())
+&& (offering.getGuestType() == Network.GuestType.Isolated 
|| offering.getGuestType() == Network.GuestType.Shared)
--- End diff --

Is this check really needed? I mean `Isolated` and `Shared` are the [only 
two types of guest 
networks](https://github.com/apache/cloudstack/blob/95ae7963d5652595d62d6ace39de2eec9670413c/api/src/com/cloud/network/Network.java#L41).
If you would like to keep the check for sake of being future proof (that 
is, new guest types being added), then refactoring it to a method with a 
meaningful name (e.g. supportedGuestTypes(...)) would help readability.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114701
  
--- Diff: 
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java
 ---
@@ -0,0 +1,110 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.network.resource.wrapper;
+
+import static com.cloud.network.resource.NiciraNvpResource.NAME_MAX_LEN;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.ConfigureSharedNetworkUuidAnswer;
+import com.cloud.agent.api.ConfigureSharedNetworkUuidCommand;
+import com.cloud.network.nicira.LogicalRouterPort;
+import com.cloud.network.nicira.LogicalSwitchPort;
+import com.cloud.network.nicira.NiciraNvpApi;
+import com.cloud.network.nicira.NiciraNvpApiException;
+import com.cloud.network.nicira.NiciraNvpTag;
+import com.cloud.network.nicira.PatchAttachment;
+import com.cloud.network.resource.NiciraNvpResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+
+@ResourceWrapper(handles =  ConfigureSharedNetworkUuidCommand.class)
+public final class NiciraNvpConfigureSharedNetworkUuidCommandWrapper 
extends CommandWrapper{
+
+private static final Logger s_logger = 
Logger.getLogger(NiciraNvpConfigureSharedNetworkUuidCommandWrapper.class);
+
+@Override
+public Answer execute(ConfigureSharedNetworkUuidCommand command, 
NiciraNvpResource niciraNvpResource) {
+final String logicalRouterUuid = command.getLogicalRouterUuid();
+final String logicalSwitchUuid = command.getLogicalSwitchUuid();
+final String portIpAddress = command.getPortIpAddress();
+final List tags = new ArrayList();
+tags.add(new NiciraNvpTag("cs_account", command.getOwnerName()));
+final long networkId = command.getNetworkId();
+
+final NiciraNvpApi niciraNvpApi = 
niciraNvpResource.getNiciraNvpApi();
+
+s_logger.debug("Attaching Logical Switch " + logicalSwitchUuid + " 
on Logical Router " + logicalRouterUuid + " for Shared Network" + networkId);
+
+//Stored for rollback
+LogicalRouterPort lrpi = null;
+LogicalSwitchPort lsp = null;
+try {
+// Create the inside port for the router
+lrpi = new LogicalRouterPort();
+lrpi.setAdminStatusEnabled(true);
+lrpi.setDisplayName(niciraNvpResource.truncate(networkId + 
"-shared-att-port", NAME_MAX_LEN));
+lrpi.setTags(tags);
+final List ipAddresses = new ArrayList();
+ipAddresses.add(portIpAddress);
+lrpi.setIpAddresses(ipAddresses);
+lrpi = niciraNvpApi.createLogicalRouterPort(logicalRouterUuid, 
lrpi);
+
+try {
+// Create the inside port on the lswitch
+lsp = new 
LogicalSwitchPort(niciraNvpResource.truncate(networkId + "-shared-att-port", 
NAME_MAX_LEN), tags, true);
+lsp = 
niciraNvpApi.createLogicalSwitchPort(logicalSwitchUuid, lsp);
+
+// Attach the inside router port to the lswitch port with 
a PatchAttachment
+
niciraNvpApi.updateLogicalRouterPortAttachment(logicalRouterUuid, 
lrpi.getUuid(), new PatchAttachment(lsp.getUuid()));
+
+// Attach the inside lswitch port to the router with a 
PatchAttachment
+
niciraNvpApi.updateLogicalSwitchPortAttachment(logicalSwitchUuid, 
lsp.getUuid(), new PatchAttachment(lrpi.getUuid()));
+}
+catch (final NiciraNvpApiException e){
+try {
+

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1094#issuecomment-160545614
  
@nvazquez I've just read through you code and I made some comments that I 
would be happy to discuss with you.

Nice to see effort being put in unit testing the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-29 Thread DaanHoogland

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1134#issuecomment-160532869
  
Yes, I understand and it makes sense to have that documented. It doesn't 
have to mean we phase out QueryService. This makes sense to be there for people 
with read-only access and it can be used by other services. It also makes sense 
to consider if Example is a final type of resource or a generic (or 
implementation of a generic type of resource). A service would be for the whole 
family, would it?

btw @pdube none of my remarks should be interpreted as a -1 to your PR! I 
like big very much this ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114108
  
--- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java ---
@@ -102,6 +102,14 @@
 @Param(description = "Id of the vm to which the nic belongs")
 private String vmId;
 
+@SerializedName("nsxlogicalswitch")
+@Param(description = "Id of the NSX Logical Switch (if NSX based), 
null otherwise", since="4.6.0")
+private String nsxlogicalswitch;
--- End diff --

variable naming convention not being followed here. It should be 
`nsxLogicalSwitch`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114122
  
--- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java ---
@@ -102,6 +102,14 @@
 @Param(description = "Id of the vm to which the nic belongs")
 private String vmId;
 
+@SerializedName("nsxlogicalswitch")
+@Param(description = "Id of the NSX Logical Switch (if NSX based), 
null otherwise", since="4.6.0")
+private String nsxlogicalswitch;
+
+@SerializedName("nsxlogicalswitchport")
+@Param(description = "Id of the NSX Logical Switch Port (if NSX 
based), null otherwise", since="4.6.0")
+private String nsxlogicalswitchport;
--- End diff --

variable naming convention not being followed here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46114825
  
--- Diff: setup/db/db/schema-461to470.sql ---
@@ -18,3 +18,5 @@
 --;
 -- Schema upgrade from 4.6.1 to 4.7.0;
 --;
+
+ALTER TABLE `cloud`.`nicira_nvp_router_map` DROP INDEX 
`logicalrouter_uuid` ;
--- End diff --

What's the purpose behind dropping the index?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-11-29 Thread miguelaferreira

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1094#discussion_r46115024
  
--- Diff: setup/db/db/schema-461to470.sql ---
@@ -18,3 +18,5 @@
 --;
 -- Schema upgrade from 4.6.1 to 4.7.0;
 --;
+
+ALTER TABLE `cloud`.`nicira_nvp_router_map` DROP INDEX 
`logicalrouter_uuid` ;
--- End diff --

This is about not being unique anymore, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-11-29 Thread remibergsma

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1122#discussion_r46095649
  
--- Diff: test/integration/component/test_tags.py ---
@@ -2401,3 +2403,143 @@ def 
test_23_list_untagged_host_for_vm_migration(self):
 if not id in host_ids_for_migration:
 self.fail("Not all hosts are available for vm migration")
 return
+
+@attr(tags=["advanced"], required_hardware="false")
+def test_24_public_IP_tag(self):
+""" Testcreation, adding and removing tag on public IP address
+"""
+# Validate the following
+# 1. Create a domain and admin account under the new domain
+# 2. Create  a tag on acquired public IP address using createTags 
API
+# 3. Delete above created tag using deleteTags API
+# 4. Perform steps 3&4 using domain-admin
--- End diff --

Do you mean steps 2 & 3 here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6.1] [4.7] CLOUDSTACK-9022: keep Destr...

2015-11-29 Thread ustcweizhou

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1029#issuecomment-160467601
  
@remibergsma  rebased with latest master. 
There is a conflict with 4.6 because of commit 
1a64c247adbeb326f7ddbe6e4feaf3159e9e740d


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

80 matches

Mail list logo