Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

[Daan Hoogland]

Rohit, First of all good catch. I think we need to remove the 460to470 step
and have the path always pass by 4.6.1. Are you busy with this change
already?

On Fri, Dec 4, 2015 at 6:03 AM, Rohit Yadav 
wrote:

> There seems to be a db view related change between 4.6.0 and 4.6.1 (DB)
> versions; and there exists separate DB upgrade paths from 4.6.0 to 4.7.0
> and 4.6.1 to 4.7.0 on master branch which shares the same changes. The
> issue is that the upgrade path from 4.6.0 to 4.7.0 does not include the db
> view related changes that exists in the 4.6.0 to 4.6.1 upgrade path.
>
> While unlikely, but please share if this was done on purpose (i.e. we
> don’t want that db view related change if some user is upgrading from 4.6.0
> to 4.7.0), in which case it’s a non-issue.
>
> I’ll try to send a PR that *ought* to be merged on master before we freeze
> master (for 4.7.0) or cut a RC, but if I’m unable to do so today — someone
> please help fix this, and also refactor code (since there is a lot of
> common code), and don’t proceed without fixing this issue.
>
> Thanks.
>
> Rohit Yadav
> *Software Architect*
>
>
>
>
>
>
>
> * S: +44 20 3603 0540 <+442036030540> | M: +91 88 262 30892
> <+447770745036>  rohit.ya...@shapeblue.com
>  | www.shapeblue.com
>  | Twitter:@ShapeBlue
>  ShapeBlue Ltd, 53 Chandos Place, Covent
> Garden, London, WC2N 4HS *
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> 
> CSForge – rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Software Engineering
> 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>



-- 
Daan

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/1173

4.6.0 upgrade path is to pass 4.6.1 to create the extra view in there

test build done only

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack 4.7.0-upgrade-path

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1173


commit 3de117c8beafdfb9b602606715dc0694303b8f36
Author: Daan Hoogland 
Date:   2015-12-04T09:06:19Z

4.6.0 upgrade path is to pass 4.6.1 to create the extra view in there




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

[koushik-das]

GitHub user koushik-das opened a pull request:

https://github.com/apache/cloudstack/pull/1172

CLOUDSTACK-9107: Description of global config agent.load.threshold an…

…d the actual behavior are not in sync

Made configuration parameter description and behavior in sync.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/koushik-das/cloudstack CLOUDSTACK-9107

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1172


commit 04c44894b961cede7a917bcc78b153a0fc8ffd46
Author: Koushik Das 
Date:   2015-12-04T08:38:56Z

CLOUDSTACK-9107: Description of global config agent.load.threshold and the 
actual behavior are not in sync
Made configuration parameter description and behavior in sync.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

[Daan Hoogland]

I gave it a quick shot. A test build is running and I'll create the pr in a
minute.

On Fri, Dec 4, 2015 at 9:51 AM, Rohit Yadav 
wrote:

> Hi Daan, I’m testing quota but can work on it in 1-2 hours. So, not
> started yet but if you got time go ahead, and later I can help review/merge
> your PR.
>
> Regards.
>
> On 04-Dec-2015, at 2:15 PM, Daan Hoogland  wrote:
>
> Rohit, First of all good catch. I think we need to remove the 460to470 step
> and have the path always pass by 4.6.1. Are you busy with this change
> already?
>
> On Fri, Dec 4, 2015 at 6:03 AM, Rohit Yadav 
> wrote:
>
> There seems to be a db view related change between 4.6.0 and 4.6.1 (DB)
> versions; and there exists separate DB upgrade paths from 4.6.0 to 4.7.0
> and 4.6.1 to 4.7.0 on master branch which shares the same changes. The
> issue is that the upgrade path from 4.6.0 to 4.7.0 does not include the db
> view related changes that exists in the 4.6.0 to 4.6.1 upgrade path.
>
> While unlikely, but please share if this was done on purpose (i.e. we
> don’t want that db view related change if some user is upgrading from 4.6.0
> to 4.7.0), in which case it’s a non-issue.
>
> I’ll try to send a PR that *ought* to be merged on master before we freeze
> master (for 4.7.0) or cut a RC, but if I’m unable to do so today — someone
> please help fix this, and also refactor code (since there is a lot of
> common code), and don’t proceed without fixing this issue.
>
> Thanks.
>
> Rohit Yadav
> *Software Architect*
>
>
>
>
>
>
>
> * S: +44 20 3603 0540 <+442036030540> | M: +91 88 262 30892
> <+447770745036>  rohit.ya...@shapeblue.com
>  | www.shapeblue.com
>  | Twitter:@ShapeBlue
>  ShapeBlue Ltd, 53 Chandos Place, Covent
> Garden, London, WC2N 4HS *
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> 
> CSForge – rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Software Engineering
> 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>
>
>
>
> --
> Daan
>
>
> Rohit Yadav
> *Software Architect*
>
>
>
>
>
>
>
>
>
> * S: +44 20 3603 0540 <+442036030540> | M: +91 88 262 30892
> <+447770745036>  rohit.ya...@shapeblue.com
>  | www.shapeblue.com
>  | Twitter:@ShapeBlue
>  ShapeBlue Ltd, 53 Chandos Place, Covent
> Garden, London, WC2N 4HS *
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> 
> CSForge – rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Software Engineering
> 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company 

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1171

[4.6/master] rate-limit: increase JVM memory and enable fork mode for unit 
tests

Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to fix intermittent Jenkins failures
which look like:


multipleClientsCanAccessWithoutBlocking(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
unable to create new native thread

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.6-rate-limit-testfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1171


commit dcc66651c0a5f53fcd9395139dad147b4ac1ea09
Author: Rohit Yadav 
Date:   2015-12-04T08:17:03Z

rate-limit: increase JVM memory and enable fork mode for unit tests

Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to fix intermittent Jenkins failures
which look like:


multipleClientsCanAccessWithoutBlocking(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
unable to create new native thread

(cherry picked from commit 421bc00cd6005d9e8484c6df46a3b84ff466afd2)
Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.5] rate-limit: increase JVM memory and...

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1170

[4.5] rate-limit: increase JVM memory and enable fork mode for unit tests

Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to fix intermittent Jenkins failures
which look like:


multipleClientsCanAccessWithoutBlocking(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
unable to create new native thread

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.5-rate-limit-testfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1170


commit 421bc00cd6005d9e8484c6df46a3b84ff466afd2
Author: Rohit Yadav 
Date:   2015-12-04T08:17:03Z

rate-limit: increase JVM memory and enable fork mode for unit tests

Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to fix intermittent Jenkins failures
which look like:


multipleClientsCanAccessWithoutBlocking(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
unable to create new native thread

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

[Rohit Yadav]

Hi Daan, I’m testing quota but can work on it in 1-2 hours. So, not started yet 
but if you got time go ahead, and later I can help review/merge your PR.

Regards.

On 04-Dec-2015, at 2:15 PM, Daan Hoogland 
> wrote:

Rohit, First of all good catch. I think we need to remove the 460to470 step
and have the path always pass by 4.6.1. Are you busy with this change
already?

On Fri, Dec 4, 2015 at 6:03 AM, Rohit Yadav 
>
wrote:

There seems to be a db view related change between 4.6.0 and 4.6.1 (DB)
versions; and there exists separate DB upgrade paths from 4.6.0 to 4.7.0
and 4.6.1 to 4.7.0 on master branch which shares the same changes. The
issue is that the upgrade path from 4.6.0 to 4.7.0 does not include the db
view related changes that exists in the 4.6.0 to 4.6.1 upgrade path.

While unlikely, but please share if this was done on purpose (i.e. we
don’t want that db view related change if some user is upgrading from 4.6.0
to 4.7.0), in which case it’s a non-issue.

I’ll try to send a PR that *ought* to be merged on master before we freeze
master (for 4.7.0) or cut a RC, but if I’m unable to do so today — someone
please help fix this, and also refactor code (since there is a lot of
common code), and don’t proceed without fixing this issue.

Thanks.

Rohit Yadav
*Software Architect*







* S: +44 20 3603 0540 <+442036030540> | M: +91 88 262 30892
<+447770745036>  rohit.ya...@shapeblue.com
> | 
www.shapeblue.com
 | Twitter:@ShapeBlue
 ShapeBlue Ltd, 53 Chandos Place, Covent
Garden, London, WC2N 4HS *

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build

CSForge – rapid IaaS deployment framework 
CloudStack Consulting 
CloudStack Software Engineering

CloudStack Infrastructure Support

CloudStack Bootcamp Training Courses


This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the author and do not necessarily
represent those of Shape Blue Ltd or related companies. If you are not the
intended recipient of this email, you must neither take any action based
upon its contents, nor copy or show it to anyone. Please contact the sender
if you believe you have received this email in error. Shape Blue Ltd is a
company incorporated in England & Wales. ShapeBlue Services India LLP is a
company incorporated in India and is operated under license from Shape Blue
Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
a company registered by The Republic of South Africa and is traded under
license from Shape Blue Ltd. ShapeBlue is a registered trademark.




--
Daan

Rohit Yadav
Software Architect

[cid:image003.png@01D122E8.F6EFE910]



S: +44 20 3603 0540 | M: +91 88 262 30892

rohit.ya...@shapeblue.com | 
www.shapeblue.com | 
Twitter:@ShapeBlue

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue 

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/855#issuecomment-161918331
  
@rafaelweingartner @alexandrelimassantana Did you test whether the console 
proxy is still in there?
@anshul1886 Do you or any of your colleagues have the oportunity to test 
this in a hyperv environment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1171#issuecomment-161920716
  
@bhaisaab How can I help testing this? Also, your branch mentions 4.6 but 
the PR is made against master branch. Is that correct? Just checking ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/969#issuecomment-161920931
  
LGTM, will start  a regression suite


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[anshul1886]

GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/1176

CLOUDSTACK-9025: Fixed can't create usable template from snapshot in 
Xenserver and Vmware

https://issues.apache.org/jira/browse/CLOUDSTACK-9025

Fix also reverts below commit as below solution making assumption about 
hypervisor which are not applicable in case of XenServer and VmWare

Revert "CLOUDSTACK-8964: Can't create template or volume from snapshot"

This reverts commit ccf5d75cfbe769b34c021ab3653ed318cae25933.

Testing:

Able to deploy VM successfully from template created from linked clone 
snapshot on XenServer.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9025-4.6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1176


commit f8790c3b9e822062bcdce88f62f57884bfc4
Author: Anshul Gangwar 
Date:   2015-12-04T09:20:01Z

CLOUDSTACK-9025: Fixed can't create usable template from snapshot in 
Xenserver and Vmware

Fix also reverts below commit as below solution making assumption about 
hypervisor which are not applicable
in case of XenServer and VmWare

Revert "CLOUDSTACK-8964: Can't create template or volume from snapshot"

This reverts commit ccf5d75cfbe769b34c021ab3653ed318cae25933.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[anshul1886]

Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/1174


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1173#issuecomment-161929046
  
LGTM, thanks @DaanHoogland for fixing this so fast


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

[harikrishna-patnala]

Github user harikrishna-patnala commented on the pull request:

https://github.com/apache/cloudstack/pull/809#issuecomment-161954435
  
I have not tested but did a code walk through. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1171#issuecomment-161921440
  
@remibergsma thanks, not sure why this happened again. This was supposed to 
be for 4.6, will recreate a new PR. I'm not sure on how to test it, it's just 
that Jenkins build sometimes fails (if you'd google you may see some old 
failures); this was mainly for 4.5 but I thought the config changes (the 
JAVA_OPTS and surefire config changes) might be useful for 4.6+


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1163#issuecomment-161921580
  
Hi there...

Also got my LGTM! So it's now 2. :)

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[anshul1886]

GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/1174

CLOUDSTACK-9025: Fixed can't create usable template from snapshot in 
Xenserver and Vmware

https://issues.apache.org/jira/browse/CLOUDSTACK-9025

Fix also reverts below commit as below solution making assumption about 
hypervisor which are not applicable
in case of XenServer and VmWare

Revert "CLOUDSTACK-8964: Can't create template or volume from snapshot"

This reverts commit ccf5d75cfbe769b34c021ab3653ed318cae25933.

Testing:

Able to deploy VM successfully from template created from linked clone 
snapshot  on XenServer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9025-4.6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1174


commit f8790c3b9e822062bcdce88f62f57884bfc4
Author: Anshul Gangwar 
Date:   2015-12-04T09:20:01Z

CLOUDSTACK-9025: Fixed can't create usable template from snapshot in 
Xenserver and Vmware

Fix also reverts below commit as below solution making assumption about 
hypervisor which are not applicable
in case of XenServer and VmWare

Revert "CLOUDSTACK-8964: Can't create template or volume from snapshot"

This reverts commit ccf5d75cfbe769b34c021ab3653ed318cae25933.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1176#issuecomment-161929602
  
@anshul1886 thanks for pointing out. 
I think it is not reasonable to send command to each hypervisorguru, so my 
suggestion is to not change  HypervisorGuruManagerImpl.java. let us look for a 
solution for xenserver and vmware.

Can you explain what cloudstack do for xenserver before and after your 
change?
I do not get the difference .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1153#issuecomment-161931625
  
@pdube you are right projectid is not required , i did check API doc but 
got confused with UI and took it as doc bug.
when createVMSnapshot is being called from UI it passes projectid which is 
ignored by API.

http://*.*.*.*:8080/client/api?command=createVMSnapshot=cdf1991b-211c-4d18-a2c8-bbeb3dc23110=false=false=sd=json=a899bd21-7be6-4113-8cc2-e81771e0c0a1&_=1449223237150

thank , i am closing it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

[ProjectMoon]

Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1162#discussion_r46671185
  
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -135,9 +135,14 @@ def checkHostName():
 self.syscfg.svo.disableService("tomcat6")
 except:
 pass
-
+
 self.syscfg.svo.stopService("cloudstack-management")
-if self.syscfg.svo.enableService("cloudstack-management"):
-return True
+
+if self.syscfg.env.noStart == False:
+if self.syscfg.svo.enableService("cloudstack-management"):
+return True
+else:
+raise CloudRuntimeException("Failed to configure %s, 
please see the /var/log/cloudstack/management/setupManagement.log for 
detail"%self.serviceName)
--- End diff --

I will change it, but it should be known that this was actually the 
original message. :) Does need to be fixed though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

[ProjectMoon]

Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1162#discussion_r46671835
  
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -135,9 +135,14 @@ def checkHostName():
 self.syscfg.svo.disableService("tomcat6")
 except:
 pass
-
+
 self.syscfg.svo.stopService("cloudstack-management")
-if self.syscfg.svo.enableService("cloudstack-management"):
-return True
+
+if self.syscfg.env.noStart == False:
+if self.syscfg.svo.enableService("cloudstack-management"):
+return True
+else:
+raise CloudRuntimeException("Failed to configure %s, 
please see the /var/log/cloudstack/management/setupManagement.log for 
detail"%self.serviceName)
--- End diff --

So, one possible issue with this: will the serviceConfigServer.py script be 
processed by the *.in ant tasks, or will a new antrun task need to be added to 
process the files found at `python/lib/cloudutils`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1162#discussion_r46671886
  
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -135,9 +135,14 @@ def checkHostName():
 self.syscfg.svo.disableService("tomcat6")
 except:
 pass
-
+
 self.syscfg.svo.stopService("cloudstack-management")
-if self.syscfg.svo.enableService("cloudstack-management"):
-return True
+
+if self.syscfg.env.noStart == False:
+if self.syscfg.svo.enableService("cloudstack-management"):
+return True
+else:
+raise CloudRuntimeException("Failed to configure %s, 
please see the /var/log/cloudstack/management/setupManagement.log for 
detail"%self.serviceName)
--- End diff --

yeah you are right, and am I glad I forgot to add a :-1: ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1166#discussion_r46673018
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 ---
@@ -459,12 +463,8 @@ public StrategyPriority canHandle(Snapshot snapshot, 
SnapshotOperation op) {
 storagePoolId = volumeVO.getPoolId();
 }
 
-if (SnapshotOperation.REVERT.equals(op)) {
-if (volumeVO != null && 
ImageFormat.QCOW2.equals(volumeVO.getFormat()))
-return StrategyPriority.DEFAULT;
-else
-return StrategyPriority.CANT_HANDLE;
-}
+if (SnapshotOperation.REVERT.equals(op) && volumeVO != null && 
ImageFormat.QCOW2.equals(volumeVO.getFormat()))
--- End diff --

Can be moved. I was not sure of whether KVM code is dependent on those side 
effects or not so done like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[kansal]

Github user kansal commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1125#discussion_r46673005
  
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final 
String ipAddress, final String
 return isInRange;
 }
 
+public static boolean isNetworkorBroadcastIP(String ip, String 
netmask){
--- End diff --

@DaanHoogland Sure I can do that. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: debian: allow rules to pick ACS_BUILD_OPT...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1169


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1163#issuecomment-161916986
  
@DaanHoogland I will count that as a LGTM and will ask @wilderrodrigues to 
also review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9004: Add features to Hy...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1013#issuecomment-161919315
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

[snuf]

Github user snuf commented on the pull request:

https://github.com/apache/cloudstack/pull/1163#issuecomment-161921763
  
Aloha,

Nice find Remi, thanks for fixing this! LGTM.

Cheers,

Funs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1175

[4.6/master] rate-limit: increase JVM memory and enable fork mode for unit 
tests

Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to fix intermittent Jenkins failures
which look like:


multipleClientsCanAccessWithoutBlocking(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
unable to create new native thread

Previous PR (again master by mistake) -- #1171 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.6-rate-limit-testfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1175


commit dcc66651c0a5f53fcd9395139dad147b4ac1ea09
Author: Rohit Yadav 
Date:   2015-12-04T08:17:03Z

rate-limit: increase JVM memory and enable fork mode for unit tests

Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to fix intermittent Jenkins failures
which look like:


multipleClientsCanAccessWithoutBlocking(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
unable to create new native thread

(cherry picked from commit 421bc00cd6005d9e8484c6df46a3b84ff466afd2)
Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

[bhaisaab]

Github user bhaisaab closed the pull request at:

https://github.com/apache/cloudstack/pull/1171


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1171#issuecomment-161922013
  
@remibergsma okay, I found what Github did in my case: when you select the 
second branch dropdown while create a PR it resets the first dropdown branch to 
master 
Here's the 4.6 based PR https://github.com/apache/cloudstack/pull/1175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/1153


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9105: Logging enhancement: Han...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1167#issuecomment-161932139
  
LGTM, no tests done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1166#issuecomment-161936797
  
@anshul1886 and @ustcweizhou can you guys go in a ring about this and 1168 
please. Both address the same issue in a slightly different way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8845: set isRevertable of snap...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1168#issuecomment-161936820
  
@anshul1886 and @ustcweizhou can you guys go in a ring about this and 1166 
please. Both address the same issue in a slightly different way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1172#discussion_r46670189
  
--- Diff: 
engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java 
---
@@ -1411,14 +1411,12 @@ protected void runInContext() {
 final double managedHostsCount = 
allManagedRoutingAgents.size();
 if (allHostsCount > 0.0) {
 final double load = managedHostsCount / 
allHostsCount;
-if (load >= ConnectedAgentThreshold.value()) {
-s_logger.debug("Scheduling agent 
rebalancing task as the average agent load " + load + " is more than the 
threshold " +
-ConnectedAgentThreshold.value());
+if (load > ConnectedAgentThreshold.value()) {
+s_logger.debug("Scheduling agent 
rebalancing task as the average agent load " + load + " is more than the 
threshold " + ConnectedAgentThreshold.value());
 scheduleRebalanceAgents();
 _agentLbHappened = true;
 } else {
-s_logger.debug("Not scheduling agent 
rebalancing task as the averages load " + load + " is less than the threshold " 
+
-ConnectedAgentThreshold.value());
+s_logger.debug("Not scheduling agent 
rebalancing task as the average load " + load + " has not crossed the threshold 
" + ConnectedAgentThreshold.value());
--- End diff --

That's the only change, nothing else in that line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1162#discussion_r46670911
  
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -135,9 +135,14 @@ def checkHostName():
 self.syscfg.svo.disableService("tomcat6")
 except:
 pass
-
+
 self.syscfg.svo.stopService("cloudstack-management")
-if self.syscfg.svo.enableService("cloudstack-management"):
-return True
+
+if self.syscfg.env.noStart == False:
+if self.syscfg.svo.enableService("cloudstack-management"):
+return True
+else:
+raise CloudRuntimeException("Failed to configure %s, 
please see the /var/log/cloudstack/management/setupManagement.log for 
detail"%self.serviceName)
--- End diff --

Sorry to be a nag @ProjectMoon but can you change the path in the log 
message as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

[ProjectMoon]

Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1162#discussion_r46672120
  
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -135,9 +135,14 @@ def checkHostName():
 self.syscfg.svo.disableService("tomcat6")
 except:
 pass
-
+
 self.syscfg.svo.stopService("cloudstack-management")
-if self.syscfg.svo.enableService("cloudstack-management"):
-return True
+
+if self.syscfg.env.noStart == False:
+if self.syscfg.svo.enableService("cloudstack-management"):
+return True
+else:
+raise CloudRuntimeException("Failed to configure %s, 
please see the /var/log/cloudstack/management/setupManagement.log for 
detail"%self.serviceName)
--- End diff --

The original message had the log message in the wrong place (I think it was 
pointing at `/var/log/cloudstack-management/setupManagement.log`). I changed it 
to the right path on Linux systems (for Ubuntu and friends). But probably the 
log path can be fixed as part of this commit or in another one. But in order 
for the replace.properties stuff to work, there is an antrun task I believe. 
Not sure it would currently process files in the directory that 
serviceConfigServer.py is in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1166#discussion_r46672520
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 ---
@@ -459,12 +463,8 @@ public StrategyPriority canHandle(Snapshot snapshot, 
SnapshotOperation op) {
 storagePoolId = volumeVO.getPoolId();
 }
 
-if (SnapshotOperation.REVERT.equals(op)) {
-if (volumeVO != null && 
ImageFormat.QCOW2.equals(volumeVO.getFormat()))
-return StrategyPriority.DEFAULT;
-else
-return StrategyPriority.CANT_HANDLE;
-}
+if (SnapshotOperation.REVERT.equals(op) && volumeVO != null && 
ImageFormat.QCOW2.equals(volumeVO.getFormat()))
--- End diff --

this can be moved to line 446. 
in case volumeVO is not null , the only thing between these lines is
storagePoolId = volumeVO.getPoolId();



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9004: Add features to Hy...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1013#issuecomment-161948346
  
LGTM @jharshman can you make sure to add tests in follow-ups (both unit and 
integration)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1163#issuecomment-161923353
  
Thanks guys, will reduce the number of false positives by some


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1163#issuecomment-161923441
  
Nice :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1176#issuecomment-161927620
  
@ustcweizhou That bug is already taken care in Ovm3 guru code with commit 
66fed46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1159#issuecomment-161927649
  
@maneesha-p It doesn't hurt to put this statement every where but let's 
reduce the number of paths. as 4.6.0 to 4.6.1 contains a new view, I made a pr 
to re-route the 4.6.0 to 4.7.0 upgrade via 4.6.1!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: release managers wanted

[Remi Bergsma]

Hi Raja,

Kinda missed your mail, sorry! Are you a committer?

Would be great if you could help testing PRs, maybe run some BVT tests against 
them etc. That will allow to get them in sooner. Also, once we freeze we should 
test master again and  make sure it is stable. Running the BVT against master 
from time to time would be great.

Regards,
Remi





On 26/11/15 13:14, "Raja Pullela"  wrote:

>would like to volunteer... please count me in, if this is still open!
>
>-Original Message-
>From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
>Sent: Tuesday, November 24, 2015 7:35 PM
>To: dev 
>Subject: Re: release managers wanted
>
>shortly: check if PRs have enough review and merge to the right branch and 
>forward.
>
>long story: [1], [2] and [3]
>
>[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Releases
>[2] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Procedure
>[3]
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up
>
>
>
>On Tue, Nov 24, 2015 at 3:01 PM, Rafael Weingärtner < 
>rafaelweingart...@gmail.com> wrote:
>
>> Out of curiosity,
>> What are the responsabilities of a release manager?
>>
>> On Tue, Nov 24, 2015 at 11:06 AM, Daan Hoogland 
>> 
>> wrote:
>>
>> > People,
>> >
>> > We now have two release manager who both live in UTC+1. It would be 
>> > nice
>> to
>> > have some one from UTC-11 or there abouts and even better to have 
>> > two
>> extra
>> > people, one from between UTC+5 and +10, and one from UTC-6 to UTC-11.
>> >
>> > ​I think we can all see why,​
>> > --
>> > Daan
>> >
>>
>>
>>
>> --
>> Rafael Weingärtner
>>
>
>
>
>--
>Daan

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1162#discussion_r46671989
  
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -135,9 +135,14 @@ def checkHostName():
 self.syscfg.svo.disableService("tomcat6")
 except:
 pass
-
+
 self.syscfg.svo.stopService("cloudstack-management")
-if self.syscfg.svo.enableService("cloudstack-management"):
-return True
+
+if self.syscfg.env.noStart == False:
+if self.syscfg.svo.enableService("cloudstack-management"):
+return True
+else:
+raise CloudRuntimeException("Failed to configure %s, 
please see the /var/log/cloudstack/management/setupManagement.log for 
detail"%self.serviceName)
--- End diff --

We crossed each other here, what do you mean?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1125#discussion_r46672603
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -1197,6 +1197,10 @@ public Network createGuestNetwork(CreateNetworkCmd 
cmd) throws InsufficientCapac
 }
 
 if (gateway != null && netmask != null) {
+if(!NetUtils.isNetworkorBroadcastIP(gateway,netmask)) {
+s_logger.debug("The gateway IP provided is "+ gateway 
+ " and netmask is "+ netmask + ". The IP is either broadcast or network IP.");
--- End diff --

please, check for isDebugEnabled on s_logger


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1125#issuecomment-161919700
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

[ProjectMoon]

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1162#issuecomment-161926917
  
Removed the unintentional change to the initLoging (sic) method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1108#issuecomment-161927037
  
There is a lot of LGTM here (including mine) but did anybody do any 
relevant tests with this code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/855#issuecomment-161926840
  
This file could be used while fixing some time taking bugs in Console Proxy 
code. It can be used in similar way as described on 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/QuickCloud


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1125#discussion_r46672736
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -1197,6 +1197,10 @@ public Network createGuestNetwork(CreateNetworkCmd 
cmd) throws InsufficientCapac
 }
 
 if (gateway != null && netmask != null) {
+if(!NetUtils.isNetworkorBroadcastIP(gateway,netmask)) {
+s_logger.debug("The gateway IP provided is "+ gateway 
+ " and netmask is "+ netmask + ". The IP is either broadcast or network IP.");
--- End diff --

maybe you can change the name of the static object to LOGGER while you are 
at it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1163#issuecomment-161915494
  
@DaanHoogland Yes, that one fails quite regularly and I think that is 
related. Although without this fix it also passes, just not always (can be 
explained by ip address reuse and timings) but we'll have to see. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1173#issuecomment-161929234
  
once merged on master, I'll rebase quota-master branch (the quota PR) with 
latest master and then fix it's db upgrade paths.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1172#issuecomment-161936477
  
LGTM (based on the code)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1163#issuecomment-161916594
  
please merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: debian: allow rules to pick ACS_BUILD_OPT...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1169#issuecomment-161916597
  
Thanks @bhaisaab I will merge this now, as I count the LGTMs in PR #1149 
(in this case running the tests again is not needed).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1157#issuecomment-161918736
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1163


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1176#issuecomment-161926055
  
@anshul1886 I do not have Xenserver, so I do not test it.
However, I have to say that the issue CLOUDSTACK-8964 will appear again 
with this commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1176#issuecomment-161931232
  
@ustcweizhou I differ on this. We should not make HypervisorGuruManagerImpl 
complex by adding these kind of conditions as nobody is expert of all 
hypervisors and can make errors as happened in this case.  This will keep the 
core code simpler.

In XenServer after version 6.2 with hotfixes we start handling creating 
template from snapshot in Hypervisor agent code. So the change is if version is 
6.1 or 6.2 without hot fix then send the command to SSVM otherwise send to 
hypervisor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[jayapalu]

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-161940413
  
@bhaisaab @remibergsma 
Started merging these commits into the latest master/4.6. Hopefully Monday 
it will be ready.
@bhaisaab  In strongswan ipsec observed that on network restart existing 
remote access vpn connection is failed to come up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/1152#issuecomment-161944643
  
@jburwell Sure!! Will look into these. Adding the test cases and some UI 
changes for this to work. Will update the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1125#discussion_r46672870
  
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final 
String ipAddress, final String
 return isInRange;
 }
 
+public static boolean isNetworkorBroadcastIP(String ip, String 
netmask){
--- End diff --

Can you add unit tests for this function?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[pdube]

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1173#issuecomment-161987586
  
LGTM by code review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1173#discussion_r46694480
  
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -1,32 +0,0 @@
--- Licensed to the Apache Software Foundation (ASF) under one
--- or more contributor license agreements.  See the NOTICE file
--- distributed with this work for additional information
--- regarding copyright ownership.  The ASF licenses this file
--- to you under the Apache License, Version 2.0 (the
--- "License"); you may not use this file except in compliance
--- with the License.  You may obtain a copy of the License at
---
---   http://www.apache.org/licenses/LICENSE-2.0
---
--- Unless required by applicable law or agreed to in writing,
--- software distributed under the License is distributed on an
--- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
--- KIND, either express or implied.  See the License for the
--- specific language governing permissions and limitations
--- under the License.
-
---;
--- Schema upgrade from 4.6.0 to 4.7.0;
---;
-
-CREATE TABLE IF NOT EXISTS `cloud`.`domain_vlan_map` (
--- End diff --

@DaanHoogland I added it to both 460to470 and 461to470


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/855#issuecomment-162006901
  
@DaanHoogland, I just used the link there because before the link that was 
presented by @anshul1886, we have not being able to find that page.

I agree with you that links in code may get broken, but I did not have any 
other ideas on how to facilitate the search for that information. I can remove 
the link if you prefer.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache CloudStack 4.6.1

[Wilder Rodrigues]

Hi there!

I tested the RC, but could not finish all the tests because faced a network 
disconnection (wifi) during the last ones! :( Got pretty much everything in 
place!

My vote is +1 (binding)

All the tests I got executed are below:

KVM Host on CentOS 7.1
Management Server on CentOS 7.1

Create a redundant VPC with two networks with two VMs in each network ... === 
TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and check 
default routes ... === TestName: test_02_redundant_VPC_default_routes | Status 
: SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === 
TestName: test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: 
test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics after 
destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok

Connection broke here!

Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | Status 
: SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | Status : 
SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS 
===
ok
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | 
Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS 
===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple 
| Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS 
===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : 
SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : 
SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone for 
migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | 
Status : SUCCESS ===
ok
Test start/stop of router after addition of one guest network ... === TestName: 
test_01_start_stop_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest network 
... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === TestName: 
test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS 
===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status 

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/809#issuecomment-161982308
  
Sure Daan I will add .
On Dec 4, 2015 7:58 PM, "Daan Hoogland"  wrote:

> @sanju1010  can you add a run output to the
> PR?
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1173#discussion_r46685020
  
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -1,32 +0,0 @@
--- Licensed to the Apache Software Foundation (ASF) under one
--- or more contributor license agreements.  See the NOTICE file
--- distributed with this work for additional information
--- regarding copyright ownership.  The ASF licenses this file
--- to you under the Apache License, Version 2.0 (the
--- "License"); you may not use this file except in compliance
--- with the License.  You may obtain a copy of the License at
---
---   http://www.apache.org/licenses/LICENSE-2.0
---
--- Unless required by applicable law or agreed to in writing,
--- software distributed under the License is distributed on an
--- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
--- KIND, either express or implied.  See the License for the
--- specific language governing permissions and limitations
--- under the License.
-
---;
--- Schema upgrade from 4.6.0 to 4.7.0;
---;
-
-CREATE TABLE IF NOT EXISTS `cloud`.`domain_vlan_map` (
--- End diff --

Is this in the 4.6.0 to 4.6.1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

[pdube]

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1153#issuecomment-161978474
  
@nitt10prashant No problemo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/809#issuecomment-161980229
  
@sanju1010 can you add a run output to the PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1173#discussion_r46686423
  
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -1,32 +0,0 @@
--- Licensed to the Apache Software Foundation (ASF) under one
--- or more contributor license agreements.  See the NOTICE file
--- distributed with this work for additional information
--- regarding copyright ownership.  The ASF licenses this file
--- to you under the Apache License, Version 2.0 (the
--- "License"); you may not use this file except in compliance
--- with the License.  You may obtain a copy of the License at
---
---   http://www.apache.org/licenses/LICENSE-2.0
---
--- Unless required by applicable law or agreed to in writing,
--- software distributed under the License is distributed on an
--- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
--- KIND, either express or implied.  See the License for the
--- specific language governing permissions and limitations
--- under the License.
-
---;
--- Schema upgrade from 4.6.0 to 4.7.0;
---;
-
-CREATE TABLE IF NOT EXISTS `cloud`.`domain_vlan_map` (
--- End diff --

yes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/855#issuecomment-161981047
  
Based on code review I can live with this, though I am not happy with 
wiki-links in javadoc. wiki links may change independant of versions of the 
code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1173#discussion_r46687151
  
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -1,32 +0,0 @@
--- Licensed to the Apache Software Foundation (ASF) under one
--- or more contributor license agreements.  See the NOTICE file
--- distributed with this work for additional information
--- regarding copyright ownership.  The ASF licenses this file
--- to you under the Apache License, Version 2.0 (the
--- "License"); you may not use this file except in compliance
--- with the License.  You may obtain a copy of the License at
---
---   http://www.apache.org/licenses/LICENSE-2.0
---
--- Unless required by applicable law or agreed to in writing,
--- software distributed under the License is distributed on an
--- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
--- KIND, either express or implied.  See the License for the
--- specific language governing permissions and limitations
--- under the License.
-
---;
--- Schema upgrade from 4.6.0 to 4.7.0;
---;
-
-CREATE TABLE IF NOT EXISTS `cloud`.`domain_vlan_map` (
--- End diff --

actually it is in schema-461to470


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/1087#issuecomment-161975241
  
@PaulAngus sounds like a reasonable solution to preserve custom logrotate 
configurations on update.  Can you push update the PR to remove commit ec698f5?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/855#issuecomment-161957476
  
@anshul1886, we really tried to look up some doc about the use of that 
class, unfortunately nothing came up on our google searches. After reading the 
link you sent, I understand its use. Having said that, the removal of that 
class cannot be executed. However, this kind of problem can be easily avoided 
if we used proper java doc in classes.

What if we start doing that?
What do you think of that Java doc I committed?

A proper Java doc can help to avoid classes that grow almost without 
control, since the purpose of the class is displayed to everyone, developers 
would have information to rely on when extending a class functionality or when 
writing new ones and looking for a place to put them.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9004: Add features to Hy...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1013


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru handl...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1177

CLOUDSTACK-8964: Ovm3HypervisorGuru handle only srcData with HypervisorType 
is Ovm3

This PR can only be applied after PR #1176 

The CopyCommand on Ovm3 should be handled by Ovm3StorageProcessor, not SSVM.
Hence, I revert two commits on Ovm3HypervisorGuru, and add the 
hypervisorType check so that only the this guru will only handle Ovm3 (not KVM)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack Ovm3-CopyCommand

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1177


commit e0501be87ea3a171afba03086139355bb3dc6051
Author: Wei Zhou 
Date:   2015-12-04T17:18:15Z

Revert "CLOUDSTACK-8964 side effect isolation"

This reverts commit fc18d1e8b11c82a18854234b0c8c827896a5b78d.

commit 69e031d9beb662f28d0c5ca46ac19a6280ee2d4e
Author: Wei Zhou 
Date:   2015-12-04T17:18:28Z

Revert "simple change to prevent failure and keep OVM3 snapshots working"

This reverts commit 66fed462b64c8e3fe9e7ee39c7a1c07ff33108f9.

commit dc01fca4f3caaf1b8b5b2f33dd5ac2c811b7cab3
Author: Wei Zhou 
Date:   2015-12-04T17:26:12Z

CLOUDSTACK-8964: Ovm3HypervisorGuru handle only srcData with HypervisorType 
is Ovm3




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1176#issuecomment-162030592
  
LGTM, but just fix the .equals()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1176#discussion_r46707102
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
 DataTO srcData = cpyCommand.getSrcTO();
 DataTO destData = cpyCommand.getDestTO();
 
-if (srcData.getObjectType() == DataObjectType.SNAPSHOT && 
destData.getObjectType() == DataObjectType.TEMPLATE) {
+if (srcData.getHypervisorType() == HypervisorType.XenServer && 
srcData.getObjectType() == DataObjectType.SNAPSHOT &&
--- End diff --

HypervisorType.XenServer.equals(srcData.getHypervisorType()) ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1173#issuecomment-162030722
  
Merging now, that we've enough LGTMs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1176#issuecomment-162027142
  
@anshul1886 thanks a lot!
now I agree with you that we should revert 66fed46.
this PR LTGM, just one small comment.

I will create another PR for Ovm3HypervisorGuru, the CopyCommand on Ovm3 
should be processed byOvm3StorageProcessor, not ssvm.
I checked  VmwareGuru, no problem with it




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1173


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache CloudStack 4.6.1

[Remi Bergsma]

For the record, I’m also +1 (binding) on the RC, based on the tests I shared 
earlier.

Regards,
Remi






On 04/12/15 15:58, "Wilder Rodrigues"  wrote:

>Hi there!
>
>I tested the RC, but could not finish all the tests because faced a network 
>disconnection (wifi) during the last ones! :( Got pretty much everything in 
>place!
>
>My vote is +1 (binding)
>
>All the tests I got executed are below:
>
>KVM Host on CentOS 7.1
>Management Server on CentOS 7.1
>
>Create a redundant VPC with two networks with two VMs in each network ... === 
>TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
>SUCCESS ===
>ok
>Create a redundant VPC with two networks with two VMs in each network and 
>check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
>Status : SUCCESS ===
>ok
>Create a redundant VPC with two networks with two VMs in each network ... === 
>TestName: test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers 
>| Status : SUCCESS ===
>ok
>Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
>test_02_routervm_iptables_policies | Status : SUCCESS ===
>ok
>Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: 
>test_01_single_VPC_iptables_policies | Status : SUCCESS ===
>ok
>Test redundant router internals ... === TestName: 
>test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
>ok
>Test redundant router internals ... === TestName: 
>test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS 
>===
>ok
>Test redundant router internals ... === TestName: 
>test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
>ok
>Test redundant router internals ... === TestName: 
>test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS 
>===
>ok
>Create a VPC with two networks with one VM in each network and test nics after 
>destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
>ok
>Create a VPC with two networks with one VM in each network and test default 
>routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
>ok
>Check the password file in the Router VM ... === TestName: 
>test_isolate_network_password_server | Status : SUCCESS ===
>ok
>Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
>TestName: test_router_dhcphosts | Status : SUCCESS ===
>ok
>Test to create Load balancing rule with source NAT ... === TestName: 
>test_01_create_lb_rule_src_nat | Status : SUCCESS ===
>ok
>Test to create Load balancing rule with non source NAT ... === TestName: 
>test_02_create_lb_rule_non_nat | Status : SUCCESS ===
>ok
>
>Connection broke here!
>
>Test router internal advanced zone ... === TestName: 
>test_02_router_internal_adv | Status : SUCCESS ===
>ok
>Test restart network ... === TestName: test_03_restart_network_cleanup | 
>Status : SUCCESS ===
>ok
>Test router basic setup ... === TestName: test_05_router_basic | Status : 
>SUCCESS ===
>ok
>Test router advanced setup ... === TestName: test_06_router_advanced | Status 
>: SUCCESS ===
>ok
>Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
>ok
>Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
>ok
>Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS 
>===
>ok
>Test reset virtual machine on reboot ... === TestName: 
>test_01_reset_vm_on_reboot | Status : SUCCESS ===
>ok
>Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter 
>| Status : SUCCESS ===
>ok
>Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
>SUCCESS ===
>ok
>Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple 
>| Status : SUCCESS ===
>ok
>Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS 
>===
>ok
>Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
>SUCCESS ===
>ok
>Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
>SUCCESS ===
>ok
>Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : 
>SUCCESS ===
>ok
>Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : 
>SUCCESS ===
>ok
>Test migrate VM ... SKIP: At least two hosts should be present in the zone for 
>migration
>Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | 
>Status : SUCCESS ===
>ok
>Test start/stop of router after addition of one guest network ... === 
>TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
>Status : SUCCESS ===
>ok
>Test reboot of router after addition of one guest network ... === TestName: 
>test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS 
>===
>ok
>Test to change service offering of router after addition of one guest network 
>... === TestName: 

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1173#discussion_r46698656
  
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -1,32 +0,0 @@
--- Licensed to the Apache Software Foundation (ASF) under one
--- or more contributor license agreements.  See the NOTICE file
--- distributed with this work for additional information
--- regarding copyright ownership.  The ASF licenses this file
--- to you under the Apache License, Version 2.0 (the
--- "License"); you may not use this file except in compliance
--- with the License.  You may obtain a copy of the License at
---
---   http://www.apache.org/licenses/LICENSE-2.0
---
--- Unless required by applicable law or agreed to in writing,
--- software distributed under the License is distributed on an
--- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
--- KIND, either express or implied.  See the License for the
--- specific language governing permissions and limitations
--- under the License.
-
---;
--- Schema upgrade from 4.6.0 to 4.7.0;
---;
-
-CREATE TABLE IF NOT EXISTS `cloud`.`domain_vlan_map` (
--- End diff --

@ustcweizhou 460to470 is to be removed. all upgrades wil go 4.6.0 -> 4.6.1 
-> 4.7.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[RESULT][VOTE] Apache CloudStack 4.6.1

[Remi Bergsma]

Hi all,

After 72+ hours, the vote for CloudStack 4.6.1 [1] *passes* with 4 PMC + 1 
non-PMC votes.

+1 (PMC / binding)
* Rohit
* Milamber
* Wilder
* Remi

+1 (non binding)
* Glenn

0
* Wido
* Paul
* Daan

-1
none

Thanks to everyone participating.

I will now prepare the release announcement to go out after 24 hours to give 
the mirrors time to catch up.

[1] http://cloudstack.markmail.org/message/6kyeyi6az72ofhap

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru handl...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1177#issuecomment-162067636
  
The diff between this PR and last commit (before 4.6)
```
# git diff 2e26e97fe87cfc68a1748d6d5e539cd60cff22b2 
plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resources/Ovm3HypervisorGuru.java
diff --git 
a/plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resources/Ovm3HypervisorGuru.java
 b/plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resources/
index 6ec7741..4d222bb 100755
--- 
a/plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resources/Ovm3HypervisorGuru.java
+++ 
b/plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resources/Ovm3HypervisorGuru.java
@@ -96,18 +96,16 @@ public class Ovm3HypervisorGuru extends 
HypervisorGuruBase implements Hypervisor
 DataTO srcData = cpyCommand.getSrcTO();
 DataTO destData = cpyCommand.getDestTO();

-if (srcData.getObjectType() == DataObjectType.SNAPSHOT && 
destData.getObjectType() == DataObjectType.TEMPLATE) {
+if (HypervisorType.Ovm3.equals(srcData.getHypervisorType()) && 
srcData.getObjectType() == DataObjectType.SNAPSHOT && destData.getObjectType() 
== DataObjectType.TEMPLATE) {
 LOGGER.debug("Snapshot to Template: " + cmd);
 DataStoreTO srcStore = srcData.getDataStore();
 DataStoreTO destStore = destData.getDataStore();
 if (srcStore instanceof NfsTO && destStore instanceof 
NfsTO) {
 HostVO host = hostDao.findById(hostId);
 EndPoint ep = 
endPointSelector.selectHypervisorHost(new ZoneScope(host.getDataCenterId()));
-host = hostDao.findById(ep.getId());
-hostDao.loadDetails(host);
-// String snapshotHotFixVersion = 
host.getDetail(XenserverConfigs.XS620HotFix);
-// if (snapshotHotFixVersion != null && 
snapshotHotFixVersion.equalsIgnoreCase(XenserverConfigs.XSHotFix62ESP1004)) {
-return new Pair(Boolean.TRUE,  
Long.valueOf(ep.getId()));
+if (ep != null) {
+return new Pair(Boolean.TRUE,  
Long.valueOf(ep.getId()));
+}
 }
 }
 }
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add47xmessagesproperties transifex

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1098#issuecomment-162067669
  
@remibergsma Yes I want! The update of localization files is done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru handl...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1177#issuecomment-162107478
  
Pinging @snuf to have a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162107170
  
@bhaisaab @abhinandanprateek Just tested again. It's cool, the UI tweaks 
are very nice. Much better, I like it!

I can also confirm the menu option is not shown when the plugin is disabled 
(which is the default). Once you enable it, restart mgt server, it appears and 
looks like the screenshot above.

@jburwell Since you did the code review I'd like to hear from you if you 
are all OK as it is right now. Once you give your OK, I will proceed and merge 
it. I will make sure this will be included in 4.7.

Great work guys!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Feature freeze ACS 4.7 next Monday

[Remi Bergsma]

Hi all,

Next Monday we'll feature freeze for our upcoming 4.7 release. We looked 
through all open Pull Requests and below is our "whish list" to get in 4.7. 
Feel free to nominate any other changes that should go in 4.7. No guarantees, 
there is limited time so only PRs that we actively work on will make it.

The RC of 4.7.0 is scheduled for Monday Dec 14th so that we all will have a 
nice Christmas present ;-)

Please help us review these PRs. Most have already had some review and when we 
can reach 2xLGTM we can include them in 4.7 on time and make another great 
release.

Happy testing and reviewing!

Regards,
Daan & Remi


Features & Fixes PRs:

Quota
https://github.com/apache/cloudstack/pull/768

Logging enhancement
https://github.com/apache/cloudstack/pull/1167

VMware diskcontrollers
https://github.com/apache/cloudstack/pull/1132

ACS allows to create isolated networks with invalid gateway ip
https://github.com/apache/cloudstack/pull/1125

Update nic IP address of stopped vm
https://github.com/apache/cloudstack/pull/1086

Hypervisor changes to support UserData for Nuage VSP
https://github.com/apache/cloudstack/pull/1142

Support shared networking in NiciraNVP Plugin
https://github.com/apache/cloudstack/pull/1094

Strongswan vpn feature
https://github.com/apache/cloudstack/pull/872

VM Snapshotting implementation for KVM
https://github.com/apache/cloudstack/pull/977

Redundant VPC improvement
(PR will follow over the weekend)


UI PRs:

[UI] fix bug: Cannot delete SSH keypairs in projects
https://github.com/apache/cloudstack/pull/1154

UI icon over VM snapshot to deploy user instance
https://github.com/apache/cloudstack/pull/1150

Newly added project is not showing in the drop down until the browser is 
refreshed
https://github.com/apache/cloudstack/pull/1082

[GitHub] cloudstack pull request: Strongswan vpn feature

[terbolous]

Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-162106175
  
@jayapalu i believe that is broken in 4.6 already, atleast i filed an issue 
for it with the current openswan implementation at 
https://issues.apache.org/jira/browse/CLOUDSTACK-9079


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9004: Add features to Hy...

[jharshman]

Github user jharshman commented on the pull request:

https://github.com/apache/cloudstack/pull/1013#issuecomment-162115622
  
@DaanHoogland I will make sure to do so!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1172#issuecomment-162043429
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===

[GitHub] cloudstack pull request: CLOUDSTACK-8845: set isRevertable of snap...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1168#issuecomment-162044783
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===

[GitHub] cloudstack pull request: CLOUDSTACK-9105: Logging enhancement: Han...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1167#issuecomment-162047910
  
Example logs from this branch:
```
2015-12-04 18:37:14,864 DEBUG [c.c.s.StatsCollector] 
(StatsCollector-2:ctx-601c739d) (logid:52f7b0de) VmStatsCollector is running...
2015-12-04 18:37:15,963 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-15:null) (logid:) Ping from 2(kvm2)
2015-12-04 18:37:15,964 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-15:null) (logid:) Process host VM state report from ping 
process. host: 2
2015-12-04 18:37:15,968 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-15:null) (logid:) Process VM state report. host: 2, 
number of records in report: 2
2015-12-04 18:37:15,968 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-15:null) (logid:) VM state report. host: 2, vm id: 63, 
power state: PowerOn
2015-12-04 18:37:15,969 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-15:null) (logid:) VM power state does not change, skip DB 
writing. vm id: 63
2015-12-04 18:37:15,969 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-15:null) (logid:) VM state report. host: 2, vm id: 62, 
power state: PowerOn
2015-12-04 18:37:15,969 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-15:null) (logid:) VM power state does not change, skip DB 
writing. vm id: 62
2015-12-04 18:37:15,971 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-15:null) (logid:) Done with process of VM state report. 
host: 2
2015-12-04 18:37:18,355 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-12:null) (logid:) SeqA 6-2861: Processing Seq 6-2861:  { 
Cmd , MgmtId: -1, via: 6, Ver: v1, Flags: 11, 
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":63,"_loadInfo":"{\n
  \"connections\": []\n}","wait":0}}] }
2015-12-04 18:37:18,359 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-12:null) (logid:) SeqA 6-2861: Sending Seq 6-2861:  { 
Ans: , MgmtId: 90520732674657, via: 6, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":true,"wait":0}}] }
2015-12-04 18:37:19,582 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-11:null) (logid:) Ping from 5(s-62-VM)
2015-12-04 18:37:20,637 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-14:null) (logid:) Ping from 6(v-63-VM)
2015-12-04 18:37:22,051 INFO  [o.a.c.f.j.i.AsyncJobManagerImpl] 
(AsyncJobMgr-Heartbeat-1:ctx-354e88d7) (logid:910493fb) Begin cleanup expired 
async-jobs
2015-12-04 18:37:22,054 INFO  [o.a.c.f.j.i.AsyncJobManagerImpl] 
(AsyncJobMgr-Heartbeat-1:ctx-354e88d7) (logid:910493fb) End cleanup expired 
async-jobs
2015-12-04 18:37:23,386 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-4:null) (logid:) SeqA 6-2863: Processing Seq 6-2863:  { 
Cmd , MgmtId: -1, via: 6, Ver: v1, Flags: 11, 
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":63,"_loadInfo":"{\n
  \"connections\": []\n}","wait":0}}] }
2015-12-04 18:37:23,389 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-4:null) (logid:) SeqA 6-2863: Sending Seq 6-2863:  { Ans: 
, MgmtId: 90520732674657, via: 6, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":true,"wait":0}}] }
```

![screen shot 2015-12-04 at 19 42 
44](https://cloud.githubusercontent.com/assets/1630096/11597953/42adf29a-9abf-11e5-81fb-dce557f1d1e6.png)

@koushik-das Like it! My only remark is that some lines have an empty 
'logid:' which I'd recommend leaving out (shown in log, not in image). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-162038916
  
@remibergsma I've rebased and fixed upgrade paths, made the icon smaller 
with fainter colours (it's still coloured but faded). When you enable the quota 
service from global settings, the UI plugin would show up but in order to use 
it as the notification msg would say - you need to restart the mgmt server, 
after that you won't get any UI errors. LGTM, please review and go for a merge!
cc @jburwell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9105: Logging enhancement: Han...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1167#issuecomment-162045526
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1166#issuecomment-162048942
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===