[GitHub] cloudstack pull request: CLOUDSTACK-9231: Root volume migration fr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1336


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1338#issuecomment-172537670
  
@nitin-maharana I like it when you put screenshots, as this speeds up my 
testing because I can see what you mean. I will test it soon, can you help me 
by putting a screenshot so that I look for the right thing? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1334#issuecomment-172539609
  
LGTM, not tested actual Netscaler integration as I don't have such a setup.

I did check the syntax and saw the UI still renders properly.

![screen shot 2016-01-18 at 15 24 
26](https://cloud.githubusercontent.com/assets/1630096/12393696/9afbd25e-bdf7-11e5-92c7-101cbf1f3fc7.png)

![screen shot 2016-01-18 at 15 21 
56](https://cloud.githubusercontent.com/assets/1630096/12393657/5a8333b6-bdf7-11e5-9f23-2f12cfbc0e97.png)


![screen shot 2016-01-18 at 15 19 
56](https://cloud.githubusercontent.com/assets/1630096/12393652/548dd6fa-bdf7-11e5-90ac-925ee73029d0.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1319#issuecomment-172522583
  
At leaseweb we noticed the same behavior for networks. I propose we use the 
uuid as the name there as well. Will create a PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSSION] Collab for Spring 2016

[Pierre-Luc Dion]

Hi,

I can't recall the thread about having a Collab this spring. Not sure
either if a place has been selected yet, Does anyone would be interested to
participate if we organise something in Canada? or because of the Bresil
edition it would be preferable to have it in europe?

I wouldn't go with a full CCC style has we might not have enough budget but
we could do hackathon and open discussions?

Cheers,

Pierre-Luc

[GitHub] cloudstack pull request: trailing commas in javascripts removed

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1288#issuecomment-172533708
  
LGTM, UI seems to display OK.

![screen shot 2016-01-18 at 15 00 
56](https://cloud.githubusercontent.com/assets/1630096/12393165/516e8c2e-bdf4-11e5-9b79-8b0cd6855fc4.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: improve metrics view implementation

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1347#issuecomment-172536210
  
LGTM, nice improvement @bhaisaab !

Some screenshots of my test env:

![screen shot 2016-01-18 at 15 09 
08](https://cloud.githubusercontent.com/assets/1630096/12393394/afbaa172-bdf5-11e5-927b-0cbe94236a3a.png)

![screen shot 2016-01-18 at 15 09 
16](https://cloud.githubusercontent.com/assets/1630096/12393398/b4349d7a-bdf5-11e5-9158-5cc197242a41.png)

![screen shot 2016-01-18 at 15 09 
57](https://cloud.githubusercontent.com/assets/1630096/12393399/b8065376-bdf5-11e5-8cdb-940d97b35464.png)

![screen shot 2016-01-18 at 15 10 
23](https://cloud.githubusercontent.com/assets/1630096/12393405/bb1b8be4-bdf5-11e5-9e2f-17652e044729.png)

![screen shot 2016-01-18 at 15 11 
57](https://cloud.githubusercontent.com/assets/1630096/12393433/da694d24-bdf5-11e5-88d4-f98bf7a50a32.png)







---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1338#issuecomment-172545747
  
LGTM based on these tests:

Situation before when not using Netscaler:

![screen shot 2016-01-18 at 15 37 
25](https://cloud.githubusercontent.com/assets/1630096/12394040/baae8bc6-bdf9-11e5-9443-23ff6f2c42cb.png)

![screen shot 2016-01-18 at 15 34 
47](https://cloud.githubusercontent.com/assets/1630096/12394036/b5cc0b38-bdf9-11e5-9fc2-c29197c504ee.png)

![screen shot 2016-01-18 at 15 34 
58](https://cloud.githubusercontent.com/assets/1630096/12394044/c048925c-bdf9-11e5-9188-b694f823332c.png)

Basically, the button is displayed but throws an ugly message.

After the fix in this PR the button is hidden:

![screen shot 2016-01-18 at 15 38 
46](https://cloud.githubusercontent.com/assets/1630096/12394060/cffca7f6-bdf9-11e5-9c87-7cc739f5cc8e.png)

Didn't test if it shows when using Netscaler, as I don't have it in my test 
environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1319#discussion_r49997495
  
--- Diff: ui/scripts/docs.js ---
@@ -1008,7 +1008,7 @@ cloudStack.docs = {
 },
 // Add volume
 helpVolumeName: {
-desc: 'Give the volume a unique name so you can find it later.',
+desc: 'Give a unique volume name. If it is not provided, a name 
will be generated randomly.',
--- End diff --

did notice this until I started working on a similar issue for 
createNetwork. Shouldn't this be in a dictionary somewhere? @milamberspace You 
are the expert. Can you give an opinion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3016

[jenkins]

See 

Changes:

[nitin.maharana] CLOUDSTACK-9230: Remove unnecessary return statement from 
cloudStack.js

--
[...truncated 28733 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.748s]
[INFO] Apache CloudStack . SUCCESS [2.088s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.780s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.640s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.606s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.104s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.826s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.909s]
[INFO] Apache CloudStack API . SUCCESS [1:48.788s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.491s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.871s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.082s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.328s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.885s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.194s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.620s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.936s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.315s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.987s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.058s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.492s]
[INFO] Apache CloudStack Server .. SUCCESS [4:16.451s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.536s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.250s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:20.766s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.064s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.429s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.820s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.433s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.445s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.951s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.479s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.706s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.002s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [13.244s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.624s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.999s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.659s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[22.961s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[37.727s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.431s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.225s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS 

[GitHub] cloudstack pull request: Quota: findbug fixes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1289#issuecomment-172558281
  
again code LGTM. Let's quickly run it 3 out of 5 findbugs issues will be 
fixed in this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: improve metrics view implementation

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1347#issuecomment-172560057
  
did a run through the code: LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: improve metrics view implementation

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1347


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota: findbug fixes

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1289#issuecomment-172563054
  
What needs to be done to fix them all?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1294#issuecomment-172460540
  
@remibergsma @DaanHoogland I've fixed a concurency issue in a unit tests 
(pointed out by @borisroman) and in the process rebased this branch on latest 
4.7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1346#issuecomment-172488515
  
Hi @borisroman 

Thanks for the fixes! It will really make the VRs behave better! :)

I now sit next to Boris here at Schuberg Philis and was looking every now 
and then at his work. I also did a code review now.

LGTM :+1: 

@borisroman and running the IT and @remibergsma will do so as well. I'm 
starting mine now!

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1199#issuecomment-172463466
  
LGTM
based on code review 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1346

Enhance VR performance

Will post integration test results soon!

Ping @wilderrodrigues @remibergsma 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack 4.7-vr-performance

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1346


commit bd96a8e79f9aae3267c8870a34f8460147bcda92
Author: Boris Schrijver 
Date:   2016-01-16T18:47:02Z

Enhance VR performance by selectively executing tasks instead of 
brute-forcing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3014

[jenkins]

See 

--
[...truncated 28733 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.728s]
[INFO] Apache CloudStack . SUCCESS [2.139s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.766s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.694s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.938s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.115s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.293s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [28.463s]
[INFO] Apache CloudStack API . SUCCESS [1:49.171s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.968s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.615s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.086s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.338s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.440s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.533s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.426s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.546s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [15.289s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:09.833s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.790s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [24.988s]
[INFO] Apache CloudStack Server .. SUCCESS [4:12.827s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.679s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.389s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:23.158s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.073s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.448s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.329s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.373s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.954s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.471s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [26.226s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.986s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [37.034s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [13.272s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.063s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.954s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.900s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.917s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.551s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.575s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.583s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.073s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.156s]
[INFO] Apache 

[GitHub] cloudstack pull request: Strongswan vpn feature

[jayapalu]

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-172485592
  
@remibergsma conflict got resolved.
I have tried running this test. There were some test setup issue while I am 
running I resolved those in my local. The test got passed. Can you also please 
try the below tests.
test/integration/smoke/test_vpc_vpn.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1190#issuecomment-172466590
  
LGTM 
Test revert snapshot on XenServer ... === 
TestName:test_01_check_revert_snapshot | Status SUCCESS ===
ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[resmo]

Github user resmo commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r49976226
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file == "cmd_line.json" or process_file == 
"guest_network.json":
--- End diff --

small hint: for better readability I suggest this syntax instead: 
~~~python
if process_file in ['cmd_line.json', 'guest_network.json']: 
~~~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota: findbug fixes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1289#issuecomment-172594983
  
@remibergsma I would have to dive into my original investigation again. I 
am not sure who or where the others where created anymore. lat me markmail that 
for you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/1348

CLOUDSTACK-9142 Migrate VM changes xmlDesc in a safe way

The problem arises when the origin hypervisor has an ip addres that ends 
with 1, like '10.10.10.1' and the VM is having a disk on an NFS share that has 
that as part of its address, '10.10.10.100' for instance.
now migrating to '10.10.10.10' will change both addresses in the xml 
description file for qemu. It is fixed and unit tests are added. I am not sure 
yet how to integration test this. Regression will probably work so creating a 
PR now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9142

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1348


commit 2df0379d8ca3754fe926c168e304e2ff70f5e204
Author: Daan Hoogland 
Date:   2016-01-18T16:43:43Z

CLOUDSTACK-9142 Migrate VM changes xmlDesc in a safe way




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/1349

CLOUDSTACK-9239 throw exception on deprecated command

an API call to LockAccount fails silently with a 200 return and no 
contents. client are responsible to check and will find that no locking has 
actually occured. This way they may be lured to a sense of false security.
Throwing an exption makes the failure explicit.
cloudmonkey lock account name= domainid=
now errors out with an http result of 530

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9239

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1349


commit 28e17165c0105caa09c54105863944ff156a19f0
Author: Daan Hoogland 
Date:   2016-01-18T14:01:33Z

CLOUDSTACK-9239 throw exception on deprecated command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1349#issuecomment-172603168
  
Shouldn’t we make that clear at the documentation too?
I mean, the method/function should contain some info about the removal of 
the function. It is not the deprecation of a method per se, but it is the 
removal of a function.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1349#issuecomment-172606992
  
Makes sense Rafael, added something to that regard


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota: findbug fixes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1289#issuecomment-172597438
  
here is my original request to look at them:
http://markmail.org/message/fqv252o3p7hmzwxz


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: test: Fix Libvirt test so that it works o...

[bheuvel]

Github user bheuvel commented on the pull request:

https://github.com/apache/cloudstack/pull/1242#issuecomment-172607827
  
Well, short answer, LGTM and seen it compile on Windows (only) with this 
adjustment.

Longs answer has more to do with the object/code generating the path 
`/root/.ssh\id_rsa.pub.cloud`; why mixing path separators like this, how is it 
made to work on Windows, is the respective code supposed to run on windows at 
all, why hardcode path to `/root`-home and then some :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3017

[jenkins]

See 

Changes:

[nitin.maharana] CLOUDSTACK-9231: Root volume migration from one primary to 
another

[miguelferreira] Add test to check that each thread has it's own execution 
counter

[miguelferreira] Fix execution counter to support separate counts per thread

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.778s]
[INFO] Apache CloudStack . SUCCESS [2.139s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.801s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.513s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.482s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.101s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.080s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.381s]
[INFO] Apache CloudStack API . SUCCESS [1:48.144s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.358s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.048s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.107s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.834s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.071s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.045s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.721s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [37.568s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.450s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.070s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.007s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.484s]
[INFO] Apache CloudStack Server .. SUCCESS [4:12.794s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [38.644s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.666s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.001s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.068s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.440s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.894s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.829s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.724s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.202s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.787s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [22.920s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.368s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.950s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.484s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.977s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.450s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.490s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.826s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS 

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1349#issuecomment-172619972
  
Giving that, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSSION] Collab for Spring 2016

[Mike Tutkowski]

I'd be interested in a couple events this year pretty much wherever they
are. I have a couple ideas for new presentations that I think will be of
interest to people.

It's typically easier for me to get permission for longer-distance trips if
the event is longer (I expect that is common). We might want to consider
two-day events for these get-togethers this year.

Talk to you later,
Mike

On Mon, Jan 18, 2016 at 6:19 AM, Pierre-Luc Dion  wrote:

> Hi,
>
> I can't recall the thread about having a Collab this spring. Not sure
> either if a place has been selected yet, Does anyone would be interested to
> participate if we organise something in Canada? or because of the Bresil
> edition it would be preferable to have it in europe?
>
> I wouldn't go with a full CCC style has we might not have enough budget but
> we could do hackathon and open discussions?
>
> Cheers,
>
> Pierre-Luc
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1349#issuecomment-172622057
  
@DaanHoogland Please check, it doesn't compile :-(

```
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java:[88,18]
 error: cannot find symbol
[INFO] 1 error
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1294#issuecomment-172505055
  
LGTM :+1:

Did code review and ran the PR in beta


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1346#issuecomment-172505604
  
Have started tests on this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1346#issuecomment-172512058
  
Started the tests:

```
[root@cs1 integration]# nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=true smoke/test_vpc_redundant.py 
smoke/test_routers_iptables_default_policy.py smoke/test_routers_network_ops.py 
smoke/test_vpc_router_nics.py smoke/test_password_server.py 
smoke/test_router_dhcphosts.py smoke/test_loadbalance.py 
smoke/test_internal_lb.py smoke/test_ssvm.py smoke/test_vpc_vpn.py 
smoke/test_network.py

 Marvin Init Started 

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

 Log Folder Path: /tmp//MarvinLogs//Jan_18_2016_12_10_42_E041DB. All 
logs will be available here 

=== Marvin Init Logging Successful===

 Marvin Init Successful 
Creating a VPC offering..
Enabling the VPC offering created
Creating a VPC network in the account: 
test-TestRouterRules-test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL-BNYWSG
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: resolving a conflict due to reformatting

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1344#issuecomment-172500103
  
LGTM Run the tests to be sure, all fine.

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===

[GitHub] cloudstack pull request: resolving a conflict due to reformatting

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1344


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: resolving a conflict due to reformatting

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1344#issuecomment-172503325
  
After merging this PR shows much more commits and changed files than before 
merge.

For the record, this what I saw at the moment of merging:

![screen shot 2016-01-18 at 12 14 
26](https://cloud.githubusercontent.com/assets/1630096/12390311/067d0b2e-bddf-11e5-8f09-651fc92ff090.png)

This is the log of my commands:

![screen shot 2016-01-18 at 12 14 
36](https://cloud.githubusercontent.com/assets/1630096/12390318/0c59f282-bddf-11e5-99bc-e8f473a7c0cf.png)

Everything seems OK. @DaanHoogland can you please validate it went well? 
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: resolving a conflict due to reformatting

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1344#issuecomment-172519784
  
This due to the PR being for a merge commit. You could have just pushed it 
upstream
The extra merge does nothing
the extra file (s?) is only in the conflict resolving. It should be only 
one and it is also in one of the commits before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: improve metrics view implementation

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1347

ui: improve metrics view implementation

- Implement Search boxes in all Metrics views
- Fix threshold calculations for host and storage pool metrics view
- Consider overcommit ratios for calculation allocated thresholds
- Save/pass context while navigating across resources and metrics view

cc @remibergsma @DaanHoogland 

![screen shot 2016-01-18 at 12 55 42 
pm](https://cloud.githubusercontent.com/assets/95203/12390720/dfec51a0-bde2-11e5-8bdd-373f41a9c5d4.png)

![screen shot 2016-01-18 at 12 56 08 
pm](https://cloud.githubusercontent.com/assets/95203/12390731/ee572cb0-bde2-11e5-8228-087cc506958e.png)

![screen shot 2016-01-18 at 12 55 55 
pm](https://cloud.githubusercontent.com/assets/95203/12390732/ee58163e-bde2-11e5-9d78-befc6cd3f145.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.7-metrics-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1347


commit 750c11b494fe9100f233c8e9a7ef89c346ccaf2b
Author: Rohit Yadav 
Date:   2016-01-07T10:22:41Z

ui: improve metrics view implementation

- Implement Search boxes in all Metrics views
- Fix threshold calculations for host and storage pool metrics view
- Consider overcommit ratios for calculation allocated thresholds
- Save/pass context while navigating across resources and metrics view

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1294


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-jdk18 #457

[jenkins]

See 

Changes:

[wrodrigues] CLOUDSTACK-9154 - Returns the guest iterface that is marked as 
added

[wrodrigues] CLOUDSTACK-9154 - Adds test to cover nics state after GC

[wrodrigues] CLOUDSTACK-9187 - Adds test to cover multiple nics and nic removal

[wrodrigues] CLOUDSTACK-9187 - Fixes interface allocation to VRRP instances

[wrodrigues] CLOUDSTACK-9188 -  Reads network GC interval and wait from 
configDao

[wrodrigues] CLOUDSTACK-9187 - Makes code ready for more something like 
eth, if

[wrodrigues] CLOUDSTACK-9154 - Sets the pub interface down when all guest nets 
are

[nitin.maharana] CLOUDSTACK-9230: Remove unnecessary return statement from 
cloudStack.js

--
[...truncated 425 lines...]
Tests run: 10, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.556 sec - in 
com.cloud.utils.ScriptTest
Running com.cloud.utils.log.CglibThrowableRendererTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.198 sec - in 
com.cloud.utils.log.CglibThrowableRendererTest
Running com.cloud.utils.UuidUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.046 sec - in 
com.cloud.utils.UuidUtilsTest
Running com.cloud.utils.crypto.RSAHelperTest
2016-01-18 12:09:55,807 INFO  [utils.crypt.RSAHelper] (main:) [ignored]error 
during public key encryption: Unsupported format
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.829 sec - in 
com.cloud.utils.crypto.RSAHelperTest
Running com.cloud.utils.crypto.EncryptionSecretKeyCheckerTest
2016-01-18 12:09:55,919 DEBUG [utils.crypt.EncryptionSecretKeyChecker] (main:) 
Encryption Type: null
2016-01-18 12:09:55,919 DEBUG [utils.crypt.EncryptionSecretKeyChecker] (main:) 
Encryption Type: file
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.037 sec - in 
com.cloud.utils.crypto.EncryptionSecretKeyCheckerTest
Running com.cloud.utils.PropertiesUtilsTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec - in 
com.cloud.utils.PropertiesUtilsTest
Running com.cloud.utils.exception.ExceptionUtilTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in 
com.cloud.utils.exception.ExceptionUtilTest
Running com.cloud.utils.storage.QCOW2UtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in 
com.cloud.utils.storage.QCOW2UtilsTest
Running com.cloud.utils.encoding.UrlEncoderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec - in 
com.cloud.utils.encoding.UrlEncoderTest
Running com.cloud.utils.UriUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.039 sec - in 
com.cloud.utils.UriUtilsTest
Running com.cloud.utils.HttpUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.128 sec - in 
com.cloud.utils.HttpUtilsTest
Running com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
2016-01-18 12:09:56,261 INFO  [backoff.impl.ConstantTimeBackoff] (Thread-1:) 
Thread Thread-1 interrupted while waiting for retry
2016-01-18 12:09:56,366 DEBUG [backoff.impl.ConstantTimeBackoffTest] (main:) 
thread started
2016-01-18 12:09:56,366 DEBUG [backoff.impl.ConstantTimeBackoffTest] 
(Thread-2:) before
2016-01-18 12:09:56,467 DEBUG [backoff.impl.ConstantTimeBackoffTest] (main:) 
testing wakeup
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.322 sec - in 
com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
Running com.cloud.utils.ProcessUtilTest
2016-01-18 12:09:56,468 INFO  [backoff.impl.ConstantTimeBackoff] (Thread-2:) 
Thread Thread-2 interrupted while waiting for retry
2016-01-18 12:09:56,468 DEBUG [backoff.impl.ConstantTimeBackoffTest] 
(Thread-2:) after
2016-01-18 12:09:56,474 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
2016-01-18 12:09:56,479 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
2016-01-18 12:09:56,483 DEBUG [cloud.utils.ProcessUtil] (main:) Executing: bash 
-c ps -p 123456 
2016-01-18 12:09:56,544 DEBUG [cloud.utils.ProcessUtil] (main:) Exit value is 1
2016-01-18 12:09:56,544 DEBUG [cloud.utils.ProcessUtil] (main:)   PID TTY   
   TIME CMD
2016-01-18 12:09:56,545 DEBUG [cloud.utils.ProcessUtil] (main:) Executing: bash 
-c echo $PPID 
2016-01-18 12:09:56,552 DEBUG [cloud.utils.ProcessUtil] (main:) Execution is 
successful.
2016-01-18 12:09:56,557 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.092 sec - in 
com.cloud.utils.ProcessUtilTest
Running com.cloud.utils.PasswordGeneratorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec - in 
com.cloud.utils.PasswordGeneratorTest
Running com.cloud.utils.rest.HttpUriRequestBuilderTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec - in 
com.cloud.utils.rest.HttpUriRequestBuilderTest

Build failed in Jenkins: build-master-slowbuild #3015

[jenkins]

See 

Changes:

[wrodrigues] CLOUDSTACK-9154 - Returns the guest iterface that is marked as 
added

[wrodrigues] CLOUDSTACK-9154 - Adds test to cover nics state after GC

[wrodrigues] CLOUDSTACK-9187 - Adds test to cover multiple nics and nic removal

[wrodrigues] CLOUDSTACK-9187 - Fixes interface allocation to VRRP instances

[wrodrigues] CLOUDSTACK-9188 -  Reads network GC interval and wait from 
configDao

[wrodrigues] CLOUDSTACK-9187 - Makes code ready for more something like 
eth, if

[wrodrigues] CLOUDSTACK-9154 - Sets the pub interface down when all guest nets 
are

--
[...truncated 28733 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.780s]
[INFO] Apache CloudStack . SUCCESS [2.371s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.771s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.727s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.927s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.119s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.167s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.275s]
[INFO] Apache CloudStack API . SUCCESS [1:48.645s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.892s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.580s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.085s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.439s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.072s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.765s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.610s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.719s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [15.548s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.856s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.483s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.281s]
[INFO] Apache CloudStack Server .. SUCCESS [4:15.308s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.478s]
[INFO] Apache CloudStack Usage Server  SUCCESS [45.097s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:20.313s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.090s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.464s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.317s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.426s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [31.120s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.450s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [31.490s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.024s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [34.847s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.376s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.473s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS 

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-172624897
  
@DaanHoogland Please check, unit test error:
```
---
 T E S T S
---
Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
log4j:WARN No appenders could be found for logger 
(org.reflections.Reflections).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
Tests run: 144, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.726 sec 
<<< FAILURE! - in com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest

testMigrateCommand(com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest)
  Time elapsed: 0.013 sec  <<< ERROR!
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1960)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

[pdube]

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1337#issuecomment-172691481
  
Code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1331#discussion_r50066929
  
--- Diff: 
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
 ---
@@ -942,6 +931,83 @@ protected Answer copyFromNfsToS3(CopyCommand cmd) {
 }
 }
 
+protected boolean swiftUploadMetadataFile(SwiftTO swift, File srcFile, 
String containerName) throws IOException {
+
+
+//create a template.properties for Swift with its correct unique 
name
+File uniqDir = _storage.createUniqDir();
+String metaFileName = uniqDir.getAbsolutePath() + File.separator + 
"template.properties";
+_storage.create(uniqDir.getAbsolutePath(), "template.properties");
+
+String uniqueName = FilenameUtils.getBaseName(srcFile.getName());
+File metaFile = new File(metaFileName);
+FileWriter writer = new FileWriter(metaFile);
+BufferedWriter bufferWriter = new BufferedWriter(writer);
+bufferWriter.write("uniquename=" + uniqueName);
+bufferWriter.write("\n");
+bufferWriter.write("filename=" + srcFile.getName());
+bufferWriter.write("\n");
+bufferWriter.write("size=" + srcFile.length());
+bufferWriter.write("\n");
+bufferWriter.write("virtualsize=" + getVirtualSize(srcFile, 
getTemplateFormat(srcFile.getName(;
+bufferWriter.close();
+writer.close();
+
+SwiftUtil.putObject(swift, metaFile, containerName, _tmpltpp);
+metaFile.delete();
+uniqDir.delete();
+
+return true;
+}
+
+
+protected Answer copyFromNfsToSwift(CopyCommand cmd) {
+
+final DataTO srcData = cmd.getSrcTO();
+final DataTO destData = cmd.getDestTO();
+
+DataStoreTO srcDataStore = srcData.getDataStore();
+NfsTO srcStore = (NfsTO)srcDataStore;
+DataStoreTO destDataStore = destData.getDataStore();
+File srcFile = getFile(srcData.getPath(), srcStore.getUrl());
+
+SwiftTO swift = (SwiftTO)destDataStore;
+
+try {
+
+String containerName = 
SwiftUtil.getContainerName(destData.getObjectType().toString(), 
destData.getId());
+String swiftPath = SwiftUtil.putObject(swift, srcFile, 
containerName, srcFile.getName());
+
+
+DataTO retObj = null;
+if (destData.getObjectType() == DataObjectType.TEMPLATE) {
+swiftUploadMetadataFile(swift, srcFile, containerName);
+TemplateObjectTO newTemplate = new TemplateObjectTO();
+newTemplate.setPath(swiftPath);
+newTemplate.setSize(getVirtualSize(srcFile, 
getTemplateFormat(srcFile.getName(;
+newTemplate.setPhysicalSize(srcFile.length());
+
newTemplate.setFormat(getTemplateFormat(srcFile.getName()));
+retObj = newTemplate;
+} else if (destData.getObjectType() == DataObjectType.VOLUME) {
+VolumeObjectTO newVol = new VolumeObjectTO();
+newVol.setPath(containerName);
+newVol.setSize(srcFile.length());
--- End diff --

Not 100% related to this PR, but are the sizes on volumes and snapshots 
correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50057840
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
 fwd = CsForwardingRules("forwardingrules", config)
 fwd.process()
 
-logging.debug("Configuring s2s vpn")
 vpns = CsSite2SiteVpn("site2sitevpn", config)
 vpns.process()
 
-logging.debug("Configuring remote access vpn")
-#remote access vpn
 rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
 rvpn.process()
 
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
 lb = CsLoadBalancer("loadbalancer", config)
 lb.process()
 
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json", 
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
--- End diff --

These were configured above right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50058474
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
 self.conf.search(sline, line)
 
 def delete_leases(self):
-changed = []
-leases = []
 try:
-for line in open(LEASES):
-bits = line.strip().split(' ')
-to = {"device": bits[0],
-  "mac": bits[1],
-  "ip": bits[2],
-  "host": bits[3:],
-  "del": False
-  }
-changed.append(to)
-
-for v in changed:
-if v['mac'] == to['mac'] or v['ip'] == to['ip'] or 
v['host'] == to['host']:
-to['del'] = True
-leases.append(to)
-
-for o in leases:
-if o['del']:
-cmd = "dhcp_release eth%s %s %s" % (o['device'], 
o['ip'], o['mac'])
-logging.info(cmd)
-CsHelper.execute(cmd)
+open(LEASES, 'w').close()
--- End diff --

This truncates the file, but what about the cmd that was executed before? 
Is that handled elsewhere? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3019

[jenkins]

See 

--
[...truncated 28723 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.693s]
[INFO] Apache CloudStack . SUCCESS [2.135s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.788s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.514s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.694s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.115s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.786s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.696s]
[INFO] Apache CloudStack API . SUCCESS [1:49.159s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.229s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.494s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.095s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.435s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.797s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.120s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.267s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.642s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.218s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.408s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.834s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.624s]
[INFO] Apache CloudStack Server .. SUCCESS [4:12.234s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [38.343s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.999s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:20.942s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.071s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.429s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.174s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.308s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.223s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.845s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.562s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.798s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.169s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.711s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.882s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.986s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.456s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[24.354s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.594s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.577s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [24.112s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.891s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.266s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1342#discussion_r50058625
  
--- Diff: ui/scripts/ui-custom/instanceWizard.js ---
@@ -429,12 +427,52 @@
 
$step.find('.custom-size-label').remove();
 
 if (!custom) {
--- End diff --

Should become if(custom){//logic} to avoid empty condition


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1337#discussion_r50060205
  
--- Diff: ui/scripts/network.js ---
@@ -3667,8 +3652,16 @@
 return 2; 
//hide Autoscale button (both header and form)
 }
 } else { //from VPC 
section
-//VPC doesn't 
support autoscale
-return 2;
+var 
lbProviderIsNetscaler;
+var services = 
args.context.vpc[0].service;
+
+
lbProviderIsNetscaler = checkIfNetScalerProviderIsEnabled(services);
+
+if 
(lbProviderIsNetscaler == true) { //AutoScale is only supported on Netscaler 
(but not on any other provider like VirtualRouter)
--- End diff --

You could remove the condition here, it is unnecessary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50057844
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
--- End diff --

Why remove the logging here? Or, why not bring the lower code block here to 
condtionally process the fwd rules?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

[pdube]

Github user pdube closed the pull request at:

https://github.com/apache/cloudstack/pull/1135


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

[pdube]

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1135#issuecomment-172710149
  
@DaanHoogland np, I will close the PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3020

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.928s]
[INFO] Apache CloudStack . SUCCESS [2.260s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.781s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.283s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.413s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.111s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.716s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.656s]
[INFO] Apache CloudStack API . SUCCESS [1:47.676s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.052s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.096s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.121s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.591s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.066s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.718s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.446s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.774s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.217s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.071s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.856s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.260s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.865s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.740s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.710s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:23.371s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.075s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.440s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.309s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.596s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.894s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.730s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [30.783s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [22.791s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.824s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.369s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.929s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.982s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.501s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.984s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.897s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.542s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.338s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.921s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.711s]
[INFO] Apache 

Re: [DISCUSS][PROPOSE] use of optional instead of null

[John Burwell]

Daan,

The problem lies within Java itself and the decision not to allow for typed 
nulls.  Therefore, writing safe code requires a certain degree null checking.   
There are also circumstances where a null is the correct representation.  For 
example, there are optional numeric values who can only be properly represented 
by null when they are not defined.  I think the following would be a good start 
towards achieving the goal of not returning null:

1. For strings, return blank (i.e. “”) for the missing case
2. For collections, return an empty representation (e.g. 
Collections.emptySet(), Collections.emptyList(), etc)
3. Introduce a Nullable interface and create null implementation of 
classes we control
4. For enumerations, provide a NONE value for the missing case

In my experience, one of the best ways to reduce null issues is to implement 
argument checking, particularly on constructors using Guava’s 
Preconditions.checkArgument.  Not only does it help ensure that inputs to 
classes fit the expected constraints, but it fails early — easing the root 
cause identification.

Thanks,
-John

> On Jan 17, 2016, at 8:20 AM, Daan Hoogland  wrote:
>
> Thanks John, I agree that the solution from your gist is a good one in
> several circumstances as well. It doesn't completely invalidate both other
> solutions completely, though.
> so now we have three
> 1. exceptions instead of nulls
> 2. optionals
> 3. nullables
>
> Not sure how to continue from here, except that I think we need to remove
> all null returns where objects are expected.
>
>
> On Sat, Jan 16, 2016 at 1:56 PM, John Burwell 
> wrote:
>
>> Daan,
>>
>> I completely agree that returning null is bad. Not only does it yield a
>> ton of useless null checks, it creates leaky abstractions by spreading the
>> handling of the missing case out beyond the boundary of the class/subsystem.
>>
>> As a big proponent of the Null Object Pattern [1], I really wanted to like
>> Optional. It is a great concept in functional languages. So, I tried using
>> it in three (3) different projects since 2011. In all three systems, I
>> would say that, at best, it was no better than returning null, and, in
>> other cases, worse. Since Optional.get throws an exception when the wrapped
>> value is null, all optional accesses must be defensively checked so the
>> code base is littered with code like the following:
>>
>> if (value.isPresent()) {
>> return value.get();
>> }
>>
>> So, basically, you end up replacing null checks and NPEs with isPresent
>> checks and a Guava exception. As a bonus, when exceptions occurred in
>> production, we had explain the meaning of them. The quickest explanation —
>> “They are the new NPE”. For all new developers on the projects, we had one
>> more thing to explain to them which, again, was asking them to do something
>> differently with no added value. Based on these experiences, I prefer null
>> checks to optional.
>>
>> While it is more effort (i.e. more code), I have gone back to using the
>> Null Object Pattern implemented in this manner [2]. Not only does this
>> approach avoid NPEs, it also explicitly defines the behavior for the
>> missing case. For more complex examples, it can be unit tested to ensure
>> the missing case behaves as expected.
>>
>> Thanks,
>> -John
>>
>> [1]: https://en.wikipedia.org/wiki/Null_Object_pattern
>> [2]: https://gist.github.com/jburwell/f5162ad2d2de32c842b3
>>
>>>
>>
>> [image: ShapeBlue] 
>> John Burwell
>> ShapeBlue
>> d:  *+44 (20) 3603 0542 | s: +1 (571) 403-2411 *
>> <+44%20(20)%203603%200542%20%7C%20s:%20+1%20(571)%20403-2411>
>> e:  *john.burw...@shapeblue.com | t: *
>>   |  w:  *www.shapeblue.com*
>> 
>> a:  53 Chandos Place, Covent Garden London WC2N 4HS UK
>> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>> Services India LLP is a company incorporated in India and is operated under
>> license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
>> company incorporated in Brasil and is operated under license from Shape
>> Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of
>> South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is
>> a registered trademark.
>> This email and any attachments to it may be confidential and are intended
>> solely for the use of the individual to whom it is addressed. Any views or
>> opinions expressed are solely those of the author and do not necessarily
>> represent those of Shape Blue Ltd or related companies. If you are not the
>> intended recipient of this email, you must neither take any action based
>> upon its contents, nor copy or show it to anyone. Please contact the sender
>> if you believe you have received this email in error.
>>
>>
>> On Nov 17, 2015, at 11:16 AM, Daan Hoogland 
>> 

Help with JUnits

[B Prakash]

Hi,


Please can someone help me with identifying and amending junits for 
UserVmManagerImpl.commitUserVm?  I see a test class called UserVmManagerTest 
but I dont see a good junits coverage here.  Also link in the 'Developer > 
Testing > Unit testing with JUnit and Spring' doesnt give out lot of details on 
junits.

  1.  Am I looking at the right place for junits for the class 
UserVmManagerImpl.commitUserVm?
  2.  Is there any other link that provides more details on JUnits?
  3.  Any document or resource explaing cloudstack JUnit implementation in 
greater detail would be of great help.
  4.  If I want to track junit of this class, how do I track and execute them?


Regards,

Prakash

Re: Help with JUnits

[Mike Tutkowski]

Here's a video of a presentation I gave about Marvin (from CloudStack Days
in Austin last year):

https://www.youtube.com/watch?v=N_eKBA_TeOs

On Mon, Jan 18, 2016 at 9:49 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Does this help?
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python
>
> On Mon, Jan 18, 2016 at 8:56 PM, B Prakash  wrote:
>
>> Hi,
>>
>>
>> Please can someone help me with identifying and amending junits for
>> UserVmManagerImpl.commitUserVm?  I see a test class called
>> UserVmManagerTest but I dont see a good junits coverage here.  Also link in
>> the 'Developer > Testing > Unit testing with JUnit and Spring' doesnt give
>> out lot of details on junits.
>>
>>   1.  Am I looking at the right place for junits for the class
>> UserVmManagerImpl.commitUserVm?
>>   2.  Is there any other link that provides more details on JUnits?
>>   3.  Any document or resource explaing cloudstack JUnit implementation
>> in greater detail would be of great help.
>>   4.  If I want to track junit of this class, how do I track and execute
>> them?
>>
>>
>> Regards,
>>
>> Prakash
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

[pdube]

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-172715155
  
Code LGTM, as a general comment though, I think it is cleaner to be as 
precise as possible with exception handling.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] LTS Release Cycle

[John Burwell]

Daan and Erik,

@Erik Reading through the proposal, I realize that I was not explicit. LTS 
releases would be official ASF releases following the same voting procedures as 
any other release. Also, realized that I have a bit a math fail in my proposal. 
The cut dates are intended to be six (6) months apart. Therefore, the cut dates 
should be 1 January and 1 June. Therefore, I propose that we cut the first LTS 
branch from the most recent monthly release as of 1 June 2016.

@Daan As many people reflected in the previous discussion about release 
cadence, many users are wedged between enduring workarounds for significant 
defects and a level of upgrade risk that is not acceptable to them. For these 
users, releases are in use for 12-18 months which means that they are often 
forced to accept some significant workarounds to keep their systems stable 
(e.g. 4.5.2 VMWare users can’t use DRS with advanced networking due to VR being 
rebooted on DRS migrations). Keeping all of the previous monthly releases 
updated with important bug fixes is not tenable. LTS allows us to maintain a 
release branch to support users who must run a release for a 12-18 months 
without having to compromise their operational capability to preserve system 
stability.

In terms of the merge strategy, nothing about the current process would change. 
Defects would be fixed on the branch where they occurred and then forward 
ported to master. For each maintained LTS branch less than 14 months old, only 
blocker and critical defects that fall within the LTS’ branch scope would be 
pulled back from master. Therefore, the number of defects backported should be 
relatively small. Any defects found and fixed in an LTS branch would be forward 
ported to master. I will clarify the proposal to establish this merge pattern 
to ensure that LTS does not violate or impede the flow of defect fixes on 
master and maintained monthly releases.

Thanks,
-John

>

[ShapeBlue]
John Burwell
ShapeBlue

d:  +44 (20) 3603 0542 | s: +1 (571) 403-2411 


e:  john.burw...@shapeblue.com | t: 
 |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:imageff218b.png@a664b8fc.4fa0ac20]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




On Jan 16, 2016, at 5:07 AM, Daan Hoogland  wrote:
>
> +0, John, I admire your efforts but I would like to see a proposal more in
> line with our present process for PR merging and releasing. For 4.5 we have
> a bootstrap problem, here so that would reauire a transistion period
> (unless we start branding our LTS on 4.7) I also don see the neccesity for
> anything beyond tiny version. I think it is confusing. So I would prefer
> going for 4.7.1 ...2 ...3 etc or 4.5.4 ...5 ...6 if you wish. And next I am
> not attracted to the back-porting bit. We should make sure bugs are fixed
> on the commit that caused them and then forward ported to any branch that
> needs them, including master and LTS.
>
> That all said, I see a feasible plan so please go ahead.
>
> On Fri, Jan 15, 2016 at 10:26 PM, Erik Weber  wrote:
>
>> On Fri, Jan 15, 2016 at 7:48 PM, John Burwell 
>> wrote:
>>
>>> Motivation
>>> 
>>>
>>> The current monthly release cycle addresses the needs of users focused on
>>> deploying new functionality as quickly as possible. It does not address
>> the
>>> needs of users oriented towards stability rather than new functionality.
>>> These users typically employ QA processes to comply with corporate policy
>>> and/or regulatory requirements. To maintain a growing, thriving
>> community,
>>> we must address the needs of both user types. Therefore, I propose that
>> we
>>> overlay a LTS release cycle onto the monthly release cycle to address the
>>> needs of stability-oriented users with minimal to no impact on the
>> monthly
>>> release 

Re: Help with JUnits

[Mike Tutkowski]

Does this help?

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python

On Mon, Jan 18, 2016 at 8:56 PM, B Prakash  wrote:

> Hi,
>
>
> Please can someone help me with identifying and amending junits for
> UserVmManagerImpl.commitUserVm?  I see a test class called
> UserVmManagerTest but I dont see a good junits coverage here.  Also link in
> the 'Developer > Testing > Unit testing with JUnit and Spring' doesnt give
> out lot of details on junits.
>
>   1.  Am I looking at the right place for junits for the class
> UserVmManagerImpl.commitUserVm?
>   2.  Is there any other link that provides more details on JUnits?
>   3.  Any document or resource explaing cloudstack JUnit implementation in
> greater detail would be of great help.
>   4.  If I want to track junit of this class, how do I track and execute
> them?
>
>
> Regards,
>
> Prakash
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [PROPOSAL] LTS Release Cycle

[John Burwell]

Ilya,

Unless we have a bug fix that addresses a significant, widespread system 
stability problem or a high priority/impact security issue, an LTS will roll up 
a number of fixes.   Each release would receive the full system test to verify 
that the patch set does not introduce regression defects.  I believe that most 
LTS users want a few releases as necessary to keep their systems up-to-date and 
stable because each upgrade carries operational risk and downtime.  Therefore, 
the process should strive to make as a few releases as necessary to achieve 
this goal.

Thanks,
-John

> On Jan 15, 2016, at 3:22 PM, ilya  wrote:
>
> John
>
> Thank you for taking time writing out the LTS proposal.
>
>> Broad community support is vital to guarantee the twenty (20) month
>> support period for each LTS branch. Given the ebbs and flows of
>> contribution and committer priorities, ShapeBlue will provide a release
>> manager, as well as, engineering support to fill any contribution gaps
>> to ensure that the community fulfills LTS commitments.
>
> You guys rock!!
>
> I'm +1 on this,
>
> Can you please expand on the QA side of LTS. Since this is more around
> long term bug/security fix - i'd think - the testing will be minimal, to
> the scope that fix applies - which will speed up the release process in
> general. What are your thoughts on this?
>
>
> Thanks
> ilya
>
>
>
>
>
> On 1/15/16 10:48 AM, John Burwell wrote:
>> Motivation
>> 
>>
>> The current monthly release cycle addresses the needs of users focused
>> on deploying new functionality as quickly as possible. It does not
>> address the needs of users oriented towards stability rather than new
>> functionality. These users typically employ QA processes to comply with
>> corporate policy and/or regulatory requirements. To maintain a growing,
>> thriving community, we must address the needs of both user types.
>> Therefore, I propose that we overlay a LTS release cycle onto the
>> monthly release cycle to address the needs of stability-oriented users
>> with minimal to no impact on the monthly release cycle. This proposed
>> LTS release cycle has the following goals:
>>
>> * Prefer Stability to New Functionality: Deliver releases that only
>> address defects and CVEs. This narrowly focused change scope greatly
>> reduces the upgrade risk/operational impact and shorter internal QA cycles.
>> * Reliable Release Lifetimes: Embracing a time-based release strategy,
>> the LTS release cycle will provide users with a reliable support time
>> frames. Users can use these time frames provide users with an 20 month
>> window in which to plan upgrades.
>> * Support Sustainability: With a defined end of support for LTS releases
>> and a maximum of two (2) LTS releases under active maintenance at any
>> given time, community members can better plan their commitments to
>> release support activities. We also have a agreed upon policy for
>> release end-of-life (EOL) to debate about continuing work on old releases.
>>
>> Proposed Process
>> ==
>>
>> LTS release branches will be cut twice year on 1 Jan and 1 July from the
>> tag of the most recent monthly release. The branch will be named > version>-LTS and each LTS release will be versioned in the form of > version>-. For example, if we cut an LTS branch
>> based on 4.7.0, the branch would be named 4.7.0-LTS and the version of
>> the first LTS release would be 4.7.0-0, the second would be 4.7.0-1,
>> etc. This release naming convention differentiates LTS and monthly
>> releases, communicates the version on which the LTS release is based,
>> and allows the maintenance releases for monthly releases without version
>> number contention/conflict. Finally, like master, an LTS branch would be
>> always deployable following its initial release. While it is unlikely
>> that LTS users would deploy from the branch, the quality discipline of
>> this requirement will benefit the long term stability of LTS releases.
>> All PRs targeting an LTS would require two LGTMs in order to be merged.
>>
>> The following are the types of changes that would permitted and
>> guarantees provided to users:
>>
>> * No features or enhancements would be backported to LTS release branches.
>> * Database changes would be limited to those required to address the
>> backported defect fixes.
>> * Support for the release/version of the following components from the
>> release on which the LTS is based throughout the entire release cycle:
>> * MySQL/MariaDB
>> * JDK/JRE
>> * Linux distributions
>> * API compatibility for between all LTS revisions. API changes would be
>> limited to those required to fix defects or address security issues.
>>
>> An LTS release would have a twenty (20) month lifetime from the date the
>> release branch is cut. This support period allows up to two (2) months
>> of branch stabilization before initial release with a minimum of
>> eighteen (18) months of availability for deployment. LTS 

Re: Help with JUnits

[B Prakash]

Thanks Mike, I read through the link and also saw the video, this answers part 
of my question about executing the unit tests.  The other part of the questions 
still remains ie were are junits written in Java for this class and operation 
UserVmManagerImpl.commitUserVm.  

How do we check the junit coverage for a particular class and implementation in 
it?  Where do I start looking for them and confirm if they exist?


From: Mike Tutkowski 
Sent: Monday, January 18, 2016 11:51 PM
To: dev@cloudstack.apache.org
Subject: Re: Help with JUnits

Here's a video of a presentation I gave about Marvin (from CloudStack Days
in Austin last year):

https://www.youtube.com/watch?v=N_eKBA_TeOs

On Mon, Jan 18, 2016 at 9:49 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Does this help?
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python
>
> On Mon, Jan 18, 2016 at 8:56 PM, B Prakash  wrote:
>
>> Hi,
>>
>>
>> Please can someone help me with identifying and amending junits for
>> UserVmManagerImpl.commitUserVm?  I see a test class called
>> UserVmManagerTest but I dont see a good junits coverage here.  Also link in
>> the 'Developer > Testing > Unit testing with JUnit and Spring' doesnt give
>> out lot of details on junits.
>>
>>   1.  Am I looking at the right place for junits for the class
>> UserVmManagerImpl.commitUserVm?
>>   2.  Is there any other link that provides more details on JUnits?
>>   3.  Any document or resource explaing cloudstack JUnit implementation
>> in greater detail would be of great help.
>>   4.  If I want to track junit of this class, how do I track and execute
>> them?
>>
>>
>> Regards,
>>
>> Prakash
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Build failed in Jenkins: build-master-slowbuild #3021

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.805s]
[INFO] Apache CloudStack . SUCCESS [2.105s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.774s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.951s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:31.447s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.099s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.288s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.433s]
[INFO] Apache CloudStack API . SUCCESS [1:46.700s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.260s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.354s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.087s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.532s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.097s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.820s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.153s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.586s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [13.918s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.755s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.100s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.366s]
[INFO] Apache CloudStack Server .. SUCCESS [4:12.454s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [38.131s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.066s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.040s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.070s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.450s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.672s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.479s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.770s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.421s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.847s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.732s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.516s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.429s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.704s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.002s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.168s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.632s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.216s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.018s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.491s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [14.959s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.531s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[milamberspace]

Github user milamberspace commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1319#discussion_r50079832
  
--- Diff: ui/scripts/docs.js ---
@@ -1008,7 +1008,7 @@ cloudStack.docs = {
 },
 // Add volume
 helpVolumeName: {
-desc: 'Give the volume a unique name so you can find it later.',
+desc: 'Give a unique volume name. If it is not provided, a name 
will be generated randomly.',
--- End diff --

Yes that would be better to put this sentences into dictionary and 
messages.properties (key should start with "message.tooltip.") 
(even if they are a lot of 'desc' strings in javascript files which need to 
be localized. Probably a work for me ;-))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] LTS Release Cycle

[Daan Hoogland]

On Tue, Jan 19, 2016 at 4:20 AM, John Burwell 
wrote:

> In terms of the merge strategy, nothing about the current process would
> change. Defects would be fixed on the branch where they occurred and then
> forward ported to master. For each maintained LTS branch less than 14
> months old, only blocker and critical defects that fall within the LTS’
> branch scope would be pulled back from master. Therefore, the number of
> defects backported should be relatively small. Any defects found and fixed
> in an LTS branch would be forward ported to master. I will clarify the
> proposal to establish this merge pattern to ensure that LTS does not
> violate or impede the flow of defect fixes on master and maintained monthly
> releases.
>

​John, Any backporting should be avoided. Any fix review should include the
contemplation of the question, 'Is this on the right branch?'. That is my
point. I am not against LTS. I want fixes to be traceable by their commit
id over all branches. Backporting is killing in that respect.​

​I am not the release manager so rest assured I will not ​make an issue of
this any more. I won't hold my peace either, though.


-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1319#discussion_r50081550
  
--- Diff: ui/scripts/docs.js ---
@@ -1008,7 +1008,7 @@ cloudStack.docs = {
 },
 // Add volume
 helpVolumeName: {
-desc: 'Give the volume a unique name so you can find it later.',
+desc: 'Give a unique volume name. If it is not provided, a name 
will be generated randomly.',
--- End diff --

Ah, so in the present state you do not consider this worth a :-1: , I read 
from your comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

New Defects reported by Coverity Scan for cloudstack

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to cloudstack found 
with Coverity Scan.

1 new defect(s) introduced to cloudstack found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1349405:  Null pointer dereferences  (FORWARD_NULL)
/server/src/com/cloud/network/router/NicProfileHelperImpl.java: 90 in 
com.cloud.network.router.NicProfileHelperImpl.createPrivateNicProfileForGateway(com.cloud.network.vpc.VpcGateway,
 com.cloud.network.router.VirtualRouter)()



*** CID 1349405:  Null pointer dereferences  (FORWARD_NULL)
/server/src/com/cloud/network/router/NicProfileHelperImpl.java: 90 in 
com.cloud.network.router.NicProfileHelperImpl.createPrivateNicProfileForGateway(com.cloud.network.vpc.VpcGateway,
 com.cloud.network.router.VirtualRouter)()
84 privateNicProfile =
85 new NicProfile(privateNic, privateNetwork, 
privateNic.getBroadcastUri(), privateNic.getIsolationUri(), 
_networkModel.getNetworkRate(
86 privateNetwork.getId(), router.getId()), 
_networkModel.isSecurityGroupSupportedInNetwork(privateNetwork), 
_networkModel.getNetworkTag(
87 router.getHypervisorType(), 
privateNetwork));
88 } else {
89 final String netmask = 
NetUtils.getCidrNetmask(privateNetwork.getCidr());
>>> CID 1349405:  Null pointer dereferences  (FORWARD_NULL)
>>> Calling a method on null object "ipVO".
90 final PrivateIpAddress ip =
91 new PrivateIpAddress(ipVO, 
privateNetwork.getBroadcastUri().toString(), privateNetwork.getGateway(), 
netmask,
92 
NetUtils.long2Mac(NetUtils.createSequenceBasedMacAddress(ipVO.getMacAddress(;
93 
94 final URI netUri = 
BroadcastDomainType.fromString(ip.getBroadcastUri());
95 privateNicProfile.setIPv4Address(ip.getIpAddress());



To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/cloudstack?tab=overview

To manage Coverity Scan email notifications for "dev@cloudstack.apache.org", 
click 
https://scan.coverity.com/subscriptions/edit?email=dev%40cloudstack.apache.org=494aabd5ba647999fa41b6d766646231

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1349#issuecomment-172657149
  
f(^(* cherry-pick problem. it was fixed in 4.2.1 first :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-172661987
  
looking into this, probably been working on to much at the same time today, 
sorry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSSION] Collab for Spring 2016

[Mike Tutkowski]

So you're thinking a Hackathon day and a day of presentations?

That seems reasonable.

On Monday, January 18, 2016, Pierre-Luc Dion  wrote:

> 2 days or more so we could have an hackathon or a day where we could spend
> collaborative time working on cloudstack ?
> I liked the hackathon of previous events but they were usually during time
> of interesting talks so I  think it would be nice to split them but within
> the same event.
>
> PL
>
>
> On Mon, Jan 18, 2016 at 1:52 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com > wrote:
>
> > I'd be interested in a couple events this year pretty much wherever they
> > are. I have a couple ideas for new presentations that I think will be of
> > interest to people.
> >
> > It's typically easier for me to get permission for longer-distance trips
> if
> > the event is longer (I expect that is common). We might want to consider
> > two-day events for these get-togethers this year.
> >
> > Talk to you later,
> > Mike
> >
> > On Mon, Jan 18, 2016 at 6:19 AM, Pierre-Luc Dion  >
> > wrote:
> >
> > > Hi,
> > >
> > > I can't recall the thread about having a Collab this spring. Not sure
> > > either if a place has been selected yet, Does anyone would be
> interested
> > to
> > > participate if we organise something in Canada? or because of the
> Bresil
> > > edition it would be preferable to have it in europe?
> > >
> > > I wouldn't go with a full CCC style has we might not have enough budget
> > but
> > > we could do hackathon and open discussions?
> > >
> > > Cheers,
> > >
> > > Pierre-Luc
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com 
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
> >
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [DISCUSSION] Collab for Spring 2016

[Will Stevens]

I like this idea as well because it gets more of the participants focusing
on the actual code.  I think it will make the hackathon more useful for the
project this way.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Mon, Jan 18, 2016 at 4:53 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> So you're thinking a Hackathon day and a day of presentations?
>
> That seems reasonable.
>
> On Monday, January 18, 2016, Pierre-Luc Dion  wrote:
>
> > 2 days or more so we could have an hackathon or a day where we could
> spend
> > collaborative time working on cloudstack ?
> > I liked the hackathon of previous events but they were usually during
> time
> > of interesting talks so I  think it would be nice to split them but
> within
> > the same event.
> >
> > PL
> >
> >
> > On Mon, Jan 18, 2016 at 1:52 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com > wrote:
> >
> > > I'd be interested in a couple events this year pretty much wherever
> they
> > > are. I have a couple ideas for new presentations that I think will be
> of
> > > interest to people.
> > >
> > > It's typically easier for me to get permission for longer-distance
> trips
> > if
> > > the event is longer (I expect that is common). We might want to
> consider
> > > two-day events for these get-togethers this year.
> > >
> > > Talk to you later,
> > > Mike
> > >
> > > On Mon, Jan 18, 2016 at 6:19 AM, Pierre-Luc Dion  > >
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > I can't recall the thread about having a Collab this spring. Not sure
> > > > either if a place has been selected yet, Does anyone would be
> > interested
> > > to
> > > > participate if we organise something in Canada? or because of the
> > Bresil
> > > > edition it would be preferable to have it in europe?
> > > >
> > > > I wouldn't go with a full CCC style has we might not have enough
> budget
> > > but
> > > > we could do hackathon and open discussions?
> > > >
> > > > Cheers,
> > > >
> > > > Pierre-Luc
> > > >
> > >
> > >
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkow...@solidfire.com 
> > > o: 303.746.7302
> > > Advancing the way the world uses the cloud
> > > *™*
> > >
> >
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>

Re: [DISCUSSION] Collab for Spring 2016

[Pierre-Luc Dion]

2 days or more so we could have an hackathon or a day where we could spend
collaborative time working on cloudstack ?
I liked the hackathon of previous events but they were usually during time
of interesting talks so I  think it would be nice to split them but within
the same event.

PL


On Mon, Jan 18, 2016 at 1:52 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> I'd be interested in a couple events this year pretty much wherever they
> are. I have a couple ideas for new presentations that I think will be of
> interest to people.
>
> It's typically easier for me to get permission for longer-distance trips if
> the event is longer (I expect that is common). We might want to consider
> two-day events for these get-togethers this year.
>
> Talk to you later,
> Mike
>
> On Mon, Jan 18, 2016 at 6:19 AM, Pierre-Luc Dion 
> wrote:
>
> > Hi,
> >
> > I can't recall the thread about having a Collab this spring. Not sure
> > either if a place has been selected yet, Does anyone would be interested
> to
> > participate if we organise something in Canada? or because of the Bresil
> > edition it would be preferable to have it in europe?
> >
> > I wouldn't go with a full CCC style has we might not have enough budget
> but
> > we could do hackathon and open discussions?
> >
> > Cheers,
> >
> > Pierre-Luc
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>

Build failed in Jenkins: build-master-slowbuild #3018

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.710s]
[INFO] Apache CloudStack . SUCCESS [2.091s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.772s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.113s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.980s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.103s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.183s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.806s]
[INFO] Apache CloudStack API . SUCCESS [1:58.096s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.183s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.346s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.089s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.699s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.232s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.028s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.155s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.550s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.635s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.462s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.090s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.335s]
[INFO] Apache CloudStack Server .. SUCCESS [4:12.096s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.941s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.690s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:23.039s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.071s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.454s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.479s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.475s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [31.263s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.741s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [26.781s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.368s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [34.979s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.402s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.772s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.003s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.619s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.831s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.780s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.055s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.593s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [14.797s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.138s]
[INFO] Apache