Re: [ACP Doctor] What is it?

[Ian Rae]

I don't believe this is freely available, rather is a tool Citrix developed
for helping troubleshoot CCP customer deployments. I would imagine that
Accelerite owns this tool now and it is likely available if you are an ACP
customer, but not necessarily for ACS users.

Probably best for Accelerite to comment.

On Tuesday, 5 April 2016, Will Stevens  wrote:

> It used to be CCP Doctor and it is not in ACS from my understanding.  It is
> a set of scripts that will do basic validation of a CloudStack setup.  It
> does things like verify the system VMs are running and the connectivity is
> working between all of the systems.  It also does some checking to make
> sure the versions of software is correct and checks some things in the DB
> as well.  It also collects a whole crap ton of logs and database dumps (i
> think) and zips them up for easy transfer to support so they can get a
> solid feel for your setup.
>
> It also has 'suggestions' for things you can do to fix different aspects of
> your setup.  Things like setting 'ulimit' to 'unlimited' and will give you
> the command to run.  It also lets you pass a 'fix' flag and it will
> automagically make all the changes for you.  I am too paranoid to have
> actually used the fix flag because I was always using this in production
> environments and I am a little too risk averse to let a script do anything
> for me (unless I wrote it).
>
> Does that answer your question?  It should be freely available and you
> should be able to run it against ACS, so you should be able to try it
> out...
>
> It is a pretty useful tool to be honest.  Especially if you are
> troubleshooting an environment you didn't setup.
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Tue, Apr 5, 2016 at 5:28 PM, ilya  > wrote:
>
> > Saw ACP Doctor in CCP release notes from Accelerite.
> >
> > Curious what it is, is it integrated into cloudstack or collection of
> > shell scripts?
> >
> > Thanks
> > ilya
> >
>


-- 
Ian Rae
CEO | PDG
c: 514.944.4008

CloudOps | Cloud Infrastructure and Networking Solutions
www.cloudops.com | 420 rue Guy | Montreal | Canada | H3J 1S6

[GitHub] cloudstack pull request: [CLOUDSTACK-9337]Enhance vcenter.py to cr...

[alexandrelimassantana]

Github user alexandrelimassantana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1464#discussion_r58633962
  
--- Diff: tools/marvin/marvin/lib/vcenter.py ---
@@ -183,7 +192,157 @@ def get_clusters(self, dc, clus=None):
 """
 pass
 
+def create_datacenter(self, dcname=None, service_instance=None, 
folder=None):
+"""
+Creates a new datacenter with the given name.
+Any % (percent) character used in this name parameter must be 
escaped,
+unless it is used to start an escape sequence. Clients may also 
escape
+any other characters in this name parameter.
+
+An entity name must be a non-empty string of
+less than 80 characters. The slash (/), backslash (\) and percent 
(%)
+will be escaped using the URL syntax. For example, %2F
+
+This can raise the following exceptions:
+vim.fault.DuplicateName
+vim.fault.InvalidName
+vmodl.fault.NotSupported
+vmodl.fault.RuntimeFault
+ValueError raised if the name len is > 79
+https://github.com/vmware/pyvmomi/blob/master/docs/vim/Folder.rst
+
+Required Privileges
+Datacenter.Create
+
+:param folder: Folder object to create DC in. If None it will 
default to
+   rootFolder
+:param dcname: Name for the new datacenter.
+:param service_instance: ServiceInstance connection to a given 
vCenter
+:return:
+"""
+if len(dcname) > 79:
+raise ValueError("The name of the datacenter must be under "
+ "80 characters.")
+
+if folder is None:
+folder = self.service_instance.content.rootFolder
+
+if folder is not None and isinstance(folder, vim.Folder):
+dc_moref = folder.CreateDatacenter(name=dcname)
--- End diff --

Hello @sanju1010 
Is it necessary to double check if folder is not None here? Also you 
mentioned some restrictions for the dcname, shouldnt they also raise and 
ValueError?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack' org

[Will Stevens]

Thank you. Will do.
On Apr 5, 2016 6:38 PM, "Chris Mattmann"  wrote:

> Hey Will, I’m not on the infra@ team, but I am a board member
> and have provided by +1 and support (and I think there is general
> support there informally).
>
> However, I would point you at recent threads related to expanding
> the MATT experiment that have surfaced on board@ in recent days
> and I would raise an infrastruct...@apache.org email there to
> discuss.
>
> Cheers,
> Chris
>
>
>
> On 4/5/16, 6:34 PM, "Will Stevens"  wrote:
>
> >So this topic has been very slow moving, so I will keep pushing this
> along.
> >
> >
> >@Chris, are you on the ASF Infra team?  From your perspective are we
> missing anything to move forward?
> >
> >
> >@Sam & David, is there anything else I need to do from the ASF side other
> than working out the logistics with the Infra team?
> >
> >
> >Thanks everyone...
> >
> >
> >On Thu, Mar 31, 2016 at 2:04 PM, Will Stevens
> > wrote:
> >
> >No problem.  I will try to keep you CC'ed with this email so you can
> contribute.  :)
> >
> >On Thu, Mar 31, 2016 at 1:55 PM, Chris Mattmann
> > wrote:
> >
> >thanks if possible if you could CC my apache email I’d appreciate it
> >on those threads so I can contribute.
> >
> >
> >
> >-Original Message-
> >From: Will Stevens 
> >Date: Thursday, March 31, 2016 at 10:47 AM
> >To: jpluser 
> >Cc: Sam Ruby , David Nalley ,
> >"dev@cloudstack.apache.org" 
> >Subject: Re: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack'
> >org
> >
> >>Conversation moved to dev@ so everyone has better visibility.  Thanks
> for
> >>the feedback Chris...  :)
> >>
> >>
> >>On Thu, Mar 31, 2016 at 1:45 PM, Chris Mattmann
> >> wrote:
> >>
> >>None here on my part, and thanks for direct CC. The cloudstack dev
> >>email was such that I had to unsubscribe, but I have been monitoring
> >>the conversation.
> >>
> >>I am OK with the below plan from my end.
> >>
> >>Thanks Will. BTW, I don’t see anything private in particular, so
> >>moving this to dev@ ASAP would be welcomed.
> >>
> >>Cheers,
> >>Chris
> >>
> >>
> >>
> >>-Original Message-
> >>From: Will Stevens 
> >>Date: Thursday, March 31, 2016 at 10:26 AM
> >>To: Sam Ruby , David Nalley ,
> >>jpluser , "priv...@cloudstack.apache.org"
> >>
> >>Subject: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack' org
> >>
> >>>This could potentially happen on dev@, but since this thread is
> >>>specifically for the logistics of the move, I figure it makes the most
> >>>sense to do on the private@ thread to start with.  If we want to move
> >>>this conversation to dev@, I am ok with
> >>> that happening at any point.
> >>>
> >>>
> >>>We have had a vote on this move and we had unanimous support for the
> move
> >>>inside the ACS community.  Now for the more delicate process of actually
> >>>making it happen.
> >>>
> >>>
> >>>Sam and David, I am going to defer to you guys quite a bit in this
> >>>conversation as you have the best understanding of how things work at
> the
> >>>ASF, so you are in the best position to advise on the buttons to press
> >>>and the ones not to.
> >>>
> >>>
> >>>Please CC anyone into this conversation who you feel should be involved.
> >>>As more people get involved I will do my best to keep everyone up to
> >>>speed with the goal, our progress, and address people's concerns.
> >>>
> >>>
> >>>I believe we need to primarily work with the ASF Infra team, but there
> >>>may be other people that we need to bring in.  Please advise on this.
> >>>
> >>>
> >>>Our current progress:
> >>>- All parties are in agreement with the decision to make the move.
> >>>- I have talked to Github support about getting the 'mirror' setup after
> >>>the move.  They said that a user who has admin access to both
> >>>organizations can email after the transfer and they will setup the
> mirror
> >>>for us.
> >>>- I have setup the 'apache-cloudstack' github organization.
> >>>- I have add Sam, Chris and David (as well as some PMC members) as
> owners
> >>>of the 'apache-cloudstack' org.
> >>>
> >>>
> >>>Please advise if I should add others as owners of the
> 'apache-cloudstack'
> >>>github organization.
> >>>
> >>>
> >>>I think that is it for this initial email.  Lets get the ball rolling
> and
> >>>make this a reality.  :)
> >>>
> >>>
> >>>Please voice any questions or concerns so we can resolve them openly.
> >>>
> >>>
> >>>Cheers,
> >>>
> >>>
> >>>Will
> >>>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
>
>

Re: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack' org

[Chris Mattmann]

Hey Will, I’m not on the infra@ team, but I am a board member
and have provided by +1 and support (and I think there is general
support there informally).

However, I would point you at recent threads related to expanding
the MATT experiment that have surfaced on board@ in recent days
and I would raise an infrastruct...@apache.org email there to
discuss.

Cheers,
Chris



On 4/5/16, 6:34 PM, "Will Stevens"  wrote:

>So this topic has been very slow moving, so I will keep pushing this along.  
>
>
>@Chris, are you on the ASF Infra team?  From your perspective are we missing 
>anything to move forward?
>
>
>@Sam & David, is there anything else I need to do from the ASF side other than 
>working out the logistics with the Infra team?
>
>
>Thanks everyone...
>
>
>On Thu, Mar 31, 2016 at 2:04 PM, Will Stevens 
> wrote:
>
>No problem.  I will try to keep you CC'ed with this email so you can 
>contribute.  :)
>
>On Thu, Mar 31, 2016 at 1:55 PM, Chris Mattmann 
> wrote:
>
>thanks if possible if you could CC my apache email I’d appreciate it
>on those threads so I can contribute.
>
>
>
>-Original Message-
>From: Will Stevens 
>Date: Thursday, March 31, 2016 at 10:47 AM
>To: jpluser 
>Cc: Sam Ruby , David Nalley ,
>"dev@cloudstack.apache.org" 
>Subject: Re: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack'
>org
>
>>Conversation moved to dev@ so everyone has better visibility.  Thanks for
>>the feedback Chris...  :)
>>
>>
>>On Thu, Mar 31, 2016 at 1:45 PM, Chris Mattmann
>> wrote:
>>
>>None here on my part, and thanks for direct CC. The cloudstack dev
>>email was such that I had to unsubscribe, but I have been monitoring
>>the conversation.
>>
>>I am OK with the below plan from my end.
>>
>>Thanks Will. BTW, I don’t see anything private in particular, so
>>moving this to dev@ ASAP would be welcomed.
>>
>>Cheers,
>>Chris
>>
>>
>>
>>-Original Message-
>>From: Will Stevens 
>>Date: Thursday, March 31, 2016 at 10:26 AM
>>To: Sam Ruby , David Nalley ,
>>jpluser , "priv...@cloudstack.apache.org"
>>
>>Subject: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack' org
>>
>>>This could potentially happen on dev@, but since this thread is
>>>specifically for the logistics of the move, I figure it makes the most
>>>sense to do on the private@ thread to start with.  If we want to move
>>>this conversation to dev@, I am ok with
>>> that happening at any point.
>>>
>>>
>>>We have had a vote on this move and we had unanimous support for the move
>>>inside the ACS community.  Now for the more delicate process of actually
>>>making it happen.
>>>
>>>
>>>Sam and David, I am going to defer to you guys quite a bit in this
>>>conversation as you have the best understanding of how things work at the
>>>ASF, so you are in the best position to advise on the buttons to press
>>>and the ones not to.
>>>
>>>
>>>Please CC anyone into this conversation who you feel should be involved.
>>>As more people get involved I will do my best to keep everyone up to
>>>speed with the goal, our progress, and address people's concerns.
>>>
>>>
>>>I believe we need to primarily work with the ASF Infra team, but there
>>>may be other people that we need to bring in.  Please advise on this.
>>>
>>>
>>>Our current progress:
>>>- All parties are in agreement with the decision to make the move.
>>>- I have talked to Github support about getting the 'mirror' setup after
>>>the move.  They said that a user who has admin access to both
>>>organizations can email after the transfer and they will setup the mirror
>>>for us.
>>>- I have setup the 'apache-cloudstack' github organization.
>>>- I have add Sam, Chris and David (as well as some PMC members) as owners
>>>of the 'apache-cloudstack' org.
>>>
>>>
>>>Please advise if I should add others as owners of the 'apache-cloudstack'
>>>github organization.
>>>
>>>
>>>I think that is it for this initial email.  Lets get the ball rolling and
>>>make this a reality.  :)
>>>
>>>
>>>Please voice any questions or concerns so we can resolve them openly.
>>>
>>>
>>>Cheers,
>>>
>>>
>>>Will
>>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>

Re: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack' org

[Will Stevens]

So this topic has been very slow moving, so I will keep pushing this along.


@Chris, are you on the ASF Infra team?  From your perspective are we
missing anything to move forward?

@Sam & David, is there anything else I need to do from the ASF side other
than working out the logistics with the Infra team?

Thanks everyone...

On Thu, Mar 31, 2016 at 2:04 PM, Will Stevens 
wrote:

> No problem.  I will try to keep you CC'ed with this email so you can
> contribute.  :)
>
> On Thu, Mar 31, 2016 at 1:55 PM, Chris Mattmann 
> wrote:
>
>> thanks if possible if you could CC my apache email I’d appreciate it
>> on those threads so I can contribute.
>>
>>
>>
>> -Original Message-
>> From: Will Stevens 
>> Date: Thursday, March 31, 2016 at 10:47 AM
>> To: jpluser 
>> Cc: Sam Ruby , David Nalley ,
>> "dev@cloudstack.apache.org" 
>> Subject: Re: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack'
>> org
>>
>> >Conversation moved to dev@ so everyone has better visibility.  Thanks
>> for
>> >the feedback Chris...  :)
>> >
>> >
>> >On Thu, Mar 31, 2016 at 1:45 PM, Chris Mattmann
>> > wrote:
>> >
>> >None here on my part, and thanks for direct CC. The cloudstack dev
>> >email was such that I had to unsubscribe, but I have been monitoring
>> >the conversation.
>> >
>> >I am OK with the below plan from my end.
>> >
>> >Thanks Will. BTW, I don’t see anything private in particular, so
>> >moving this to dev@ ASAP would be welcomed.
>> >
>> >Cheers,
>> >Chris
>> >
>> >
>> >
>> >-Original Message-
>> >From: Will Stevens 
>> >Date: Thursday, March 31, 2016 at 10:26 AM
>> >To: Sam Ruby , David Nalley ,
>> >jpluser , "priv...@cloudstack.apache.org"
>> >
>> >Subject: [LOGISTICS] Move 'apache/cloudstack' to 'apache-cloudstack' org
>> >
>> >>This could potentially happen on dev@, but since this thread is
>> >>specifically for the logistics of the move, I figure it makes the most
>> >>sense to do on the private@ thread to start with.  If we want to move
>> >>this conversation to dev@, I am ok with
>> >> that happening at any point.
>> >>
>> >>
>> >>We have had a vote on this move and we had unanimous support for the
>> move
>> >>inside the ACS community.  Now for the more delicate process of actually
>> >>making it happen.
>> >>
>> >>
>> >>Sam and David, I am going to defer to you guys quite a bit in this
>> >>conversation as you have the best understanding of how things work at
>> the
>> >>ASF, so you are in the best position to advise on the buttons to press
>> >>and the ones not to.
>> >>
>> >>
>> >>Please CC anyone into this conversation who you feel should be involved.
>> >>As more people get involved I will do my best to keep everyone up to
>> >>speed with the goal, our progress, and address people's concerns.
>> >>
>> >>
>> >>I believe we need to primarily work with the ASF Infra team, but there
>> >>may be other people that we need to bring in.  Please advise on this.
>> >>
>> >>
>> >>Our current progress:
>> >>- All parties are in agreement with the decision to make the move.
>> >>- I have talked to Github support about getting the 'mirror' setup after
>> >>the move.  They said that a user who has admin access to both
>> >>organizations can email after the transfer and they will setup the
>> mirror
>> >>for us.
>> >>- I have setup the 'apache-cloudstack' github organization.
>> >>- I have add Sam, Chris and David (as well as some PMC members) as
>> owners
>> >>of the 'apache-cloudstack' org.
>> >>
>> >>
>> >>Please advise if I should add others as owners of the
>> 'apache-cloudstack'
>> >>github organization.
>> >>
>> >>
>> >>I think that is it for this initial email.  Lets get the ball rolling
>> and
>> >>make this a reality.  :)
>> >>
>> >>
>> >>Please voice any questions or concerns so we can resolve them openly.
>> >>
>> >>
>> >>Cheers,
>> >>
>> >>
>> >>Will
>> >>
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>>
>>
>>
>

Re: [ACP Doctor] What is it?

[Will Stevens]

It used to be CCP Doctor and it is not in ACS from my understanding.  It is
a set of scripts that will do basic validation of a CloudStack setup.  It
does things like verify the system VMs are running and the connectivity is
working between all of the systems.  It also does some checking to make
sure the versions of software is correct and checks some things in the DB
as well.  It also collects a whole crap ton of logs and database dumps (i
think) and zips them up for easy transfer to support so they can get a
solid feel for your setup.

It also has 'suggestions' for things you can do to fix different aspects of
your setup.  Things like setting 'ulimit' to 'unlimited' and will give you
the command to run.  It also lets you pass a 'fix' flag and it will
automagically make all the changes for you.  I am too paranoid to have
actually used the fix flag because I was always using this in production
environments and I am a little too risk averse to let a script do anything
for me (unless I wrote it).

Does that answer your question?  It should be freely available and you
should be able to run it against ACS, so you should be able to try it
out...

It is a pretty useful tool to be honest.  Especially if you are
troubleshooting an environment you didn't setup.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Apr 5, 2016 at 5:28 PM, ilya  wrote:

> Saw ACP Doctor in CCP release notes from Accelerite.
>
> Curious what it is, is it integrated into cloudstack or collection of
> shell scripts?
>
> Thanks
> ilya
>

[ACP Doctor] What is it?

[ilya]

Saw ACP Doctor in CCP release notes from Accelerite.

Curious what it is, is it integrated into cloudstack or collection of
shell scripts?

Thanks
ilya

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1332#issuecomment-205981012
  
Sure @swill . I've sqashed them


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1463#issuecomment-205968247
  
I replayed the functionality tested in the second test and it is working. 
Will have to look into the test code to see what is happening.

retesting the first one now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-205968363
  
Well, if this PR gets merged, I do not know much how we can close the PR 
#561. Maybe @swill  or @DaanHoogland  can help with that.

Now the code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-205949475
  
Thanks, Will!

On Apr 5, 2016, at 12:35 PM, Will Stevens 
> wrote:


I will get CI run against this PR as soon as I have my CI reinstalled. 
Thanks @mike-tutkowski

-
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-205937640
  
I will get CI run against this PR as soon as I have my CI reinstalled.  
Thanks @mike-tutkowski 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-205932840
  
@rafaelweingartner now this commit is not cherry-picked from the 
commit (b9181c689e0e7b5f1e28c81d73710196dfabd0ba). When this PR be merged 
(or closed), it will be necessary to close the PR 
.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1332#issuecomment-205926253
  
@syed can you squash the commits.  This is best applied as a single commit. 
 Thx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1332#issuecomment-205922970
  
@bvbharatk it looks to be a problem with the test. Volume creation should 
work irrespective of my changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1457#issuecomment-205917619
  
thanks @rafaelweingartner and @swill !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1463#issuecomment-205909585
  
two failures. they seem unrelated but double ckecking

[1463.results.network.txt](https://github.com/apache/cloudstack/files/205002/1463.results.network.txt)

[1463.results.vpc_routers.txt](https://github.com/apache/cloudstack/files/205003/1463.results.vpc_routers.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1457#issuecomment-205892175
  
Perfect.  Thank you both for verifying this.  I probably won't be able to 
get to testing this till tomorrow evening because I am about to reinstall my CI 
to get my tests running on SSD drives.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1454#issuecomment-205892559
  
@abhinandanprateek slight delay.  I am going to blow away my CI setup and 
reinstall it now to get it running on SSD drives so I can better parallelize my 
tests.  This will delay this test till at least tomorrow evening. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1457#issuecomment-205885858
  
Good question, those changes affect every single hypervisor. 
I have reviewed the code and after that I can say that if those changes 
work for KVM, I see no reason not to work for VMware, XenServer and others. In 
my opinion that would be enough.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1454#issuecomment-205885703
  
@abhinandanprateek: Thank you.  I will run the whole set of tests against 
it again tonight.  I have to let the current tests finish and run this on its 
own because I have to change the tests run specifically for this PR.  I should 
have results in the morning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1457#issuecomment-205883002
  
@rafaelweingartner I can run tests via KVM, but I don't have the ability to 
run tests against VMware hardware.  Are tests against KVM good enough in this 
case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1457#issuecomment-205882042
  
For me everything (with the code) is ok now, LGTM for the PR.
Could you please run functional tests?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-205867477
  
@DaanHoogland feel free to split this however you feel, I've already moved 
the Travis fix to a separate PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1457#issuecomment-205857772
  
@rafaelweingartner cool! I added it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1413#issuecomment-205831656
  
Thank you. I've raised CLOUDSTACK-9339 on Jira about the non-VPC RvR 
issues. As my company needs those issues solved in the short term I'll begin 
working on a fix from the 4.7 branch.

If that fix is later useful upstream then I shall create a PR. If I need to 
re-work things from a different branch then I'll be happy to do so subsequently


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1413#issuecomment-205820963
  
@dsclose This bug exists as far back as 4.6 I believe, as that was when RvR 
for VPC was introduced. So you might want base your patch on 4.7 and then it 
can be pulled into later releases.

Gentlemen,

@wilderrodrigues  @remibergsma  @ustcweizhou @DaanHoogland @swill 

How do you guys want to handle this. Should Dean base his PR on top of 
Wilders rebase, or are you guys going to collaborate on a solution?

- Si


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

[Dean Close]

Thank you, I'm going to raise a separate bug report about the issues I've found 
with RvR setups. If I work on a patch I'll fork from the master branch unless I 
hear otherwise.

Dean

-Original Message-
From: kiwiflyer [mailto:g...@git.apache.org] 
Sent: 05 April 2016 14:28
To: dev@cloudstack.apache.org
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac 
address ...

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1413#issuecomment-205804779
  
@dsclose  - just FYI. As far as I'm aware, this PR has not been committed 
yet. @ustcweizhou has requested a new PR/rebase.

I just pulled these into our build tree last night, so I was going to start 
testing it as well.


---
If your project is set up for it, you can reply to this email and have your 
reply appear on GitHub as well. If your project does not have this feature 
enabled and wishes so, or if the feature is enabled but not working, please 
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with 
INFRA.
---

[GitHub] cloudstack pull request: speedup iptables setup

[kollyma]

Github user kollyma commented on the pull request:

https://github.com/apache/cloudstack/pull/1449#issuecomment-205809122
  
@Swill: tried to squash the commits shortly from holidays. Did not worked 
as expected, messed up my PR. I need to debug this when I am back next week...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1413#issuecomment-205804779
  
@dsclose  - just FYI. As far as I'm aware, this PR has not been committed 
yet. @ustcweizhou has requested a new PR/rebase.

I just pulled these into our build tree last night, so I was going to start 
testing it as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

jenkins restart

[Daan Hoogland]

sorry for not giving prior notice. I am updating plugins on
jenkins.buildacloud.org. It will restart.

-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

[abhinandanprateek]

Github user abhinandanprateek commented on the pull request:

https://github.com/apache/cloudstack/pull/1454#issuecomment-205780575
  
Updated marvin test to use the builtin template. @swill 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9337]Enhance vcenter.py to cr...

[sanju1010]

GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/1464

[CLOUDSTACK-9337]Enhance vcenter.py to created data center in vcenter 
server automatically

These changes have been made to support vmware deployments in CI. 
For CI to create cloudstack setup with vmware, it is required to create 
datacenter, cluster and hosts in vcenter server before adding in cloudstack. 
Added few methods in vcenter.py to perform these tasks.

Please refer to CLOUDSTACK-9337 for more details.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack vcenter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1464


commit 8daaa30fc895b2e54bf4adaea01429008c5b368a
Author: sanjeevn 
Date:   2016-03-21T12:52:08Z

[CLOUDSTACK-9337]Enhance vcenter.py to created data center in vcenter 
server automatically
(Programmatically)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/1463

CLOUDSTACK-9336 surround the execution of baremetal-vr.py with condition



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9336

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1463.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1463


commit 2a88b11132780a2adba63de519e4c459ee7c3cea
Author: dahn 
Date:   2016-04-05T11:28:39Z

CLOUDSTACK-9336 surround the execution of baremetal-vr.py with condition




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1463#issuecomment-205763867
  
integration tests pending


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-205755861
  
Thanks @DaanHoogland, I will check on that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-205755506
  
@bhaisaab I'm kind of confused, you write about three parts but I count 
four. I would agree that the bouncy castle is a completely seperate one. I 
think mvn changes would include any changes made by me, right? So then we are 
down to three again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [QUESTION] baremetal router

[Daan Hoogland]

thakns Hari, I'll make a small pr for putting the baremetal-vr.py under a
condition.

On Tue, Apr 5, 2016 at 11:10 AM, Harikrishna Patnala <
harikrishna.patn...@accelerite.com> wrote:

> Hi Daan,
>
> Yes, this should run only in Virtual Router. Instead of moving it to
> existing “if” block, better to have a seperate check only for normal
> router, since we don’t support baremetal deployment in VPC.
>
> Regarding the later question, with the current implementation I don’t
> think we can distinguish whether PXE service enabled on the router or not,
> or we can also initiate this agent on VR from management server using
> sshCmdHelper just before deploying the baremetal instance.
>
> Regards,
> Harikrishna
>
>
> On 30-Mar-2016, at 5:26 pm, Daan Hoogland  wrote:
>
> > People,
> >
> > in the following code the baremetal-vr.py configuration script is started
> > unconditionally, this means it will be started on ssvm and cpvm as well.
> > but also on virtual routervms;
> >
> >
> > CMDLINE=$(cat /var/cache/cloud/cmdline)
> > router=$(echo "$CMDLINE" | grep -o  type=router)
> > vpcrouter=$(echo "$CMDLINE" | grep -o  type=vpcrouter)
> >
> > if [ "$router" != "" ] ||  [ "$vpcrouter" != "" ]
> > then
> >   echo 100 > /proc/sys/net/ipv4/netfilter/ip_conntrack_max
> >   echo 100 > /proc/sys/net/netfilter/nf_conntrack_max
> >   echo 100 > /proc/sys/net/nf_conntrack_max
> > fi
> >
> > python /opt/cloud/bin/baremetal-vr.py &
> >
> >
> > Does it make sense to at least move it inside the if block above so it is
> > only started on routers?
> > Or does anybody know how to distinguish that we are running on baremetal
> > and guard for that condition?
> >
> > --
> > Daan
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>



-- 
Daan

Re: monday morning reading

[Wido den Hollander]

> Op 4 april 2016 om 9:28 schreef Daan Hoogland :
> 
> 
> H, for those interested in how we get to improve, here is something I
> stumbled upon on reddit [1]
> 
> I must admit I think most of us are already working as described but
> still,... it touches on some of the pitfalls we have been tripping in as a
> project as well.
> 

Thanks! Interesting read indeed :)

The three points they highlight are very true. What I think is good to know is
that using textual conversations between humans usually lack context. Always
keep that in mind.

Wido

> ​[1] : https://10kloc.wordpress.com/2016/04/03/effective-code-reviews/​
> 
> -- 
> Daan

Re: [QUESTION] baremetal router

[Harikrishna Patnala]

Hi Daan,

Yes, this should run only in Virtual Router. Instead of moving it to existing 
“if” block, better to have a seperate check only for normal router, since we 
don’t support baremetal deployment in VPC.

Regarding the later question, with the current implementation I don’t think we 
can distinguish whether PXE service enabled on the router or not, or we can 
also initiate this agent on VR from management server using sshCmdHelper just 
before deploying the baremetal instance.

Regards,
Harikrishna


On 30-Mar-2016, at 5:26 pm, Daan Hoogland  wrote:

> People,
>
> in the following code the baremetal-vr.py configuration script is started
> unconditionally, this means it will be started on ssvm and cpvm as well.
> but also on virtual routervms;
>
>
> CMDLINE=$(cat /var/cache/cloud/cmdline)
> router=$(echo "$CMDLINE" | grep -o  type=router)
> vpcrouter=$(echo "$CMDLINE" | grep -o  type=vpcrouter)
>
> if [ "$router" != "" ] ||  [ "$vpcrouter" != "" ]
> then
>   echo 100 > /proc/sys/net/ipv4/netfilter/ip_conntrack_max
>   echo 100 > /proc/sys/net/netfilter/nf_conntrack_max
>   echo 100 > /proc/sys/net/nf_conntrack_max
> fi
>
> python /opt/cloud/bin/baremetal-vr.py &
>
>
> Does it make sense to at least move it inside the if block above so it is
> only started on routers?
> Or does anybody know how to distinguish that we are running on baremetal
> and guard for that condition?
>
> --
> Daan




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: Redundant Router Interfaces

[Dean Close]

Hi Wei,

Have you noticed the PR #1413 at https://github.com/apache/cloudstack/pull/1413 
? The commit at 
https://github.com/apache/cloudstack/commit/8bbea5eeb6598b213b78a324c184841dbba69280
 changes the check_is_up method considerably such that your patch would 
no-longer apply.

That PR #1413 focuses on VPC router functionality but it raises a number of 
other concerns for normal RvR routers:


  1. We mentioned the conflict between the code in your patch and the commit at 
8bbea5
  2. Redundant routers can have multiple public interfaces. Eth2 is just the 
public interface where IPs on the same subnet as the source-NAT IP are 
assigned. When a public IP on a different subnet is assigned to a router it 
creates a new interface for that subnet, eth3, eth4, etc. The commit 11e61f7 in 
PR #1413 does not account for this.
  3. If we solve the issue with check_is_up not bringing up public interfaces, 
we need to consider that public interfaces may be created on RvRs after they 
have become master. Because the keepalived notify script will not be executed 
(no transition) these new interfaces will remain DOWN until a failover is 
triggered. From the user's perspective, these newly assigned IPs just won't 
work until they restart their network.
  4. Once the interface is brought up IP addresses assigned to it still won't 
work. Two IP tables rules are missing for the new interface to allow inbound 
traffic. Once those rules are added, inbound static-NAT and port-forwarding 
traffic works. Outbound static-NAT, however, does not work and gets NAT'd to 
the source-NAT IP. This is because of the connmark given to any traffic from 
the guest network. This connmark matches an IP rule trying to route such 
traffic over eth0. Public IP traffic can't go via eth0, however, so it is 
routed via the default gateway, via the source-NAT IP, on eth2.


I'd like to help with points 3 and 4 but it's not clear to me which version of 
the code should be considered 'current'. Have you noticed these issues being 
discussed elsewhere?

Dean


-Original Message-
From: Dean Close [mailto:dean.cl...@icloudhosting.com] 
Sent: 04 April 2016 14:36
To: dev@cloudstack.apache.org
Subject: RE: Redundant Router Interfaces

Hi Wei,

I implemented your modifications on a test cloud we have here and it worked 
well. Redundant routers in the backup state booted with public interfaces down.

As you said, they also negotiated the VRRP instance over eth0 which is correct.

As an aside, regarding the following code:

if self.cl.is_redundant() and (not self.is_public() or 
(self.config.is_vpc() and self.getDevice() not in VPC_PUBLIC_INTERFACE)):

I expanded this out to help me make sense of the logic. I also disposed of the 
preceding comment block as it was misleading in non-VPC contexts. The full 
block I'm running here is:

# if not redundant bring everything up
if not self.cl.is_redundant():
CsHelper.execute(cmd2)
# Otherwise only bring up non-public interfaces
elif self.cl.is_redundant() and self.config.is_vpc() and \
(self.getDevice() not in VPC_PUBLIC_INTERFACE):
CsHelper.execute(cmd2)
elif self.cl.is_redundant() and not self.is_public():
CsHelper.execute(cmd2)


Dean

-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: 02 April 2016 07:02
To: dev@cloudstack.apache.org
Subject: Re: Redundant Router Interfaces

Hi Dean,

the VRRP instance will be set to eth0 (guest device) in router, and eth2 (the 
first guest device ) in vpc router. I think it is good.

-Wei

2016-04-02 0:22 GMT+02:00 Dean Close :

> Hi Wei,
>
> It looks like your patch will prevent redundant routers from bringing 
> up public interfaces. We also need to:
>
> 1. shift the VRRP instance over to eth0 as eth2 will be down on the backup.
> 2. Ensure that eth0 and eth1 are up on both redundant virtual routers.
>
> Your patch might already solve point 2. What do you think?
>
> Point 1 will require modifying the keepalived.conf template. Do you 
> want to handle this in your PR or shall I arrange that?
>
> Kind Regards,
>
> Dean Close
> iCloudHosting.com
> http://www.icloudhosting.com
> Tel: 01582 227927
>
> Spectrum House, Dunstable Road, Redbourn, AL3 7PR
>
>
> **
>
> The names iCloudHosting and iCloudHosting.com are trading styles of 
> BBS Commerce Ltd which is registered in England and Wales, Company 
> Number 04837714. Please use our trading address above for mail. Our 
> registered office is 5 Theale Lakes Business Park, Moulden Way, 
> Sulhamstead, Reading, Berkshire, RG7 4GB. VAT Registration Number GB 982 8230 
> 94.
>
> This email and any files transmitted with it are confidential and 
> intended solely for the use of the individual or entity to whom they are 
> addressed.
> If you 

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1413#issuecomment-205716220
  
@wilderrodrigues @ustcweizhou Sorry to arrive late to the party but this 
appears to break/ignore some RvR functionality. 4 things in particular stand 
out:

1. All public interfaces should be down in both redundanant virtual 
routers. Non-public interfaces should be up. The master.py script will bring up 
public interfaces on master routers. I had been discussing this with 
@ustcweizhou on the Cloudstack mailing list, Wei had provided a solution based 
upon the check_is_up method of the CsIP class (in CsAddress.py) but the commit 
at 8bbea5eeb6598b213b78a324c184841dbba69280 in #1413 appears to contradict what 
we discussed.
2. Redundant virtual routers can have multiple public interfaces. 
Presumably, so can VPC routers - although I've not experimented with that. The 
source-NAT IP will be assigned to eth2 - as will any public IP on the same 
subnet. Public IPs on different subnets will be assigned to eth3, eth4, eth5 
etc. with a new device being created for each separate subnet. The commit 
11e61f7054234e17343e9a11948f1804d732ac6c in #1413 does not account for this.
3. Because of point 2, we know that a new interface will be created on an 
RvR when an IP on a new subnet is assigned to it. Because of point 1, we know 
that that interface will be down because the master.py script will not have run 
since it was created. Currently a failover must be induced before this 
interface will be brought up - I'm yet to address this issue because of point 
4, next.
4. Currently static-NATs do not work on RvR setup when they are on a 
different subnet to the source-NAT IP. There are two reasons for this; one is 
missing iptables config allowing traffic across interfaces other than eth2. The 
second reason is that connmarks are being assigned to outbound traffic from 
eth0 (guest network) which are being used to match traffic to an interface in 
the IP rules. Traffic intended for a public network therefore gets routed out 
of the default gateway interface (eth2), breaking any static-NAT traffic on 
public IPs not assigned to eth2.

I'd like to contribute to points 3 and 4 but issue #1413 appears to have 
been marked as closed. To remedy these points I might need to overwrite code 
committed as part of this issue, so it seems best to start a conversation about 
it before rolling the sleeves up and getting stuck in.

Are these issues being considered else where?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-205715741
  
the other one is persistant i'm afraid: 

[1459.results.vpc_redundant.txt](https://github.com/apache/cloudstack/files/204056/1459.results.vpc_redundant.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1460#issuecomment-205705013
  
@jburwell the failure is not in rat but in the unit tests for the secondary 
storage controller project


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Hooking into the SecurityGroups

[Nux!]

Thanks Jayapal!

I won't propose this change as a pull request since this is a pretty custom job.

Myipset (with a different name) will include all our data centre (AS) subnets, 
the end result being that with a simple "iptables-save -c" I can now know what 
traffic was done against our data centre as well as global traffic; then with 
simple arithmetic I can calculate exactly the amount of traffic done outside 
our networks. e.g.

iptables-save -c |grep -i vnet0
[542306:28257982] -A BF-breth0-109-IN -m physdev --physdev-in vnet0 
--physdev-is-bridged -m set --match-set myipset dst 
[719558:37497155] -A BF-breth0-109-IN -m physdev --physdev-in vnet0 
--physdev-is-bridged -j i-2-38-def 
[562386:3982131066] -A BF-breth0-109-OUT -m physdev --physdev-out vnet0 
--physdev-is-bridged -m set --match-set myipset src 
[765296:5230761832] -A BF-breth0-109-OUT -m physdev --physdev-out vnet0 
--physdev-is-bridged -j i-2-38-def
...

Logging and graphing this is another adventure, but I'm glad I got the 
Cloudstack bit done, unless anyone else wants to point to some horrible 
mistake. :)

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Jayapal Uradi" 
> To: dev@cloudstack.apache.org
> Sent: Tuesday, 5 April, 2016 06:00:19
> Subject: Re: Hooking into the SecurityGroups

> Hi Nux,
> 
> I think ipset ‘myipset’ changes might be there in other commits. If you do not
> have special requirement then you can use the existing ipset which is with the
> vmname ex: i-2-3-VM. Except this it looks good to me.
> 
> 
> Thanks,
> Jayapal
> 
> 
>> On 04-Apr-2016, at 10:17 pm, Nux!  wrote:
>> 
>> Well, this is what we got working in the end. If someone has any suggestions 
>> on
>> how to improve it, that'd be great.
>> 
>> https://github.com/NuxRo/cloudstack/commit/de6f97367fc2dc02378f367c462eaaec8f92e234
>> 
>> --
>> Sent from the Delta quadrant using Borg technology!
>> 
>> Nux!
>> www.nux.ro
>> 
>> - Original Message -
>>> From: "Nux!" 
>>> To: "dev" 
>>> Sent: Friday, 1 April, 2016 11:42:10
>>> Subject: Hooking into the SecurityGroups
>> 
>>> Hi,
>>> 
>>> I want to hook into the SGs and add a few iptables rules every time a VM is
>>> spawned and delete them when the VM is moved/deleted.
>>> Has anyone done this before? Any pointers before I go and butcher it? :-)
>>> 
>>> Lucian
>>> 
>>> --
>>> Sent from the Delta quadrant using Borg technology!
>>> 
>>> Nux!
>>> www.nux.ro
> 
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the
> property of Accelerite, a Persistent Systems business. It is intended only for
> the use of the individual or entity to which it is addressed. If you are not
> the intended recipient, you are not authorized to read, retain, copy, print,
> distribute or use this message. If you have received this communication in
> error, please notify the sender and delete all copies of this message.
> Accelerite, a Persistent Systems business does not accept any liability for
> virus infected mails.

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-205684941
  
the first one wwas a false positive:

[1459.results.password.txt](https://github.com/apache/cloudstack/files/203940/1459.results.password.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1417#issuecomment-205684992
  
LGTM based on the code review !!

Please squash the commits into single commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1459#issuecomment-205679998
  
@GabrielBrascher I ran the regression suite as defined by SBP and found two 
failures. I am rerunning them individually to see if I can find out some more. 
Here's the output:

[1459.results.network.txt](https://github.com/apache/cloudstack/files/203927/1459.results.network.txt)

[1459.results.vpc.txt](https://github.com/apache/cloudstack/files/203926/1459.results.vpc.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

[abhinandanprateek]

Github user abhinandanprateek commented on the pull request:

https://github.com/apache/cloudstack/pull/1454#issuecomment-205672352
  
On comparing test execution times with macchinina Vs Centos builtin 
template I did not find much of a difference. So modifying the test to go with 
the standard builtin templates. @swill 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1462#issuecomment-205671313
  
Thanks @terbolous, fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---