[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/669#issuecomment-221780994
  
@swill Resolved the merge conflicts. They were because of import statements.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9388: Remove string conversion...

[pavanb018]

Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/1561#issuecomment-221780495
  
Very small change , conversion of firewall port to string was not necessary 
and that seems to be removed. Looks Good to me !!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/956


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1494


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1556


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1533


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Refactor system VM default network creati...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1360


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9380: fix NPE in listDomains A...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1550


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1518


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1503


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1424


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1552


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1555


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dynamically load drivers before creating ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1553


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/846


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1410


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-221764160
  
Need code review on this one.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/669#issuecomment-221763988
  
This one needs some work. We have merge conflicts and we need another code 
review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1499#issuecomment-221763535
  
Bump...

@alexandrelimassantana this one has merge conflicts. Can you rebase and fix 
the conflicts? Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1491#issuecomment-221763412
  
This one needs review as well...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1471#issuecomment-221762946
  
Can I get some code review on this one?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1450#issuecomment-221762730
  
CI is clean and everything is green.  I need some code review on this one.  
Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1555#issuecomment-221759242
  
This is ready to merge now.  The issue we are seeing is a known issue not 
related to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1555#issuecomment-221759081
  


### CI RESULTS

```
Tests Run: 82
  Skipped: 0
   Failed: 0
   Errors: 3
 Duration: 8h 37m 16s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_PGNO2P/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_PGNO2P/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_PGNO2P/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_16_44_SKVYEG:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_16_44_SKVYEG/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_16_44_SKVYEG/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_16_44_SKVYEG/runinfo.txt)

**`/tmp/MarvinLogs/test_network_PGNO2P:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_network_PGNO2P/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1555/tmp/MarvinLogs/test_network_PGNO2P/results.txt)
* 

[GitHub] cloudstack pull request: Dynamically load drivers before creating ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1553#issuecomment-221758855
  
This is a known issue, so this one should be ready now.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactoring CitrixResourceBase

[Will Stevens]

cool.  :)

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Wed, May 25, 2016 at 9:45 PM, Syed Mushtaq 
wrote:

> Nope. I think they should all be XenServer (they were Citrix earlier) I
> plan to clean that up too.
>
> -Syed
>
> On Wed, May 25, 2016 at 9:43 PM, Will Stevens 
> wrote:
>
> > Is there a reason some are prefixed with 'Xs' and others are prefixed
> with
> > 'XenServer'?
> > On May 25, 2016 9:41 PM, "Will Stevens" 
> wrote:
> >
> > > Ya. I didn't know either and made the same mistake. :)
> > > On May 25, 2016 9:40 PM, "Syed Mushtaq" 
> wrote:
> > >
> > >> Aah I did not know that. Thanks Will .. here is the link
> > >> http://i.imgur.com/5B55XMB.png
> > >>
> > >> On Wed, May 25, 2016 at 6:37 PM, Will Stevens <
> williamstev...@gmail.com
> > >
> > >> wrote:
> > >>
> > >> > Attachments don't work. You will have to host it publicly and then
> > post
> > >> a
> > >> > link to it.
> > >> > On May 25, 2016 4:28 PM, "Syed Ahmed"  wrote:
> > >> >
> > >> > > Forgot to attach screenshot
> > >> > >
> > >> > > On Wed, May 25, 2016 at 4:09 PM, Syed Ahmed 
> > >> wrote:
> > >> > >
> > >> > >> Thanks Rafael,
> > >> > >>
> > >> > >> Here is how I am doing. You can see the tree in the screenshot
> > >> attached.
> > >> > >> I have started with storage and extracted the storage commands
> out
> > of
> > >> > >> CitrixResourceBase (I've renamed it to XenServerResourceBase).
> This
> > >> is
> > >> > the
> > >> > >> file for refrence. Let me know what you think.
> > >> > >>
> > >> > >>
> > >> > >>
> > >> >
> > >>
> >
> https://github.com/syed/cloudstack/blob/ca2d1469f991727515d9b71a790411d36eb60fdc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/storage/XenServerStorageResource.java
> > >> > >>
> > >> > >> It is a non-trivial refactor so may take some time but I think
> the
> > >> end
> > >> > >> result would be very good for everyone.
> > >> > >>
> > >> > >>
> > >> > >>
> > >> > >> On Wed, May 25, 2016 at 11:22 AM, Rafael Weingärtner <
> > >> > >> rafaelweingart...@gmail.com> wrote:
> > >> > >>
> > >> > >>> Hi Syed,
> > >> > >>> That is a great job.
> > >> > >>> I would only suggest breaking the commons a little bit more
> > between
> > >> > >>> “monitoring” and “common”. On the monitoring side, we could have
> > >> host
> > >> > >>> monitoring, VMs monitoring, VMs' status checks (running,
> stopped,
> > >> and
> > >> > >>> others) and maybe other tasks that aim to monitor/check a
> resource
> > >> > >>> state/information.
> > >> > >>>
> > >> > >>> About the singletons you extracted, I do not see a need for an
> > >> > interface
> > >> > >>> right now (maybe I am overlooking the need); in the future if
> the
> > >> need
> > >> > >>> for
> > >> > >>> interfaces appears, we can create some interfaces and use them
> > into
> > >> the
> > >> > >>> singletons you created.
> > >> > >>>
> > >> > >>>
> > >> > >>> On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq <
> > >> > syed1.mush...@gmail.com>
> > >> > >>> wrote:
> > >> > >>>
> > >> > >>> > Hey Guys,
> > >> > >>> >
> > >> > >>> > To give you an update, I've identified and categorized the
> > >> functions
> > >> > in
> > >> > >>> > CitrixResourceBase into 4 categories
> > >> > >>> >
> > >> > >>> > 1) common: These deal with the host as a whole (example
> > >> getHostInfo,
> > >> > >>> > callPlugin, connection pool  etc)
> > >> > >>> > 2) compute: Dealing with operations on VMs (start,stop,
> reboot,
> > >> > update
> > >> > >>> etc)
> > >> > >>> > 3) storage: Dealing with storage operations (creating VDI,
> > >> attaching
> > >> > >>> to VM,
> > >> > >>> > SR operations)
> > >> > >>> > 4) network: OVS / PIF / VIF operations
> > >> > >>> >
> > >> > >>> > I've created singleton classes for each and slowly moving the
> > >> > >>> functionality
> > >> > >>> > there. These singletons don't have a base class nor do they
> > >> implement
> > >> > >>> an
> > >> > >>> > interface. I don't know what the best practice is. One
> question
> > >> that
> > >> > I
> > >> > >>> have
> > >> > >>> > is, should I create an interface for them or use some existing
> > >> > >>> interface?
> > >> > >>> >
> > >> > >>> > Thanks,
> > >> > >>> > -Syed
> > >> > >>> >
> > >> > >>> >
> > >> > >>> > On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq <
> > >> > syed1.mush...@gmail.com
> > >> > >>> >
> > >> > >>> > wrote:
> > >> > >>> >
> > >> > >>> > > Thanks guys for the Ideas. I will open a JIRA ticket and
> start
> > >> > >>> working on
> > >> > >>> > > it.
> > >> > >>> > >
> > >> > >>> > > -Syed
> > >> > >>> > >
> > >> > >>> > >
> > >> > >>> > > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
> > >> > >>> > > rafaelweingart...@gmail.com> wrote:
> > >> > >>> > >
> > >> > >>> > >> Hi Syed,
> > >> > >>> > >> That is a great idea; 

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/846#issuecomment-221758314
  
This is a cleaner run because this issue is a known issue.  I think this 
one is ready now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/846#issuecomment-221757982
  


### CI RESULTS

```
Tests Run: 82
  Skipped: 0
   Failed: 0
   Errors: 3
 Duration: 8h 33m 42s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_VKMDK0/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_VKMDK0/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_VKMDK0/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_10_57_8DI3FD:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_10_57_8DI3FD/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_10_57_8DI3FD/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/DeployDataCenter__May_25_2016_19_10_57_8DI3FD/runinfo.txt)

**`/tmp/MarvinLogs/test_network_VKMDK0:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/test_network_VKMDK0/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/test_network_VKMDK0/results.txt)
* 

Re: Refactoring CitrixResourceBase

[Syed Mushtaq]

Nope. I think they should all be XenServer (they were Citrix earlier) I
plan to clean that up too.

-Syed

On Wed, May 25, 2016 at 9:43 PM, Will Stevens 
wrote:

> Is there a reason some are prefixed with 'Xs' and others are prefixed with
> 'XenServer'?
> On May 25, 2016 9:41 PM, "Will Stevens"  wrote:
>
> > Ya. I didn't know either and made the same mistake. :)
> > On May 25, 2016 9:40 PM, "Syed Mushtaq"  wrote:
> >
> >> Aah I did not know that. Thanks Will .. here is the link
> >> http://i.imgur.com/5B55XMB.png
> >>
> >> On Wed, May 25, 2016 at 6:37 PM, Will Stevens  >
> >> wrote:
> >>
> >> > Attachments don't work. You will have to host it publicly and then
> post
> >> a
> >> > link to it.
> >> > On May 25, 2016 4:28 PM, "Syed Ahmed"  wrote:
> >> >
> >> > > Forgot to attach screenshot
> >> > >
> >> > > On Wed, May 25, 2016 at 4:09 PM, Syed Ahmed 
> >> wrote:
> >> > >
> >> > >> Thanks Rafael,
> >> > >>
> >> > >> Here is how I am doing. You can see the tree in the screenshot
> >> attached.
> >> > >> I have started with storage and extracted the storage commands out
> of
> >> > >> CitrixResourceBase (I've renamed it to XenServerResourceBase). This
> >> is
> >> > the
> >> > >> file for refrence. Let me know what you think.
> >> > >>
> >> > >>
> >> > >>
> >> >
> >>
> https://github.com/syed/cloudstack/blob/ca2d1469f991727515d9b71a790411d36eb60fdc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/storage/XenServerStorageResource.java
> >> > >>
> >> > >> It is a non-trivial refactor so may take some time but I think the
> >> end
> >> > >> result would be very good for everyone.
> >> > >>
> >> > >>
> >> > >>
> >> > >> On Wed, May 25, 2016 at 11:22 AM, Rafael Weingärtner <
> >> > >> rafaelweingart...@gmail.com> wrote:
> >> > >>
> >> > >>> Hi Syed,
> >> > >>> That is a great job.
> >> > >>> I would only suggest breaking the commons a little bit more
> between
> >> > >>> “monitoring” and “common”. On the monitoring side, we could have
> >> host
> >> > >>> monitoring, VMs monitoring, VMs' status checks (running, stopped,
> >> and
> >> > >>> others) and maybe other tasks that aim to monitor/check a resource
> >> > >>> state/information.
> >> > >>>
> >> > >>> About the singletons you extracted, I do not see a need for an
> >> > interface
> >> > >>> right now (maybe I am overlooking the need); in the future if the
> >> need
> >> > >>> for
> >> > >>> interfaces appears, we can create some interfaces and use them
> into
> >> the
> >> > >>> singletons you created.
> >> > >>>
> >> > >>>
> >> > >>> On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq <
> >> > syed1.mush...@gmail.com>
> >> > >>> wrote:
> >> > >>>
> >> > >>> > Hey Guys,
> >> > >>> >
> >> > >>> > To give you an update, I've identified and categorized the
> >> functions
> >> > in
> >> > >>> > CitrixResourceBase into 4 categories
> >> > >>> >
> >> > >>> > 1) common: These deal with the host as a whole (example
> >> getHostInfo,
> >> > >>> > callPlugin, connection pool  etc)
> >> > >>> > 2) compute: Dealing with operations on VMs (start,stop, reboot,
> >> > update
> >> > >>> etc)
> >> > >>> > 3) storage: Dealing with storage operations (creating VDI,
> >> attaching
> >> > >>> to VM,
> >> > >>> > SR operations)
> >> > >>> > 4) network: OVS / PIF / VIF operations
> >> > >>> >
> >> > >>> > I've created singleton classes for each and slowly moving the
> >> > >>> functionality
> >> > >>> > there. These singletons don't have a base class nor do they
> >> implement
> >> > >>> an
> >> > >>> > interface. I don't know what the best practice is. One question
> >> that
> >> > I
> >> > >>> have
> >> > >>> > is, should I create an interface for them or use some existing
> >> > >>> interface?
> >> > >>> >
> >> > >>> > Thanks,
> >> > >>> > -Syed
> >> > >>> >
> >> > >>> >
> >> > >>> > On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq <
> >> > syed1.mush...@gmail.com
> >> > >>> >
> >> > >>> > wrote:
> >> > >>> >
> >> > >>> > > Thanks guys for the Ideas. I will open a JIRA ticket and start
> >> > >>> working on
> >> > >>> > > it.
> >> > >>> > >
> >> > >>> > > -Syed
> >> > >>> > >
> >> > >>> > >
> >> > >>> > > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
> >> > >>> > > rafaelweingart...@gmail.com> wrote:
> >> > >>> > >
> >> > >>> > >> Hi Syed,
> >> > >>> > >> That is a great idea; however, it is a very hard task.
> >> > >>> > >> The idea of Tim is great; actually, we already have some sort
> >> of
> >> > >>> > hierarchy
> >> > >>> > >> that is used in “CitrixResourceBase.java”.
> >> > >>> > >> I would suggest you first removing the unused code, unused
> >> > >>> variable, and
> >> > >>> > >> duplicate methods; that would be one PR. You can use a tool
> >> called
> >> > >>> > >> UCdetector to find unused code. To find duplicated code you
> can
> >> > use
> >> > >>> PMD.
> >> > >>> > >>
> >> > >>> > >> One very good 

Re: Refactoring CitrixResourceBase

[Will Stevens]

Is there a reason some are prefixed with 'Xs' and others are prefixed with
'XenServer'?
On May 25, 2016 9:41 PM, "Will Stevens"  wrote:

> Ya. I didn't know either and made the same mistake. :)
> On May 25, 2016 9:40 PM, "Syed Mushtaq"  wrote:
>
>> Aah I did not know that. Thanks Will .. here is the link
>> http://i.imgur.com/5B55XMB.png
>>
>> On Wed, May 25, 2016 at 6:37 PM, Will Stevens 
>> wrote:
>>
>> > Attachments don't work. You will have to host it publicly and then post
>> a
>> > link to it.
>> > On May 25, 2016 4:28 PM, "Syed Ahmed"  wrote:
>> >
>> > > Forgot to attach screenshot
>> > >
>> > > On Wed, May 25, 2016 at 4:09 PM, Syed Ahmed 
>> wrote:
>> > >
>> > >> Thanks Rafael,
>> > >>
>> > >> Here is how I am doing. You can see the tree in the screenshot
>> attached.
>> > >> I have started with storage and extracted the storage commands out of
>> > >> CitrixResourceBase (I've renamed it to XenServerResourceBase). This
>> is
>> > the
>> > >> file for refrence. Let me know what you think.
>> > >>
>> > >>
>> > >>
>> >
>> https://github.com/syed/cloudstack/blob/ca2d1469f991727515d9b71a790411d36eb60fdc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/storage/XenServerStorageResource.java
>> > >>
>> > >> It is a non-trivial refactor so may take some time but I think the
>> end
>> > >> result would be very good for everyone.
>> > >>
>> > >>
>> > >>
>> > >> On Wed, May 25, 2016 at 11:22 AM, Rafael Weingärtner <
>> > >> rafaelweingart...@gmail.com> wrote:
>> > >>
>> > >>> Hi Syed,
>> > >>> That is a great job.
>> > >>> I would only suggest breaking the commons a little bit more between
>> > >>> “monitoring” and “common”. On the monitoring side, we could have
>> host
>> > >>> monitoring, VMs monitoring, VMs' status checks (running, stopped,
>> and
>> > >>> others) and maybe other tasks that aim to monitor/check a resource
>> > >>> state/information.
>> > >>>
>> > >>> About the singletons you extracted, I do not see a need for an
>> > interface
>> > >>> right now (maybe I am overlooking the need); in the future if the
>> need
>> > >>> for
>> > >>> interfaces appears, we can create some interfaces and use them into
>> the
>> > >>> singletons you created.
>> > >>>
>> > >>>
>> > >>> On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq <
>> > syed1.mush...@gmail.com>
>> > >>> wrote:
>> > >>>
>> > >>> > Hey Guys,
>> > >>> >
>> > >>> > To give you an update, I've identified and categorized the
>> functions
>> > in
>> > >>> > CitrixResourceBase into 4 categories
>> > >>> >
>> > >>> > 1) common: These deal with the host as a whole (example
>> getHostInfo,
>> > >>> > callPlugin, connection pool  etc)
>> > >>> > 2) compute: Dealing with operations on VMs (start,stop, reboot,
>> > update
>> > >>> etc)
>> > >>> > 3) storage: Dealing with storage operations (creating VDI,
>> attaching
>> > >>> to VM,
>> > >>> > SR operations)
>> > >>> > 4) network: OVS / PIF / VIF operations
>> > >>> >
>> > >>> > I've created singleton classes for each and slowly moving the
>> > >>> functionality
>> > >>> > there. These singletons don't have a base class nor do they
>> implement
>> > >>> an
>> > >>> > interface. I don't know what the best practice is. One question
>> that
>> > I
>> > >>> have
>> > >>> > is, should I create an interface for them or use some existing
>> > >>> interface?
>> > >>> >
>> > >>> > Thanks,
>> > >>> > -Syed
>> > >>> >
>> > >>> >
>> > >>> > On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq <
>> > syed1.mush...@gmail.com
>> > >>> >
>> > >>> > wrote:
>> > >>> >
>> > >>> > > Thanks guys for the Ideas. I will open a JIRA ticket and start
>> > >>> working on
>> > >>> > > it.
>> > >>> > >
>> > >>> > > -Syed
>> > >>> > >
>> > >>> > >
>> > >>> > > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
>> > >>> > > rafaelweingart...@gmail.com> wrote:
>> > >>> > >
>> > >>> > >> Hi Syed,
>> > >>> > >> That is a great idea; however, it is a very hard task.
>> > >>> > >> The idea of Tim is great; actually, we already have some sort
>> of
>> > >>> > hierarchy
>> > >>> > >> that is used in “CitrixResourceBase.java”.
>> > >>> > >> I would suggest you first removing the unused code, unused
>> > >>> variable, and
>> > >>> > >> duplicate methods; that would be one PR. You can use a tool
>> called
>> > >>> > >> UCdetector to find unused code. To find duplicated code you can
>> > use
>> > >>> PMD.
>> > >>> > >>
>> > >>> > >> One very good example of code duplicity are the methods called
>> > >>> > >>
>> > >>> > >>
>> > >>> >
>> > >>>
>> >
>> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
>> > >>> > >>
>> > >>> > >> After you have cleaned the class, I suggest you analyzing where
>> > each
>> > >>> > >> remaining method is used and then look for the proper place to
>> put
>> > >>> them.
>> > >>> > >> It might be a good idea on separating between singletons that
>> are

Re: Refactoring CitrixResourceBase

[Will Stevens]

Ya. I didn't know either and made the same mistake. :)
On May 25, 2016 9:40 PM, "Syed Mushtaq"  wrote:

> Aah I did not know that. Thanks Will .. here is the link
> http://i.imgur.com/5B55XMB.png
>
> On Wed, May 25, 2016 at 6:37 PM, Will Stevens 
> wrote:
>
> > Attachments don't work. You will have to host it publicly and then post a
> > link to it.
> > On May 25, 2016 4:28 PM, "Syed Ahmed"  wrote:
> >
> > > Forgot to attach screenshot
> > >
> > > On Wed, May 25, 2016 at 4:09 PM, Syed Ahmed 
> wrote:
> > >
> > >> Thanks Rafael,
> > >>
> > >> Here is how I am doing. You can see the tree in the screenshot
> attached.
> > >> I have started with storage and extracted the storage commands out of
> > >> CitrixResourceBase (I've renamed it to XenServerResourceBase). This is
> > the
> > >> file for refrence. Let me know what you think.
> > >>
> > >>
> > >>
> >
> https://github.com/syed/cloudstack/blob/ca2d1469f991727515d9b71a790411d36eb60fdc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/storage/XenServerStorageResource.java
> > >>
> > >> It is a non-trivial refactor so may take some time but I think the end
> > >> result would be very good for everyone.
> > >>
> > >>
> > >>
> > >> On Wed, May 25, 2016 at 11:22 AM, Rafael Weingärtner <
> > >> rafaelweingart...@gmail.com> wrote:
> > >>
> > >>> Hi Syed,
> > >>> That is a great job.
> > >>> I would only suggest breaking the commons a little bit more between
> > >>> “monitoring” and “common”. On the monitoring side, we could have host
> > >>> monitoring, VMs monitoring, VMs' status checks (running, stopped, and
> > >>> others) and maybe other tasks that aim to monitor/check a resource
> > >>> state/information.
> > >>>
> > >>> About the singletons you extracted, I do not see a need for an
> > interface
> > >>> right now (maybe I am overlooking the need); in the future if the
> need
> > >>> for
> > >>> interfaces appears, we can create some interfaces and use them into
> the
> > >>> singletons you created.
> > >>>
> > >>>
> > >>> On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq <
> > syed1.mush...@gmail.com>
> > >>> wrote:
> > >>>
> > >>> > Hey Guys,
> > >>> >
> > >>> > To give you an update, I've identified and categorized the
> functions
> > in
> > >>> > CitrixResourceBase into 4 categories
> > >>> >
> > >>> > 1) common: These deal with the host as a whole (example
> getHostInfo,
> > >>> > callPlugin, connection pool  etc)
> > >>> > 2) compute: Dealing with operations on VMs (start,stop, reboot,
> > update
> > >>> etc)
> > >>> > 3) storage: Dealing with storage operations (creating VDI,
> attaching
> > >>> to VM,
> > >>> > SR operations)
> > >>> > 4) network: OVS / PIF / VIF operations
> > >>> >
> > >>> > I've created singleton classes for each and slowly moving the
> > >>> functionality
> > >>> > there. These singletons don't have a base class nor do they
> implement
> > >>> an
> > >>> > interface. I don't know what the best practice is. One question
> that
> > I
> > >>> have
> > >>> > is, should I create an interface for them or use some existing
> > >>> interface?
> > >>> >
> > >>> > Thanks,
> > >>> > -Syed
> > >>> >
> > >>> >
> > >>> > On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq <
> > syed1.mush...@gmail.com
> > >>> >
> > >>> > wrote:
> > >>> >
> > >>> > > Thanks guys for the Ideas. I will open a JIRA ticket and start
> > >>> working on
> > >>> > > it.
> > >>> > >
> > >>> > > -Syed
> > >>> > >
> > >>> > >
> > >>> > > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
> > >>> > > rafaelweingart...@gmail.com> wrote:
> > >>> > >
> > >>> > >> Hi Syed,
> > >>> > >> That is a great idea; however, it is a very hard task.
> > >>> > >> The idea of Tim is great; actually, we already have some sort of
> > >>> > hierarchy
> > >>> > >> that is used in “CitrixResourceBase.java”.
> > >>> > >> I would suggest you first removing the unused code, unused
> > >>> variable, and
> > >>> > >> duplicate methods; that would be one PR. You can use a tool
> called
> > >>> > >> UCdetector to find unused code. To find duplicated code you can
> > use
> > >>> PMD.
> > >>> > >>
> > >>> > >> One very good example of code duplicity are the methods called
> > >>> > >>
> > >>> > >>
> > >>> >
> > >>>
> >
> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
> > >>> > >>
> > >>> > >> After you have cleaned the class, I suggest you analyzing where
> > each
> > >>> > >> remaining method is used and then look for the proper place to
> put
> > >>> them.
> > >>> > >> It might be a good idea on separating between singletons that
> are
> > >>> > >> responsible for well-defined tasks such as managing storage,
> > >>> networking,
> > >>> > >> VMs creating and deletion, VMs monitoring and others.
> > >>> > >>
> > >>> > >> If you need any help, please do not hesitate on asking for our
> > help.
> > >>> > >>
> > >>> > >>
> > >>> > >> On Thu, May 19, 2016 at 

Re: Refactoring CitrixResourceBase

[Syed Mushtaq]

Aah I did not know that. Thanks Will .. here is the link
http://i.imgur.com/5B55XMB.png

On Wed, May 25, 2016 at 6:37 PM, Will Stevens 
wrote:

> Attachments don't work. You will have to host it publicly and then post a
> link to it.
> On May 25, 2016 4:28 PM, "Syed Ahmed"  wrote:
>
> > Forgot to attach screenshot
> >
> > On Wed, May 25, 2016 at 4:09 PM, Syed Ahmed  wrote:
> >
> >> Thanks Rafael,
> >>
> >> Here is how I am doing. You can see the tree in the screenshot attached.
> >> I have started with storage and extracted the storage commands out of
> >> CitrixResourceBase (I've renamed it to XenServerResourceBase). This is
> the
> >> file for refrence. Let me know what you think.
> >>
> >>
> >>
> https://github.com/syed/cloudstack/blob/ca2d1469f991727515d9b71a790411d36eb60fdc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/storage/XenServerStorageResource.java
> >>
> >> It is a non-trivial refactor so may take some time but I think the end
> >> result would be very good for everyone.
> >>
> >>
> >>
> >> On Wed, May 25, 2016 at 11:22 AM, Rafael Weingärtner <
> >> rafaelweingart...@gmail.com> wrote:
> >>
> >>> Hi Syed,
> >>> That is a great job.
> >>> I would only suggest breaking the commons a little bit more between
> >>> “monitoring” and “common”. On the monitoring side, we could have host
> >>> monitoring, VMs monitoring, VMs' status checks (running, stopped, and
> >>> others) and maybe other tasks that aim to monitor/check a resource
> >>> state/information.
> >>>
> >>> About the singletons you extracted, I do not see a need for an
> interface
> >>> right now (maybe I am overlooking the need); in the future if the need
> >>> for
> >>> interfaces appears, we can create some interfaces and use them into the
> >>> singletons you created.
> >>>
> >>>
> >>> On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq <
> syed1.mush...@gmail.com>
> >>> wrote:
> >>>
> >>> > Hey Guys,
> >>> >
> >>> > To give you an update, I've identified and categorized the functions
> in
> >>> > CitrixResourceBase into 4 categories
> >>> >
> >>> > 1) common: These deal with the host as a whole (example getHostInfo,
> >>> > callPlugin, connection pool  etc)
> >>> > 2) compute: Dealing with operations on VMs (start,stop, reboot,
> update
> >>> etc)
> >>> > 3) storage: Dealing with storage operations (creating VDI, attaching
> >>> to VM,
> >>> > SR operations)
> >>> > 4) network: OVS / PIF / VIF operations
> >>> >
> >>> > I've created singleton classes for each and slowly moving the
> >>> functionality
> >>> > there. These singletons don't have a base class nor do they implement
> >>> an
> >>> > interface. I don't know what the best practice is. One question that
> I
> >>> have
> >>> > is, should I create an interface for them or use some existing
> >>> interface?
> >>> >
> >>> > Thanks,
> >>> > -Syed
> >>> >
> >>> >
> >>> > On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq <
> syed1.mush...@gmail.com
> >>> >
> >>> > wrote:
> >>> >
> >>> > > Thanks guys for the Ideas. I will open a JIRA ticket and start
> >>> working on
> >>> > > it.
> >>> > >
> >>> > > -Syed
> >>> > >
> >>> > >
> >>> > > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
> >>> > > rafaelweingart...@gmail.com> wrote:
> >>> > >
> >>> > >> Hi Syed,
> >>> > >> That is a great idea; however, it is a very hard task.
> >>> > >> The idea of Tim is great; actually, we already have some sort of
> >>> > hierarchy
> >>> > >> that is used in “CitrixResourceBase.java”.
> >>> > >> I would suggest you first removing the unused code, unused
> >>> variable, and
> >>> > >> duplicate methods; that would be one PR. You can use a tool called
> >>> > >> UCdetector to find unused code. To find duplicated code you can
> use
> >>> PMD.
> >>> > >>
> >>> > >> One very good example of code duplicity are the methods called
> >>> > >>
> >>> > >>
> >>> >
> >>>
> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
> >>> > >>
> >>> > >> After you have cleaned the class, I suggest you analyzing where
> each
> >>> > >> remaining method is used and then look for the proper place to put
> >>> them.
> >>> > >> It might be a good idea on separating between singletons that are
> >>> > >> responsible for well-defined tasks such as managing storage,
> >>> networking,
> >>> > >> VMs creating and deletion, VMs monitoring and others.
> >>> > >>
> >>> > >> If you need any help, please do not hesitate on asking for our
> help.
> >>> > >>
> >>> > >>
> >>> > >> On Thu, May 19, 2016 at 4:50 PM, Daan Hoogland <
> >>> daan.hoogl...@gmail.com
> >>> > >
> >>> > >> wrote:
> >>> > >>
> >>> > >> > Syed,
> >>> > >> >
> >>> > >> > gogogo. actually it has shrunk to 5k lines since 2012 ;)
> >>> > >> >
> >>> > >> > I like your initiative and initial direction. A lot of small
> >>> steps to
> >>> > >> > improve the blob have been taken and I would sugest to keep
> going
> >>> in
> >>> > >> small
> >>> > >> > 

Re: XenServer 7

[Tim Mackey]

Correct, all modern XenServer distros until 7 were centos 5.x. I doubt any
xapi changes would break cloudstack, but the plugins should be retested,
and btw it's also systemd time
On May 25, 2016 2:39 PM, "Remi Bergsma"  wrote:

As far as I know previous versions were based on Centos 5 even ;-)

Regards, Remi

> On 25 May 2016, at 16:55, Rafael Weingärtner 
wrote:
>
> Oh, I did know that, thanks for sharing Will.
>
> I was reading their Release notes; it seems that their “major changes”
> section does not reflect the experience you are getting.
>
> On Wed, May 25, 2016 at 11:42 AM, Will Stevens 
> wrote:
>
>> CentOS changes a LOT, especially around networking, so I would not be
>> surprised if it does not work. It still takes me like 20 minutes to
figure
>> out what the hell I am doing when I login to CentOS7.  No ifconfig, no
>> iptables, etc, etc, etc...  They pretty much did a wholesale change of
>> everything you expect to be there.
>>
>> Lots of testing will have to be done on this and I have not tried to do
>> that yet...
>>
>> *Will STEVENS*
>> Lead Developer
>>
>> *CloudOps* *| *Cloud Solutions Experts
>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>> w cloudops.com *|* tw @CloudOps_
>>
>> On Wed, May 25, 2016 at 9:35 AM, Rafael Weingärtner <
>> rafaelweingart...@gmail.com> wrote:
>>
>>> Considering those scripts you are right; but, my main concerns would be
>>> regarding some XAPI change. The scripts that we create and inject into
>> the
>>> Dom0 should not be that intrusive.
>>>
>>> I do not know about the differences between CentOS 6 and 7, but the only
>>> way I see a script stopping working is that if a program that the script
>>> uses does not come with the CentOS 7 that is bundled with XenServer or
if
>>> that program does not work with CentOS 7 anymore.
>>> I do not recall every single task that those scripts execute, at the top
>> of
>>> my memory I can say that they play with the systems' firewall. They also
>>> mount, copy, and move some files around. I believe they also remove some
>>> configurations from the XAPI sometimes.
>>>
>>> Looking at the release notes in [1], it seems that none of the scripts
>>> should stop working. However, to be sure about every single function and
>>> task that ACS execute on XenServer a batch of tests would be required.
>>>
>>> [1]
>>
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS7#head-b02657cf2e223edb2d7946cbc45086d42c2bb41b
>>>
>>>
>>> On Wed, May 25, 2016 at 10:19 AM, Paul Angus 
>>> wrote:
>>>
 Rafael

 We don’t purely use XAPI with XenServer.
 XenServer 7 has a CentOS7 dom0 rather than CentOS6.  We do a whole load
>>> of
 stuff behind the scenes with python and shell scripts a chunk of which
 won't work anymore.


 Kind regards,

 Paul Angus

 paul.an...@shapeblue.com
 www.shapeblue.com
 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
 @shapeblue



 -Original Message-
 From: Rafael Weingärtner [mailto:rafaelweingart...@gmail.com]
 Sent: 25 May 2016 14:12
 To: dev@cloudstack.apache.org
 Subject: Re: XenServer 7

 Will there be any change on the XAPI? If not, it already works (just
>> the
 new functions, if any, that will not be used).

 On Wed, May 25, 2016 at 9:59 AM, Paul Angus 
 wrote:

> Is anyone here working on XenServer 7 support for CloudStack?
>
>
> Kind regards,
>
> Paul Angus
>
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue


 --
 Rafael Weingärtner
>>>
>>>
>>>
>>> --
>>> Rafael Weingärtner
>
>
>
> --
> Rafael Weingärtner

Re: Refactoring CitrixResourceBase

[Will Stevens]

Attachments don't work. You will have to host it publicly and then post a
link to it.
On May 25, 2016 4:28 PM, "Syed Ahmed"  wrote:

> Forgot to attach screenshot
>
> On Wed, May 25, 2016 at 4:09 PM, Syed Ahmed  wrote:
>
>> Thanks Rafael,
>>
>> Here is how I am doing. You can see the tree in the screenshot attached.
>> I have started with storage and extracted the storage commands out of
>> CitrixResourceBase (I've renamed it to XenServerResourceBase). This is the
>> file for refrence. Let me know what you think.
>>
>>
>> https://github.com/syed/cloudstack/blob/ca2d1469f991727515d9b71a790411d36eb60fdc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/storage/XenServerStorageResource.java
>>
>> It is a non-trivial refactor so may take some time but I think the end
>> result would be very good for everyone.
>>
>>
>>
>> On Wed, May 25, 2016 at 11:22 AM, Rafael Weingärtner <
>> rafaelweingart...@gmail.com> wrote:
>>
>>> Hi Syed,
>>> That is a great job.
>>> I would only suggest breaking the commons a little bit more between
>>> “monitoring” and “common”. On the monitoring side, we could have host
>>> monitoring, VMs monitoring, VMs' status checks (running, stopped, and
>>> others) and maybe other tasks that aim to monitor/check a resource
>>> state/information.
>>>
>>> About the singletons you extracted, I do not see a need for an interface
>>> right now (maybe I am overlooking the need); in the future if the need
>>> for
>>> interfaces appears, we can create some interfaces and use them into the
>>> singletons you created.
>>>
>>>
>>> On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq 
>>> wrote:
>>>
>>> > Hey Guys,
>>> >
>>> > To give you an update, I've identified and categorized the functions in
>>> > CitrixResourceBase into 4 categories
>>> >
>>> > 1) common: These deal with the host as a whole (example getHostInfo,
>>> > callPlugin, connection pool  etc)
>>> > 2) compute: Dealing with operations on VMs (start,stop, reboot, update
>>> etc)
>>> > 3) storage: Dealing with storage operations (creating VDI, attaching
>>> to VM,
>>> > SR operations)
>>> > 4) network: OVS / PIF / VIF operations
>>> >
>>> > I've created singleton classes for each and slowly moving the
>>> functionality
>>> > there. These singletons don't have a base class nor do they implement
>>> an
>>> > interface. I don't know what the best practice is. One question that I
>>> have
>>> > is, should I create an interface for them or use some existing
>>> interface?
>>> >
>>> > Thanks,
>>> > -Syed
>>> >
>>> >
>>> > On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq >> >
>>> > wrote:
>>> >
>>> > > Thanks guys for the Ideas. I will open a JIRA ticket and start
>>> working on
>>> > > it.
>>> > >
>>> > > -Syed
>>> > >
>>> > >
>>> > > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
>>> > > rafaelweingart...@gmail.com> wrote:
>>> > >
>>> > >> Hi Syed,
>>> > >> That is a great idea; however, it is a very hard task.
>>> > >> The idea of Tim is great; actually, we already have some sort of
>>> > hierarchy
>>> > >> that is used in “CitrixResourceBase.java”.
>>> > >> I would suggest you first removing the unused code, unused
>>> variable, and
>>> > >> duplicate methods; that would be one PR. You can use a tool called
>>> > >> UCdetector to find unused code. To find duplicated code you can use
>>> PMD.
>>> > >>
>>> > >> One very good example of code duplicity are the methods called
>>> > >>
>>> > >>
>>> >
>>> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
>>> > >>
>>> > >> After you have cleaned the class, I suggest you analyzing where each
>>> > >> remaining method is used and then look for the proper place to put
>>> them.
>>> > >> It might be a good idea on separating between singletons that are
>>> > >> responsible for well-defined tasks such as managing storage,
>>> networking,
>>> > >> VMs creating and deletion, VMs monitoring and others.
>>> > >>
>>> > >> If you need any help, please do not hesitate on asking for our help.
>>> > >>
>>> > >>
>>> > >> On Thu, May 19, 2016 at 4:50 PM, Daan Hoogland <
>>> daan.hoogl...@gmail.com
>>> > >
>>> > >> wrote:
>>> > >>
>>> > >> > Syed,
>>> > >> >
>>> > >> > gogogo. actually it has shrunk to 5k lines since 2012 ;)
>>> > >> >
>>> > >> > I like your initiative and initial direction. A lot of small
>>> steps to
>>> > >> > improve the blob have been taken and I would sugest to keep going
>>> in
>>> > >> small
>>> > >> > steps.
>>> > >> >
>>> > >> > On Thu, May 19, 2016 at 9:44 PM, Tim Mackey 
>>> > wrote:
>>> > >> >
>>> > >> > > +1
>>> > >> > >
>>> > >> > > When I went through this last time, not only was it hard to
>>> > understand
>>> > >> > the
>>> > >> > > flows, but the XenServer version management was a pain. Would
>>> > suggest
>>> > >> > > creating a base class which always works (i.e. is independent of
>>> > >> > XenServer
>>> > >> > > 

Re: XenServer 7

[Remi Bergsma]

As far as I know previous versions were based on Centos 5 even ;-)

Regards, Remi 

> On 25 May 2016, at 16:55, Rafael Weingärtner  
> wrote:
> 
> Oh, I did know that, thanks for sharing Will.
> 
> I was reading their Release notes; it seems that their “major changes”
> section does not reflect the experience you are getting.
> 
> On Wed, May 25, 2016 at 11:42 AM, Will Stevens 
> wrote:
> 
>> CentOS changes a LOT, especially around networking, so I would not be
>> surprised if it does not work. It still takes me like 20 minutes to figure
>> out what the hell I am doing when I login to CentOS7.  No ifconfig, no
>> iptables, etc, etc, etc...  They pretty much did a wholesale change of
>> everything you expect to be there.
>> 
>> Lots of testing will have to be done on this and I have not tried to do
>> that yet...
>> 
>> *Will STEVENS*
>> Lead Developer
>> 
>> *CloudOps* *| *Cloud Solutions Experts
>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>> w cloudops.com *|* tw @CloudOps_
>> 
>> On Wed, May 25, 2016 at 9:35 AM, Rafael Weingärtner <
>> rafaelweingart...@gmail.com> wrote:
>> 
>>> Considering those scripts you are right; but, my main concerns would be
>>> regarding some XAPI change. The scripts that we create and inject into
>> the
>>> Dom0 should not be that intrusive.
>>> 
>>> I do not know about the differences between CentOS 6 and 7, but the only
>>> way I see a script stopping working is that if a program that the script
>>> uses does not come with the CentOS 7 that is bundled with XenServer or if
>>> that program does not work with CentOS 7 anymore.
>>> I do not recall every single task that those scripts execute, at the top
>> of
>>> my memory I can say that they play with the systems' firewall. They also
>>> mount, copy, and move some files around. I believe they also remove some
>>> configurations from the XAPI sometimes.
>>> 
>>> Looking at the release notes in [1], it seems that none of the scripts
>>> should stop working. However, to be sure about every single function and
>>> task that ACS execute on XenServer a batch of tests would be required.
>>> 
>>> [1]
>> https://wiki.centos.org/Manuals/ReleaseNotes/CentOS7#head-b02657cf2e223edb2d7946cbc45086d42c2bb41b
>>> 
>>> 
>>> On Wed, May 25, 2016 at 10:19 AM, Paul Angus 
>>> wrote:
>>> 
 Rafael
 
 We don’t purely use XAPI with XenServer.
 XenServer 7 has a CentOS7 dom0 rather than CentOS6.  We do a whole load
>>> of
 stuff behind the scenes with python and shell scripts a chunk of which
 won't work anymore.
 
 
 Kind regards,
 
 Paul Angus
 
 paul.an...@shapeblue.com
 www.shapeblue.com
 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
 @shapeblue
 
 
 
 -Original Message-
 From: Rafael Weingärtner [mailto:rafaelweingart...@gmail.com]
 Sent: 25 May 2016 14:12
 To: dev@cloudstack.apache.org
 Subject: Re: XenServer 7
 
 Will there be any change on the XAPI? If not, it already works (just
>> the
 new functions, if any, that will not be used).
 
 On Wed, May 25, 2016 at 9:59 AM, Paul Angus 
 wrote:
 
> Is anyone here working on XenServer 7 support for CloudStack?
> 
> 
> Kind regards,
> 
> Paul Angus
> 
> 
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
 
 
 --
 Rafael Weingärtner
>>> 
>>> 
>>> 
>>> --
>>> Rafael Weingärtner
> 
> 
> 
> -- 
> Rafael Weingärtner

Re: Refactoring CitrixResourceBase

[Syed Ahmed]

Forgot to attach screenshot

On Wed, May 25, 2016 at 4:09 PM, Syed Ahmed  wrote:

> Thanks Rafael,
>
> Here is how I am doing. You can see the tree in the screenshot attached. I
> have started with storage and extracted the storage commands out of
> CitrixResourceBase (I've renamed it to XenServerResourceBase). This is the
> file for refrence. Let me know what you think.
>
>
> https://github.com/syed/cloudstack/blob/ca2d1469f991727515d9b71a790411d36eb60fdc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/storage/XenServerStorageResource.java
>
> It is a non-trivial refactor so may take some time but I think the end
> result would be very good for everyone.
>
>
>
> On Wed, May 25, 2016 at 11:22 AM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
>> Hi Syed,
>> That is a great job.
>> I would only suggest breaking the commons a little bit more between
>> “monitoring” and “common”. On the monitoring side, we could have host
>> monitoring, VMs monitoring, VMs' status checks (running, stopped, and
>> others) and maybe other tasks that aim to monitor/check a resource
>> state/information.
>>
>> About the singletons you extracted, I do not see a need for an interface
>> right now (maybe I am overlooking the need); in the future if the need for
>> interfaces appears, we can create some interfaces and use them into the
>> singletons you created.
>>
>>
>> On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq 
>> wrote:
>>
>> > Hey Guys,
>> >
>> > To give you an update, I've identified and categorized the functions in
>> > CitrixResourceBase into 4 categories
>> >
>> > 1) common: These deal with the host as a whole (example getHostInfo,
>> > callPlugin, connection pool  etc)
>> > 2) compute: Dealing with operations on VMs (start,stop, reboot, update
>> etc)
>> > 3) storage: Dealing with storage operations (creating VDI, attaching to
>> VM,
>> > SR operations)
>> > 4) network: OVS / PIF / VIF operations
>> >
>> > I've created singleton classes for each and slowly moving the
>> functionality
>> > there. These singletons don't have a base class nor do they implement an
>> > interface. I don't know what the best practice is. One question that I
>> have
>> > is, should I create an interface for them or use some existing
>> interface?
>> >
>> > Thanks,
>> > -Syed
>> >
>> >
>> > On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq 
>> > wrote:
>> >
>> > > Thanks guys for the Ideas. I will open a JIRA ticket and start
>> working on
>> > > it.
>> > >
>> > > -Syed
>> > >
>> > >
>> > > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
>> > > rafaelweingart...@gmail.com> wrote:
>> > >
>> > >> Hi Syed,
>> > >> That is a great idea; however, it is a very hard task.
>> > >> The idea of Tim is great; actually, we already have some sort of
>> > hierarchy
>> > >> that is used in “CitrixResourceBase.java”.
>> > >> I would suggest you first removing the unused code, unused variable,
>> and
>> > >> duplicate methods; that would be one PR. You can use a tool called
>> > >> UCdetector to find unused code. To find duplicated code you can use
>> PMD.
>> > >>
>> > >> One very good example of code duplicity are the methods called
>> > >>
>> > >>
>> >
>> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
>> > >>
>> > >> After you have cleaned the class, I suggest you analyzing where each
>> > >> remaining method is used and then look for the proper place to put
>> them.
>> > >> It might be a good idea on separating between singletons that are
>> > >> responsible for well-defined tasks such as managing storage,
>> networking,
>> > >> VMs creating and deletion, VMs monitoring and others.
>> > >>
>> > >> If you need any help, please do not hesitate on asking for our help.
>> > >>
>> > >>
>> > >> On Thu, May 19, 2016 at 4:50 PM, Daan Hoogland <
>> daan.hoogl...@gmail.com
>> > >
>> > >> wrote:
>> > >>
>> > >> > Syed,
>> > >> >
>> > >> > gogogo. actually it has shrunk to 5k lines since 2012 ;)
>> > >> >
>> > >> > I like your initiative and initial direction. A lot of small steps
>> to
>> > >> > improve the blob have been taken and I would sugest to keep going
>> in
>> > >> small
>> > >> > steps.
>> > >> >
>> > >> > On Thu, May 19, 2016 at 9:44 PM, Tim Mackey 
>> > wrote:
>> > >> >
>> > >> > > +1
>> > >> > >
>> > >> > > When I went through this last time, not only was it hard to
>> > understand
>> > >> > the
>> > >> > > flows, but the XenServer version management was a pain. Would
>> > suggest
>> > >> > > creating a base class which always works (i.e. is independent of
>> > >> > XenServer
>> > >> > > version) for core functions. Then add in that which exists for a
>> > >> specific
>> > >> > > version. Should help greatly with testing IMO.
>> > >> > >
>> > >> > > -tim
>> > >> > >
>> > >> > > On Thu, May 19, 2016 at 2:37 PM, Syed Mushtaq <
>> > >> syed1.mush...@gmail.com>
>> > >> > > wrote:
>> > >> > >

Re: Refactoring CitrixResourceBase

[Syed Ahmed]

Thanks Rafael,

Here is how I am doing. You can see the tree in the screenshot attached. I
have started with storage and extracted the storage commands out of
CitrixResourceBase (I've renamed it to XenServerResourceBase). This is the
file for refrence. Let me know what you think.

https://github.com/syed/cloudstack/blob/ca2d1469f991727515d9b71a790411d36eb60fdc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/storage/XenServerStorageResource.java

It is a non-trivial refactor so may take some time but I think the end
result would be very good for everyone.



On Wed, May 25, 2016 at 11:22 AM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Hi Syed,
> That is a great job.
> I would only suggest breaking the commons a little bit more between
> “monitoring” and “common”. On the monitoring side, we could have host
> monitoring, VMs monitoring, VMs' status checks (running, stopped, and
> others) and maybe other tasks that aim to monitor/check a resource
> state/information.
>
> About the singletons you extracted, I do not see a need for an interface
> right now (maybe I am overlooking the need); in the future if the need for
> interfaces appears, we can create some interfaces and use them into the
> singletons you created.
>
>
> On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq 
> wrote:
>
> > Hey Guys,
> >
> > To give you an update, I've identified and categorized the functions in
> > CitrixResourceBase into 4 categories
> >
> > 1) common: These deal with the host as a whole (example getHostInfo,
> > callPlugin, connection pool  etc)
> > 2) compute: Dealing with operations on VMs (start,stop, reboot, update
> etc)
> > 3) storage: Dealing with storage operations (creating VDI, attaching to
> VM,
> > SR operations)
> > 4) network: OVS / PIF / VIF operations
> >
> > I've created singleton classes for each and slowly moving the
> functionality
> > there. These singletons don't have a base class nor do they implement an
> > interface. I don't know what the best practice is. One question that I
> have
> > is, should I create an interface for them or use some existing interface?
> >
> > Thanks,
> > -Syed
> >
> >
> > On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq 
> > wrote:
> >
> > > Thanks guys for the Ideas. I will open a JIRA ticket and start working
> on
> > > it.
> > >
> > > -Syed
> > >
> > >
> > > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
> > > rafaelweingart...@gmail.com> wrote:
> > >
> > >> Hi Syed,
> > >> That is a great idea; however, it is a very hard task.
> > >> The idea of Tim is great; actually, we already have some sort of
> > hierarchy
> > >> that is used in “CitrixResourceBase.java”.
> > >> I would suggest you first removing the unused code, unused variable,
> and
> > >> duplicate methods; that would be one PR. You can use a tool called
> > >> UCdetector to find unused code. To find duplicated code you can use
> PMD.
> > >>
> > >> One very good example of code duplicity are the methods called
> > >>
> > >>
> >
> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
> > >>
> > >> After you have cleaned the class, I suggest you analyzing where each
> > >> remaining method is used and then look for the proper place to put
> them.
> > >> It might be a good idea on separating between singletons that are
> > >> responsible for well-defined tasks such as managing storage,
> networking,
> > >> VMs creating and deletion, VMs monitoring and others.
> > >>
> > >> If you need any help, please do not hesitate on asking for our help.
> > >>
> > >>
> > >> On Thu, May 19, 2016 at 4:50 PM, Daan Hoogland <
> daan.hoogl...@gmail.com
> > >
> > >> wrote:
> > >>
> > >> > Syed,
> > >> >
> > >> > gogogo. actually it has shrunk to 5k lines since 2012 ;)
> > >> >
> > >> > I like your initiative and initial direction. A lot of small steps
> to
> > >> > improve the blob have been taken and I would sugest to keep going in
> > >> small
> > >> > steps.
> > >> >
> > >> > On Thu, May 19, 2016 at 9:44 PM, Tim Mackey 
> > wrote:
> > >> >
> > >> > > +1
> > >> > >
> > >> > > When I went through this last time, not only was it hard to
> > understand
> > >> > the
> > >> > > flows, but the XenServer version management was a pain. Would
> > suggest
> > >> > > creating a base class which always works (i.e. is independent of
> > >> > XenServer
> > >> > > version) for core functions. Then add in that which exists for a
> > >> specific
> > >> > > version. Should help greatly with testing IMO.
> > >> > >
> > >> > > -tim
> > >> > >
> > >> > > On Thu, May 19, 2016 at 2:37 PM, Syed Mushtaq <
> > >> syed1.mush...@gmail.com>
> > >> > > wrote:
> > >> > >
> > >> > > > Hi All,
> > >> > > >
> > >> > > > I would like to refactor CitrixResourceBase class which is
> > >> responsible
> > >> > > for
> > >> > > > communicating with Xenserver. It has grown too long (>5K lines)
> > and
> > >> has
> > >> > > > 

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[KrisSterckx]

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221666486
  
Thanks @swill and all involved !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: DS template copies don��...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1560#discussion_r64617338
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -5510,6 +5501,27 @@ public Answer execute(DestroyCommand cmd) {
 }
 }
 
+/**
+ * Use data center to look for vm, instead of randomly picking up a 
cluster
+ * (in multiple cluster environments vm could not be found if wrong 
cluster was chosen)
+ * @param context vmware context
+ * @param hyperHost vmware hv host
+ * @param vol volume
+ * @return a virtualmachinemo if could be found on datacenter
+ * @throws Exception if there is an error while finding vm
+ * @throws CloudRuntimeException if datacenter cannot be found
+ */
+protected VirtualMachineMO findVmOnDatacenter(VmwareContext context, 
VmwareHypervisorHost hyperHost, VolumeTO vol) throws Exception {
+DatacenterMO dcMo = new DatacenterMO(context, 
hyperHost.getHyperHostDatacenter());
+if (dcMo.getMor() == null) {
+String msg = "Unable to find VMware DC";
+s_logger.error(msg);
+throw new CloudRuntimeException(msg);
+}
+VirtualMachineMO vmMo = dcMo.findVm(vol.getPath());
--- End diff --

My bad, I pushed and fixed it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1519#issuecomment-221637516
  
@dsclose can you kick it off again.  It is just a timeout which caused it 
to fail, so kicking it off again could fix it.  `No output has been received in 
the last 10m0s`.

I will CI this right now.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221631597
  
This error is unrelated to this PR.  This is ready to merge...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: DS template copies don��...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1560#discussion_r64607461
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -5510,6 +5501,27 @@ public Answer execute(DestroyCommand cmd) {
 }
 }
 
+/**
+ * Use data center to look for vm, instead of randomly picking up a 
cluster
+ * (in multiple cluster environments vm could not be found if wrong 
cluster was chosen)
+ * @param context vmware context
+ * @param hyperHost vmware hv host
+ * @param vol volume
+ * @return a virtualmachinemo if could be found on datacenter
+ * @throws Exception if there is an error while finding vm
+ * @throws CloudRuntimeException if datacenter cannot be found
+ */
+protected VirtualMachineMO findVmOnDatacenter(VmwareContext context, 
VmwareHypervisorHost hyperHost, VolumeTO vol) throws Exception {
+DatacenterMO dcMo = new DatacenterMO(context, 
hyperHost.getHyperHostDatacenter());
+if (dcMo.getMor() == null) {
+String msg = "Unable to find VMware DC";
+s_logger.error(msg);
+throw new CloudRuntimeException(msg);
+}
+VirtualMachineMO vmMo = dcMo.findVm(vol.getPath());
--- End diff --

What about using  here: `return dcMo.findVm(vol.getPath());`
then, we could save 1 line of code ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dynamically load drivers before creating ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1553#issuecomment-221634279
  


### CI RESULTS

```
Tests Run: 83
  Skipped: 0
   Failed: 1
   Errors: 2
 Duration: 8h 32m 15s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_GHJEO9/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_GHJEO9/results.txt
```

```
FAIL: test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
262, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
325, in performVPCTests
privateGw_1 = self.createPvtGw(vpc_1, "10.0.3.100", "10.0.3.101", 
acl1.id, vlan_1)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
595, in createPvtGw
self.fail("Failed to create Private Gateway ==> %s" % e)
AssertionError: Failed to create Private Gateway ==> Execute cmd: 
createprivategateway failed, due to: errorCode: 431, errorText:Network with 
vlan vlan://100 already exists in zone 1
--
Additional details in: /tmp/MarvinLogs/test_network_GHJEO9/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_35_59_8X66H9:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1553/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_35_59_8X66H9/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1553/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_35_59_8X66H9/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1553/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_35_59_8X66H9/runinfo.txt)

**`/tmp/MarvinLogs/test_network_GHJEO9:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1553/tmp/MarvinLogs/test_network_GHJEO9/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1553/tmp/MarvinLogs/test_network_GHJEO9/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1553/tmp/MarvinLogs/test_network_GHJEO9/runinfo.txt)

[GitHub] cloudstack pull request: CLOUDSTACK-9280: System VM volumes can be...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1559#issuecomment-221633251
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 1
   Errors: 1
 Duration: 10h 41m 20s
```

**Summary of the problem(s):**
```
FAIL: Test destroy(expunge) Virtual Machine
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 
646, in test_09_expunge_vm
self.assertEqual(list_vm_response,None,"Check Expunged virtual machine 
is in listVirtualMachines response")
AssertionError: Check Expunged virtual machine is in listVirtualMachines 
response
--
Additional details in: /tmp/MarvinLogs/test_vpc_routers_NJRMT6/results.txt
```

```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
854, in tearDown
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : 
u'2016-05-24T12:25:52+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to delete network'}, cmd : 
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid : 
u'fb39f9f4-2168-11e6-9284-5254001daa61', jobstatus : 2, jobid : 
u'a7e1d97d-e770-43f6-83a7-2d81ada1521e', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'Network', accountid : 
u'fb39dea8-2168-11e6-9284-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_HC1DJD/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_38_46_2TM014:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_38_46_2TM014/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_38_46_2TM014/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_38_46_2TM014/runinfo.txt)

**`/tmp/MarvinLogs/test_network_HC1DJD:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/test_network_HC1DJD/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/test_network_HC1DJD/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/test_network_HC1DJD/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_NJRMT6:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/test_vpc_routers_NJRMT6/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/test_vpc_routers_NJRMT6/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1559/tmp/MarvinLogs/test_vpc_routers_NJRMT6/runinfo.txt)


Uploads will be available until `2016-07-25 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/846#issuecomment-221633655
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 2
   Errors: 1
 Duration: 10h 41m 55s
```

**Summary of the problem(s):**
```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
854, in tearDown
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : 
u'2016-05-24T12:24:25+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to delete network'}, cmd : 
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid : 
u'a5538db6-2168-11e6-932f-5254001daa61', jobstatus : 2, jobid : 
u'8e7ebb93-fb36-4842-8e2d-5cefea2ff80a', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'Network', accountid : 
u'a5537331-2168-11e6-932f-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_F00C21/results.txt
```

```
FAIL: test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
262, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
325, in performVPCTests
privateGw_1 = self.createPvtGw(vpc_1, "10.0.3.100", "10.0.3.101", 
acl1.id, vlan_1)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
595, in createPvtGw
self.fail("Failed to create Private Gateway ==> %s" % e)
AssertionError: Failed to create Private Gateway ==> Execute cmd: 
createprivategateway failed, due to: errorCode: 431, errorText:Network with 
vlan vlan://100 already exists in zone 1
--
Additional details in: /tmp/MarvinLogs/test_network_F00C21/results.txt
```

```
FAIL: Test destroy(expunge) Virtual Machine
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 
646, in test_09_expunge_vm
self.assertEqual(list_vm_response,None,"Check Expunged virtual machine 
is in listVirtualMachines response")
AssertionError: Check Expunged virtual machine is in listVirtualMachines 
response
--
Additional details in: /tmp/MarvinLogs/test_vpc_routers_J2J0PP/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_36_18_ATGDYK:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_36_18_ATGDYK/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_36_18_ATGDYK/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_36_18_ATGDYK/runinfo.txt)

**`/tmp/MarvinLogs/test_network_F00C21:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/test_network_F00C21/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/test_network_F00C21/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/test_network_F00C21/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_J2J0PP:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/test_vpc_routers_J2J0PP/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/test_vpc_routers_J2J0PP/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR846/tmp/MarvinLogs/test_vpc_routers_J2J0PP/runinfo.txt)


Uploads will be available until `2016-07-25 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up 

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221631430
  


### CI RESULTS

```
Tests Run: 84
  Skipped: 0
   Failed: 0
   Errors: 1
 Duration: 5h 26m 59s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs2/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_LQ4X6P/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_25_2016_00_27_45_TANKCS:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_25_2016_00_27_45_TANKCS/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_25_2016_00_27_45_TANKCS/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/DeployDataCenter__May_25_2016_00_27_45_TANKCS/runinfo.txt)

**`/tmp/MarvinLogs/test_network_LQ4X6P:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_LQ4X6P/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_LQ4X6P/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_network_LQ4X6P/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_EGE3RJ:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_EGE3RJ/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_EGE3RJ/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1494/tmp/MarvinLogs/test_vpc_routers_EGE3RJ/runinfo.txt)


Uploads will be available until `2016-07-25 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-221631305
  
@syed can you review this error?  It seems to be related to your test.  
Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-221631046
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 1
 Duration: 4h 14m 49s
```

**Summary of the problem(s):**
```
ERROR: Failure: SyntaxError (invalid syntax (test_vpn_service.py, line 209))
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/case.py", line 132, 
in run
self.beforeTest(result)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/case.py", line 74, 
in beforeTest
beforeTest(self.test)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/proxy.py", line 
117, in beforeTest
self.plugins.beforeTest(self.test)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/plugins/manager.py",
 line 99, in __call__
return self.call(*arg, **kw)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/plugins/manager.py",
 line 167, in simple
result = meth(*arg, **kw)
  File "/usr/lib/python2.7/site-packages/marvin/marvinPlugin.py", line 174, 
in beforeTest
join([self.__identifier, self.__testName])
TypeError: sequence item 0: expected string, NoneType found
--
Additional details in: /tmp/MarvinLogs/LW938D/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_24_2016_19_30_24_G1GYB2:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/DeployDataCenter__May_24_2016_19_30_24_G1GYB2/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/DeployDataCenter__May_24_2016_19_30_24_G1GYB2/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/DeployDataCenter__May_24_2016_19_30_24_G1GYB2/runinfo.txt)

**`/tmp/MarvinLogs/LW938D:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/LW938D/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/LW938D/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/LW938D/runinfo.txt)

**`/tmp/MarvinLogs/test_network_9YH1EQ:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/test_network_9YH1EQ/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/test_network_9YH1EQ/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/test_network_9YH1EQ/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_0J3G7J:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/test_vpc_routers_0J3G7J/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/test_vpc_routers_0J3G7J/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1423/tmp/MarvinLogs/test_vpc_routers_0J3G7J/runinfo.txt)


Uploads will be available until `2016-07-25 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: DS template copies don��...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1560#issuecomment-221629942
  
Great job, thanks @nvazquez 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: DS template copies don��...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1560#issuecomment-221623024
  
Hi @rafaelweingartner thanks for your comments!
I extracted to a method and added test cases for this new method. Also 
changed Exception to CloudRuntimeException when data center can't be found.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1519#issuecomment-221611699
  
Same issue. I don't think this is related to the PR. I'll leave this be for 
now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactoring CitrixResourceBase

[Rafael Weingärtner]

Hi Syed,
That is a great job.
I would only suggest breaking the commons a little bit more between
“monitoring” and “common”. On the monitoring side, we could have host
monitoring, VMs monitoring, VMs' status checks (running, stopped, and
others) and maybe other tasks that aim to monitor/check a resource
state/information.

About the singletons you extracted, I do not see a need for an interface
right now (maybe I am overlooking the need); in the future if the need for
interfaces appears, we can create some interfaces and use them into the
singletons you created.


On Wed, May 25, 2016 at 12:10 PM, Syed Mushtaq 
wrote:

> Hey Guys,
>
> To give you an update, I've identified and categorized the functions in
> CitrixResourceBase into 4 categories
>
> 1) common: These deal with the host as a whole (example getHostInfo,
> callPlugin, connection pool  etc)
> 2) compute: Dealing with operations on VMs (start,stop, reboot, update etc)
> 3) storage: Dealing with storage operations (creating VDI, attaching to VM,
> SR operations)
> 4) network: OVS / PIF / VIF operations
>
> I've created singleton classes for each and slowly moving the functionality
> there. These singletons don't have a base class nor do they implement an
> interface. I don't know what the best practice is. One question that I have
> is, should I create an interface for them or use some existing interface?
>
> Thanks,
> -Syed
>
>
> On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq 
> wrote:
>
> > Thanks guys for the Ideas. I will open a JIRA ticket and start working on
> > it.
> >
> > -Syed
> >
> >
> > On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
> > rafaelweingart...@gmail.com> wrote:
> >
> >> Hi Syed,
> >> That is a great idea; however, it is a very hard task.
> >> The idea of Tim is great; actually, we already have some sort of
> hierarchy
> >> that is used in “CitrixResourceBase.java”.
> >> I would suggest you first removing the unused code, unused variable, and
> >> duplicate methods; that would be one PR. You can use a tool called
> >> UCdetector to find unused code. To find duplicated code you can use PMD.
> >>
> >> One very good example of code duplicity are the methods called
> >>
> >>
> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
> >>
> >> After you have cleaned the class, I suggest you analyzing where each
> >> remaining method is used and then look for the proper place to put them.
> >> It might be a good idea on separating between singletons that are
> >> responsible for well-defined tasks such as managing storage, networking,
> >> VMs creating and deletion, VMs monitoring and others.
> >>
> >> If you need any help, please do not hesitate on asking for our help.
> >>
> >>
> >> On Thu, May 19, 2016 at 4:50 PM, Daan Hoogland  >
> >> wrote:
> >>
> >> > Syed,
> >> >
> >> > gogogo. actually it has shrunk to 5k lines since 2012 ;)
> >> >
> >> > I like your initiative and initial direction. A lot of small steps to
> >> > improve the blob have been taken and I would sugest to keep going in
> >> small
> >> > steps.
> >> >
> >> > On Thu, May 19, 2016 at 9:44 PM, Tim Mackey 
> wrote:
> >> >
> >> > > +1
> >> > >
> >> > > When I went through this last time, not only was it hard to
> understand
> >> > the
> >> > > flows, but the XenServer version management was a pain. Would
> suggest
> >> > > creating a base class which always works (i.e. is independent of
> >> > XenServer
> >> > > version) for core functions. Then add in that which exists for a
> >> specific
> >> > > version. Should help greatly with testing IMO.
> >> > >
> >> > > -tim
> >> > >
> >> > > On Thu, May 19, 2016 at 2:37 PM, Syed Mushtaq <
> >> syed1.mush...@gmail.com>
> >> > > wrote:
> >> > >
> >> > > > Hi All,
> >> > > >
> >> > > > I would like to refactor CitrixResourceBase class which is
> >> responsible
> >> > > for
> >> > > > communicating with Xenserver. It has grown too long (>5K lines)
> and
> >> has
> >> > > > absolutely no testing.
> >> > > >
> >> > > > In my first pass I want to separate out the functionality buy the
> >> > > subsystem
> >> > > > it targets (compute, storage, network etc) and will go on from
> >> there.
> >> > > What
> >> > > > do you think? Is anyone working on this currently?
> >> > > >
> >> > > > Thanks,
> >> > > > -Syed
> >> > > >
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> > Daan
> >> >
> >>
> >>
> >>
> >> --
> >> Rafael Weingärtner
> >>
> >
> >
>



-- 
Rafael Weingärtner

Re: Refactoring CitrixResourceBase

[Syed Mushtaq]

Hey Guys,

To give you an update, I've identified and categorized the functions in
CitrixResourceBase into 4 categories

1) common: These deal with the host as a whole (example getHostInfo,
callPlugin, connection pool  etc)
2) compute: Dealing with operations on VMs (start,stop, reboot, update etc)
3) storage: Dealing with storage operations (creating VDI, attaching to VM,
SR operations)
4) network: OVS / PIF / VIF operations

I've created singleton classes for each and slowly moving the functionality
there. These singletons don't have a base class nor do they implement an
interface. I don't know what the best practice is. One question that I have
is, should I create an interface for them or use some existing interface?

Thanks,
-Syed


On Fri, May 20, 2016 at 9:58 AM, Syed Mushtaq 
wrote:

> Thanks guys for the Ideas. I will open a JIRA ticket and start working on
> it.
>
> -Syed
>
>
> On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
>> Hi Syed,
>> That is a great idea; however, it is a very hard task.
>> The idea of Tim is great; actually, we already have some sort of hierarchy
>> that is used in “CitrixResourceBase.java”.
>> I would suggest you first removing the unused code, unused variable, and
>> duplicate methods; that would be one PR. You can use a tool called
>> UCdetector to find unused code. To find duplicated code you can use PMD.
>>
>> One very good example of code duplicity are the methods called
>>
>> “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.
>>
>> After you have cleaned the class, I suggest you analyzing where each
>> remaining method is used and then look for the proper place to put them.
>> It might be a good idea on separating between singletons that are
>> responsible for well-defined tasks such as managing storage, networking,
>> VMs creating and deletion, VMs monitoring and others.
>>
>> If you need any help, please do not hesitate on asking for our help.
>>
>>
>> On Thu, May 19, 2016 at 4:50 PM, Daan Hoogland 
>> wrote:
>>
>> > Syed,
>> >
>> > gogogo. actually it has shrunk to 5k lines since 2012 ;)
>> >
>> > I like your initiative and initial direction. A lot of small steps to
>> > improve the blob have been taken and I would sugest to keep going in
>> small
>> > steps.
>> >
>> > On Thu, May 19, 2016 at 9:44 PM, Tim Mackey  wrote:
>> >
>> > > +1
>> > >
>> > > When I went through this last time, not only was it hard to understand
>> > the
>> > > flows, but the XenServer version management was a pain. Would suggest
>> > > creating a base class which always works (i.e. is independent of
>> > XenServer
>> > > version) for core functions. Then add in that which exists for a
>> specific
>> > > version. Should help greatly with testing IMO.
>> > >
>> > > -tim
>> > >
>> > > On Thu, May 19, 2016 at 2:37 PM, Syed Mushtaq <
>> syed1.mush...@gmail.com>
>> > > wrote:
>> > >
>> > > > Hi All,
>> > > >
>> > > > I would like to refactor CitrixResourceBase class which is
>> responsible
>> > > for
>> > > > communicating with Xenserver. It has grown too long (>5K lines) and
>> has
>> > > > absolutely no testing.
>> > > >
>> > > > In my first pass I want to separate out the functionality buy the
>> > > subsystem
>> > > > it targets (compute, storage, network etc) and will go on from
>> there.
>> > > What
>> > > > do you think? Is anyone working on this currently?
>> > > >
>> > > > Thanks,
>> > > > -Syed
>> > > >
>> > >
>> >
>> >
>> >
>> > --
>> > Daan
>> >
>>
>>
>>
>> --
>> Rafael Weingärtner
>>
>
>

Re: XenServer 7

[Syed Mushtaq]

I had installed Xenserver 7 when it was still in beta. If I remember
correctly, it has a different python version than 6.5 (2.4 in 6.5 and 2.6
in 7). Some scripts had been modified to run on python 2.4 may break with
XS7. Will have to verify this.



On Wed, May 25, 2016 at 10:55 AM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Oh, I did know that, thanks for sharing Will.
>
> I was reading their Release notes; it seems that their “major changes”
> section does not reflect the experience you are getting.
>
> On Wed, May 25, 2016 at 11:42 AM, Will Stevens 
> wrote:
>
> > CentOS changes a LOT, especially around networking, so I would not be
> > surprised if it does not work. It still takes me like 20 minutes to
> figure
> > out what the hell I am doing when I login to CentOS7.  No ifconfig, no
> > iptables, etc, etc, etc...  They pretty much did a wholesale change of
> > everything you expect to be there.
> >
> > Lots of testing will have to be done on this and I have not tried to do
> > that yet...
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> > On Wed, May 25, 2016 at 9:35 AM, Rafael Weingärtner <
> > rafaelweingart...@gmail.com> wrote:
> >
> > > Considering those scripts you are right; but, my main concerns would be
> > > regarding some XAPI change. The scripts that we create and inject into
> > the
> > > Dom0 should not be that intrusive.
> > >
> > > I do not know about the differences between CentOS 6 and 7, but the
> only
> > > way I see a script stopping working is that if a program that the
> script
> > > uses does not come with the CentOS 7 that is bundled with XenServer or
> if
> > > that program does not work with CentOS 7 anymore.
> > > I do not recall every single task that those scripts execute, at the
> top
> > of
> > > my memory I can say that they play with the systems' firewall. They
> also
> > > mount, copy, and move some files around. I believe they also remove
> some
> > > configurations from the XAPI sometimes.
> > >
> > > Looking at the release notes in [1], it seems that none of the scripts
> > > should stop working. However, to be sure about every single function
> and
> > > task that ACS execute on XenServer a batch of tests would be required.
> > >
> > >  [1]
> > >
> > >
> >
> https://wiki.centos.org/Manuals/ReleaseNotes/CentOS7#head-b02657cf2e223edb2d7946cbc45086d42c2bb41b
> > >
> > >
> > > On Wed, May 25, 2016 at 10:19 AM, Paul Angus  >
> > > wrote:
> > >
> > > > Rafael
> > > >
> > > > We don’t purely use XAPI with XenServer.
> > > > XenServer 7 has a CentOS7 dom0 rather than CentOS6.  We do a whole
> load
> > > of
> > > > stuff behind the scenes with python and shell scripts a chunk of
> which
> > > > won't work anymore.
> > > >
> > > >
> > > > Kind regards,
> > > >
> > > > Paul Angus
> > > >
> > > > paul.an...@shapeblue.com
> > > > www.shapeblue.com
> > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > > @shapeblue
> > > >
> > > >
> > > >
> > > > -Original Message-
> > > > From: Rafael Weingärtner [mailto:rafaelweingart...@gmail.com]
> > > > Sent: 25 May 2016 14:12
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: XenServer 7
> > > >
> > > > Will there be any change on the XAPI? If not, it already works (just
> > the
> > > > new functions, if any, that will not be used).
> > > >
> > > > On Wed, May 25, 2016 at 9:59 AM, Paul Angus <
> paul.an...@shapeblue.com>
> > > > wrote:
> > > >
> > > > > Is anyone here working on XenServer 7 support for CloudStack?
> > > > >
> > > > >
> > > > > Kind regards,
> > > > >
> > > > > Paul Angus
> > > > >
> > > > >
> > > > > paul.an...@shapeblue.com
> > > > > www.shapeblue.com
> > > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Rafael Weingärtner
> > > >
> > >
> > >
> > >
> > > --
> > > Rafael Weingärtner
> > >
> >
>
>
>
> --
> Rafael Weingärtner
>

Re: XenServer 7

[Rafael Weingärtner]

Oh, I did know that, thanks for sharing Will.

I was reading their Release notes; it seems that their “major changes”
section does not reflect the experience you are getting.

On Wed, May 25, 2016 at 11:42 AM, Will Stevens 
wrote:

> CentOS changes a LOT, especially around networking, so I would not be
> surprised if it does not work. It still takes me like 20 minutes to figure
> out what the hell I am doing when I login to CentOS7.  No ifconfig, no
> iptables, etc, etc, etc...  They pretty much did a wholesale change of
> everything you expect to be there.
>
> Lots of testing will have to be done on this and I have not tried to do
> that yet...
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Wed, May 25, 2016 at 9:35 AM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > Considering those scripts you are right; but, my main concerns would be
> > regarding some XAPI change. The scripts that we create and inject into
> the
> > Dom0 should not be that intrusive.
> >
> > I do not know about the differences between CentOS 6 and 7, but the only
> > way I see a script stopping working is that if a program that the script
> > uses does not come with the CentOS 7 that is bundled with XenServer or if
> > that program does not work with CentOS 7 anymore.
> > I do not recall every single task that those scripts execute, at the top
> of
> > my memory I can say that they play with the systems' firewall. They also
> > mount, copy, and move some files around. I believe they also remove some
> > configurations from the XAPI sometimes.
> >
> > Looking at the release notes in [1], it seems that none of the scripts
> > should stop working. However, to be sure about every single function and
> > task that ACS execute on XenServer a batch of tests would be required.
> >
> >  [1]
> >
> >
> https://wiki.centos.org/Manuals/ReleaseNotes/CentOS7#head-b02657cf2e223edb2d7946cbc45086d42c2bb41b
> >
> >
> > On Wed, May 25, 2016 at 10:19 AM, Paul Angus 
> > wrote:
> >
> > > Rafael
> > >
> > > We don’t purely use XAPI with XenServer.
> > > XenServer 7 has a CentOS7 dom0 rather than CentOS6.  We do a whole load
> > of
> > > stuff behind the scenes with python and shell scripts a chunk of which
> > > won't work anymore.
> > >
> > >
> > > Kind regards,
> > >
> > > Paul Angus
> > >
> > > paul.an...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > @shapeblue
> > >
> > >
> > >
> > > -Original Message-
> > > From: Rafael Weingärtner [mailto:rafaelweingart...@gmail.com]
> > > Sent: 25 May 2016 14:12
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: XenServer 7
> > >
> > > Will there be any change on the XAPI? If not, it already works (just
> the
> > > new functions, if any, that will not be used).
> > >
> > > On Wed, May 25, 2016 at 9:59 AM, Paul Angus 
> > > wrote:
> > >
> > > > Is anyone here working on XenServer 7 support for CloudStack?
> > > >
> > > >
> > > > Kind regards,
> > > >
> > > > Paul Angus
> > > >
> > > >
> > > > paul.an...@shapeblue.com
> > > > www.shapeblue.com
> > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Rafael Weingärtner
> > >
> >
> >
> >
> > --
> > Rafael Weingärtner
> >
>



-- 
Rafael Weingärtner

Re: XenServer 7

[Will Stevens]

CentOS changes a LOT, especially around networking, so I would not be
surprised if it does not work. It still takes me like 20 minutes to figure
out what the hell I am doing when I login to CentOS7.  No ifconfig, no
iptables, etc, etc, etc...  They pretty much did a wholesale change of
everything you expect to be there.

Lots of testing will have to be done on this and I have not tried to do
that yet...

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Wed, May 25, 2016 at 9:35 AM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Considering those scripts you are right; but, my main concerns would be
> regarding some XAPI change. The scripts that we create and inject into the
> Dom0 should not be that intrusive.
>
> I do not know about the differences between CentOS 6 and 7, but the only
> way I see a script stopping working is that if a program that the script
> uses does not come with the CentOS 7 that is bundled with XenServer or if
> that program does not work with CentOS 7 anymore.
> I do not recall every single task that those scripts execute, at the top of
> my memory I can say that they play with the systems' firewall. They also
> mount, copy, and move some files around. I believe they also remove some
> configurations from the XAPI sometimes.
>
> Looking at the release notes in [1], it seems that none of the scripts
> should stop working. However, to be sure about every single function and
> task that ACS execute on XenServer a batch of tests would be required.
>
>  [1]
>
> https://wiki.centos.org/Manuals/ReleaseNotes/CentOS7#head-b02657cf2e223edb2d7946cbc45086d42c2bb41b
>
>
> On Wed, May 25, 2016 at 10:19 AM, Paul Angus 
> wrote:
>
> > Rafael
> >
> > We don’t purely use XAPI with XenServer.
> > XenServer 7 has a CentOS7 dom0 rather than CentOS6.  We do a whole load
> of
> > stuff behind the scenes with python and shell scripts a chunk of which
> > won't work anymore.
> >
> >
> > Kind regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > -Original Message-
> > From: Rafael Weingärtner [mailto:rafaelweingart...@gmail.com]
> > Sent: 25 May 2016 14:12
> > To: dev@cloudstack.apache.org
> > Subject: Re: XenServer 7
> >
> > Will there be any change on the XAPI? If not, it already works (just the
> > new functions, if any, that will not be used).
> >
> > On Wed, May 25, 2016 at 9:59 AM, Paul Angus 
> > wrote:
> >
> > > Is anyone here working on XenServer 7 support for CloudStack?
> > >
> > >
> > > Kind regards,
> > >
> > > Paul Angus
> > >
> > >
> > > paul.an...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > >
> > >
> > >
> >
> >
> > --
> > Rafael Weingärtner
> >
>
>
>
> --
> Rafael Weingärtner
>

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1519#issuecomment-221600590
  
> No output has been received in the last 10m0s, this potentially indicates 
a stalled build or something wrong with the build itself.
>
>The build has been terminated

Kicking it off again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[dsclose]

GitHub user dsclose reopened a pull request:

https://github.com/apache/cloudstack/pull/1519

Cloudstack 9339: Virtual Routers do not handle Multiple Public Interfaces

This PR addresses CLOUDSTACK-9339 and may need a code review from someone 
familiar with the System VM scripts. In particular, this PR has not been tested 
in a VPC RvR context. Only standalone routers and RvR routers have been 
demonstrated.

- **d582358: Leave public interfaces down in backup redundant routers.** 
Previously backup routers were bringing all interfaces up and thus arping 
public IPs away from the master router.
- **9ee1eb6: Add the default gateway to the main routing table when 
interfaces are configured.** The gateway for the first public IP was always 
being added to the main routing table. Sometimes a router would consequently 
add the gateway for an IP other than the default source-NAT IP. This would 
prevent outbound connectivity for guest VMs.
- **ad9d72f: Add default gateway to device-specific routing tables.** 
Link-level routes were being put into the device-specific routing tables 
(accessed via firewall marks) but these are unnecessary. Instead, the default 
gateway is needed to allow the kernel to make an appropriate routing decision.
- **8db879e: Only mark guest connections when they are part of a 
static-NAT.** Guest connections were being marked with a zero. This added no 
functionality and prevented static-NAT rules from routing outbound traffic 
properly as device-specific routing tables would not be used. Instead, all 
traffic would be routed out via the default public interface.
- **788b1be: Allow forwarding and collect network stats on any public 
interface.** Forwarding rules and network stats were limited to eth2 on RvR 
networks. This needed to be decoupled from eth2 and reapplied to whichever 
interface was under consideration.
- **b19e8aa: Ensure that CONNMARK --restore-mark only appears once.** This 
is a bit of a hack and can do with being improved. The CONNMARK rule was not 
being picked up by the de-duplication logic in CsNetfilter and was being added 
twice. This caused checksum errors on packets traversing NAT.
- **bf285e1: Transition to master state should add all necessary routes.** 
Now that backup routers keep their interfaces down, the route logic executed at 
configuration-time cannot be applied. Instead, once the interface is brought up 
during a transition to master, routers must re-evaluate what routes are needed 
and add them. Unfortunately I couldn't see a way to re-use the existing route 
logic with the variables that I had in scope so there is some duplication. In 
some cases, routers did not successfully arp IPs away from the old master so 
some arp logic was added. During a failover most connections with guest VMs 
will be maintained with only minor packet loss. SSH sessions implemented via 
port-forwarding rules on an interface other than the source-NAT interface 
consistently get dropped, however, so the failover isn't quite seamless. It's 
possible that there's an easy fix for that.

I expect that a number of tests may need to be modified/written as part of 
this PR. Any feedback or pointers would be useful as initially I'll be relying 
on the CI failures to tell me where to look.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-9339

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1519


commit e7a63be161bdd14c985a8b483bffe4bfdaa3f5d4
Author: dean.close 
Date:   2016-05-09T10:31:26Z

CLOUDSTACK-9339: Handle multiple public subnets on virtual routers.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[dsclose]

Github user dsclose closed the pull request at:

https://github.com/apache/cloudstack/pull/1519


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: XenServer 7

[Rafael Weingärtner]

Considering those scripts you are right; but, my main concerns would be
regarding some XAPI change. The scripts that we create and inject into the
Dom0 should not be that intrusive.

I do not know about the differences between CentOS 6 and 7, but the only
way I see a script stopping working is that if a program that the script
uses does not come with the CentOS 7 that is bundled with XenServer or if
that program does not work with CentOS 7 anymore.
I do not recall every single task that those scripts execute, at the top of
my memory I can say that they play with the systems' firewall. They also
mount, copy, and move some files around. I believe they also remove some
configurations from the XAPI sometimes.

Looking at the release notes in [1], it seems that none of the scripts
should stop working. However, to be sure about every single function and
task that ACS execute on XenServer a batch of tests would be required.

 [1]
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS7#head-b02657cf2e223edb2d7946cbc45086d42c2bb41b


On Wed, May 25, 2016 at 10:19 AM, Paul Angus 
wrote:

> Rafael
>
> We don’t purely use XAPI with XenServer.
> XenServer 7 has a CentOS7 dom0 rather than CentOS6.  We do a whole load of
> stuff behind the scenes with python and shell scripts a chunk of which
> won't work anymore.
>
>
> Kind regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: Rafael Weingärtner [mailto:rafaelweingart...@gmail.com]
> Sent: 25 May 2016 14:12
> To: dev@cloudstack.apache.org
> Subject: Re: XenServer 7
>
> Will there be any change on the XAPI? If not, it already works (just the
> new functions, if any, that will not be used).
>
> On Wed, May 25, 2016 at 9:59 AM, Paul Angus 
> wrote:
>
> > Is anyone here working on XenServer 7 support for CloudStack?
> >
> >
> > Kind regards,
> >
> > Paul Angus
> >
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
> >
> >
>
>
> --
> Rafael Weingärtner
>



-- 
Rafael Weingärtner

RE: XenServer 7

[Paul Angus]

Rafael 

We don’t purely use XAPI with XenServer.
XenServer 7 has a CentOS7 dom0 rather than CentOS6.  We do a whole load of 
stuff behind the scenes with python and shell scripts a chunk of which won't 
work anymore.


Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue



-Original Message-
From: Rafael Weingärtner [mailto:rafaelweingart...@gmail.com] 
Sent: 25 May 2016 14:12
To: dev@cloudstack.apache.org
Subject: Re: XenServer 7

Will there be any change on the XAPI? If not, it already works (just the new 
functions, if any, that will not be used).

On Wed, May 25, 2016 at 9:59 AM, Paul Angus 
wrote:

> Is anyone here working on XenServer 7 support for CloudStack?
>
>
> Kind regards,
>
> Paul Angus
>
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>
>
>


-- 
Rafael Weingärtner

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

[footplus]

Github user footplus commented on the pull request:

https://github.com/apache/cloudstack/pull/1555#issuecomment-221572152
  
LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: XenServer 7

[Rafael Weingärtner]

Will there be any change on the XAPI? If not, it already works (just the
new functions, if any, that will not be used).

On Wed, May 25, 2016 at 9:59 AM, Paul Angus 
wrote:

> Is anyone here working on XenServer 7 support for CloudStack?
>
>
> Kind regards,
>
> Paul Angus
>
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>


-- 
Rafael Weingärtner

XenServer 7

[Paul Angus]

Is anyone here working on XenServer 7 support for CloudStack?


Kind regards,

Paul Angus


paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1562#issuecomment-221538713
  
LGTM, simple fix.
Tested on local database.

tag:easypr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1562#issuecomment-221538332
  
@rhtyd: Could you take a look? As you can see, it's a very small fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1562#issuecomment-221531859
  
@swill: Still time to get this one in?

This fix is running in production on our clouds. It is just a ALTER TABLE 
to increase the size of a database field.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

[wido]

GitHub user wido opened a pull request:

https://github.com/apache/cloudstack/pull/1562

CLOUDSTACK-9238: Change template_host_ref.url to varchar(2048)

In Pull Request #1341 / commit a171bb this was fixed for many other
URL fields, but this was not corrected and is still a varchar(255)

Change this field to a varchar(2048) to accomodate longer URLs in
the database.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wido/cloudstack CLOUDSTACK-9238

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1562


commit a77a301f715ea64f3c5e0ff8b37923663868f1a6
Author: Wido den Hollander 
Date:   2016-05-25T10:12:58Z

CLOUDSTACK-9238: Change template_host_ref.url to varchar(2048)

In Pull Request #1341 / commit a171bb this was fixed for many other
URL fields, but this was not corrected and is still a varchar(255)

Change this field to a varchar(2048) to accomodate longer URLs in
the database.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[dsclose]

Github user dsclose closed the pull request at:

https://github.com/apache/cloudstack/pull/1519


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[dsclose]

GitHub user dsclose reopened a pull request:

https://github.com/apache/cloudstack/pull/1519

Cloudstack 9339: Virtual Routers do not handle Multiple Public Interfaces

This PR addresses CLOUDSTACK-9339 and may need a code review from someone 
familiar with the System VM scripts. In particular, this PR has not been tested 
in a VPC RvR context. Only standalone routers and RvR routers have been 
demonstrated.

- **d582358: Leave public interfaces down in backup redundant routers.** 
Previously backup routers were bringing all interfaces up and thus arping 
public IPs away from the master router.
- **9ee1eb6: Add the default gateway to the main routing table when 
interfaces are configured.** The gateway for the first public IP was always 
being added to the main routing table. Sometimes a router would consequently 
add the gateway for an IP other than the default source-NAT IP. This would 
prevent outbound connectivity for guest VMs.
- **ad9d72f: Add default gateway to device-specific routing tables.** 
Link-level routes were being put into the device-specific routing tables 
(accessed via firewall marks) but these are unnecessary. Instead, the default 
gateway is needed to allow the kernel to make an appropriate routing decision.
- **8db879e: Only mark guest connections when they are part of a 
static-NAT.** Guest connections were being marked with a zero. This added no 
functionality and prevented static-NAT rules from routing outbound traffic 
properly as device-specific routing tables would not be used. Instead, all 
traffic would be routed out via the default public interface.
- **788b1be: Allow forwarding and collect network stats on any public 
interface.** Forwarding rules and network stats were limited to eth2 on RvR 
networks. This needed to be decoupled from eth2 and reapplied to whichever 
interface was under consideration.
- **b19e8aa: Ensure that CONNMARK --restore-mark only appears once.** This 
is a bit of a hack and can do with being improved. The CONNMARK rule was not 
being picked up by the de-duplication logic in CsNetfilter and was being added 
twice. This caused checksum errors on packets traversing NAT.
- **bf285e1: Transition to master state should add all necessary routes.** 
Now that backup routers keep their interfaces down, the route logic executed at 
configuration-time cannot be applied. Instead, once the interface is brought up 
during a transition to master, routers must re-evaluate what routes are needed 
and add them. Unfortunately I couldn't see a way to re-use the existing route 
logic with the variables that I had in scope so there is some duplication. In 
some cases, routers did not successfully arp IPs away from the old master so 
some arp logic was added. During a failover most connections with guest VMs 
will be maintained with only minor packet loss. SSH sessions implemented via 
port-forwarding rules on an interface other than the source-NAT interface 
consistently get dropped, however, so the failover isn't quite seamless. It's 
possible that there's an easy fix for that.

I expect that a number of tests may need to be modified/written as part of 
this PR. Any feedback or pointers would be useful as initially I'll be relying 
on the CI failures to tell me where to look.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-9339

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1519


commit e7a63be161bdd14c985a8b483bffe4bfdaa3f5d4
Author: dean.close 
Date:   2016-05-09T10:31:26Z

CLOUDSTACK-9339: Handle multiple public subnets on virtual routers.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9388: Remove string conversion...

[sanju1010]

GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/1561

CLOUDSTACK-9388: Remove string conversion in assertion statement

Remove string convertion in Assertion statement, since the start port 
parameter in listFirewallAPI response is of type integer

Test Result:
=
"Checking firewall rules deletion after static NAT disable ... === 
TestName: test_01_firewall_rules_port_fw | Status : SUCCESS ===
ok

--
Ran 1 test in 153.974s

OK


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack startport

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1561


commit e363fd27021c77e515b0fe3bf25585d3c9818dda
Author: sanjeev 
Date:   2016-05-25T09:27:29Z

CLOUDSTACK-9388: Remove string conversion in assertion statement




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[dsclose]

Github user dsclose commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1519#discussion_r64537215
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -288,14 +290,16 @@ def post_configure(self, address):
 """ The steps that must be done after a device is configured """
 route = CsRoute()
 if not self.get_type() in ["control"]:
-route.add_table(self.dev)
 
-CsRule(self.dev).addMark()
+if self.dev != 'eth0':
+route.add_table(self.dev)
+CsRule(self.dev).addMark()
+self.set_mark()
 
 interfaces = [CsInterface(address, self.config)]
 CsHelper.reconfigure_interfaces(self.cl, interfaces)
 
--- End diff --

Lines 299 and 300 were added as part of c41edc1. I've not investigated what 
those lines do, I've just naively overcome the merge conflicts. I'll look at 
the results of CI and follow from there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1519#issuecomment-221501553
  
@swill taking a look now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1555#issuecomment-221497756
  
I add the noprompt option. Travis are green. Ready to merge.

cc @swill @footplus 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---