[GitHub] cloudstack issue #1703: Trillian testrun on PR-1692 fwd-merged on 4.9 branch

2016-10-18 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1703
  
Thanks! I'll post results when we can fix issues


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1703: Trillian testrun on PR-1692 fwd-merged on 4.9 branch

2016-10-18 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1703
  
@nvazquez thanks for the update, yes it's known issue that when running 
tests all at once it might cause issues. If you have a look at our Travis 
runner, we're running each test one at a time:
https://github.com/apache/cloudstack/blob/master/tools/travis/script.sh#L43

Trillian runs them one at a time as well, you may take some hints from 
Trillian's smoketest runner:

https://github.com/shapeblue/Trillian/blob/master/Ansible/roles/marvin/templates/smoketests.sh.j2#L70


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1703: Trillian testrun on PR-1692 fwd-merged on 4.9 branch

2016-10-18 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1703
  
@jburwell @rhtyd we're running tests with @serg38 and we got some errors, 
but we notice that `failed_plus_exceptions` and `runinfo` files are empty after 
tests finish. When we run individual tests this doesn't happen. It would be 
helpful for us to have those files so we can fix some things in our config and 
re-run tests. Did you have the same issue before?

We are running tests using this command:
```
nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg -vv -s -a 
tags=advanced,required_hardware=true --hypervisor=vmware 
test/integration/smoke/*.py
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #872: Strongswan vpn feature

2016-10-18 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/872
  
I have to solve for this now though: 


![image](https://cloud.githubusercontent.com/assets/13644/19495845/0811c4ba-9553-11e6-9691-1cc17941526d.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1711: Xenserver7 Support

2016-10-18 Thread syed
Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
@koushik-das Thank you for the review! I've added the guest OS mappings and 
hypervisor capabilities.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1711: Xenserver7 Support

2016-10-18 Thread syed
Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1711#discussion_r83933003
  
--- Diff: scripts/vm/hypervisor/xenserver/xenserver70/patch ---
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --

Thanks Koushik for the review. I have removed this file and am using the 
6.5 one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: XenServer 7

2016-10-18 Thread Syed Ahmed
Perfect! Thanks Paul for doing this so fast! I've had some comments on the
PR by Kaushik which I will address and a few other things that I found like
the path of some binaries changed in XS7.0. I will go through the scripts
and see if anyone is using them and will update the PR. Hopefully we can
get this done by the end of this week.

Thanks,
-Syed


On Tue, Oct 18, 2016 at 10:42 AM, Paul Angus 
wrote:

> Hi Syed,
>
>
> I've added XenServer7 into our potential testing matrix, and kicked of the
> smoke test suite.
> The first thing that I've noticed, is that one of my two hosts hasn't
> configured 'fully'  - The label 'Local-Storage' hasn't changed to a UUID
>
> I'll have some proper feedback in the morning, when the test suites have
> finished...
>
>
> Kind regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Syed Ahmed [mailto:sah...@cloudops.com]
> Sent: 17 October 2016 21:04
> To: dev@cloudstack.apache.org
> Subject: Re: XenServer 7
>
> @Raj I'd be more interested in knowing if there are any corner cases that
> We've missed. The fix seems to be relatively simple but I wonder if there
> is something that I've missed as I cannot tests most of the scenarios
>
> On Mon, Oct 17, 2016 at 4:00 PM, Syed Ahmed  wrote:
>
> > PR Created at https://github.com/apache/cloudstack/pull/1711
> >
> >
> >
> > On Mon, Oct 17, 2016 at 3:20 PM, Syed Ahmed  wrote:
> >
> >> Agree with Paul. If you can point to your public repo we can
> >> collaborate easily.
> >>
> >> As per testing. I have manually verified the following use cases
> >> below. I am very happy with the results so far. I will open a PR with
> >> this and we can run regression tests. I also have qcow2 images of
> >> XenServer7 and script to reset/reinitialize it so I will post them as
> >> well on the PR so you guys can take them and install/test XS7
> >>
> >> * Create a new cluster with XenServer7
> >> * Add Primary storage: Should create an SR on XS7
> >> * Add another XS7 host to the Pool
> >> * Add host2 to Cloudstack
> >> * Create VM1 from template
> >> * Create VM2 from template
> >> * Ping/SSH VM1 to VM2 and vice-versa
> >> * Stop/Delete/Expunge VM2
> >> * Create Data disk
> >> * Attach it to VM1
> >> * Create VM snaphsot of VM1
> >> * Restore VM snapshot of VM1
> >> * Delete VM snapshot of VM1
> >> * Create Volume snapshot of Datadisk
> >> * Create volume snapshot of Root disk
> >> * Create new template from snapshot of root disk
> >> * Create volume from snapshot of datadisk
> >> * Detach datadisk volume
> >> * Delete datadisk volume
> >> * Aquire a public IP
> >> * Create a static nat to VM1
> >> * Live migrate VM1 while traffic on VM
> >> * Delete VM1
> >>
> >> Thanks,
> >> -Syed
> >>
> >>
> >> On Mon, Oct 17, 2016 at 1:45 PM, Paul Angus
> >> 
> >> wrote:
> >>
> >>> Hey Rajesh,
> >>>
> >>> Could you submit a pull request to Syed's branch containing where
> >>> you've got to (or let us know where your work is publicly
> >>> accessible) so that we can combine work..?
> >>>
> >>>
> >>>
> >>> Kind regards,
> >>>
> >>> Paul Angus
> >>>
> >>> paul.an...@shapeblue.com
> >>> www.shapeblue.com
> >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >>>
> >>>
> >>>
> >>>
> >>> -Original Message-
> >>> From: Rajesh Ramchandani [mailto:rajesh.ramchand...@accelerite.com]
> >>> Sent: 17 October 2016 18:37
> >>> To: dev@cloudstack.apache.org
> >>> Subject: Re: XenServer 7
> >>>
> >>> Syed - we are working with Citrix on XS7 as well, please drop a note if
> >>> you need help.
> >>>
> >>> Raj
> >>>
> >>>
> >>>
> >>> On Mon, Oct 17, 2016 at 8:30 AM -0700, "Syed Ahmed" <
> sah...@cloudops.com
> >>> > wrote:
> >>>
> >>> Hi Guys,
> >>>
> >>> I have some free time on my hands and was trying to add XenServer 7
> >>> support. There seems to be only one line change that was required to
> add
> >>> it. I am able to create VMs and do basic stuff like NAT/port
> forwarding.
> >>>
> >>> If anyone is interested in trying this out, I have a branch [1] which I
> >>> am working on currently. I will open a PR after I am fairly confident
> that
> >>> everything works.
> >>>
> >>> [1] https://github.com/syed/cloudstack/tree/xenserver7
> >>>
> >>>
> >>> Thanks,
> >>> -Syed
> >>>
> >>>
> >>>
> >>> DISCLAIMER
> >>> ==
> >>> This e-mail may contain privileged and confidential information which
> is
> >>> the property of Accelerite, a Persistent Systems business. It is
> intended
> >>> only for the use of the individual or entity to which it is addressed.
> If
> >>> you are not the intended recipient, you are not authorized to read,
> retain,
> >>> copy, print, distribute or use this message. If you have received this
> >>> communication in error, please notify the sender and delete all copies
> of
> >>> 

[GitHub] cloudstack issue #872: Strongswan vpn feature

2016-10-18 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/872
  
I think I have found why the VPN connections are not correctly being 
deleted from the VR when you run `deleteVpnConnection`.

The [problem is 
here](https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java#L520):
```
if (conn.getState() == State.Connected) {
stopVpnConnection(id);
}
```

It should be:
```
if (conn.getState() != State.Pending) {
stopVpnConnection(id);
}
```

Right now, if the VPN is not in a `Connected` state, the configuration on 
the VR is never cleaned up.  That means that if you make a mistake in your VPN 
configuration when you do it the first time, the config is never deleted 
because it will either be in `Disconnected` or `Error` state.  Between this and 
the fact that config files never get rebuilt, only added to or updated, deleted 
configuration options (like `dpd` for example) will never be removed from the 
config file.  This means that regardless of what you do (like delete everything 
from ACS and start again), the VPN connection for that IP will ALWAYS be broken 
and it will never be possible to make it work correctly because the config will 
be corrupted.

@jayapalu, do you want me to create a pull request to your PR to make all 
my changes available to you guys, or should I create my own PR?  Because we 
need this fix in 4.7, I have a few branches I am maintaining locally with the 
changes.  Let me know...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: XenServer 7

2016-10-18 Thread Paul Angus
Hi Syed,


I've added XenServer7 into our potential testing matrix, and kicked of the 
smoke test suite.  
The first thing that I've noticed, is that one of my two hosts hasn't 
configured 'fully'  - The label 'Local-Storage' hasn't changed to a UUID

I'll have some proper feedback in the morning, when the test suites have 
finished...


Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Syed Ahmed [mailto:sah...@cloudops.com] 
Sent: 17 October 2016 21:04
To: dev@cloudstack.apache.org
Subject: Re: XenServer 7

@Raj I'd be more interested in knowing if there are any corner cases that We've 
missed. The fix seems to be relatively simple but I wonder if there is 
something that I've missed as I cannot tests most of the scenarios

On Mon, Oct 17, 2016 at 4:00 PM, Syed Ahmed  wrote:

> PR Created at https://github.com/apache/cloudstack/pull/1711
>
>
>
> On Mon, Oct 17, 2016 at 3:20 PM, Syed Ahmed  wrote:
>
>> Agree with Paul. If you can point to your public repo we can 
>> collaborate easily.
>>
>> As per testing. I have manually verified the following use cases 
>> below. I am very happy with the results so far. I will open a PR with 
>> this and we can run regression tests. I also have qcow2 images of 
>> XenServer7 and script to reset/reinitialize it so I will post them as 
>> well on the PR so you guys can take them and install/test XS7
>>
>> * Create a new cluster with XenServer7
>> * Add Primary storage: Should create an SR on XS7
>> * Add another XS7 host to the Pool
>> * Add host2 to Cloudstack
>> * Create VM1 from template
>> * Create VM2 from template
>> * Ping/SSH VM1 to VM2 and vice-versa
>> * Stop/Delete/Expunge VM2
>> * Create Data disk
>> * Attach it to VM1
>> * Create VM snaphsot of VM1
>> * Restore VM snapshot of VM1
>> * Delete VM snapshot of VM1
>> * Create Volume snapshot of Datadisk
>> * Create volume snapshot of Root disk
>> * Create new template from snapshot of root disk
>> * Create volume from snapshot of datadisk
>> * Detach datadisk volume
>> * Delete datadisk volume
>> * Aquire a public IP
>> * Create a static nat to VM1
>> * Live migrate VM1 while traffic on VM
>> * Delete VM1
>>
>> Thanks,
>> -Syed
>>
>>
>> On Mon, Oct 17, 2016 at 1:45 PM, Paul Angus 
>> 
>> wrote:
>>
>>> Hey Rajesh,
>>>
>>> Could you submit a pull request to Syed's branch containing where 
>>> you've got to (or let us know where your work is publicly 
>>> accessible) so that we can combine work..?
>>>
>>>
>>>
>>> Kind regards,
>>>
>>> Paul Angus
>>>
>>> paul.an...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>>>
>>>
>>>
>>>
>>> -Original Message-
>>> From: Rajesh Ramchandani [mailto:rajesh.ramchand...@accelerite.com]
>>> Sent: 17 October 2016 18:37
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: XenServer 7
>>>
>>> Syed - we are working with Citrix on XS7 as well, please drop a note if
>>> you need help.
>>>
>>> Raj
>>>
>>>
>>>
>>> On Mon, Oct 17, 2016 at 8:30 AM -0700, "Syed Ahmed" >> > wrote:
>>>
>>> Hi Guys,
>>>
>>> I have some free time on my hands and was trying to add XenServer 7
>>> support. There seems to be only one line change that was required to add
>>> it. I am able to create VMs and do basic stuff like NAT/port forwarding.
>>>
>>> If anyone is interested in trying this out, I have a branch [1] which I
>>> am working on currently. I will open a PR after I am fairly confident that
>>> everything works.
>>>
>>> [1] https://github.com/syed/cloudstack/tree/xenserver7
>>>
>>>
>>> Thanks,
>>> -Syed
>>>
>>>
>>>
>>> DISCLAIMER
>>> ==
>>> This e-mail may contain privileged and confidential information which is
>>> the property of Accelerite, a Persistent Systems business. It is intended
>>> only for the use of the individual or entity to which it is addressed. If
>>> you are not the intended recipient, you are not authorized to read, retain,
>>> copy, print, distribute or use this message. If you have received this
>>> communication in error, please notify the sender and delete all copies of
>>> this message. Accelerite, a Persistent Systems business does not accept any
>>> liability for virus infected mails.
>>>
>>
>>
>


Re: Out 18 - 25 Oct 2016

2016-10-18 Thread Will Stevens
Get well soon. Best of luck with the procedure.

On Oct 18, 2016 6:33 AM, "John Burwell"  wrote:

> All,
>
> I will be out 18-25 Oct 2016 for ankle surgery.  Murali Reddy will
> reviewing, testing, and merging PRs until I return.
>
> Thanks,
> -John
> john.burw...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
>
>
>
>


Out 18 - 25 Oct 2016

2016-10-18 Thread John Burwell
All,

I will be out 18-25 Oct 2016 for ankle surgery.  Murali Reddy will reviewing, 
testing, and merging PRs until I return.

Thanks,
-John
john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 



Re: ACS 4.9 + VMware: Unable to remove one of the NICs of a multi-nic VM

2016-10-18 Thread Prashanth Manthena
Hi All,

Raised the following issue on Jira to track this bug:
https://issues.apache.org/jira/browse/CLOUDSTACK-9547

With regards,
Prashanth

On Mon, Oct 17, 2016 at 12:38 PM, Prashanth Manthena <
prashanth.manth...@nuagenetworks.net> wrote:

> Hi Paul,
>
> First of all, thank you for your time and investigation.
>
> I have tried with timeouts up to 180 seconds, and that didn't help either
> :)
>
> Yes, it doesn't explain the difference between 4.7 and 4.9, because I am
> using the same vcenter/vmware setup (i.e. no vmware tools installed).
>
> Let me know, if you want me to raise an issue on Jira for tracking this
> bug.
>
> On Sat, Oct 15, 2016 at 8:55 PM, Paul Angus 
> wrote:
>
>> I tried extending the timeout to 30 seconds, but that didn't help.
>> However, installing vmware tools (not easy in our built-in templates)
>> made the problem go away.  With the tools installed the removal was pretty
>> much instant.
>> Doesn't explain the difference 4.7 and 4.9 that you are seeing though.
>>
>>
>> Kind regards,
>>
>> Paul Angus
>>
>> paul.an...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>
>>
>> -Original Message-
>> From: Prashanth Manthena [mailto:prashanth.manth...@nuagenetworks.net]
>> Sent: 14 October 2016 13:24
>> To: dev@cloudstack.apache.org
>> Subject: Re: ACS 4.9 + VMware: Unable to remove one of the NICs of a
>> multi-nic VM
>>
>> Hi Paul,
>>
>> Thank you for trying it out.
>>
>> I am only hitting this issue for guest VMs (i.e. not with VPC VRs)
>> created in ACS 4.9 (i.e. not in ACS 4.7) with VMware setups.
>>
>> Moreover, I get the same error when I am trying to remove the NIC (i.e.
>> network adapter) directly from VMware's Vcenter.
>>
>> There is a possible workaround for this issue from VMware on Internet,
>> which doesn't work in this scenario both from CloudStack and VMware:
>> https://kb.vmware.com/selfservice/microsites/search.do?
>> language=en_US=displayKC=2081503
>>
>> Most likely, this issue has something to do with how we deploy
>> (multi-nic) guest VMs in ACS 4.9 with VMware setups.
>>
>> On Fri, Oct 14, 2016 at 1:00 PM, Paul Angus 
>> wrote:
>>
>> > Hi Prashanth,
>> >
>> > I've just tried that. I get the same error - The guest operating
>> > system did not respond to a hot-remove request for device ethernet1 in
>> > a timely manner.
>> >
>> > Kind regards,
>> >
>> > Paul Angus
>> >
>> > paul.an...@shapeblue.com
>> > www.shapeblue.com
>> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>> >
>> >
>> >
>> >
>> > -Original Message-
>> > From: Prashanth Manthena [mailto:prashanth.manth...@nuagenetworks.net]
>> > Sent: 14 October 2016 09:21
>> > To: dev@cloudstack.apache.org
>> > Subject: Re: ACS 4.9 + VMware: Unable to remove one of the NICs of a
>> > multi-nic VM
>> >
>> > HI All,
>> >
>> > Does this issue ring a bell, and is anyone else hitting this issue ?
>> >
>> > Let me know, if it is a known issue.
>> >
>> > Thanking you in advance !!
>> >
>> > On Thu, Oct 13, 2016 at 6:25 PM, Prashanth Manthena <
>> prashanth.manthena@
>> > nuagenetworks.net> wrote:
>> >
>> > > Hi,
>> > >
>> > > I am hitting the following issue on an ACS 4.9 + VMware setup (steps
>> > > to
>> > > reproduce):
>> > >
>> > > 1) Deploy a multi-nic VM (or) add a nic to a single-nic VM
>> > >
>> > > 2) Remove the non-default nic from the multi-nic VM, which fails with
>> > > the following error/exception in the management server log:
>> > >
>> > > 2016-10-05 06:13:28,251 DEBUG [c.c.a.ApiServlet]
>> > > (catalina-exec-14:ctx-f8dc6bd0 ctx-ee610e01) (logid:58e9cf98)
>> > > ===END===  10.31.52.95 -- GET
>> > > command=queryAsyncJobResult=9ad66ce9-6e1b-4c25-bd2e-76
>> 3f4586dd86
>> > > =json&_=1475673245452
>> > > 2016-10-05 06:13:29,787 ERROR [c.c.h.v.r.VmwareResource]
>> > (DirectAgent-302:ctx-78a58d67 10.31.56.178, job-171/job-172, cmd:
>> > UnPlugNicCommand) (logid:9ad66ce9) Unexpected exception:
>> > > java.lang.RuntimeException: The guest operating system did not respond
>> > to a hot-remove request for device ethernet1 in a timely manner.
>> > > at com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(
>> > VmwareClient.java:354)
>> > > at com.cloud.hypervisor.vmware.mo.VirtualMachineMO.
>> > configureVm(VirtualMachineMO.java:949)
>> > > at com.cloud.hypervisor.vmware.resource.VmwareResource.
>> > execute(VmwareResource.java:1103)
>> > > at com.cloud.hypervisor.vmware.resource.VmwareResource.
>> > executeRequest(VmwareResource.java:469)
>> > > at com.cloud.agent.manager.Direct
>> AgentAttache$Task.runInContext(
>> > DirectAgentAttache.java:315)
>> > > at org.apache.cloudstack.managed.context.
>> > ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
>> > > at org.apache.cloudstack.managed.context.impl.
>> > DefaultManagedContext$1.call(DefaultManagedContext.java:56)
>> > > at 

[GitHub] cloudstack pull request #1711: Xenserver7 Support

2016-10-18 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1711#discussion_r83789402
  
--- Diff: scripts/vm/hypervisor/xenserver/xenserver70/patch ---
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --

Is the content of this same as that of XS6.5? If so then this is not 
needed, the 6.5 one can be reused.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1711: Xenserver7 Support

2016-10-18 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1711#discussion_r83790292
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
 ---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import com.cloud.resource.ServerResource;
+
+import javax.ejb.Local;
+
+@Local(value=ServerResource.class)
+public class XenServer700Resource extends Xenserver625Resource {
+
+@Override
+protected String getPatchFilePath() {
+return "scripts/vm/hypervisor/xenserver/xenserver70/patch";
--- End diff --

Additional DB changes are also needed for guest OS mapping and HV 
capabilities table.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1711: Xenserver7 Support

2016-10-18 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1711#discussion_r83789828
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
 ---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import com.cloud.resource.ServerResource;
+
+import javax.ejb.Local;
+
+@Local(value=ServerResource.class)
+public class XenServer700Resource extends Xenserver625Resource {
+
+@Override
+protected String getPatchFilePath() {
+return "scripts/vm/hypervisor/xenserver/xenserver70/patch";
--- End diff --

Refer to the comment on patch file, if same as XS 6.5 then 
XenServer650Resource can be reused


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1711: Xenserver7 Support

2016-10-18 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-63


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1711: Xenserver7 Support

2016-10-18 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
There was an env issue with the debian package job, it has been re-fired.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---