[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1757 Trillian test result (tid-337) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 30772 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1757-t337-xenserver-65sp1.zip Test completed. 39 look ok, 4 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 420.58 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 1372.61 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 479.80 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 619.78 | test_privategw_acl.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py test_06_download_detached_volume | `Error` | 30.43 | test_volumes.py test_01_vpc_site2site_vpn | Success | 326.97 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 121.74 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 271.09 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 638.24 | test_vpc_router_nics.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 777.50 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 984.30 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.75 | test_volumes.py test_08_resize_volume | Success | 85.99 | test_volumes.py test_07_resize_fail | Success | 91.06 | test_volumes.py test_05_detach_volume | Success | 100.28 | test_volumes.py test_04_delete_attached_volume | Success | 10.27 | test_volumes.py test_03_download_attached_volume | Success | 15.38 | test_volumes.py test_02_attach_volume | Success | 10.71 | test_volumes.py test_01_create_volume | Success | 427.98 | test_volumes.py test_03_delete_vm_snapshots | Success | 280.78 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 186.62 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 133.90 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 294.33 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 31.87 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.17 | test_vm_life_cycle.py test_08_migrate_vm | Success | 66.24 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py test_06_destroy_vm | Success | 10.18 | test_vm_life_cycle.py test_03_reboot_vm | Success | 10.20 | test_vm_life_cycle.py test_02_start_vm | Success | 15.22 | test_vm_life_cycle.py test_01_stop_vm | Success | 30.30 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 126.15 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.17 | test_templates.py test_03_delete_template | Success | 5.12 | test_templates.py test_02_edit_template | Success | 90.13 | test_templates.py test_01_create_template | Success | 80.84 | test_templates.py test_10_destroy_cpvm | Success | 221.74 | test_ssvm.py test_09_destroy_ssvm | Success | 204.12 | test_ssvm.py test_08_reboot_cpvm | Success | 141.60 | test_ssvm.py test_07_reboot_ssvm | Success | 153.97 | test_ssvm.py test_06_stop_cpvm | Success | 136.74 | test_ssvm.py test_05_stop_ssvm | Success | 174.01 | test_ssvm.py test_04_cpvm_internals | Success | 1.10 | test_ssvm.py test_03_ssvm_internals | Success | 3.54 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py test_01_snapshot_root_disk | Success | 16.69 | test_snapshots.py test_04_change_offering_small | Success | 58.90 | test_service_offerings.py test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py test_02_edit_service_offering | Success | 0.12 | test_service_offerings.py test_01_create_service_offering | Success | 0.10 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py test_01_scale_vm | Success | 5.24 | test_scale_vm.py test_09_reboot_router | Success | 50.48 | test_routers.py test_08_start_router | Success | 40.43 | test_routers.py test_07_stop_router | Success | 10.20 | test_routers.py test_06_router_advanced | Success | 0.06 | test_routers.py test_05_router_basic | Success |
[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1757 Trillian test result (tid-339) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29505 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1757-t339-vmware-55u3.zip Test completed. 42 look ok, 1 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn | `Error` | 426.66 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Error` | 669.50 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 142.18 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 299.75 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 661.29 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 494.72 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1513.28 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 571.88 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 511.48 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1135.81 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 31.73 | test_volumes.py test_06_download_detached_volume | Success | 70.64 | test_volumes.py test_05_detach_volume | Success | 110.39 | test_volumes.py test_04_delete_attached_volume | Success | 15.24 | test_volumes.py test_03_download_attached_volume | Success | 20.38 | test_volumes.py test_02_attach_volume | Success | 58.72 | test_volumes.py test_01_create_volume | Success | 455.56 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.26 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 194.06 | test_vm_snapshots.py test_01_test_vm_volume_snapshot | Success | 156.69 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 129.77 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 238.87 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.90 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.28 | test_vm_life_cycle.py test_08_migrate_vm | Success | 66.47 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py test_06_destroy_vm | Success | 10.20 | test_vm_life_cycle.py test_03_reboot_vm | Success | 5.23 | test_vm_life_cycle.py test_02_start_vm | Success | 20.38 | test_vm_life_cycle.py test_01_stop_vm | Success | 10.30 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 257.55 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.07 | test_templates.py test_04_extract_template | Success | 15.24 | test_templates.py test_03_delete_template | Success | 5.10 | test_templates.py test_02_edit_template | Success | 90.14 | test_templates.py test_01_create_template | Success | 111.24 | test_templates.py test_10_destroy_cpvm | Success | 266.90 | test_ssvm.py test_09_destroy_ssvm | Success | 238.71 | test_ssvm.py test_08_reboot_cpvm | Success | 126.62 | test_ssvm.py test_07_reboot_ssvm | Success | 128.49 | test_ssvm.py test_06_stop_cpvm | Success | 207.77 | test_ssvm.py test_05_stop_ssvm | Success | 174.68 | test_ssvm.py test_04_cpvm_internals | Success | 1.22 | test_ssvm.py test_03_ssvm_internals | Success | 4.42 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.18 | test_ssvm.py test_01_snapshot_root_disk | Success | 26.71 | test_snapshots.py test_04_change_offering_small | Success | 92.16 | test_service_offerings.py test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py test_01_create_service_offering | Success | 0.10 | test_service_offerings.py test_02_sys_template_ready | Success | 0.11 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.16 | test_secondary_storage.py test_09_reboot_router | Success | 105.96 | test_routers.py test_08_start_router | Success | 100.77 | test_routers.py test_07_stop_router | Success | 20.20 | test_routers.py test_06_router_advanced | Success | 0.04 | test_routers.py test_05_router_basic | Success | 0.03 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.75 | test_routers.py test_03_restart_network_cleanup | Success | 126.03 | test_routers.py test_02_router_internal_adv | Succe
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Github user nitin-maharana commented on the issue: https://github.com/apache/cloudstack/pull/1758 The Add Load Balancer tab was removed.  The same functionality is done by Load Balancing tab. https://cloud.githubusercontent.com/assets/12583725/20293902/26cd3f1e-ab20-11e6-9b59-05ac6ec8194b.png";> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1757 Trillian test result (tid-338) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 24043 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1757-t338-kvm-centos7.zip Test completed. 42 look ok, 1 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 396.62 | test_vpc_redundant.py test_01_vpc_site2site_vpn | Success | 150.37 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 56.14 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 257.22 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 291.44 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 502.74 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 530.07 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1443.95 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 576.62 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 758.56 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.46 | test_volumes.py test_08_resize_volume | Success | 15.38 | test_volumes.py test_07_resize_fail | Success | 20.55 | test_volumes.py test_06_download_detached_volume | Success | 15.30 | test_volumes.py test_05_detach_volume | Success | 100.36 | test_volumes.py test_04_delete_attached_volume | Success | 10.21 | test_volumes.py test_03_download_attached_volume | Success | 15.45 | test_volumes.py test_02_attach_volume | Success | 43.71 | test_volumes.py test_01_create_volume | Success | 712.26 | test_volumes.py test_deploy_vm_multiple | Success | 254.22 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.66 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.29 | test_vm_life_cycle.py test_08_migrate_vm | Success | 41.43 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 126.01 | test_vm_life_cycle.py test_03_reboot_vm | Success | 126.01 | test_vm_life_cycle.py test_02_start_vm | Success | 10.23 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.42 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 65.72 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.03 | test_templates.py test_05_template_permissions | Success | 0.05 | test_templates.py test_04_extract_template | Success | 5.28 | test_templates.py test_03_delete_template | Success | 5.51 | test_templates.py test_02_edit_template | Success | 90.16 | test_templates.py test_01_create_template | Success | 65.67 | test_templates.py test_10_destroy_cpvm | Success | 131.43 | test_ssvm.py test_09_destroy_ssvm | Success | 163.33 | test_ssvm.py test_08_reboot_cpvm | Success | 101.52 | test_ssvm.py test_07_reboot_ssvm | Success | 103.22 | test_ssvm.py test_06_stop_cpvm | Success | 101.46 | test_ssvm.py test_05_stop_ssvm | Success | 133.18 | test_ssvm.py test_04_cpvm_internals | Success | 1.02 | test_ssvm.py test_03_ssvm_internals | Success | 3.99 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py test_01_snapshot_root_disk | Success | 12.48 | test_snapshots.py test_04_change_offering_small | Success | 209.76 | test_service_offerings.py test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py test_01_create_service_offering | Success | 0.10 | test_service_offerings.py test_02_sys_template_ready | Success | 0.16 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.24 | test_secondary_storage.py test_09_reboot_router | Success | 35.33 | test_routers.py test_08_start_router | Success | 30.32 | test_routers.py test_07_stop_router | Success | 10.28 | test_routers.py test_06_router_advanced | Success | 0.06 | test_routers.py test_05_router_basic | Success | 0.05 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.65 | test_routers.py test_03_restart_network_cleanup | Success | 50.51 | test_routers.py test_02_router_internal_adv | Success | 0.87 | test_routers.py test_01_router_internal_basic | Success | 0.46 | test_routers.py test_router_dhcphosts | Success | 276.56 | test_router_dhcphosts.py test_01
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 with custom plugins, there is no way to reliably perform such tracing. I can think of batch cleanup operations in the storage layer that follow the pattern I described. Even if there were, we would have planted a landline for future changes to the system. Deadlocks are significant technical debt that are clearly causing significant operational issues. Unfortunately, there is no way to address them generically --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @jburwell I concur but if @yvsubhash verified that those methods don't participate in complex DML transactions this might be still a good start. If so this approach might be expanded later to multi DML transaction so that each piece can be retired individually. I myself traced few deadlocks in ACS using native mysql deadlock logging and it doesn't seem there would be a viable alternative to retires due to well known complexity of ACS DB operations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 there remains a risk when those methods are executed in the context of an open transaction where DMLs have already been executed and subsequent DMLs will be executed. In this scenario, the first set of the changes would be lost due to the rollback triggered by the query deadlock with the second set proceeding successfully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @jburwell @yvsubhash I might be wrong but this PR will retry on deadlock for only 2 DAO methods searchIncludingRemoved and customSearchIncludingRemoved. No update methods are set with this retry mechanism. If that's the case there is no risk of corrupting DB. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r87917132
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){
if(downloadUrlCurrentAgeInSecs <
_downloadUrlExpirationInterval){ // URL hasnt expired yet
continue;
}
-
-s_logger.debug("Removing download url " +
volumeOnImageStore.getExtractUrl() + " for volume id " +
volumeOnImageStore.getVolumeId());
+long volumeId = volumeOnImageStore.getVolumeId();
+s_logger.debug("Removing download url " +
volumeOnImageStore.getExtractUrl() + " for volume id " + volumeId);
// Remove it from image store
ImageStoreEntity secStore = (ImageStoreEntity)
_dataStoreMgr.getDataStore(volumeOnImageStore.getDataStoreId(),
DataStoreRole.Image);
secStore.deleteExtractUrl(volumeOnImageStore.getInstallPath(),
volumeOnImageStore.getExtractUrl(), Upload.Type.VOLUME);
// Now expunge it from DB since this entry was created
only for download purpose
_volumeStoreDao.expunge(volumeOnImageStore.getId());
+Volume volume = _volumeDao.findById(volumeId);
+if (volume != null && volume.getState() ==
Volume.State.Expunged)
+{
+_volumeDao.remove(volumeId);
+}
--- End diff --
@yvsubhash have you had a chance to review @ustcweizhou's feedback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1735#discussion_r87915067
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -526,16 +529,18 @@ public static DataStoreRole getDataStoreRole(Snapshot
snapshot, SnapshotDataStor
}
long storagePoolId = snapshotStore.getDataStoreId();
-DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId,
DataStoreRole.Primary);
+if (snapshotStore.getState() != null && !
snapshotStore.getState().equals(ObjectInDataStoreStateMachine.State.Destroyed))
{
+DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId,
DataStoreRole.Primary);
-Map mapCapabilities =
dataStore.getDriver().getCapabilities();
+Map mapCapabilities =
dataStore.getDriver().getCapabilities();
-if (mapCapabilities != null) {
-String value =
mapCapabilities.get(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString());
-Boolean supportsStorageSystemSnapshots = new Boolean(value);
+if (mapCapabilities != null) {
+String value =
mapCapabilities.get(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString());
+Boolean supportsStorageSystemSnapshots = new
Boolean(value);
--- End diff --
`new Boolean` skips the constant pool -- putting unnecessary pressure on
the heap and creating a potential memory leak. Please use `Boolean.valueOf` to
part the value to avoid this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1737: CLOUDSTACK-9561 After domain/account deletion, snaps...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1737 @SudharmaJain this fix seems like it would be good for LTS users as well. Could you please change the base branch to 4.9? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1740#discussion_r87913074
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -,6 +,20 @@ public boolean canOperateOnVolume(Volume volume) {
}
@Override
+public void cleanupSnapshotsByVolume(Long volumeId) {
+List volSnapShots =
_snapshotDao.listByVolumeId(volumeId);
+for(SnapshotVO snapshot: volSnapShots) {
+SnapshotInfo info =
snapshotFactory.getSnapshot(snapshot.getId(), DataStoreRole.Primary);
+try {
+snapshotSrv.deleteSnapshot(info);
+} catch(CloudRuntimeException e) {
+String msg = "Cleanup of Snapshot with uuid " +
snapshot.getUuid() + " in primary storage is failed. Ignoring";
--- End diff --
This local variable is only used once. Please consider collapsing into
lint 1122. Also, please add the message from the exception to the message to
provide greater detail for debugging efforts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1740#discussion_r87913578
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -,6 +,20 @@ public boolean canOperateOnVolume(Volume volume) {
}
@Override
+public void cleanupSnapshotsByVolume(Long volumeId) {
+List volSnapShots =
_snapshotDao.listByVolumeId(volumeId);
+for(SnapshotVO snapshot: volSnapShots) {
+SnapshotInfo info =
snapshotFactory.getSnapshot(snapshot.getId(), DataStoreRole.Primary);
--- End diff --
This appears to be an application side join. Please consider creating a
new query to retrieve all snapshot info instances associated with `volumeId` to
reduce load on the database and simplify this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 that is not a safe assumption. Transactions often span multiple statements and methods across DAOs. `TransactionLegacy` has a transaction stacking/nested model that further occludes when a transaction actually completely. Deadlocks are a severe problem that need to be fixed. Unfortunately, this patch would do more harm than good as it would eventually corrupt the database. In, and of themselves, retries are also a very expensive solution to the problem both in terms of the engineering effort required to do it properly and the extra stress placed on the database to perform additional work that will likely fail. Furthermore, a generic **and** correct retry mechanism is a very difficult thing to write. Given the way transaction boundaries are managed in ACS, I think such an effort would be nearly impossible. In a properly written application, deadlocks should very rarely, if ever, occur. Their presence is a symptom of improper transaction handling and/or poor lock management problems. Therefore, my suggestion is that we change this patch to log details about the context in which deadlocks occur. We can then use this information to identify the areas in ACS where these contention problems are location and fix the root cause. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1761#discussion_r87900141
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -962,18 +962,22 @@ protected void
updateSite2SiteVpnConnectionState(final List rout
}
final Site2SiteVpnConnection.State oldState =
conn.getState();
final Site2SiteCustomerGateway gw =
_s2sCustomerGatewayDao.findById(conn.getCustomerGatewayId());
-if (answer.isConnected(gw.getGatewayIp())) {
-
conn.setState(Site2SiteVpnConnection.State.Connected);
-} else {
-
conn.setState(Site2SiteVpnConnection.State.Disconnected);
-}
-_s2sVpnConnectionDao.persist(conn);
-if (oldState != conn.getState()) {
-final String title = "Site-to-site Vpn
Connection to " + gw.getName() + " just switch from " + oldState + " to " +
conn.getState();
-final String context = "Site-to-site Vpn
Connection to " + gw.getName() + " on router " + router.getHostName() + "(id: "
+ router.getId() + ") "
-+ " just switch from " + oldState + "
to " + conn.getState();
-s_logger.info(context);
-
_alertMgr.sendAlert(AlertManager.AlertType.ALERT_TYPE_DOMAIN_ROUTER,
router.getDataCenterId(), router.getPodIdToDeployIn(), title, context);
+
+if (answer.isIPPresent(gw.getGatewayIp())) {
+if (answer.isConnected(gw.getGatewayIp())) {
+
conn.setState(Site2SiteVpnConnection.State.Connected);
+} else {
+
conn.setState(Site2SiteVpnConnection.State.Disconnected);
+}
+_s2sVpnConnectionDao.persist(conn);
+if (oldState != conn.getState()) {
+final String title = "Site-to-site Vpn
Connection to " + gw.getName() + " just switch from " + oldState + " to " +
conn.getState();
--- End diff --
Minor nit: could you please fix the grammatical error in this error
message? It should read "~~just~~ switch**ed** from".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1761#discussion_r87897999
--- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
@@ -76,4 +76,14 @@ public String getDetail(String ip) {
}
return null;
}
+
+public boolean isIPPresent(String ip) {
+if (this.getResult()) {
+Boolean status = ipToConnected.get(ip);
+if (status != null) {
--- End diff --
Is the IP present if `status` is equal to `false`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @jburwell I thought that most if not all of ACS interaction through DAO is rather atomic transactions. Do we have cases of multiple DML statements as a part of the same transaction? We have been seeing quite a few deadlock in a high transaction volume environments where multiple management servers are employed. This causes quite a pain for users due to the randomness and no good recourse/explanation. I would argue that proper retry is a better choice should we cover all the cases including all cases with complex transactions. We have been successful leveraging this approach in systems built on the top of ACS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1759: CLOUDSTACK-9589 vmName entries from host_details tab...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1759 This change has been added to the `schema-480to481.sql` script. Since 4.8.1 has already shipped, this script will not be applied for those users. Therefore, this change needs to be placed in the `schema-481to4820.sql` script. Also, the base branch for this PR is master. However, the database change is targeted at 4.8. Therefore, the base branch should be changed to 4.8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1759: CLOUDSTACK-9589 vmName entries from host_deta...
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1759#discussion_r87896137 --- Diff: setup/db/db/schema-480to481-cleanup.sql --- @@ -18,3 +18,6 @@ --; -- Schema cleanup from 4.8.0 to 4.8.1; --; + +DELETE FROM `cloud`.`host_details` where name = 'vmName' and value in (select name from `cloud`.`vm_instance` where state = 'Expunging' and hypervisor_type ='BareMetal'); --- End diff -- Why is this change scoped only to the baremetal hypervisor? It would seem that it should apply to all hypervisors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1760 @marcaurele this change looks a good check to add to LTS to as well. Could you please change the base branch to 4.9? Once you do, I will kick regression tests across all hypervisors in order to merge the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Apachecon this week
Hello fellows, That would be great! I am staying at Seville until saturday (19 - Nov) afternoon. Cheers, Gabriel. Em 14/11/2016 15:07, Rajesh Ramchandani escreveu: Giles - I am planning to be at ApacheCon and look forward to seeing you all. Thursday and/or Friday get together will be great. I added Jaydeep on the Cc too. Raj From: Giles Sirett Sent: Monday, November 14, 1:12 AM Subject: Apachecon this week To: dev@cloudstack.apache.org Cc: Will Stevens, Gabriel Beims Bräscher, Paul Angus, Tutkowski, Mike According to the schedule, the folks in CC here are all speaking on Cloudstack at Apachecon this week. It looks like Friday is the cloudstack track in room Giralda VI/VII (Jaydeep Marfatia is also speaking, but I cant find his address on the mailing lists - could one of the Accelerite folks on this list please pass this email to him) If anybody else from this community is planning on attending, please shout here I cant see any plans for evening parties, etc so I was going to suggest that our small group of cloudstack devotees get together for a drink, dinner & catchup on either Thursday or Friday evening, after the sessions have finished Kind Regards Giles giles.sir...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue DISCLAIMER == This e-mail may contain privileged and confidential information which is the property of Accelerite, a Persistent Systems business. It is intended only for the use of the individual or entity to which it is addressed. If you are not the intended recipient, you are not authorized to read, retain, copy, print, distribute or use this message. If you have received this communication in error, please notify the sender and delete all copies of this message. Accelerite, a Persistent Systems business does not accept any liability for virus infected mails.
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1758 @nitin-maharana could you please provide a screenshot of this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1757 @jburwell a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1757 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @serg38 my reading of the code is that only the most recently attempted DML will be re-executed. Furthermore, retrying without refreshing the base data can also lead to data corruption. The best thing to do in a case of a dead lock is to fail and rollback due to the risk of data corruption. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1763 Thank you for your submission, but this issue has already been addressed as part of security fix ([CLOUDSTACK-9376](https://issues.apache.org/jira/browse/CLOUDSTACK-9376)) for 4.5+. Please see commit 0cb60a72fea2a216b5e3f6b0d769878b76a3eb03 for more information regarding the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @jburwell @yvsubhash My understanding that all roll back statements will receive MYSQL_DEADLOCK_ERROR_CODE and will be retired as a part of this patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1711: XenServer 7 Support
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87849857 --- Diff: setup/db/db/schema-4910to41000.sql --- @@ -35,4 +35,192 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervi INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) VALUES (UUID(), 'KVM', 'default', 'Windows 10', 257, now()); INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) VALUES (UUID(), 'KVM', 'default', 'Windows 10', 258, now()); -INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) VALUES (UUID(), 'KVM', 'default', 'Windows Server 2012', 259, now()); \ No newline at end of file +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) VALUES (UUID(), 'KVM', 'default', 'Windows Server 2012', 259, now()); + +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 4.5 (32-bit)', 1, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 4.6 (32-bit)', 2, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 4.7 (32-bit)', 3, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 4.8 (32-bit)', 4, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 5, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 6, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 7, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 8, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 9, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 10, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 11, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 12, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 13, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 14, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 111, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 112, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid
[GitHub] cloudstack pull request #1711: XenServer 7 Support
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87848428
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import com.cloud.resource.ServerResource;
+
+import javax.ejb.Local;
+
+@Local(value=ServerResource.class)
+public class XenServer700Resource extends Xenserver625Resource {
+
+@Override
+protected String getPatchFilePath() {
+return "scripts/vm/hypervisor/xenserver/xenserver65/patch";
--- End diff --
@jburwell Because we haven't changed any scripts in 6.5 and 7.0 we don't
need to copy all the scripts to a new foloder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1711: XenServer 7 Support
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87837783
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -489,9 +490,11 @@ def checkVolumeSize(ssh_handle=None,
return FAILED
for line in fdisk_output["stdout"]:
if volume_name in line:
-parts = line.strip().split()
-if str(parts[-2]) == str(size_to_verify):
-return [SUCCESS,str(parts[-2])]
+# Get the bytes from the output
+# Disk /dev/xvdb: 1 GiB, 1073741824 bytes, 2097152
sectors
+m = re.match('.*?(\d+) bytes.*', line)
--- End diff --
Minor nit: `m` is not a descriptive/Pythonic variable. Please consider
refactoring a more a descriptive name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1711: XenServer 7 Support
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87846677 --- Diff: setup/db/db/schema-4910to41000.sql --- @@ -35,4 +35,192 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervi INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) VALUES (UUID(), 'KVM', 'default', 'Windows 10', 257, now()); INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) VALUES (UUID(), 'KVM', 'default', 'Windows 10', 258, now()); -INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) VALUES (UUID(), 'KVM', 'default', 'Windows Server 2012', 259, now()); \ No newline at end of file +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) VALUES (UUID(), 'KVM', 'default', 'Windows Server 2012', 259, now()); + +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 4.5 (32-bit)', 1, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 4.6 (32-bit)', 2, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 4.7 (32-bit)', 3, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 4.8 (32-bit)', 4, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 5, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 6, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 7, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 8, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 9, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 10, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 11, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 12, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 13, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 14, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (32-bit)', 111, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '7.0.0', 'CentOS 5 (64-bit)', 112, utc_timestamp(), 0); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (
[GitHub] cloudstack pull request #1711: XenServer 7 Support
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87836142
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import com.cloud.resource.ServerResource;
+
+import javax.ejb.Local;
+
+@Local(value=ServerResource.class)
+public class XenServer700Resource extends Xenserver625Resource {
+
+@Override
+protected String getPatchFilePath() {
+return "scripts/vm/hypervisor/xenserver/xenserver65/patch";
--- End diff --
Why would the path be `xenserver65/patch` rather than `xenserver70/patch`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
Re: Apachecon this week
Giles - I am planning to be at ApacheCon and look forward to seeing you all. Thursday and/or Friday get together will be great. I added Jaydeep on the Cc too. Raj From: Giles Sirett Sent: Monday, November 14, 1:12 AM Subject: Apachecon this week To: dev@cloudstack.apache.org Cc: Will Stevens, Gabriel Beims Bräscher, Paul Angus, Tutkowski, Mike According to the schedule, the folks in CC here are all speaking on Cloudstack at Apachecon this week. It looks like Friday is the cloudstack track in room Giralda VI/VII (Jaydeep Marfatia is also speaking, but I cant find his address on the mailing lists - could one of the Accelerite folks on this list please pass this email to him) If anybody else from this community is planning on attending, please shout here I cant see any plans for evening parties, etc so I was going to suggest that our small group of cloudstack devotees get together for a drink, dinner & catchup on either Thursday or Friday evening, after the sessions have finished Kind Regards Giles giles.sir...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue DISCLAIMER == This e-mail may contain privileged and confidential information which is the property of Accelerite, a Persistent Systems business. It is intended only for the use of the individual or entity to which it is addressed. If you are not the intended recipient, you are not authorized to read, retain, copy, print, distribute or use this message. If you have received this communication in error, please notify the sender and delete all copies of this message. Accelerite, a Persistent Systems business does not accept any liability for virus infected mails.
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1762 @yvsubhash according to the (MySQL deadlock documenation)[http://dev.mysql.com/doc/refman/5.7/en/innodb-deadlocks.html], a `MYSQL_DEADLOCK_ERROR_CODE` error indicates the enclosing transaction has been rolled back. The proper handling for this error is to re-execute all statements executed in the aborted transaction. From a best practices perspective, all base data should be re-retrieved and changed to ensure logical consistency with changes made by the transaction that won deadlock resolution. As I understand this patch, only the most recently executed DML is retried. Therefore, any previously executed changes will be discarded and the DML will be re-executed either in a new transaction or in auto-commit (I didn't look up how the client handles the transaction context in this scenario). If my understanding is correct, this patch could lead to issues ranging from unexpected foreign key integrity errors to data corruption. Rather attempting to implement a generic retry, I think the best approach to addressing deadlocks is to treat them bugs. This patch could be modified to provide detailed logging information about the conditions under which a deadlock occurs providing the information necessary to refactor the system to avoid lock contention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1721: CLOUDSTACK-9557 Deploy from VMsnapshot fails with ex...
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/1721 @rhtyd i will merge this to #1664 once the conflicts are resolved int the other one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...
GitHub user yvsubhash reopened a pull request: https://github.com/apache/cloudstack/pull/1740 CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor⦠Snapshot on primary storage not cleaned up after Storage migration. This happens in the following scenario ## Steps To Reproduce 1. Create an instance on the local storage on any host 2. Create a scheduled snapshot of the volume: 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local storage and is transferring this snapshot to secondary storage. But the latest snapshot on local storage will stay there. This is as expected. 4. Migrate the instance to another XenServer host with ACS UI and Storage Live Migration 5. The Snapshot on the old host on local storage will not be cleaned up and is staying on local storage. So local storage will fill up with unneeded snapshots. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9572 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1740.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1740 commit 13820fdae5a22573db1c964f02e37d232228b3d8 Author: subhash yedugundla Date: 2016-09-12T13:29:53Z CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Storage migration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1763 ### ACS CI BVT Run **Sumarry:** Build Number 134 Hypervisor xenserver NetworkType Advanced Passed=103 Failed=2 Skipped=6 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_deploy_vm_iso.py * test_deploy_vm_from_iso Failing since 18 runs * test_vm_life_cycle.py * test_10_attachAndDetach_iso Failing since 19 runs **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_routers_network_ops.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: Apachecon this week
Sorry, I meant Wednesday or Thursday evening - I expect most people will be travelling on Friday Kind Regards Giles giles.sir...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue From: Giles Sirett Sent: 14 November 2016 09:11 To: dev@cloudstack.apache.org Cc: Will Stevens ; Gabriel Beims Bräscher ; Paul Angus ; Tutkowski, Mike Subject: Apachecon this week According to the schedule, the folks in CC here are all speaking on Cloudstack at Apachecon this week. It looks like Friday is the cloudstack track in room Giralda VI/VII (Jaydeep Marfatia is also speaking, but I cant find his address on the mailing lists - could one of the Accelerite folks on this list please pass this email to him) If anybody else from this community is planning on attending, please shout here I cant see any plans for evening parties, etc so I was going to suggest that our small group of cloudstack devotees get together for a drink, dinner & catchup on either Thursday or Friday evening, after the sessions have finished Kind Regards Giles
Apachecon this week
According to the schedule, the folks in CC here are all speaking on Cloudstack at Apachecon this week. It looks like Friday is the cloudstack track in room Giralda VI/VII (Jaydeep Marfatia is also speaking, but I cant find his address on the mailing lists - could one of the Accelerite folks on this list please pass this email to him) If anybody else from this community is planning on attending, please shout here I cant see any plans for evening parties, etc so I was going to suggest that our small group of cloudstack devotees get together for a drink, dinner & catchup on either Thursday or Friday evening, after the sessions have finished Kind Regards Giles giles.sir...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue
[GitHub] cloudstack pull request #1711: XenServer 7 Support
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87758702
--- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh ---
@@ -72,7 +72,7 @@ else
fi
rm $link -f
fi
-lvcreate VG_XenStorage-$2 -n hb-$1 --size 4M
+lvcreate VG_XenStorage-$2 -n hb-$1 --size 4M --config
global{metadata_read_only=0}
--- End diff --
Thanks @ArmedGuy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1711: XenServer 7 Support
Github user ArmedGuy commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87756104
--- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh ---
@@ -72,7 +72,7 @@ else
fi
rm $link -f
fi
-lvcreate VG_XenStorage-$2 -n hb-$1 --size 4M
+lvcreate VG_XenStorage-$2 -n hb-$1 --size 4M --config
global{metadata_read_only=0}
--- End diff --
On 6.5 metadata_read_only is already set to false, so this just overrides
with the same value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1711: XenServer 7 Support
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87754997
--- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh ---
@@ -72,7 +72,7 @@ else
fi
rm $link -f
fi
-lvcreate VG_XenStorage-$2 -n hb-$1 --size 4M
+lvcreate VG_XenStorage-$2 -n hb-$1 --size 4M --config
global{metadata_read_only=0}
--- End diff --
Is this verified on older versions of XS?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
