date:20170104

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-01-04 Thread rashmidixit

GitHub user rashmidixit opened a pull request:

https://github.com/apache/cloudstack/pull/1889

CLOUDSTACK-9718: Revamp the dropdown showing lists of hosts available for 
migration in a Zone

Refer to 
[CLOUDSTACK-9718](https://issues.apache.org/jira/browse/CLOUDSTACK-9718) for 
more details.

Problem: All the hosts suitable for VM Migration are not shown in the UI. 
This could
confuse the user as the target host might never be shown in the UI.

Root Cause: The API (findHostsForMigration) always returned page 1 results 
which would
be always <= default.page.size global parameter. Therefore, in case of large
no. of hosts where the result can map to multiple pages, this issue would 
arise.

Solution: 1. Replace drop-down with listView widget.
2. Allow lazy-loading of records on listView's scroll.
3. Show additional parameters (CPU/Memory used) to assist admin in decision 
making.
4. Provide 'Search by host name' to limit the results.

Conflicts:
client/WEB-INF/classes/resources/messages.properties
client/WEB-INF/classes/resources/messages_ja_JP.properties
client/WEB-INF/classes/resources/messages_zh_CN.properties
ui/css/cloudstack3.css
ui/dictionary2.jsp

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9718

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1889.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1889


commit dfb595bdfebc38ae1561584030e62c40cdbd46a5
Author: radhika grover 
Date:   2016-05-06T12:57:41Z

CLOUDSTACK-9718: Revamp the dropdown showing lists of hosts available for 
migration in a Zone

Reviewed-By: Rashmi Dixit

Problem: All the hosts suitable for VM Migration are not shown in the UI. 
This could
confuse the user as the target host might never be shown in the UI.

Root Cause: The API (findHostsForMigration) always returned page 1 results 
which would
be always <= default.page.size global parameter. Therefore, in case of large
no. of hosts where the result can map to multiple pages, this issue would 
arise.

Solution: 1. Replace drop-down with listView widget.
2. Allow lazy-loading of records on listView's scroll.
3. Show additional parameters (CPU/Memory used) to assist admin in decision 
making.
4. Provide 'Search by host name' to limit the results.

Conflicts:
client/WEB-INF/classes/resources/messages.properties
client/WEB-INF/classes/resources/messages_ja_JP.properties
client/WEB-INF/classes/resources/messages_zh_CN.properties
ui/css/cloudstack3.css
ui/dictionary2.jsp




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-01-04 Thread Anshul Gangwar

In case of unmanaged primary storage, we only care about secondary storage for 
snapshot. In case of VMware primary storage is only involved while taking 
snapshot. As far as I know process to take snapshot is to take VM snapshot, 
backup volume to secondary and then remove the VM snapshot on primary. After 
the snapshot is successfully created primary storage is of no concern to that 
snapshot. Somebody can confirm that. I am not able to figure out what 
performance improvements you are talking about?

Also, the datastore checks while listing snapshots are there because of managed 
primary storage only. 

Regards,
Anshul 

On 04/01/17, 7:39 PM, "Sergey Levitskiy"  wrote:

@anshul1886 Actually in unmanaged primary storage scenario the removal of 
PS doesn't check for the existence of the volume snapshot copy. Snapshot should 
be allowed to exist on secondary after primary is gone. In VMware environment 
snapshot copy on primary only improves performance but in the end it always 
replicates to secondary where it remains as a source of truth for a given 
snapshot 




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-01-04 Thread koushik-das

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
@pdube The description mentions about a way to workaround the problem, 
thats the reason for not calling it a blocker. If you think the issue is 
important for the current 4.9 release, please reply on the voting thread that 
is currently going on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-04 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1888
  
This one is open for review, pinging for review -- @swill @karuturi 
@abhinandanprateek @murali-reddy @PaulAngus @nvazquez @serg38 @milamberspace 
@wido @syed @mike-tutkowski and others

High level major changes:
- Switches to openjdk 8 for building CloudStack.
- Switches to openjdk-8-jre for running mgmt server, usage server, agents. 
Test results are based on CentOS6, CentOS7 against Xen, VMware and KVM.
- A new systemvmtemplate with openjdk-8 (zulu-8 distribution of openjdk 
from Azul as Debian7 repos don't have openjdk-8-jre) needs to be used. A 
compatible 4.6.0 systemvmtemplate was built and tested, that only replaces 
openjdk-7 JRE with openjdk-8 JRE and was found to be compatible with ACS 
4.6.0+. If StrongSwan PR is merged, we'll need to create and use a new 
systemvmtemplate with 4.10+.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Cloudstack 4.9.2.0 (RC2)

2017-01-04 Thread Rajani Karuturi

+1 (binding)

Did basic manual tests(create templates, launch vm, networks
etc.) on fresh install of 4.9.2 with xen 6.2

Did not see any issues.

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On January 3, 2017 at 12:35 PM, Rohit Yadav (bhais...@apache.org)
wrote:

Hi All,

I've created a 4.9.2.0 release (RC2), with the following
artifacts up for a
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.9.2.0-RC20170103T1228
Commit: dfc39c1f088dc9979a53bd0de4dfd0e5b266bd0f

Source release (checksums and signatures are available at the
same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.9.2.0/

PGP release keys (signed using 0EE3D884):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure
to indicate
"(binding)" with their vote?

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Regards.

[GitHub] cloudstack pull request #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-04 Thread rhtyd

GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1888

CLOUDSTACK-9710: Switch to JRE1.8

- Switches Travis to use jdk1.8
- Changes java-version to 1.8
- Change jdk/maven version to 1.8
- Switch to F5/java8 compatible library release
- Switch packaging to use jdk 1.8, and jre 1.8 in init/systemd scripts
- Switch systemvm to openjdk-8-jre

By default, openjdk-8 packages are not available on Debian 7 (wheezy); 
installing the pkg from jessie/testing causes several package regressions so 
I've used an openjdk free/opensource repository maintained by Azul, please 
review their terms of use: http://www.azul.com/products/zulu/zulu-terms-of-use
They are similar to what openjdk, or any other package on Debian would 
provide.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack jre8-only

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1888


commit 95016c6594e5fb6740fbf7eab4b33c9e04662dda
Author: Rohit Yadav 
Date:   2017-01-04T17:15:43Z

CLOUDSTACK-9710: Switch to JRE1.8

- Switches Travis to use jdk1.8
- Changes java-version to 1.8
- Change jdk/maven version to 1.8
- Switch to F5/java8 compatible library release
- Switch packaging to use jdk 1.8, and jre 1.8 in init/systemd scripts
- Switch systemvm to openjdk-8-jre

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-04 Thread rhtyd

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1888


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1888
  
Trillian test result (tid-769)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36934 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1888-t769-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 386.09 | 
test_privategw_acl.py
test_01_create_volume | `Error` | 280.13 | test_volumes.py
test_01_vpc_site2site_vpn | Success | 155.66 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 56.12 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 235.50 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 473.30 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 801.66 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 517.02 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1405.62 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 548.75 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 764.47 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1284.16 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.59 | test_volumes.py
test_08_resize_volume | Success | 151.43 | test_volumes.py
test_07_resize_fail | Success | 161.64 | test_volumes.py
test_06_download_detached_volume | Success | 156.29 | test_volumes.py
test_05_detach_volume | Success | 236.20 | test_volumes.py
test_04_delete_attached_volume | Success | 151.57 | test_volumes.py
test_03_download_attached_volume | Success | 156.35 | test_volumes.py
test_02_attach_volume | Success | 184.64 | test_volumes.py
test_deploy_vm_multiple | Success | 363.94 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.80 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 41.00 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.17 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.84 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.86 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
test_01_stop_vm | Success | 125.82 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 70.69 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.23 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 40.55 | test_templates.py
test_10_destroy_cpvm | Success | 161.44 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.76 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.25 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.15 | test_ssvm.py
test_06_stop_cpvm | Success | 131.50 | test_ssvm.py
test_05_stop_ssvm | Success | 133.24 | test_ssvm.py
test_04_cpvm_internals | Success | 1.00 | test_ssvm.py
test_03_ssvm_internals | Success | 3.40 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.25 | test_snapshots.py
test_04_change_offering_small | Success | 210.13 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.09 | test_service_offerings.py
test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 35.33 | test_routers.py
test_08_start_router | Success | 35.37 | test_routers.py
test_07_stop_router | Success | 10.17 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup |

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
Trillian test result (tid-764)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 58402 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1836-t764-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 46 look ok, 4 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 96.46 | 
test_privategw_acl.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 658.36 | 
test_vpc_redundant.py
test_02_VPC_default_routes | Success | 369.73 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 766.95 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 653.25 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1533.81 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 729.50 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 683.58 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1340.20 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 20.96 | test_volumes.py
test_06_download_detached_volume | Success | 55.53 | test_volumes.py
test_05_detach_volume | Success | 105.26 | test_volumes.py
test_04_delete_attached_volume | Success | 10.19 | test_volumes.py
test_03_download_attached_volume | Success | 15.31 | test_volumes.py
test_02_attach_volume | Success | 53.76 | test_volumes.py
test_01_create_volume | Success | 511.75 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 229.18 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 201.59 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.67 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 227.43 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.83 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.17 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 76.30 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.12 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.14 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.24 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.16 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 241.77 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.05 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 15.23 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 130.99 | test_templates.py
test_10_destroy_cpvm | Success | 236.76 | test_ssvm.py
test_09_destroy_ssvm | Success | 268.88 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.60 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.34 | test_ssvm.py
test_06_stop_cpvm | Success | 207.00 | test_ssvm.py
test_05_stop_ssvm | Success | 174.00 | test_ssvm.py
test_04_cpvm_internals | Success | 1.19 | test_ssvm.py
test_03_ssvm_internals | Success | 3.26 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 66.47 | test_snapshots.py
test_04_change_offering_small | Success | 97.01 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.07 | test_service_offerings.py

[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-01-04 Thread mike-tutkowski

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1735#discussion_r94657561
  
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -526,16 +529,18 @@ public static DataStoreRole getDataStoreRole(Snapshot 
snapshot, SnapshotDataStor
 }
 
 long storagePoolId = snapshotStore.getDataStoreId();
-DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId, 
DataStoreRole.Primary);
+if (snapshotStore.getState() != null && ! 
snapshotStore.getState().equals(ObjectInDataStoreStateMachine.State.Destroyed)) 
{
--- End diff --

For managed storage, that is true. For unmanaged storage, one should be 
able to delete the primary storage from which a snapshot was created and the 
snapshot should be able to remain (since the snapshot, in this case, is on 
secondary storage).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-04 Thread mike-tutkowski

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
To clarify this line:

"If that comes back null, then we apparently have removed primary storage, 
which can only be done if your snapshots don't reside on it. If dataStore == 
null, return DataStoreRole.IMAGE."

I meant this for managed storage. For unmanaged storage, the original 
primary storage from which the snapshot came can be deleted and the snapshot 
can remain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
Trillian test result (tid-762)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 43689 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1836-t762-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 492.26 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1378.71 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 554.67 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 844.96 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 336.46 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 152.17 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 548.55 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 300.06 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 715.33 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 915.00 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1104.98 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.71 | test_volumes.py
test_08_resize_volume | Success | 85.94 | test_volumes.py
test_07_resize_fail | Success | 101.18 | test_volumes.py
test_06_download_detached_volume | Success | 20.39 | test_volumes.py
test_05_detach_volume | Success | 100.28 | test_volumes.py
test_04_delete_attached_volume | Success | 10.28 | test_volumes.py
test_03_download_attached_volume | Success | 15.37 | test_volumes.py
test_02_attach_volume | Success | 10.95 | test_volumes.py
test_01_create_volume | Success | 392.58 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.26 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 186.26 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 101.02 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 167.67 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.31 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 66.19 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.17 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 10.19 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.25 | test_vm_life_cycle.py
test_01_stop_vm | Success | 30.29 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 121.06 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.20 | test_templates.py
test_03_delete_template | Success | 5.12 | test_templates.py
test_02_edit_template | Success | 90.19 | test_templates.py
test_01_create_template | Success | 60.59 | test_templates.py
test_10_destroy_cpvm | Success | 226.60 | test_ssvm.py
test_09_destroy_ssvm | Success | 199.00 | test_ssvm.py
test_08_reboot_cpvm | Success | 291.69 | test_ssvm.py
test_07_reboot_ssvm | Success | 154.04 | test_ssvm.py
test_06_stop_cpvm | Success | 166.71 | test_ssvm.py
test_05_stop_ssvm | Success | 169.02 | test_ssvm.py
test_04_cpvm_internals | Success | 1.00 | test_ssvm.py
test_03_ssvm_internals | Success | 3.43 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.16 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.55 | test_snapshots.py
test_04_change_offering_small | Success | 126.12 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.10 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
test_01_scale_vm | Success | 5.24 | test_scale_vm.py
test_09_reboot_router | Success | 65.53 |

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
Trillian test result (tid-763)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42800 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1836-t763-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 336.08 | 
test_privategw_acl.py
test_01_create_volume | `Error` | 279.73 | test_volumes.py
test_01_vpc_site2site_vpn | Success | 164.86 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 71.16 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 271.47 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 473.53 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 805.62 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 529.14 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1342.15 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 568.68 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 795.69 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1310.81 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.53 | test_volumes.py
test_08_resize_volume | Success | 156.43 | test_volumes.py
test_07_resize_fail | Success | 161.44 | test_volumes.py
test_06_download_detached_volume | Success | 156.49 | test_volumes.py
test_05_detach_volume | Success | 241.28 | test_volumes.py
test_04_delete_attached_volume | Success | 151.23 | test_volumes.py
test_03_download_attached_volume | Success | 156.25 | test_volumes.py
test_02_attach_volume | Success | 214.78 | test_volumes.py
test_deploy_vm_multiple | Success | 364.04 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.80 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 41.01 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.83 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.90 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 125.88 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 70.62 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.13 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.10 | test_templates.py
test_01_create_template | Success | 60.56 | test_templates.py
test_10_destroy_cpvm | Success | 161.78 | test_ssvm.py
test_09_destroy_ssvm | Success | 193.61 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.64 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.66 | test_ssvm.py
test_06_stop_cpvm | Success | 131.86 | test_ssvm.py
test_05_stop_ssvm | Success | 163.93 | test_ssvm.py
test_04_cpvm_internals | Success | 1.21 | test_ssvm.py
test_03_ssvm_internals | Success | 3.43 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.27 | test_snapshots.py
test_04_change_offering_small | Success | 234.93 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 40.35 | test_routers.py
test_08_start_router | Success | 35.32 | test_routers.py
test_07_stop_router | Success | 10.16 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1888
  
Packaging result: âcentos6 âcentos7 âdebian. JID-448


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1888
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-04 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1888
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-04 Thread rhtyd

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1888

CLOUDSTACK-9710: Switch to JRE1.8

- Switches Travis to use jdk1.8
- Changes java-version to 1.8
- Change jdk/maven version to 1.8
- Switch to F5/java8 compatible library release
- Switch packaging to use jdk 1.8, and jre 1.8 in init/systemd scripts
- Switch systemvm to openjdk-8-jre

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack jre8-only

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1888


commit 3b7b70528f1a346d402a5032d6b0509b483b8530
Author: Rohit Yadav 
Date:   2017-01-04T17:15:43Z

CLOUDSTACK-9710: Switch to JRE1.8

- Switches Travis to use jdk1.8
- Changes java-version to 1.8
- Change jdk/maven version to 1.8
- Switch to F5/java8 compatible library release
- Switch packaging to use jdk 1.8, and jre 1.8 in init/systemd scripts
- Switch systemvm to openjdk-8-jre

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1864: CLOUDSTACK-9710: Switch to using JDK 1.8 and Strongs...

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1864
  
Packaging result: âcentos6 âcentos7 âdebian. JID-447


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...

2017-01-04 Thread nathanejohnson

Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/977
  
@ustcweizhou I'm pulling this down for testing, I will update with logs and 
screen shots soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1864: CLOUDSTACK-9710: Switch to using JDK 1.8 and Strongs...

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1864
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-01-04 Thread pdube

Github user pdube commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
@rhtyd @koushik-das definitely a blocker IMHO. Being unable to start/reboot 
a VM that has 3 volumes is unacceptable in a public cloud scenario


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1830: CLOUDSTACK-9677: Adding storage policy support for s...

2017-01-04 Thread pdube

Github user pdube commented on the issue:

https://github.com/apache/cloudstack/pull/1830
  
Oops, closed by accident


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1830: CLOUDSTACK-9677: Adding storage policy suppor...

2017-01-04 Thread pdube

Github user pdube closed the pull request at:

https://github.com/apache/cloudstack/pull/1830


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1830: CLOUDSTACK-9677: Adding storage policy suppor...

2017-01-04 Thread pdube

GitHub user pdube reopened a pull request:

https://github.com/apache/cloudstack/pull/1830

CLOUDSTACK-9677: Adding storage policy support for swift as secondaryâ¦

â¦ storage

Added support to use storage policies with swift

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdube/cloudstack swift-storagepolicies

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1830


commit b157381b9933e17bd2f0583ecf519c58faeffcb7
Author: Patrick Dube 
Date:   2016-12-14T18:57:20Z

CLOUDSTACK-9677: Adding storage policy support for swift as secondary 
storage




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1830: CLOUDSTACK-9677: Adding storage policy support for s...

2017-01-04 Thread pdube

Github user pdube commented on the issue:

https://github.com/apache/cloudstack/pull/1830
  
@syed Think you could take a look? Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Cloudstack 4.9.2.0 (RC2)

2017-01-04 Thread Milamber


Hello,

My vote +1 (binding)

Tests are passed on a virtual topology of servers  (CS over CS) 
(1mgr+2nodes+1nfs) :


1/ Fresh install of 4.9.2.0 RC2 (adv net) on Ubuntu 14.04.5 + KVM + NFS 
: OK
Some standard tests with success (create vm, migration, HA, create 
networks, create user, create ssh key, destroy vm, register template, 
create snapshot, restore snapshot, create template, ip association, ip 
release, static nat, firewall rule)
Some tests with cloudstack ansible module with success too (create 
network, register templates, create vm, ip, firewall rule)


2/ Test upgrade from 4.9.1.0 to 4.9.2.0 RC2 : OK
Some standard tests with success (create vm, migration, HA, create 
networks, create user, create ssh key, destroy vm, register template, 
create snapshot, restore snapshot, create template, ip association, ip 
release, static nat, firewall rule)
Some tests with cloudstack ansible module with success too (create 
network, register templates, create vm, ip, firewall rule)


3/ Tests of all localization Web UI for 4.9.2.0 RC2:
Localization works well except Spanish (not a blocker to release): the 
Web UI display partially the localization strings due of one bad 
carriage return in the label message.installWizard.copy.whatIsCloudStack 
string (from Transifex). (I will fix this for the next release 4.9 release)



Perhaps add in the Release notes this Spanish l10n issue.

Thanks to the RM.

Milamber

On 03/01/2017 07:05, Rohit Yadav wrote:

Hi All,

I've created a 4.9.2.0 release (RC2), with the following artifacts up for a
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.9.2.0-RC20170103T1228
Commit: dfc39c1f088dc9979a53bd0de4dfd0e5b266bd0f

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.9.2.0/

PGP release keys (signed using 0EE3D884):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Regards.

Re: [GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-01-04 Thread Sergey Levitskiy

@anshul1886 Actually in unmanaged primary storage scenario the removal of PS 
doesn't check for the existence of the volume snapshot copy. Snapshot should be 
allowed to exist on secondary after primary is gone. In VMware environment 
snapshot copy on primary only improves performance but in the end it always 
replicates to secondary where it remains as a source of truth for a given 
snapshot

Re: 4.9 api docs went missing

2017-01-04 Thread Özhan Rüzgar Karaman

Hi;
I think they are setting up the api page for new CloudStack release, its
not accessible till this Monday.

Thanks
Özhan

On Wed, Jan 4, 2017 at 12:42 PM, Linas Žilinskas 
wrote:

> Hello.
>
> Not sure if intentional, but 4.9 api docs at
> https://cloudstack.apache.org/api.html are missing now.
>
> It seems the page got reverted to a previous version.
>
> Linas Žilinskas
> Head of Development
> website  facebook
>  twitter
>  linkedin
> 
>
> Host1Plus is a division of Digital Energy Technologies Ltd.
>
> 26 York Street, London W1U 6PZ, United Kingdom
>
>
>

[GitHub] cloudstack issue #1864: CLOUDSTACK-9710: Switch to using JDK 1.8 and Strongs...

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1864
  
Packaging result: âcentos6 âcentos7 âdebian. JID-446


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1864: CLOUDSTACK-9710: Switch to using JDK 1.8 and Strongs...

2017-01-04 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1864
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-01-04 Thread anshul1886

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1735#discussion_r94555784
  
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -517,10 +517,10 @@ public String getSecondaryStorageURL(SnapshotVO 
snapshot) {
 List ids = getIdsListFromCmd(cmd.getId(), cmd.getIds());
 
 Ternary 
domainIdRecursiveListProject = new Ternary(cmd.getDomainId(), cmd.isRecursive(), null);
-   _accountMgr.buildACLSearchParameters(caller, id, 
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts, 
domainIdRecursiveListProject, cmd.listAll(), false);
-   Long domainId = domainIdRecursiveListProject.first();
-   Boolean isRecursive = domainIdRecursiveListProject.second();
-   ListProjectResourcesCriteria listProjectResourcesCriteria = 
domainIdRecursiveListProject.third();
+_accountMgr.buildACLSearchParameters(caller, id, 
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts, 
domainIdRecursiveListProject, cmd.listAll(), false);
+Long domainId = domainIdRecursiveListProject.first();
+Boolean isRecursive = domainIdRecursiveListProject.second();
+ListProjectResourcesCriteria listProjectResourcesCriteria = 
domainIdRecursiveListProject.third();
--- End diff --

These type of changes should not be done on unrelated file as it makes 
following changes difficult.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-01-04 Thread anshul1886

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1735#discussion_r94555654
  
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -526,16 +529,18 @@ public static DataStoreRole getDataStoreRole(Snapshot 
snapshot, SnapshotDataStor
 }
 
 long storagePoolId = snapshotStore.getDataStoreId();
-DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId, 
DataStoreRole.Primary);
+if (snapshotStore.getState() != null && ! 
snapshotStore.getState().equals(ObjectInDataStoreStateMachine.State.Destroyed)) 
{
--- End diff --

As pointed out by @mike-tutkowski store cannot be destroyed if there are 
snapshots. Also that enum is meant for snapshot (and entities like that) and 
not for snapshot store. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-01-04 Thread anshul1886

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1735#discussion_r94554986
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java 
---
@@ -115,8 +115,10 @@ public void execute() {
 List snapshotResponses = new 
ArrayList();
 for (Snapshot snapshot : result.first()) {
 SnapshotResponse snapshotResponse = 
_responseGenerator.createSnapshotResponse(snapshot);
-snapshotResponse.setObjectName("snapshot");
-snapshotResponses.add(snapshotResponse);
+if (snapshotResponse != null) {
+snapshotResponse.setObjectName("snapshot");
--- End diff --

What is the use case for null case when that can happen? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-04 Thread anshul1886

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
@mike-tutkowski was in python mode so used try except mode instead of null 
check which is recommended in java. Pushed the changes for null check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-01-04 Thread anshul1886

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1862
  
@sateesh-chodapuneedi code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2017-01-04 Thread karuturi

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@blueorangutan test centos7 vmware-60u2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2017-01-04 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@karuturi I understand these words: "help", "hello", "thanks", "package", 
"test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 
'xenserver-65sp1', 'xenserver-62sp1', 'vmware-60u2', 'vmware-55u3', 
'vmware-51u1', 'vmware-50u1']
Additional tests: list of comma separated tests with paths relative to the 
`test/integration` directory, for example: component/test_acl_listvm.py, 
component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os 
and hypervisor or use the `matrix` command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 
'murali-reddy', 'abhinandanprateek', 'PaulAngus', 'borisstoyanov']


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2017-01-04 Thread karuturi

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@blueorangutan help


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2017-01-04 Thread sateesh-chodapuneedi

Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1862
  
ping @anshulgangwar @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

39 matches

Mail list logo