[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1939
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1939
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...

2017-02-13 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1907#discussion_r100969281
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
 gw = interface.get_gateway()
 logging.info("Interface has the following gateway ==> %s", gw)
 
-if bag['nw_type'] == "guest" and rip == gw:
+guest_gw = self.config.cmdline().get_guest_gw()
+logging.info("Interface has the following gateway ==> %s", 
guest_gw)
+
+if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
--- End diff --

@swill @rafaelweingartner 
#1871 has already been merged into 4.9 and master, so I think guest_gw is 
not necessary here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-13 Thread deepthimachiraju
Github user deepthimachiraju commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@swill  Would do some basic testing of the PR and update the results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@karuturi This one is ready for merging. Two LGTMs + tests passing on all 3 
hypervisors


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-02-13 Thread jayakarteek
Github user jayakarteek commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
HI  raferweingartner, nvazquez,

Yes as specified in mail,
The issue is specific to VMware.

--JayaKarteek

From: Nicolas Vazquez [mailto:notificati...@github.com]
Sent: Tuesday, February 14, 2017 5:36 AM
To: apache/cloudstack 
Cc: Jayakarteek Vasana ; Mention 

Subject: Re: [apache/cloudstack] Management Server UI (VM statistics page) 
CPU Utilized value is incorrect. (#1918)


Hi @jayakarteek 
@rafaelweingartner,

I confirm issue, I tested using an instance with 1 CPU 500Mhz. I'll add 
screenshots for cases when CPU utilization is low and high:

First, with little utilization, vSphere shows 51Mhz CPU Utilization, while 
on Management Server statistics shows 51% CPU utilization

[cpu51]

[cpu512]

Then, ran a loop to increase CPU utilization increasing it to ~1609Mhz and 
Management Server statistics shows 1609% CPU Utilization,

[cpu1600]

[cpu16002]

Hope this helps!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, 
or mute the 
thread.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is 
the property of Accelerite, a Persistent Systems business. It is intended only 
for the use of the individual or entity to which it is addressed. If you are 
not the intended recipient, you are not authorized to read, retain, copy, 
print, distribute or use this message. If you have received this communication 
in error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
Trillian test result (tid-817)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43428 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1727-t817-vmware-60u2.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 48 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 808.93 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 321.50 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 161.88 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 538.04 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 289.56 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 721.30 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 627.21 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1478.29 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 638.93 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 608.03 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1310.61 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 20.77 | test_volumes.py
test_06_download_detached_volume | Success | 50.49 | test_volumes.py
test_05_detach_volume | Success | 100.26 | test_volumes.py
test_04_delete_attached_volume | Success | 10.20 | test_volumes.py
test_03_download_attached_volume | Success | 15.30 | test_volumes.py
test_02_attach_volume | Success | 49.58 | test_volumes.py
test_01_create_volume | Success | 435.28 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 500.36 | 
test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 275.21 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 222.12 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 201.53 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.64 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 262.85 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.95 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 56.05 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.12 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.13 | test_vm_life_cycle.py
test_02_start_vm | Success | 15.20 | test_vm_life_cycle.py
test_01_stop_vm | Success | 5.12 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 206.63 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 10.23 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 105.82 | test_templates.py
test_10_destroy_cpvm | Success | 261.82 | test_ssvm.py
test_09_destroy_ssvm | Success | 233.75 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.62 | test_ssvm.py
test_07_reboot_ssvm | Success | 188.54 | test_ssvm.py
test_06_stop_cpvm | Success | 171.74 | test_ssvm.py
test_05_stop_ssvm | Success | 173.73 | test_ssvm.py
test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
test_03_ssvm_internals | Success | 3.28 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.17 | test_snapshots.py
test_04_change_offering_small | Success | 116.84 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 115.76 | test_routers.py
test_08_

Re: PRs for 4.10

2017-02-13 Thread Will Stevens
Not sure, I will see if I can find some time tomorrow to look at this.
Thanks...

*Will STEVENS*
Lead Developer



On Mon, Feb 13, 2017 at 11:58 PM, Rajani Karuturi  wrote:

> Thanks Will. I will take a look at this today and merge.
>
> Is it possible to add a systemvmtemplate job on
> builds.apachecloudstack.net (https://builds.cloudstack.org/)
> similar to
> http://jenkins.buildacloud.org/job/build-systemvm64-master/ ?
>
> Thanks,
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On February 13, 2017 at 10:46 PM, Will Stevens
> (wstev...@cloudops.com) wrote:
>
> At this point, I think 1741 is ready to merge. I think we need
> one more
> LGTM though...
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens
>  wrote:
>
> @Daan: In order for the tests to pass with 1741, the tests have
> to be run
> with the SystemVM from the PR being used.
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 8, 2017 at 2:46 AM, Daan Hoogland
> 
> wrote:
>
> About 1741, I started the packaging, Will but saw Boris making a
> remark about the system VMs. I'll look into that and start the
> tests.
>
> On Tue, Feb 7, 2017 at 8:19 PM, Will Stevens
> 
> wrote:
>
> I would like to get 1741(strongswan) in, but I need to get
> Trillian to
>
> run
>
> against it with a system vm built from my pr. I have done a CI in
> bubble
> and it came back clean, but would like confirmation through
> Trillian as
> well.
>
> On Feb 7, 2017 2:17 PM, "Milamber"  wrote:
>
> And this PR for 4.9 but need to be foward to 4.10 too.
>
> https://github.com/apache/cloudstack/pull/1929
>
> 2 LGTM
> CI green
>
> On 07/02/2017 13:07, Rajani Karuturi wrote:
>
> Hi all,
> If you know of any PRs which meet the below criteria, please
> mail
>
> them to
>
> me.
> 1. No open questions.
> 2. Has two LGTMs
> 3. Has CI test results.
>
> ~Rajani
> http://cloudplatform.accelerite.com
>
> --
> Daan
>


Re: PRs for 4.10

2017-02-13 Thread Rajani Karuturi
Thanks Will. I will take a look at this today and merge.

Is it possible to add a systemvmtemplate job on
builds.apachecloudstack.net (https://builds.cloudstack.org/)
similar to
http://jenkins.buildacloud.org/job/build-systemvm64-master/ ?

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On February 13, 2017 at 10:46 PM, Will Stevens
(wstev...@cloudops.com) wrote:

At this point, I think 1741 is ready to merge. I think we need
one more
LGTM though...

*Will STEVENS*
Lead Developer



On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens
 wrote:

@Daan: In order for the tests to pass with 1741, the tests have
to be run
with the SystemVM from the PR being used.

*Will STEVENS*
Lead Developer



On Wed, Feb 8, 2017 at 2:46 AM, Daan Hoogland

wrote:

About 1741, I started the packaging, Will but saw Boris making a
remark about the system VMs. I'll look into that and start the
tests.

On Tue, Feb 7, 2017 at 8:19 PM, Will Stevens

wrote:

I would like to get 1741(strongswan) in, but I need to get
Trillian to

run

against it with a system vm built from my pr. I have done a CI in
bubble
and it came back clean, but would like confirmation through
Trillian as
well.

On Feb 7, 2017 2:17 PM, "Milamber"  wrote:

And this PR for 4.9 but need to be foward to 4.10 too.

https://github.com/apache/cloudstack/pull/1929

2 LGTM
CI green

On 07/02/2017 13:07, Rajani Karuturi wrote:

Hi all,
If you know of any PRs which meet the below criteria, please
mail

them to

me.
1. No open questions.
2. Has two LGTMs
3. Has CI test results.

~Rajani
http://cloudplatform.accelerite.com

--
Daan

[GitHub] cloudstack issue #1860: CLOUDSTACK-9703: Fixed Start VM does not honor clust...

2017-02-13 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1860
  
 ### ACS CI BVT Run
 **Sumarry:**
 Build Number 320
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1939
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Beauty. Good job. Thanks for doing that. :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #25: Updated list with makewholist.py

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/25
  
Before this PR reaches its one year of age, I will merge this tomorrow if 
no one objects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Merged; the good part is that I followed the new tutorial we developed, and 
it worked like a charm ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-www/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-02-13 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
Hi @jayakarteek @rafaelweingartner,

I confirm issue, I tested using an instance with 1 CPU 500Mhz. I'll add 
screenshots for cases when CPU utilization is low and high:

First, with little utilization, vSphere shows 51Mhz CPU Utilization, while 
on Management Server statistics shows 51% CPU utilization

![cpu51](https://cloud.githubusercontent.com/assets/5295080/22908776/1e437a10-f22f-11e6-87a5-6933c990f911.JPG)

![cpu512](https://cloud.githubusercontent.com/assets/5295080/22908783/26db1ba6-f22f-11e6-9a83-8743d7abb0e8.JPG)

Then, ran a loop to increase CPU utilization increasing it to ~1609Mhz and 
Management Server statistics shows 1609% CPU Utilization,

![cpu1600](https://cloud.githubusercontent.com/assets/5295080/22908949/fed18ad6-f22f-11e6-9635-23cd5da38cba.JPG)

![cpu16002](https://cloud.githubusercontent.com/assets/5295080/22908951/01fb02fa-f230-11e6-8f72-739709c87984.JPG)

Hope this helps!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Build Failure on Master

2017-02-13 Thread Tutkowski, Mike
Thanks!

> On Feb 13, 2017, at 2:52 PM, Sergey Levitskiy  
> wrote:
> 
> Thankfully @rhtyd maintains a repo of all dependencies 
> 
>>> 
> @serg38 I've been maintaining the non-oss libs here: 
> https://github.com/rhtyd/cloudstack-nonoss
>You can get the latest v12.1 library that is Java8 compatible from above, 
> it also includes the install-non-oss.sh script, you can simply clone the repo 
> and run it before building/packaging (in Jenkins too), in fact Travis jobs 
> actually do that: 
> https://github.com/apache/cloudstack/blob/master/tools/travis/install.sh#L28
> 
> 
> 
> 
> On 2/13/17, 1:44 PM, "Rafael Weingärtner"  wrote:
> 
>Yes, it is.
> 
>This plugin is not on Maven central repo. You have to install it manually
>on your local maven repo.
> 
>On Mon, Feb 13, 2017 at 4:41 PM, Tutkowski, Mike 
> 
>wrote:
> 
>> Hi,
>> 
>> I may have missed it in recent e-mails, but is this a known issue and, if
>> so, how can I get around it?
>> 
>> [ERROR] Failed to execute goal on project cloud-plugin-network-f5: Could
>> not resolve dependencies for project org.apache.cloudstack:cloud-
>> plugin-network-f5:jar:4.10.0.0-SNAPSHOT: Could not find artifact
>> com.cloud.com.f5:icontrol:jar:12.1 in central (https://repo.maven.apache.
>> org/maven2) -> [Help 1]
>> 
>> Thanks!
>> Mike
>> 
> 
> 
> 
>-- 
>Rafael Weingärtner
> 
> 


[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1878
  
Hi @sureshanaparti 
Would you mind extracting the code at lines 1967-1972 to a specific method? 
Then, it allows you to write test cases for the newly created method and proper 
documentation of the method behaviors?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Build Failure on Master

2017-02-13 Thread Sergey Levitskiy
Thankfully @rhtyd maintains a repo of all dependencies 

>>
@serg38 I've been maintaining the non-oss libs here: 
https://github.com/rhtyd/cloudstack-nonoss
You can get the latest v12.1 library that is Java8 compatible from above, 
it also includes the install-non-oss.sh script, you can simply clone the repo 
and run it before building/packaging (in Jenkins too), in fact Travis jobs 
actually do that: 
https://github.com/apache/cloudstack/blob/master/tools/travis/install.sh#L28




On 2/13/17, 1:44 PM, "Rafael Weingärtner"  wrote:

Yes, it is.

This plugin is not on Maven central repo. You have to install it manually
on your local maven repo.

On Mon, Feb 13, 2017 at 4:41 PM, Tutkowski, Mike 
wrote:

> Hi,
>
> I may have missed it in recent e-mails, but is this a known issue and, if
> so, how can I get around it?
>
> [ERROR] Failed to execute goal on project cloud-plugin-network-f5: Could
> not resolve dependencies for project org.apache.cloudstack:cloud-
> plugin-network-f5:jar:4.10.0.0-SNAPSHOT: Could not find artifact
> com.cloud.com.f5:icontrol:jar:12.1 in central (https://repo.maven.apache.
> org/maven2) -> [Help 1]
>
> Thanks!
> Mike
>



-- 
Rafael Weingärtner




Re: Build Failure on Master

2017-02-13 Thread Rafael Weingärtner
Yes, it is.

This plugin is not on Maven central repo. You have to install it manually
on your local maven repo.

On Mon, Feb 13, 2017 at 4:41 PM, Tutkowski, Mike 
wrote:

> Hi,
>
> I may have missed it in recent e-mails, but is this a known issue and, if
> so, how can I get around it?
>
> [ERROR] Failed to execute goal on project cloud-plugin-network-f5: Could
> not resolve dependencies for project org.apache.cloudstack:cloud-
> plugin-network-f5:jar:4.10.0.0-SNAPSHOT: Could not find artifact
> com.cloud.com.f5:icontrol:jar:12.1 in central (https://repo.maven.apache.
> org/maven2) -> [Help 1]
>
> Thanks!
> Mike
>



-- 
Rafael Weingärtner


Build Failure on Master

2017-02-13 Thread Tutkowski, Mike
Hi,

I may have missed it in recent e-mails, but is this a known issue and, if so, 
how can I get around it?

[ERROR] Failed to execute goal on project cloud-plugin-network-f5: Could not 
resolve dependencies for project 
org.apache.cloudstack:cloud-plugin-network-f5:jar:4.10.0.0-SNAPSHOT: Could not 
find artifact com.cloud.com.f5:icontrol:jar:12.1 in central 
(https://repo.maven.apache.org/maven2) -> [Help 1]

Thanks!
Mike


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
@karuturi 

Smoke test test_internal_lb.py  uses  a value of 
network.loadbalancer.haproxy.stats.auth which is encrypted for haproxy checks. 

settings["username"], settings["password"] = Configurations.list(
self.apiclient, 
name="network.loadbalancer.haproxy.stats.auth")[0].value.split(":")

Looks like the test needs to be reworked to support decryption. 

test_04_rvpc_internallb_haproxy_stats_on_all_interfaces 
(tests.smoke.test_internal_lb.TestInternalLb): DEBUG: Sending GET Cmd : 
listConfigurations===
requests.packages.urllib3.connectionpool: DEBUG: Starting new HTTP 
connection (1): 10.2.2.74
requests.packages.urllib3.connectionpool: DEBUG: http://10.2.2.74:8080 "GET 
/client/api?apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&name=network.loadbalancer.haproxy.stats.auth&command=listConfigurations&signature=CIbKLFE4BGTK3QsvDeeO3Aux0nY%3D&response=json
 HTTP/1.1" 200 266
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces 
(tests.smoke.test_internal_lb.TestInternalLb): DEBUG: Response : [{category : 
u'Secure', name : u'network.loadbalancer.haproxy.stats.auth', value : 
u'fjtpluk/LdwnvDx4FKo1z1JRAZTaW1Td', description : u'Load Balancer(haproxy) 
authetication string in the format username:password'}]
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces 
(tests.smoke.test_internal_lb.TestInternalLb): CRITICAL: EXCEPTION: 
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most 
recent call last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 
369, in run\ntestMethod()\n', '  File 
"/marvin/tests/smoke/test_internal_lb.py", line 784, in 
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces\n
self.execute_internallb_haproxy_tests(redundant_vpc_offering)\n', '  File 
"/marvin/tests/smoke/test_internal_lb.py", line 788, in 
execute_internallb_haproxy_tests\nsettings = 
self.get_lb_stats_settings()\n', '  File 
"/marvin/tests/smoke/test_internal_lb.py", line 714, in get_lb_stats_settings\n 
   self.fail("Failed to retrieve stats settings " % e)\n', 'TypeError: not all 
arguments converted during string formatting\n']


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1907#discussion_r100904660
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
 gw = interface.get_gateway()
 logging.info("Interface has the following gateway ==> %s", gw)
 
-if bag['nw_type'] == "guest" and rip == gw:
+guest_gw = self.config.cmdline().get_guest_gw()
+logging.info("Interface has the following gateway ==> %s", 
guest_gw)
+
+if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
--- End diff --

ok, got it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...

2017-02-13 Thread swill
Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1907#discussion_r100902927
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
 gw = interface.get_gateway()
 logging.info("Interface has the following gateway ==> %s", gw)
 
-if bag['nw_type'] == "guest" and rip == gw:
+guest_gw = self.config.cmdline().get_guest_gw()
+logging.info("Interface has the following gateway ==> %s", 
guest_gw)
+
+if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
--- End diff --

I find that makes the code a bit harder to read if we did that. Then it is 
not as obvious you are returning a boolean. This stuff is already complicated, 
for two lines of code, I don't think it makes sense to make it harder to 
understand. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
Trillian test result (tid-816)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34139 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr927-t816-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 335.42 | 
test_privategw_acl.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 5.25 | 
test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 5.25 | 
test_internal_lb.py
test_01_vpc_site2site_vpn | Success | 164.87 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.24 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 261.06 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 272.02 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 537.68 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 506.98 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1401.04 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 553.90 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 755.09 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1279.89 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.43 | test_volumes.py
test_08_resize_volume | Success | 151.30 | test_volumes.py
test_07_resize_fail | Success | 161.50 | test_volumes.py
test_06_download_detached_volume | Success | 156.28 | test_volumes.py
test_05_detach_volume | Success | 155.78 | test_volumes.py
test_04_delete_attached_volume | Success | 151.21 | test_volumes.py
test_03_download_attached_volume | Success | 156.29 | test_volumes.py
test_02_attach_volume | Success | 94.50 | test_volumes.py
test_01_create_volume | Success | 711.50 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.67 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 163.73 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 247.47 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.63 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 41.12 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.15 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.76 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.78 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.16 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.30 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 45.49 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.14 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.17 | test_templates.py
test_01_create_template | Success | 40.41 | test_templates.py
test_10_destroy_cpvm | Success | 161.77 | test_ssvm.py
test_09_destroy_ssvm | Success | 138.62 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.53 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.47 | test_ssvm.py
test_06_stop_cpvm | Success | 131.71 | test_ssvm.py
test_05_stop_ssvm | Success | 163.59 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 3.23 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.24 | test_snapshots.py
test_04_change_offering_small | Success | 240.58 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.06 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py

[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1881
  
@sureshanaparti Thanks for the cleanup. LGTM
@sateesh-chodapuneedi this is a good question. The changes here remove an 
attribute of an Enum that is not referenced anywhere. In my opinion, we should 
not need to run function tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1886
  
@jayapalu you changed the request type to `POST`. Is the server side (the 
bit that will handle/deliver this request) expecting `POST` requests as well?

Also, how do you feel about extracting the request object creation (lines 
214-219) to a specific method? Then, we can document and describe what how the 
method is supposed to work; it also enabled the writing of test cases (for this 
request creation method).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1907#discussion_r100897492
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
 gw = interface.get_gateway()
 logging.info("Interface has the following gateway ==> %s", gw)
 
-if bag['nw_type'] == "guest" and rip == gw:
+guest_gw = self.config.cmdline().get_guest_gw()
+logging.info("Interface has the following gateway ==> %s", 
guest_gw)
+
+if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
--- End diff --

This is more like a curiosity than anything else. 
What do you think about using only `return bag['nw_type'] == "guest" and 
(rip == gw or rip == guest_gw)` ? It does not feel that we need the conditional 
here.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
@jayakarteek this problem is happening only for VMware, right?

@nvazquez could you confirm this problem here? I believe you have access to 
an ACS system that orchestrates VMware deployment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1919
  
@serbaut  I would only like to make a few questions to see if I understood 
the issue here, before evaluating the code any further.

When you first deploy the VM, the keys are delivered to the newly deployed 
VM, right? The problem only happens on reboots?

Do we need to always keep sending the same access keys? Is not one time 
enough? Of course, if the keys are changed, we should send them; but otherwise, 
it feels that we should not need to keep sending them.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Yes, I think we are good to go to merge this change.

On Mon, Feb 13, 2017 at 1:45 PM, Rafael Weingärtner <
notificati...@github.com> wrote:

> I agree with you @swill 
> So, if we intend to change this working flow, we will have a detailed
> discussion somewhere else.
> Can I assume we ok to go here, and merge this PR?
>
> BTW: there is a PR for the Cloudstack-WWW that is going to have a birthday
> this month (February 24), I think we should all celebrate it ;)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
Great, thanks @borisstoyanov!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
I agree with you @swill 
So, if we intend to change this working flow, we will have a detailed 
discussion somewhere else.
Can I assume we ok to go here, and merge this PR?

BTW: there is a PR for the Cloudstack-WWW that is going to have a birthday 
this month (February 24), I think we should all celebrate it ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-13 Thread remibergsma
Github user remibergsma commented on the issue:

https://github.com/apache/cloudstack/pull/1934
  
What about signed S3 urls that people may supply? If you want to register a 
template and have it download from a S3 bucket, you need to specify a signed 
url to provide the authentication. But that signature is valid for either GET 
or HEAD requests, not both. 

When you use S3 as secondary storage, you automatically get a GET 
pre-signed url from CloudStack that you cannot use to register it as a new 
template. Something to think about..

See: 
http://stackoverflow.com/questions/15717230/pre-signing-amazon-s3-urls-for-both-head-and-get-verbs
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
There you go @nvazquez, results should come up in 6-8 hours.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@blueorangutan test centos7 vmware-60u2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: PRs for 4.10

2017-02-13 Thread Will Stevens
At this point, I think 1741 is ready to merge.  I think we need one more
LGTM though...

*Will STEVENS*
Lead Developer



On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens  wrote:

> @Daan: In order for the tests to pass with 1741, the tests have to be run
> with the SystemVM from the PR being used.
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 8, 2017 at 2:46 AM, Daan Hoogland 
> wrote:
>
>> About 1741, I started the packaging, Will but saw Boris making a
>> remark about the system VMs. I'll look into that and start the tests.
>>
>> On Tue, Feb 7, 2017 at 8:19 PM, Will Stevens 
>> wrote:
>> > I would like to get 1741(strongswan) in, but I need to get Trillian to
>> run
>> > against it with a system vm built from my pr. I have done a CI in bubble
>> > and it came back clean, but would like confirmation through Trillian as
>> > well.
>> >
>> > On Feb 7, 2017 2:17 PM, "Milamber"  wrote:
>> >
>> >>
>> >> And this PR for 4.9 but need to be foward to 4.10 too.
>> >>
>> >> https://github.com/apache/cloudstack/pull/1929
>> >>
>> >> 2 LGTM
>> >> CI green
>> >>
>> >>
>> >> On 07/02/2017 13:07, Rajani Karuturi wrote:
>> >>
>> >>> Hi all,
>> >>> If you know of any PRs which meet the below criteria, please mail
>> them to
>> >>> me.
>> >>> 1. No open questions.
>> >>> 2. Has two LGTMs
>> >>> 3. Has CI test results.
>> >>>
>> >>> ~Rajani
>> >>> http://cloudplatform.accelerite.com
>> >>>
>> >>>
>> >>
>>
>>
>>
>> --
>> Daan
>>
>
>


[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
Thanks @borisstoyanov! Can we test it against Vmware?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1934
  
Trillian test result (tid-815)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27420 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1934-t815-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 48 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 315.33 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 160.02 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 61.36 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 230.58 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 269.92 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 533.06 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 485.65 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1413.44 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 538.62 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 734.57 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1290.28 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 151.53 | test_volumes.py
test_08_resize_volume | Success | 156.46 | test_volumes.py
test_07_resize_fail | Success | 161.45 | test_volumes.py
test_06_download_detached_volume | Success | 156.32 | test_volumes.py
test_05_detach_volume | Success | 150.78 | test_volumes.py
test_04_delete_attached_volume | Success | 151.31 | test_volumes.py
test_03_download_attached_volume | Success | 156.32 | test_volumes.py
test_02_attach_volume | Success | 89.12 | test_volumes.py
test_01_create_volume | Success | 621.05 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.21 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.83 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 133.77 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 282.86 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.66 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.31 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 35.88 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 130.85 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.84 | test_vm_life_cycle.py
test_02_start_vm | Success | 5.13 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.31 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 60.61 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.14 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.20 | test_templates.py
test_01_create_template | Success | 65.56 | test_templates.py
test_10_destroy_cpvm | Success | 161.62 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.23 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.34 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.78 | test_ssvm.py
test_06_stop_cpvm | Success | 131.50 | test_ssvm.py
test_05_stop_ssvm | Success | 133.61 | test_ssvm.py
test_04_cpvm_internals | Success | 0.98 | test_ssvm.py
test_03_ssvm_internals | Success | 3.38 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.48 | test_snapshots.py
test_04_change_offering_small | Success | 209.62 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.15 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 35.31 | test_routers.py
test_08_start_router | Success | 30.28 | test_routers.py
test_07_stop_router | Success | 10.19 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success |

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Yes @rafaelweingartner, that is also my concern.  It **probably** would be 
fine because the `.gitignore` would handle the problem cases with the merges (I 
hope), but it would make it less obvious to the end user what was going on for 
sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
@swill the procedure you described seems to be the way to go. However, as 
our discussion regarding the Jenkins idea, I am not convinced about the 
benefits of the change in procedures (this time I am the skeptical one). Also, 
it feels that the change would bring complications for merges (it would not be 
straightforward anymore).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack-www/pull/34#discussion_r100827279
  
--- Diff: content/about.html ---
@@ -79,7 +78,7 @@
 Get 
Involved
 Developers
 Mailing 
Lists
-http://lanyrd.com/topics/apache-cloudstack/"; target="_blank">Events & 
Meetups 
--- End diff --

I was going to say exactly that. At least for me, it feels something that 
we stopped using and maintaining a long time ago. Could not we use the 
system/website of CCC for spread the word about user group meeting too? Then, 
we centralize information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread swill
Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack-www/pull/34#discussion_r100826211
  
--- Diff: content/about.html ---
@@ -79,7 +78,7 @@
 Get 
Involved
 Developers
 Mailing 
Lists
-http://lanyrd.com/topics/apache-cloudstack/"; target="_blank">Events & 
Meetups 
--- End diff --

No one uses it though. It is just empty. Do we even have credentials 
somewhere to add to that? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread pdion891
Github user pdion891 commented on a diff in the pull request:

https://github.com/apache/cloudstack-www/pull/34#discussion_r100800298
  
--- Diff: content/about.html ---
@@ -79,7 +78,7 @@
 Get 
Involved
 Developers
 Mailing 
Lists
-http://lanyrd.com/topics/apache-cloudstack/"; target="_blank">Events & 
Meetups 
--- End diff --

I'm not sure we want to ditch lanyrd link, it's usefull to publish other 
event that collabs, like meetups.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
So how would this work?  We would have a `.gitignore` tracked in `master` 
which would make the `content` folder untracked?  The `.gitignore` tracked in 
the `asf-site` branch would not include the `content` directory?

So then when you develop, it would not be as simple as a `merge` from 
`master` into `asf-site` anymore because the tracked files are not consistent 
between those branches anymore.

Would the flow be something like this then:
- Get the PR approved in `master`.
- Do a `merge` from `master` to `asf-site`.
- Run the `./build.sh` script in `asf-site`.
- Push code to `asf-site` branch.

Does that seem right?  We would have to do a `git rm` of the content on the 
`master` branch and then update the `.gitignore` tracked in that branch.

I don't think we need to worry about these changes in this PR though. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Let's change the model but not in this PR ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
@pdion891, got your idea; but, for this PR do we keep with the current 
"working model, versioning the `content` folder in `master` branch" or you 
would like to change this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
sorry,  so yeah,   no html in the PR, only in asf-site when merge is 
aprouve, than html generated by the commiter merging the PR.  make sense?   
since `content` folder already exist, no need to change this PR for this ;-)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
@pdion891, 
you have a double negation in the sentence, but I am reading as "we should 
not include *.html files in the PR. We should only generate and send them (HTML 
files) to `asf-site` branch after the PR is merged."

That is a good question. I only followed the pattern that has been used so 
far. I could remove the `content` from the master branch, though. Then, we 
could only maintain the `content` folder with HTMLs only on `asf-site` branch.

I do not mind working in one way or the other; It is up to you guys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1818: CLOUDSTACK-9655 The template which is registered in ...

2017-02-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1818
  
related to this PR, I doubt the action in deleteTemplate on UI (from a 
zone).
```
 if 
(!args.context.templates[0].crossZones){
queryParams += 
"&zoneid=" + args.context.zones[0].zoneid;
 }
```
should "!" is removed in the first line ?

I would suggest to add the new button in the template details page, and use 
this warning message ("message.action.delete.template.for.all.zones").




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
I haven't follow this whole thread but shouldn't we not include .html files 
in PR and master branch and only push them in the asf-site branch once approved 
?  this would make master and PR cleaners.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...

2017-02-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1885
  
The issue can be reproduced and fixed by this PR.
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1939
  
code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME ...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1938


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
good point @swill. Thanks @borisstoyanov.
Since the fix is no different from the earlier version for 1.7, I am 
assuming it should work for 1.8 as well on ubuntu.
merging this now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1939
  
```
[INFO] Apache CloudStack Plugin - F5 . SUCCESS [2.778s]
[INFO] Apache CloudStack Plugin - Juniper SRX  FAILURE [0.107s]
[INFO] Apache CloudStack VMware Base . SKIPPED

[INFO] 

[ERROR] Failed to execute goal on project cloud-plugin-network-srx: Could 
not resolve dependencies for project 
org.apache.cloudstack:cloud-plugin-network-srx:jar:4.10.0.0-SNAPSHOT: Could not 
find artifact com.cloud.com.f5:icontrol:jar:1.0 in central 
(https://repo.maven.apache.org/maven2) -> [Help 1]
```
@jayapalu looks like some dependency is missing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1939
  
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-482


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1876: CLOUDSTACK-9715: Update somaxconn value to de...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1876


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #928: CLOUDSTACK-8950 Hypervisor Parameter check is ...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/928


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1876: CLOUDSTACK-9715: Update somaxconn value to default v...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1876
  
travis failure not related. merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1939
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-481


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1939
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1818: CLOUDSTACK-9655 The template which is registered in ...

2017-02-13 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1818
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #858: CLOUDSTACK-8886: Limitations is listUsageRecords outp...

2017-02-13 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/858
  
created new #PR 1939 for this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1939: CLOUDSTACK-8886: Limitations is listUsageReco...

2017-02-13 Thread jayapalu
GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1939

CLOUDSTACK-8886: Limitations is listUsageRecords output, listUsageRec…

As @kansal  is inactive created new branch and raised the PR. This is 
continuation of PR#858
https://github.com/apache/cloudstack/pull/858

Problem: Only domainid is returned by usageReports API call. In cloudstack 
documention it mentions "domain" as being in the usage response. The API should 
really be returning the domain as account information has both account and 
accountid.

Fix: Missing setDomainName at the time of creating response.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8886

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1939.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1939


commit f17d27dd93e7c1b0ba60afdf78276a8b07c4dff0
Author: Kshitij Kansal 
Date:   2015-09-21T06:18:17Z

CLOUDSTACK-8886: Limitations is listUsageRecords output, listUsageRecords 
does not return domain - Fixed and tests added




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1818: CLOUDSTACK-9655 The template which is registe...

2017-02-13 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1818#discussion_r100771599
  
--- Diff: ui/scripts/templates.js ---
@@ -1447,7 +1447,11 @@
  label: 
'label.action.delete.template',
  messages: {
  confirm: 
function(args) {
- return 
'message.action.delete.template';
+ 
if(args.context.templates[0].crossZones == true) {
+ return 'This 
is a cross zone template and will be deleted from all the zones. Are you sure 
you want to proceed?';
--- End diff --

used an existing message from properties


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
@anshul1886 can you and @nvazquez work together and create a single PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
Code changes looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...

2017-02-13 Thread koushik-das
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1885
  
Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...

2017-02-13 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1885#discussion_r100767709
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, 
boolean postApplyRules, List 0) {
+if (network.getVpcId() != null) {
--- End diff --

@jayapalu Please improve the code comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1876: CLOUDSTACK-9715: Update somaxconn value to default v...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1876
  
merging. simple config change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #843: Security group ingress/egress issues with xens...

2017-02-13 Thread jayapalu
Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/843#discussion_r100766384
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -356,18 +356,25 @@ def allow_egress_traffic(session):
 return 'false'
 return 'true'
 
+def getIpsetType():
+try:
+util.pread2(['/bin/bash', '-c', "ipset -v | grep 'protocol 
version: 6'"])
+return 'nethash'
--- End diff --

For xenserver 6.5 the ipset version is 6.  For xenserver version less than 
6.5 (i.e 6.2) the ipset version is 4.x. 
if ipset version is 6 then it uses nethash otherwise it uses iptreemap
The getIpsetType method is as below.
def getIpsetType():
try:
util.pread2(['/bin/bash', '-c', "ipset -v | grep 'protocol version: 
6'"])
return 'nethash'
except:
return 'iptreemap'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1183: Marvin test to verify that adding TCP ports 5...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1183


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1183: Marvin test to verify that adding TCP ports 500,4500...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1183
  
failures are note related. merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1416: CLOUDSTACK-8717: Failed to start instance aft...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1416


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/873
  
added ifdebugenabled() checks 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1855: CLOUDSTACK-9697: Better error message if user tries ...

2017-02-13 Thread sadhugit
Github user sadhugit commented on the issue:

https://github.com/apache/cloudstack/pull/1855
  
tested on my setup and Looks good to me.
Need to handle on API side  so please update the Bug description  by adding 
UI only


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-02-13 Thread anshul1886
Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/669


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-02-13 Thread anshul1886
GitHub user anshul1886 reopened a pull request:

https://github.com/apache/cloudstack/pull/669

Made the adding new keyboard language support easier

https://issues.apache.org/jira/browse/CLOUDSTACK-8665

This branch has implemented following improvements in console proxy 
keyboard language support

1) ajaxviewer.js and ajaxkeys.js are main files involved in key code 
translations. These files now can be copied in systemvm/js folder and they will 
be copied to CPVM with stop/start performed on it.
2) Started passing parameters to CPVM needed to resolve the ambiguous cases 
of keycode translations.
3) Generalise the framework such that one needs to modify only ajaxkeys.js 
(file which has keycode mappings) without need of much knowledge in js.

FS for this feature is available at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy

After these changes how to add keyboard support for new language or fix 
existing broken keys WIP document  is available at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Adding+support+for+non-US+Keyboard+for+Console+Proxy


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 nonuskeyboardsupport

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #669


commit 31e12325e715420536ee3215e312474be1b258a5
Author: Anshul Gangwar 
Date:   2015-08-04T04:54:16Z

CLOUDSTACK-8665: Added following improvements:
1. Added support for copying js files from management server to console 
proxy VM with stop start
2. Generalise console keyboard support framework
3. Passing additional parameters which will be needed for keyboard mappings 
for vm console
4. Moved the console Keyboard Options to new file so that user can add 
keyboard options easily
5. Improved memory footprint, now keeping only required locale mappings
6. Added more conditions while setting up translation table
7. Improved browser detection for keyboard mappings
8. Formatted ajaxviewer.js and ajaxkeys.js with spaces instead of tabs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #928: CLOUDSTACK-8950 Hypervisor Parameter check is ...

2017-02-13 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/928#discussion_r100753379
  
--- Diff: server/src/com/cloud/template/TemplateAdapterBase.java ---
@@ -293,9 +298,15 @@ public TemplateProfile 
prepare(GetUploadParamsForTemplateCmd cmd) throws Resourc
 zoneId = -1L;
 }
 
+HypervisorType hypervisorType = 
HypervisorType.getType(cmd.getHypervisor());
+if(hypervisorType == HypervisorType.None) {
+throw new InvalidParameterValueException("Hypervisor Type: " + 
cmd.getHypervisor() + " is invalid. Supported Hypervisor types are "
+ + 
EnumUtils.listValues(HypervisorType.values()).replace("None, ", ""));
+}
--- End diff --

@GabrielBrascher there is lot of duplicate code between the methods. A 
proper cleanup has to be planned. Cant take up now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1934
  
OK @marcaurele, if you're 100% sure it works as expected it could be that 
we need to redesign the test itself, I guess it needs deeper investigation of 
the failure itself. 
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1934
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
@karuturi unfortunately we've hit an issue with the ubuntu images, didn't 
manage to deploy the Trillian env.. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [PROPOSAL] Extra DHCP options

2017-02-13 Thread Kris Sterckx
Hi all

Comparing storing a set of DHCP options as extra json info in nic details
with a new formal specification in sql, I would judge the formal approach
as long-term preferred ?
I understand everything can be modeled in json as well - i just want to
understand better the arguments pro that approach, compared to the proposed
extra table. Json has the drawback of higher error proneness (as less
formal) and (slightly) reduced performance, as I see it. Also depending on
the design, every network plugin would need to understand how to process
the json info, again relating to my point of error-proneness.

thanks,

Kris

On 8 February 2017 at 16:49, Sergey Levitskiy  wrote:

> I personally like this option. This way you can obtain all DHCP options at
> once very fast and manipulate them as you see fit in the respective module
>- A second option could be that we store all the DHCP options in
> *one*
>key,value pair.
>
> As key we pick a specific value say; "extra_dhcp_options" and as
> value: we
> decode all the dhcp options (code + value) as json. This makes updating
> DHCP options on a nic more complex.
>
>
>
>