[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1907
  
code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1972
  
code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
updated.
changes
(1) add init-system-helpers version
(2) add ExecStartPre to avoid the issue caused by JAVA_HOME


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PRs for 4.10

[Rajani Karuturi]

please use the criteria mentioned at http://acspr.ena.net/help.html to tag
PRs as merge ready.

~Rajani
http://cloudplatform.accelerite.com/

On Thu, Feb 23, 2017 at 4:24 AM, Sergey Levitskiy <
sergey.levits...@autodesk.com> wrote:

> I would like to get this added
> https://github.com/apache/cloudstack/pull/1935
>
>
> On 2/22/17, 2:33 PM, "David Mabry"  wrote:
>
> I would like to see the following PRs merged:
>
> https://github.com/apache/cloudstack/pull/1915
> https://github.com/apache/cloudstack/pull/1954 <- This one could be
> backported to 4.8/4.9
>
> Collectively, these solve an issue that causes the VPC router to fail
> due to a full /var/log FS.  We’ve tested these extensively in the lab and
> confirmed that it does solve the problem.
>
> Thanks,
> David Mabry
>
> On 2/22/17, 2:00 PM, "williamstev...@gmail.com on behalf of Will
> Stevens" 
> wrote:
>
> I would like to get this fix in:
> https://github.com/apache/cloudstack/pull/1907
>
> This fix is really important because it causes routing issues when
> the IP,
> which was not cleaned up, is later used on a different VR.
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 22, 2017 at 5:29 AM, Rohit Yadav <
> rohit.ya...@shapeblue.com>
> wrote:
>
> > Rajani and all,
> >
> >
> > Please consider following PRs for review and merge:
> >
> >
> > https://github.com/apache/cloudstack/pull/1829 (XenServer HVM
> VM attached
> > disk limit bugfix, enough LGTMs and test results)
> >
> > https://github.com/apache/cloudstack/pull/1941 (same as above
> with
> > additional fixes, lacks review lgtms)
> > https://github.com/apache/cloudstack/pull/1896 (translation
> updates)
> >
> > https://github.com/apache/cloudstack/pull/1770 (template size
> issue
> > bugfix)
> >
> > https://github.com/apache/cloudstack/pull/1950 (Ubuntu 16.04
> packaging
> > tomcat6/7 support)
> >
> > https://github.com/apache/cloudstack/pull/1951 (xenserver7
> capability fix
> > and upgrade path from 4.9.2->4.9.3)
> >
> > https://github.com/apache/cloudstack/pull/1944 (metrics view
> and infra
> > tab/UI performance improvement)
> > https://github.com/apache/cloudstack/pull/1903 (cannot add
> users to vpc
> > vpn)
> >
> > https://github.com/apache/cloudstack/pull/1945
> >
> > https://
> > github.com/apache/cloudstack/pull/1946
> >
> > https://
> > github.com/apache/cloudstack/pull/1947
> > https://github.com/apache/cloudstack/pull/1856
> > https://github.com/apache/cloudstack/pull/1212
> >
> >
> >
> > Regards.
> >
> > 
> > From: Rajani Karuturi 
> > Sent: 22 February 2017 14:41:42
> > To: dev@cloudstack.apache.org
> > Subject: Re: PRs for 4.10
> >
> > 6 days to go for the first RC.
> > Please get the required lgtms and tests ready for the PRs you
> like to see
> > in 4.10.
> > I will try to merge all the PRs that meet the criteria.
> >
> > Thanks,
> > ~Rajani
> >
> > On 19 Feb 2017 3:11 p.m., "Rajani Karuturi" 
> wrote:
> >
> > > noted.
> > >
> > >
> > > ~ Rajani
> > >
> > > http://cloudplatform.accelerite.com/
> > >
> > >
> > > On February 17, 2017 at 6:03 PM, Frank Maximus (
> > > frank.maxi...@nuagenetworks.net) wrote:
> > >
> > > I have a couple of bugfixes on previous version outstanding,
> > > which I would like to have merged to 4.10,
> > > both still requiring review:
> > > on 4.8: PR#1912  cloudstack/pull/1912>: which
> > > fixes password service running on internal lb vms, making it
> impossible
> > to
> > > do loadbalancing on port 8080
> > > on 4.9: PR#1925  cloudstack/pull/1925>: Minor
> > > plugin fix
> > >
> > > Kind Regards,
> > > Frank
> > >
> > > On Tue, Feb 14, 2017 at 10:56 PM Syed Ahmed <
> sah...@cloudops.com> wrote:
> > >
> > > I'd like to include https://github.com/apache/
> cloudstack/pull/1928 to
> > 4.10
> > > as well. This is a simple fix that adds hypervisor
> capabilities for
> > > XenServer 7
> > >
> > > Thanks,
> > > -Syed
> 

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@rhtyd The permission issue seems to be caused by 
./scripts/vm/systemvm/injectkeys.sh


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@rhtyd @karuturi To fix errors in B.O in 
test_02_list_snapshots_with_removed_data_store we need to merge PR1961 and then 
adjust test_data on B.O side to have correct mapping for nfs2 label 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

[yvsubhash]

Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/1942
  
LGTM for code changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

[marcaurele]

Github user marcaurele commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1944#discussion_r103143033
  
--- Diff: plugins/metrics/pom.xml ---
@@ -0,0 +1,55 @@
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+  http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+  cloud-plugin-metrics
+  Apache CloudStack Plugin - Metrics
+  
+org.apache.cloudstack
+cloudstack-plugins
+4.9.3.0-SNAPSHOT
+../pom.xml
+  
+  
+
+  org.apache.cloudstack
+  cloud-api
+  ${project.version}
+
+
+  org.apache.cloudstack
+  cloud-utils
+  ${project.version}
+
+  
+  
+
--- End diff --

Would be nice to follow maven standards on new modules. Since you cannot 
inherit from `cloud-maven-standard` you have to put all those lines:
```

${basedir}/src/main/java

${basedir}/src/main/scripts
${basedir}/src/test/java
${basedir}/target/classes

${basedir}/target/test-classes

  
${basedir}/src/main/resources
  


  
${basedir}/src/test/resources
  

...

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@nvazquez can you check if the failures in above test results are related 
to your changes, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
Thanks @dmabry 
LGTM @karuturi this is ready for merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
@dmabry can we have this in 4.9 as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
LGTM @karuturi this is ready for merge
Ping @abhinandanprateek in case you want to review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1212
  
LGTM @karuturi this is ready for merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1907
  
LGTM @karuturi this is ready for merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Modern template hosting

[Raja Pullela]

Hi will, 

I believe, we didn’t get to close ‘getting a mirror on Apache’ because we 
needed someone on the Apache Infra side to close this. BTW, 
cloudstack-apt.get.eu (I think Nux manages this?) has all/most of the content.  
Once we can close on the Apache mirror for hosting the content, I can help 
assist getting the content there.

For now, we have replicated the download.cloud.com content to 
‘s3.download.accelerite.com’.
Also, we are working on a set of steps/procedure to help with this change.  I 
will update everyone in about a week’s time on the details.

Best,
Raja Pullela
Engineering Team,
Accelerite, 2055 Laurelwood Road,
Santa Clara, CA, 95054

On 2/24/17, 11:23 PM, "williamstev...@gmail.com on behalf of Will Stevens" 
 wrote:

unfortunately the template mirror conversation got caught up in details and
nobody took the lead on implementing a solution.

citrix has been pinging me every couple months to say 'dude, we need to
remove the dependency on download.citrix.com', but i have not had the
cycles to get in and solve the problem.  the shutdown of that is imminent
right now, so we need to solve it asap.



*Will STEVENS*
Lead Developer



On Fri, Feb 24, 2017 at 12:38 PM, Paul Angus 
wrote:

> Hi Nathan,
>
> Ideally, if you put the template location in (or use a template defined
> in)  test_data.py then the actual location can be overridden by anyone
> testing.
>
> For Trillian, we've copied all of the templates that people have define to
> a local repo and then replace the URLs in test_data.py to reduce bandwidth
> use and download times.
>
> Ie:
>
> "bootableIso":
> {
> "displaytext": "Test Bootable ISO",
> "name": "testISO",
> "bootable": True,
> "ispublic": False,
> "url": "{{ marvin_images_location
> }}/TinyCore-current.iso",
> "ostype": 'Other Linux (64-bit)',
> "mode": 'HTTP_DOWNLOAD'
> },
>
>
>
> I thought that we had come up with a solution for download.cloud.com, by
> having a mirrorlist hosted in Community Apache 'space' with anyone able to
> out themselves forward as a mirror.
> But I must admit I lost track of whether anyone made the requisite changes
> in code
>
>
>
>
> Kind regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: 24 February 2017 16:30
> To: dev@cloudstack.apache.org
> Subject: Re: Modern template hosting
>
> this is a hard questions.  in general, we should be setting up a mirror on
> some cloudstack/apache domain and then mirror to other provided templates.
>
> we MUST come up with a solution to deprecate 'download.cloud.com', that
> is going to be going away any day now.
>
> i don't know the right way to solve this to be honest, but if you have
> ideas, i am willing to help.
>
>
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Fri, Feb 24, 2017 at 11:25 AM, Nathan Johnson  wrote:
>
> > So not to re-open a can of worms, but I’m in a situation where I need
> > to come up with a Marvin component test that depends on a template
> > based on a kernel that’s relatively new, i.e., newer than Centos 5.3 /
> Ubuntu 10.04 .
> > I see openvm.eu has a suitable template (Ubuntu 16.0.4 for KVM), but
> > from looking at the thread "Migrating CloudStack content from
> > download.cloud.com” it looks like there is resistance to using this at
> > least for hosting system vm templates over concerns of neutrality.
> > Would this be suitable for a component test?  If not, what is a “blessed”
> > template location?
> >
> > Thanks in advance!
> >
> > Nathan Johnson
> > R Engineer
> >
> >
> >
> > 618 Grassmere Park Drive, Suite 12
> > Nashville, TN 37211
> > General Office: 615-312-6000
> >
> > website | blog | support
> >
> >
> >
> >
> >
> >
> >
>






DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1946
  
LGTM. @karuturi let's merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
Thanks @rashmidixit awaiting your review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1945
  
LGTM. @karuturi let's merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1903
  
LGTM. @karuturi let's merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@ustcweizhou can you check the permissions issue I hit in my test, as share 
in my comment above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
LGTM. @karuturi let's merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
Okay @syed either PR need to be merged to solve the issue of restart bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
LGTM. @karuturi let's merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

[shwetaag]

Github user shwetaag commented on the issue:

https://github.com/apache/cloudstack/pull/1949
  
@rhtyd  any updates on this PR .. it shows Travis build failed ..Does this 
need any action on my part ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1886
  
Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1252
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 397
 Hypervisor xenserver
 NetworkType Advanced
 Passed=102
 Failed=3
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed

* test_routers_network_ops.py

 * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 2 
runs

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
2 runs


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...

[niteshsarda]

Github user niteshsarda commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1972#discussion_r103138362
  
--- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDaoImpl.java 
---
@@ -75,4 +84,40 @@ protected LoadBalancerDaoImpl() {
 return listBy(sc);
 }
 
+@Override
+public boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, 
String instanceIp, long networkId, FirewallRule.Purpose purpose)
+{
+SearchBuilder lbVmMapSearch = 
_loadBalancerVMMapDao.createSearchBuilder();
+lbVmMapSearch.and("instanceIp", 
lbVmMapSearch.entity().getInstanceIp(),SearchCriteria.Op.EQ);
+lbVmMapSearch.and("instanceId", 
lbVmMapSearch.entity().getInstanceId(), SearchCriteria.Op.EQ);
+
+SearchBuilder firewallRuleIdSearch = 
_firewallRulesDao.createSearchBuilder();
--- End diff --

@ustcweizhou  : As per suggestion, I have made changes. Please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/669
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1869: CLOUDSTACK-9701: When host is disabled/removed, capa...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1869
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1795: CLOUDSTACK-9625:Unable to scale VM from any offering...

[sudhansu7]

Github user sudhansu7 commented on the issue:

https://github.com/apache/cloudstack/pull/1795
  
Closing this PR as this is already fixed in master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1886#discussion_r103136343
  
--- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java 
---
@@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer 
getPublicIpBytesSentAndReceived(DirectNetworkUs
 answer.put(publicIp, bytesSentAndReceived);
 }
 }
+os.close();
--- End diff --

Updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

[sateesh-chodapuneedi]

Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
@sureshanaparti Can you please investigate the two failures listed in 
results from @cloudmonger?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

[sateesh-chodapuneedi]

Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@karuturi @koushik This has 1 LGTM and test results without any failures.
Can you please review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
Trillian test result (tid-899)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31181 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1958-t899-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 304.33 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 144.36 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 60.88 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 230.23 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 248.04 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 451.81 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 509.74 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1386.69 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 516.32 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 727.69 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1271.79 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.45 | test_volumes.py
test_08_resize_volume | Success | 156.13 | test_volumes.py
test_07_resize_fail | Success | 161.18 | test_volumes.py
test_06_download_detached_volume | Success | 156.01 | test_volumes.py
test_05_detach_volume | Success | 150.57 | test_volumes.py
test_04_delete_attached_volume | Success | 145.93 | test_volumes.py
test_03_download_attached_volume | Success | 156.04 | test_volumes.py
test_02_attach_volume | Success | 88.92 | test_volumes.py
test_01_create_volume | Success | 710.90 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.65 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 128.71 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 262.11 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.52 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.20 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 35.71 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.76 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.67 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.12 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.23 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 30.33 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.02 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.12 | test_templates.py
test_03_delete_template | Success | 5.09 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 30.30 | test_templates.py
test_10_destroy_cpvm | Success | 161.54 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.44 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.26 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.44 | test_ssvm.py
test_06_stop_cpvm | Success | 131.35 | test_ssvm.py
test_05_stop_ssvm | Success | 133.54 | test_ssvm.py
test_04_cpvm_internals | Success | 0.95 | test_ssvm.py
test_03_ssvm_internals | Success | 3.31 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
test_01_snapshot_root_disk | Success | 10.95 | test_snapshots.py
test_04_change_offering_small | Success | 204.34 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
test_09_reboot_router | Success | 30.20 

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 396
 Hypervisor xenserver
 NetworkType Advanced
 Passed=103
 Failed=2
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_routers_network_ops.py

 * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 395
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
@syed yes there is no problem I see, with `INSERT IGNORE` we can have this 
db change in both paths resulting in same final state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 394
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_routers_network_ops.py

 * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---