[GitHub] cloudstack issue #1970: CLOUDSTACK-9725 Failed to update VPC Network during ...

2017-03-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1970
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-03-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
@jayapalu  LGTM

I have two questions
(1) Is it possible to disable the check ?
(2) Could you please fix CLOUDSTACK-9413 (with this PR or in new PR) ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
@bvbharatk  I think the new password should be saved to one of the running 
routers, not all running routers.
I disagree with change line 797.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-06 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1991
  
basic zone is not supported currently with BO @karuturi 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-06 Thread nitin-maharana
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Please find the test plan executed from below link(Updated in wiki page).

https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+with+CloudStack+Test+Plan



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...

2017-03-06 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1875#discussion_r104600403
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -707,6 +709,23 @@ private String setupMountPoint(String parent) {
 return mountPoint;
 }
 
+@Override
+public synchronized void setSystemVmTmpltPermission(String mountPoint) 
{
+if (!s_isSystemVmTmpltPermissionSet) {
+s_logger.debug("Set permissions for " + mountPoint);
+String result = null;
+final String systemVmTmpltPermissions = "0777";
+Script script = new Script(true, "chmod", _timeout, s_logger);
+script.add("-R", systemVmTmpltPermissions, mountPoint);
--- End diff --

@sureshanaparti It would be better if you  can move it to TemplateConstants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-06 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1278
  
@rafaelweingartner, Basically CallContext.current().getCallingAccount(); is 
setting the proper context which is later used. If you have observed in code 
all the api calls have a similar call before proceeding further. One random 
example:

```java
 @ActionEvent(eventType = EventTypes.EVENT_VOLUME_UPLOAD, eventDescription 
= "uploading volume", async = true)
public VolumeVO uploadVolume(UploadVolumeCmd cmd) throws 
ResourceAllocationException {
Account caller = CallContext.current().getCallingAccount(); 
```
For more details refer 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+CallContext and 
commits 7928963 and 11e1e58  which I have mentioned earlier.

Hopefully this clears your doubts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@abhinandanprateek a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) 
has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@abhinandanprateek unsupported parameters provided. Supported mgmt server 
os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, 
kvm-centos7, kvm-ubuntu, xenserver-65sp1, xenserver-62sp1, vmware-60u2, 
vmware-55u3, vmware-51u1, vmware-50u1`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@blueorangutan test vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@abhinandanprateek unsupported parameters provided. Supported mgmt server 
os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, 
kvm-centos7, kvm-ubuntu, xenserver-65sp1, xenserver-62sp1, vmware-60u2, 
vmware-55u3, vmware-51u1, vmware-50u1`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@blueorangutan test vmware



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-06 Thread Tutkowski, Mike
I believe this is another blocker, but probably related to CLOUDSTACK-9822 
(which I just opened):

https://issues.apache.org/jira/browse/CLOUDSTACK-9823

On 3/6/17, 11:32 PM, "Tutkowski, Mike"  wrote:

I seem to have found another blocker:

https://issues.apache.org/jira/browse/CLOUDSTACK-9822

On 3/6/17, 9:51 PM, "Rajani Karuturi"  wrote:

PRs are ready for the blockers. Waiting for reviews and test
results. Once they are ready, I will merge them(and a few more
bug fixes) and create RC2 (probably tomorrow, Wednesday)

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On March 3, 2017 at 4:30 PM, Rajani Karuturi (raj...@apache.org)
wrote:

I will create RC2 on Monday with the fixes mentioned in my
previous mail.

~ Rajani

http://cloudplatform.accelerite.com/

On March 3, 2017 at 2:36 PM, Rohit Yadav
(rohit.ya...@shapeblue.com) wrote:

Thanks Koushik, I did not realize Kishan had sent this already.
Let's get either of the PRs merged and kick a RC2.

Regards.


From: Koushik Das 
Sent: 03 March 2017 14:14:56
To: dev@cloudstack.apache.org
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

Looks like there is already a PR for the same issue
https://github.com/apache/cloudstack/pull/1982 from Kishan.

-Koushik

On 03/03/17, 1:58 PM, "Rohit Yadav" 
wrote:

-1 (binding)

All, I've found an upgrade blocker. Pre 4.6 users are required
to seed 4.6 systemvmtemplate to proceed with the upgrade
otherwise upgrade fails, and from 4.9 upgrade to 4.10 does no
check/enforcement that 4.10 based systemvmtemplate has been
seeded/registered, nor the minimum required systemvmtemplate
version is changed from 4.6.0 to 4.10.0.

After we have merged the strongswan/java8 PR, I had updated the
upgrade docs on how to upgrade the systemvmtemplate here:


http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.10/upgrade/upgrade-4.9.html

Using the above, I've tried to fix these issues here, please
review and merge for RC2:

https://github.com/apache/cloudstack/pull/1983

With above fix,
the aim is that users only seed the 4.10 systemvmtemplate before
upgrade and post-upgrade the upgrade paths fix the entries,
global setting etc.

Regards.


From: Tutkowski, Mike 
Sent: 02 March 2017 22:39:08
To: dev@cloudstack.apache.org
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

I rolled back to my master branch at
da66b06e7d562393da2e4b52206943f8bad49d10 and it works.

It appears something that went into after that commit has broken
this. It looks like this SHA is about two weeks old and that 43
commits have gone into master since it.

On 3/2/17, 7:06 AM, "Tutkowski, Mike"
 wrote:

According to where the code fails, though, it appears to be a
networking problem. If I set a breakpoint before the failure and
change a variable to say that security groups are not being used,
then the VM starts.

I think this is a recently introduced problem because I have
another branch based off of a slightly older version of master
and it works fine here.

> On Mar 2, 2017, at 6:51 AM, Pierre-Luc Dion
 wrote:
>
> Hi Mike,
> Try vm with at least 512MB for memory.
>
>> On Mar 1, 2017 15:01, "Tutkowski, Mike"
 wrote:
>>
>> I see the following exception when trying to deploy a user VM
in a Basic
>> Zone with two XenServer 6.5 hosts in one cluster. My system
VMs have all
>> deployed properly. The user template gets downloaded fine. I
can see the
>> user VM begin to start on a XenServer host, then it goes
away. We then
>> automatically try on the other host. I can see the VM begin
to start there
>> for a moment, then it goes away.
>>
>> I am just deploying the user VM’s template and root disk to
NFS (same
>> place where the template and root disks of my system VMs
are).
>>

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-563


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-06 Thread Tutkowski, Mike
I seem to have found another blocker:

https://issues.apache.org/jira/browse/CLOUDSTACK-9822

On 3/6/17, 9:51 PM, "Rajani Karuturi"  wrote:

PRs are ready for the blockers. Waiting for reviews and test
results. Once they are ready, I will merge them(and a few more
bug fixes) and create RC2 (probably tomorrow, Wednesday)

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On March 3, 2017 at 4:30 PM, Rajani Karuturi (raj...@apache.org)
wrote:

I will create RC2 on Monday with the fixes mentioned in my
previous mail.

~ Rajani

http://cloudplatform.accelerite.com/

On March 3, 2017 at 2:36 PM, Rohit Yadav
(rohit.ya...@shapeblue.com) wrote:

Thanks Koushik, I did not realize Kishan had sent this already.
Let's get either of the PRs merged and kick a RC2.

Regards.


From: Koushik Das 
Sent: 03 March 2017 14:14:56
To: dev@cloudstack.apache.org
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

Looks like there is already a PR for the same issue
https://github.com/apache/cloudstack/pull/1982 from Kishan.

-Koushik

On 03/03/17, 1:58 PM, "Rohit Yadav" 
wrote:

-1 (binding)

All, I've found an upgrade blocker. Pre 4.6 users are required
to seed 4.6 systemvmtemplate to proceed with the upgrade
otherwise upgrade fails, and from 4.9 upgrade to 4.10 does no
check/enforcement that 4.10 based systemvmtemplate has been
seeded/registered, nor the minimum required systemvmtemplate
version is changed from 4.6.0 to 4.10.0.

After we have merged the strongswan/java8 PR, I had updated the
upgrade docs on how to upgrade the systemvmtemplate here:


http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.10/upgrade/upgrade-4.9.html

Using the above, I've tried to fix these issues here, please
review and merge for RC2:

https://github.com/apache/cloudstack/pull/1983

With above fix,
the aim is that users only seed the 4.10 systemvmtemplate before
upgrade and post-upgrade the upgrade paths fix the entries,
global setting etc.

Regards.


From: Tutkowski, Mike 
Sent: 02 March 2017 22:39:08
To: dev@cloudstack.apache.org
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

I rolled back to my master branch at
da66b06e7d562393da2e4b52206943f8bad49d10 and it works.

It appears something that went into after that commit has broken
this. It looks like this SHA is about two weeks old and that 43
commits have gone into master since it.

On 3/2/17, 7:06 AM, "Tutkowski, Mike"
 wrote:

According to where the code fails, though, it appears to be a
networking problem. If I set a breakpoint before the failure and
change a variable to say that security groups are not being used,
then the VM starts.

I think this is a recently introduced problem because I have
another branch based off of a slightly older version of master
and it works fine here.

> On Mar 2, 2017, at 6:51 AM, Pierre-Luc Dion
 wrote:
>
> Hi Mike,
> Try vm with at least 512MB for memory.
>
>> On Mar 1, 2017 15:01, "Tutkowski, Mike"
 wrote:
>>
>> I see the following exception when trying to deploy a user VM
in a Basic
>> Zone with two XenServer 6.5 hosts in one cluster. My system
VMs have all
>> deployed properly. The user template gets downloaded fine. I
can see the
>> user VM begin to start on a XenServer host, then it goes
away. We then
>> automatically try on the other host. I can see the VM begin
to start there
>> for a moment, then it goes away.
>>
>> I am just deploying the user VM’s template and root disk to
NFS (same
>> place where the template and root disks of my system VMs
are).
>>
>> I am using the built-in XenServer CentOS 5.6 (64 bit)
template with 1
>> vCPU, 500 MHz, and 256 MB memory.
>>
>> WARN [c.c.a.r.v.VirtualRoutingResource]
(DirectAgent-7:ctx-35aded78)
>> (logid:aab9c320) Expected 1 answers while executing
VmDataCommand but
>> received 2
>> WARN [c.c.v.VirtualMachinePowerStateSyncImpl]
(DirectAgentCronJob-14:ctx-27fb1ac3)
>> (logid:2c342f23) VM state was updated but update time is
null?! vm id: 6
>> INFO [o.a.c.f.j.i.AsyncJobManagerImpl]
(AsyncJobMgr-Heartbeat-1:ctx-2c7d2dce)
>> (logid:a56a9a8c) Begin cleanup expired async-jobs
>> INFO [o.a.c.f.j.i.AsyncJobManagerImpl]
(AsyncJobMgr-Heartbeat-1:ctx-2c7d2dce)
>> 

[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread kishankavala
Github user kishankavala commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@karuturi updated template URLs and md5sum


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-03-06 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@nvazquez @serg38  I tested this fix on VMware vSphere 5.5 and 6.0. I'll 
re-verify this on 6.0. Can you please share the build# of ESXi 6.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1970: CLOUDSTACK-9725 Failed to update VPC Network during ...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1970
  
Code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1969: CLOUDSTACK-9667 Enable resourcecount.check.interval ...

2017-03-06 Thread bvbharatk
Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/1969
  
will move the changes to new schema file, when the new master branch is 
created after release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-06 Thread Rajani Karuturi
PRs are ready for the blockers. Waiting for reviews and test
results. Once they are ready, I will merge them(and a few more
bug fixes) and create RC2 (probably tomorrow, Wednesday)

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On March 3, 2017 at 4:30 PM, Rajani Karuturi (raj...@apache.org)
wrote:

I will create RC2 on Monday with the fixes mentioned in my
previous mail.

~ Rajani

http://cloudplatform.accelerite.com/

On March 3, 2017 at 2:36 PM, Rohit Yadav
(rohit.ya...@shapeblue.com) wrote:

Thanks Koushik, I did not realize Kishan had sent this already.
Let's get either of the PRs merged and kick a RC2.

Regards.


From: Koushik Das 
Sent: 03 March 2017 14:14:56
To: dev@cloudstack.apache.org
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

Looks like there is already a PR for the same issue
https://github.com/apache/cloudstack/pull/1982 from Kishan.

-Koushik

On 03/03/17, 1:58 PM, "Rohit Yadav" 
wrote:

-1 (binding)

All, I've found an upgrade blocker. Pre 4.6 users are required
to seed 4.6 systemvmtemplate to proceed with the upgrade
otherwise upgrade fails, and from 4.9 upgrade to 4.10 does no
check/enforcement that 4.10 based systemvmtemplate has been
seeded/registered, nor the minimum required systemvmtemplate
version is changed from 4.6.0 to 4.10.0.

After we have merged the strongswan/java8 PR, I had updated the
upgrade docs on how to upgrade the systemvmtemplate here:

http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.10/upgrade/upgrade-4.9.html

Using the above, I've tried to fix these issues here, please
review and merge for RC2:

https://github.com/apache/cloudstack/pull/1983

With above fix,
the aim is that users only seed the 4.10 systemvmtemplate before
upgrade and post-upgrade the upgrade paths fix the entries,
global setting etc.

Regards.


From: Tutkowski, Mike 
Sent: 02 March 2017 22:39:08
To: dev@cloudstack.apache.org
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

I rolled back to my master branch at
da66b06e7d562393da2e4b52206943f8bad49d10 and it works.

It appears something that went into after that commit has broken
this. It looks like this SHA is about two weeks old and that 43
commits have gone into master since it.

On 3/2/17, 7:06 AM, "Tutkowski, Mike"
 wrote:

According to where the code fails, though, it appears to be a
networking problem. If I set a breakpoint before the failure and
change a variable to say that security groups are not being used,
then the VM starts.

I think this is a recently introduced problem because I have
another branch based off of a slightly older version of master
and it works fine here.

> On Mar 2, 2017, at 6:51 AM, Pierre-Luc Dion
 wrote:
>
> Hi Mike,
> Try vm with at least 512MB for memory.
>
>> On Mar 1, 2017 15:01, "Tutkowski, Mike"
 wrote:
>>
>> I see the following exception when trying to deploy a user VM
in a Basic
>> Zone with two XenServer 6.5 hosts in one cluster. My system
VMs have all
>> deployed properly. The user template gets downloaded fine. I
can see the
>> user VM begin to start on a XenServer host, then it goes
away. We then
>> automatically try on the other host. I can see the VM begin
to start there
>> for a moment, then it goes away.
>>
>> I am just deploying the user VM’s template and root disk to
NFS (same
>> place where the template and root disks of my system VMs
are).
>>
>> I am using the built-in XenServer CentOS 5.6 (64 bit)
template with 1
>> vCPU, 500 MHz, and 256 MB memory.
>>
>> WARN [c.c.a.r.v.VirtualRoutingResource]
(DirectAgent-7:ctx-35aded78)
>> (logid:aab9c320) Expected 1 answers while executing
VmDataCommand but
>> received 2
>> WARN [c.c.v.VirtualMachinePowerStateSyncImpl]
(DirectAgentCronJob-14:ctx-27fb1ac3)
>> (logid:2c342f23) VM state was updated but update time is
null?! vm id: 6
>> INFO [o.a.c.f.j.i.AsyncJobManagerImpl]
(AsyncJobMgr-Heartbeat-1:ctx-2c7d2dce)
>> (logid:a56a9a8c) Begin cleanup expired async-jobs
>> INFO [o.a.c.f.j.i.AsyncJobManagerImpl]
(AsyncJobMgr-Heartbeat-1:ctx-2c7d2dce)
>> (logid:a56a9a8c) End cleanup expired async-jobs
>> INFO [c.c.u.AccountManagerImpl]
(AccountChecker-1:ctx-383a632c)
>> (logid:541e9ba5) Found 0 removed accounts to cleanup
>> INFO [c.c.u.AccountManagerImpl]
(AccountChecker-1:ctx-383a632c)
>> (logid:541e9ba5) Found 0 disabled accounts to cleanup
>> INFO [c.c.u.AccountManagerImpl]
(AccountChecker-1:ctx-383a632c)
>> (logid:541e9ba5) Found 0 inactive domains to cleanup
>> INFO [c.c.u.AccountManagerImpl]
(AccountChecker-1:ctx-383a632c)
>> (logid:541e9ba5) Found 0 disabled projects to cleanup
>> WARN [c.c.h.x.r.CitrixResourceBase]
(DirectAgent-16:ctx-7c901443)
>> (logid:aab9c320) callHostPlugin failed for cmd:
default_network_rules with
>> args secIps: 0:, vmName: 

[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1991
  
@borisstoyanov can you start the tests on this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@kishankavala can you use the templates from 
http://cloudstack.apt-get.eu/systemvm/4.10/ ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
Two LGTMs and no test failures from cloudmonger  test results.
@ustcweizhou waited for your comments for this, I am putting the mergeready 
tag.  If you have anything to bring up let me know.

tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1908
  
@ProjectMoon  Can you please review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-06 Thread rajesh-battala
Github user rajesh-battala commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Thanks.
Once its update please point the same here. So that every one knows it.

Thanks
Rajesh Battala

On Tue, Mar 7, 2017 at 9:27 AM, Nitin Kumar Maharana <
notificati...@github.com> wrote:

> @rajesh-battala  : Will update the
> same in wiki page.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



-- 
Thanks
Rajesh Battala



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-06 Thread nitin-maharana
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rajesh-battala : Will update the same in wiki page. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread nitin-maharana
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1655: Fix ajaxviewer.js to solve console on Firefox

2017-03-06 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1655
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 434
 Hypervisor xenserver
 NetworkType Advanced
 Passed=102
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_routers_network_ops.py

 * ContextSuite context=TestRedundantIsolateNetworks>:setup Failing since 3 
runs


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@serg38 Yes, the aim of the PR is to enable deployment from templates with 
multiple data disks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-03-06 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
Sure @serg38, after enabling HA on cluster, stopping VR and the starting VR 
we got this exception on ESXi 6:

2017-03-06 12:18:14,654 ERROR [cloud.vm.VmWorkJobDispatcher] 
(Work-Job-Executor-4:ctx-d275214a job-8521/job-8522) Unable to complete 
AsyncJobVO {id:8522, userId: 2, accountId: 2, instanceType: null, instanceId: 
null, cmd: com.cloud.vm.VmWorkStart, cmdInfo: 
rO0ABXNyABhjb20uY2xvdWQudm0uVm1Xb3JrU3RhcnR9cMGsvxz73gIAC0oABGRjSWRMAAZhdm9pZHN0ADBMY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5lciRFeGNsdWRlTGlzdDtMAAljbHVzdGVySWR0ABBMamF2YS9sYW5nL0xvbmc7TAAGaG9zdElkcQB-AAJMAAtqb3VybmFsTmFtZXQAEkxqYXZhL2xhbmcvU3RyaW5nO0wAEXBoeXNpY2FsTmV0d29ya0lkcQB-AAJMAAdwbGFubmVycQB-AANMAAVwb2RJZHEAfgACTAAGcG9vbElkcQB-AAJMAAlyYXdQYXJhbXN0AA9MamF2YS91dGlsL01hcDtMAA1yZXNlcnZhdGlvbklkcQB-AAN4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1lcQB-AAN4cAACAAIhUHQAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAHBwcHBwcHBwc3IAEWphdmEudXRpbC5IYXNoTWFwBQfawcMWYNEDAAJGAApsb2FkRmFjdG9ySQAJdGhyZXNob2xkeHA_QAAADHcIEAF0AA5SZXN0YXJ0TmV0d29ya
 
3QAP3JPMEFCWE55QUJGcVlYWmhMbXhoYm1jdVFtOXZiR1ZoYnMwZ2NvRFZuUHJ1QWdBQldnQUZkbUZzZFdWNGNBRXhw,
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 345051565299, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: Mon Mar 06 12:18:05 PST 2017}, job origin:8521
com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
deployment for VM[DomainRouter|r-8528-VM]Scope=interface 
com.cloud.dc.DataCenter; id=1
at 
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:961)
at 
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:4643)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
at 
com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:4804)
at 
com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:554)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:502)

Also, on vSphere we got this error: `Configuration vmConfig is not valid 
for cluster CLD100`.

@sureshanaparti maybe this link could be useful to solve the issue: 
https://communities.vmware.com/thread/467685?start=0=0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with memory i...

2017-03-06 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/914
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 433
 Hypervisor xenserver
 NetworkType Advanced
 Passed=103
 Failed=2
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed

* test_routers_network_ops.py

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
Trillian test result (tid-932)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27819 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1982-t932-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 345.49 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 150.45 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.15 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 235.76 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 252.15 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 463.04 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 491.16 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1393.99 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 532.56 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 734.00 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1289.62 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.43 | test_volumes.py
test_08_resize_volume | Success | 156.45 | test_volumes.py
test_07_resize_fail | Success | 161.53 | test_volumes.py
test_06_download_detached_volume | Success | 156.31 | test_volumes.py
test_05_detach_volume | Success | 155.77 | test_volumes.py
test_04_delete_attached_volume | Success | 151.24 | test_volumes.py
test_03_download_attached_volume | Success | 156.35 | test_volumes.py
test_02_attach_volume | Success | 95.77 | test_volumes.py
test_01_create_volume | Success | 620.83 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.80 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.76 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 237.56 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.55 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.88 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 130.85 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.82 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.16 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.34 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 40.47 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.05 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 5.17 | test_templates.py
test_03_delete_template | Success | 5.23 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 25.33 | test_templates.py
test_10_destroy_cpvm | Success | 161.58 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.57 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.54 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.53 | test_ssvm.py
test_06_stop_cpvm | Success | 131.77 | test_ssvm.py
test_05_stop_ssvm | Success | 133.62 | test_ssvm.py
test_04_cpvm_internals | Success | 1.18 | test_ssvm.py
test_03_ssvm_internals | Success | 3.34 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.13 | test_snapshots.py
test_04_change_offering_small | Success | 234.51 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.44 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 35.30 | test_routers.py
test_08_start_router | Success | 30.28 | 

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 432
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-03-06 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
LGTM @nvazquez Can we test it with shared networking? 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1989
  
@abhinandanprateek I am curious if this PR will allow deploying VM with 
Data disk attached?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-06 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
LGTM
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: GSoC projects

2017-03-06 Thread sachin patil
@daan Thank you!!

On Mon, Mar 6, 2017 at 7:58 PM, Daan Hoogland 
wrote:

> On Mon, Mar 6, 2017 at 2:59 PM, sachin patil 
> wrote:
> > sachin931350
>
>
> you have access now
>
> --
> Daan
>


[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-06 Thread nathanejohnson
Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
Also, I just made a commit, I have not squashed it because I wanted to get 
some feedback.  I noticed that vmware uses details to pass rootDiskController 
for the bus type, and there was even some code that inspected this in the kvm 
plugin.  With this latest commit, it will actually honor either OS type "Other 
PV Virtio-SCSI" or rootDiskController passed in via details, with details 
overriding OS type.  I also made a minor tweak to the UI to allow setting the 
root disk bus via the add template dialog in the UI:


![template_screen](https://cloud.githubusercontent.com/assets/1360240/23617743/b29b8dd6-0253-11e7-970b-6aafe314bd49.png)

So this way you can select virtio scsi by one of the following three ways:

1) selecting os type as "Other PV Virtio-SCSI (64 bit)"
2) uploading a template and specifying details[0].rootDiskController=scsi, 
either from the UI or the API, then creating a VM from this template
3) deploying a VM and specifying details[0].rootDiskController=scsi , 
currently only available via the API




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-06 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1278
  
@anshul1886 sorry, but I still do not understand you.

Your changes affect `NetworkHelperImpl.java` class. Do we agree on that?

You changed lines 334 and 512. You changed the call `startVirtualRouter`; 
this method is implemented in the same `NetworkHelperImpl.java` class. Before 
you change the call was `startVirtualRouter(router, 
_accountMgr.getSystemUser(), _accountMgr.getSystemAccount(), 
routerDeploymentDefinition.getParams())`; then, you altered the code to 
`startVirtualRouter(router, callerUser, caller, 
routerDeploymentDefinition.getParams())`. 

You changed the way the code is retrieving objects “user” and 
“account”; before the user was retrieved as `_accountMgr.getSystemUser()`, 
now it is retrieved as 
`_accountMgr.getActiveUser(CallContext.current().getCallingUserId())`. The 
account was obtained as `_accountMgr.getSystemAccount()` and now it is obtained 
as `CallContext.current().getCallingAccount()`.

Can we agree on this?

You are telling me to look at the Deployment planner. However, what I fail 
to understand is the following.

Looking at lines 334 and 512, the `user` and `account` are passed as 
parameters to 
`com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO, 
User, Account, Map)`. This method is in the same ` 
NetworkHelperImpl` class. The only thing the ` startVirtualRouter` method does 
with the mentioned objects is to send them as parameters to ` 
com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO, User, Account, 
Map, DeploymentPlan)` at lines 349, 387, or 412. Then, the 
method to ` com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO, 
User, Account, Map, DeploymentPlan)` does not use the ` User` 
and `Account` objects.

Can we agree on that?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-06 Thread nathanejohnson
Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
@borisstoyanov I have reworked the test so that it should now use the host 
IP versus the hostname.  Could you please re-run the blue orangutan test?  
Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-06 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
That's great! Thanks @borisstoyanov for your help!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


ACS master: Failing to dedicate a vlan range to an account

2017-03-06 Thread Prashanth Manthena
Hi all,

I am seeing the following issue while trying to dedicate a vlan range to an
account:

(local)  > dedicate guestvlanrange account=admin
domainid=efd478ff-0145-11e7-ba73-faaca6101800 vlanrange=100-300
physicalnetworkid=7c658a8b-6e24-4a2d-ad58-75f318815dfa
Error 530: Index: 0, Size: 0
cserrorcode = 
errorcode = 530
errortext = Index: 0, Size: 0
uuidList:


Here is the exception in the logs:

2017-03-06 06:23:46,476 ERROR [c.c.a.ApiServer]
(catalina-exec-8:ctx-4703c806 ctx-672b4276 ctx-ee68b9c9) (logid:2af07a55)
unhandled exception executing api command: [Ljava.lang.String;@752957ea
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
at java.util.ArrayList.rangeCheck(ArrayList.java:653)
at java.util.ArrayList.get(ArrayList.java:429)
at com.cloud.network.NetworkServiceImpl.dedicateGuestVlanRange(
NetworkServiceImpl.java:3222)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.springframework.aop.support.AopUtils.
invokeJoinpointUsingReflection(AopUtils.java:333)
at org.springframework.aop.framework.ReflectiveMethodInvocation.
invokeJoinpoint(ReflectiveMethodInvocation.java:190)
at org.springframework.aop.framework.ReflectiveMethodInvocation.
proceed(ReflectiveMethodInvocation.java:157)
at org.apache.cloudstack.network.contrail.management.
EventUtils$EventInterceptor.invoke(EventUtils.java:107)
at org.springframework.aop.framework.ReflectiveMethodInvocation.
proceed(ReflectiveMethodInvocation.java:168)
at com.cloud.event.ActionEventInterceptor.invoke(
ActionEventInterceptor.java:51)
at org.springframework.aop.framework.ReflectiveMethodInvocation.
proceed(ReflectiveMethodInvocation.java:168)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.
invoke(ExposeInvocationInterceptor.java:92)
at org.springframework.aop.framework.ReflectiveMethodInvocation.
proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.framework.JdkDynamicAopProxy.
invoke(JdkDynamicAopProxy.java:213)
at com.sun.proxy.$Proxy171.dedicateGuestVlanRange(Unknown Source)
at org.apache.cloudstack.api.command.admin.network.
DedicateGuestVlanRangeCmd.execute(DedicateGuestVlanRangeCmd.java:113)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:709)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:533)
at com.cloud.api.ApiServlet.processRequestInContext(
ApiServlet.java:299)
at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129)
at org.apache.cloudstack.managed.context.impl.
DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
callWithContext(DefaultManagedContext.java:103)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
runWithContext(DefaultManagedContext.java:53)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126)
at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:303)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:208)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(
WsFilter.java:52)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:241)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:208)
at org.apache.catalina.core.StandardWrapperValve.invoke(
StandardWrapperValve.java:220)
at org.apache.catalina.core.StandardContextValve.invoke(
StandardContextValve.java:122)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(
AuthenticatorBase.java:501)
at org.apache.catalina.core.StandardHostValve.invoke(
StandardHostValve.java:171)
at org.apache.catalina.valves.ErrorReportValve.invoke(
ErrorReportValve.java:102)
at org.apache.catalina.valves.AccessLogValve.invoke(
AccessLogValve.java:950)
at org.apache.catalina.core.StandardEngineValve.invoke(
StandardEngineValve.java:116)
at org.apache.catalina.connector.CoyoteAdapter.service(
CoyoteAdapter.java:408)
at org.apache.coyote.http11.AbstractHttp11Processor.process(
AbstractHttp11Processor.java:1040)
at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.
process(AbstractProtocol.java:607)
at 

[GitHub] cloudstack issue #1832: CLOUDSTACK-9652 Job framework - Cancelling async job...

2017-03-06 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1832
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 431
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: GSoC projects

2017-03-06 Thread Daan Hoogland
On Mon, Mar 6, 2017 at 2:59 PM, sachin patil  wrote:
> sachin931350


you have access now

-- 
Daan


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
I've tested the upgrade and it has passed from 4.5 to 4.10. Will kick 
smoketests now
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: GSoC projects

2017-03-06 Thread sachin patil
Sorry for late reply @daan.
My id is sachin931350

On Fri, Mar 3, 2017 at 11:35 AM, Daan Hoogland 
wrote:

> On Thu, Mar 2, 2017 at 11:22 PM, Syed Ahmed  wrote:
> > I've talked to folks here and I don't think I can give write access to
> you
> > for the Wiki. I will create a google form and lets' use that instead.
> >
> > On Thu, Mar 2, 2017 at 2:58 PM, sachin patil 
> wrote:
> >
> >> @syed I tried to edit the Candidates column but couldn't do it. I think
> >> there are some restrictions to edit the page. Please have a look into
> it. I
> >> would like to work for CLOUDSTACK-8629
> >> 
>
>
> I can give you access Sachin, what's your id there?
>
> --
> Daan
>


[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-06 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@nvazquez @serg38 I'm happy to merge this change I've run the tests with 
the NFS2 trillian branch and it passed. As soon as we get the trillian branch 
merged as well we'll have this passing in the smoketests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1991
  
Updated the patch. Tested it no issues found.
Please review this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

2017-03-06 Thread jayapalu
Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1991#discussion_r104414236
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
 type = getIpsetType()
 tmpname = 'ipsetqzvxtmp'
 try:
-util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type])
+util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])
--- End diff --

Updated the patch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-562


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1991
  
I am testing it again. Please wait till I update


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1991
  
code LGTM. not tested.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

2017-03-06 Thread jayapalu
Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1991#discussion_r104405081
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
 type = getIpsetType()
 tmpname = 'ipsetqzvxtmp'
 try:
-util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type])
+util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])
--- End diff --

Spaces will not cause any issues. Anyway I removed the spaces, tested and 
update the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

2017-03-06 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1991#discussion_r104393162
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
 type = getIpsetType()
 tmpname = 'ipsetqzvxtmp'
 try:
-util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type])
+util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])
--- End diff --

is the space after "-N". "-F" . "-X" needed ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...

2017-03-06 Thread prashanthvarma
Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1981
  
@borisstoyanov yes, I also did cross check the test failures. Thanks for 
the investigation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-06 Thread Jayapal Uradi
Created the PR.
https://github.com/apache/cloudstack/pull/1991

Thanks,
Jayapal

On Mar 6, 2017, at 3:58 PM, Rajani Karuturi 
> wrote:

Thanks Wei Zhow. Will ping Jayapal.

~ Rajani
http://cloudplatform.accelerite.com/

On March 6, 2017 at 3:25 PM, Wei ZHOU 
(ustcweiz...@gmail.com) wrote:
about ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9821


this seems to be caused by commit 175c8d83b8a628566a4c443db0de587874718c8c

Author: Jayapal 
>
AuthorDate: Mon Feb 20 18:29:14 2017 +0530
Commit: Jayapal 
>
CommitDate: Mon Feb 20 18:34:13 2017 +0530

CLOUDSTACK-8871: fixed issue with the xenserver 6.2 ipset nethash
---
scripts/vm/hypervisor/xenserver/vmops | 25 +++--
1 files changed, 19 insertions(+), 6 deletions(-)

Jayapal, could you please have a look ?

2017-03-04 2:41 GMT+01:00 Rajani Karuturi 
>:
Thanks for the update mike.

@wido, weizhou
Can you take a look at the issue please?

~Rajani
Sent from phone.

On 4 Mar 2017 3:25 a.m., "Tutkowski, Mike" 
>
wrote:
-1 (binding)

Per my previous e-mails concerning this issue, here is a ticket I
created:

https://issues.apache.org/jira/browse/CLOUDSTACK-9821

We should get someone from the networking side of things to investigate.

Thanks!

On 3/3/17, 1:28 AM, "Rohit Yadav" 
> wrote:

-1 (binding)


All, I've found an upgrade blocker. Pre 4.6 users are required to
seed
4.6 systemvmtemplate to proceed with the upgrade otherwise upgrade fails,
and from 4.9 upgrade to 4.10 does no check/enforcement that 4.10 based
systemvmtemplate has been seeded/registered, nor the minimum required
systemvmtemplate version is changed from 4.6.0 to 4.10.0.


After we have merged the strongswan/java8 PR, I had updated the
upgrade docs on how to upgrade the systemvmtemplate here:

http://docs.cloudstack.apache.org/projects/cloudstack-
release-notes/en/4.10/upgrade/upgrade-4.9.html


Using the above, I've tried to fix these issues here, please review
and merge for RC2:

https://github.com/apache/cloudstack/pull/1983


With
 above fix, the
aim is that users only seed the 4.10 systemvmtemplate before upgrade and
post-upgrade the upgrade paths fix the entries, global setting etc.


Regards.


From: Tutkowski, Mike 
>
Sent: 02 March 2017 22:39:08
To: dev@cloudstack.apache.org
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

I rolled back to my master branch at da66b06e7d562393da2e4b52206943
f8bad49d10
and it works.

It appears something that went into after that commit has broken
this.
It looks like this SHA is about two weeks old and that 43 commits have
gone
into master since it.

On 3/2/17, 7:06 AM, "Tutkowski, Mike" 
>
wrote:

According to where the code fails, though, it appears to be a
networking problem. If I set a breakpoint before the failure and change a
variable to say that security groups are not being used, then the VM
starts.

I think this is a recently introduced problem because I have
another branch based off of a slightly older version of master and it
works
fine here.
On Mar 2, 2017, at 6:51 AM, Pierre-Luc Dion <
pd...@cloudops.com>
wrote: > wrote: in a Basic
VMs NFS null?! 10.117.40.53, Exception: xenbase. xenbase. java:266) xenbase. 
xenbase. java:266) (Network-Scavenger-1:ctx- checkResponse(Types.java:693) 457) 
xenbase. xenbase. java:266) checkResponse(Types.java:693) 457) xenbase. 
xenbase. java:266) checkResponse(Types.java:693) 457) xenbase. xenbase. 
java:266) VM orchestrateStart( orchestrateStart( java:266) dataCenterId:: 
VirtualMachineEntityImpl.java: dispatch(ApiDispatcher.java: java:266) 
orchestrateStart( orchestrateStart( artifacts the org/repos/dist/dev/cloudstack/




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

2017-03-06 Thread jayapalu
GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1991

CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone

Fixed issue in deploying vm in basic zone. 
There is issue in ipset command with xenserver 6.5. In util.pread2 ipset 
and -N is passed as single string and it caused the issue in command failure.

 util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9821

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1991


commit c8819c0876582ffa1685b26bbb5aa4ed145d4723
Author: Jayapal 
Date:   2017-03-06T11:10:05Z

CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...

2017-03-06 Thread niteshsarda
Github user niteshsarda commented on the issue:

https://github.com/apache/cloudstack/pull/1725
  
I have tested this and **LGTM** for test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread nitin-maharana
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@karuturi : Currently running. Will post once completes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread nitin-maharana
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@cloudmonger


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-06 Thread Rajani Karuturi
Thanks Wei Zhow. Will ping Jayapal.

~ Rajani

http://cloudplatform.accelerite.com/

On March 6, 2017 at 3:25 PM, Wei ZHOU (ustcweiz...@gmail.com)
wrote:

about ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-9821

this seems to be caused by commit
175c8d83b8a628566a4c443db0de587874718c8c

Author: Jayapal 
AuthorDate: Mon Feb 20 18:29:14 2017 +0530
Commit: Jayapal 
CommitDate: Mon Feb 20 18:34:13 2017 +0530

CLOUDSTACK-8871: fixed issue with the xenserver 6.2 ipset
nethash
---
scripts/vm/hypervisor/xenserver/vmops | 25
+++--
1 files changed, 19 insertions(+), 6 deletions(-)

Jayapal, could you please have a look ?

2017-03-04 2:41 GMT+01:00 Rajani Karuturi :

Thanks for the update mike.

@wido, weizhou
Can you take a look at the issue please?

~Rajani
Sent from phone.

On 4 Mar 2017 3:25 a.m., "Tutkowski, Mike"

wrote:

-1 (binding)

Per my previous e-mails concerning this issue, here is a ticket
I

created:

https://issues.apache.org/jira/browse/CLOUDSTACK-9821

We should get someone from the networking side of things to
investigate.

Thanks!

On 3/3/17, 1:28 AM, "Rohit Yadav" 
wrote:

-1 (binding)

All, I've found an upgrade blocker. Pre 4.6 users are required
to

seed

4.6 systemvmtemplate to proceed with the upgrade otherwise
upgrade fails,
and from 4.9 upgrade to 4.10 does no check/enforcement that 4.10
based
systemvmtemplate has been seeded/registered, nor the minimum
required
systemvmtemplate version is changed from 4.6.0 to 4.10.0.

After we have merged the strongswan/java8 PR, I had updated the
upgrade docs on how to upgrade the systemvmtemplate here:

http://docs.cloudstack.apache.org/projects/cloudstack-
release-notes/en/4.10/upgrade/upgrade-4.9.html

Using the above, I've tried to fix these issues here, please
review
and merge for RC2:

https://github.com/apache/cloudstack/pull/1983

With above fix,
the
aim is that users only seed the 4.10 systemvmtemplate before
upgrade and
post-upgrade the upgrade paths fix the entries, global setting
etc.

Regards.


From: Tutkowski, Mike 
Sent: 02 March 2017 22:39:08
To: dev@cloudstack.apache.org
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

I rolled back to my master branch at
da66b06e7d562393da2e4b52206943

f8bad49d10

and it works.

It appears something that went into after that commit has broken

this.

It looks like this SHA is about two weeks old and that 43 commits
have

gone

into master since it.

On 3/2/17, 7:06 AM, "Tutkowski, Mike"

wrote:

According to where the code fails, though, it appears to be a
networking problem. If I set a breakpoint before the failure and
change a
variable to say that security groups are not being used, then
the VM

starts.

I think this is a recently introduced problem because I have
another branch based off of a slightly older version of master
and it

works

fine here.

On Mar 2, 2017, at 6:51 AM, Pierre-Luc Dion <

pd...@cloudops.com>

wrote: > wrote: in a Basic

VMs NFS null?! 10.117.40.53, Exception: xenbase. xenbase.
java:266) xenbase. xenbase. java:266) (Network-Scavenger-1:ctx-
checkResponse(Types.java:693) 457) xenbase. xenbase. java:266)
checkResponse(Types.java:693) 457) xenbase. xenbase. java:266)
checkResponse(Types.java:693) 457) xenbase. xenbase. java:266) VM
orchestrateStart( orchestrateStart( java:266) dataCenterId::
VirtualMachineEntityImpl.java: dispatch(ApiDispatcher.java:
java:266) orchestrateStart( orchestrateStart( artifacts the
org/repos/dist/dev/cloudstack/

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-06 Thread priyankparihar
Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Hi, @serg38 and @borisstoyanov soon test_00_deploy_vm_root_resize will be 
updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-06 Thread Wei ZHOU
about ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9821


this seems to be caused by commit 175c8d83b8a628566a4c443db0de587874718c8c

Author: Jayapal 
AuthorDate: Mon Feb 20 18:29:14 2017 +0530
Commit: Jayapal 
CommitDate: Mon Feb 20 18:34:13 2017 +0530

CLOUDSTACK-8871: fixed issue with the xenserver 6.2 ipset nethash
---
 scripts/vm/hypervisor/xenserver/vmops |   25 +++--
 1 files changed, 19 insertions(+), 6 deletions(-)

Jayapal, could you please have a look ?

2017-03-04 2:41 GMT+01:00 Rajani Karuturi :

> Thanks for the update mike.
>
> @wido, weizhou
> Can you take a look at the issue please?
>
> ~Rajani
> Sent from phone.
>
> On 4 Mar 2017 3:25 a.m., "Tutkowski, Mike" 
> wrote:
>
> > -1 (binding)
> >
> > Per my previous e-mails concerning this issue, here is a ticket I
> created:
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-9821
> >
> > We should get someone from the networking side of things to investigate.
> >
> > Thanks!
> >
> > On 3/3/17, 1:28 AM, "Rohit Yadav"  wrote:
> >
> > -1 (binding)
> >
> >
> > All, I've found an upgrade blocker. Pre 4.6 users are required to
> seed
> > 4.6 systemvmtemplate to proceed with the upgrade otherwise upgrade fails,
> > and from 4.9 upgrade to 4.10 does no check/enforcement that 4.10 based
> > systemvmtemplate has been seeded/registered, nor the minimum required
> > systemvmtemplate version is changed from 4.6.0 to 4.10.0.
> >
> >
> > After we have merged the strongswan/java8 PR, I had updated the
> > upgrade docs on how to upgrade the systemvmtemplate here:
> >
> > http://docs.cloudstack.apache.org/projects/cloudstack-
> > release-notes/en/4.10/upgrade/upgrade-4.9.html
> >
> >
> > Using the above, I've tried to fix these issues here, please review
> > and merge for RC2:
> >
> > https://github.com/apache/cloudstack/pull/1983
> >
> >
> > With above fix, the
> > aim is that users only seed the 4.10 systemvmtemplate before upgrade and
> > post-upgrade the upgrade paths fix the entries, global setting etc.
> >
> >
> > Regards.
> >
> > 
> > From: Tutkowski, Mike 
> > Sent: 02 March 2017 22:39:08
> > To: dev@cloudstack.apache.org
> > Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0
> >
> > I rolled back to my master branch at da66b06e7d562393da2e4b52206943
> f8bad49d10
> > and it works.
> >
> > It appears something that went into after that commit has broken
> this.
> > It looks like this SHA is about two weeks old and that 43 commits have
> gone
> > into master since it.
> >
> > On 3/2/17, 7:06 AM, "Tutkowski, Mike" 
> > wrote:
> >
> > According to where the code fails, though, it appears to be a
> > networking problem. If I set a breakpoint before the failure and change a
> > variable to say that security groups are not being used, then the VM
> starts.
> >
> > I think this is a recently introduced problem because I have
> > another branch based off of a slightly older version of master and it
> works
> > fine here.
> >
> > > On Mar 2, 2017, at 6:51 AM, Pierre-Luc Dion <
> pd...@cloudops.com>
> > wrote:
> > >
> > > Hi Mike,
> > > Try vm with at least 512MB for memory.
> > >
> > >> On Mar 1, 2017 15:01, "Tutkowski, Mike" <
> > mike.tutkow...@netapp.com> wrote:
> > >>
> > >> I see the following exception when trying to deploy a user VM
> > in a Basic
> > >> Zone with two XenServer 6.5 hosts in one cluster. My system
> VMs
> > have all
> > >> deployed properly. The user template gets downloaded fine. I
> > can see the
> > >> user VM begin to start on a XenServer host, then it goes away.
> > We then
> > >> automatically try on the other host. I can see the VM begin to
> > start there
> > >> for a moment, then it goes away.
> > >>
> > >> I am just deploying the user VM’s template and root disk to
> NFS
> > (same
> > >> place where the template and root disks of my system VMs are).
> > >>
> > >> I am using the built-in XenServer CentOS 5.6 (64 bit) template
> > with 1
> > >> vCPU, 500 MHz, and 256 MB memory.
> > >>
> > >> WARN  [c.c.a.r.v.VirtualRoutingResource]
> > (DirectAgent-7:ctx-35aded78)
> > >> (logid:aab9c320) Expected 1 answers while executing
> > VmDataCommand but
> > >> received 2
> > >> WARN  [c.c.v.VirtualMachinePowerStateSyncImpl]
> > (DirectAgentCronJob-14:ctx-27fb1ac3)
> > >> (logid:2c342f23) VM state was updated but update time is
> null?!
> > vm id: 6
> > >> INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > (AsyncJobMgr-Heartbeat-1:ctx-2c7d2dce)
> > >> 

[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...

2017-03-06 Thread yvsubhash
Github user yvsubhash commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1726#discussion_r104374914
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2263,27 +2264,43 @@ public void cleanupDownloadUrls(){
 
 // Cleanup expired volume URLs
 List volumesOnImageStoreList = 
_volumeStoreDao.listVolumeDownloadUrls();
+HashSet expiredVolumeIds = new HashSet();
+HashSet activeVolumeIds = new HashSet();
 for(VolumeDataStoreVO volumeOnImageStore : 
volumesOnImageStoreList){
 
+long volumeId = volumeOnImageStore.getVolumeId();
 try {
 long downloadUrlCurrentAgeInSecs = 
DateUtil.getTimeDifference(DateUtil.now(), 
volumeOnImageStore.getExtractUrlCreated());
 if(downloadUrlCurrentAgeInSecs < 
_downloadUrlExpirationInterval){  // URL hasnt expired yet
+activeVolumeIds.add(volumeId);
 continue;
 }
-
-s_logger.debug("Removing download url " + 
volumeOnImageStore.getExtractUrl() + " for volume id " + 
volumeOnImageStore.getVolumeId());
+expiredVolumeIds.add(volumeId);
+s_logger.debug("Removing download url " + 
volumeOnImageStore.getExtractUrl() + " for volume id " + volumeId);
 
 // Remove it from image store
 ImageStoreEntity secStore = (ImageStoreEntity) 
_dataStoreMgr.getDataStore(volumeOnImageStore.getDataStoreId(), 
DataStoreRole.Image);
 
secStore.deleteExtractUrl(volumeOnImageStore.getInstallPath(), 
volumeOnImageStore.getExtractUrl(), Upload.Type.VOLUME);
 
+_snapshotStoreDao.findByVolume(volumeId, 
DataStoreRole.Image);
--- End diff --

@ustcweizhou  That was not needed. So removed that same


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@wido Can you please update the systemvm templates at 
http://cloudstack.apt-get.eu/systemvm ?
You can use the one from 
https://builds.cloudstack.org/job/build-master-systemvm/148/ 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...

2017-03-06 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1875#discussion_r104373535
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -707,6 +709,23 @@ private String setupMountPoint(String parent) {
 return mountPoint;
 }
 
+@Override
+public synchronized void setSystemVmTmpltPermission(String mountPoint) 
{
+if (!s_isSystemVmTmpltPermissionSet) {
+s_logger.debug("Set permissions for " + mountPoint);
+String result = null;
+final String systemVmTmpltPermissions = "0777";
+Script script = new Script(true, "chmod", _timeout, s_logger);
+script.add("-R", systemVmTmpltPermissions, mountPoint);
--- End diff --

@SudharmaJain Used the string as suggested instead of hardcoded value for 
permissions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...

2017-03-06 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1726#discussion_r104370668
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2263,27 +2264,43 @@ public void cleanupDownloadUrls(){
 
 // Cleanup expired volume URLs
 List volumesOnImageStoreList = 
_volumeStoreDao.listVolumeDownloadUrls();
+HashSet expiredVolumeIds = new HashSet();
+HashSet activeVolumeIds = new HashSet();
 for(VolumeDataStoreVO volumeOnImageStore : 
volumesOnImageStoreList){
 
+long volumeId = volumeOnImageStore.getVolumeId();
 try {
 long downloadUrlCurrentAgeInSecs = 
DateUtil.getTimeDifference(DateUtil.now(), 
volumeOnImageStore.getExtractUrlCreated());
 if(downloadUrlCurrentAgeInSecs < 
_downloadUrlExpirationInterval){  // URL hasnt expired yet
+activeVolumeIds.add(volumeId);
 continue;
 }
-
-s_logger.debug("Removing download url " + 
volumeOnImageStore.getExtractUrl() + " for volume id " + 
volumeOnImageStore.getVolumeId());
+expiredVolumeIds.add(volumeId);
+s_logger.debug("Removing download url " + 
volumeOnImageStore.getExtractUrl() + " for volume id " + volumeId);
 
 // Remove it from image store
 ImageStoreEntity secStore = (ImageStoreEntity) 
_dataStoreMgr.getDataStore(volumeOnImageStore.getDataStoreId(), 
DataStoreRole.Image);
 
secStore.deleteExtractUrl(volumeOnImageStore.getInstallPath(), 
volumeOnImageStore.getExtractUrl(), Upload.Type.VOLUME);
 
+_snapshotStoreDao.findByVolume(volumeId, 
DataStoreRole.Image);
--- End diff --

what's the proposal of line 2285 to line 2287 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-03-06 Thread harikrishna-patnala
Github user harikrishna-patnala commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
LGTM for the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-03-06 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@nvazquez @serg38 Please review the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

2017-03-06 Thread yvsubhash
Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/1726
  
@ustcweizhou  Please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1983: [4.10/blocker] Upgrade4920to41000: Migrate systemvmt...

2017-03-06 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1983
  
@rhtyd I've tried the upgrade from 4.5 and ended up with failing at the 
point when upgrading templates ids:

```
2017-03-06 08:53:17,365 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Alter view image_store_view
2017-03-06 08:53:17,365 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
CREATE OR REPLACE VIEW `image_store_view` AS SELECT 
`image_store`.`id` AS `id`, `image_store`.`uuid` AS `uuid`, 
`image_store`.`name` AS `name`, `image_store`.`image_provider_name` AS 
`image_provider_name`, `image_store`.`protocol` AS `protocol`, 
`image_store`.`url` AS `url`, `image_store`.`scope` AS `scope`, 
`image_store`.`role` AS `role`, `image_store`.`removed` AS `removed`,   
  `data_center`.`id` AS `data_center_id`, `data_center`.`uuid` AS 
`data_center_uuid`, `data_center`.`name` AS `data_center_name` FROM 
(`image_store` LEFT JOIN `data_center` ON 
((`image_store`.`data_center_id` = `data_center`.`id`)))
2017-03-06 08:53:17,374 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Add service_offering_id column to vm_snapshots table
2017-03-06 08:53:17,374 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`vm_snapshots` ADD COLUMN `service_offering_id` BIGINT(20) 
UNSIGNED NOT NULL COMMENT '' AFTER `domain_id`
2017-03-06 08:53:17,440 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
UPDATE `cloud`.`vm_snapshots` s JOIN `cloud`.`vm_instance` v ON v.id = s.vm_id 
SET s.service_offering_id = v.service_offering_id
2017-03-06 08:53:17,440 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`vm_snapshots` ADD CONSTRAINT 
`fk_vm_snapshots_service_offering_id` FOREIGN KEY (`service_offering_id`) 
REFERENCES `cloud`.`service_offering` (`id`) ON DELETE NO ACTION ON UPDATE NO 
ACTION
2017-03-06 08:53:17,523 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Update vm snapshot details for instances with custom service offerings
2017-03-06 08:53:17,523 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
INSERT INTO `cloud`.`vm_snapshot_details` (vm_snapshot_id, name, value) SELECT 
s.id, d.name, d.value FROM `cloud`.`user_vm_details` d JOIN 
`cloud`.`vm_instance` v ON (d.vm_id = v.id) JOIN `cloud`.`service_offering` o 
ON (v.service_offering_id = o.id)  JOIN `cloud`.`vm_snapshots` s ON 
(s.service_offering_id = o.id AND s.vm_id = v.id) WHERE (o.cpu is null AND 
o.speed IS NULL AND o.ram_size IS NULL) AND (d.name = 'cpuNumber' OR d.name = 
'cpuSpeed' OR d.name = 'memory')
2017-03-06 08:53:17,524 DEBUG [c.c.u.d.Upgrade4920to41000] (main:null) 
(logid:) Updating System Vm template IDs
2017-03-06 08:53:17,526 ERROR [c.c.u.d.Upgrade4920to41000] (main:null) 
(logid:) updateSystemVmTemplates:Exception while getting hypervisor types from 
clusters: Before start of result set
2017-03-06 08:53:17,528 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Unable to upgrade the database
com.cloud.utils.exception.CloudRuntimeException: 
updateSystemVmTemplates:Exception while getting hypervisor types from clusters
at 
com.cloud.upgrade.dao.Upgrade4920to41000.updateSystemVmTemplates(Upgrade4920to41000.java:99)
at 
com.cloud.upgrade.dao.Upgrade4920to41000.performDataMigration(Upgrade4920to41000.java:73)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:426)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:507)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:65)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:55)
at 
org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:173)
at 
org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:51)
at 
org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:346)
at 
org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:149)
at 
org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:112)
at 
org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:879)
at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:545)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
at 

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
code LGTM.
@nitin-maharana Please initiate internal CI run on @cloudmonger.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1990: CLOUDSTACK-9674: Baremetal deployment improve...

2017-03-06 Thread harikrishna-patnala
GitHub user harikrishna-patnala opened a pull request:

https://github.com/apache/cloudstack/pull/1990

CLOUDSTACK-9674: Baremetal deployment improvements

With the current implementation of baremetal with cloudstack works but 
there are lot of improvements and bug fixes to be done.

1) Improvements in the baremetal planner.
2) Currently baremetal deployement supports only single nic on the 
baremetal host. Need to add multiple isolated network support in advanced zone.
3) There is a dependency on VMWare hypervisor to host the Virtual router. 
This has to be removed and make the VR deployment hypervisor agnostic.
4) To be able to handle baremetal deployments in case of RVR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9674

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1990


commit 601b0671d81e1842da49601947d08cdb3a4c134e
Author: Harikrishna Patnala 
Date:   2017-03-06T07:03:30Z

CLOUDSTACK-9674: Baremetal deployment improvements

With the current implementation of baremetal with cloudstack works but 
there are lot of improvements and bug fixes to be done.

1) Improvements in the baremetal planner.
2) Currently baremetal deployement supports only single nic on the 
baremetal host. Need to add multiple isolated network support in advanced zone.
3) There is a dependency on VMWare hypervisor to host the Virtual router. 
This has to be removed and make the VR deployment hypervisor agnostic.
4) To be able to handle baremetal deployments in case of RVR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---