[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-03-13 Thread rashmidixit
Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@ustcweizhou The popup is to indicate that no hosts were found. If I remove 
that, then there will be no visual indication that the search has returned no 
results. 

We need to have an alternative way to show that 0 results found. Let me see 
if I can put a message somewhere beneath to say the same. Will get back to you 
in a day or so.

Thanks for trying this out!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2017-03-13 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1762
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 464
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_routers_network_ops.py

 * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...

2017-03-13 Thread ramkatru
Github user ramkatru commented on the issue:

https://github.com/apache/cloudstack/pull/1997
  
@jayapalu, Please see Daan's and Wido's comments on the referenced PR 
#1307. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: [Proposal] - StorageHA

2017-03-13 Thread Jeromy Grimmett
I apologize for the delay on the response, let me clarify the points requested:

Mike asked:

"What I was curious about is if you plan to exclusively build your feature as a 
set of scripts and/or if you plan to update the CloudStack code base, as well."

JG:  My idea was to do this separately as a plugin, then add it to the code 
base down the road.

"Also, if a primary storage actually goes offline, I'm not clear on how 
starting an impacted VM on a different compute host would help. Could you 
clarify this for me?"

JG:  The VM would be started on another host that still has access to the 
storage.  Individually a host can have problems and lose its connectivity to a 
primary storage device.  The solution we are working on would help to get the 
VM back and up running much faster than waiting for Cloudstack to make a 
decision to restart the VM on a different host.

Paul asked:

"  1.  We can't/don't run scripts on vSphere hosts (not sure about Hyper-V)"

JG:  I should have been more clear, this is for KVM hosts.
  
"2.  I know of one failure scenario (which happened) where MTU issues in 
intermediate switches meant that small amounts of data could pass, but anything 
that was passed as jumbo frames then failed. So it would be important to 
exercise that."

JG:  I have faced this Jumbo Frame issue as well, perhaps we need to have an 
option that would indicate Jumbo Frames are being used to access that storage 
and the test result would reflect a failure to access using Jumbo Frames. 

"3.  You need to be very sure of failures before shutting hosts down.  Also a 
host is likely to be connected to multiple storage pools, so you wouldn't want 
to shut down a host due to one pool becoming unavailable."

JG:  The script wouldn’t shut down any hosts at all.  Just force stop the 
affected VMs on that specific host and then start them on a host that is not 
having the issue with storage.

"4.  Environments can have hundreds of storage pools, so watch out for spamming 
the logs with updates."

JG:  The polling/testing time increments are configurable, so I am hoping that 
can help with that.  The results are pretty small and should be relatively 
negligible.

"5.  The primary storage pools have a 'state' which should get updated and used 
by the deployment planners"

JG:  I have copied Alex on this email to make sure he sees this suggestion.  We 
will figure out how to incorporate that 'state' field.

"6.  Secondary storage pools don't have a 'state' - but it would be great if 
that were added in the DB and reflected in the UI."

JG:  For now, I think this might be a feature request that maybe we should 
submit through the normal Cloudstack request process.  Otherwise, we can 
definitely include that into our work when we start to add it into the code 
base.

To take this a step further, we are also working on a KVM host load balancer 
that will be used as a factor when moving the VMs.  We have a number of little 
projects we are working on.

Thank you all for reviewing the information.  All suggestions are welcome.

Jeromy Grimmett
P: 603.766.3625
jer...@cloudbrix.com
www.cloudbrix.com


-Original Message-
From: Paul Angus [mailto:paul.an...@shapeblue.com] 
Sent: Saturday, March 11, 2017 2:43 AM
To: dev@cloudstack.apache.org
Subject: RE: [Proposal] - StorageHA

Hi Jeromy,

I love the idea, I'm not really a developer, so those guys will look at things 
a different way, but...

These would be by my initial comments:


  1.  We can't/don't run scripts on vSphere hosts (not sure about Hyper-V)
  2.  I know of one failure scenario (which happened) where MTU issues in 
intermediate switches meant that small amounts of data could pass, but anything 
that was passed as jumbo frames then failed. So it would be important to 
exercise that.
  3.  You need to be very sure of failures before shutting hosts down.  Also a 
host is likely to be connected to multiple storage pools, so you wouldn't want 
to shut down a host due to one pool becoming unavailable.
  4.  Environments can have hundreds of storage pools, so watch out for 
spamming the logs with updates.
  5.  The primary storage pools have a 'state' which should get updated and 
used by the deployment planners
  6.  Secondary storage pools don't have a 'state' - but it would be great if 
that were added in the DB and reflected in the UI.



Kind regards,

Paul Angus


paul.an...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
  
 

From: Jeromy Grimmett [mailto:jer...@cloudbrix.com]
Sent: 10 March 2017 15:28
To: dev@cloudstack.apache.org
Subject: [Proposal] - StorageHA

Hello,

I am new to the mailing list, and we are glad to be a part of the CloudStack 
community.  We are looking to develop plugins and modules that will help grow 
and expand the adoption and use of CloudStack.  So as part of my introductory 
email, I'd like to introduce a little project we have been working on; a 
StorageHA Monitor.  The 

Re: Cannot edit confluence wiki page

2017-03-13 Thread Rajani Karuturi
You(shanika) should have access to the edit the wiki now.

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On March 12, 2017 at 8:43 PM, Shanika Ediriweera
(shanika...@cse.mrt.ac.lk) wrote:

Thank you.

Should I drop another mail saying I am interested in the above
mentioned
project

Best Regards,

Shanika Ediriweera
Undergraduate
Dept. of Computer Science & Eng.
University of Moratuwa

On 12 March 2017 at 13:41, sachin patil 
wrote:

Hello Shanika,

Actually, the page was created so that gsoc students
could add their names there. But that is not the case now as
students
don't have the rights required to update the page. I'll ask
someone to
remove/edit the page accordingly.
regards,
Sachin Patil

On Sun, Mar 12, 2017 at 12:28 PM, Shanika Ediriweera <
shanika...@cse.mrt.ac.lk> wrote:

Hi,

I am interested in CLOUDSTACK-9804
 project
for gsoc
2017.

But I am unable to edit the page
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Googl
e+Summer+of+Code+2017
.

Please could someone guide me how to edit the page and add my
name in the
"Candidates interested" column.

Thank you.

Best Regards,

Shanika Ediriweera
Undergraduate
Dept. of Computer Science & Eng.
University of Moratuwa

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-13 Thread cloudsadhu
Github user cloudsadhu commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@serg38 - thanks for your comment- I have added nfs support





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-13 Thread nitin-maharana
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rafaelweingartner : As there are multiple contributors to this feature, If 
I squash it to one commit, then others are going to lose their part of 
contributions. Initially, we thought of making it to one commit, but this is 
the main reason we pushed with multiple commits. Let's wait for others to 
comment on this, after that we will decide. Thanks, @rafaelweingartner for 
pitching in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

2017-03-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Thanks Will. Can you please add bug id(CLOUDSTACK-9811) to the PR and 
commit message?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-13 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1278
  
Hi @rafaelweingartner @anshul1886 @GabrielBrascher,
I've read this PR's comments several times and I think I could understand 
@anshul1886's point. Please correct me if I'm wrong. The execution of 
`getCallingAccount()` is setting the context with the proper account, and I 
think that's fine, as next methods will use it (e.g. `orchestrateStart` in 
`VirtualMachineManagerImpl` lines 829-831).
I also agree with @rafaelweingartner and @GabrielBrascher that even though 
the context is being set, variables `user` and `caller` on `start` method 
(defined on line 266) are not being used. @anshul1886, if no validations are 
required and the context is already set, don't you think that those unused 
parameters can be removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
This seems to be a great idea @nvazquez.
What do you think @jayakarteek ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
Trillian test result (tid-953)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45570 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1880-t953-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Test completed. 46 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_test_vm_volume_snapshot | `Failure` | 342.55 | test_vm_snapshots.py
test_04_rvpc_privategw_static_routes | `Failure` | 919.54 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 81.22 | 
test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 86.31 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 371.26 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 166.74 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 587.67 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 379.85 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 795.54 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 667.55 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1580.39 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 715.16 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 669.22 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1391.68 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 30.82 | test_volumes.py
test_06_download_detached_volume | Success | 51.00 | test_volumes.py
test_05_detach_volume | Success | 110.30 | test_volumes.py
test_04_delete_attached_volume | Success | 10.19 | test_volumes.py
test_03_download_attached_volume | Success | 15.28 | test_volumes.py
test_02_attach_volume | Success | 53.71 | test_volumes.py
test_01_create_volume | Success | 514.68 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 494.29 | 
test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 275.15 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 230.09 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.74 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 217.48 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.95 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 66.05 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.15 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.13 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.23 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.16 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 217.42 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 10.22 | test_templates.py
test_03_delete_template | Success | 5.13 | test_templates.py
test_02_edit_template | Success | 90.19 | test_templates.py
test_01_create_template | Success | 105.85 | test_templates.py
test_10_destroy_cpvm | Success | 236.95 | test_ssvm.py
test_09_destroy_ssvm | Success | 238.81 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.64 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.49 | test_ssvm.py
test_06_stop_cpvm | Success | 176.85 | test_ssvm.py
test_05_stop_ssvm | Success | 173.74 | test_ssvm.py
test_04_cpvm_internals | Success | 1.25 | test_ssvm.py
test_03_ssvm_internals | Success | 3.43 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 66.42 | test_snapshots.py
test_04_change_offering_small | Success | 97.24 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-03-13 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
@jayakarteek @rafaelweingartner what about retrieving CPU performance 
metric for usage using 
[PerfomanceManager](https://pubs.vmware.com/vsphere-60/index.jsp#com.vmware.wssdk.apiref.doc/vim.PerformanceManager.html)?
 It is already used in `VmwareResource.getVmStats` lines 5134-5185 to retrieve 
vm network metrics. I think that similar as it is done for these metrics, we 
must query for available metrics and look for [usage CPU 
counter](https://pubs.vmware.com/vsphere-60/index.jsp?topic=%2Fcom.vmware.wssdk.apiref.doc%2Fcpu_counters.html)
 which already comes as percentage for a given interval which would have to be 
low. This way we don't have to calculate depending on limit flag. What do you 
think about this approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1891
  
Trillian test result (tid-952)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45011 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1891-t952-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Test completed. 46 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_test_vm_volume_snapshot | `Failure` | 277.24 | test_vm_snapshots.py
test_04_rvpc_privategw_static_routes | `Failure` | 878.79 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 121.10 | 
test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 126.19 | 
test_snapshots.py
ContextSuite context=TestSnapshotRootDisk>:teardown | `Error` | 156.48 | 
test_snapshots.py
test_02_vpc_privategw_static_routes | `Error` | 646.76 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 366.15 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 151.59 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 558.22 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 329.08 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 707.72 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 661.92 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1529.30 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 725.10 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 714.27 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1524.70 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 30.78 | test_volumes.py
test_06_download_detached_volume | Success | 55.48 | test_volumes.py
test_05_detach_volume | Success | 105.28 | test_volumes.py
test_04_delete_attached_volume | Success | 20.23 | test_volumes.py
test_03_download_attached_volume | Success | 15.28 | test_volumes.py
test_02_attach_volume | Success | 58.70 | test_volumes.py
test_01_create_volume | Success | 511.69 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 476.60 | 
test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 232.18 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.63 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 222.39 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.71 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.18 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 65.98 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.11 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.12 | test_vm_life_cycle.py
test_02_start_vm | Success | 15.19 | test_vm_life_cycle.py
test_01_stop_vm | Success | 5.11 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 216.45 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 15.22 | test_templates.py
test_03_delete_template | Success | 5.12 | test_templates.py
test_02_edit_template | Success | 90.13 | test_templates.py
test_01_create_template | Success | 115.92 | test_templates.py
test_10_destroy_cpvm | Success | 211.69 | test_ssvm.py
test_09_destroy_ssvm | Success | 268.64 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.47 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.25 | test_ssvm.py
test_06_stop_cpvm | Success | 176.81 | test_ssvm.py
test_05_stop_ssvm | Success | 183.65 | test_ssvm.py
test_04_cpvm_internals | Success | 1.09 | test_ssvm.py
test_03_ssvm_internals | Success | 3.12 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_01_snapshot_root_disk | Success | 61.32 | test_snapshots.py
test_04_change_offering_small 

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-13 Thread nvazquez
Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105797159
  
--- Diff: 
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 ---
@@ -409,15 +460,13 @@ public StoragePoolVO persist(StoragePoolVO pool, 
Map details) {
 sc.and(sc.entity().getScope(), Op.EQ, ScopeType.ZONE);
 return sc.list();
 } else {
-Map details = tagsToDetails(tags);
-
-StringBuilder sql = new 
StringBuilder(ZoneWideDetailsSqlPrefix);
+StringBuilder sql = new StringBuilder(ZoneWideTagsSqlPrefix);
--- End diff --

Thanks for pointing this out, I had missed it out. Created methods 
`getSqlPreparedStatement` and `searchStoragePoolsPreparedStatement` which are 
called from many methods and allow storage pool retrieval


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-13 Thread nvazquez
Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105796872
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
+
+final int detailsBatchSize = batchCfg != null ? 
Integer.parseInt(batchCfg) : 2000;
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
+while ((curr_index + detailsBatchSize) <= stIds.length) {
+Long[] ids = new Long[detailsBatchSize];
+
+for (int k = 0, j = curr_index; j < curr_index + 
detailsBatchSize; j++, k++) {
+ids[k] = stIds[j];
+}
+
+SearchCriteria sc = 
StoragePoolIdsSearch.create();
--- End diff --

Done, created method `searchForStoragePoolIdsInternal`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-13 Thread nvazquez
Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105796786
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
--- End diff --

About number 2000, I assumed it was a default value for that configuration


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1759: CLOUDSTACK-9589 vmName entries from host_details tab...

2017-03-13 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1759
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 463
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_routers_network_ops.py

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
2 runs


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-13 Thread nvazquez
Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r105796076
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
--- End diff --

Done, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-13 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
@rafaelweingartner I pushed changes and squashed my commits as it could be 
easier to review. I also added unit tests for new methods


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

2017-03-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-591


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@nitin-maharana I was looking at the PR.
Do you need to split everything thing there in a different commit?
I think that we still do not have a clear understanding when and how to 
separate things in a commit; however, anything like 90+ commits in a PR seems 
exaggerated to me.

I like the philosophy that for every commit we should be able to get the 
system, build it and use it. This, for instance, would not happen here. Again, 
as I said, I think we do not have a clear rule about that, but I would like 
others to check this situation as well.

@DaanHoogland, @rhtyd, @swill any thoughts here?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-13 Thread nitin-maharana
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
It has already two LGTMs and contains all successful test results. This is 
a big change, as time passes there are more chances of conflicts 
appearance(Already resolved once). If anyone wants to review, please do it else 
we should consider merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

2017-03-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Thanks for this fix @swill 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: midonet-client and Guava dependency conflict

2017-03-13 Thread Rafael Weingärtner
I got a reply from Midonet community; they said that midonet-client was
incorporated by midonet-cluster (
https://github.com/midonet/midonet/tree/staging/v5.4/midonet-cluster).


So, if anyone wants to invest energy on this, it might be a good idea to
upgrade the dependency. Moreover, I start to question the compatibility of
the current client we are using, with the mido-net server side that might
be deployed by users. Will this partial integration that we have work?

On Sat, Mar 11, 2017 at 2:49 AM, Paul Angus 
wrote:

> Jeff,
>
> To confirm what Rohit said, I spoke with Midokura a couple of years ago,
> they did some basics, then were looking for a customer to finish/polish the
> implementation with.
>
> AFAIK that never happened, as customers wanted to see it working FIRST
> before signing up.
>
> Kind regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Jeff Hair [mailto:j...@greenqloud.com]
> Sent: 10 March 2017 13:45
> To: dev@cloudstack.apache.org
> Subject: Re: midonet-client and Guava dependency conflict
>
> The Midonet jar has Guava 18 packaged into it with the Shade plugin.
> Guava-19.0 is also on the classpath. But for whatever reason,
> com.google.common.base.Equivalence is being loaded from the Midonet jar
> instead of guava-19.0.jar, even with an alphabetically sorted classpath.
> This causes the error mentioned in the original message. My next step is to
> figure out if this is just what happens when CS 4.9 is running on Tomcat 8
> (my current guess), or if it's some weird interaction with changes we've
> made on our fork (don't see how it can be the case, but must try all
> possibilities). Guava 19.0 is coming in as a transitive dependency of
> Reflections 0.9.10. This version was set in commit bb29b1d06.
>
> *Jeff Hair*
> Technical Lead and Software Developer
>
> Tel: (+354) 415 0200
> j...@greenqloud.com
> www.greenqloud.com
>
> On Fri, Mar 10, 2017 at 1:34 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > Are these Guava classes in the Midonet jar? Or do you have two jars
> > for the same library with two different version in the lib folder?
> >
> > On Fri, Mar 10, 2017 at 8:32 AM, Jeff Hair  wrote:
> >
> > > I have managed to confirm with advanced debugging techniques (i.e.
> > sticking
> > > log statements everywhere) that the classloader which sorts the jars
> > > is working as expected, but the error with guava is still popping
> > > up. My
> > next
> > > step is to see if there is some overriding of the sorted classpath
> > loader.
> > >
> > > *Jeff Hair*
> > > Technical Lead and Software Developer
> > >
> > > Tel: (+354) 415 0200
> > > j...@greenqloud.com
> > > www.greenqloud.com
> > >
> > > On Fri, Mar 10, 2017 at 9:25 AM, Rohit Yadav
> > > 
> > > wrote:
> > >
> > > > +1 Retire unsupported plugins, with at least comment them from the
> > > default
> > > > build/packaging in plugins/pom.xml?
> > > >
> > > >
> > > > Several plugins in 'plugins/network-elements/' may be removed from
> > > > the default build/packaging. However, 'midonet' was never fully
> > > > implemented
> > > or
> > > > completed and most definitely removed.
> > > >
> > > >
> > > > Regards.
> > > >
> > > > 
> > > > From: Simon Weller 
> > > > Sent: 09 March 2017 21:37:08
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: midonet-client and Guava dependency conflict
> > > >
> > > > So this brings up a good discussion point. As Jeff points out, the
> > > Midonet
> > > > plugin hasn't been actively supported for almost 5 years. At what
> > > > point
> > > do
> > > > we consider retiring unsupported plugins?
> > > >
> > > >
> > > > - Si
> > > >
> > > >
> > > > 
> > > > From: Jeff Hair 
> > > > Sent: Thursday, March 9, 2017 9:43 AM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: midonet-client and Guava dependency conflict
> > > >
> > > > After doing some more digging, I have confirmed the following:
> > > >
> > > >- The midonet plugin is using the Maven Shade plugin to put a
> > > > bunch
> > of
> > > >dependencies into itself.
> > > >- The plugin hosted in this repository was last updated in 2013.
> > > >- Most importantly: removing all the guava stuff out of the
> midonet
> > > >plugin fixes this issue.
> > > >
> > > > I have not had any success in applying
> > > > https://github.com/openwide-java/tomcat-classloader-ordered to get
> > > Tomcat
> > > > [https://avatars1.githubusercontent.com/u/1385131?v=3=400] > > > :// github.com/openwide-java/tomcat-classloader-ordered>
> > > >
> > > > GitHub - openwide-java/tomcat-classloader-ordered: A ...<
> > > > https://github.com/openwide-java/tomcat-classloader-ordered>
> > > > github.com
> > > > README.md 

Re: [Discuss] 4.10: VR don't come up on Physical KVM host - possible blocker for 4.10

2017-03-13 Thread Will Stevens
Boris, please test this PR in your environment:
https://github.com/apache/cloudstack/pull/2003

Thanks,

*Will Stevens*



On Mon, Mar 13, 2017 at 3:35 PM, Will Stevens  wrote:

> I will open a PR to update the offending line of code to be more defensive
> so it won't error.  We can't revert that change because it will
> re-introduce a bug which causes the source nat IP to not be the primary IP
> on the nic after a VR reboot.
>
> I will open a PR to fix this right now so you can test it.
>
> Thanks,
>
> *Will Stevens*
>
>
>


[GitHub] cloudstack pull request #2003: fixed an issue if the dev is not in the datab...

2017-03-13 Thread swill
GitHub user swill opened a pull request:

https://github.com/apache/cloudstack/pull/2003

fixed an issue if the dev is not in the databag

Defend against the specified dev not being in the databag.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/swill/cloudstack cs_ip_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2003.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2003


commit 6cde7cdaef5082446872c8858392f54fc11dba92
Author: Will Stevens 
Date:   2017-03-13T19:37:54Z

fixed an issue if the dev is not in the databag




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [Discuss] 4.10: VR don't come up on Physical KVM host - possible blocker for 4.10

2017-03-13 Thread Will Stevens
I will open a PR to update the offending line of code to be more defensive
so it won't error.  We can't revert that change because it will
re-introduce a bug which causes the source nat IP to not be the primary IP
on the nic after a VR reboot.

I will open a PR to fix this right now so you can test it.

Thanks,

*Will Stevens*


Re: [Discuss] 4.10: VR don't come up on Physical KVM host - possible blocker for 4.10

2017-03-13 Thread Boris Stoyanov
Hi Guys,

Thanks to Will Stevens we’ve managed to identify that the changes in cs_ip.py 
introduced in StrongSwan development were causing this blocker. I guess it 
managed to slip in, since it appears only on physical KVM hosts.

I’ve reverted back to the state of cs_ip.py before the changes and was able to 
start the VR with this commit:
https://github.com/swill/cloudstack/blob/8b4c36ef501a96742c52b4d532cc3adda25aa71b/systemvm/patches/debian/config/opt/cloud/bin/cs_ip.py

I guess we’ll need to create separate PR to address fixing this issue, and 
refactor the StrongSwan changes, so that it works with physical KVM hosts. I’ll 
be happy to assist with testing these changes.

Thanks,
Boris Stoyanov


boris.stoya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

On Mar 7, 2017, at 12:21 PM, Boris Stoyanov 
> wrote:

Hello everyone,

We’ve hit this issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9811

On our physical hosts environment we’re not able to start the VR, it appears 
that it’s looking for eth3 configuration but no such is available. We’ve 
narrowed down the issue only to 4.10, so it must been a change that went in 
there that is causing this.
Currently this issue is logged as Critical and I’m suggesting we escalate it to 
Blocker, as it is blocking the user to deploy a VM on a KVM physical host.

Does anyone recall any change that might have caused this?

Please find the logs attached and further details in the bug.

Thanks,
Boris Stoyanov

boris.stoya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue






[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-03-13 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1878
  
@rafaelweingartner Thanks for reviewing, will work on the changes suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105725769
  
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long 
dataCenterId, Long podId, Long c
 // set up a new alert
 AlertVO newAlert = new AlertVO();
 newAlert.setType(alertType.getType());
-newAlert.setSubject(subject);
+//do not have a seperate column for content.
+//appending the message to the subject for now.
+newAlert.setSubject(subject+content);
--- End diff --

Are you sure this is a good idea?
If the column for content does exist, what about creating it with this PR? 
Thus, we can avoid this type of half measure solution. Especially that the 
column `subject` has a limitation on its size  `@Column(name = "subject", 
length = 999)`; this can potentially create problems in certain conditions in 
runtime.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105723834
  
--- Diff: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -986,33 +986,28 @@ public Answer easySend(final Long hostId, final 
Command cmd) {
 }
 
 @Override
-public boolean reconnect(final long hostId) {
+public void reconnect(final long hostId) throws CloudRuntimeException, 
AgentUnavailableException{
--- End diff --

You added `AgentUnavailableException` to the method signature, but I did 
not see you throwing this exception anywhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105724153
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
 ---
@@ -512,7 +512,11 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 });
 HostVO host = _hostDao.findById(lbDeviceVo.getHostId());
 
-_agentMgr.reconnect(host.getId());
+try {
+_agentMgr.reconnect(host.getId());
+} catch (Exception e ) {
--- End diff --

Cannot you use a more specific `catch` here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...

2017-03-13 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/2002
  
@sudhansu7 Shouldn't we update POD id upon a successful migration? If 
migration fails we will have wrong POD id in the DB.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105723444
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java ---
@@ -100,17 +103,18 @@ public Long getInstanceId() {
 @Override
 public void execute() {
 try {
-Host result = _resourceService.reconnectHost(this);
-if (result != null) {
-HostResponse response = 
_responseGenerator.createHostResponse(result);
-response.setResponseName(getCommandName());
-this.setResponseObject(response);
-} else {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
"Failed to reconnect host");
-}
-} catch (Exception ex) {
-s_logger.warn("Exception: ", ex);
-throw new 
ServerApiException(ApiErrorCode.RESOURCE_UNAVAILABLE_ERROR, ex.getMessage());
+Host result =_resourceService.reconnectHost(this);
--- End diff --

Before the `result` was checked for `null`; can the method 
`_resourceService.reconnectHost(this)` return null?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105723252
  
--- Diff: api/src/com/cloud/resource/ResourceService.java ---
@@ -50,7 +52,7 @@
 
 Host cancelMaintenance(CancelMaintenanceCmd cmd);
 
-Host reconnectHost(ReconnectHostCmd cmd);
+Host reconnectHost(ReconnectHostCmd cmd) throws CloudRuntimeException, 
AgentUnavailableException;
--- End diff --

The `CloudRuntimeException` is a `RuntimeException` you do not need to 
declare it in the method signature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105723986
  
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
 
 public void pullAgentOutMaintenance(long hostId);
 
-boolean reconnect(long hostId);
+void reconnect(long hostId) throws CloudRuntimeException, 
AgentUnavailableException;
--- End diff --

the `CloudRuntimeException` is a `RuntimeException` you do not need to 
declare it in the method signature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1968: CLOUDSTACK-9666 Added basic configuration validation...

2017-03-13 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1968
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 462
 Hypervisor xenserver
 NetworkType Advanced
 Passed=102
 Failed=3
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed

* test_routers_network_ops.py

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed

 * test_03_RVR_Network_check_router_state Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-13 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r105722036
  
--- Diff: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1049,7 +1044,13 @@ public boolean executeUserRequest(final long hostId, 
final Event event) throws A
 }
 return true;
 } else if (event == Event.ShutdownRequested) {
-return reconnect(hostId);
+//should throw a exception here as well.instead of eating this 
up.
+   try {
+   reconnect(hostId);
+   } catch (CloudRuntimeException e) {
--- End diff --

@bvbharatk Is it possible to take the failure reason forward?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-13 Thread Rajani Karuturi
1866 - failed BVT results(may not be related. But, needs to be
checked. Also, jenkins and travis failed)

1967 - no test results

rest merged.

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On March 4, 2017 at 8:13 PM, Haijiao (18602198...@163.com) wrote:

[GitHub] cloudstack issue #1967: CLOUDSTACK-9638 Problems caused when inputting doubl...

2017-03-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1967
  
@bvbharat can you start internal CI and post results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #847: Bug-ID: CLOUDSTACK-8880: calculate free memory...

2017-03-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/847


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-03-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1953


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1856: [4.9] CLOUDSTACK-9569: propagate global confi...

2017-03-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1856


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait...

2017-03-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1861


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-03-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1958


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-03-13 Thread Rajani Karuturi
We still have below three blockers open. I will create RC once
they are fixed.

~ Rajani

http://cloudplatform.accelerite.com/

On March 9, 2017 at 10:09 AM, Rajani Karuturi (raj...@apache.org)
wrote:

We currently have the below list of blockers:

BUGID - Summary - Assignee - Creator

CLOUDSTACK-9827 - Storage tags stored in multiple places -
Nicolas Vazquez - Mike Tutkowski - PR Ready

CLOUDSTACK-9811 - VR will not start, looking to configure eth3
while no such device exists on the VR. On KVM-CentOS6.8 physical
host - Unassigned - Boris Stoyanov

CLOUDSTACK-9408 - remove runtime references to
http://download.cloud.com - Daan Hoogland - Daan Hoogland

Can someone take a look at CLOUDSTACK-9811?

~ Rajani

http://cloudplatform.accelerite.com/

On March 9, 2017 at 3:16 AM, Tutkowski, Mike
(mike.tutkow...@netapp.com) wrote:

Hi,

Sure, I can pull that code and test.

I might have to wait until tomorrow, though, because I’m in the
middle of trying to reproduce CLOUDSTACK-9823. Once that is done,
I can move on to your PR.

Thanks!
Mike

On 3/8/17, 1:45 PM, "Nicolas Vazquez" 
wrote:

Hi Mike,

Thanks for reporting this issue! We've been working on it and
created this
PR: https://github.com/apache/cloudstack/pull/1994. We've been
testing it
and seems to be solving the issues reported, can you please
repeat your
tests on it?

Thanks,
Nicolas

2017-03-07 21:52 GMT-03:00 Tutkowski, Mike
:

> Here’s the ticket:
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-9827
>
> On 3/7/17, 1:51 PM, "Tutkowski, Mike"
 wrote:
>
> Yes, I can open a ticket.
>
> > On Mar 7, 2017, at 1:50 PM, Sergey Levitskiy <
> sergey.levits...@autodesk.com> wrote:
> >
> > Yes that’s the bug. Can you open a ticket for this? @
nvazquez can
> you take a look?
> >
> > On 3/7/17, 12:44 PM, "Tutkowski, Mike"

> wrote:
> >
> > This does seem messed up.
> >
> > If I add a new primary storage and give it a storage tag,
the tag
> ends up in storage_pool_details.
> >
> > If I edit an existing storage pool’s storage tags, it places
them
> in storage_pool_tags.
> >
> > On 3/7/17, 1:39 PM, "Tutkowski, Mike"

> wrote:
> >
> > I believe I have found another bug (one that we should
either
> fix or examine in detail before releasing 4.10).
> >
> > It looks like we have a new table: cloud.storage_pool_tags.
> >
> > The addition of this table seems to have broken the
> listStorageTags API command. When this command runs, it
doesn’t pick up any
> storage tags for me (and I know I have one storage tag).
> >
> > This data used to be stored in the
cloud.storage_pool_details
> table. It’s good to put it in its own table, but will our
upgrade process
> move the existing tags from storage_pool_details to
storage_pool_tags?
> >
> > I have not yet opened a ticket for this. I want to examine
it
> a bit more before doing so.
> >
> > On 3/7/17, 8:10 AM, "Tutkowski, Mike" <
> mike.tutkow...@netapp.com> wrote:
> >
> > No VM snapshot.
> >
> > I tried while the VM was in the Running state and then I
> also tried in the Stopped state. Same results.
> >
> >> On Mar 7, 2017, at 7:54 AM, Sergey Levitskiy <
> sergey.levits...@autodesk.com> wrote:
> >>
> >> Is VM has an VMsnaphsot? Is VM in Stopped state?
> >>
> >> On 3/6/17, 10:32 PM, "Tutkowski, Mike"

> wrote:
> >>
> >> I seem to have found another blocker:
> >>
> >> https://issues.apache.org/jira/browse/CLOUDSTACK-9822
> >>
> >> On 3/6/17, 9:51 PM, "Rajani Karuturi" 
wrote:
> >>
> >> PRs are ready for the blockers. Waiting for reviews and
test
> >> results. Once they are ready, I will merge them(and a few
more
> >> bug fixes) and create RC2 (probably tomorrow, Wednesday)
> >>
> >> Thanks,
> >>
> >> ~ Rajani
> >>
> >> http://cloudplatform.accelerite.com/
> >>
> >> On March 3, 2017 at 4:30 PM, Rajani Karuturi (
> raj...@apache.org)
> >> wrote:
> >>
> >> I will create RC2 on Monday with the fixes mentioned in my
> >> previous mail.
> >>
> >> ~ Rajani
> >>
> >> http://cloudplatform.accelerite.com/
> >>
> >> On March 3, 2017 at 2:36 PM, Rohit Yadav
> >> (rohit.ya...@shapeblue.com) wrote:
> >>
> >> Thanks Koushik, I did not realize Kishan had sent this
> already.
> >> Let's get either of the PRs merged and kick a RC2.
> >>
> >> Regards.
> >>
> >> 
> >> From: Koushik Das 
> >> Sent: 03 March 2017 14:14:56
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0
> >>
> >> Looks like there is already a PR for the same issue
> >> https://github.com/apache/cloudstack/pull/1982 from Kishan.
> >>
> >> -Koushik
> >>
> >> On 03/03/17, 1:58 PM, "Rohit Yadav" <
> rohit.ya...@shapeblue.com>
> >> wrote:
> >>
> >> -1 (binding)
> >>
> >> All, I've found an upgrade blocker. Pre 4.6 users are
required
> >> to seed 4.6 systemvmtemplate to proceed with the upgrade
> >> otherwise upgrade 

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
@jayakarteek thanks for the explanation
I thought that ACS would configure those parameters automatically. The way 
you described it feels like ACS is not limiting the use of CPU for VMs created 
in VMware systems. 

I was checking the code, and there is this piece here: 
`com.cloud.hypervisor.vmware.util.VmwareHelper.setBasicVmConfig(VirtualMachineConfigSpec,
 int, int, int, int, int, String, boolean)`. At line 634 ACS is setting the CPU 
limit if CPU cap is enabled. Isn't that information available to be retrieved 
later (when we get the stats of a VM)? I know, this will only work with CPU 
cap. However, we could retrieve that CPU limit configuration, if it is '-1', we 
could then retrieve the CPU speed of the host (and use it to calculate the 
percentage of usage), is it possible? Or do you think it brings much trouble 
for the code?

@nvazquez could you also provide some feedback here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1878#discussion_r105676576
  
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -302,4 +309,17 @@ public int countNicsForStartingVms(long networkId) {
 List results = customSearch(sc, null);
 return results.get(0);
 }
+
+@Override
+public Long getPeerRouterId(String publicMacAddress, final long 
routerId) {
+final SearchCriteria sc = PeerRouterSearch.create();
+sc.setParameters("instanceId", routerId);
+sc.setParameters("macAddress", publicMacAddress);
+sc.setParameters("vmType", VirtualMachine.Type.DomainRouter);
+NicVO nicVo = findOneBy(sc);
+if (nicVo != null) {
+return (new Long(nicVo.getInstanceId()));
--- End diff --

Let the auto-boxing and auto-unboxing do this for you.
When you do this manually the pool of String/numbers of java will not be 
used.
You just need to return `nicVo.getInstanceId()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1878#discussion_r105679910
  
--- Diff: 
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
 ---
@@ -216,6 +216,20 @@ public void testScaleVMF1() throws Exception {
 }
 
 @Test
+public void testReplaceNicsMacSequenceInBootArgs() throws Exception {
--- End diff --

Do you need this `throws Exception` here?
It does not seem o be required by any of the method calls you have here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

2017-03-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1878#discussion_r105677642
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2072,6 +2121,17 @@ protected StartAnswer execute(StartCommand cmd) {
 }
 
 /**
+ * Update boot args with the new nic mac addresses.
+ */
+protected String replaceNicsMacSequenceInBootArgs(String 
oldMacSequence, String newMacSequence, VirtualMachineTO vmSpec) {
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs) && 
!StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
+return bootArgs.replace(oldMacSequence, newMacSequence);
+}
+return "";
--- End diff --

Is this case possible? `bootArgs` not empty and `oldMacSequence` or 
`newMacSequence` empty

If so, would not it be better to return at line 2131 the variable 
`bootArgs`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: old wishes

2017-03-13 Thread Rafael Weingärtner
The proposal seems interesting, I do not know why it was closed in the
first place.

Ticket reopened; now you just need to discuss and code the proposal ;)

On Sat, Mar 11, 2017 at 8:17 PM, Jan-Arve Nygård 
wrote:

> My Jira username is thinktwo, but i'm not a developer so it's probably
> better if it stays without an assignee?
>
> 2017-03-12 2:13 GMT+01:00 Rafael Weingärtner  >:
>
> > I can reopen and add you as an Assignee if you wish to work on this one.
> > What is your Jira ID?
> >
> > On Sat, Mar 11, 2017 at 7:42 PM, Jan-Arve Nygård <
> > jan.arve.nyg...@gmail.com>
> > wrote:
> >
> > > Hi,
> > >
> > > I can't reopen CLOUDSTACK-4603
> > >  but i might be
> > > missing rights? If it's not possible to reopen the issue, i can start a
> > > discussion about this feature request before i decide to recreate it or
> > > not.
> > >
> > > -thinktwo
> > >
> > > 2017-02-08 10:25 GMT+01:00 Daan Hoogland  >:
> > >
> > > > H devs,
> > > >
> > > > I am busy closing all wishes that haven’t been  discussed for more
> > then 2
> > > > years. Please feel free to reopen any that you feel are still
> relevant.
> > > > Going through them one by one turned out to be to time consuming.
> > > >
> > > > Verzonden vanuit Mail >
> > > > voor KV-guests
> > > >
> > > >
> > > > daan.hoogl...@shapeblue.com
> > > > www.shapeblue.com
> > > > 53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands
> > > > @shapeblue
> > > >
> > > >
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > Rafael Weingärtner
> >
>



-- 
Rafael Weingärtner


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-13 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
@mike-tutkowski awesome, thanks for testing this PR!

@rafaelweingartner thanks for reviewing, I'll work on changes proposed

@karuturi sure, I'll work on it, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1983: [4.10/blocker] Upgrade4920to41000: Migrate systemvmt...

2017-03-13 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1983
  
Closing since another similar PR has been merged now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-03-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-13 Thread kiwiflyer
Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
@karuturi  3 x LGTM, testing successful. Ready for Merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1891
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...

2017-03-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1891
  
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1891
  
@borisstoyanov unsupported parameters provided. Supported mgmt server os 
are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, 
kvm-centos7, kvm-ubuntu, xenserver-65sp1, xenserver-62sp1, vmware-60u2, 
vmware-55u3, vmware-51u1, vmware-50u1`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...

2017-03-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1891
  
@blueorangutan test centos7 vmware-65u1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-589


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1891
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-590


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not clea...

2017-03-13 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1740
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 461
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...

2017-03-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1891
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-03-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...

2017-03-13 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1891
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2002: CLOUDSTACK-9831: Previous pod_id still remain...

2017-03-13 Thread sudhansu7
GitHub user sudhansu7 opened a pull request:

https://github.com/apache/cloudstack/pull/2002

CLOUDSTACK-9831: Previous pod_id still remains in the vm_instance table

Previous pod_id still remains in the vm_instance table after VM migration 
with migrateVirtualMachineWithVolume

{noformat}

Previous pod_id still remains in the vm_instance table after VM migration 
with migrateVirtualMachineWithVolume

Before migrateVirtualMachineWithVolume
mysql> select v.id,v.instance_name,h.name,v.pod_id as 
pod_id_from_instance_tb,h.pod_id as pod_id_from_host_tb from vm_instance v, 
host h where v.host_id=h.id and v.id=2;

--
id  instance_name   namepod_id_from_instance_tb 
pod_id_from_host_tb


--
2   i-2-2-VMtestVM  1   1


--
1 row in set (0.00 sec)

After migrateVirtualMachineWithVolume
mysql> select v.id,v.instance_name,h.name,v.pod_id as 
pod_id_from_instance_tb,h.pod_id as pod_id_from_host_tb from vm_instance v, 
host h where v.host_id=h.id and v.id=3;

-
id  instance_name   namepod_id_from_instance_tb 
pod_id_from_host_tb


-
3   i-2-3-VMtestVm1 1   2


-
1 row in set (0.00 sec)

{noformat}

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sudhansu7/cloudstack CLOUDSTACK-9831

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2002.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2002


commit 7018bf13e51e9d71dcd4ab2393fa95cd6a437def
Author: Sudhansu 
Date:   2017-03-13T07:44:12Z

CLOUDSTACK-9831: Previous pod_id still remains in the vm_instance table 
after
 VM migration with migrateVirtualMachineWithVolume




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-13 Thread priyankparihar
Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@serg38 and @borisstoyanov Thanks for giving your precious time.

@sadhugit is looking for test cases related suggestions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-03-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit We have ported it in our branch and found it inconvenient to 
click the OK button in dialog with warning "No more hosts are available for 
migration" frequently.

could you remove the line below ?
```
 
cloudStack.dialog.notice({
 message: 
_l('message.no.host.available')
 }); //Only a 
single host in the set up
-} else {
- 
cloudStack.dialog.notice({
- message: 
_l('message.no.more.hosts.available')
- });
 }
 }
 });
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
@bvbharatk Yes, you might know only the vm has sshkey attached will have 
the password in vm details. If the vm does not have ssh keypair, then the vm 
password will not saved into user_vm_details.

Actually the vm password should be synced between master and backup. Saving 
to only one of them or saving to both of them are not working fine.
for example, if we save password in master, but not save it in backup. Once 
the master is down, then vm cannot get password from backup vr.
another example is, if we save password on both of master and backup, if vm 
get the password from master and reset it, once the master is down (or 
master->backup switch) and we reboot vm later, the vm will get the old password 
from backup again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-03-13 Thread jayakarteek
Github user jayakarteek commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
@rafaelweingartner 

The CPU.Reservation value by **default** is 0, Also the value is set in 
VMware not from the ACS UI.
this gives ambiguity about the CPU allocated and Utilised.

Use case 1 :
CPU.Reservation is 0 by default, In this case we cannot calculate % as the 
value is always zero.

Use case 2:
CPU.Reservation is set by VMware admin say 500Mhz.
But while creating vm-instance  using ACS UI , admin selected service 
offering as Medium Instance which is 1Ghz CPU. so CPU utilisation will be wrong.
In case say cloud environment has 30 instances , then Vmware admin has to 
manually set the CPU.Reservation value for each of the VM Instance which  is 
cumbersome. 






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-03-13 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
@rhtyd @karuturi Could see vSphere 4.1 in the latest installation guide. 
Please note that this documentation needs to be updated at some point later.
> vSphere and vCenter, versions 4.1, 5.0, 5.1 or 5.5.
> VMware vCenter Standard Edition 4.1, 5.0, 5.1 or 5.5 must be installed 
and available to manage the vSphere hosts.
> CloudStack requires VMware vSphere 4.1, 5.0, 5.1 or 5.5. VMware vSphere 
4.0 is not supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---