date:20170428

[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-04-28 Thread git

cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-298117640
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 596
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=9
Skipped=6
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   * test_network.py
   
* test_public_ip_admin_account Failed
   
   * test_deploy_virtio_scsi_vm.py
   
* test_01_verify_libvirt Failing since 12 runs
   
* test_02_verify_libvirt_after_restart Failing since 12 runs
   
* test_03_verify_libvirt_attach_disk Failing since 12 runs
   
* test_04_verify_guest_lspci Failing since 12 runs
   
* test_05_change_vm_ostype_restart Failing since 12 runs
   
* test_06_verify_guest_lspci_again Failing since 12 runs
   
* ContextSuite context=TestDeployVirtioSCSIVM>:teardown Failing since 12 
runs
   
   * test_routers_network_ops.py
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-04-28 Thread git

cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-298145735
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 597
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=8
Skipped=6
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   * test_network.py
   
* test_public_ip_admin_account Failing since 2 runs
   
   * test_deploy_virtio_scsi_vm.py
   
* test_01_verify_libvirt Failing since 13 runs
   
* test_02_verify_libvirt_after_restart Failing since 13 runs
   
* test_03_verify_libvirt_attach_disk Failing since 13 runs
   
* test_04_verify_guest_lspci Failing since 13 runs
   
* test_05_change_vm_ostype_restart Failing since 13 runs
   
* test_06_verify_guest_lspci_again Failing since 13 runs
   
* ContextSuite context=TestDeployVirtioSCSIVM>:teardown Failing since 13 
runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-04-28 Thread git

cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-298117640
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 596
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=9
Skipped=6
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   * test_network.py
   
* test_public_ip_admin_account Failed
   
   * test_deploy_virtio_scsi_vm.py
   
* test_01_verify_libvirt Failing since 12 runs
   
* test_02_verify_libvirt_after_restart Failing since 12 runs
   
* test_03_verify_libvirt_attach_disk Failing since 12 runs
   
* test_04_verify_guest_lspci Failing since 12 runs
   
* test_05_change_vm_ostype_restart Failing since 12 runs
   
* test_06_verify_guest_lspci_again Failing since 12 runs
   
* ContextSuite context=TestDeployVirtioSCSIVM>:teardown Failing since 12 
runs
   
   * test_routers_network_ops.py
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-04-28 Thread git

cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-298036704
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 595
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=8
Skipped=6
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   * test_vm_snapshots.py
   
* test_change_service_offering_for_vm_with_snapshots Failed
   
   * test_deploy_virtio_scsi_vm.py
   
* test_01_verify_libvirt Failing since 11 runs
   
* test_02_verify_libvirt_after_restart Failing since 11 runs
   
* test_03_verify_libvirt_attach_disk Failing since 11 runs
   
* test_04_verify_guest_lspci Failing since 11 runs
   
* test_05_change_vm_ostype_restart Failing since 11 runs
   
* test_06_verify_guest_lspci_again Failing since 11 runs
   
* ContextSuite context=TestDeployVirtioSCSIVM>:teardown Failing since 11 
runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-28 Thread git

blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN 
drops
URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-298100691
 
 
   Trillian test result (tid-1048)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31943 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2062-t1048-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Test completed. 49 look ok, 3 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 345.75 | 
test_privategw_acl.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_01_vpc_site2site_vpn | Success | 170.87 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 71.15 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 250.95 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 269.00 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 542.99 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 512.21 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1421.11 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 555.77 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 756.17 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1287.63 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 156.56 | test_volumes.py
   test_08_resize_volume | Success | 156.37 | test_volumes.py
   test_07_resize_fail | Success | 161.50 | test_volumes.py
   test_06_download_detached_volume | Success | 151.35 | test_volumes.py
   test_05_detach_volume | Success | 150.71 | test_volumes.py
   test_04_delete_attached_volume | Success | 146.33 | test_volumes.py
   test_03_download_attached_volume | Success | 156.31 | test_volumes.py
   test_02_attach_volume | Success | 89.17 | test_volumes.py
   test_01_create_volume | Success | 622.20 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 100.76 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 163.75 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 262.59 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.65 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.28 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 61.03 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 125.80 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 125.83 | test_vm_life_cycle.py
   test_02_start_vm | Success | 10.16 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 35.28 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 55.56 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.06 | test_templates.py
   test_04_extract_template | Success | 5.15 | test_templates.py
   test_03_delete_template | Success | 5.10 | test_templates.py
   test_02_edit_template | Success | 90.13 | test_templates.py
   test_01_create_template | Success | 55.51 | test_templates.py
   test_10_destroy_cpvm | Success | 161.61 | test_ssvm.py
   test_09_destroy_ssvm | Success | 163.73 | test_ssvm.py
   test_08_reboot_cpvm | Success | 101.56 | test_ssvm.py
   test_07_reboot_ssvm | Success | 133.59 | test_ssvm.py
   test_06_stop_cpvm | Success | 131.79 | test_ssvm.py
   test_05_stop_ssvm | Success | 133.72 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.19 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.65 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 86.94 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 11.23 | test_snapshots.py
   test_04_change_offering_small | Success | 210.09 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
   test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
   test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
   test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py

Re: Github messages on dev list

2017-04-28 Thread Tutkowski, Mike

I don’t know…I like waking up to about 200 e-mails that I need to delete. ;)

On 4/28/17, 7:52 AM, "Nicolas Vazquez"  wrote:

I personally prefer the way it worked before, where Github username was
shown in From field and not in Subject. That way mails could be grouped by
PR

2017-04-28 8:08 GMT-03:00 Will Stevens :

> I would be +1 for moving them to commits@.
>
> In the current implementation, I find it is not nearly as useful at a
> glance. The info I care about (PR number and user) are not visible when I
> scroll through the list. Ideally we could change the subject format to 
move
> the important info to the start of the message.
>
> Something like:
> Git #2062 (swill): whatever message about...
>
> On Apr 28, 2017 4:24 AM, "Rene Moser"  wrote:
>
> > Hi Wido
> >
> > There have been messages from github in the past (you probably had a
> > filter?). I already wrote I don't like it and suggested to use
> > comm...@cloudstack.apache.org for automated and bot messages.
> >
> > But a few devs insisted they like to keep them here that filtering would
> > be an option (for all others). So I created a filter (although I still
> > thing my suggestion would be the cleaner solution). The filter is not
> > matching anymore, I also have to adjust it.
> >
> > I am still +1 for moving them to commits@ and whoever needs them can
> > subscribe to this list. Opt-In.
> >
> > René
> >
> > On 04/28/2017 08:28 AM, Wido den Hollander wrote:
> > > Hi,
> > >
> > > See: https://issues.apache.org/jira/browse/INFRA-13929
> > >
> > > We are now getting all these messages from Github on
> > dev@cloudstack.apache.org
> > >
> > > We didn't have this before. Do we want this?
> > >
> > > Personally I find it very annoying that my inbox now gets so many
> > messages from Github.
> > >
> > > Anybody else feeling that way?
> > >
> > > Wido
> > >
> >
>

[GitHub] DaanHoogland commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-28 Thread git

DaanHoogland commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix 
test_deploy_virtio_scsi_vm.py
URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-298045082
 
 
   @karuturi can you merge this?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-04-28 Thread git

cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-298036704
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 595
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=8
Skipped=6
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   * test_vm_snapshots.py
   
* test_change_service_offering_for_vm_with_snapshots Failed
   
   * test_deploy_virtio_scsi_vm.py
   
* test_01_verify_libvirt Failing since 11 runs
   
* test_02_verify_libvirt_after_restart Failing since 11 runs
   
* test_03_verify_libvirt_attach_disk Failing since 11 runs
   
* test_04_verify_guest_lspci Failing since 11 runs
   
* test_05_change_vm_ostype_restart Failing since 11 runs
   
* test_06_verify_guest_lspci_again Failing since 11 runs
   
* ContextSuite context=TestDeployVirtioSCSIVM>:teardown Failing since 11 
runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : 
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113932053
 
 

 ##
 File path: 
engine/schema/src/org/apache/cloudstack/resourcedetail/ResourceDetailsDao.java
 ##
 @@ -77,4 +77,6 @@
 
 public void addDetail(long resourceId, String key, String value, boolean 
display);
 
+public void removeDetails(String key);
 
 Review comment:
   Again what is the need for this? There are already 
removeDetail/removeDetails() method present.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : 
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113932159
 
 

 ##
 File path: 
engine/schema/src/org/apache/cloudstack/resourcedetail/ResourceDetailsDaoBase.java
 ##
 @@ -104,6 +104,15 @@ public void removeDetail(long resourceId, String key) {
 }
 }
 
+public void removeDetails(String key) {
 
 Review comment:
   Is this needed?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : 
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113936474
 
 

 ##
 File path: 
framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
 ##
 @@ -1012,6 +1018,22 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 s_logger.debug("Purge queue item for cancelled 
job-" + job.getId());
 }
 _queueMgr.purgeAsyncJobQueueItemId(job.getId());
+
+if(job.getInstanceType().equals("Volume")) {
+// todo perform decrement opreation on the ref 
count based on the volume and snapshot
+
+try {
+
+VolumeDetailVO volumeDetailVO = 
_volumeDetailsDao.findDetail(job.getInstanceId(), "SNAPSHOT_ID");
 
 Review comment:
   Again this find and delete can be replaced with removeDetail()
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : 
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113936886
 
 

 ##
 File path: 
framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
 ##
 @@ -1012,6 +1018,22 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 s_logger.debug("Purge queue item for cancelled 
job-" + job.getId());
 }
 _queueMgr.purgeAsyncJobQueueItemId(job.getId());
+
+if(job.getInstanceType().equals("Volume")) {
+// todo perform decrement opreation on the ref 
count based on the volume and snapshot
 
 Review comment:
   Once the code is complete remove the TODO
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : 
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113931425
 
 

 ##
 File path: 
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
 ##
 @@ -2025,4 +2037,27 @@ public VolumeInfo 
updateHypervisorSnapshotReserveForVolume(DiskOffering diskOffe
 
 return volFactory.getVolume(volumeId);
 }
+
+/**
+ *  inserts volume,snapshot details
+ * @param volumeId
+ * @param snapsShotid
+ */
+public void insertVolumeDetailsVO(Long volumeId,Long snapsShotid)
 
 Review comment:
   What is the need for this method? There is already a method addDetail() in 
VolumeDetailsDaoImpl.java. I would suggest checking the existing code to see 
what all are already available before implementing something.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : 
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113930154
 
 

 ##
 File path: engine/schema/src/com/cloud/storage/VolumeDetailVO.java
 ##
 @@ -80,4 +80,23 @@ public boolean isDisplay() {
 return display;
 }
 
+public void setId(long id) {
 
 Review comment:
   Why these setters are needed? There is already a ctor which takes all the 
parameters.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : 
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113935048
 
 

 ##
 File path: 
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
 ##
 @@ -155,6 +159,12 @@
 @Inject
 private ClusterDao clusterDao;
 
+@Inject
+private SnapshotDetailsDao _snapshotDetailsDao;
 
 Review comment:
   Is the snapshotdetailsdao needed?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 : 
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113936161
 
 

 ##
 File path: 
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
 ##
 @@ -1214,7 +1224,9 @@ protected Void 
createVolumeFromSnapshotCallback(AsyncCallbackDispatcher

Re: Github messages on dev list

2017-04-28 Thread Nicolas Vazquez

I personally prefer the way it worked before, where Github username was
shown in From field and not in Subject. That way mails could be grouped by
PR

2017-04-28 8:08 GMT-03:00 Will Stevens :

> I would be +1 for moving them to commits@.
>
> In the current implementation, I find it is not nearly as useful at a
> glance. The info I care about (PR number and user) are not visible when I
> scroll through the list. Ideally we could change the subject format to move
> the important info to the start of the message.
>
> Something like:
> Git #2062 (swill): whatever message about...
>
> On Apr 28, 2017 4:24 AM, "Rene Moser"  wrote:
>
> > Hi Wido
> >
> > There have been messages from github in the past (you probably had a
> > filter?). I already wrote I don't like it and suggested to use
> > comm...@cloudstack.apache.org for automated and bot messages.
> >
> > But a few devs insisted they like to keep them here that filtering would
> > be an option (for all others). So I created a filter (although I still
> > thing my suggestion would be the cleaner solution). The filter is not
> > matching anymore, I also have to adjust it.
> >
> > I am still +1 for moving them to commits@ and whoever needs them can
> > subscribe to this list. Opt-In.
> >
> > René
> >
> > On 04/28/2017 08:28 AM, Wido den Hollander wrote:
> > > Hi,
> > >
> > > See: https://issues.apache.org/jira/browse/INFRA-13929
> > >
> > > We are now getting all these messages from Github on
> > dev@cloudstack.apache.org
> > >
> > > We didn't have this before. Do we want this?
> > >
> > > Personally I find it very annoying that my inbox now gets so many
> > messages from Github.
> > >
> > > Anybody else feeling that way?
> > >
> > > Wido
> > >
> >
>

[GitHub] blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-28 Thread git

blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN 
drops
URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297977466
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-28 Thread git

borisstoyanov commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN 
drops
URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297977456
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2017-04-28 Thread git

DaanHoogland commented on a change in pull request #1302: CLOUDSTACK-9104: VM 
naming convention in case vmware is used
URL: https://github.com/apache/cloudstack/pull/1302#discussion_r113908318
 
 

 ##
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##
 @@ -3383,12 +3383,6 @@ protected UserVm createVirtualMachine(DataCenter zone, 
ServiceOffering serviceOf
 hostName = generateHostName(uuidName);
 }
 }
-// If global config vm.instancename.flag is set to true, then CS 
will set guest VM's name as it appears on the hypervisor, to its hostname.
-// In case of VMware since VM name must be unique within a DC, 
check if VM with the same hostname already exists in the zone.
 
 Review comment:
   are those not allowed (in different domains/accounts)?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2017-04-28 Thread git

DaanHoogland commented on a change in pull request #1302: CLOUDSTACK-9104: VM 
naming convention in case vmware is used
URL: https://github.com/apache/cloudstack/pull/1302#discussion_r113907617
 
 

 ##
 File path: 
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
 ##
 @@ -404,4 +410,46 @@ public void testConfigNestedHVSupportFlagFalse() throws 
Exception{
 verify(vmMo, never()).getRunningHost();
 }
 
+@Test
+public  void  testComposeVmNames() throws Exception{
 
 Review comment:
   i agree, let's test as little as possible per test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2017-04-28 Thread git

DaanHoogland commented on a change in pull request #1302: CLOUDSTACK-9104: VM 
naming convention in case vmware is used
URL: https://github.com/apache/cloudstack/pull/1302#discussion_r113907545
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -2226,13 +2227,30 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
throws CloudRuntimeException {
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec == null) {
+throw new CloudRuntimeException("vmSpec is null");
 }
+
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag && vmSpec.getType() == VirtualMachine.Type.User) 
{
+   String[] tokens = vmInternalCSName.split("-");
+   if(tokens.length<3) throw new 
InvalidParameterValueException("Invalid vmInternalCSName format: 
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); // 
vmInternalCSName has format i-x-y-
+  vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0], 
tokens[1], tokens[2], vmSpec.getHostName());
 
 Review comment:
   @rhtyd I don't mind "null" in a name as long as the name is not null or 
duplicate. (see your comment further on)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-28 Thread git

blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN 
drops
URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297972707
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-28 Thread git

borisstoyanov commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN 
drops
URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297972556
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Github messages on dev list

2017-04-28 Thread Will Stevens

I would be +1 for moving them to commits@.

In the current implementation, I find it is not nearly as useful at a
glance. The info I care about (PR number and user) are not visible when I
scroll through the list. Ideally we could change the subject format to move
the important info to the start of the message.

Something like:
Git #2062 (swill): whatever message about...

On Apr 28, 2017 4:24 AM, "Rene Moser"  wrote:

> Hi Wido
>
> There have been messages from github in the past (you probably had a
> filter?). I already wrote I don't like it and suggested to use
> comm...@cloudstack.apache.org for automated and bot messages.
>
> But a few devs insisted they like to keep them here that filtering would
> be an option (for all others). So I created a filter (although I still
> thing my suggestion would be the cleaner solution). The filter is not
> matching anymore, I also have to adjust it.
>
> I am still +1 for moving them to commits@ and whoever needs them can
> subscribe to this list. Opt-In.
>
> René
>
> On 04/28/2017 08:28 AM, Wido den Hollander wrote:
> > Hi,
> >
> > See: https://issues.apache.org/jira/browse/INFRA-13929
> >
> > We are now getting all these messages from Github on
> dev@cloudstack.apache.org
> >
> > We didn't have this before. Do we want this?
> >
> > Personally I find it very annoying that my inbox now gets so many
> messages from Github.
> >
> > Anybody else feeling that way?
> >
> > Wido
> >
>

[GitHub] pavanaravapalli opened a new pull request #2072: WIP: CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume snapshot

2017-04-28 Thread git

pavanaravapalli opened a new pull request #2072: WIP: CLOUDSTACK-9895 : Added 
support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-28 Thread git

rhtyd commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix 
test_deploy_virtio_scsi_vm.py
URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297950110
 
 
   LGTM.
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-04-28 Thread git

blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added  exit status 
checking for the iptables commands
URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-297949836
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-04-28 Thread git

rhtyd commented on issue #2018: CLOUDSTACK-9848: Added  exit status checking 
for the iptables commands
URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-297949754
 
 
   It might be regressions due to the change, I can help rekick them.
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2017-04-28 Thread git

rhtyd commented on issue #1302: CLOUDSTACK-9104: VM naming convention in case 
vmware is used
URL: https://github.com/apache/cloudstack/pull/1302#issuecomment-297949612
 
 
   @abhinandanprateek @DaanHoogland -- ping for review?
   @PaulAngus would you like to share your thoughts in changing VM naming 
convention for vmware?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2017-04-28 Thread git

rhtyd commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming 
convention in case vmware is used
URL: https://github.com/apache/cloudstack/pull/1302#discussion_r113886159
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -2226,13 +2227,30 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
throws CloudRuntimeException {
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec == null) {
+throw new CloudRuntimeException("vmSpec is null");
 }
+
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag && vmSpec.getType() == VirtualMachine.Type.User) 
{
+   String[] tokens = vmInternalCSName.split("-");
+   if(tokens.length<3) throw new 
InvalidParameterValueException("Invalid vmInternalCSName format: 
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); // 
vmInternalCSName has format i-x-y-
+  vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0], 
tokens[1], tokens[2], vmSpec.getHostName());
 
 Review comment:
   Should we validate here that tokens items are not null or empty; or we might 
get a vm name that has null in its name?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2017-04-28 Thread git

rhtyd commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming 
convention in case vmware is used
URL: https://github.com/apache/cloudstack/pull/1302#discussion_r113885986
 
 

 ##
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##
 @@ -3383,12 +3383,6 @@ protected UserVm createVirtualMachine(DataCenter zone, 
ServiceOffering serviceOf
 hostName = generateHostName(uuidName);
 }
 }
-// If global config vm.instancename.flag is set to true, then CS 
will set guest VM's name as it appears on the hypervisor, to its hostname.
-// In case of VMware since VM name must be unique within a DC, 
check if VM with the same hostname already exists in the zone.
 
 Review comment:
   Instead of removing the check, does it make sense to amend it to verify that 
with the updated naming convention -- there are no duplicate VMs by name?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2017-04-28 Thread git

rhtyd commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming 
convention in case vmware is used
URL: https://github.com/apache/cloudstack/pull/1302#discussion_r113885728
 
 

 ##
 File path: 
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
 ##
 @@ -404,4 +410,46 @@ public void testConfigNestedHVSupportFlagFalse() throws 
Exception{
 verify(vmMo, never()).getRunningHost();
 }
 
+@Test
+public  void  testComposeVmNames() throws Exception{
 
 Review comment:
   @priyankparihar please split the tests into multiple case methods, it's 
easier to debug failures.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Github messages on dev list

2017-04-28 Thread Rene Moser

Hi Wido

There have been messages from github in the past (you probably had a
filter?). I already wrote I don't like it and suggested to use
comm...@cloudstack.apache.org for automated and bot messages.

But a few devs insisted they like to keep them here that filtering would
be an option (for all others). So I created a filter (although I still
thing my suggestion would be the cleaner solution). The filter is not
matching anymore, I also have to adjust it.

I am still +1 for moving them to commits@ and whoever needs them can
subscribe to this list. Opt-In.

René

On 04/28/2017 08:28 AM, Wido den Hollander wrote:
> Hi,
> 
> See: https://issues.apache.org/jira/browse/INFRA-13929
> 
> We are now getting all these messages from Github on dev@cloudstack.apache.org
> 
> We didn't have this before. Do we want this?
> 
> Personally I find it very annoying that my inbox now gets so many messages 
> from Github.
> 
> Anybody else feeling that way?
> 
> Wido
>

[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location

2017-04-28 Thread git

DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more 
generic location
URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297930758
 
 
   the virtio failures are addressed in #2066. still needs a 'this reads like 
poetry to me"
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location

2017-04-28 Thread git

DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more 
generic location
URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297927230
 
 
   @rafaelweingartner I don't like to. Is this :-1: worth? Can of worms 
involved.
   
   There is a lot more service definitions to take into account when we do that 
move. We can but it is to much change for the scope of this one and only if we 
move all will it serve it purpose. Also this as is might be a breaking change 
so, though I need it I would like to keep it as small as possible. Of course 
happy to discuss if this is
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more generic location

2017-04-28 Thread git

DaanHoogland commented on issue #2071: CLOUDSTACK-9815 move CertService to more 
generic location
URL: https://github.com/apache/cloudstack/pull/2071#issuecomment-297927230
 
 
   @rafaelweingartner I don't like to. Is this :-1: worth? Can of worms 
involved.
   
   There is a lot more service definitions to take into account when we do that 
move. We can but it is to much change for the scope of this one and only if we 
move all will it serve it purpose. Also this as is might be a breaking change 
so, though I need it I would like to keep it as small as possible. Of course 
happy to discuss if this is
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Github messages on dev list

2017-04-28 Thread Boris Stoyanov

+1, 

I like the way it was showing who made the comment in FROM field, now just 
shows git at github dot com.
Is there a way we can change this setting? 

Thanks,
Boris Stoyanov

boris.stoya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

> On Apr 28, 2017, at 9:28 AM, Wido den Hollander  wrote:
> 
> Hi,
> 
> See: https://issues.apache.org/jira/browse/INFRA-13929
> 
> We are now getting all these messages from Github on dev@cloudstack.apache.org
> 
> We didn't have this before. Do we want this?
> 
> Personally I find it very annoying that my inbox now gets so many messages 
> from Github.
> 
> Anybody else feeling that way?
> 
> Wido

[GitHub] nitin-maharana commented on issue #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type

2017-04-28 Thread git

nitin-maharana commented on issue #868: CLOUDSTACK-8894: Restrict vGPU enabled 
VMs dynamic scaling if new service offering has different vGPU type
URL: https://github.com/apache/cloudstack/pull/868#issuecomment-297916819
 
 
   Code LGTM.
   
   Just curious to know, Do we support upgrading/downgrading the stopped VM 
with different vgpuTypes on both XS and VMware.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on issue #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type

2017-04-28 Thread git

nitin-maharana commented on issue #868: CLOUDSTACK-8894: Restrict vGPU enabled 
VMs dynamic scaling if new service offering has different vGPU type
URL: https://github.com/apache/cloudstack/pull/868#issuecomment-297916819
 
 
   Code LGTM.
   
   Just curious to know, Do we support the scaling on stopped VM with different 
vgpuTypes.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Github messages on dev list

2017-04-28 Thread Wido den Hollander

Hi,

See: https://issues.apache.org/jira/browse/INFRA-13929

We are now getting all these messages from Github on dev@cloudstack.apache.org

We didn't have this before. Do we want this?

Personally I find it very annoying that my inbox now gets so many messages from 
Github.

Anybody else feeling that way?

Wido

[GitHub] nitin-maharana commented on a change in pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type

2017-04-28 Thread git

nitin-maharana commented on a change in pull request #868: CLOUDSTACK-8894: 
Restrict vGPU enabled VMs dynamic scaling if new service offering has different 
vGPU type
URL: https://github.com/apache/cloudstack/pull/868#discussion_r113858287
 
 

 ##
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##
 @@ -1661,6 +1661,19 @@ private boolean upgradeRunningVirtualMachine(Long vmId, 
Long newServiceOfferingI
 + ",memory=," + currentMemory + ")");
 }
 
+_offeringDao.loadDetails(currentServiceOffering);
 
 Review comment:
   For a bit of improvement, before loading, we can check if the value is 
already loaded then we can skip this, else load it. Something like this.
   
   if(currentServiceOffering.getDetails() == null) {
   _offeringDao.loadDetails(currentServiceOffering);
   }
   
   Same for newServiceOffering.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on issue #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type

2017-04-28 Thread git

nitin-maharana commented on issue #868: CLOUDSTACK-8894: Restrict vGPU enabled 
VMs dynamic scaling if new service offering has different vGPU type
URL: https://github.com/apache/cloudstack/pull/868#issuecomment-297916819
 
 
   Code LGTM.
   
   Just curious to know, Do we support the scaling on stopped VM with different 
vgpuTypes.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sureshanaparti commented on a change in pull request #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS

2017-04-28 Thread git

sureshanaparti commented on a change in pull request #1872: CLOUDSTACK-3223 
Exception observed while creating CPVM in VMware Setup with DVS
URL: https://github.com/apache/cloudstack/pull/1872#discussion_r113858258
 
 

 ##
 File path: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java
 ##
 @@ -36,24 +37,67 @@
 public class DistributedVirtualSwitchMO extends BaseMO {
 @SuppressWarnings("unused")
 private static final Logger s_logger = 
Logger.getLogger(DistributedVirtualSwitchMO.class);
+private static ConcurrentHashMap 
s_dvPortGroupCacheMap = null;
 
 public DistributedVirtualSwitchMO(VmwareContext context, 
ManagedObjectReference morDvs) {
 super(context, morDvs);
+s_dvPortGroupCacheMap = new ConcurrentHashMap();
 }
 
 public DistributedVirtualSwitchMO(VmwareContext context, String morType, 
String morValue) {
 super(context, morType, morValue);
+s_dvPortGroupCacheMap = new ConcurrentHashMap();
 }
 
 public void createDVPortGroup(DVPortgroupConfigSpec dvPortGroupSpec) 
throws Exception {
 List dvPortGroupSpecArray = new 
ArrayList();
 dvPortGroupSpecArray.add(dvPortGroupSpec);
-_context.getService().addDVPortgroupTask(_mor, dvPortGroupSpecArray);
+boolean dvPortGroupExists = false;
+String dvSwitchInstance = _mor.getValue();
+String dvPortGroupName = dvPortGroupSpec.getName();
+String uniquedvPortGroupPerDvs = dvSwitchInstance + dvPortGroupName;
+List dvPortGroupList = null;
+synchronized (uniquedvPortGroupPerDvs.intern()) {
+// Looking up local cache rather than firing another API call to 
see if dvPortGroup exists already.
+if (s_dvPortGroupCacheMap.containsKey(dvSwitchInstance)) {
+dvPortGroupList = s_dvPortGroupCacheMap.get(dvSwitchInstance);
+if (dvPortGroupList != null && 
dvPortGroupList.contains(dvPortGroupName)) {
+dvPortGroupExists = true;
+}
+}
+if (!dvPortGroupExists) {
+ManagedObjectReference task = 
_context.getService().addDVPortgroupTask(_mor, dvPortGroupSpecArray);
+if (!_context.getVimClient().waitForTask(task)) {
+throw new Exception("Failed to create dvPortGroup " + 
dvPortGroupSpec.getName());
+} else {
+if (s_dvPortGroupCacheMap.containsKey(dvSwitchInstance)) {
+dvPortGroupList = 
s_dvPortGroupCacheMap.get(dvSwitchInstance);
+if (dvPortGroupList == null) {
+dvPortGroupList = new ArrayList();
+}
+dvPortGroupList.add(dvPortGroupName); //does this 
update map?
 
 Review comment:
   @sateesh-chodapuneedi `s_dvPortGroupCacheMap` update required here?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Reg: Permissions for JIRA and CWIKI

2017-04-28 Thread Rajani Karuturi

Done

~ Rajani

http://cloudplatform.accelerite.com/

On April 27, 2017 at 3:47 PM, Harika Punna
(harika_pu...@persistent.com) wrote:

Hi,

I am Harika, working on the improvement "CLOUDSTACK-9894", need
permissions on Jira(for ticket assignment) and cwiki(for creating
FS for the improvement).

Username for JIRA: HarikaPunna
Username for cwiki: harika.punna

Thanks,
Harika.

DISCLAIMER
==
This e-mail may contain privileged and confidential information
which is the property of Persistent Systems Ltd. It is intended
only for the use of the individual or entity to which it is
addressed. If you are not the intended recipient, you are not
authorized to read, retain, copy, print, distribute or use this
message. If you have received this communication in error, please
notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus
infected mails.

Re: Reg : Permission for Jira

2017-04-28 Thread Rajani Karuturi

done.

~ Rajani

http://cloudplatform.accelerite.com/

On April 27, 2017 at 3:56 PM, Pavan Kumar Aravapalli
(pavankuma...@accelerite.com) wrote:

Hi,

This is Pavan Aravapalli, I am working for Accelerite. I would
like to contribute for Cloud Stack. Please grant permission for
the Jira, so that I can create and assign ticket to myself.

Jira Username: pavan4smile

Thanks & Regards
Pavan Kumar Aravapalli.

DISCLAIMER
==
This e-mail may contain privileged and confidential information
which is the property of Accelerite, a Persistent Systems
business. It is intended only for the use of the individual or
entity to which it is addressed. If you are not the intended
recipient, you are not authorized to read, retain, copy, print,
distribute or use this message. If you have received this
communication in error, please notify the sender and delete all
copies of this message. Accelerite, a Persistent Systems business
does not accept any liability for virus infected mails.

46 matches

Mail list logo