[GitHub] [cloudstack-documentation] PaulAngus commented on a change in pull request #131: Relnotes 414 pa

[GitBox]

PaulAngus commented on a change in pull request #131:
URL: 
https://github.com/apache/cloudstack-documentation/pull/131#discussion_r432576698



##
File path: source/releasenotes/about.rst
##
@@ -33,29 +34,41 @@ Apache CloudStack |release| is a |version| LTS release with 
over 15 major new fe
 •  Enable additional configuration metadata to virtual machines
 
 
-The full list of new features can be found in the project release notes at 
http://docs.cloudstack.apache.org/en/4.14.0.0/releasenotes/changes.html
+The full list of new features can be found in the project release notes at
+http://docs.cloudstack.apache.org/en/4.14.0.0/releasenotes/changes.html
 
-.. note:: 
+.. important::
This version of CloudStack allows control over the visibility of the DNS 
services provided
-   by the Virtual Router. One can control whether the service on the routers 
be available to 
-   networks outside the local network. This might be important on Shared 
Networks which are 
-   using Internet routable/public (i.e. non-RFC 1918) IP addresses. The new 
global setting 
-   "expose.dns.externally" has been added with a default value of "true" in 
order to keep backward compatibility
-   with the previous installations. If you wish to disable public access to 
the DNS services
-   running on Virtual Router, set the value to "false" and recreate the 
related Virtual Routers.
+   by the Virtual Router in Shared networks. By default CloudStack allows DNS 
queries via the
+   Guest interface from any IP address. This allows for the DNS resolution of 
guest VMs on the
+   Shared network by services outside of the shared network. While this can be 
useful, it can
+   also be an issue on Shared Networks which are using Internet 
routable/public (i.e. non-RFC1918)
+   IP addresses as the DNS service is then queriable from the public internet 
at large. A new
+   global setting "expose.dns.externally" has been added (with a default value 
of "true" in
+   order to keep backward compatibility) which limits the source of DNS 
queries to hosts on the

Review comment:
   Yes, I see your point, i've reworded to be clearer.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd closed pull request #366: dummy testing

[GitBox]

rhtyd closed pull request #366:
URL: https://github.com/apache/cloudstack-primate/pull/366


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #131: Relnotes 414 pa

[GitBox]

andrijapanicsb commented on a change in pull request #131:
URL: 
https://github.com/apache/cloudstack-documentation/pull/131#discussion_r432540605



##
File path: source/releasenotes/about.rst
##
@@ -33,29 +34,41 @@ Apache CloudStack |release| is a |version| LTS release with 
over 15 major new fe
 •  Enable additional configuration metadata to virtual machines
 
 
-The full list of new features can be found in the project release notes at 
http://docs.cloudstack.apache.org/en/4.14.0.0/releasenotes/changes.html
+The full list of new features can be found in the project release notes at
+http://docs.cloudstack.apache.org/en/4.14.0.0/releasenotes/changes.html
 
-.. note:: 
+.. important::
This version of CloudStack allows control over the visibility of the DNS 
services provided
-   by the Virtual Router. One can control whether the service on the routers 
be available to 
-   networks outside the local network. This might be important on Shared 
Networks which are 
-   using Internet routable/public (i.e. non-RFC 1918) IP addresses. The new 
global setting 
-   "expose.dns.externally" has been added with a default value of "true" in 
order to keep backward compatibility
-   with the previous installations. If you wish to disable public access to 
the DNS services
-   running on Virtual Router, set the value to "false" and recreate the 
related Virtual Routers.
+   by the Virtual Router in Shared networks. By default CloudStack allows DNS 
queries via the
+   Guest interface from any IP address. This allows for the DNS resolution of 
guest VMs on the
+   Shared network by services outside of the shared network. While this can be 
useful, it can
+   also be an issue on Shared Networks which are using Internet 
routable/public (i.e. non-RFC1918)
+   IP addresses as the DNS service is then queriable from the public internet 
at large. A new
+   global setting "expose.dns.externally" has been added (with a default value 
of "true" in
+   order to keep backward compatibility) which limits the source of DNS 
queries to hosts on the

Review comment:
   ```suggestion
  order to keep backward compatibility) which does not limit the source of 
DNS queries to hosts on the
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #131: Relnotes 414 pa

[GitBox]

andrijapanicsb commented on a change in pull request #131:
URL: 
https://github.com/apache/cloudstack-documentation/pull/131#discussion_r432540605



##
File path: source/releasenotes/about.rst
##
@@ -33,29 +34,41 @@ Apache CloudStack |release| is a |version| LTS release with 
over 15 major new fe
 •  Enable additional configuration metadata to virtual machines
 
 
-The full list of new features can be found in the project release notes at 
http://docs.cloudstack.apache.org/en/4.14.0.0/releasenotes/changes.html
+The full list of new features can be found in the project release notes at
+http://docs.cloudstack.apache.org/en/4.14.0.0/releasenotes/changes.html
 
-.. note:: 
+.. important::
This version of CloudStack allows control over the visibility of the DNS 
services provided
-   by the Virtual Router. One can control whether the service on the routers 
be available to 
-   networks outside the local network. This might be important on Shared 
Networks which are 
-   using Internet routable/public (i.e. non-RFC 1918) IP addresses. The new 
global setting 
-   "expose.dns.externally" has been added with a default value of "true" in 
order to keep backward compatibility
-   with the previous installations. If you wish to disable public access to 
the DNS services
-   running on Virtual Router, set the value to "false" and recreate the 
related Virtual Routers.
+   by the Virtual Router in Shared networks. By default CloudStack allows DNS 
queries via the
+   Guest interface from any IP address. This allows for the DNS resolution of 
guest VMs on the
+   Shared network by services outside of the shared network. While this can be 
useful, it can
+   also be an issue on Shared Networks which are using Internet 
routable/public (i.e. non-RFC1918)
+   IP addresses as the DNS service is then queriable from the public internet 
at large. A new
+   global setting "expose.dns.externally" has been added (with a default value 
of "true" in
+   order to keep backward compatibility) which limits the source of DNS 
queries to hosts on the

Review comment:
   ```suggestion
  order to keep backward compatibility) which does not limits the source of 
DNS queries to hosts on the
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #131: Relnotes 414 pa

[GitBox]

andrijapanicsb commented on pull request #131:
URL: 
https://github.com/apache/cloudstack-documentation/pull/131#issuecomment-636015258


   I like the green colour though...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] andrijapanicsb closed pull request #131: Relnotes 414 pa

[GitBox]

andrijapanicsb closed pull request #131:
URL: https://github.com/apache/cloudstack-documentation/pull/131


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] PaulAngus opened a new pull request #131: Relnotes 414 pa

[GitBox]

PaulAngus opened a new pull request #131:
URL: https://github.com/apache/cloudstack-documentation/pull/131


   improve information to external DNS note and reformat line widths.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] PaulAngus commented on a change in pull request #131: Relnotes 414 pa

[GitBox]

PaulAngus commented on a change in pull request #131:
URL: 
https://github.com/apache/cloudstack-documentation/pull/131#discussion_r432428325



##
File path: source/releasenotes/about.rst
##
@@ -17,7 +17,8 @@
 What's New in |release|
 ===
 
-Apache CloudStack |release| is a |version| LTS release with over 15 major new 
features, and over 200 enhancements and fixes since 4.13.  Highlights include:
+Apache CloudStack |release| is a |version| LTS release with over 15 major new 
features, and
+over 200 enhancements and fixes since 4.13.  Highlights include:

Review comment:
   I restructured the entire documentation set; I'm fully aware that a new 
line at c.80 characters does not make any difference to the final  output.  
However, we have a 'standard', so realigned the text while adding some 
explanation.
   
   Is this a LGTM against the actual content?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] PaulAngus commented on a change in pull request #131: Relnotes 414 pa

[GitBox]

PaulAngus commented on a change in pull request #131:
URL: 
https://github.com/apache/cloudstack-documentation/pull/131#discussion_r432428325



##
File path: source/releasenotes/about.rst
##
@@ -17,7 +17,8 @@
 What's New in |release|
 ===
 
-Apache CloudStack |release| is a |version| LTS release with over 15 major new 
features, and over 200 enhancements and fixes since 4.13.  Highlights include:
+Apache CloudStack |release| is a |version| LTS release with over 15 major new 
features, and
+over 200 enhancements and fixes since 4.13.  Highlights include:

Review comment:
   I restructured the entire documentation set; I'm fully aware that a new 
line at c.80 characters does not make any difference to the final  output.  
However, we have a 'standard', so realigned the text while adding some 
explanation.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #131: Relnotes 414 pa

[GitBox]

andrijapanicsb commented on a change in pull request #131:
URL: 
https://github.com/apache/cloudstack-documentation/pull/131#discussion_r432426598



##
File path: source/releasenotes/about.rst
##
@@ -17,7 +17,8 @@
 What's New in |release|
 ===
 
-Apache CloudStack |release| is a |version| LTS release with over 15 major new 
features, and over 200 enhancements and fixes since 4.13.  Highlights include:
+Apache CloudStack |release| is a |version| LTS release with over 15 major new 
features, and
+over 200 enhancements and fixes since 4.13.  Highlights include:

Review comment:
   Any line break/making those shorter in source docs will NOT affect the 
output - it's identical, but it doesn't hurt to make it beautiful.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

RE: [ Proposal ] Managing CloudStack Load Balancer configuration

[Paul Angus]

This looks great @Wei Zhou do you have a timeline for when you think a PR will 
appear?

As probably a discussion thread for after this is in, do we think that there is 
mileage in allowing a user to upload their own haproxy config? There would have 
to be a binary 'cloudstack controlled config file' vs 'user controlled config 
file' switch somewhere, but then power users could tinker all they liked with 
the haproxy config, and CloudStack can stick to orchestrating relatively simple 
configurations ??

Kind regards


Paul.



paul.an...@shapeblue.com 
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue
  
 


-Original Message-
From: Wei ZHOU  
Sent: 06 May 2020 08:38
To: dev@cloudstack.apache.org
Subject: Re: [ Proposal ] Managing CloudStack Load Balancer configuration

cool, Thanks Liridon and Gregor.
We will take them into consideration.

-Wei


On Tue, 5 May 2020 at 15:12, Ismaili, Liridon (SWISS TXT) < 
liridon.isma...@swisstxt.ch> wrote:

> Hi Wei,
>
> That's some great improvements to the HAProxy! We couldn't realize 
> some projects because of the missing features on the HAProxy therefore 
> we are happy to hear that there will be some improvements.
> As an addition to the proposal of you we would like to see the 
> possibility to separate timeout settings (client/server/connect/...) 
> as these timeout can be different.
> We would also like to have the timeout settings available under the 
> LoadbalancerRule
>
> as a summary:
> - Separate options for all timeout parameters 
> (client/server/connect/...)
> - Timeouts also per LoadbalancerRule, not only Network
>
> We also thought about some "nice to have" additions:
> - check customization: HTTP Check, Check Interval, etc.
> - LoadbalancerRule: Custom Server string & Custom Listen string (only 
> Domain Admin)
> - Network: Custom Defaults (only Domain Admin)
>
> Please let me know what you think about these additions.
>
> Best Regards
> Liridon
>
> -Original Message-
> From: "Riepl, Gregor (SWISS TXT)"  %22Riepl,%20Gregor%20%28SWISS%20TXT%29%22%20%3cGregor.Riepl@swisstxt.c
> h
> %3e>>
> Reply-To: dev@cloudstack.apache.org
> To: dev@cloudstack.apache.org  22...@cloudstack.apache.org%22%20%3c...@cloudstack.apache.org%3e>>
> Subject: Re: [ Proposal ] Managing CloudStack Load Balancer 
> configuration
> Date: Mon, 04 May 2020 10:22:39 +
>
>
> Hi Wei,
>
>
> Thank you for this proposal!
>
> We are also very much interested in this feature.
>
>
> There's a few things we're not quite happy with, though - but we still 
> need to discuss this internally a bit.
>
> Liridon or myself will give some feedback soon.
>
>
> Regards,
>
> Gregor
>
> 
>
> From: Wei ZHOU <
>
> 
>
> ustcweiz...@gmail.com
>
> >
>
> Sent: 01 May 2020 08:01
>
> To:
>
> 
>
> dev@cloudstack.apache.org
>
>  <
>
> 
>
> dev@cloudstack.apache.org
>
> >
>
> Subject: [ Proposal ] Managing CloudStack Load Balancer configuration
>
>
> Our improvements to cloudstack load balancer (implemented by HAproxy 
> in the
>
> VRs) allow cloudstack users to manage certain restricted configuration
>
> settings. With this feature, users can
>
>
> * Change basic configuration of HAproxy (e.g. set the amount of 
> allowed
>
> connections),
>
>
> * choose if load balancer is transparent,
>
>
> * enable or disable the support for SSL offloading in isolated networks.
>
>
> * choose if load balancer supports HTTP/2.
>
>
> * more settings.
>
>
>
>
> To make this possible to the user, we provide two forms on cloudstack 
> GUI
>
> (old GUI, will add changes on Primate) from which the settings can be
>
> managed and applied in virtual routers.
>
>
>
>
> FS can be found at
>
> <
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/VR+haproxy+cust
> omization+in+CloudStack
> >
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/VR+haproxy+cust
> omization+in+CloudStack
>
>
>
>
> Any suggestions ?
>
>
>
>
> Kind regards,
>
>
> *Wei Zhou*
>
>
> Principal Cloud Engineer
>
>
> Leaseweb Global B.V.
>

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #326: Form to Migrate data between Image stores

[GitBox]

blueorangutan commented on pull request #326:
URL: 
https://github.com/apache/cloudstack-primate/pull/326#issuecomment-635832279


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive. JID-1948



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org